)]}'
{"openstack_dashboard/dashboards/settings/user/forms.py":[{"author":{"_account_id":20766,"name":"Alexey Dushechkin","email":"alexey.dushechkin@gmail.com","username":"alexey.dushechkin"},"change_message_id":"b46b7bf2b3d015a7a7fbe41a51de2fbdb7187b82","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import datetime"},{"line_number":16,"context_line":"import string"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import babel"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_155eb211","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":15},"updated":"2016-02-29 12:01:20.000000000","message":"Should we really change the import affecting the unrelated line?","commit_id":"a195f393bcb71d5403d5902bb6b10c8239c24eac"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"a3da8dd2f2e5d09c5ed484d5760a054497bea6a4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import datetime"},{"line_number":16,"context_line":"import string"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import babel"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_701aac7e","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":15},"in_reply_to":"9aed3d3a_155eb211","updated":"2016-02-29 12:23:10.000000000","message":"No, this change need.\ntimedelta method is not datetime.datetime.timedelta but datetime.timedelta, so we need to change this line to import timedelta.","commit_id":"a195f393bcb71d5403d5902bb6b10c8239c24eac"},{"author":{"_account_id":20766,"name":"Alexey Dushechkin","email":"alexey.dushechkin@gmail.com","username":"alexey.dushechkin"},"change_message_id":"f2a7e1a8a48a98af377ecdfdfad95e47d806a985","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import datetime"},{"line_number":16,"context_line":"import string"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import babel"}],"source_content_type":"text/x-python","patch_set":1,"id":"9aed3d3a_ceeaef0e","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":15},"in_reply_to":"9aed3d3a_701aac7e","updated":"2016-02-29 15:21:36.000000000","message":"We also may use \"from datetime import datetime, timedelta  #noqa\" and use bare \"... + timedelta(days\u003d365)\" later on and leave line 55 in orig unchanged. Anyway, that\u0027s cosmetic, I won\u0027t insist on that.","commit_id":"a195f393bcb71d5403d5902bb6b10c8239c24eac"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"55c7eadb1af0b1fcaf60b62ae25887eaa1846e19","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        # Language"},{"line_number":101,"context_line":"        lang_code \u003d data[\u0027language\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        seconds_in_year \u003d 31557600  # leap year non compliant fwiw"},{"line_number":104,"context_line":"        if lang_code and translation.check_for_language(lang_code):"},{"line_number":105,"context_line":"            if hasattr(request, \u0027session\u0027):"},{"line_number":106,"context_line":"                request.session[\u0027django_language\u0027] \u003d lang_code"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_667655d8","line":103,"updated":"2016-02-29 21:21:01.000000000","message":"this deserves more information why are we hardcoding the seconds in a year instead of calculating.\n\nI\u0027m fine with the change, but this needs more documentation for maintenance purpose.","commit_id":"cce45e9a5bc5fa2a0041058cf0b771b2528c39df"}],"openstack_dashboard/dashboards/settings/user/tests.py":[{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"82642d25ce17f0600795ed1667b3f9b37b3c4d8e","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        # Unknown language"},{"line_number":44,"context_line":"        self.assertContains(res, \u0027Unknown Language\u0027)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def test_one_year(self):"},{"line_number":47,"context_line":"        now \u003d datetime.datetime.utcnow()"},{"line_number":48,"context_line":"        diff \u003d forms._one_year() - now"},{"line_number":49,"context_line":"        self.assertEqual(diff.days, 365)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_1fb23f06","line":46,"updated":"2016-02-29 15:51:25.000000000","message":"I would imagined a test, which exactly uses a situation like today, where we have a leap-day.\nyour test does exactly what your function in forms does; Unfortunately it does not test anything more like the functions triggering the bug.","commit_id":"6011759a81f1478d2b0cf0d6e5e49662e94347a9"}]}