)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"a3b3b4c86ceda46bb2fef968a790fee4310a8220","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2016-03-02 16:10:16 -0600"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add event broadcast to table row expansion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9db9053331a232149495d847351a71d62ce19bf9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7af24918_83708e73","line":8,"updated":"2016-03-04 00:13:27.000000000","message":"Need more description here. What is the problem that this patch is attempting to fix? Why is it needed? etc..","commit_id":"dee2ed5e98ae2c4de889c41492a18e3699b785e8"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"a3b3b4c86ceda46bb2fef968a790fee4310a8220","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add event broadcast to table row expansion"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9db9053331a232149495d847351a71d62ce19bf9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7af24918_e30232b3","line":9,"updated":"2016-03-04 00:13:27.000000000","message":"Link to the bug via \u0027Closes-Bug: #xyz\u0027 tag","commit_id":"dee2ed5e98ae2c4de889c41492a18e3699b785e8"}],"horizon/static/framework/widgets/table/hz-expand-detail.directive.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"a3b3b4c86ceda46bb2fef968a790fee4310a8220","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7af24918_e8a97125","updated":"2016-03-04 00:13:27.000000000","message":"I wonder if we even need to reference hzTable. Is it possible to just broadcast using the scope in hzExpandDetail? I suppose not considering that this is isolated scope and we are attempting to manipulate a tr sibling element. Just entertaining the idea.","commit_id":"dee2ed5e98ae2c4de889c41492a18e3699b785e8"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"bf24cdc5f1f678302de7accac3d8c9e98eb6b61b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      require: \u0027^hzTable\u0027,"},{"line_number":61,"context_line":"      scope: {"},{"line_number":62,"context_line":"        icons: \u0027@hzExpandDetail\u0027,"},{"line_number":63,"context_line":"        duration: \u0027@\u0027"},{"line_number":64,"context_line":"      },"},{"line_number":65,"context_line":"      link: link"},{"line_number":66,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":2,"id":"7af24918_d1237d54","line":63,"updated":"2016-03-04 03:08:22.000000000","message":"Should add an optional \u0027item\u0027 property to scope that tracks the model.","commit_id":"dee2ed5e98ae2c4de889c41492a18e3699b785e8"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a6311c00675c2a30c4ee6180b8e97a0929c093bb","unresolved":false,"context_lines":[{"line_number":60,"context_line":"      require: \u0027^hzTable\u0027,"},{"line_number":61,"context_line":"      scope: {"},{"line_number":62,"context_line":"        icons: \u0027@hzExpandDetail\u0027,"},{"line_number":63,"context_line":"        duration: \u0027@\u0027"},{"line_number":64,"context_line":"      },"},{"line_number":65,"context_line":"      link: link"},{"line_number":66,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_c0c1cee5","line":63,"in_reply_to":"7af24918_d1237d54","updated":"2016-03-10 21:18:46.000000000","message":"We should pass in \u0027item\u0027 into hzExpandDetail directive rather than using the summaryRow from below, since summaryRow is just HTML markup that isn\u0027t very useful (https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/table/images-table.html#L93-L140)\n\nIt would be more useful to have the item data.\n\nSo directive would be used like:\n\u003cspan hz-expand-detail item\u003d“image” duration\u003d“200\"\u003e\u003c/span\u003e\n\n\nThen L101 would be:\n\n\nhzTableCtrl.broadcastExpansion(scope.item);","commit_id":"dee2ed5e98ae2c4de889c41492a18e3699b785e8"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"bf24cdc5f1f678302de7accac3d8c9e98eb6b61b","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            detailCell.wrapInner(\u0027\u003cdiv class\u003d\"detail-expanded\"\u003e\u003c/div\u003e\u0027);"},{"line_number":99,"context_line":"          }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"          hzTableCtrl.broadcastExpansion(summaryRow);"},{"line_number":102,"context_line":"          detailCell.find(\u0027.detail-expanded\u0027).slideDown(duration);"},{"line_number":103,"context_line":"        }"},{"line_number":104,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":2,"id":"7af24918_7128a933","line":101,"updated":"2016-03-04 03:08:22.000000000","message":"Cleaner to pass the row data instead of the row element. There is not much we can do with the element as that is the presentation layer.","commit_id":"dee2ed5e98ae2c4de889c41492a18e3699b785e8"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"d5127c1f4659dbb575a630874218fc4ca7b69937","unresolved":false,"context_lines":[{"line_number":61,"context_line":"      scope: {"},{"line_number":62,"context_line":"        icons: \u0027@hzExpandDetail\u0027,"},{"line_number":63,"context_line":"        duration: \u0027@\u0027,"},{"line_number":64,"context_line":"        item: \u0027@\u0027"},{"line_number":65,"context_line":"      },"},{"line_number":66,"context_line":"      link: link"},{"line_number":67,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":4,"id":"3afc51ec_43d126cd","line":64,"updated":"2016-03-11 18:30:25.000000000","message":"should use \u0027\u003d\u0027\n\n@ is used for passing in strings","commit_id":"70a0b91fb9d1c2998c62c6459a6c2113925c6aef"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"98b8459359e6d642dd32065def10ad9c2801d36b","unresolved":false,"context_lines":[{"line_number":37,"context_line":"   * the classes \u0027detail-row\u0027 and \u0027detail\u0027, respectively."},{"line_number":38,"context_line":"   *"},{"line_number":39,"context_line":"   * @restrict A"},{"line_number":40,"context_line":"   * @scope icons: \u0027@hzExpandDetail\u0027, duration: \u0027@\u0027"},{"line_number":41,"context_line":"   * @example"},{"line_number":42,"context_line":"   *"},{"line_number":43,"context_line":"   * ```"}],"source_content_type":"text/javascript","patch_set":7,"id":"ba0121b8_85c8e5a9","line":40,"updated":"2016-03-30 17:52:54.000000000","message":"Could you please update the documentation with the new parameter, so it would become clear if it\u0027s a whole \u003ctr\u003e or something more granular?","commit_id":"cdbd8cdd4d30760519928a1e73e1c023f15e8be7"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"c69ba25ddd35ea23bdbae5e949db9a83a7ab2bda","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   * duration for the slide animation can be specified as well (default: 400)."},{"line_number":36,"context_line":"   * The detail drawer row and cell also needs to be implemented and include"},{"line_number":37,"context_line":"   * the classes \u0027detail-row\u0027 and \u0027detail\u0027, respectively. On expansion,"},{"line_number":38,"context_line":"   * the directive will broadcast a supplied item in the template."},{"line_number":39,"context_line":"   *"},{"line_number":40,"context_line":"   * @restrict A"},{"line_number":41,"context_line":"   * @scope icons: \u0027@hzExpandDetail\u0027, duration: \u0027@\u0027, item: \u0027\u003d\u0027"}],"source_content_type":"text/javascript","patch_set":8,"id":"ba0121b8_935d9d17","line":38,"updated":"2016-03-31 14:45:55.000000000","message":"a--\u003ethe\n\n\nin--\u003efrom","commit_id":"14fe033fcfb008ec0d92a30b9ab6d440a33a43a9"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"c69ba25ddd35ea23bdbae5e949db9a83a7ab2bda","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      scope: {"},{"line_number":64,"context_line":"        icons: \u0027@hzExpandDetail\u0027,"},{"line_number":65,"context_line":"        duration: \u0027@\u0027,"},{"line_number":66,"context_line":"        item: \u0027\u003d\u0027"},{"line_number":67,"context_line":"      },"},{"line_number":68,"context_line":"      link: link"},{"line_number":69,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":8,"id":"ba0121b8_533945d6","line":66,"updated":"2016-03-31 14:45:55.000000000","message":"We should either make this an optional attribute (item: \u0027\u003d?\u0027) or make changes to where it\u0027s used in all the table templates. Also, check for scope.item\u0027s existence before executing L105?\n\n\nDocumentation should be updated too.","commit_id":"14fe033fcfb008ec0d92a30b9ab6d440a33a43a9"}],"horizon/static/framework/widgets/table/table.controller.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"a3b3b4c86ceda46bb2fef968a790fee4310a8220","unresolved":false,"context_lines":[{"line_number":89,"context_line":"    }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    /*"},{"line_number":92,"context_line":"     * Toggle row expansion"},{"line_number":93,"context_line":"     */"},{"line_number":94,"context_line":"    function broadcastExpansion(summaryRow) {"},{"line_number":95,"context_line":"      var row \u003d {row: summaryRow};"}],"source_content_type":"text/javascript","patch_set":2,"id":"7af24918_c3e1f62b","line":92,"updated":"2016-03-04 00:13:27.000000000","message":"Broadcast row expansion is probably more appropriate. We should only trigger this event \u0027on expand\u0027. I don\u0027t think we care about \u0027on close\u0027 yet (at least I can\u0027t think of a scenario where we need this).","commit_id":"dee2ed5e98ae2c4de889c41492a18e3699b785e8"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"a3b3b4c86ceda46bb2fef968a790fee4310a8220","unresolved":false,"context_lines":[{"line_number":93,"context_line":"     */"},{"line_number":94,"context_line":"    function broadcastExpansion(summaryRow) {"},{"line_number":95,"context_line":"      var row \u003d {row: summaryRow};"},{"line_number":96,"context_line":"      $scope.$broadcast(\u0027hzTable:rowExpanded\u0027, row);"},{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":2,"id":"7af24918_233a5a99","line":96,"updated":"2016-03-04 00:13:27.000000000","message":"Why not just pass summaryRow directly? summaryRow can be rename to just \u0027row\u0027 or \u0027item\u0027.","commit_id":"dee2ed5e98ae2c4de889c41492a18e3699b785e8"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"a6311c00675c2a30c4ee6180b8e97a0929c093bb","unresolved":false,"context_lines":[{"line_number":93,"context_line":"     */"},{"line_number":94,"context_line":"    function broadcastExpansion(summaryRow) {"},{"line_number":95,"context_line":"      var row \u003d {row: summaryRow};"},{"line_number":96,"context_line":"      $scope.$broadcast(\u0027hzTable:rowExpanded\u0027, row);"},{"line_number":97,"context_line":"    }"},{"line_number":98,"context_line":"  }"},{"line_number":99,"context_line":"})();"}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_2bdb337d","line":96,"in_reply_to":"7af24918_233a5a99","updated":"2016-03-10 21:18:46.000000000","message":"function broadcastExpansion(item) {\n      $scope.$broadcast(\u0027hzTable:rowExpanded\u0027, item);\n}","commit_id":"dee2ed5e98ae2c4de889c41492a18e3699b785e8"}],"horizon/static/framework/widgets/table/table.mock.html":[{"author":{"_account_id":19450,"name":"David Cusatis","email":"dcusati@us.ibm.com","username":"davidcusatis1"},"change_message_id":"61d8d29203aa7699cb22524e9e99ed3031c35555","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  \u003ctbody\u003e"},{"line_number":10,"context_line":"    \u003ctr ng-repeat-start\u003d\"row in fakeData\"\u003e"},{"line_number":11,"context_line":"      \u003ctd\u003e\u003cinput type\u003d\"checkbox\" hz-select\u003d\"row\" ng-model\u003d\"tCtrl.selections[row.id].checked\"\u003e\u003c/td\u003e"},{"line_number":12,"context_line":"      \u003ctd\u003e\u003cspan class\u003d\"fa fa-chevron-right\" hz-expand-detail item\u003d\"row.animal\"\u003e\u003c/span\u003e\u003c/td\u003e"},{"line_number":13,"context_line":"      \u003ctd\u003e{{ row.animal }}\u003c/td\u003e"},{"line_number":14,"context_line":"    \u003c/tr\u003e"},{"line_number":15,"context_line":"    \u003ctr class\u003d\"detail-row\" ng-repeat-end\u003e"}],"source_content_type":"text/html","patch_set":11,"id":"9a061dce_b322fcb7","line":12,"updated":"2016-04-04 17:16:00.000000000","message":"I\u0027m thinking this may be the best, least intrusive solution for getting the test to pass. I could add this attribute manually in the test, then recompile this mock html in the test itself, but as this is an optional argument, this seemed to be the best approach to me. let me know if anyone disagrees.","commit_id":"0109d7462657bc2dfd4dd7d11dd7cbe6823e6cc8"}],"horizon/static/framework/widgets/table/table.spec.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"6d43e2f7728a6ad966bfc8135ef6319ff41ae077","unresolved":false,"context_lines":[{"line_number":250,"context_line":"      });"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"      it(\u0027should broadcast event when row is expanded\u0027, function(done){"},{"line_number":253,"context_line":"        spyOn.($scope, \u0027$broadcast\u0027).and.callThrough();"},{"line_number":254,"context_line":"        var expandIcon \u003d $element.find(\u0027.fa\u0027).first();"},{"line_number":255,"context_line":"        expandIcon.click();"},{"line_number":256,"context_line":"        expect($scope.$broadcast).toHaveBeenCalledWith(\u0027hzTable:rowExpanded\u0027);"}],"source_content_type":"text/javascript","patch_set":5,"id":"fa0719c6_d5c77943","line":253,"updated":"2016-03-22 00:27:48.000000000","message":"test did not pass. remove done from function parameters, the period after spyOn still gave error: \"Expected spy $broadcast to have been called...\"","commit_id":"134786f5bf55cd0ca910effb75bc910bc8fccf89"},{"author":{"_account_id":19450,"name":"David Cusatis","email":"dcusati@us.ibm.com","username":"davidcusatis1"},"change_message_id":"795b7c89eb0cfa9a203ec5ad1fea4b990b97738c","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        /*eslint-enable angular/timeout-service */"},{"line_number":250,"context_line":"      });"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"      it(\u0027should broadcast event when row is expanded\u0027, function() {"},{"line_number":253,"context_line":"        spyOn($scope, \u0027$broadcast\u0027);"},{"line_number":254,"context_line":"        var expandIcon \u003d $element.find(\u0027.fa\u0027).first();"},{"line_number":255,"context_line":"        expandIcon.click();"}],"source_content_type":"text/javascript","patch_set":10,"id":"ba0121b8_2ac36b58","line":252,"updated":"2016-03-31 17:59:07.000000000","message":"the conditional check for existence of scope.item is causing this to break now. I tried to add a line adding the attribute to the element, i.e. expandIcon.attr(\u0027item\u0027, \u0027q\u0027), but that didn\u0027t work. \n\ncan anyone point me in the right direction here? is there a better way to inject this attribute so jasmine knows about it earlier or something?","commit_id":"ea7815e0e0cd3af03aa98350fde1820246a8f94d"}]}
