)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"0311610a1266fe3e3db52dc5da59e285ecedea63","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"def update_pagination(entities, page_size, marker, sort_dir, sort_key,"},{"line_number":526,"context_line":"                      reversed_order):"},{"line_number":527,"context_line":"    has_more_data, has_prev_data \u003d False, False"},{"line_number":528,"context_line":"    if len(entities) \u003e page_size:"},{"line_number":529,"context_line":"        has_more_data \u003d True"},{"line_number":530,"context_line":"        entities.pop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_e78a291a","line":527,"updated":"2016-03-04 11:21:07.000000000","message":"has_more_data \u003dhas_prev_data \u003d False","commit_id":"61e1c8c92aeb35221aae3ebb1aa2e5655e8cac67"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"0dd05c8a18bf00d1fc08cf3ed48052e209241c23","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"def update_pagination(entities, page_size, marker, sort_dir, sort_key,"},{"line_number":526,"context_line":"                      reversed_order):"},{"line_number":527,"context_line":"    has_more_data, has_prev_data \u003d False, False"},{"line_number":528,"context_line":"    if len(entities) \u003e page_size:"},{"line_number":529,"context_line":"        has_more_data \u003d True"},{"line_number":530,"context_line":"        entities.pop()"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_cae294d4","line":527,"in_reply_to":"7af24918_e78a291a","updated":"2016-03-04 11:41:49.000000000","message":"Done","commit_id":"61e1c8c92aeb35221aae3ebb1aa2e5655e8cac67"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"0311610a1266fe3e3db52dc5da59e285ecedea63","unresolved":false,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"@memoized"},{"line_number":550,"context_line":"def flavor_list_paged(request, is_public\u003dTrue, get_extras\u003dFalse, marker\u003dNone,"},{"line_number":551,"context_line":"                      paginate\u003dFalse, sort_key\u003d\"id\", sort_dir\u003d\"desc\","},{"line_number":552,"context_line":"                      reversed_order\u003dFalse):"},{"line_number":553,"context_line":"    \"\"\"Get the list of available instance sizes (flavors).\"\"\""},{"line_number":554,"context_line":"    has_more_data \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_07847508","line":551,"updated":"2016-03-04 11:21:07.000000000","message":"Shouldn\u0027t we sort by name? Makes more sense to me and more user friendly","commit_id":"61e1c8c92aeb35221aae3ebb1aa2e5655e8cac67"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"0dd05c8a18bf00d1fc08cf3ed48052e209241c23","unresolved":false,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"@memoized"},{"line_number":550,"context_line":"def flavor_list_paged(request, is_public\u003dTrue, get_extras\u003dFalse, marker\u003dNone,"},{"line_number":551,"context_line":"                      paginate\u003dFalse, sort_key\u003d\"id\", sort_dir\u003d\"desc\","},{"line_number":552,"context_line":"                      reversed_order\u003dFalse):"},{"line_number":553,"context_line":"    \"\"\"Get the list of available instance sizes (flavors).\"\"\""},{"line_number":554,"context_line":"    has_more_data \u003d False"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_8a71ac0e","line":551,"in_reply_to":"7af24918_07847508","updated":"2016-03-04 11:41:49.000000000","message":"Done","commit_id":"61e1c8c92aeb35221aae3ebb1aa2e5655e8cac67"}],"openstack_dashboard/dashboards/admin/flavors/tests.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"108bc2f2ba166d70d557a7ce4d2846340f315f97","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @django.test.utils.override_settings(API_RESULT_PAGE_SIZE\u003d1)"},{"line_number":46,"context_line":"    @test.create_stubs({api.nova: (\u0027flavor_list_paged\u0027,),"},{"line_number":47,"context_line":"                        flavors.Flavor: (\u0027get_keys\u0027,), })"},{"line_number":48,"context_line":"    def test_index_form_action_with_pagination(self):"},{"line_number":49,"context_line":"        page_size \u003d getattr(settings, \u0027API_RESULT_PAGE_SIZE\u0027, 1)"},{"line_number":50,"context_line":"        flavors_list \u003d self.flavors.list()[:2]"},{"line_number":51,"context_line":"        api.nova.flavor_list_paged(IsA(http.HttpRequest), None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_9833adf6","line":48,"updated":"2016-03-04 19:08:40.000000000","message":"we don\u0027t test the prev pagination anywhere.  can we add some test cases in for that?\n\nsomething like: https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/admin/images/tests.py#L135","commit_id":"181490487b0172b25cfa8ba51771c7a1a3128238"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"8edeb3c7161d79e9527310c34a923a503d714c39","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @django.test.utils.override_settings(API_RESULT_PAGE_SIZE\u003d1)"},{"line_number":46,"context_line":"    @test.create_stubs({api.nova: (\u0027flavor_list_paged\u0027,),"},{"line_number":47,"context_line":"                        flavors.Flavor: (\u0027get_keys\u0027,), })"},{"line_number":48,"context_line":"    def test_index_form_action_with_pagination(self):"},{"line_number":49,"context_line":"        page_size \u003d getattr(settings, \u0027API_RESULT_PAGE_SIZE\u0027, 1)"},{"line_number":50,"context_line":"        flavors_list \u003d self.flavors.list()[:2]"},{"line_number":51,"context_line":"        api.nova.flavor_list_paged(IsA(http.HttpRequest), None,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_03abb28a","line":48,"in_reply_to":"7af24918_9833adf6","updated":"2016-03-07 07:53:56.000000000","message":"Done","commit_id":"181490487b0172b25cfa8ba51771c7a1a3128238"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"bdaa64c702e35d42cda1cd0053ca4368a054a17f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @django.test.utils.override_settings(API_RESULT_PAGE_SIZE\u003d2)"},{"line_number":46,"context_line":"    @test.create_stubs({api.nova: (\u0027flavor_list_paged\u0027,),"},{"line_number":47,"context_line":"                        flavors.Flavor: (\u0027get_keys\u0027,), })"},{"line_number":48,"context_line":"    def test_index_prev_pagination(self):"},{"line_number":49,"context_line":"        flavors_list \u003d self.flavors.list()[:3]"},{"line_number":50,"context_line":"        api.nova.flavor_list_paged(IsA(http.HttpRequest), None,"},{"line_number":51,"context_line":"                                   marker\u003dNone, paginate\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_cfaf00e2","line":48,"updated":"2016-03-07 21:40:39.000000000","message":"it would be nice to separate out into 2 test cases:\n- test_index_prev_pagination (start from last page, page back)\n- test_index_pagination\n\nso that if something breaks, we know which to target.","commit_id":"a0b14bd9e2d111c0d743341af2fc4ebb05bc7ad1"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"b4038087a688cf321ee2d741b93784b44c771401","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    @django.test.utils.override_settings(API_RESULT_PAGE_SIZE\u003d2)"},{"line_number":46,"context_line":"    @test.create_stubs({api.nova: (\u0027flavor_list_paged\u0027,),"},{"line_number":47,"context_line":"                        flavors.Flavor: (\u0027get_keys\u0027,), })"},{"line_number":48,"context_line":"    def test_index_prev_pagination(self):"},{"line_number":49,"context_line":"        flavors_list \u003d self.flavors.list()[:3]"},{"line_number":50,"context_line":"        api.nova.flavor_list_paged(IsA(http.HttpRequest), None,"},{"line_number":51,"context_line":"                                   marker\u003dNone, paginate\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_3bde973f","line":48,"in_reply_to":"5aef4532_cfaf00e2","updated":"2016-03-08 07:39:38.000000000","message":"Done","commit_id":"a0b14bd9e2d111c0d743341af2fc4ebb05bc7ad1"}]}
