)]}'
{"doc/source/contributing.rst":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"1d462709515e9f547c82b346dca05d6f8a84ea1e","unresolved":false,"context_lines":[{"line_number":469,"context_line":"1. Check if the library is already packaged as xstatic on PyPi, by searching"},{"line_number":470,"context_line":"   for the library name. If it already is, go to step 5. If it is, but not in"},{"line_number":471,"context_line":"   the right version, contact the original packager to have them update it."},{"line_number":472,"context_line":"   You should also check whether the package version is available in major"},{"line_number":473,"context_line":"   downstream packaging distributions; if they don\u0027t have them, then users"},{"line_number":474,"context_line":"   of those distributions may run into trouble."},{"line_number":475,"context_line":"2. Package the library as an xstatic package by following the instructions in"},{"line_number":476,"context_line":"   xstatic documentation_. Install the xstatic-release_ script and follow"},{"line_number":477,"context_line":"   the instructions that come with it."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_2a513ad9","line":474,"range":{"start_line":472,"start_character":0,"end_line":474,"end_character":47},"updated":"2016-06-16 05:58:54.000000000","message":"I\u0027m confused/concerned about this. I think I\u0027m missing some state from the people who are actually doing the work (rather than this drive-by review), but this doesn\u0027t feel right.\n\nIf Horizon (or $project) need a new version of an xstatic or javascript package and a distro doesn\u0027t want to make it available what is the alternative? You\u0027re cornering yourself here to bend to their will.\n\nIsn\u0027t it the responsibility of the downstream packages to figure this out? When they go to package a new version of something (say Horizon) and its dependencies have changed or increased then the packagers need to also bump or find a way to make the dependencies work.\n\nHorizon needs the autonomy and ability to change its dependencies based on what its requirements are, and not what the packagers requirements are.","commit_id":"99ed4d1b325a74bcf4b0fc138e49ae89a74e4d45"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"f96538d2ec6669291740f7ccef35fde6841e579c","unresolved":false,"context_lines":[{"line_number":469,"context_line":"1. Check if the library is already packaged as xstatic on PyPi, by searching"},{"line_number":470,"context_line":"   for the library name. If it already is, go to step 5. If it is, but not in"},{"line_number":471,"context_line":"   the right version, contact the original packager to have them update it."},{"line_number":472,"context_line":"   You should also check whether the package version is available in major"},{"line_number":473,"context_line":"   downstream packaging distributions; if they don\u0027t have them, then users"},{"line_number":474,"context_line":"   of those distributions may run into trouble."},{"line_number":475,"context_line":"2. Package the library as an xstatic package by following the instructions in"},{"line_number":476,"context_line":"   xstatic documentation_. Install the xstatic-release_ script and follow"},{"line_number":477,"context_line":"   the instructions that come with it."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_fb49c633","line":474,"range":{"start_line":472,"start_character":0,"end_line":474,"end_character":47},"in_reply_to":"7aa08908_2a513ad9","updated":"2016-06-16 07:41:06.000000000","message":"This is in principle true, however, there may be important reasons why a particular version can\u0027t be included in the distributions that OpenStack supports, and they need to be considered. One such reason may be a license change, another may be reported but unfixed security problems. If you just ignore them, then Horizon simply will not be included in the packages for that version.\n\nSo yes, Horizon is an autonomous project able to change its dependencies on a whim, but it is also committed to supporting certain distributions, and including certain dependencies on a whim can result in that support not being possible.\n\nIn the end, what is needed is a little bit of caution and dialog with the downstream packagers. Of course, that will happen at the \"add the new package to the global-requirements\" step, but it may speed things up to actually start the dialog earlier.","commit_id":"99ed4d1b325a74bcf4b0fc138e49ae89a74e4d45"},{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"f0283029ca36e3050205e96026385834ab838454","unresolved":false,"context_lines":[{"line_number":469,"context_line":"1. Check if the library is already packaged as xstatic on PyPi, by searching"},{"line_number":470,"context_line":"   for the library name. If it already is, go to step 5. If it is, but not in"},{"line_number":471,"context_line":"   the right version, contact the original packager to have them update it."},{"line_number":472,"context_line":"   You should also check whether the package version is available in major"},{"line_number":473,"context_line":"   downstream packaging distributions; if they don\u0027t have them, then users"},{"line_number":474,"context_line":"   of those distributions may run into trouble."},{"line_number":475,"context_line":"2. Package the library as an xstatic package by following the instructions in"},{"line_number":476,"context_line":"   xstatic documentation_. Install the xstatic-release_ script and follow"},{"line_number":477,"context_line":"   the instructions that come with it."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_5a00bf02","line":474,"range":{"start_line":472,"start_character":0,"end_line":474,"end_character":47},"in_reply_to":"7aa08908_b56102d6","updated":"2016-06-16 14:09:10.000000000","message":"The xstatic package won\u0027t be available, but the library which it wraps may. Also, I agree that it should be changed from \"is available\" to \"can be packaged\".","commit_id":"99ed4d1b325a74bcf4b0fc138e49ae89a74e4d45"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"ba509e16e1f108e2664ed4e506f800e7cc62ffd8","unresolved":false,"context_lines":[{"line_number":469,"context_line":"1. Check if the library is already packaged as xstatic on PyPi, by searching"},{"line_number":470,"context_line":"   for the library name. If it already is, go to step 5. If it is, but not in"},{"line_number":471,"context_line":"   the right version, contact the original packager to have them update it."},{"line_number":472,"context_line":"   You should also check whether the package version is available in major"},{"line_number":473,"context_line":"   downstream packaging distributions; if they don\u0027t have them, then users"},{"line_number":474,"context_line":"   of those distributions may run into trouble."},{"line_number":475,"context_line":"2. Package the library as an xstatic package by following the instructions in"},{"line_number":476,"context_line":"   xstatic documentation_. Install the xstatic-release_ script and follow"},{"line_number":477,"context_line":"   the instructions that come with it."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7aa08908_b56102d6","line":474,"range":{"start_line":472,"start_character":0,"end_line":474,"end_character":47},"in_reply_to":"7aa08908_fb49c633","updated":"2016-06-16 10:27:07.000000000","message":"Downstream packages can only be available *after* the xstatic package was released on pypi.\n\nWhile this is a noble and appreciated step, it\u0027ll fail almost for sure, step 2/5 comes later.","commit_id":"99ed4d1b325a74bcf4b0fc138e49ae89a74e4d45"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"6dc183da79e6f302714b96c180993d03d647b77f","unresolved":false,"context_lines":[{"line_number":484,"context_line":"1. Ensure the version information in the `xstatic/pkg/\u003cpackage name\u003e/__init__.py`"},{"line_number":485,"context_line":"   file is up to date, especially the `BUILD`."},{"line_number":486,"context_line":"2. Push your updated package up for review in gerrit."},{"line_number":487,"context_line":"5. Once the review is approved and the change merged, `tag your release`_. That"},{"line_number":488,"context_line":"   will cause it to be automatically packaged and released to PyPi."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":".. warning::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7aa08908_019a2a6e","line":487,"updated":"2016-06-17 02:21:06.000000000","message":"5?","commit_id":"d9f7719b1ba03de49b3104cf72cf05f26963f4e9"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"6b186a217ce2ad5c2d39c7c64ba89202bfd25e27","unresolved":false,"context_lines":[{"line_number":484,"context_line":"1. Ensure the version information in the `xstatic/pkg/\u003cpackage name\u003e/__init__.py`"},{"line_number":485,"context_line":"   file is up to date, especially the `BUILD`."},{"line_number":486,"context_line":"2. Push your updated package up for review in gerrit."},{"line_number":487,"context_line":"5. Once the review is approved and the change merged, `tag your release`_. That"},{"line_number":488,"context_line":"   will cause it to be automatically packaged and released to PyPi."},{"line_number":489,"context_line":""},{"line_number":490,"context_line":".. warning::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"7aa08908_01018a06","line":487,"in_reply_to":"7aa08908_019a2a6e","updated":"2016-06-17 02:44:06.000000000","message":"Fixed, thanks!","commit_id":"d9f7719b1ba03de49b3104cf72cf05f26963f4e9"}]}