)]}'
{"horizon/static/framework/framework.module.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"baa2c78a67a88524a37441d60c2b452e32b1715d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      return $delegate;"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    horizon.recompileAngularContent \u003d recompileAngularContent;"},{"line_number":58,"context_line":"    function recompileAngularContent() {"},{"line_number":59,"context_line":"      var body \u003d angular.element(\u0027body\u0027);"},{"line_number":60,"context_line":"      var scope \u003d $rootScopeProvider[4]();"}],"source_content_type":"text/javascript","patch_set":5,"id":"1af94dfe_32f14496","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":12},"updated":"2016-03-17 17:13:17.000000000","message":"I actually think just putting this on the window scope would be OK, because we aren\u0027t inherently reliant on the horizon object being present.  Also, it\u0027s a hack, like gettext, etc.  It can eventually go away, but for now dropping it on window seems preferable.  Thoughts?","commit_id":"bf8c8f5c6108a3f1a5d326f88901217138140652"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8b81e5f1396abbb489234926bef7cdce6f3dad62","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      return $delegate;"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    horizon.recompileAngularContent \u003d recompileAngularContent;"},{"line_number":58,"context_line":"    function recompileAngularContent() {"},{"line_number":59,"context_line":"      var body \u003d angular.element(\u0027body\u0027);"},{"line_number":60,"context_line":"      var scope \u003d $rootScopeProvider[4]();"}],"source_content_type":"text/javascript","patch_set":5,"id":"1af94dfe_66c31139","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":12},"in_reply_to":"1af94dfe_32f14496","updated":"2016-03-17 18:08:10.000000000","message":"Sounds quite reasonable to me.\n\nHowever, it seems that we have other, more serious problems here - with $rootScopeProvider (see next patchset).","commit_id":"bf8c8f5c6108a3f1a5d326f88901217138140652"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"24058d24af89908defe69474bc9527467473a68a","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    var $rootScope \u003d $rootScopeProvider.$get[4]();"},{"line_number":58,"context_line":"    window.recompileAngularContent \u003d recompileAngularContent;"},{"line_number":59,"context_line":"    function recompileAngularContent() {"},{"line_number":60,"context_line":"      var body \u003d angular.element(\u0027body\u0027);"},{"line_number":61,"context_line":"      var scope \u003d $rootScope.$new();"}],"source_content_type":"text/javascript","patch_set":6,"id":"1af94dfe_7c6a7eef","line":58,"range":{"start_line":58,"start_character":4,"end_line":58,"end_character":10},"updated":"2016-03-17 18:11:38.000000000","message":"Might want to use the $windowProvider to do this, using (probably), just as we are supposed to avoid raw references to window:\n\n$windowProvider.$get().recompileAngularContent \u003d recompileAngularContent;\n\nYou could also do this in the run() method if you wanted to just use the typical $window injectable.","commit_id":"b09eeb75d242b994eb74c3f9c6581430e94f43e8"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9cdd45a599cb3918571cbfbea086478356817104","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  run.$inject \u003d [\u0027$window\u0027, \u0027$rootScope\u0027];"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  function run($window, $rootScope) {"},{"line_number":78,"context_line":"    $window.recompileAngularContent \u003d recompileAngularContent;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    function recompileAngularContent() {"},{"line_number":81,"context_line":"      var body \u003d angular.element(\u0027body\u0027);"}],"source_content_type":"text/javascript","patch_set":8,"id":"1af94dfe_988e6d77","line":78,"range":{"start_line":78,"start_character":4,"end_line":78,"end_character":11},"updated":"2016-03-17 21:07:33.000000000","message":"-1: IMHO I\u0027d prefer this be added to \"horizon\" like earlier patchsets. \n\nMy thinking is that the places that invoke this function are things like \"horizon.tables\" and \"horizon.tabs\"...both are logically within the horizon framework. Pushing this all the way up to window seems a bit too much, since only code within the horizon framework needs to access this.","commit_id":"2de6baae34f13ae1e0e3e70e2f08eceae346cfcc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"93977b09c0d8e93b986a05f66fe4bf7d6955c3cd","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  run.$inject \u003d [\u0027$window\u0027, \u0027$rootScope\u0027];"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"  function run($window, $rootScope) {"},{"line_number":78,"context_line":"    $window.recompileAngularContent \u003d recompileAngularContent;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    function recompileAngularContent() {"},{"line_number":81,"context_line":"      var body \u003d angular.element(\u0027body\u0027);"}],"source_content_type":"text/javascript","patch_set":8,"id":"1af94dfe_d8b755d6","line":78,"range":{"start_line":78,"start_character":4,"end_line":78,"end_character":11},"in_reply_to":"1af94dfe_988e6d77","updated":"2016-03-17 21:14:44.000000000","message":"My only 2 cents on this is that we\u0027re making an assumption in the Angular code of the presence of \u0027horizon\u0027 which could cause troubles.  This is assured to work in all cases (tests, etc.).\nIt also may cause confusion about its origin (which you kind of address in your other comment) as it is not created as part of the horizon legacy libraries.\n\nYou could just assign another global name if you think it\u0027s confusing, e.g.\n\n\u0027angularHacks.recompileAngularContent()\u0027","commit_id":"2de6baae34f13ae1e0e3e70e2f08eceae346cfcc"}],"horizon/static/horizon/js/horizon.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"38cabf8ee4a3ab8bbd48123f5c3b9a02570a9066","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  horizon.recompileAngularContent \u003d recompileAngularContent;"},{"line_number":32,"context_line":"  function recompileAngularContent() {"},{"line_number":33,"context_line":"    var body \u003d angular.element(\u0027body\u0027);"},{"line_number":34,"context_line":"    var scope \u003d body.scope();"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    function explicit($compile) {"},{"line_number":37,"context_line":"      $compile(body)(scope);"}],"source_content_type":"text/javascript","patch_set":4,"id":"1af94dfe_914e8894","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":28},"updated":"2016-03-16 21:26:03.000000000","message":"-1: This will break when/if we turn off Angular debug. Instead use $rootScope.\n\nTo make $rootScope available, I suggest moving this function definition into the config function in framework.module.js and creating adding the horizon.recompileAngularContent attribute from there.","commit_id":"40771f7ba810157e16b8e308f93da9a53ce75dec"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"cf1fafd4cd631fb9ad7b9954d1aec923bcfa1a51","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  horizon.recompileAngularContent \u003d recompileAngularContent;"},{"line_number":32,"context_line":"  function recompileAngularContent() {"},{"line_number":33,"context_line":"    var body \u003d angular.element(\u0027body\u0027);"},{"line_number":34,"context_line":"    var scope \u003d body.scope();"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    function explicit($compile) {"},{"line_number":37,"context_line":"      $compile(body)(scope);"}],"source_content_type":"text/javascript","patch_set":4,"id":"1af94dfe_d2c3c087","line":34,"range":{"start_line":34,"start_character":16,"end_line":34,"end_character":28},"in_reply_to":"1af94dfe_914e8894","updated":"2016-03-17 17:06:35.000000000","message":"Done","commit_id":"40771f7ba810157e16b8e308f93da9a53ce75dec"}],"horizon/static/horizon/js/horizon.tables.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"38cabf8ee4a3ab8bbd48123f5c3b9a02570a9066","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              // problem with not-working angular actions in a content added"},{"line_number":104,"context_line":"              // by jQuery via replacing jQuery insert with Angular insert."},{"line_number":105,"context_line":"              // Should address this in Newton release"},{"line_number":106,"context_line":"              horizon.recompileAngularContent();"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"              // Reset tablesorter\u0027s data cache."},{"line_number":109,"context_line":"              $table.trigger(\"update\");"}],"source_content_type":"text/javascript","patch_set":4,"id":"1af94dfe_310e943b","line":106,"range":{"start_line":106,"start_character":14,"end_line":106,"end_character":21},"updated":"2016-03-16 21:26:03.000000000","message":"I suggest moving the code that adds this function into framework.module.js. Assuming it moves, wrap this in a hasOwnProperty test.","commit_id":"40771f7ba810157e16b8e308f93da9a53ce75dec"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"cf1fafd4cd631fb9ad7b9954d1aec923bcfa1a51","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              // problem with not-working angular actions in a content added"},{"line_number":104,"context_line":"              // by jQuery via replacing jQuery insert with Angular insert."},{"line_number":105,"context_line":"              // Should address this in Newton release"},{"line_number":106,"context_line":"              horizon.recompileAngularContent();"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"              // Reset tablesorter\u0027s data cache."},{"line_number":109,"context_line":"              $table.trigger(\"update\");"}],"source_content_type":"text/javascript","patch_set":4,"id":"1af94dfe_d2dc6075","line":106,"range":{"start_line":106,"start_character":14,"end_line":106,"end_character":21},"in_reply_to":"1af94dfe_310e943b","updated":"2016-03-17 17:06:35.000000000","message":"My point here is that once it moves, we should remove the call as well, anyways it should fail aloud if something wrong, not silently.","commit_id":"40771f7ba810157e16b8e308f93da9a53ce75dec"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"9cdd45a599cb3918571cbfbea086478356817104","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              // problem with not-working angular actions in a content added"},{"line_number":104,"context_line":"              // by jQuery via replacing jQuery insert with Angular insert."},{"line_number":105,"context_line":"              // Should address this in Newton release"},{"line_number":106,"context_line":"              recompileAngularContent();"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"              // Reset tablesorter\u0027s data cache."},{"line_number":109,"context_line":"              $table.trigger(\"update\");"}],"source_content_type":"text/javascript","patch_set":8,"id":"1af94dfe_98014db2","line":106,"range":{"start_line":106,"start_character":14,"end_line":106,"end_character":37},"updated":"2016-03-17 21:07:33.000000000","message":"nit: From the point of view of this file, it is difficult to understand who or what supplies this function.\n\nI know this solution is supposed to be temporary, but consider changing to \"horizon.hzFrameworkRecompileAngular( )\" to help remind people that the \"hz.framework\" module is a likely suspect.","commit_id":"2de6baae34f13ae1e0e3e70e2f08eceae346cfcc"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"93977b09c0d8e93b986a05f66fe4bf7d6955c3cd","unresolved":false,"context_lines":[{"line_number":103,"context_line":"              // problem with not-working angular actions in a content added"},{"line_number":104,"context_line":"              // by jQuery via replacing jQuery insert with Angular insert."},{"line_number":105,"context_line":"              // Should address this in Newton release"},{"line_number":106,"context_line":"              recompileAngularContent();"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"              // Reset tablesorter\u0027s data cache."},{"line_number":109,"context_line":"              $table.trigger(\"update\");"}],"source_content_type":"text/javascript","patch_set":8,"id":"1af94dfe_18337d63","line":106,"range":{"start_line":106,"start_character":14,"end_line":106,"end_character":37},"in_reply_to":"1af94dfe_98014db2","updated":"2016-03-17 21:14:44.000000000","message":"I find the name recompileAngularContent to be slightly more correct as we\u0027re recompiling the content, not Angular as suggested by horizon.hzFrameworkRecompileAngular, so it would have to be more like \"horizon.hzFrameworkRecompileAngularContent\".","commit_id":"2de6baae34f13ae1e0e3e70e2f08eceae346cfcc"}]}
