)]}'
{".eslintrc":[{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"5214e265f1631deb28bcac8eb82b7c144aa892ef","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  #############################################################################"},{"line_number":26,"context_line":"  # Disabled Rules from eslint-config-openstack"},{"line_number":27,"context_line":"  #############################################################################"},{"line_number":28,"context_line":"  valid-jsdoc: [1, {"},{"line_number":29,"context_line":"    requireParamDescription: false"},{"line_number":30,"context_line":"  }]"},{"line_number":31,"context_line":"  no-undefined: 1"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"5aef4532_254aa955","line":28,"updated":"2016-03-09 12:33:44.000000000","message":"Not needed if this gets in: https://review.openstack.org/#/c/290235/","commit_id":"f20ea6415eb718c1f7e4d5a4dd0f74affe9ffe2c"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/objects.controller.spec.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"a784e52f6e5077e8d089abaf9120dd654496d110","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      expect(ctrl.containerURL).toEqual(\u0027eggs/spam/\u0027);"},{"line_number":48,"context_line":"      expect(ctrl.currentURL).toEqual(\u0027eggs/spam/\u0027);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"      expect(model.selectContainer.calls.argsFor(0)[0]).toBe(\u0027spam\u0027);"},{"line_number":51,"context_line":"      expect(model.selectContainer.calls.argsFor(0)[1]).toBeUndefined();"},{"line_number":52,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":3,"id":"3afc51ec_9f541a55","line":49,"updated":"2016-03-11 20:42:25.000000000","message":"We should not be altering code to this extend just to pass linting. This is really fragile code. If the internals of jasmine changes, we could end up with something that breaks. I personally prefer to keep the old statement and add an ignore statement or investigate a different approach to fixing it.","commit_id":"f20ea6415eb718c1f7e4d5a4dd0f74affe9ffe2c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"2df2a64fbbadc765a2ba598ea6d54e62efcb12d0","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      expect(ctrl.containerURL).toEqual(\u0027eggs/spam/\u0027);"},{"line_number":48,"context_line":"      expect(ctrl.currentURL).toEqual(\u0027eggs/spam/\u0027);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"      expect(model.selectContainer.calls.argsFor(0)[0]).toBe(\u0027spam\u0027);"},{"line_number":51,"context_line":"      expect(model.selectContainer.calls.argsFor(0)[1]).toBeUndefined();"},{"line_number":52,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":3,"id":"3afc51ec_daad108a","line":49,"in_reply_to":"3afc51ec_9f541a55","updated":"2016-03-11 21:01:18.000000000","message":"Well, I don\u0027t know...this is a test, not production code, and it is equivalent.","commit_id":"f20ea6415eb718c1f7e4d5a4dd0f74affe9ffe2c"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f7f4fd689b128b194c7409e4ddb48caef577834b","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      expect(ctrl.containerURL).toEqual(\u0027eggs/spam/\u0027);"},{"line_number":48,"context_line":"      expect(ctrl.currentURL).toEqual(\u0027eggs/spam/\u0027);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"      expect(model.selectContainer.calls.argsFor(0)[0]).toBe(\u0027spam\u0027);"},{"line_number":51,"context_line":"      expect(model.selectContainer.calls.argsFor(0)[1]).toBeUndefined();"},{"line_number":52,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":3,"id":"3afc51ec_60bc0e6d","line":49,"in_reply_to":"3afc51ec_daad108a","updated":"2016-03-11 21:29:47.000000000","message":"-1 the linter in this case. The test is asserting precisely what happened, and with a very clear assertion call. The change to appease the linter is way out of line.","commit_id":"f20ea6415eb718c1f7e4d5a4dd0f74affe9ffe2c"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/flavor/select-flavor-table.directive.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"cead6e4565d203fd663d5392d95d1081b89657f4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * @name selectFlavorTable"},{"line_number":33,"context_line":"   * @scope true"},{"line_number":34,"context_line":"   * @element"},{"line_number":35,"context_line":"   * @param {Object} basePath"},{"line_number":36,"context_line":"   * @param {Object} transferTableHelpText"},{"line_number":37,"context_line":"   * @param {Object} donutChartSettings"},{"line_number":38,"context_line":"   * @param {Object} tooltipService"}],"source_content_type":"text/javascript","patch_set":5,"id":"3afc51ec_25ed9b25","line":35,"updated":"2016-03-15 01:35:57.000000000","message":"string","commit_id":"520798ac02a3d7663cb3a2dd787e3e727c901498"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ca6e87dfbf07612e90683ca94552543c9e04729","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * @name selectFlavorTable"},{"line_number":33,"context_line":"   * @scope true"},{"line_number":34,"context_line":"   * @element"},{"line_number":35,"context_line":"   * @param {Object} basePath"},{"line_number":36,"context_line":"   * @param {Object} transferTableHelpText"},{"line_number":37,"context_line":"   * @param {Object} donutChartSettings"},{"line_number":38,"context_line":"   * @param {Object} tooltipService"}],"source_content_type":"text/javascript","patch_set":5,"id":"1af94dfe_cd70fe0d","line":35,"in_reply_to":"3afc51ec_25ed9b25","updated":"2016-03-18 20:23:26.000000000","message":"Done","commit_id":"520798ac02a3d7663cb3a2dd787e3e727c901498"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/keypair/import-keypair.controller.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"cead6e4565d203fd663d5392d95d1081b89657f4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   * @param {Object} $modalInstance"},{"line_number":35,"context_line":"   * @param {Object} novaAPI"},{"line_number":36,"context_line":"   * @param {Object} toastService"},{"line_number":37,"context_line":"   * @param {Object} basePath"},{"line_number":38,"context_line":"   * @description"},{"line_number":39,"context_line":"   * Provide a dialog for import of an existing ssh public key."},{"line_number":40,"context_line":"   * @returns {undefined} Returns nothing"}],"source_content_type":"text/javascript","patch_set":5,"id":"3afc51ec_45ea6710","line":37,"updated":"2016-03-15 01:35:57.000000000","message":"string","commit_id":"520798ac02a3d7663cb3a2dd787e3e727c901498"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ca6e87dfbf07612e90683ca94552543c9e04729","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   * @param {Object} $modalInstance"},{"line_number":35,"context_line":"   * @param {Object} novaAPI"},{"line_number":36,"context_line":"   * @param {Object} toastService"},{"line_number":37,"context_line":"   * @param {Object} basePath"},{"line_number":38,"context_line":"   * @description"},{"line_number":39,"context_line":"   * Provide a dialog for import of an existing ssh public key."},{"line_number":40,"context_line":"   * @returns {undefined} Returns nothing"}],"source_content_type":"text/javascript","patch_set":5,"id":"1af94dfe_4d634e42","line":37,"in_reply_to":"3afc51ec_45ea6710","updated":"2016-03-18 20:23:26.000000000","message":"Done","commit_id":"520798ac02a3d7663cb3a2dd787e3e727c901498"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/keypair/keypair.controller.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"cead6e4565d203fd663d5392d95d1081b89657f4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  /**"},{"line_number":32,"context_line":"   * @ngdoc controller"},{"line_number":33,"context_line":"   * @name LaunchInstanceKeypairController"},{"line_number":34,"context_line":"   * @param {Object} basePath"},{"line_number":35,"context_line":"   * @param {Object} launchInstanceModel"},{"line_number":36,"context_line":"   * @param {Object} $modal"},{"line_number":37,"context_line":"   * @param {Object} toastService"}],"source_content_type":"text/javascript","patch_set":5,"id":"3afc51ec_c597978e","line":34,"updated":"2016-03-15 01:35:57.000000000","message":"string","commit_id":"520798ac02a3d7663cb3a2dd787e3e727c901498"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ca6e87dfbf07612e90683ca94552543c9e04729","unresolved":false,"context_lines":[{"line_number":31,"context_line":"  /**"},{"line_number":32,"context_line":"   * @ngdoc controller"},{"line_number":33,"context_line":"   * @name LaunchInstanceKeypairController"},{"line_number":34,"context_line":"   * @param {Object} basePath"},{"line_number":35,"context_line":"   * @param {Object} launchInstanceModel"},{"line_number":36,"context_line":"   * @param {Object} $modal"},{"line_number":37,"context_line":"   * @param {Object} toastService"}],"source_content_type":"text/javascript","patch_set":5,"id":"1af94dfe_4dca2e1c","line":34,"in_reply_to":"3afc51ec_c597978e","updated":"2016-03-18 20:23:26.000000000","message":"Done","commit_id":"520798ac02a3d7663cb3a2dd787e3e727c901498"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/security-groups/security-groups.controller.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"cead6e4565d203fd663d5392d95d1081b89657f4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"   * @ngdoc controller"},{"line_number":28,"context_line":"   * @name LaunchInstanceSecurityGroupsController"},{"line_number":29,"context_line":"   * @param {Object} launchInstanceModel"},{"line_number":30,"context_line":"   * @param {Object} basePath"},{"line_number":31,"context_line":"   * @description"},{"line_number":32,"context_line":"   * Allows selection of security groups."},{"line_number":33,"context_line":"   * @returns {undefined} No return value"}],"source_content_type":"text/javascript","patch_set":5,"id":"3afc51ec_25863b65","line":30,"updated":"2016-03-15 01:35:57.000000000","message":"basePath is a string","commit_id":"520798ac02a3d7663cb3a2dd787e3e727c901498"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"6ca6e87dfbf07612e90683ca94552543c9e04729","unresolved":false,"context_lines":[{"line_number":27,"context_line":"   * @ngdoc controller"},{"line_number":28,"context_line":"   * @name LaunchInstanceSecurityGroupsController"},{"line_number":29,"context_line":"   * @param {Object} launchInstanceModel"},{"line_number":30,"context_line":"   * @param {Object} basePath"},{"line_number":31,"context_line":"   * @description"},{"line_number":32,"context_line":"   * Allows selection of security groups."},{"line_number":33,"context_line":"   * @returns {undefined} No return value"}],"source_content_type":"text/javascript","patch_set":5,"id":"1af94dfe_8de716ab","line":30,"in_reply_to":"3afc51ec_25863b65","updated":"2016-03-18 20:23:26.000000000","message":"Done","commit_id":"520798ac02a3d7663cb3a2dd787e3e727c901498"}]}