)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f2136da05c7cf96f40beb907c2c4def3e0eb042d","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I78d189d6eb026bd98abba6451641010104fc5002"},{"line_number":25,"context_line":"Partially-Implements: blueprint angularize-images-table"},{"line_number":26,"context_line":"Partial-Bug: 1514627"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_d38e0a78","line":26,"updated":"2016-03-09 21:41:13.000000000","message":"You may want to add:\n\nPartial-Bug: 1553314\n\nIf you think that is appropriate.","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d459c49db946bed65108acb590b393f0afde8362","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I78d189d6eb026bd98abba6451641010104fc5002"},{"line_number":25,"context_line":"Partially-Implements: blueprint angularize-images-table"},{"line_number":26,"context_line":"Partial-Bug: 1514627"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5aef4532_2e71c1a8","line":26,"in_reply_to":"5aef4532_d38e0a78","updated":"2016-03-09 22:01:58.000000000","message":"Never mind, it\u0027s something else.","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"}],"horizon/static/framework/widgets/action-list/actions.controller.js":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"a9bcfe934f4a6c71c44b4af67c7b465c035fa384","unresolved":false,"context_lines":[{"line_number":90,"context_line":"     */"},{"line_number":91,"context_line":"    function generateDynamicCallback(service, index, resultHandler) {"},{"line_number":92,"context_line":"      var dynCallbackName \u003d \"callback\" + index;"},{"line_number":93,"context_line":"      ctrl.passThroughCallbacks[dynCallbackName] \u003d function genPassThroughCallback(item) {"},{"line_number":94,"context_line":"        if (resultHandler) {"},{"line_number":95,"context_line":"          return resultHandler(service.perform(item));"},{"line_number":96,"context_line":"        } else {"}],"source_content_type":"text/javascript","patch_set":4,"id":"3afc51ec_9f87b0d6","line":93,"updated":"2016-03-14 17:17:37.000000000","message":"note that item is plural for batch delete. maybe just a comment would be sufficient.","commit_id":"05b53f7d60c2e9e0c7538348656442a89a03d3fd"}],"horizon/static/framework/widgets/action-list/actions.directive.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ccec6f4d836e73a3f63b9e5c6f31af3b9ee52541","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   * @param {string\u003d} item"},{"line_number":45,"context_line":"   * The item to pass to the \u0027service\u0027 when using \u0027row\u0027 type."},{"line_number":46,"context_line":"   *"},{"line_number":47,"context_line":"   * @param {function} perform-handler"},{"line_number":48,"context_line":"   * (Optional) A function that will be given the return value from the action\u0027s perform function."},{"line_number":49,"context_line":"   * Ideally, an action perform function returns a promise that resolves to some data that"},{"line_number":50,"context_line":"   * indicates the affected items."}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_2637f34d","line":47,"updated":"2016-03-10 18:42:38.000000000","message":"this isn\u0027t really handling perform or even invoking perform on the actions... it is handling the result.  result-handler would probably better convey what this should be.","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"}],"horizon/static/framework/widgets/modal/delete-modal.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c4077b76ceff3ac9d6eec5b009a0fe0d370961f4","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          toast.add(\u0027error\u0027, getMessage(context.labels.error, failEntities));"},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        return {"},{"line_number":112,"context_line":"          // Object intentionally left blank. This data is is passed to"},{"line_number":113,"context_line":"          // code that holds this action\u0027s promise. In the future, it may"},{"line_number":114,"context_line":"          // contain entity IDs and types that were modified by this action."}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_abe655e5","line":111,"updated":"2016-03-10 05:18:14.000000000","message":"i\u0027m concerned about a couple things.\n\nwe don\u0027t know who is using this already (lbaas)\nthis is functionally a regression in that there is no context anymore.","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"16d90da8a460d5141f26b1c1a6ffcb0dd81c4cc1","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          toast.add(\u0027error\u0027, getMessage(context.labels.error, failEntities));"},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        return {"},{"line_number":112,"context_line":"          // Object intentionally left blank. This data is is passed to"},{"line_number":113,"context_line":"          // code that holds this action\u0027s promise. In the future, it may"},{"line_number":114,"context_line":"          // contain entity IDs and types that were modified by this action."}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_664a84ae","line":111,"in_reply_to":"5aef4532_260ed38b","updated":"2016-03-11 07:07:51.000000000","message":"might need to check zaqar, lbaas, and magnum. i don\u0027t think others would be using it.","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a73aa906fa1fae553e9e7df6e54ee0c8623e953f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          toast.add(\u0027error\u0027, getMessage(context.labels.error, failEntities));"},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        return {"},{"line_number":112,"context_line":"          // Object intentionally left blank. This data is is passed to"},{"line_number":113,"context_line":"          // code that holds this action\u0027s promise. In the future, it may"},{"line_number":114,"context_line":"          // contain entity IDs and types that were modified by this action."}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_90344f4a","line":111,"in_reply_to":"5aef4532_abe655e5","updated":"2016-03-10 14:48:21.000000000","message":"I guess that is true; they could be using the delete-modal.service.  Can\u0027t hurt to leave it for now, but perhaps with an indication that the promise should be used for most handling.","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"1fc87f3f2cd052946f2758f0855e0a60cb54033d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          toast.add(\u0027error\u0027, getMessage(context.labels.error, failEntities));"},{"line_number":109,"context_line":"        }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"        return {"},{"line_number":112,"context_line":"          // Object intentionally left blank. This data is is passed to"},{"line_number":113,"context_line":"          // code that holds this action\u0027s promise. In the future, it may"},{"line_number":114,"context_line":"          // contain entity IDs and types that were modified by this action."}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_260ed38b","line":111,"in_reply_to":"5aef4532_abe655e5","updated":"2016-03-10 23:19:10.000000000","message":"To be clear...the context still exists...it just doesn\u0027t contain a specific  event that the service is supposed to dispatch.\n\nI waffled on removing events from this service, because, as you say, what if a non-core plugin is using them?","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c7dcf3a0b7d4d2b41193387f7b95f08e2f45ae7e","unresolved":false,"context_lines":[{"line_number":73,"context_line":"     * The first argument is the id of the Entity to delete."},{"line_number":74,"context_line":"     * Note: This callback might need to suppress errors on the"},{"line_number":75,"context_line":"     * alert service."},{"line_number":76,"context_line":"     *"},{"line_number":77,"context_line":"     * @param {string} context.successEvent"},{"line_number":78,"context_line":"     * The name of the event to emit for the entities that have been deleted successfully."},{"line_number":79,"context_line":"     * @param {string} context.failedEvent"}],"source_content_type":"text/javascript","patch_set":4,"id":"3afc51ec_83ddee72","line":76,"updated":"2016-03-11 17:40:24.000000000","message":"Should we add some kine of a note in here that using events rather than the promise returned may make the service less reusable.","commit_id":"05b53f7d60c2e9e0c7538348656442a89a03d3fd"},{"author":{"_account_id":9647,"name":"Justin Pomeroy","email":"jpomero@linux.vnet.ibm.com","username":"jpomero"},"change_message_id":"6b9f98aa322e7d488449c8697db2c0b55f21ff7a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"     * The first argument is the id of the Entity to delete."},{"line_number":74,"context_line":"     * Note: This callback might need to suppress errors on the"},{"line_number":75,"context_line":"     * alert service."},{"line_number":76,"context_line":"     *"},{"line_number":77,"context_line":"     * @param {string} context.successEvent"},{"line_number":78,"context_line":"     * The name of the event to emit for the entities that have been deleted successfully."},{"line_number":79,"context_line":"     * @param {string} context.failedEvent"}],"source_content_type":"text/javascript","patch_set":4,"id":"3afc51ec_78832ccd","line":76,"in_reply_to":"3afc51ec_35bc0d6c","updated":"2016-03-11 18:41:05.000000000","message":"+1 for deprecating the events.  LBaaS dashboard does use the failedEvent in Mitaka but will be removed for Newton when I can update it to use promises.","commit_id":"05b53f7d60c2e9e0c7538348656442a89a03d3fd"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5ee5650c2d865b2c8d75ca1a133668cbcfd50b67","unresolved":false,"context_lines":[{"line_number":73,"context_line":"     * The first argument is the id of the Entity to delete."},{"line_number":74,"context_line":"     * Note: This callback might need to suppress errors on the"},{"line_number":75,"context_line":"     * alert service."},{"line_number":76,"context_line":"     *"},{"line_number":77,"context_line":"     * @param {string} context.successEvent"},{"line_number":78,"context_line":"     * The name of the event to emit for the entities that have been deleted successfully."},{"line_number":79,"context_line":"     * @param {string} context.failedEvent"}],"source_content_type":"text/javascript","patch_set":4,"id":"3afc51ec_35bc0d6c","line":76,"in_reply_to":"3afc51ec_83ddee72","updated":"2016-03-11 18:20:21.000000000","message":"Yeah, I think we should deprecate events as they don\u0027t produce the same fidelity that a promise has, and can\u0027t be chained and such which is quite useful.  Similarly, if you \"create\" something, it\u0027s ambiguous; you could create a listener for a load balancer, so you \"created\" a listener but \"updated\" the load balancer (in the sense that its display may need to be updated).  Having these emitted as separate events which are handled asynchronously could cause a lot of confusion.","commit_id":"05b53f7d60c2e9e0c7538348656442a89a03d3fd"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/launch-instance-modal.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c4077b76ceff3ac9d6eec5b009a0fe0d370961f4","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        };"},{"line_number":57,"context_line":"      };"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"      return launchInstanceModal.result.then("},{"line_number":60,"context_line":"        handleModalClose(\u0027successUrl\u0027),"},{"line_number":61,"context_line":"        handleModalClose(\u0027dismissUrl\u0027)"},{"line_number":62,"context_line":"      );"}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_48319759","line":59,"updated":"2016-03-10 05:18:14.000000000","message":"this changes the location, making the promise obsolete?","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"1fc87f3f2cd052946f2758f0855e0a60cb54033d","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        };"},{"line_number":57,"context_line":"      };"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"      return launchInstanceModal.result.then("},{"line_number":60,"context_line":"        handleModalClose(\u0027successUrl\u0027),"},{"line_number":61,"context_line":"        handleModalClose(\u0027dismissUrl\u0027)"},{"line_number":62,"context_line":"      );"}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_26d373d6","line":59,"in_reply_to":"5aef4532_48319759","updated":"2016-03-10 23:19:10.000000000","message":"Correct. This service does not play well with others.","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"}],"openstack_dashboard/static/app/core/images/actions/create-volume.service.spec.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d67b11f1c055344e680a6d0cee1996cc7de58590","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    var wizardModalService \u003d {"},{"line_number":23,"context_line":"      modal: function () {"},{"line_number":24,"context_line":"        return {"},{"line_number":25,"context_line":"          result: function() {}"},{"line_number":26,"context_line":"        }"},{"line_number":27,"context_line":"      }"},{"line_number":28,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_c9bb00e4","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":31},"updated":"2016-03-09 19:39:13.000000000","message":"can use angular.noop here if you like.","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"557b6ce9c7f2dd41e065cbd0d918f8bb0b211119","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    var wizardModalService \u003d {"},{"line_number":23,"context_line":"      modal: function () {"},{"line_number":24,"context_line":"        return {"},{"line_number":25,"context_line":"          result: function() {}"},{"line_number":26,"context_line":"        }"},{"line_number":27,"context_line":"      }"},{"line_number":28,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_d4bc3008","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":31},"in_reply_to":"5aef4532_c9bb00e4","updated":"2016-03-09 22:51:43.000000000","message":"Done","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"fc0832e4bb482461d9aff357b92abc67f832920d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      modal: function () {"},{"line_number":24,"context_line":"        return {"},{"line_number":25,"context_line":"          result: function() {}"},{"line_number":26,"context_line":"        }"},{"line_number":27,"context_line":"      }"},{"line_number":28,"context_line":"    };"},{"line_number":29,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_029c9e0d","line":26,"updated":"2016-03-09 20:59:20.000000000","message":"eslint: add semicolon.","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"557b6ce9c7f2dd41e065cbd0d918f8bb0b211119","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      modal: function () {"},{"line_number":24,"context_line":"        return {"},{"line_number":25,"context_line":"          result: function() {}"},{"line_number":26,"context_line":"        }"},{"line_number":27,"context_line":"      }"},{"line_number":28,"context_line":"    };"},{"line_number":29,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_b4b9a417","line":26,"in_reply_to":"5aef4532_029c9e0d","updated":"2016-03-09 22:51:43.000000000","message":"Done","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"}],"openstack_dashboard/static/app/core/images/actions/delete-image.service.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d67b11f1c055344e680a6d0cee1996cc7de58590","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    function afterCheck(result) {"},{"line_number":102,"context_line":"      var outcome \u003d $q.reject();  // Reject the promise by default"},{"line_number":103,"context_line":"      if (result.fail.length \u003e 0) {"},{"line_number":104,"context_line":"        toast.add(\u0027error\u0027, getMessage(notAllowedMessage, result.fail));"},{"line_number":105,"context_line":"        outcome \u003d $q.reject(result.fail);"},{"line_number":106,"context_line":"      }"},{"line_number":107,"context_line":"      if (result.pass.length \u003e 0) {"},{"line_number":108,"context_line":"        outcome \u003d deleteModal.open(scope, result.pass.map(getEntity), context);"},{"line_number":109,"context_line":"      }"},{"line_number":110,"context_line":"      return outcome;"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_a98e742b","line":109,"range":{"start_line":103,"start_character":1,"end_line":109,"end_character":7},"updated":"2016-03-09 19:39:13.000000000","message":"I think we should modify the conditional structure here.  The old way made sense, but here we can technically assign a reject() to the outcome and then subsequently assign the resulting promise from the modal.  I\u0027d change this to an else-if.  \n\nAlso, does it make sense to return an undefined outcome?  I just think this may need a new logic structure.","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"edc150daaa9c191ac3a846e0f82f0857eb4fcf13","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    function afterCheck(result) {"},{"line_number":102,"context_line":"      var outcome \u003d $q.reject();  // Reject the promise by default"},{"line_number":103,"context_line":"      if (result.fail.length \u003e 0) {"},{"line_number":104,"context_line":"        toast.add(\u0027error\u0027, getMessage(notAllowedMessage, result.fail));"},{"line_number":105,"context_line":"        outcome \u003d $q.reject(result.fail);"},{"line_number":106,"context_line":"      }"},{"line_number":107,"context_line":"      if (result.pass.length \u003e 0) {"},{"line_number":108,"context_line":"        outcome \u003d deleteModal.open(scope, result.pass.map(getEntity), context);"},{"line_number":109,"context_line":"      }"},{"line_number":110,"context_line":"      return outcome;"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_c2d636f0","line":109,"range":{"start_line":103,"start_character":1,"end_line":109,"end_character":7},"in_reply_to":"5aef4532_7f4c1ec8","updated":"2016-03-09 20:53:14.000000000","message":"Got it.  Default reject, display toast if some failed, but still present modal if appropriate.","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"3ef90c48dce2c35a4b36b66fdb364c9569900db6","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    function afterCheck(result) {"},{"line_number":102,"context_line":"      var outcome \u003d $q.reject();  // Reject the promise by default"},{"line_number":103,"context_line":"      if (result.fail.length \u003e 0) {"},{"line_number":104,"context_line":"        toast.add(\u0027error\u0027, getMessage(notAllowedMessage, result.fail));"},{"line_number":105,"context_line":"        outcome \u003d $q.reject(result.fail);"},{"line_number":106,"context_line":"      }"},{"line_number":107,"context_line":"      if (result.pass.length \u003e 0) {"},{"line_number":108,"context_line":"        outcome \u003d deleteModal.open(scope, result.pass.map(getEntity), context);"},{"line_number":109,"context_line":"      }"},{"line_number":110,"context_line":"      return outcome;"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_7f4c1ec8","line":109,"range":{"start_line":103,"start_character":1,"end_line":109,"end_character":7},"in_reply_to":"5aef4532_a98e742b","updated":"2016-03-09 20:13:41.000000000","message":"I think this is by design. If you select multiple images, some of which you can delete, some of which you cannot, this structure gives you a toast for the unallowed ones, but proceeds to display the delete modal for the allowed ones.\n\nI do notice however that the old images panel only shows my project\u0027s images...where the new images panel shows more...which is probably a bug in NG launch instance.","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"}],"openstack_dashboard/static/app/core/images/actions/launch-instance.service.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c4077b76ceff3ac9d6eec5b009a0fe0d370961f4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    //////////////"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    function perform(image) {"},{"line_number":55,"context_line":"      return launchInstanceModal.open({"},{"line_number":56,"context_line":"        successUrl: \u0027/project/instances\u0027,"},{"line_number":57,"context_line":"        \u0027imageId\u0027: image.id"},{"line_number":58,"context_line":"      });"}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_ab7bf579","line":55,"updated":"2016-03-10 05:18:14.000000000","message":"launch instance modal will redirect, so i don\u0027t know if the promise is valid?","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"1fc87f3f2cd052946f2758f0855e0a60cb54033d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    //////////////"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    function perform(image) {"},{"line_number":55,"context_line":"      return launchInstanceModal.open({"},{"line_number":56,"context_line":"        successUrl: \u0027/project/instances\u0027,"},{"line_number":57,"context_line":"        \u0027imageId\u0027: image.id"},{"line_number":58,"context_line":"      });"}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_e64fcb8f","line":55,"in_reply_to":"5aef4532_10779f02","updated":"2016-03-10 23:19:10.000000000","message":"Launch instance service is a good example of a \"bad\" action because it ignores the calling view\u0027s desires for what should happen after the action completes.\n\nIt is really up to the caller if they want to redirect to instances page or not...but this service doesn\u0027t give you that choice.","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a73aa906fa1fae553e9e7df6e54ee0c8623e953f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    //////////////"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    function perform(image) {"},{"line_number":55,"context_line":"      return launchInstanceModal.open({"},{"line_number":56,"context_line":"        successUrl: \u0027/project/instances\u0027,"},{"line_number":57,"context_line":"        \u0027imageId\u0027: image.id"},{"line_number":58,"context_line":"      });"}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_10779f02","line":55,"in_reply_to":"5aef4532_ab7bf579","updated":"2016-03-10 14:48:21.000000000","message":"I think it\u0027s valid, because the controller (context of the launch) can set whether a successUrl (redirect) is used.  If the context needs a redirect, set successUrl.  If it doesn\u0027t, don\u0027t set it, and use the promise.  Returning a promise is OK if nothing is done with it.","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"16d90da8a460d5141f26b1c1a6ffcb0dd81c4cc1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    //////////////"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    function perform(image) {"},{"line_number":55,"context_line":"      return launchInstanceModal.open({"},{"line_number":56,"context_line":"        successUrl: \u0027/project/instances\u0027,"},{"line_number":57,"context_line":"        \u0027imageId\u0027: image.id"},{"line_number":58,"context_line":"      });"}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_46dae8ea","line":55,"in_reply_to":"5aef4532_e64fcb8f","updated":"2016-03-11 07:07:51.000000000","message":"so separate bug?","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"}],"openstack_dashboard/static/app/core/images/table/images-table.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ccec6f4d836e73a3f63b9e5c6f31af3b9ee52541","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      --\u003e"},{"line_number":14,"context_line":"      \u003cth colspan\u003d\"100\" class\u003d\"search-header\"\u003e"},{"line_number":15,"context_line":"        \u003chz-search-bar group-classes\u003d\"input-group\" icon-classes\u003d\"fa-search\"\u003e"},{"line_number":16,"context_line":"          \u003cactions allowed\u003d\"table.imageResourceType.batchActions\" type\u003d\"batch\""},{"line_number":17,"context_line":"                   perform-handler\u003d\"table.actionPerformHandler\"\u003e\u003c/actions\u003e"},{"line_number":18,"context_line":"        \u003c/hz-search-bar\u003e"},{"line_number":19,"context_line":"      \u003c/th\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"5aef4532_0692b74b","line":16,"updated":"2016-03-10 18:42:38.000000000","message":"this isn\u0027t really handling perform or even invoking perform on the actions... it is handling the result.  result-handler would probably better convey what this should be.","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"1fc87f3f2cd052946f2758f0855e0a60cb54033d","unresolved":false,"context_lines":[{"line_number":13,"context_line":"      --\u003e"},{"line_number":14,"context_line":"      \u003cth colspan\u003d\"100\" class\u003d\"search-header\"\u003e"},{"line_number":15,"context_line":"        \u003chz-search-bar group-classes\u003d\"input-group\" icon-classes\u003d\"fa-search\"\u003e"},{"line_number":16,"context_line":"          \u003cactions allowed\u003d\"table.imageResourceType.batchActions\" type\u003d\"batch\""},{"line_number":17,"context_line":"                   perform-handler\u003d\"table.actionPerformHandler\"\u003e\u003c/actions\u003e"},{"line_number":18,"context_line":"        \u003c/hz-search-bar\u003e"},{"line_number":19,"context_line":"      \u003c/th\u003e"}],"source_content_type":"text/html","patch_set":2,"id":"5aef4532_411f895a","line":16,"in_reply_to":"5aef4532_0692b74b","updated":"2016-03-10 23:19:10.000000000","message":"Good point.\n\nReally it is \"here is the function I\u0027d like the result of the perform action to be given to...and hopefully that result  is a promise\"\n\n\"result-handler\" is good. Ideally, actions return promises...but the interface doesn\u0027t strictly require it.","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"}],"openstack_dashboard/static/app/core/images/table/images.controller.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d67b11f1c055344e680a6d0cee1996cc7de58590","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    ctrl.imageResourceType \u003d typeRegistry.getResourceType(imageResourceType);"},{"line_number":66,"context_line":"    ctrl.actionPerformHandler \u003d actionPerformHandler;"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    typeRegistry.initActions(imageResourceType, $scope);"},{"line_number":69,"context_line":"    loadImages();"},{"line_number":70,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_69a8ec77","line":67,"updated":"2016-03-09 19:39:13.000000000","message":"so much nicer without the events.","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d67b11f1c055344e680a6d0cee1996cc7de58590","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    ////////////////////////////////"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    function loadImages() {"},{"line_number":74,"context_line":"      $q.all("},{"line_number":75,"context_line":"        {"},{"line_number":76,"context_line":"          images: glance.getImages(),"}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_09ae8880","line":73,"range":{"start_line":73,"start_character":13,"end_line":73,"end_character":23},"updated":"2016-03-09 19:39:13.000000000","message":"nice refactor","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"c4077b76ceff3ac9d6eec5b009a0fe0d370961f4","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      $scope.$emit(\u0027hzTable:clearSelected\u0027);"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"      // For all actions simply refresh the list of images."},{"line_number":114,"context_line":"      loadImages();"},{"line_number":115,"context_line":"    }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    function actionErrorHandler(reason) { // eslint-disable-line no-unused-vars"}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_cbf6418e","line":114,"updated":"2016-03-10 05:18:14.000000000","message":"If this loads 1000 images (default API result limit, this is potentially expensive call to glance).","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a73aa906fa1fae553e9e7df6e54ee0c8623e953f","unresolved":false,"context_lines":[{"line_number":111,"context_line":"      $scope.$emit(\u0027hzTable:clearSelected\u0027);"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"      // For all actions simply refresh the list of images."},{"line_number":114,"context_line":"      loadImages();"},{"line_number":115,"context_line":"    }"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    function actionErrorHandler(reason) { // eslint-disable-line no-unused-vars"}],"source_content_type":"text/javascript","patch_set":2,"id":"5aef4532_10931ffb","line":114,"in_reply_to":"5aef4532_cbf6418e","updated":"2016-03-10 14:48:21.000000000","message":"True, there may be behavioral issues here in very large sets of data.  But they are probably still preferable for the 80% case than not refreshing.  Also, if there\u0027s a better, more advanced way we should do this, this patch makes such a thing possible.  I won\u0027t -1 on this.","commit_id":"6db2313631718f15b0a28d04545a7d4cf59dc2d4"}],"openstack_dashboard/static/app/core/images/table/images.controller.spec.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"fc0832e4bb482461d9aff357b92abc67f832920d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"          }"},{"line_number":54,"context_line":"        };"},{"line_number":55,"context_line":"      },"},{"line_number":56,"context_line":"      when: function (input, successCallback, errorCallback) {"},{"line_number":57,"context_line":"        return successCallback(input);"},{"line_number":58,"context_line":"      }"},{"line_number":59,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_e291b2f2","line":56,"range":{"start_line":56,"start_character":46,"end_line":56,"end_character":59},"updated":"2016-03-09 20:59:20.000000000","message":"eslint: remove errorCallback.","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"557b6ce9c7f2dd41e065cbd0d918f8bb0b211119","unresolved":false,"context_lines":[{"line_number":53,"context_line":"          }"},{"line_number":54,"context_line":"        };"},{"line_number":55,"context_line":"      },"},{"line_number":56,"context_line":"      when: function (input, successCallback, errorCallback) {"},{"line_number":57,"context_line":"        return successCallback(input);"},{"line_number":58,"context_line":"      }"},{"line_number":59,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_f43dec8f","line":56,"range":{"start_line":56,"start_character":46,"end_line":56,"end_character":59},"in_reply_to":"5aef4532_e291b2f2","updated":"2016-03-09 22:51:43.000000000","message":"Done","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"fc0832e4bb482461d9aff357b92abc67f832920d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      2: {id: \u00272\u0027, is_public: false, owner: \u0027not_me\u0027, filtered_visibility: \u0027Shared with Me\u0027}"},{"line_number":64,"context_line":"    };"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    var $scope, controller, events, detailsRoute;"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    beforeEach(module(\u0027ui.bootstrap\u0027));"},{"line_number":69,"context_line":"    beforeEach(module(\u0027horizon.framework\u0027));"}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_a2b20a92","line":66,"range":{"start_line":66,"start_character":28,"end_line":66,"end_character":34},"updated":"2016-03-09 20:59:20.000000000","message":"eslint: remove events.","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"557b6ce9c7f2dd41e065cbd0d918f8bb0b211119","unresolved":false,"context_lines":[{"line_number":63,"context_line":"      2: {id: \u00272\u0027, is_public: false, owner: \u0027not_me\u0027, filtered_visibility: \u0027Shared with Me\u0027}"},{"line_number":64,"context_line":"    };"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    var $scope, controller, events, detailsRoute;"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    beforeEach(module(\u0027ui.bootstrap\u0027));"},{"line_number":69,"context_line":"    beforeEach(module(\u0027horizon.framework\u0027));"}],"source_content_type":"text/javascript","patch_set":1,"id":"5aef4532_2e29c137","line":66,"range":{"start_line":66,"start_character":28,"end_line":66,"end_character":34},"in_reply_to":"5aef4532_a2b20a92","updated":"2016-03-09 22:51:43.000000000","message":"Done","commit_id":"d28f7ea064f0ad79e8c9b9c09a4940198a206f1b"}]}
