)]}'
{"horizon/templates/horizon/common/_workflow_inner.html":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"bddfbab39398c6f58ba1ea2cb1b4fa8e0dd353fb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  \u003c/form\u003e"},{"line_number":40,"context_line":"\u003c/div\u003e"},{"line_number":41,"context_line":"{% endwith %}"},{"line_number":42,"context_line":"{% block modal-js %}"},{"line_number":43,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"AAAAO3%2F%2F9Rg%3D","line":42,"updated":"2013-05-16 06:05:40.000000000","message":"Moving all this code to _workflow_inner.html will break the code of users that have already extended _workflow.html  to override some of the blocks like modal-js (for adding custom js code).","commit_id":"3bf87640f4cb062e9a5501549b0169d3af986bc8"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"73362111f377b5dbcc95ba691d1b3d9e93842c7a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  \u003c/form\u003e"},{"line_number":40,"context_line":"\u003c/div\u003e"},{"line_number":41,"context_line":"{% endwith %}"},{"line_number":42,"context_line":"{% block modal-js %}"},{"line_number":43,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"AAAAPH%2F%2F%2B1I%3D","line":42,"in_reply_to":"AAAAO3%2F%2F9G4%3D","updated":"2013-05-17 07:19:19.000000000","message":"how about keeping this as _workflow.html.\n\nThen change the name of the other file from _workflow.html to _workflow_base.html?  That name might be more fitting since it is a base layout for the workflow. Just my two cents.","commit_id":"3bf87640f4cb062e9a5501549b0169d3af986bc8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"b92f5cabb9b8d8e8644c1e91ae3e26bd22d19cfb","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  \u003c/form\u003e"},{"line_number":40,"context_line":"\u003c/div\u003e"},{"line_number":41,"context_line":"{% endwith %}"},{"line_number":42,"context_line":"{% block modal-js %}"},{"line_number":43,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"AAAAO3%2F%2F9G4%3D","line":42,"in_reply_to":"AAAAO3%2F%2F9Rg%3D","updated":"2013-05-16 09:53:40.000000000","message":"Ok, that is a valid point, reverting it back. Yet I still think that we have to give Tihomir\u0027s suggestion some consideration, as his point is also good.","commit_id":"3bf87640f4cb062e9a5501549b0169d3af986bc8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"fa3bd64c56a255754e74713454f582b6c608a16b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  \u003c/form\u003e"},{"line_number":40,"context_line":"\u003c/div\u003e"},{"line_number":41,"context_line":"{% endwith %}"},{"line_number":42,"context_line":"{% block modal-js %}"},{"line_number":43,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":2,"id":"AAAAPH%2F%2F%2ByM%3D","line":42,"in_reply_to":"AAAAPH%2F%2F%2B1I%3D","updated":"2013-05-17 08:14:32.000000000","message":"Ok. I called it \"_workflow_wrapper.html\" yesterday but \"base\" sound better.","commit_id":"3bf87640f4cb062e9a5501549b0169d3af986bc8"}],"horizon/templates/horizon/common/action.html":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"4eea8652719d9adbd58e99f7bb6fdd44b9e76e3f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans workflow.name %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":1,"id":"AAAAO3%2F%2F%2Fsc%3D","line":1,"updated":"2013-05-15 09:35:54.000000000","message":"I\u0027m a little concerned about the name \u0027action.html\u0027 for this template. \n\nFirst - all templates in /common begin with \"_\". \n\nSecond - I see some inconsistency with the workflow construction. With introducing WorkflowView, it seems that Workflows are not rendered directly(doing some quick debug with deleting the \u0027render\u0027 method in Workflow class, nothing happened - workflows work....). On the other hand, _wokflow.html is being used in WorkflowView as ajax template, and as base template_name in Workflow class. Although this could be intentional, I find it a bit confusing. \n\n\nFinally, what we have is \"action.html\" includes _workflow.html, and _workflow.html is intended to be a ajax-only template in WorkflowView class. Also \"_workflow.html\" is used as default class in Workflow class. So why not rename action.html to _workflow.html, and _workflow.html to _workflow_inner.html or something like that?","commit_id":"cc3a0cde7fbfdfecd540ac7c1dca240f434d7f67"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"042900ddb7f6ecbb8e160c7144165203f3357415","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans workflow.name %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":1,"id":"AAAAO3%2F%2F%2Ff0%3D","line":1,"in_reply_to":"AAAAO3%2F%2F%2Fsc%3D","updated":"2013-05-15 11:54:34.000000000","message":"Thank you, that\u0027s useful information! I have renamed the templates.","commit_id":"cc3a0cde7fbfdfecd540ac7c1dca240f434d7f67"}],"openstack_dashboard/dashboards/admin/networks/subnets/views.py":[{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"4eea8652719d9adbd58e99f7bb6fdd44b9e76e3f","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class CreateView(project_views.CreateView):"},{"line_number":36,"context_line":"    workflow_class \u003d CreateSubnet"},{"line_number":37,"context_line":"    template_name \u003d \"horizon/common/action.html\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class UpdateView(project_views.UpdateView):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2F1E%3D","line":37,"updated":"2013-05-15 09:35:54.000000000","message":"I\u0027d suggest this to be set as default value in WorkflowView, and to be overridden only if differs from the default. Also related to the other comment in action.html.","commit_id":"cc3a0cde7fbfdfecd540ac7c1dca240f434d7f67"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"042900ddb7f6ecbb8e160c7144165203f3357415","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class CreateView(project_views.CreateView):"},{"line_number":36,"context_line":"    workflow_class \u003d CreateSubnet"},{"line_number":37,"context_line":"    template_name \u003d \"horizon/common/action.html\""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class UpdateView(project_views.UpdateView):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAO3%2F%2F%2FjI%3D","line":37,"in_reply_to":"AAAAO3%2F%2F%2F1E%3D","updated":"2013-05-15 11:54:34.000000000","message":"Done","commit_id":"cc3a0cde7fbfdfecd540ac7c1dca240f434d7f67"}],"openstack_dashboard/dashboards/admin/networks/tests.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"bddfbab39398c6f58ba1ea2cb1b4fa8e0dd353fb","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                      args\u003d[network.id])"},{"line_number":382,"context_line":"        res \u003d self.client.get(url)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        self.assertTemplateUsed(res, \u0027horizon/common/_workflow.html\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    @test.create_stubs({api.quantum: (\u0027network_get\u0027,"},{"line_number":387,"context_line":"                                      \u0027subnet_create\u0027,)})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F9N0%3D","line":384,"updated":"2013-05-16 06:05:40.000000000","message":"I think this test doesn\u0027t make sense  now, since this test that the template used is matching the default workflow template (which happens all the time).\n\nI think this type of test is only useful if the view is using a custom template.","commit_id":"3bf87640f4cb062e9a5501549b0169d3af986bc8"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"73362111f377b5dbcc95ba691d1b3d9e93842c7a","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                      args\u003d[network.id])"},{"line_number":382,"context_line":"        res \u003d self.client.get(url)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        self.assertTemplateUsed(res, \u0027horizon/common/_workflow.html\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    @test.create_stubs({api.quantum: (\u0027network_get\u0027,"},{"line_number":387,"context_line":"                                      \u0027subnet_create\u0027,)})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2F%2B00%3D","line":384,"in_reply_to":"AAAAO3%2F%2F9GI%3D","updated":"2013-05-17 07:19:19.000000000","message":"Okay, I am fine with having a test to check the template used.","commit_id":"3bf87640f4cb062e9a5501549b0169d3af986bc8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"b92f5cabb9b8d8e8644c1e91ae3e26bd22d19cfb","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                      args\u003d[network.id])"},{"line_number":382,"context_line":"        res \u003d self.client.get(url)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        self.assertTemplateUsed(res, \u0027horizon/common/_workflow.html\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    @test.create_stubs({api.quantum: (\u0027network_get\u0027,"},{"line_number":387,"context_line":"                                      \u0027subnet_create\u0027,)})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F9GI%3D","line":384,"in_reply_to":"AAAAO3%2F%2F9N0%3D","updated":"2013-05-16 09:53:40.000000000","message":"What if the default workflow template itself is incorrect? I think we should test this case anyway. And what about url reversing? Shouldn\u0027t we test if we get exactly this template by the url?","commit_id":"3bf87640f4cb062e9a5501549b0169d3af986bc8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"fa3bd64c56a255754e74713454f582b6c608a16b","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                      args\u003d[network.id])"},{"line_number":382,"context_line":"        res \u003d self.client.get(url)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        self.assertTemplateUsed(res, \u0027horizon/common/_workflow.html\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    @test.create_stubs({api.quantum: (\u0027network_get\u0027,"},{"line_number":387,"context_line":"                                      \u0027subnet_create\u0027,)})"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2F%2ByI%3D","line":384,"in_reply_to":"AAAAPH%2F%2F%2B00%3D","updated":"2013-05-17 08:14:32.000000000","message":"Done","commit_id":"3bf87640f4cb062e9a5501549b0169d3af986bc8"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"31b143fa15e4398b0eca43b4e1771515287d81f1","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                      args\u003d[network.id])"},{"line_number":382,"context_line":"        res \u003d self.client.get(url)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        self.assertTemplateUsed(res, \u0027horizon/common/_workflow_base.html\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    @test.create_stubs({api.quantum: (\u0027network_get\u0027,"},{"line_number":387,"context_line":"                                      \u0027subnet_create\u0027,)})"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F%2BRI%3D","line":384,"updated":"2013-05-17 13:53:41.000000000","message":"Might be a good to move the template name to a constant since it is used in a lot of places.","commit_id":"9e699eaa32e894236aaf421b688b99ae29d02a20"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"f9b897c9aab63569d9bf8fde9d7a7cad36e2cbf2","unresolved":false,"context_lines":[{"line_number":381,"context_line":"                      args\u003d[network.id])"},{"line_number":382,"context_line":"        res \u003d self.client.get(url)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        self.assertTemplateUsed(res, \u0027horizon/common/_workflow_base.html\u0027)"},{"line_number":385,"context_line":""},{"line_number":386,"context_line":"    @test.create_stubs({api.quantum: (\u0027network_get\u0027,"},{"line_number":387,"context_line":"                                      \u0027subnet_create\u0027,)})"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2F7Bo%3D","line":384,"in_reply_to":"AAAAPH%2F%2F%2BRI%3D","updated":"2013-05-20 09:33:50.000000000","message":"Done","commit_id":"9e699eaa32e894236aaf421b688b99ae29d02a20"}],"openstack_dashboard/dashboards/admin/networks/urls.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"bddfbab39398c6f58ba1ea2cb1b4fa8e0dd353fb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    url(NETWORKS % \u0027update\u0027, UpdateView.as_view(), name\u003d\u0027update\u0027),"},{"line_number":36,"context_line":"    # for detail view"},{"line_number":37,"context_line":"    url(NETWORKS % \u0027detail\u0027, DetailView.as_view(), name\u003d\u0027detail\u0027),"},{"line_number":38,"context_line":"    url(NETWORKS % \u0027action/subnets/create\u0027, AddSubnetView.as_view(),"},{"line_number":39,"context_line":"        name\u003d\u0027addsubnet\u0027),"},{"line_number":40,"context_line":"    url(NETWORKS % \u0027ports/create\u0027, AddPortView.as_view(), name\u003d\u0027addport\u0027),"},{"line_number":41,"context_line":"    url(r\u0027^(?P\u003cnetwork_id\u003e[^/]+)/action/subnets/(?P\u003csubnet_id\u003e[^/]+)/update$\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F9RU%3D","line":38,"updated":"2013-05-16 06:05:40.000000000","message":"Why are you pre-pending this with \"action\"? This seems not related to refactoring template code.","commit_id":"3bf87640f4cb062e9a5501549b0169d3af986bc8"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"b92f5cabb9b8d8e8644c1e91ae3e26bd22d19cfb","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    url(NETWORKS % \u0027update\u0027, UpdateView.as_view(), name\u003d\u0027update\u0027),"},{"line_number":36,"context_line":"    # for detail view"},{"line_number":37,"context_line":"    url(NETWORKS % \u0027detail\u0027, DetailView.as_view(), name\u003d\u0027detail\u0027),"},{"line_number":38,"context_line":"    url(NETWORKS % \u0027action/subnets/create\u0027, AddSubnetView.as_view(),"},{"line_number":39,"context_line":"        name\u003d\u0027addsubnet\u0027),"},{"line_number":40,"context_line":"    url(NETWORKS % \u0027ports/create\u0027, AddPortView.as_view(), name\u003d\u0027addport\u0027),"},{"line_number":41,"context_line":"    url(r\u0027^(?P\u003cnetwork_id\u003e[^/]+)/action/subnets/(?P\u003csubnet_id\u003e[^/]+)/update$\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAO3%2F%2F9HA%3D","line":38,"in_reply_to":"AAAAO3%2F%2F9RU%3D","updated":"2013-05-16 09:53:40.000000000","message":"Done","commit_id":"3bf87640f4cb062e9a5501549b0169d3af986bc8"}]}
