)]}'
{"openstack_dashboard/templatetags/context_selection.py":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"f030e88305a826d771ee27af94e39e5b54e711a6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"@register.inclusion_tag(\u0027context_selection/_project_list.html\u0027,"},{"line_number":78,"context_line":"                        takes_context\u003dTrue)"},{"line_number":79,"context_line":"def show_project_list(context):"},{"line_number":80,"context_line":"    max_proj \u003d getattr(settings,"},{"line_number":81,"context_line":"                       \u0027DROPDOWN_MAX_ITEMS\u0027,"},{"line_number":82,"context_line":"                       30)"},{"line_number":83,"context_line":"    if \u0027request\u0027 not in context:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_ff1a7b6d","line":80,"updated":"2016-03-15 19:31:01.000000000","message":"This annoys me a tiny bit. There is definitely enough room, not sure why the original author chose to indent it this way. This is just a rant, feel free to ignore.","commit_id":"dcfdc31ce3d6d0c0ab3785a78272af400ee0448f"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"2ce6883787d4339a1df713ef6b06c3314f539b27","unresolved":false,"context_lines":[{"line_number":77,"context_line":"@register.inclusion_tag(\u0027context_selection/_project_list.html\u0027,"},{"line_number":78,"context_line":"                        takes_context\u003dTrue)"},{"line_number":79,"context_line":"def show_project_list(context):"},{"line_number":80,"context_line":"    max_proj \u003d getattr(settings,"},{"line_number":81,"context_line":"                       \u0027DROPDOWN_MAX_ITEMS\u0027,"},{"line_number":82,"context_line":"                       30)"},{"line_number":83,"context_line":"    if \u0027request\u0027 not in context:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_da821600","line":80,"in_reply_to":"1af94dfe_ff1a7b6d","updated":"2016-03-16 08:53:49.000000000","message":"haha... I really want to move all the parameters into one line.\nFeel good to know others(not only me) don\u0027t like this indent too. Just do it. Hope original author will forgive me. :)","commit_id":"dcfdc31ce3d6d0c0ab3785a78272af400ee0448f"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"f030e88305a826d771ee27af94e39e5b54e711a6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return {}"},{"line_number":85,"context_line":"    request \u003d context[\u0027request\u0027]"},{"line_number":86,"context_line":"    context \u003d {\u0027projects\u0027: sorted(context[\u0027authorized_tenants\u0027],"},{"line_number":87,"context_line":"                                  key\u003dlambda x: x.name.lower())[:max_proj],"},{"line_number":88,"context_line":"               \u0027project_id\u0027: request.user.project_id,"},{"line_number":89,"context_line":"               \u0027request\u0027: request}"},{"line_number":90,"context_line":"    return context"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_5b446473","line":87,"updated":"2016-03-15 19:31:01.000000000","message":"This is me being picky, but I think \u0027project\u0027 reads better than \u0027x\u0027. My suggestion would be to move the sorted function out.\n\n\n    projects \u003d sorted(context[\u0027authorized_tenants\u0027],\n                      key\u003dlambda project: project.name.lower())\n\n    context \u003d {\u0027projects\u0027: projects[:max_proj],\n               \u0027project_id\u0027: request.user.project_id,\n               \u0027request\u0027: request}\n\n\nA bit more code, but much easier to read and follow.","commit_id":"dcfdc31ce3d6d0c0ab3785a78272af400ee0448f"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"2ce6883787d4339a1df713ef6b06c3314f539b27","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        return {}"},{"line_number":85,"context_line":"    request \u003d context[\u0027request\u0027]"},{"line_number":86,"context_line":"    context \u003d {\u0027projects\u0027: sorted(context[\u0027authorized_tenants\u0027],"},{"line_number":87,"context_line":"                                  key\u003dlambda x: x.name.lower())[:max_proj],"},{"line_number":88,"context_line":"               \u0027project_id\u0027: request.user.project_id,"},{"line_number":89,"context_line":"               \u0027request\u0027: request}"},{"line_number":90,"context_line":"    return context"}],"source_content_type":"text/x-python","patch_set":1,"id":"1af94dfe_da57b600","line":87,"in_reply_to":"1af94dfe_5b446473","updated":"2016-03-16 08:53:49.000000000","message":"Thanks for your comments, agree that to make code much easier to read.\nDone in patch set 2.","commit_id":"dcfdc31ce3d6d0c0ab3785a78272af400ee0448f"}]}