)]}'
{"openstack_dashboard/dashboards/admin/volumes/volume_types/tables.py":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"b2bc3e21a6c2b1cf2d476691862e16c1d6ea6db5","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    try:"},{"line_number":171,"context_line":"        if not volume_type.encryption.provider:"},{"line_number":172,"context_line":"            return None"},{"line_number":173,"context_line":"    except Exception:"},{"line_number":174,"context_line":"        return None"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    return reverse(\"horizon:admin:volumes:volume_types:type_encryption_detail\","}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_b75f4274","line":173,"updated":"2016-05-13 13:10:31.000000000","message":"will raise attribution exception?","commit_id":"9d9a1c104b62cda89a85242e3558e714ccfa7a46"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"52de2c2ead7a047a7509a95b2abd04438cf81708","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    try:"},{"line_number":171,"context_line":"        if not volume_type.encryption.provider:"},{"line_number":172,"context_line":"            return None"},{"line_number":173,"context_line":"    except Exception:"},{"line_number":174,"context_line":"        return None"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    return reverse(\"horizon:admin:volumes:volume_types:type_encryption_detail\","}],"source_content_type":"text/x-python","patch_set":5,"id":"dab17558_49098e94","line":173,"in_reply_to":"dab17558_b75f4274","updated":"2016-05-17 12:42:57.000000000","message":"I\u0027m not sure but original code (L163) is using try-except. This code is same as above.","commit_id":"9d9a1c104b62cda89a85242e3558e714ccfa7a46"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"08f80f06369674f41a0ae790c741ecd48b0e5a8d","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"def get_volume_type_encryption_link(volume_type):"},{"line_number":170,"context_line":"    try:"},{"line_number":171,"context_line":"        if not volume_type.encryption.provider:"},{"line_number":172,"context_line":"            return None"},{"line_number":173,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_ce05b4c2","line":170,"updated":"2016-06-13 20:13:11.000000000","message":"you could use the \"_does_vol_type_enc_exist\" method here, since it looks like the purpose of this block is to determine whether encryption exists or not","commit_id":"9eb26a1522600bc70b5b741d36202e17d041e914"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1583167e6400f49a05ceea68a2e49140d857e01f","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"def get_volume_type_encryption_link(volume_type):"},{"line_number":170,"context_line":"    try:"},{"line_number":171,"context_line":"        if not volume_type.encryption.provider:"},{"line_number":172,"context_line":"            return None"},{"line_number":173,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7aa08908_0b0680cd","line":170,"in_reply_to":"7aa08908_ce05b4c2","updated":"2016-06-14 05:26:35.000000000","message":"Done","commit_id":"9eb26a1522600bc70b5b741d36202e17d041e914"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"15230346f802b5ef3af9947a0ddc9273a94fce0d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        return None"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    return reverse(\"horizon:admin:volumes:volume_types:type_encryption_detail\","},{"line_number":174,"context_line":"                   kwargs\u003d{\u0027volume_type_id\u0027: volume_type.id})"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"class VolumeTypesFilterAction(tables.FilterAction):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_efd91224","line":174,"updated":"2016-06-15 20:27:25.000000000","message":"I think it is more readable if the \"not\" is not used:\n\nif _does_vol_type_enc_exist(volume_type):\n    return reverse(...)\nelse\n    return None","commit_id":"bb121f2a9d9d3381e14c7e69b8ec1e04615dcf29"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"af1bcf5a71c94898d25e6e7521640fe84ab7b705","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        return reverse(\"horizon:admin:volumes:volume_types:\""},{"line_number":172,"context_line":"                       \"type_encryption_detail\","},{"line_number":173,"context_line":"                       kwargs\u003d{\u0027volume_type_id\u0027: volume_type.id})"},{"line_number":174,"context_line":"    else:"},{"line_number":175,"context_line":"        return None"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class VolumeTypesFilterAction(tables.FilterAction):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_478f1423","line":175,"range":{"start_line":174,"start_character":0,"end_line":175,"end_character":19},"updated":"2016-06-17 10:19:15.000000000","message":"This is not necessary, \u0027return None\u0027 is a default behavior.","commit_id":"c0df4c89d32816026a961f05967ad25fbdca941a"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"3cc528f64d6e5dbb02b24d3cab34c846efbbee9d","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        return reverse(\"horizon:admin:volumes:volume_types:\""},{"line_number":172,"context_line":"                       \"type_encryption_detail\","},{"line_number":173,"context_line":"                       kwargs\u003d{\u0027volume_type_id\u0027: volume_type.id})"},{"line_number":174,"context_line":"    else:"},{"line_number":175,"context_line":"        return None"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"class VolumeTypesFilterAction(tables.FilterAction):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a9d85d2_bb1c8a78","line":175,"range":{"start_line":174,"start_character":0,"end_line":175,"end_character":19},"in_reply_to":"7aa08908_478f1423","updated":"2016-06-20 05:52:11.000000000","message":"Done","commit_id":"c0df4c89d32816026a961f05967ad25fbdca941a"}],"openstack_dashboard/dashboards/project/volumes/templates/volumes/volumes/_detail_overview.html":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"b2bc3e21a6c2b1cf2d476691862e16c1d6ea6db5","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"},{"line_number":38,"context_line":"    \u003cdt\u003e{% trans \"Created\" context \"Created time\" %}\u003c/dt\u003e"},{"line_number":39,"context_line":"    \u003cdd\u003e{{ volume.created_at|parse_date }}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"dab17558_772f9aa1","line":36,"updated":"2016-05-13 13:10:31.000000000","message":"should be None here, right?","commit_id":"9d9a1c104b62cda89a85242e3558e714ccfa7a46"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"52de2c2ead7a047a7509a95b2abd04438cf81708","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"},{"line_number":38,"context_line":"    \u003cdt\u003e{% trans \"Created\" context \"Created time\" %}\u003c/dt\u003e"},{"line_number":39,"context_line":"    \u003cdd\u003e{{ volume.created_at|parse_date }}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":5,"id":"dab17558_a942ba65","line":36,"in_reply_to":"dab17558_772f9aa1","updated":"2016-05-17 12:42:57.000000000","message":"At the moment, whether it is encrypted is expressed as yes or no. \nThis patch doesn\u0027t change this spec.\nAnd, \u0027Bootable\u0027(L30) is also expressed as yes or no, so  I think it doesn\u0027t need to change. how about?","commit_id":"9d9a1c104b62cda89a85242e3558e714ccfa7a46"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"08f80f06369674f41a0ae790c741ecd48b0e5a8d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u003cdd\u003e{{ volume.is_bootable|yesno|capfirst }}\u003c/dd\u003e"},{"line_number":32,"context_line":"    \u003cdt\u003e{% trans \"Encrypted\" %}\u003c/dt\u003e"},{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"}],"source_content_type":"text/html","patch_set":8,"id":"7aa08908_ce8f7421","line":34,"updated":"2016-06-13 20:13:11.000000000","message":"This will always be yes, correct?  Since you are already checking for volume.encrypted before getting here?","commit_id":"9eb26a1522600bc70b5b741d36202e17d041e914"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1583167e6400f49a05ceea68a2e49140d857e01f","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u003cdd\u003e{{ volume.is_bootable|yesno|capfirst }}\u003c/dd\u003e"},{"line_number":32,"context_line":"    \u003cdt\u003e{% trans \"Encrypted\" %}\u003c/dt\u003e"},{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"}],"source_content_type":"text/html","patch_set":8,"id":"7aa08908_a6be81ab","line":34,"in_reply_to":"7aa08908_ce8f7421","updated":"2016-06-14 05:26:35.000000000","message":"Done","commit_id":"9eb26a1522600bc70b5b741d36202e17d041e914"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"08f80f06369674f41a0ae790c741ecd48b0e5a8d","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"},{"line_number":38,"context_line":"    \u003cdt\u003e{% trans \"Created\" context \"Created time\" %}\u003c/dt\u003e"},{"line_number":39,"context_line":"    \u003cdd\u003e{{ volume.created_at|parse_date }}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":8,"id":"7aa08908_ee835001","line":36,"updated":"2016-06-13 20:13:11.000000000","message":"Can this ever be yes?  This is in an else block that already checks whether the volume is encrypted.  Should it just say \"no\"?","commit_id":"9eb26a1522600bc70b5b741d36202e17d041e914"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1583167e6400f49a05ceea68a2e49140d857e01f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{{ volume.encrypted|yesno:_(\"yes,no,-\")|capfirst }}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"},{"line_number":38,"context_line":"    \u003cdt\u003e{% trans \"Created\" context \"Created time\" %}\u003c/dt\u003e"},{"line_number":39,"context_line":"    \u003cdd\u003e{{ volume.created_at|parse_date }}\u003c/dd\u003e"}],"source_content_type":"text/html","patch_set":8,"id":"7aa08908_06de7510","line":36,"in_reply_to":"7aa08908_ee835001","updated":"2016-06-14 05:26:35.000000000","message":"Done","commit_id":"9eb26a1522600bc70b5b741d36202e17d041e914"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"af1bcf5a71c94898d25e6e7521640fe84ab7b705","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u003cdd\u003e{{ volume.is_bootable|yesno|capfirst }}\u003c/dd\u003e"},{"line_number":32,"context_line":"    \u003cdt\u003e{% trans \"Encrypted\" %}\u003c/dt\u003e"},{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{% trans \"Yes\" %}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{% trans \"No\" %}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"},{"line_number":38,"context_line":"    \u003cdt\u003e{% trans \"Created\" context \"Created time\" %}\u003c/dt\u003e"},{"line_number":39,"context_line":"    \u003cdd\u003e{{ volume.created_at|parse_date }}\u003c/dd\u003e"},{"line_number":40,"context_line":"  \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":10,"id":"7aa08908_877f3cde","line":37,"range":{"start_line":34,"start_character":90,"end_line":37,"end_character":15},"updated":"2016-06-17 10:19:15.000000000","message":"Such translation is a little wierd, horizon has no such code.","commit_id":"c0df4c89d32816026a961f05967ad25fbdca941a"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"3cc528f64d6e5dbb02b24d3cab34c846efbbee9d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u003cdd\u003e{{ volume.is_bootable|yesno|capfirst }}\u003c/dd\u003e"},{"line_number":32,"context_line":"    \u003cdt\u003e{% trans \"Encrypted\" %}\u003c/dt\u003e"},{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{% trans \"Yes\" %}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{% trans \"No\" %}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"},{"line_number":38,"context_line":"    \u003cdt\u003e{% trans \"Created\" context \"Created time\" %}\u003c/dt\u003e"},{"line_number":39,"context_line":"    \u003cdd\u003e{{ volume.created_at|parse_date }}\u003c/dd\u003e"},{"line_number":40,"context_line":"  \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":10,"id":"5a9d85d2_fb2571ae","line":37,"range":{"start_line":34,"start_character":90,"end_line":37,"end_character":15},"in_reply_to":"7aa08908_877f3cde","updated":"2016-06-20 05:52:11.000000000","message":"What do you mean? Whether volume is encrypted or not is already checked at L33. So I thought just use \"Yes\" or \"No\".","commit_id":"c0df4c89d32816026a961f05967ad25fbdca941a"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"eb249c6b393b3b19e68038102d93b773f3ea3678","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u003cdd\u003e{{ volume.is_bootable|yesno|capfirst }}\u003c/dd\u003e"},{"line_number":32,"context_line":"    \u003cdt\u003e{% trans \"Encrypted\" %}\u003c/dt\u003e"},{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{% trans \"Yes\" %}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{% trans \"No\" %}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"}],"source_content_type":"text/html","patch_set":11,"id":"3aaa91ec_bb149a9f","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":24},"updated":"2016-06-27 11:35:34.000000000","message":"Seems to me that this change is not needed as the yesno filter is translated (not sure if automatically, but I can see it translated to my local lang)","commit_id":"f464f4b1d3f13fc9a24304d46b688e5147dc2a3c"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"72346da2b25f5bd96a10b9b1ef2114a0d64a258a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u003cdd\u003e{{ volume.is_bootable|yesno|capfirst }}\u003c/dd\u003e"},{"line_number":32,"context_line":"    \u003cdt\u003e{% trans \"Encrypted\" %}\u003c/dt\u003e"},{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{% trans \"Yes\" %}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{% trans \"No\" %}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"}],"source_content_type":"text/html","patch_set":11,"id":"3aaa91ec_cac6cb48","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":24},"in_reply_to":"3aaa91ec_bb149a9f","updated":"2016-06-28 00:05:28.000000000","message":"You are right, but previous comment said it is already judged whether a volume is encrypted or not at L33. So this line and L36 are using just \"Yes\" and \"No\" :)\nHow about ?","commit_id":"f464f4b1d3f13fc9a24304d46b688e5147dc2a3c"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"5533768e2bbae556b476e10dc1c1f271ef9c7de7","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \u003cdd\u003e{{ volume.is_bootable|yesno|capfirst }}\u003c/dd\u003e"},{"line_number":32,"context_line":"    \u003cdt\u003e{% trans \"Encrypted\" %}\u003c/dt\u003e"},{"line_number":33,"context_line":"    {% if volume.encrypted %}"},{"line_number":34,"context_line":"    \u003cdd\u003e\u003ca href\u003d\"{% url \u0027horizon:project:volumes:volumes:encryption_detail\u0027 volume.id %}\"\u003e{% trans \"Yes\" %}\u003c/a\u003e\u003c/dd\u003e"},{"line_number":35,"context_line":"    {% else %}"},{"line_number":36,"context_line":"    \u003cdd\u003e{% trans \"No\" %}\u003c/dd\u003e"},{"line_number":37,"context_line":"    {% endif %}"}],"source_content_type":"text/html","patch_set":11,"id":"3aaa91ec_e247591b","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":24},"in_reply_to":"3aaa91ec_cac6cb48","updated":"2016-06-28 10:16:10.000000000","message":"Indeed you are rigth, thanks!","commit_id":"f464f4b1d3f13fc9a24304d46b688e5147dc2a3c"}],"openstack_dashboard/dashboards/project/volumes/volumes/tables.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"15230346f802b5ef3af9947a0ddc9273a94fce0d","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        return None"},{"line_number":392,"context_line":"    else:"},{"line_number":393,"context_line":"        return reverse(\"horizon:project:volumes:volumes:encryption_detail\","},{"line_number":394,"context_line":"                       kwargs\u003d{\u0027volume_id\u0027: volume.id})"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"class VolumesTableBase(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_6f0a427b","line":394,"updated":"2016-06-15 20:27:25.000000000","message":"I think this also is more readable if the \"not\" is removed:\n\nif hasattr(volume, \u0027encrypted\u0027) and volume.encrypted:\n    return reverse(...)\nelse:\n    return None","commit_id":"bb121f2a9d9d3381e14c7e69b8ec1e04615dcf29"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"af1bcf5a71c94898d25e6e7521640fe84ab7b705","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    if hasattr(volume, \u0027encrypted\u0027) and volume.encrypted:"},{"line_number":391,"context_line":"        return reverse(\"horizon:project:volumes:volumes:encryption_detail\","},{"line_number":392,"context_line":"                       kwargs\u003d{\u0027volume_id\u0027: volume.id})"},{"line_number":393,"context_line":"    else:"},{"line_number":394,"context_line":"        return None"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"class VolumesTableBase(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":10,"id":"7aa08908_07d86c1d","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":19},"updated":"2016-06-17 10:19:15.000000000","message":"This is not necessary, \u0027return None\u0027 is a default behavior.","commit_id":"c0df4c89d32816026a961f05967ad25fbdca941a"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"3cc528f64d6e5dbb02b24d3cab34c846efbbee9d","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    if hasattr(volume, \u0027encrypted\u0027) and volume.encrypted:"},{"line_number":391,"context_line":"        return reverse(\"horizon:project:volumes:volumes:encryption_detail\","},{"line_number":392,"context_line":"                       kwargs\u003d{\u0027volume_id\u0027: volume.id})"},{"line_number":393,"context_line":"    else:"},{"line_number":394,"context_line":"        return None"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"class VolumesTableBase(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a9d85d2_db2a357e","line":394,"range":{"start_line":393,"start_character":0,"end_line":394,"end_character":19},"in_reply_to":"7aa08908_07d86c1d","updated":"2016-06-20 05:52:11.000000000","message":"Done","commit_id":"c0df4c89d32816026a961f05967ad25fbdca941a"}]}
