)]}'
{"openstack_dashboard/dashboards/project/stacks/forms.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                              disable_ssl_certificate_validation\u003dTrue)"},{"line_number":45,"context_line":"            resp, template \u003d h.request(url, \"GET\")"},{"line_number":46,"context_line":"            if resp.status not in (200, 304):"},{"line_number":47,"context_line":"                messages.error(request, \u0027URL returned status %s\u0027 % resp.status)"},{"line_number":48,"context_line":"                return False"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            # neither file or url were given"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fwf8%3D","line":47,"updated":"2013-05-23 18:40:43.000000000","message":"string not set up for localization","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                              disable_ssl_certificate_validation\u003dTrue)"},{"line_number":45,"context_line":"            resp, template \u003d h.request(url, \"GET\")"},{"line_number":46,"context_line":"            if resp.status not in (200, 304):"},{"line_number":47,"context_line":"                messages.error(request, \u0027URL returned status %s\u0027 % resp.status)"},{"line_number":48,"context_line":"                return False"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            # neither file or url were given"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fvx0%3D","line":47,"in_reply_to":"AAAAPH%2F%2Fwf8%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                return False"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            # neither file or url were given"},{"line_number":51,"context_line":"            messages.error(request, \"Please choose a file or provide a url\")"},{"line_number":52,"context_line":"            return False"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # store the template so we can render it next"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FwgE%3D","line":51,"updated":"2013-05-23 18:40:43.000000000","message":"string not set up for localization","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                return False"},{"line_number":49,"context_line":"        else:"},{"line_number":50,"context_line":"            # neither file or url were given"},{"line_number":51,"context_line":"            messages.error(request, \"Please choose a file or provide a url\")"},{"line_number":52,"context_line":"            return False"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # store the template so we can render it next"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fvxw%3D","line":51,"in_reply_to":"AAAAPH%2F%2FwgE%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsSU%3D","line":1,"updated":"2013-05-26 14:45:22.000000000","message":"This code in this file doesn\u0027t look finished and isn\u0027t used anywhere. Remove it?","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrFk%3D","line":1,"in_reply_to":"AAAAPH%2F%2FsSU%3D","updated":"2013-05-28 00:06:49.000000000","message":"Yes, sorry for the noise","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"43fa8a747cade30b7d4802fd6231bc7a4613fc58","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class UploadTemplate(forms.SelfHandlingForm):"},{"line_number":28,"context_line":"    upload_template \u003d forms.FileField(required\u003dFalse)"},{"line_number":29,"context_line":"    http_url \u003d forms.CharField(required\u003dFalse)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def handle(self, request, data):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FuGM%3D","line":28,"updated":"2013-05-24 14:54:01.000000000","message":"Instead of having Django use the \"pretty version\" of the field name, please provide a translatable label value.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"43fa8a747cade30b7d4802fd6231bc7a4613fc58","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class UploadTemplate(forms.SelfHandlingForm):"},{"line_number":28,"context_line":"    upload_template \u003d forms.FileField(required\u003dFalse)"},{"line_number":29,"context_line":"    http_url \u003d forms.CharField(required\u003dFalse)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def handle(self, request, data):"},{"line_number":32,"context_line":"        if \u0027upload_template\u0027 in request.FILES:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FuGE%3D","line":29,"updated":"2013-05-24 14:54:01.000000000","message":"same here.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"c662ba05279cc2edb92ea1462e8128d6a7914ac5","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            api.heat.stack_create(self.request, **fields)"},{"line_number":245,"context_line":"            messages.success(request, _(\"Stack creation started.\"))"},{"line_number":246,"context_line":"            return True"},{"line_number":247,"context_line":"        except:"},{"line_number":248,"context_line":"            exceptions.handle(request, _(\u0027Stack creation failed.\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYdI%3D","line":247,"updated":"2013-07-02 23:04:15.000000000","message":"These kind of drive me crazy.  Can we at least catch Exception as e and log that so we know what happened?  It may show up in the heat log, but having it here is helpful for debugging / turn-on","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"279d768148f805754d4f4b6164b36e38de8941bb","unresolved":false,"context_lines":[{"line_number":244,"context_line":"            api.heat.stack_create(self.request, **fields)"},{"line_number":245,"context_line":"            messages.success(request, _(\"Stack creation started.\"))"},{"line_number":246,"context_line":"            return True"},{"line_number":247,"context_line":"        except:"},{"line_number":248,"context_line":"            exceptions.handle(request, _(\u0027Stack creation failed.\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYIo%3D","line":247,"in_reply_to":"AAAAPn%2F%2FYdI%3D","updated":"2013-07-03 01:03:47.000000000","message":"Go read exceptions.handle.\n\nhttps://github.com/openstack/horizon/blob/master/horizon/exceptions.py#L220\n\nIt\u0027s a centralized set of error handling, logging, etc.\n\nNormally I\u0027d link the docs directly but the doc builder is currently broken.","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"fa5afcfe74a1c8a385b556af16c1e67bdb05ea82","unresolved":false,"context_lines":[{"line_number":245,"context_line":"            messages.success(request, _(\"Stack creation started.\"))"},{"line_number":246,"context_line":"            return True"},{"line_number":247,"context_line":"        except:"},{"line_number":248,"context_line":"            exceptions.handle(request, _(\u0027Stack creation failed.\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FX9I%3D","line":248,"updated":"2013-07-03 02:48:59.000000000","message":"Yeah, I know about that, but I\u0027ve seen exceptions blow right through this and you end up getting a 500 server error with no real information about what happened (or a stack trace in DEBUG mode).  The infrastructure captures a lot of the exceptions, but I know I\u0027ve seen some get through.  Now you\u0027re going to ask me to give an example of when it happened :-)  Either way, I most certainly do NOT think that anyone here is a lazy programmer and the care taken in writing this code is OBVIOUS.","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"}],"openstack_dashboard/dashboards/project/stacks/mappings.py":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import urlparse"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from django.core.urlresolvers import reverse"},{"line_number":20,"context_line":"from django.template.defaultfilters import register"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from openstack_dashboard.api.swift import FOLDER_DELIMITER"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsSM%3D","line":20,"updated":"2013-05-26 14:45:22.000000000","message":"Not sure about adding this filter to defaultfilters, but I guess it does allow all the Heat code to live in one place...","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"}],"openstack_dashboard/dashboards/project/stacks/tables.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            return True"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def action(self, request, stack_id):"},{"line_number":53,"context_line":"        api.heat.stack_delete(request, stack_id)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class StacksUpdateRow(tables.Row):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fwgs%3D","line":53,"updated":"2013-05-23 18:40:43.000000000","message":"try/except needed","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            return True"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def action(self, request, stack_id):"},{"line_number":53,"context_line":"        api.heat.stack_delete(request, stack_id)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class StacksUpdateRow(tables.Row):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FvxE%3D","line":53,"in_reply_to":"AAAAPH%2F%2Fwgs%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"564662c837861cd78810ddc6306860aebd9c6ee0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def action(self, request, stack_id):"},{"line_number":54,"context_line":"        obj \u003d self.table.get_object_by_id(stack_id)"},{"line_number":55,"context_line":"        name \u003d self.table.get_object_display(obj)"},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            api.heat.stack_delete(request, stack_id)"},{"line_number":58,"context_line":"        except Exception as e:"},{"line_number":59,"context_line":"            msg \u003d (_(\u0027Unable to delete stack \"%(name)s\": \"%(msg)s\"\u0027) % {"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2Fu48%3D","line":56,"updated":"2013-05-24 07:42:44.000000000","message":"try-except here is not necessary, BatchAction already wraps each call to action with try-except.  You also get the bonus of automatically appending all record failed into one message.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def action(self, request, stack_id):"},{"line_number":54,"context_line":"        obj \u003d self.table.get_object_by_id(stack_id)"},{"line_number":55,"context_line":"        name \u003d self.table.get_object_display(obj)"},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            api.heat.stack_delete(request, stack_id)"},{"line_number":58,"context_line":"        except Exception as e:"},{"line_number":59,"context_line":"            msg \u003d (_(\u0027Unable to delete stack \"%(name)s\": \"%(msg)s\"\u0027) % {"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrFc%3D","line":56,"in_reply_to":"AAAAPH%2F%2Fu48%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"25a6074b39b69069a1a8584036bd8006fca638fd","unresolved":false,"context_lines":[{"line_number":53,"context_line":"    def action(self, request, stack_id):"},{"line_number":54,"context_line":"        obj \u003d self.table.get_object_by_id(stack_id)"},{"line_number":55,"context_line":"        name \u003d self.table.get_object_display(obj)"},{"line_number":56,"context_line":"        try:"},{"line_number":57,"context_line":"            api.heat.stack_delete(request, stack_id)"},{"line_number":58,"context_line":"        except Exception as e:"},{"line_number":59,"context_line":"            msg \u003d (_(\u0027Unable to delete stack \"%(name)s\": \"%(msg)s\"\u0027) % {"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FuGw%3D","line":56,"in_reply_to":"AAAAPH%2F%2Fu48%3D","updated":"2013-05-24 14:48:47.000000000","message":"oops, my fault Steve missed that it was a BatchAction. Lin\u0027s correct here.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"c662ba05279cc2edb92ea1462e8128d6a7914ac5","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    classes \u003d (\u0027btn-danger\u0027, \u0027btn-terminate\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def action(self, request, stack_id):"},{"line_number":51,"context_line":"        api.heat.stack_delete(request, stack_id)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class StacksUpdateRow(tables.Row):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYcs%3D","line":51,"updated":"2013-07-02 23:04:15.000000000","message":"I\u0027d like to see a try/except around this.  I know it\u0027s not all over Horizon code, but it\u0027s very helpful to have.","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"279d768148f805754d4f4b6164b36e38de8941bb","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    classes \u003d (\u0027btn-danger\u0027, \u0027btn-terminate\u0027)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def action(self, request, stack_id):"},{"line_number":51,"context_line":"        api.heat.stack_delete(request, stack_id)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"class StacksUpdateRow(tables.Row):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYIQ%3D","line":51,"in_reply_to":"AAAAPn%2F%2FYcs%3D","updated":"2013-07-03 01:03:47.000000000","message":"BatchAction has the try/except embedded in it:\n\nhttps://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L569\n\nThis is also documented in the method signature for the base class\u0027 action method: https://github.com/openstack/horizon/blob/master/horizon/tables/actions.py#L532\n\nNormally I\u0027d link the docs directly, but the doc builder is apparently broken.","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"}],"openstack_dashboard/dashboards/project/stacks/tabs.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":30,"context_line":"class StackOverviewTab(tabs.Tab):"},{"line_number":31,"context_line":"    name \u003d _(\"Overview\")"},{"line_number":32,"context_line":"    slug \u003d \"overview\""},{"line_number":33,"context_line":"    template_name \u003d (\"project/stacks/_detail_overview.html\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_context_data(self, request):"},{"line_number":36,"context_line":"        return {\"stack\": self.tab_group.kwargs[\u0027stack\u0027]}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fwg8%3D","line":33,"updated":"2013-05-23 18:40:43.000000000","message":"why parenthesis here?","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"class StackOverviewTab(tabs.Tab):"},{"line_number":31,"context_line":"    name \u003d _(\"Overview\")"},{"line_number":32,"context_line":"    slug \u003d \"overview\""},{"line_number":33,"context_line":"    template_name \u003d (\"project/stacks/_detail_overview.html\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get_context_data(self, request):"},{"line_number":36,"context_line":"        return {\"stack\": self.tab_group.kwargs[\u0027stack\u0027]}"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fvw0%3D","line":33,"in_reply_to":"AAAAPH%2F%2Fwg8%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class ResourceOverviewTab(tabs.Tab):"},{"line_number":40,"context_line":"    name \u003d _(\"Overview\")"},{"line_number":41,"context_line":"    slug \u003d \"resource_overview\""},{"line_number":42,"context_line":"    template_name \u003d (\"project/stacks/_resource_overview.html\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_context_data(self, request):"},{"line_number":45,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fwg0%3D","line":42,"updated":"2013-05-23 18:40:43.000000000","message":"and here?","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class ResourceOverviewTab(tabs.Tab):"},{"line_number":40,"context_line":"    name \u003d _(\"Overview\")"},{"line_number":41,"context_line":"    slug \u003d \"resource_overview\""},{"line_number":42,"context_line":"    template_name \u003d (\"project/stacks/_resource_overview.html\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def get_context_data(self, request):"},{"line_number":45,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fvww%3D","line":42,"in_reply_to":"AAAAPH%2F%2Fwg0%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"}],"openstack_dashboard/dashboards/project/stacks/templates/stacks/_detail_overview.html":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    \u003cdt\u003e{% trans \"Timeout\" %}\u003c/dt\u003e"},{"line_number":62,"context_line":"    \u003cdd\u003e{{ stack.timeout_mins }} Minutes\u003c/dd\u003e"},{"line_number":63,"context_line":"    \u003cdt\u003e{% trans \"Rollback\" %}\u003c/dt\u003e"},{"line_number":64,"context_line":"    \u003cdd\u003e{% if stack.disable_rollback %}Disabled{% else %}Enabled{% endif %}\u003c/dd\u003e"},{"line_number":65,"context_line":"  \u003c/dl\u003e"},{"line_number":66,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"AAAAPH%2F%2Fwfc%3D","line":64,"updated":"2013-05-23 18:40:43.000000000","message":"Disable and Enabled not localized","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    \u003cdt\u003e{% trans \"Timeout\" %}\u003c/dt\u003e"},{"line_number":62,"context_line":"    \u003cdd\u003e{{ stack.timeout_mins }} Minutes\u003c/dd\u003e"},{"line_number":63,"context_line":"    \u003cdt\u003e{% trans \"Rollback\" %}\u003c/dt\u003e"},{"line_number":64,"context_line":"    \u003cdd\u003e{% if stack.disable_rollback %}Disabled{% else %}Enabled{% endif %}\u003c/dd\u003e"},{"line_number":65,"context_line":"  \u003c/dl\u003e"},{"line_number":66,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"AAAAPH%2F%2FvwM%3D","line":64,"in_reply_to":"AAAAPH%2F%2Fwfc%3D","updated":"2013-05-24 02:47:29.000000000","message":"Neither was Minutes\nDone","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"}],"openstack_dashboard/dashboards/project/stacks/templates/stacks/_upload.html":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \"horizon/common/_modal_form.html\" %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block form_id %}upload_template_form{% endblock %}"}],"source_content_type":"text/html","patch_set":9,"id":"AAAAPH%2F%2FsSA%3D","line":1,"updated":"2013-05-26 14:45:22.000000000","message":"This file doesn\u0027t seem to be used anywhere either?","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \"horizon/common/_modal_form.html\" %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block form_id %}upload_template_form{% endblock %}"}],"source_content_type":"text/html","patch_set":9,"id":"AAAAPH%2F%2FrFY%3D","line":1,"in_reply_to":"AAAAPH%2F%2FsSA%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"}],"openstack_dashboard/dashboards/project/stacks/templates/stacks/launch.html":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"564662c837861cd78810ddc6306860aebd9c6ee0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Launch Stack\" %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":9,"id":"AAAAPH%2F%2Fu2s%3D","line":1,"updated":"2013-05-24 07:42:44.000000000","message":"This file can be removed, there is a new workflow default template added that takes cares of this.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Launch Stack\" %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":9,"id":"AAAAPH%2F%2FrFU%3D","line":1,"in_reply_to":"AAAAPH%2F%2Fu2s%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"}],"openstack_dashboard/dashboards/project/stacks/templates/stacks/resource.html":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Resource Detail\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d\"Resource Detail: \"|add:resource.logical_resource_id %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":7,"id":"AAAAPH%2F%2FwfY%3D","line":6,"updated":"2013-05-23 18:40:43.000000000","message":"title not localized","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Resource Detail\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"  {% include \"horizon/common/_page_header.html\" with title\u003d\"Resource Detail: \"|add:resource.logical_resource_id %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":7,"id":"AAAAPH%2F%2FvvY%3D","line":6,"in_reply_to":"AAAAPH%2F%2FwfY%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"}],"openstack_dashboard/dashboards/project/stacks/templates/stacks/upload.html":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Upload Template\" %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":9,"id":"AAAAPH%2F%2FsRk%3D","line":1,"updated":"2013-05-26 14:45:22.000000000","message":"Another unused file?","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Upload Template\" %}{% endblock %}"},{"line_number":4,"context_line":""}],"source_content_type":"text/html","patch_set":9,"id":"AAAAPH%2F%2FrFQ%3D","line":1,"in_reply_to":"AAAAPH%2F%2FsRk%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"}],"openstack_dashboard/dashboards/project/stacks/tests.py":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"22c4dba9e63b93bce79586d9820fdeef244c8453","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    @unittest.skip"},{"line_number":89,"context_line":"    def test_launch_stack_workflow(self):"},{"line_number":90,"context_line":"        # TODO sbaker enable and implement this test when it is find out why"},{"line_number":91,"context_line":"        # self.client.get(url) returns HttpResponseRedirect to the login page"},{"line_number":92,"context_line":"        self.mox.ReplayAll()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        url \u003d reverse(\u0027horizon:project:stacks:launch\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAPH%2F%2F3rM%3D","line":91,"updated":"2013-05-21 10:14:02.000000000","message":"It\u0027s redirecting to the login page because the test user doesn\u0027t have the \"openstack.services.orchestration\" permission as defined in the panel, which means the service doesn\u0027t exist in the test setup. Adding orchestration to the keystone test_data catalogue should fix this:\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/test/test_data/keystone_data.py#L25","commit_id":"2944937bfb0e41e7e29cc30464e376d37d8433e6"}],"openstack_dashboard/dashboards/project/stacks/urls.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from django.conf.urls.defaults import patterns, url"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from .views import IndexView"},{"line_number":18,"context_line":"from .views import LaunchStackView"},{"line_number":19,"context_line":"from .views import DetailView"},{"line_number":20,"context_line":"from .views import ResourceView"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FyJ0%3D","line":17,"updated":"2013-05-23 18:40:43.000000000","message":"could combine into one from statement\nfrom .views import IndexView, LaunchStackView, DetailView, ResourceView","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from django.conf.urls.defaults import patterns, url"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from .views import IndexView"},{"line_number":18,"context_line":"from .views import LaunchStackView"},{"line_number":19,"context_line":"from .views import DetailView"},{"line_number":20,"context_line":"from .views import ResourceView"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FvvU%3D","line":17,"in_reply_to":"AAAAPH%2F%2FyJ0%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"}],"openstack_dashboard/dashboards/project/stacks/views.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from openstack_dashboard import api"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from .tables import StacksTable"},{"line_number":29,"context_line":"from .tabs import StackDetailTabs"},{"line_number":30,"context_line":"from .tabs import ResourceDetailTabs"},{"line_number":31,"context_line":"from .workflows import LaunchStack"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FyJs%3D","line":29,"updated":"2013-05-23 18:40:43.000000000","message":"could combine into one from","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from openstack_dashboard import api"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from .tables import StacksTable"},{"line_number":29,"context_line":"from .tabs import StackDetailTabs"},{"line_number":30,"context_line":"from .tabs import ResourceDetailTabs"},{"line_number":31,"context_line":"from .workflows import LaunchStack"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FvvI%3D","line":29,"in_reply_to":"AAAAPH%2F%2FyJs%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return stack"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_data(self):"},{"line_number":50,"context_line":"        stacks \u003d api.heat.stacks_list(self.request)"},{"line_number":51,"context_line":"        stacks \u003d map(self._inject_name, stacks)"},{"line_number":52,"context_line":"        return stacks"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FwkU%3D","line":50,"updated":"2013-05-23 18:40:43.000000000","message":"wrap the api request in a try/except to prevent unhandled exceptions","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return stack"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def get_data(self):"},{"line_number":50,"context_line":"        stacks \u003d api.heat.stacks_list(self.request)"},{"line_number":51,"context_line":"        stacks \u003d map(self._inject_name, stacks)"},{"line_number":52,"context_line":"        return stacks"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FvrY%3D","line":50,"in_reply_to":"AAAAPH%2F%2FwkU%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    kwargs[\u0027resource_name\u0027])"},{"line_number":109,"context_line":"                self._resource \u003d resource"},{"line_number":110,"context_line":"            except Exception, e:"},{"line_number":111,"context_line":"                messages.error(request, e)"},{"line_number":112,"context_line":"                redirect \u003d reverse(\u0027horizon:project:stacks:index\u0027)"},{"line_number":113,"context_line":"                return HttpResponseRedirect(redirect)"},{"line_number":114,"context_line":"        return self._resource"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fwhg%3D","line":111,"updated":"2013-05-23 18:40:43.000000000","message":"wouldn\u0027t using exceptions.handle() simplify this\n\nthroughout","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                    kwargs[\u0027resource_name\u0027])"},{"line_number":109,"context_line":"                self._resource \u003d resource"},{"line_number":110,"context_line":"            except Exception, e:"},{"line_number":111,"context_line":"                messages.error(request, e)"},{"line_number":112,"context_line":"                redirect \u003d reverse(\u0027horizon:project:stacks:index\u0027)"},{"line_number":113,"context_line":"                return HttpResponseRedirect(redirect)"},{"line_number":114,"context_line":"        return self._resource"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fvpc%3D","line":111,"in_reply_to":"AAAAPH%2F%2Fwhg%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"564662c837861cd78810ddc6306860aebd9c6ee0","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class LaunchStackView(workflows.WorkflowView):"},{"line_number":59,"context_line":"    workflow_class \u003d LaunchStack"},{"line_number":60,"context_line":"    template_name \u003d \"project/stacks/launch.html\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_initial(self):"},{"line_number":63,"context_line":"        initial \u003d super(LaunchStackView, self).get_initial()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2Fu2k%3D","line":60,"updated":"2013-05-24 07:42:44.000000000","message":"You can remove this line and the html template.\n\nThere is a default workflow template defined in WorkflowView that will do the same thing you need in launch.html.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"class LaunchStackView(workflows.WorkflowView):"},{"line_number":59,"context_line":"    workflow_class \u003d LaunchStack"},{"line_number":60,"context_line":"    template_name \u003d \"project/stacks/launch.html\""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def get_initial(self):"},{"line_number":63,"context_line":"        initial \u003d super(LaunchStackView, self).get_initial()"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrFI%3D","line":60,"in_reply_to":"AAAAPH%2F%2Fu2k%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"237ed0554a1c96e2216f0ff8f01e2a9203c62e0e","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from openstack_dashboard import api"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from .tables import StacksTable"},{"line_number":28,"context_line":"from .tabs import ResourceDetailTabs, StackDetailTabs"},{"line_number":29,"context_line":"from .workflows import LaunchStack"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPn%2F%2F5yc%3D","line":28,"updated":"2013-06-18 17:13:49.000000000","message":"needs to be two lines due to updated hacking standards in Horizon","commit_id":"23b2e31f06d39e9f9b6214f2f4c3dbd6023210a5"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"237ed0554a1c96e2216f0ff8f01e2a9203c62e0e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            stacks \u003d map(self._inject_name, stacks)"},{"line_number":52,"context_line":"        except:"},{"line_number":53,"context_line":"            exceptions.handle(request,"},{"line_number":54,"context_line":"                              _(\u0027Unable to retrieve stack list.\u0027))"},{"line_number":55,"context_line":"        return stacks"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAPn%2F%2F5yk%3D","line":54,"updated":"2013-06-18 17:13:49.000000000","message":"missing import of _ causes uncaught exception.","commit_id":"23b2e31f06d39e9f9b6214f2f4c3dbd6023210a5"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"6a57e7f52e09edf6d60008bedd54019f41ef25c1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            stacks \u003d api.heat.stacks_list(self.request)"},{"line_number":47,"context_line":"        except:"},{"line_number":48,"context_line":"            exceptions.handle(request, _(\u0027Unable to retrieve stack list.\u0027))"},{"line_number":49,"context_line":"        return stacks"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAAPn%2F%2Fgbc%3D","line":48,"updated":"2013-07-01 18:55:38.000000000","message":"need to set stacks \u003d []  here","commit_id":"602a3daed6515ccc01f6356383e3715e695a0a75"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"c662ba05279cc2edb92ea1462e8128d6a7914ac5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        request \u003d self.request"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            stacks \u003d api.heat.stacks_list(self.request)"},{"line_number":47,"context_line":"        except:"},{"line_number":48,"context_line":"            exceptions.handle(request, _(\u0027Unable to retrieve stack list.\u0027))"},{"line_number":49,"context_line":"            stacks \u003d []"},{"line_number":50,"context_line":"        return stacks"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYbY%3D","line":47,"updated":"2013-07-02 23:04:15.000000000","message":"Can we log the exception here too?","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"279d768148f805754d4f4b6164b36e38de8941bb","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        request \u003d self.request"},{"line_number":45,"context_line":"        try:"},{"line_number":46,"context_line":"            stacks \u003d api.heat.stacks_list(self.request)"},{"line_number":47,"context_line":"        except:"},{"line_number":48,"context_line":"            exceptions.handle(request, _(\u0027Unable to retrieve stack list.\u0027))"},{"line_number":49,"context_line":"            stacks \u003d []"},{"line_number":50,"context_line":"        return stacks"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYIA%3D","line":47,"in_reply_to":"AAAAPn%2F%2FYbY%3D","updated":"2013-07-03 01:03:47.000000000","message":"See comment in other file.","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"c662ba05279cc2edb92ea1462e8128d6a7914ac5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            try:"},{"line_number":102,"context_line":"                stack \u003d api.heat.stack_get(request, stack_id)"},{"line_number":103,"context_line":"                self._stack \u003d stack"},{"line_number":104,"context_line":"            except:"},{"line_number":105,"context_line":"                msg \u003d _(\"Unable to retrieve stack.\")"},{"line_number":106,"context_line":"                redirect \u003d reverse(\u0027horizon:project:stacks:index\u0027)"},{"line_number":107,"context_line":"                exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYbM%3D","line":104,"updated":"2013-07-02 23:04:15.000000000","message":"Can we log the exception here too","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"279d768148f805754d4f4b6164b36e38de8941bb","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            try:"},{"line_number":102,"context_line":"                stack \u003d api.heat.stack_get(request, stack_id)"},{"line_number":103,"context_line":"                self._stack \u003d stack"},{"line_number":104,"context_line":"            except:"},{"line_number":105,"context_line":"                msg \u003d _(\"Unable to retrieve stack.\")"},{"line_number":106,"context_line":"                redirect \u003d reverse(\u0027horizon:project:stacks:index\u0027)"},{"line_number":107,"context_line":"                exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYH8%3D","line":104,"in_reply_to":"AAAAPn%2F%2FYbM%3D","updated":"2013-07-03 01:03:47.000000000","message":"See comment in other file.","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"c662ba05279cc2edb92ea1462e8128d6a7914ac5","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                    kwargs[\u0027stack_id\u0027],"},{"line_number":131,"context_line":"                    kwargs[\u0027resource_name\u0027])"},{"line_number":132,"context_line":"                self._resource \u003d resource"},{"line_number":133,"context_line":"            except:"},{"line_number":134,"context_line":"                msg \u003d _(\"Unable to retrieve resource.\")"},{"line_number":135,"context_line":"                redirect \u003d reverse(\u0027horizon:project:stacks:index\u0027)"},{"line_number":136,"context_line":"                exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYbA%3D","line":133,"updated":"2013-07-02 23:04:15.000000000","message":"And here? :)","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"279d768148f805754d4f4b6164b36e38de8941bb","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                    kwargs[\u0027stack_id\u0027],"},{"line_number":131,"context_line":"                    kwargs[\u0027resource_name\u0027])"},{"line_number":132,"context_line":"                self._resource \u003d resource"},{"line_number":133,"context_line":"            except:"},{"line_number":134,"context_line":"                msg \u003d _(\"Unable to retrieve resource.\")"},{"line_number":135,"context_line":"                redirect \u003d reverse(\u0027horizon:project:stacks:index\u0027)"},{"line_number":136,"context_line":"                exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYH4%3D","line":133,"in_reply_to":"AAAAPn%2F%2FYbA%3D","updated":"2013-07-03 01:03:47.000000000","message":"See comment in other file.","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"},{"author":{"_account_id":6966,"name":"Jeffrey J. Walls","email":"jeff.walls@hpe.com","username":"ftcjeff"},"change_message_id":"c662ba05279cc2edb92ea1462e8128d6a7914ac5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    kwargs[\u0027stack_id\u0027],"},{"line_number":145,"context_line":"                    kwargs[\u0027resource_name\u0027])"},{"line_number":146,"context_line":"                self._metadata \u003d json.dumps(metadata, indent\u003d2)"},{"line_number":147,"context_line":"            except:"},{"line_number":148,"context_line":"                msg \u003d _(\"Unable to retrieve metadata.\")"},{"line_number":149,"context_line":"                redirect \u003d reverse(\u0027horizon:project:stacks:index\u0027)"},{"line_number":150,"context_line":"                exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYa4%3D","line":147,"updated":"2013-07-02 23:04:15.000000000","message":"Also here :)","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"279d768148f805754d4f4b6164b36e38de8941bb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"                    kwargs[\u0027stack_id\u0027],"},{"line_number":145,"context_line":"                    kwargs[\u0027resource_name\u0027])"},{"line_number":146,"context_line":"                self._metadata \u003d json.dumps(metadata, indent\u003d2)"},{"line_number":147,"context_line":"            except:"},{"line_number":148,"context_line":"                msg \u003d _(\"Unable to retrieve metadata.\")"},{"line_number":149,"context_line":"                redirect \u003d reverse(\u0027horizon:project:stacks:index\u0027)"},{"line_number":150,"context_line":"                exceptions.handle(request, msg, redirect\u003dredirect)"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAPn%2F%2FYH0%3D","line":147,"in_reply_to":"AAAAPn%2F%2FYa4%3D","updated":"2013-07-03 01:03:47.000000000","message":"See comment in other file.","commit_id":"6eb54b20376a6ecec8605d09633dc4b8f5f6c29e"}],"openstack_dashboard/dashboards/project/stacks/workflows.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":48,"context_line":"class SetTemplateAction(workflows.Action):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    class Meta:"},{"line_number":51,"context_line":"        name \u003d (\u0027Select Template\u0027)"},{"line_number":52,"context_line":"        help_text \u003d _(\u0027From here you can select a template to launch \u0027"},{"line_number":53,"context_line":"                      \u0027a stack.\u0027)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FwfI%3D","line":51,"updated":"2013-05-23 18:40:43.000000000","message":"name value not localized","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"class SetTemplateAction(workflows.Action):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    class Meta:"},{"line_number":51,"context_line":"        name \u003d (\u0027Select Template\u0027)"},{"line_number":52,"context_line":"        help_text \u003d _(\u0027From here you can select a template to launch \u0027"},{"line_number":53,"context_line":"                      \u0027a stack.\u0027)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FvpM%3D","line":51,"in_reply_to":"AAAAPH%2F%2FwfI%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"37cabe4900fb49802cf51b1e6446e836ea1ca835","unresolved":false,"context_lines":[{"line_number":127,"context_line":"class SetParametersAction(workflows.Action):"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    class Meta:"},{"line_number":130,"context_line":"        name \u003d (\u0027Set Stack Parameters\u0027)"},{"line_number":131,"context_line":"        help_text \u003d _(\u0027Set the launch parameters for the selected template\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, request, context, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2Fwe4%3D","line":130,"updated":"2013-05-23 18:40:43.000000000","message":"name value not localized","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f80301ceb26c39478015a3ac796f80f18c7b3ff1","unresolved":false,"context_lines":[{"line_number":127,"context_line":"class SetParametersAction(workflows.Action):"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    class Meta:"},{"line_number":130,"context_line":"        name \u003d (\u0027Set Stack Parameters\u0027)"},{"line_number":131,"context_line":"        help_text \u003d _(\u0027Set the launch parameters for the selected template\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, request, context, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAPH%2F%2FvpE%3D","line":130,"in_reply_to":"AAAAPH%2F%2Fwe4%3D","updated":"2013-05-24 02:47:29.000000000","message":"Done","commit_id":"8b454fc996277a0d70dfbff68ae4d28807096ffd"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"564662c837861cd78810ddc6306860aebd9c6ee0","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        required\u003dTrue)"},{"line_number":62,"context_line":"    template_upload \u003d forms.FileField("},{"line_number":63,"context_line":"        label\u003d_(\u0027Template File\u0027),"},{"line_number":64,"context_line":"        help_text\u003d(\u0027A local template to upload.\u0027),"},{"line_number":65,"context_line":"        required\u003dFalse)"},{"line_number":66,"context_line":"    template_url \u003d forms.URLField("},{"line_number":67,"context_line":"        label\u003d_(\u0027Template Location\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2Fu4g%3D","line":64,"updated":"2013-05-24 07:42:44.000000000","message":"Make it translatable","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        required\u003dTrue)"},{"line_number":62,"context_line":"    template_upload \u003d forms.FileField("},{"line_number":63,"context_line":"        label\u003d_(\u0027Template File\u0027),"},{"line_number":64,"context_line":"        help_text\u003d(\u0027A local template to upload.\u0027),"},{"line_number":65,"context_line":"        required\u003dFalse)"},{"line_number":66,"context_line":"    template_url \u003d forms.URLField("},{"line_number":67,"context_line":"        label\u003d_(\u0027Template Location\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrFE%3D","line":64,"in_reply_to":"AAAAPH%2F%2Fu4g%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"564662c837861cd78810ddc6306860aebd9c6ee0","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                \u0027template_upload\u0027].read()"},{"line_number":91,"context_line":"            self.data[\u0027template_data\u0027] \u003d tpl"},{"line_number":92,"context_line":"            if tpl.startswith(\u0027{\u0027):"},{"line_number":93,"context_line":"                cleaned[\u0027template_data\u0027] \u003d json.loads(tpl)"},{"line_number":94,"context_line":"            else:"},{"line_number":95,"context_line":"                cleaned[\u0027template_data\u0027] \u003d tpl"},{"line_number":96,"context_line":"            template_name \u003d self.request.FILES[\u0027template_upload\u0027].name"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2Fu28%3D","line":93,"updated":"2013-05-24 07:42:44.000000000","message":"Would there be a case when this won\u0027t throw invalid json format?\nIf yes, probably need to enclose in try-except.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                \u0027template_upload\u0027].read()"},{"line_number":91,"context_line":"            self.data[\u0027template_data\u0027] \u003d tpl"},{"line_number":92,"context_line":"            if tpl.startswith(\u0027{\u0027):"},{"line_number":93,"context_line":"                cleaned[\u0027template_data\u0027] \u003d json.loads(tpl)"},{"line_number":94,"context_line":"            else:"},{"line_number":95,"context_line":"                cleaned[\u0027template_data\u0027] \u003d tpl"},{"line_number":96,"context_line":"            template_name \u003d self.request.FILES[\u0027template_upload\u0027].name"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrCY%3D","line":93,"in_reply_to":"AAAAPH%2F%2Fu28%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            del self.data[\u0027template_data\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        elif not template_data:"},{"line_number":104,"context_line":"            msg \u003d _(\u0027Select either a \"Template File\" or \"Template Location\"\u0027)"},{"line_number":105,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsUk%3D","line":104,"updated":"2013-05-26 14:45:22.000000000","message":"period here","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            del self.data[\u0027template_data\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        elif not template_data:"},{"line_number":104,"context_line":"            msg \u003d _(\u0027Select either a \"Template File\" or \"Template Location\"\u0027)"},{"line_number":105,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrE8%3D","line":104,"in_reply_to":"AAAAPH%2F%2FsUk%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        except Exception as e:"},{"line_number":117,"context_line":"            msg \u003d exception_to_validation_msg(e)"},{"line_number":118,"context_line":"            if not msg:"},{"line_number":119,"context_line":"                msg \u003d _(\u0027An unknown problem occured validating the template\u0027)"},{"line_number":120,"context_line":"                LOG.error(e)"},{"line_number":121,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsUg%3D","line":119,"updated":"2013-05-26 14:45:22.000000000","message":"*occurred and end with a period.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        except Exception as e:"},{"line_number":117,"context_line":"            msg \u003d exception_to_validation_msg(e)"},{"line_number":118,"context_line":"            if not msg:"},{"line_number":119,"context_line":"                msg \u003d _(\u0027An unknown problem occured validating the template\u0027)"},{"line_number":120,"context_line":"                LOG.error(e)"},{"line_number":121,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrE4%3D","line":119,"in_reply_to":"AAAAPH%2F%2FsUg%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            msg \u003d exception_to_validation_msg(e)"},{"line_number":118,"context_line":"            if not msg:"},{"line_number":119,"context_line":"                msg \u003d _(\u0027An unknown problem occured validating the template\u0027)"},{"line_number":120,"context_line":"                LOG.error(e)"},{"line_number":121,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        #LOG.info(\u0027SetTemplateAction cleaned data %s\u0027 % cleaned)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsUM%3D","line":120,"updated":"2013-05-26 14:45:22.000000000","message":"Probably better to use LOG.exception(msg) here so we get a full traceback in logs.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":117,"context_line":"            msg \u003d exception_to_validation_msg(e)"},{"line_number":118,"context_line":"            if not msg:"},{"line_number":119,"context_line":"                msg \u003d _(\u0027An unknown problem occured validating the template\u0027)"},{"line_number":120,"context_line":"                LOG.error(e)"},{"line_number":121,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        #LOG.info(\u0027SetTemplateAction cleaned data %s\u0027 % cleaned)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrEw%3D","line":120,"in_reply_to":"AAAAPH%2F%2FsUM%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                LOG.error(e)"},{"line_number":121,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        #LOG.info(\u0027SetTemplateAction cleaned data %s\u0027 % cleaned)"},{"line_number":124,"context_line":"        return cleaned"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsUI%3D","line":123,"updated":"2013-05-26 14:45:22.000000000","message":"Remove this or make it debug()?","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                LOG.error(e)"},{"line_number":121,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        #LOG.info(\u0027SetTemplateAction cleaned data %s\u0027 % cleaned)"},{"line_number":124,"context_line":"        return cleaned"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrEs%3D","line":123,"in_reply_to":"AAAAPH%2F%2FsUI%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    class Meta:"},{"line_number":130,"context_line":"        name \u003d _(\u0027Set Stack Parameters\u0027)"},{"line_number":131,"context_line":"        help_text \u003d _(\u0027Set the launch parameters for the selected template\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, request, context, *args, **kwargs):"},{"line_number":134,"context_line":"        super(SetParametersAction, self).__init__("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsTA%3D","line":131,"updated":"2013-05-26 14:45:22.000000000","message":".","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    class Meta:"},{"line_number":130,"context_line":"        name \u003d _(\u0027Set Stack Parameters\u0027)"},{"line_number":131,"context_line":"        help_text \u003d _(\u0027Set the launch parameters for the selected template\u0027)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def __init__(self, request, context, *args, **kwargs):"},{"line_number":134,"context_line":"        super(SetParametersAction, self).__init__("}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrEo%3D","line":131,"in_reply_to":"AAAAPH%2F%2FsTA%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        params_submitted \u003d cleaned.get(\u0027params_submitted\u0027)"},{"line_number":147,"context_line":"        if self.params_rendered and not params_submitted:"},{"line_number":148,"context_line":"            msg \u003d _(\u0027Enter the launch parameters for this template\u0027)"},{"line_number":149,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        context \u003d self.data"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsS8%3D","line":148,"updated":"2013-05-26 14:45:22.000000000","message":".","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        params_submitted \u003d cleaned.get(\u0027params_submitted\u0027)"},{"line_number":147,"context_line":"        if self.params_rendered and not params_submitted:"},{"line_number":148,"context_line":"            msg \u003d _(\u0027Enter the launch parameters for this template\u0027)"},{"line_number":149,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        context \u003d self.data"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrCU%3D","line":148,"in_reply_to":"AAAAPH%2F%2FsS8%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        context \u003d self.data"},{"line_number":152,"context_line":"        parameters \u003d dict((k[8:], v) for (k, v) in cleaned.iteritems()"},{"line_number":153,"context_line":"            if k.startswith(\u0027__param_\u0027))"},{"line_number":154,"context_line":"        fields \u003d {"},{"line_number":155,"context_line":"            \u0027stack_name\u0027: context.get(\u0027stack_name\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsTk%3D","line":152,"updated":"2013-05-26 14:45:22.000000000","message":"This looks a bit magical. Can you store the \u0027__param_\u0027 prefix in a member variable and use that everywhere? (and get its length for the array slice here)","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":149,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"        context \u003d self.data"},{"line_number":152,"context_line":"        parameters \u003d dict((k[8:], v) for (k, v) in cleaned.iteritems()"},{"line_number":153,"context_line":"            if k.startswith(\u0027__param_\u0027))"},{"line_number":154,"context_line":"        fields \u003d {"},{"line_number":155,"context_line":"            \u0027stack_name\u0027: context.get(\u0027stack_name\u0027),"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrEE%3D","line":152,"in_reply_to":"AAAAPH%2F%2FsTk%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            fields[\u0027template\u0027] \u003d template_data"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            api.heat.stack_create(self.request, **fields)"},{"line_number":168,"context_line":"        except Exception as e:"},{"line_number":169,"context_line":"            msg \u003d exception_to_validation_msg(e)"},{"line_number":170,"context_line":"            if not msg:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsR0%3D","line":167,"updated":"2013-05-26 14:45:22.000000000","message":"This seems like an odd place for an API call. Usually the actual work is done in the handle() method of the workflow class.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            fields[\u0027template\u0027] \u003d template_data"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        try:"},{"line_number":167,"context_line":"            api.heat.stack_create(self.request, **fields)"},{"line_number":168,"context_line":"        except Exception as e:"},{"line_number":169,"context_line":"            msg \u003d exception_to_validation_msg(e)"},{"line_number":170,"context_line":"            if not msg:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrD8%3D","line":167,"in_reply_to":"AAAAPH%2F%2FsR0%3D","updated":"2013-05-28 00:06:49.000000000","message":"Yes it is an odd place to do this. The reason is that there is only so much validating that can be done in the template validate call. For now calling stack_create might raise its own validation errors. Eventually there will be enough structure to this validation error that a field can be highlighted too.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        except Exception as e:"},{"line_number":169,"context_line":"            msg \u003d exception_to_validation_msg(e)"},{"line_number":170,"context_line":"            if not msg:"},{"line_number":171,"context_line":"                msg \u003d _(\u0027An unknown problem occured validating the template\u0027)"},{"line_number":172,"context_line":"                LOG.error(e)"},{"line_number":173,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsS4%3D","line":171,"updated":"2013-05-26 14:45:22.000000000","message":".","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        except Exception as e:"},{"line_number":169,"context_line":"            msg \u003d exception_to_validation_msg(e)"},{"line_number":170,"context_line":"            if not msg:"},{"line_number":171,"context_line":"                msg \u003d _(\u0027An unknown problem occured validating the template\u0027)"},{"line_number":172,"context_line":"                LOG.error(e)"},{"line_number":173,"context_line":"            raise forms.ValidationError(msg)"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrD4%3D","line":171,"in_reply_to":"AAAAPH%2F%2FsS4%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"564662c837861cd78810ddc6306860aebd9c6ee0","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    default_steps \u003d (SetTemplate, SetParameters)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def get_success_url(self):"},{"line_number":249,"context_line":"        return reverse(\"horizon:project:stacks:index\")"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def get_failure_url(self):"},{"line_number":252,"context_line":"        return reverse(\"horizon:project:stacks:index\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2Fu3o%3D","line":249,"updated":"2013-05-24 07:42:44.000000000","message":"This method seems not necessary, you can just define success_url\u003dxxx in the class attributes (where success_message is defined)","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":246,"context_line":"    default_steps \u003d (SetTemplate, SetParameters)"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    def get_success_url(self):"},{"line_number":249,"context_line":"        return reverse(\"horizon:project:stacks:index\")"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def get_failure_url(self):"},{"line_number":252,"context_line":"        return reverse(\"horizon:project:stacks:index\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrDw%3D","line":249,"in_reply_to":"AAAAPH%2F%2Fu3o%3D","updated":"2013-05-28 00:06:49.000000000","message":"Done","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"564662c837861cd78810ddc6306860aebd9c6ee0","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def get_success_url(self):"},{"line_number":249,"context_line":"        return reverse(\"horizon:project:stacks:index\")"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def get_failure_url(self):"},{"line_number":252,"context_line":"        return reverse(\"horizon:project:stacks:index\")"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def format_status_message(self, message):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2Fu3U%3D","line":251,"updated":"2013-05-24 07:42:44.000000000","message":"What is this used for? I don\u0027t see this being in the parent Workflow class.","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def get_success_url(self):"},{"line_number":249,"context_line":"        return reverse(\"horizon:project:stacks:index\")"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def get_failure_url(self):"},{"line_number":252,"context_line":"        return reverse(\"horizon:project:stacks:index\")"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def format_status_message(self, message):"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrDs%3D","line":251,"in_reply_to":"AAAAPH%2F%2Fu3U%3D","updated":"2013-05-28 00:06:49.000000000","message":"Deleted","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"982ee657c1eaa85f13e0d6ccdd293316dc40b238","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        return reverse(\"horizon:project:stacks:index\")"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def format_status_message(self, message):"},{"line_number":255,"context_line":"        name \u003d self.context.get(\u0027name\u0027, \u0027unknown stack\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FsT8%3D","line":255,"updated":"2013-05-26 14:45:22.000000000","message":"This function doesn\u0027t seem to do any real work?","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"f43f42ba86572315f4f020ba8c4eb6b068cd6b25","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        return reverse(\"horizon:project:stacks:index\")"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def format_status_message(self, message):"},{"line_number":255,"context_line":"        name \u003d self.context.get(\u0027name\u0027, \u0027unknown stack\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPH%2F%2FrDo%3D","line":255,"in_reply_to":"AAAAPH%2F%2FsT8%3D","updated":"2013-05-28 00:06:49.000000000","message":"Deleted","commit_id":"bea3e50d3bf1caf247b50f220a16803a749b9a54"},{"author":{"_account_id":7714,"name":"Tim Schnell","email":"tim.schnell@rackspace.com","username":"timductive"},"change_message_id":"d55cc1489d70acaf3b747d6924440fdf21987629","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    name \u003d _(\u0027Launch Stack\u0027)"},{"line_number":248,"context_line":"    multipart \u003d True"},{"line_number":249,"context_line":"    finalize_button_name \u003d _(\u0027Next\u0027)"},{"line_number":250,"context_line":"    success_message \u003d _(\u0027Launched stack named \"%(name)s\".\u0027)"},{"line_number":251,"context_line":"    success_url \u003d \"horizon:project:stacks:index\""},{"line_number":252,"context_line":"    failure_message \u003d _(\u0027Unable to launch stack named \"%(name)s\".\u0027)"},{"line_number":253,"context_line":"    default_steps \u003d (SetTemplate, SetParameters)"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAPH%2F%2FdEE%3D","line":250,"updated":"2013-06-03 16:10:20.000000000","message":"This isn\u0027t translating into the stack name, it is displaying as literal.","commit_id":"94f7e4ce4b6c0993ea93f873a72f16626922d983"}]}
