)]}'
{"horizon/static/framework/conf/resource-type-registry.service.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      this.getName \u003d getName;"},{"line_number":67,"context_line":"      this.label \u003d label;"},{"line_number":68,"context_line":"      this.format \u003d format;"},{"line_number":69,"context_line":"      this.type \u003d type;"},{"line_number":70,"context_line":"      this.setLoadFunction \u003d setLoadFunction;"},{"line_number":71,"context_line":"      this.load \u003d load;"},{"line_number":72,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_ee2cf59a","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":15},"updated":"2016-03-23 22:40:23.000000000","message":"given the load function, is this really needed?","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":66,"context_line":"      this.getName \u003d getName;"},{"line_number":67,"context_line":"      this.label \u003d label;"},{"line_number":68,"context_line":"      this.format \u003d format;"},{"line_number":69,"context_line":"      this.type \u003d type;"},{"line_number":70,"context_line":"      this.setLoadFunction \u003d setLoadFunction;"},{"line_number":71,"context_line":"      this.load \u003d load;"},{"line_number":72,"context_line":""}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_f12b0e80","line":69,"range":{"start_line":69,"start_character":11,"end_line":69,"end_character":15},"in_reply_to":"fa0719c6_ee2cf59a","updated":"2016-03-24 14:55:00.000000000","message":"Yes, this is needed for the detailsPath feature, and I foresee it being useful elsewhere as well as this object doesn\u0027t actually know its own reference string.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"a547a305ea9f937cba1a58c9b8db939405d0a70a","unresolved":false,"context_lines":[{"line_number":67,"context_line":"      this.label \u003d label;"},{"line_number":68,"context_line":"      this.format \u003d format;"},{"line_number":69,"context_line":"      this.type \u003d type;"},{"line_number":70,"context_line":"      this.setLoadFunction \u003d setLoadFunction;"},{"line_number":71,"context_line":"      this.load \u003d load;"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"      // These members support the ability of a type to provide a function"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_4a8866c5","line":70,"range":{"start_line":70,"start_character":11,"end_line":70,"end_character":26},"updated":"2016-03-24 00:40:52.000000000","message":"The pattern I\u0027m familiar with for setters and getters would use \"setLoad\" for an attribute named \"load\".\n\nIn this case, I like \"setLoadFunction\" and \"loadFunction\".","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":67,"context_line":"      this.label \u003d label;"},{"line_number":68,"context_line":"      this.format \u003d format;"},{"line_number":69,"context_line":"      this.type \u003d type;"},{"line_number":70,"context_line":"      this.setLoadFunction \u003d setLoadFunction;"},{"line_number":71,"context_line":"      this.load \u003d load;"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"      // These members support the ability of a type to provide a function"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_116162a9","line":70,"range":{"start_line":70,"start_character":11,"end_line":70,"end_character":26},"in_reply_to":"fa0719c6_4a8866c5","updated":"2016-03-24 14:55:00.000000000","message":"I disagree about changing the name...setLoadFunction \"sets the load function.\"  It makes more sense for someone to call .load() to load the data than to call \"loadfunction().\"  This isn\u0027t a typical setter/getter scenario; it\u0027s \"set\" and \"use.\"","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      // load() function, produces a human-readable name."},{"line_number":76,"context_line":"      this.itemNameFunction \u003d defaultItemNameFunction;"},{"line_number":77,"context_line":"      this.setItemNameFunction \u003d setItemNameFunction;"},{"line_number":78,"context_line":"      this.itemName \u003d itemName;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      function defaultItemNameFunction(item) {"},{"line_number":81,"context_line":"        return item.name;"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_8edf3968","line":78,"range":{"start_line":78,"start_character":22,"end_line":78,"end_character":30},"updated":"2016-03-23 22:40:23.000000000","message":"consider getItemName instead.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      // load() function, produces a human-readable name."},{"line_number":76,"context_line":"      this.itemNameFunction \u003d defaultItemNameFunction;"},{"line_number":77,"context_line":"      this.setItemNameFunction \u003d setItemNameFunction;"},{"line_number":78,"context_line":"      this.itemName \u003d itemName;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      function defaultItemNameFunction(item) {"},{"line_number":81,"context_line":"        return item.name;"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_d19eca61","line":78,"range":{"start_line":78,"start_character":22,"end_line":78,"end_character":30},"in_reply_to":"fa0719c6_8edf3968","updated":"2016-03-24 14:55:00.000000000","message":"For the exposed function, or just the internal reference?","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"34c23f9c63ebb8ef6852e5e1a718ed5324887613","unresolved":false,"context_lines":[{"line_number":75,"context_line":"      // load() function, produces a human-readable name."},{"line_number":76,"context_line":"      this.itemNameFunction \u003d defaultItemNameFunction;"},{"line_number":77,"context_line":"      this.setItemNameFunction \u003d setItemNameFunction;"},{"line_number":78,"context_line":"      this.itemName \u003d itemName;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      function defaultItemNameFunction(item) {"},{"line_number":81,"context_line":"        return item.name;"}],"source_content_type":"text/javascript","patch_set":1,"id":"da0c15f0_cdcf29b2","line":78,"range":{"start_line":78,"start_character":22,"end_line":78,"end_character":30},"in_reply_to":"fa0719c6_d19eca61","updated":"2016-03-24 18:24:17.000000000","message":"just the exposed function. Personal preference really. For me \"getItemName\" helps clue me in that it is a function instead of a settable attribute.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":98,"context_line":"      //"},{"line_number":99,"context_line":"      // An identifier of \u0027abc-defg\u0027 would yield \u0027/abc-defg\u0027 which"},{"line_number":100,"context_line":"      // could be used in a details route, such as:"},{"line_number":101,"context_line":"      // \u0027/details/OS::Glance::Image/abc-defg\u0027"},{"line_number":102,"context_line":"      this.pathParser \u003d defaultPathParser;"},{"line_number":103,"context_line":"      this.setPathParser \u003d setPathParser;"},{"line_number":104,"context_line":"      this.parsePath \u003d parsePath;"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_4e424169","line":101,"range":{"start_line":101,"start_character":37,"end_line":101,"end_character":45},"updated":"2016-03-23 22:40:23.000000000","message":"all functions related to this seem like a really exotic use case...","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":98,"context_line":"      //"},{"line_number":99,"context_line":"      // An identifier of \u0027abc-defg\u0027 would yield \u0027/abc-defg\u0027 which"},{"line_number":100,"context_line":"      // could be used in a details route, such as:"},{"line_number":101,"context_line":"      // \u0027/details/OS::Glance::Image/abc-defg\u0027"},{"line_number":102,"context_line":"      this.pathParser \u003d defaultPathParser;"},{"line_number":103,"context_line":"      this.setPathParser \u003d setPathParser;"},{"line_number":104,"context_line":"      this.parsePath \u003d parsePath;"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_f194ae37","line":101,"range":{"start_line":101,"start_character":37,"end_line":101,"end_character":45},"in_reply_to":"fa0719c6_0a85ce05","updated":"2016-03-24 14:55:00.000000000","message":"I could see (as you sort of get to below) having this service rely on a routing service to provide path logic.  We do need path logic somewhere, perhaps outside of the resource type as you suggest.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"a547a305ea9f937cba1a58c9b8db939405d0a70a","unresolved":false,"context_lines":[{"line_number":98,"context_line":"      //"},{"line_number":99,"context_line":"      // An identifier of \u0027abc-defg\u0027 would yield \u0027/abc-defg\u0027 which"},{"line_number":100,"context_line":"      // could be used in a details route, such as:"},{"line_number":101,"context_line":"      // \u0027/details/OS::Glance::Image/abc-defg\u0027"},{"line_number":102,"context_line":"      this.pathParser \u003d defaultPathParser;"},{"line_number":103,"context_line":"      this.setPathParser \u003d setPathParser;"},{"line_number":104,"context_line":"      this.parsePath \u003d parsePath;"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_0a85ce05","line":101,"range":{"start_line":101,"start_character":37,"end_line":101,"end_character":45},"in_reply_to":"fa0719c6_4e424169","updated":"2016-03-24 00:40:52.000000000","message":"I\u0027m having trouble understanding the need for \"path\" in the registry. I\u0027d prefer a \"getId( )\" function in the registry, which I can then use to get the opaque object that the resource likes to use to identify itself. In 99% of cases, that object will be a simple string...but if an object needs to use a complex descriptor, that\u0027s fine too, because the \"id\" returned by getId( ) is passed unmodified to any registry functions, like \"load( )\".","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":213,"context_line":"       * @ngdoc function"},{"line_number":214,"context_line":"       * @name parsePath"},{"line_number":215,"context_line":"       * @description"},{"line_number":216,"context_line":"       * Given a subpath, produce an object that describes the object"},{"line_number":217,"context_line":"       * enough to load it from an API.  This is used in details"},{"line_number":218,"context_line":"       * routes, which must generate an object that has enough"},{"line_number":219,"context_line":"       * fidelity to fetch the object.  In many cases this is a simple"},{"line_number":220,"context_line":"       * ID, but in others there may be multiple IDs that are required"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_1b236aa8","line":217,"range":{"start_line":216,"start_character":26,"end_line":217,"end_character":39},"updated":"2016-03-23 22:40:23.000000000","message":"in fact, the object must conform to a specific format and include:\n- identifier\n- resourceTypeCode - such as \"OS::Glance::Image\"","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":213,"context_line":"       * @ngdoc function"},{"line_number":214,"context_line":"       * @name parsePath"},{"line_number":215,"context_line":"       * @description"},{"line_number":216,"context_line":"       * Given a subpath, produce an object that describes the object"},{"line_number":217,"context_line":"       * enough to load it from an API.  This is used in details"},{"line_number":218,"context_line":"       * routes, which must generate an object that has enough"},{"line_number":219,"context_line":"       * fidelity to fetch the object.  In many cases this is a simple"},{"line_number":220,"context_line":"       * ID, but in others there may be multiple IDs that are required"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_71a1be93","line":217,"range":{"start_line":216,"start_character":26,"end_line":217,"end_character":39},"in_reply_to":"fa0719c6_1b236aa8","updated":"2016-03-24 14:55:00.000000000","message":"Yep, that\u0027s true.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"34c23f9c63ebb8ef6852e5e1a718ed5324887613","unresolved":false,"context_lines":[{"line_number":213,"context_line":"       * @ngdoc function"},{"line_number":214,"context_line":"       * @name parsePath"},{"line_number":215,"context_line":"       * @description"},{"line_number":216,"context_line":"       * Given a subpath, produce an object that describes the object"},{"line_number":217,"context_line":"       * enough to load it from an API.  This is used in details"},{"line_number":218,"context_line":"       * routes, which must generate an object that has enough"},{"line_number":219,"context_line":"       * fidelity to fetch the object.  In many cases this is a simple"},{"line_number":220,"context_line":"       * ID, but in others there may be multiple IDs that are required"}],"source_content_type":"text/javascript","patch_set":1,"id":"da0c15f0_cd0449c8","line":217,"range":{"start_line":216,"start_character":26,"end_line":217,"end_character":39},"in_reply_to":"fa0719c6_71a1be93","updated":"2016-03-24 18:24:17.000000000","message":"my point is just that the comment block didn\u0027t describe the requirements making it hard to use.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"a547a305ea9f937cba1a58c9b8db939405d0a70a","unresolved":false,"context_lines":[{"line_number":272,"context_line":"       ```"},{"line_number":273,"context_line":"       */"},{"line_number":274,"context_line":"      function load(descriptor) {"},{"line_number":275,"context_line":"        return this.loadFunction(descriptor);"},{"line_number":276,"context_line":"      }"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"      /**"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_ca6916fb","line":275,"range":{"start_line":275,"start_character":20,"end_line":275,"end_character":32},"updated":"2016-03-24 00:40:52.000000000","message":"I\u0027d put a safety check here, or use a default initializer to avoid \"loadFunction is not a function\" errors.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":272,"context_line":"       ```"},{"line_number":273,"context_line":"       */"},{"line_number":274,"context_line":"      function load(descriptor) {"},{"line_number":275,"context_line":"        return this.loadFunction(descriptor);"},{"line_number":276,"context_line":"      }"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"      /**"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_91cd7268","line":275,"range":{"start_line":275,"start_character":20,"end_line":275,"end_character":32},"in_reply_to":"fa0719c6_ca6916fb","updated":"2016-03-24 14:55:00.000000000","message":"Good idea","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":291,"context_line":"           + \u0027/listener/\u0027 + descriptor.id"},{"line_number":292,"context_line":"       }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"       var path \u003d resourceType.detailsPath({id: 12, balancerId: \u0027abasefasdf\u0027);"},{"line_number":295,"context_line":"       ```"},{"line_number":296,"context_line":"       */"},{"line_number":297,"context_line":"      function setPathGenerator(func) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_29a2674b","line":294,"updated":"2016-03-23 22:40:23.000000000","message":"missing right brace","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":291,"context_line":"           + \u0027/listener/\u0027 + descriptor.id"},{"line_number":292,"context_line":"       }"},{"line_number":293,"context_line":""},{"line_number":294,"context_line":"       var path \u003d resourceType.detailsPath({id: 12, balancerId: \u0027abasefasdf\u0027);"},{"line_number":295,"context_line":"       ```"},{"line_number":296,"context_line":"       */"},{"line_number":297,"context_line":"      function setPathGenerator(func) {"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_f1e2eed3","line":294,"in_reply_to":"fa0719c6_29a2674b","updated":"2016-03-24 14:55:00.000000000","message":"D\u0027oh!","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":311,"context_line":"       ```"},{"line_number":312,"context_line":"       */"},{"line_number":313,"context_line":"      function detailsPath(descriptor) {"},{"line_number":314,"context_line":"        return \u0027/details/\u0027 + this.type + \u0027/\u0027 + this.pathGenerator(descriptor);"},{"line_number":315,"context_line":"      }"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"      /**"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_7eb25495","line":314,"range":{"start_line":314,"start_character":16,"end_line":314,"end_character":25},"updated":"2016-03-23 22:40:23.000000000","message":"The /details/ part and the path parsing makes me nervous. I feel like the registry needs to stay focused on types and the actions and views associated with a type.  I\u0027m thinking there is some other details service that knows how to build routes to the subset of \"details\" views. It might be that service that knows what part of the path contains types and descriptors.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":311,"context_line":"       ```"},{"line_number":312,"context_line":"       */"},{"line_number":313,"context_line":"      function detailsPath(descriptor) {"},{"line_number":314,"context_line":"        return \u0027/details/\u0027 + this.type + \u0027/\u0027 + this.pathGenerator(descriptor);"},{"line_number":315,"context_line":"      }"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"      /**"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_d176ca04","line":314,"range":{"start_line":314,"start_character":16,"end_line":314,"end_character":25},"in_reply_to":"fa0719c6_7eb25495","updated":"2016-03-24 14:55:00.000000000","message":"We could do that, perhaps have this service rely on a routing service, so the end code doesn\u0027t have to be aware of anything in particular other than the resource type.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"34c23f9c63ebb8ef6852e5e1a718ed5324887613","unresolved":false,"context_lines":[{"line_number":311,"context_line":"       ```"},{"line_number":312,"context_line":"       */"},{"line_number":313,"context_line":"      function detailsPath(descriptor) {"},{"line_number":314,"context_line":"        return \u0027/details/\u0027 + this.type + \u0027/\u0027 + this.pathGenerator(descriptor);"},{"line_number":315,"context_line":"      }"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"      /**"}],"source_content_type":"text/javascript","patch_set":1,"id":"da0c15f0_edaf8d92","line":314,"range":{"start_line":314,"start_character":16,"end_line":314,"end_character":25},"in_reply_to":"fa0719c6_d176ca04","updated":"2016-03-24 18:24:17.000000000","message":"Here is what I\u0027m imagining:\n\nI\u0027m some random view...and I\u0027ve just stumbled across a resource type that calls itself \"OS::Cinder::Volumes\"\n\nI\u0027d like present a link, that when clicked, goes to the first registered \"list view\" provider.\n\nThat list view provider is the searchlight panel. In other distributions, it might be a different panel that knows how to show a list of cinder volumes.\n\nThe search panel is somehow able to advertise that it provides list views for many, many types...but other list view providers may only support 1 or 2 types.\n\nI think that is related to your details experiment.\n\ne.g. Is there a view provider registered that can show details for a {type: OS::Cinder::Volume, id: foobar} ?","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"dab17558_f633b5f4","updated":"2016-05-12 18:56:49.000000000","message":"i reviewed from bottom up, so order of my comments are backward :P","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      this.setItemNameFunction \u003d setItemNameFunction;"},{"line_number":78,"context_line":"      this.itemName \u003d itemName;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"      function defaultItemNameFunction(item) {"},{"line_number":81,"context_line":"        return item.name;"},{"line_number":82,"context_line":"      }"},{"line_number":83,"context_line":""}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_a281e8fd","line":80,"updated":"2016-05-12 18:56:49.000000000","message":"should move all these functions below to separate declarations and implementations. This is more inline with JPs style guide.","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":196,"context_line":"       ```"},{"line_number":197,"context_line":"       getResourceType(\u0027thing\u0027).setPathParser(func);"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"       function func(path) {"},{"line_number":200,"context_line":"         return path.replace(\u0027-\u0027, \u0027\u0027);"},{"line_number":201,"context_line":"       }"},{"line_number":202,"context_line":""}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_d619517b","line":199,"updated":"2016-05-12 18:56:49.000000000","message":"ditto","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":222,"context_line":"       ```"},{"line_number":223,"context_line":"       getResourceType(\u0027thing\u0027).setPathParser(func);"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"       function func(path) {"},{"line_number":226,"context_line":"         return path.replace(\u0027-\u0027, \u0027\u0027);"},{"line_number":227,"context_line":"       }"},{"line_number":228,"context_line":""}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_7656a507","line":225,"updated":"2016-05-12 18:56:49.000000000","message":"ditto","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":242,"context_line":"       ```"},{"line_number":243,"context_line":"       getResourceType(\u0027thing\u0027).setLoadFunction(func);"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"       function func(descriptor) {"},{"line_number":246,"context_line":"         return someApi.get(descriptor.id);"},{"line_number":247,"context_line":"       }"},{"line_number":248,"context_line":""}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_222fb8a2","line":245,"updated":"2016-05-12 18:56:49.000000000","message":"Styling suggestion, perhaps a better name of the function will make it more easier to understand. function fetchData(descriptor){...}","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":246,"context_line":"         return someApi.get(descriptor.id);"},{"line_number":247,"context_line":"       }"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"       var descriptor \u003d resourceType.parsePath(path);"},{"line_number":250,"context_line":"       ```"},{"line_number":251,"context_line":"       */"},{"line_number":252,"context_line":"      function setLoadFunction(func) {"}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_427d9ce6","line":249,"updated":"2016-05-12 18:56:49.000000000","message":"not sure why this example has parsePath in it.","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":261,"context_line":"       * Loads a single item"},{"line_number":262,"context_line":"       * @example"},{"line_number":263,"context_line":"       ```"},{"line_number":264,"context_line":"       getResourceType(\u0027thing\u0027).setLoadFunction(func);"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"       function func(descriptor) {"},{"line_number":267,"context_line":"         return someApi.get(descriptor.id);"}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_625f0076","line":264,"updated":"2016-05-12 18:56:49.000000000","message":"shouldnt this be load?","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":267,"context_line":"         return someApi.get(descriptor.id);"},{"line_number":268,"context_line":"       }"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"       var descriptor \u003d resourceType.parsePath(path);"},{"line_number":271,"context_line":"       ```"},{"line_number":272,"context_line":"       */"},{"line_number":273,"context_line":"      function load(descriptor) {"}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_e26c9038","line":270,"updated":"2016-05-12 18:56:49.000000000","message":"same here.","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"eb885cb6d46094e79efeeb55897d43021f52a0f8","unresolved":false,"context_lines":[{"line_number":440,"context_line":"      angular.forEach(resourceTypes[type].batchActions, setActionScope);"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"      function setActionScope(action) {"},{"line_number":443,"context_line":"        if (action.service.initScope) {"},{"line_number":444,"context_line":"          action.service.initScope(scope.$new());"},{"line_number":445,"context_line":"        }"},{"line_number":446,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_e77d7d1d","line":443,"range":{"start_line":443,"start_character":12,"end_line":443,"end_character":36},"updated":"2016-05-09 17:26:35.000000000","message":"Probably should check to see if action is actually there.","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"a0b9d2a36f7e209510c149dff837a8b004943833","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    function setDefaultDetailsTemplateUrl(url) {"},{"line_number":413,"context_line":"      defaultDetailsTemplateUrl \u003d url;"},{"line_number":414,"context_line":"      return this;"},{"line_number":415,"context_line":"    }"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    /*"},{"line_number":418,"context_line":"     * @ngdoc function"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_64379eff","line":415,"updated":"2016-05-16 11:42:46.000000000","message":"What is this default details template supposed to be? By default, do you mean the template url that Horizon provides, that may be overridden by customisations? I followed the logic through the template and controllers, and wasn\u0027t sure what this was supposed to represent, and how that is different to the overview.html that we provide for example.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e87b677d99db2d718406f0f9df7c4364d06778f1","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    function setDefaultDetailsTemplateUrl(url) {"},{"line_number":413,"context_line":"      defaultDetailsTemplateUrl \u003d url;"},{"line_number":414,"context_line":"      return this;"},{"line_number":415,"context_line":"    }"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    /*"},{"line_number":418,"context_line":"     * @ngdoc function"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_a348525d","line":415,"in_reply_to":"dab17558_64379eff","updated":"2016-05-16 14:16:45.000000000","message":"That is correct; the idea is that in the case that someone links to a details page for a resource and there is no view registered, there can be a default view.  For example, if there\u0027s a generic property viewer, that could display the resource.  There isn\u0027t one implemented in default right now for Horizon, but maybe there could be.\n\nI can add some more documentation about this.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"320d9f065267ade21b6fe51fe82c0260f86248d7","unresolved":false,"context_lines":[{"line_number":412,"context_line":"    function setDefaultDetailsTemplateUrl(url) {"},{"line_number":413,"context_line":"      defaultDetailsTemplateUrl \u003d url;"},{"line_number":414,"context_line":"      return this;"},{"line_number":415,"context_line":"    }"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"    /*"},{"line_number":418,"context_line":"     * @ngdoc function"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_51f7b0d2","line":415,"in_reply_to":"dab17558_a348525d","updated":"2016-05-16 14:50:05.000000000","message":"Done","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"}],"horizon/static/framework/conf/resource-type-registry.service.spec.js":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"a0b9d2a36f7e209510c149dff837a8b004943833","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      });"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"      it(\u0027setItemNameFunction supplies a function for interpreting names\u0027, function() {"},{"line_number":199,"context_line":"        var item \u003d {name: \u0027MegaMan\u0027};"},{"line_number":200,"context_line":"        var func \u003d function(x) { return \u0027Mr. \u0027 + x.name; };"},{"line_number":201,"context_line":"        type.setItemNameFunction(func);"},{"line_number":202,"context_line":"        expect(type.itemName(item)).toBe(\u0027Mr. MegaMan\u0027);"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_e9cc078b","line":199,"updated":"2016-05-16 11:42:46.000000000","message":"Brilliant.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e87b677d99db2d718406f0f9df7c4364d06778f1","unresolved":false,"context_lines":[{"line_number":196,"context_line":"      });"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"      it(\u0027setItemNameFunction supplies a function for interpreting names\u0027, function() {"},{"line_number":199,"context_line":"        var item \u003d {name: \u0027MegaMan\u0027};"},{"line_number":200,"context_line":"        var func \u003d function(x) { return \u0027Mr. \u0027 + x.name; };"},{"line_number":201,"context_line":"        type.setItemNameFunction(func);"},{"line_number":202,"context_line":"        expect(type.itemName(item)).toBe(\u0027Mr. MegaMan\u0027);"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_63694abe","line":199,"in_reply_to":"dab17558_e9cc078b","updated":"2016-05-16 14:16:45.000000000","message":"Thanks!  I never know what my brain will produce.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"}],"horizon/static/framework/widgets/details/details.directive.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   * @example"},{"line_number":32,"context_line":"   *"},{"line_number":33,"context_line":"   * ```"},{"line_number":34,"context_line":"   * \u003chz-details details\u003d\"ctrl.myDetailsList\"\u003e\u003c/hz-details\u003e"},{"line_number":35,"context_line":"   * ```"},{"line_number":36,"context_line":"   *"},{"line_number":37,"context_line":"   */"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_a9b4b734","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":24},"updated":"2016-03-23 22:40:23.000000000","message":"detailsViews","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8b2eeb803c9aa523d911817772b163b3cd32ed12","unresolved":false,"context_lines":[{"line_number":31,"context_line":"   * @example"},{"line_number":32,"context_line":"   *"},{"line_number":33,"context_line":"   * ```"},{"line_number":34,"context_line":"   * \u003chz-details details\u003d\"ctrl.myDetailsList\"\u003e\u003c/hz-details\u003e"},{"line_number":35,"context_line":"   * ```"},{"line_number":36,"context_line":"   *"},{"line_number":37,"context_line":"   */"}],"source_content_type":"text/javascript","patch_set":1,"id":"ba0121b8_a774db35","line":34,"range":{"start_line":34,"start_character":17,"end_line":34,"end_character":24},"in_reply_to":"fa0719c6_a9b4b734","updated":"2016-03-31 16:03:15.000000000","message":"Done","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":41,"context_line":"      scope: {"},{"line_number":42,"context_line":"        details: \u0027\u003ddetails\u0027,"},{"line_number":43,"context_line":"        descriptor: \u0027\u003ddescriptor\u0027"},{"line_number":44,"context_line":"      },"},{"line_number":45,"context_line":"      templateUrl: $window.STATIC_URL + \u0027framework/widgets/details/details.html\u0027"},{"line_number":46,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_497a3b78","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":18},"updated":"2016-03-23 22:40:23.000000000","message":"please give example of descriptor in comment above","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8b2eeb803c9aa523d911817772b163b3cd32ed12","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":41,"context_line":"      scope: {"},{"line_number":42,"context_line":"        details: \u0027\u003ddetails\u0027,"},{"line_number":43,"context_line":"        descriptor: \u0027\u003ddescriptor\u0027"},{"line_number":44,"context_line":"      },"},{"line_number":45,"context_line":"      templateUrl: $window.STATIC_URL + \u0027framework/widgets/details/details.html\u0027"},{"line_number":46,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":1,"id":"ba0121b8_8771d746","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":18},"in_reply_to":"fa0719c6_497a3b78","updated":"2016-03-31 16:03:15.000000000","message":"Done","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        details: \u0027\u003ddetails\u0027,"},{"line_number":43,"context_line":"        descriptor: \u0027\u003ddescriptor\u0027"},{"line_number":44,"context_line":"      },"},{"line_number":45,"context_line":"      templateUrl: $window.STATIC_URL + \u0027framework/widgets/details/details.html\u0027"},{"line_number":46,"context_line":"    };"},{"line_number":47,"context_line":"    return directive;"},{"line_number":48,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_094fa36b","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":50},"updated":"2016-03-23 22:40:23.000000000","message":"-1: use \u0027horizon.framework.basePath\u0027 from the framework.module.js instead.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8b2eeb803c9aa523d911817772b163b3cd32ed12","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        details: \u0027\u003ddetails\u0027,"},{"line_number":43,"context_line":"        descriptor: \u0027\u003ddescriptor\u0027"},{"line_number":44,"context_line":"      },"},{"line_number":45,"context_line":"      templateUrl: $window.STATIC_URL + \u0027framework/widgets/details/details.html\u0027"},{"line_number":46,"context_line":"    };"},{"line_number":47,"context_line":"    return directive;"},{"line_number":48,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":1,"id":"ba0121b8_87a8b778","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":50},"in_reply_to":"da0c15f0_edb4add2","updated":"2016-03-31 16:03:15.000000000","message":"Yeah, let me take a look at this.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        details: \u0027\u003ddetails\u0027,"},{"line_number":43,"context_line":"        descriptor: \u0027\u003ddescriptor\u0027"},{"line_number":44,"context_line":"      },"},{"line_number":45,"context_line":"      templateUrl: $window.STATIC_URL + \u0027framework/widgets/details/details.html\u0027"},{"line_number":46,"context_line":"    };"},{"line_number":47,"context_line":"    return directive;"},{"line_number":48,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_710a5e27","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":50},"in_reply_to":"fa0719c6_094fa36b","updated":"2016-03-24 14:55:00.000000000","message":"Yeah, I never liked that approach because it\u0027s just adding a lot of indirection with no added value.  Actually, we can just use relative paths, but we seem unwilling to accept that as a practice. :)","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"34c23f9c63ebb8ef6852e5e1a718ed5324887613","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        details: \u0027\u003ddetails\u0027,"},{"line_number":43,"context_line":"        descriptor: \u0027\u003ddescriptor\u0027"},{"line_number":44,"context_line":"      },"},{"line_number":45,"context_line":"      templateUrl: $window.STATIC_URL + \u0027framework/widgets/details/details.html\u0027"},{"line_number":46,"context_line":"    };"},{"line_number":47,"context_line":"    return directive;"},{"line_number":48,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":1,"id":"da0c15f0_edb4add2","line":45,"range":{"start_line":45,"start_character":19,"end_line":45,"end_character":50},"in_reply_to":"fa0719c6_710a5e27","updated":"2016-03-24 18:24:17.000000000","message":"I don\u0027t think it is good for many files to know that $window.STATIC_URL + \u0027framework.... is the base path. It makes code maintenance and relocation hard.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"9f868543ffb52866f7eae24c55f7db73bba80ac1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   * @example"},{"line_number":36,"context_line":"   *"},{"line_number":37,"context_line":"   * ```"},{"line_number":38,"context_line":"   * \u003chz-details detailsViews\u003d\"ctrl.myDetailsList\" descriptor\u003d\"item.descriptor\"\u003e\u003c/hz-details\u003e"},{"line_number":39,"context_line":"   * ```"},{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   */"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_f3ea12da","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":29},"updated":"2016-03-31 16:33:57.000000000","message":"details-views","commit_id":"1cb7e509d884683a441f691b24a814d4bd92b28f"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"72e6d110599208bab3832204bdffe39fe4896ff0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   * @example"},{"line_number":36,"context_line":"   *"},{"line_number":37,"context_line":"   * ```"},{"line_number":38,"context_line":"   * \u003chz-details detailsViews\u003d\"ctrl.myDetailsList\" descriptor\u003d\"item.descriptor\"\u003e\u003c/hz-details\u003e"},{"line_number":39,"context_line":"   * ```"},{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   */"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_56376cfe","line":38,"range":{"start_line":38,"start_character":24,"end_line":38,"end_character":29},"in_reply_to":"ba0121b8_f3ea12da","updated":"2016-03-31 17:05:41.000000000","message":"Done","commit_id":"1cb7e509d884683a441f691b24a814d4bd92b28f"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":35,"context_line":"   * @example"},{"line_number":36,"context_line":"   *"},{"line_number":37,"context_line":"   * ```"},{"line_number":38,"context_line":"   * \u003chz-details details-views\u003d\"ctrl.myDetailsList\" descriptor\u003d\"item.descriptor\"\u003e\u003c/hz-details\u003e"},{"line_number":39,"context_line":"   * ```"},{"line_number":40,"context_line":"   *"},{"line_number":41,"context_line":"   */"}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_a27ba87a","line":38,"updated":"2016-05-12 18:56:49.000000000","message":"Provide an example of myDetailsList and descriptor. We have no idea what those objects look like.","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    var directive \u003d {"},{"line_number":44,"context_line":"      restrict: \u0027E\u0027,"},{"line_number":45,"context_line":"      scope: {"},{"line_number":46,"context_line":"        detailsViews: \u0027\u003ddetailsViews\u0027,"},{"line_number":47,"context_line":"        descriptor: \u0027\u003ddescriptor\u0027,"},{"line_number":48,"context_line":"        defaultTemplateUrl: \u0027\u003ddefaultTemplateUrl\u0027"},{"line_number":49,"context_line":"      },"}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_877156e3","line":46,"updated":"2016-05-12 18:56:49.000000000","message":"can probably simplify to just views attr since we are already using in context to hzDetails.","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1031d20dc6d5f654c8fc5fd953d77deef46998de","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   * };"},{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * markup:"},{"line_number":47,"context_line":"   * \u003chz-details details-views\u003d\"ctrl.myDetailsList\" descriptor\u003d\"item.context\"\u003e\u003c/hz-details\u003e"},{"line_number":48,"context_line":"   * ```"},{"line_number":49,"context_line":"   *"},{"line_number":50,"context_line":"   */"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_83c26e51","line":47,"updated":"2016-05-16 14:18:37.000000000","message":"\u003chz-details\n     views\u003d\"ctrl.resourceType.detailsViews\"\n     context\u003d\"ctrl.context\"\n     default-template-url\u003d\"ctrl.defaultTemplateUrl\"\n  \u003e\u003c/hz-details\u003e\n\nhow about use the example code?","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"320d9f065267ade21b6fe51fe82c0260f86248d7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"   * };"},{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * markup:"},{"line_number":47,"context_line":"   * \u003chz-details details-views\u003d\"ctrl.myDetailsList\" descriptor\u003d\"item.context\"\u003e\u003c/hz-details\u003e"},{"line_number":48,"context_line":"   * ```"},{"line_number":49,"context_line":"   *"},{"line_number":50,"context_line":"   */"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_511e900c","line":47,"in_reply_to":"dab17558_83c26e51","updated":"2016-05-16 14:50:05.000000000","message":"Good idea.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"}],"horizon/static/framework/widgets/details/details.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"fd74c86d8710edced72b84b7e4ff7998dea32b70","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-if\u003d\"details.length \u003e 1\"\u003e"},{"line_number":2,"context_line":"  \u003ctabset\u003e"},{"line_number":3,"context_line":"    \u003ctab ng-repeat\u003d\"detail in details\" heading\u003d\"{$ detail.name $}\"\u003e"},{"line_number":4,"context_line":"      \u003cng-include src\u003d\"detail.template\"\u003e\u003c/ng-include\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"ba0121b8_515dbd45","line":1,"updated":"2016-03-31 15:30:36.000000000","message":"Can we add some contextual class names throughout this template?","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"2af6250155936557bdd3b8c5857af9847c5e6585","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-if\u003d\"views.length \u003e 1\"\u003e"},{"line_number":2,"context_line":"  \u003ctabset class\u003d\"tabset-details\"\u003e"},{"line_number":3,"context_line":"    \u003ctab class\u003d\"tab-details\" ng-repeat\u003d\"view in views\" heading\u003d\"{$ view.name $}\"\u003e"},{"line_number":4,"context_line":"      \u003cng-include src\u003d\"view.template\"\u003e\u003c/ng-include\u003e"},{"line_number":5,"context_line":"    \u003c/tab\u003e"},{"line_number":6,"context_line":"  \u003c/tabset\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"dab17558_baa7c3a5","line":3,"updated":"2016-05-17 00:06:59.000000000","message":"should this be track by view.id?\n\nshould views by one time binding?","commit_id":"11968c840cc88ef29fcd49b9c8f4f2f66328e35c"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"cb46f393bad09373091a39310933f45ec64869cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-if\u003d\"views.length \u003e 1\"\u003e"},{"line_number":2,"context_line":"  \u003ctabset class\u003d\"tabset-details\"\u003e"},{"line_number":3,"context_line":"    \u003ctab class\u003d\"tab-details\" ng-repeat\u003d\"view in views\" heading\u003d\"{$ view.name $}\"\u003e"},{"line_number":4,"context_line":"      \u003cng-include src\u003d\"view.template\"\u003e\u003c/ng-include\u003e"},{"line_number":5,"context_line":"    \u003c/tab\u003e"},{"line_number":6,"context_line":"  \u003c/tabset\u003e"}],"source_content_type":"text/html","patch_set":22,"id":"dab17558_c3745bff","line":3,"in_reply_to":"dab17558_baa7c3a5","updated":"2016-05-17 00:17:16.000000000","message":"Discussed with Matt and decided no.","commit_id":"11968c840cc88ef29fcd49b9c8f4f2f66328e35c"}],"horizon/static/framework/widgets/details/generic-details.controller.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    ctrl.resourceType \u003d registry.getResourceType($routeParams.type);"},{"line_number":34,"context_line":"    ctrl.descriptor \u003d ctrl.resourceType.parsePath($routeParams.path);"},{"line_number":35,"context_line":"    ctrl.descriptor.item \u003d ctrl.resourceType.load(ctrl.descriptor.identifier);"},{"line_number":36,"context_line":"    ctrl.descriptor.item.then(function loadData(response) {"},{"line_number":37,"context_line":"      ctrl.itemData \u003d response.data;"},{"line_number":38,"context_line":"      ctrl.itemName \u003d ctrl.resourceType.itemName(response.data);"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_c9f00b94","line":35,"range":{"start_line":35,"start_character":20,"end_line":35,"end_character":24},"updated":"2016-03-23 22:40:23.000000000","message":"loadPromise","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8b2eeb803c9aa523d911817772b163b3cd32ed12","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    ctrl.resourceType \u003d registry.getResourceType($routeParams.type);"},{"line_number":34,"context_line":"    ctrl.descriptor \u003d ctrl.resourceType.parsePath($routeParams.path);"},{"line_number":35,"context_line":"    ctrl.descriptor.item \u003d ctrl.resourceType.load(ctrl.descriptor.identifier);"},{"line_number":36,"context_line":"    ctrl.descriptor.item.then(function loadData(response) {"},{"line_number":37,"context_line":"      ctrl.itemData \u003d response.data;"},{"line_number":38,"context_line":"      ctrl.itemName \u003d ctrl.resourceType.itemName(response.data);"}],"source_content_type":"text/javascript","patch_set":1,"id":"ba0121b8_0785c705","line":35,"range":{"start_line":35,"start_character":20,"end_line":35,"end_character":24},"in_reply_to":"fa0719c6_3459f435","updated":"2016-03-31 16:03:15.000000000","message":"Done","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    ctrl.resourceType \u003d registry.getResourceType($routeParams.type);"},{"line_number":34,"context_line":"    ctrl.descriptor \u003d ctrl.resourceType.parsePath($routeParams.path);"},{"line_number":35,"context_line":"    ctrl.descriptor.item \u003d ctrl.resourceType.load(ctrl.descriptor.identifier);"},{"line_number":36,"context_line":"    ctrl.descriptor.item.then(function loadData(response) {"},{"line_number":37,"context_line":"      ctrl.itemData \u003d response.data;"},{"line_number":38,"context_line":"      ctrl.itemName \u003d ctrl.resourceType.itemName(response.data);"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_3459f435","line":35,"range":{"start_line":35,"start_character":20,"end_line":35,"end_character":24},"in_reply_to":"fa0719c6_c9f00b94","updated":"2016-03-24 14:55:00.000000000","message":"yep","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"}],"horizon/static/framework/widgets/details/generic-details.controller.spec.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"431a5c5cc1f522f8a2f9baa33337bd5aa23d1fce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/**"},{"line_number":2,"context_line":" * (c) Copyright 2016 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_73bf2261","line":1,"updated":"2016-03-31 16:44:12.000000000","message":"Rename this file","commit_id":"1cb7e509d884683a441f691b24a814d4bd92b28f"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"72e6d110599208bab3832204bdffe39fe4896ff0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/**"},{"line_number":2,"context_line":" * (c) Copyright 2016 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_d6237cbb","line":1,"in_reply_to":"ba0121b8_73bf2261","updated":"2016-03-31 17:05:41.000000000","message":"Done","commit_id":"1cb7e509d884683a441f691b24a814d4bd92b28f"}],"horizon/static/framework/widgets/details/generic-details.html":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"GenericDetailsController as ctrl\"\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \u003cdiv class\u003d\"page-header\"\u003e"},{"line_number":4,"context_line":"    \u003col class\u003d\"breadcrumb\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"fa0719c6_5b1fa207","line":1,"range":{"start_line":1,"start_character":20,"end_line":1,"end_character":34},"updated":"2016-03-23 22:40:23.000000000","message":"I was confused by the relationship between hz-details and generic-details.\n\nConsider renaming to detailsPanel or detailsContainer or similar.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8b2eeb803c9aa523d911817772b163b3cd32ed12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"GenericDetailsController as ctrl\"\u003e"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \u003cdiv class\u003d\"page-header\"\u003e"},{"line_number":4,"context_line":"    \u003col class\u003d\"breadcrumb\"\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"ba0121b8_67fac376","line":1,"range":{"start_line":1,"start_character":20,"end_line":1,"end_character":34},"in_reply_to":"fa0719c6_5b1fa207","updated":"2016-03-31 16:03:15.000000000","message":"Yeah, I should probably specify that it\u0027s Routed details in this case.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"fd74c86d8710edced72b84b7e4ff7998dea32b70","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \u003cdiv class\u003d\"page-header\"\u003e"},{"line_number":4,"context_line":"    \u003col class\u003d\"breadcrumb\"\u003e"},{"line_number":5,"context_line":"      \u003cli\u003e\u003ca href\u003d\"javascript:history.back()\"\u003e{$ ctrl.resourceType.getName(2) $}\u003c/a\u003e\u003c/li\u003e"},{"line_number":6,"context_line":"      \u003cli class\u003d\"active\"\u003e{$ ::ctrl.itemName $}\u003c/li\u003e"},{"line_number":7,"context_line":"    \u003cspan class\u003d\"pull-right\" ng-if\u003d\"ctrl.itemData\"\u003e"},{"line_number":8,"context_line":"      \u003cactions allowed\u003d\"ctrl.resourceType.itemActions\" type\u003d\"row\" item\u003d\"ctrl.itemData\"\u003e\u003c/actions\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"ba0121b8_ec27dab3","line":5,"updated":"2016-03-31 15:30:36.000000000","message":"Can we add some class names here too?","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      \u003cli\u003e\u003ca href\u003d\"javascript:history.back()\"\u003e{$ ctrl.resourceType.getName(2) $}\u003c/a\u003e\u003c/li\u003e"},{"line_number":6,"context_line":"      \u003cli class\u003d\"active\"\u003e{$ ::ctrl.itemName $}\u003c/li\u003e"},{"line_number":7,"context_line":"    \u003cspan class\u003d\"pull-right\" ng-if\u003d\"ctrl.itemData\"\u003e"},{"line_number":8,"context_line":"      \u003cactions allowed\u003d\"ctrl.resourceType.itemActions\" type\u003d\"row\" item\u003d\"ctrl.itemData\"\u003e\u003c/actions\u003e"},{"line_number":9,"context_line":"    \u003c/span\u003e"},{"line_number":10,"context_line":"    \u003c/ol\u003e"},{"line_number":11,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"fa0719c6_dea720bb","line":8,"range":{"start_line":8,"start_character":7,"end_line":8,"end_character":14},"updated":"2016-03-23 22:40:23.000000000","message":"add a resultHandler.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"34c23f9c63ebb8ef6852e5e1a718ed5324887613","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      \u003cli\u003e\u003ca href\u003d\"javascript:history.back()\"\u003e{$ ctrl.resourceType.getName(2) $}\u003c/a\u003e\u003c/li\u003e"},{"line_number":6,"context_line":"      \u003cli class\u003d\"active\"\u003e{$ ::ctrl.itemName $}\u003c/li\u003e"},{"line_number":7,"context_line":"    \u003cspan class\u003d\"pull-right\" ng-if\u003d\"ctrl.itemData\"\u003e"},{"line_number":8,"context_line":"      \u003cactions allowed\u003d\"ctrl.resourceType.itemActions\" type\u003d\"row\" item\u003d\"ctrl.itemData\"\u003e\u003c/actions\u003e"},{"line_number":9,"context_line":"    \u003c/span\u003e"},{"line_number":10,"context_line":"    \u003c/ol\u003e"},{"line_number":11,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"da0c15f0_8df25199","line":8,"range":{"start_line":8,"start_character":7,"end_line":8,"end_character":14},"in_reply_to":"fa0719c6_3443b414","updated":"2016-03-24 18:24:17.000000000","message":"We at least have a general agreement that actions return promises.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      \u003cli\u003e\u003ca href\u003d\"javascript:history.back()\"\u003e{$ ctrl.resourceType.getName(2) $}\u003c/a\u003e\u003c/li\u003e"},{"line_number":6,"context_line":"      \u003cli class\u003d\"active\"\u003e{$ ::ctrl.itemName $}\u003c/li\u003e"},{"line_number":7,"context_line":"    \u003cspan class\u003d\"pull-right\" ng-if\u003d\"ctrl.itemData\"\u003e"},{"line_number":8,"context_line":"      \u003cactions allowed\u003d\"ctrl.resourceType.itemActions\" type\u003d\"row\" item\u003d\"ctrl.itemData\"\u003e\u003c/actions\u003e"},{"line_number":9,"context_line":"    \u003c/span\u003e"},{"line_number":10,"context_line":"    \u003c/ol\u003e"},{"line_number":11,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":1,"id":"fa0719c6_3443b414","line":8,"range":{"start_line":8,"start_character":7,"end_line":8,"end_character":14},"in_reply_to":"fa0719c6_dea720bb","updated":"2016-03-24 14:55:00.000000000","message":"Yeah, I want to add that; thinking it might be better as an add-on patch due to the fact that we don\u0027t have a standard for the resolve agreed to by upstream, so building logic to receive that would be contentious.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"}],"horizon/static/framework/widgets/details/routed-details-view.controller.js":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"a0b9d2a36f7e209510c149dff837a8b004943833","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" *"},{"line_number":3,"context_line":" * Licensed under the Apache License, Version 2.0 (the \u0027License\u0027);"},{"line_number":4,"context_line":" * you may not use this file except in compliance with the License."},{"line_number":5,"context_line":" * You may obtain a copy of the License at"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_e9936759","line":2,"updated":"2016-05-16 11:42:46.000000000","message":"Missing your HP copyright here.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e87b677d99db2d718406f0f9df7c4364d06778f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" *"},{"line_number":3,"context_line":" * Licensed under the Apache License, Version 2.0 (the \u0027License\u0027);"},{"line_number":4,"context_line":" * you may not use this file except in compliance with the License."},{"line_number":5,"context_line":" * You may obtain a copy of the License at"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_8048a4b4","line":2,"in_reply_to":"dab17558_e9936759","updated":"2016-05-16 14:16:45.000000000","message":"ha, thanks!","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1031d20dc6d5f654c8fc5fd953d77deef46998de","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  angular"},{"line_number":19,"context_line":"    .module(\u0027horizon.framework.widgets.details\u0027)"},{"line_number":20,"context_line":"    .controller(\u0027RoutedDetailsViewController\u0027, controller);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  controller.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.framework.conf.resource-type-registry.service\u0027,"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_039b1e67","line":20,"range":{"start_line":20,"start_character":47,"end_line":20,"end_character":57},"updated":"2016-05-16 14:18:37.000000000","message":"how about use `RoutedDetailsViewController`","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1031d20dc6d5f654c8fc5fd953d77deef46998de","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    .module(\u0027horizon.framework.widgets.details\u0027)"},{"line_number":20,"context_line":"    .controller(\u0027RoutedDetailsViewController\u0027, controller);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  controller.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.framework.conf.resource-type-registry.service\u0027,"},{"line_number":24,"context_line":"    \u0027$routeParams\u0027,"},{"line_number":25,"context_line":"    \u0027$rootScope\u0027"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_23ad8284","line":22,"range":{"start_line":22,"start_character":2,"end_line":22,"end_character":12},"updated":"2016-05-16 14:18:37.000000000","message":"ditto","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1031d20dc6d5f654c8fc5fd953d77deef46998de","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    \u0027$rootScope\u0027"},{"line_number":26,"context_line":"  ];"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"  function controller("},{"line_number":29,"context_line":"    registry,"},{"line_number":30,"context_line":"    $routeParams,"},{"line_number":31,"context_line":"    $rootScope"}],"source_content_type":"text/javascript","patch_set":18,"id":"dab17558_a3c17231","line":28,"range":{"start_line":28,"start_character":11,"end_line":28,"end_character":21},"updated":"2016-05-16 14:18:37.000000000","message":"ditto","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"}],"horizon/static/framework/widgets/details/routed-details-view.html":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \u003c/ol\u003e"},{"line_number":10,"context_line":"    \u003ch1 class\u003d\"active details-item-name\"\u003e{$ ctrl.resourceType.getName(1) + \u0027: \u0027 + ctrl.itemName $}\u003c/h1\u003e"},{"line_number":11,"context_line":"  \u003c/div\u003e"},{"line_number":12,"context_line":"  \u003chz-details details-views\u003d\"ctrl.resourceType.detailsViews\" descriptor\u003d\"ctrl.descriptor\" default-template-url\u003d\"ctrl.defaultTemplateUrl\"\u003e\u003c/hz-details\u003e"},{"line_number":13,"context_line":"\u003c/div\u003e"},{"line_number":14,"context_line":""}],"source_content_type":"text/html","patch_set":15,"id":"dab17558_c7223e01","line":12,"updated":"2016-05-12 18:56:49.000000000","message":"line too long","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"a0b9d2a36f7e209510c149dff837a8b004943833","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      \u003cli\u003e\u003ca href\u003d\"javascript:history.back()\" translate\u003eBack\u003c/a\u003e\u003c/li\u003e"},{"line_number":6,"context_line":"      \u003cspan class\u003d\"pull-right details-item-actions\" ng-if\u003d\"ctrl.itemData\"\u003e"},{"line_number":7,"context_line":"        \u003cactions allowed\u003d\"ctrl.resourceType.itemActions\" type\u003d\"row\" item\u003d\"ctrl.itemData\"\u003e\u003c/actions\u003e"},{"line_number":8,"context_line":"      \u003c/span\u003e"},{"line_number":9,"context_line":"    \u003c/ol\u003e"},{"line_number":10,"context_line":"    \u003ch1 class\u003d\"active details-item-name\"\u003e{$ ctrl.resourceType.getName(1) + \u0027: \u0027 + ctrl.itemName $}\u003c/h1\u003e"},{"line_number":11,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_2472b611","line":8,"updated":"2016-05-16 11:42:46.000000000","message":"Can we follow the current design for this? Seems strange to change it for a specific type of page. If its going to be generic, we should keep it that way.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"0e43520be3a9ec4ea38807d41d2b47ff901679b7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      \u003cli\u003e\u003ca href\u003d\"javascript:history.back()\" translate\u003eBack\u003c/a\u003e\u003c/li\u003e"},{"line_number":6,"context_line":"      \u003cspan class\u003d\"pull-right details-item-actions\" ng-if\u003d\"ctrl.itemData\"\u003e"},{"line_number":7,"context_line":"        \u003cactions allowed\u003d\"ctrl.resourceType.itemActions\" type\u003d\"row\" item\u003d\"ctrl.itemData\"\u003e\u003c/actions\u003e"},{"line_number":8,"context_line":"      \u003c/span\u003e"},{"line_number":9,"context_line":"    \u003c/ol\u003e"},{"line_number":10,"context_line":"    \u003ch1 class\u003d\"active details-item-name\"\u003e{$ ctrl.resourceType.getName(1) + \u0027: \u0027 + ctrl.itemName $}\u003c/h1\u003e"},{"line_number":11,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_86a71ca6","line":8,"in_reply_to":"dab17558_2057385b","updated":"2016-05-16 14:29:04.000000000","message":"robcresswell, with the breadcrumbs, the notion of Project \u003e Compute \u003e Images may start to degrade somewhat, as the details page can be reached from a variety of contexts (a panel, searchlight, etc.)","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e87b677d99db2d718406f0f9df7c4364d06778f1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"      \u003cli\u003e\u003ca href\u003d\"javascript:history.back()\" translate\u003eBack\u003c/a\u003e\u003c/li\u003e"},{"line_number":6,"context_line":"      \u003cspan class\u003d\"pull-right details-item-actions\" ng-if\u003d\"ctrl.itemData\"\u003e"},{"line_number":7,"context_line":"        \u003cactions allowed\u003d\"ctrl.resourceType.itemActions\" type\u003d\"row\" item\u003d\"ctrl.itemData\"\u003e\u003c/actions\u003e"},{"line_number":8,"context_line":"      \u003c/span\u003e"},{"line_number":9,"context_line":"    \u003c/ol\u003e"},{"line_number":10,"context_line":"    \u003ch1 class\u003d\"active details-item-name\"\u003e{$ ctrl.resourceType.getName(1) + \u0027: \u0027 + ctrl.itemName $}\u003c/h1\u003e"},{"line_number":11,"context_line":"  \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_2057385b","line":8,"in_reply_to":"dab17558_2472b611","updated":"2016-05-16 14:16:45.000000000","message":"I can keep the design; this may have been snapshotted from something from a while ago.  Let me see what\u0027s being done now.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"}],"horizon/static/framework/widgets/widgets.module.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"60cd985ee9ef5ad69209c8b24d3c47342a4ef1f1","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  angular"},{"line_number":21,"context_line":"    .module(\u0027horizon.framework.widgets\u0027, ["},{"line_number":22,"context_line":"      \u0027horizon.framework.widgets.headers\u0027,"},{"line_number":23,"context_line":"      \u0027horizon.framework.widgets.details\u0027,"},{"line_number":24,"context_line":"      \u0027horizon.framework.widgets.help-panel\u0027,"},{"line_number":25,"context_line":"      \u0027horizon.framework.widgets.wizard\u0027,"},{"line_number":26,"context_line":"      \u0027horizon.framework.widgets.table\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_1eb358ea","line":23,"range":{"start_line":23,"start_character":33,"end_line":23,"end_character":40},"updated":"2016-03-23 22:40:23.000000000","message":"I\u0027d find it more clear to indicate this is a kind of container, like detailsPanel, or detailsContainer...although it isn\u0027t really specific to details either. Perhaps it can be generalized to a \"resourceViewContainer\" ?","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"34c23f9c63ebb8ef6852e5e1a718ed5324887613","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  angular"},{"line_number":21,"context_line":"    .module(\u0027horizon.framework.widgets\u0027, ["},{"line_number":22,"context_line":"      \u0027horizon.framework.widgets.headers\u0027,"},{"line_number":23,"context_line":"      \u0027horizon.framework.widgets.details\u0027,"},{"line_number":24,"context_line":"      \u0027horizon.framework.widgets.help-panel\u0027,"},{"line_number":25,"context_line":"      \u0027horizon.framework.widgets.wizard\u0027,"},{"line_number":26,"context_line":"      \u0027horizon.framework.widgets.table\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"da0c15f0_4d6dd931","line":23,"range":{"start_line":23,"start_character":33,"end_line":23,"end_character":40},"in_reply_to":"fa0719c6_140830d9","updated":"2016-03-24 18:24:17.000000000","message":"My thinking is that at the framework level this isn\u0027t a \"details\" component so much as a \"component that has a tabbed collection of sub-view\". I might use this same component for a collection of dashboards.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55af500722debcc281ab5f8c6cd5b4696629a722","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  angular"},{"line_number":21,"context_line":"    .module(\u0027horizon.framework.widgets\u0027, ["},{"line_number":22,"context_line":"      \u0027horizon.framework.widgets.headers\u0027,"},{"line_number":23,"context_line":"      \u0027horizon.framework.widgets.details\u0027,"},{"line_number":24,"context_line":"      \u0027horizon.framework.widgets.help-panel\u0027,"},{"line_number":25,"context_line":"      \u0027horizon.framework.widgets.wizard\u0027,"},{"line_number":26,"context_line":"      \u0027horizon.framework.widgets.table\u0027,"}],"source_content_type":"text/javascript","patch_set":1,"id":"fa0719c6_140830d9","line":23,"range":{"start_line":23,"start_character":33,"end_line":23,"end_character":40},"in_reply_to":"fa0719c6_1eb358ea","updated":"2016-03-24 14:55:00.000000000","message":"That really varies from our naming patterns overall.  This is a place to put widget(s) related to details, just as table, charts, action-list, and modal do.","commit_id":"55b9f833f5bb5faa37ebf1dcc26973ca55df148c"}],"openstack_dashboard/enabled/_1070_project_ng_details_panel.py":[{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# The slug of the dashboard the PANEL associated with. Required."},{"line_number":16,"context_line":"PANEL_DASHBOARD \u003d \u0027project\u0027"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# The slug of the panel group the PANEL is associated with."},{"line_number":19,"context_line":"# If you want the panel to show up without a panel group,"}],"source_content_type":"text/x-python","patch_set":15,"id":"dab17558_67039277","line":16,"updated":"2016-05-12 18:56:49.000000000","message":"So I understand the need to attach the generic details page to a dashboard, just doesnt feel right that we are creating a reliance on the \"project\" dashboard. What happens when we disable the \"project\" dashboard?","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"}],"openstack_dashboard/static/app/core/images/images.module.spec.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8e604a7a8eada7eb086f3566f06071e566553695","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    });"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    it(\u0027should set table and detail path\u0027, function() {"},{"line_number":81,"context_line":"      expect($routeProvider.when.calls.count()).toEqual(3);"},{"line_number":82,"context_line":"      var imagesRouteCallArgs \u003d $routeProvider.when.calls.argsFor(0);"},{"line_number":83,"context_line":"      expect(imagesRouteCallArgs).toEqual(["},{"line_number":84,"context_line":"        \u0027/project/ngimages/\u0027, {templateUrl: staticUrl + \u0027app/core/images/table/images-table.html\u0027}"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_96462479","line":81,"range":{"start_line":81,"start_character":7,"end_line":81,"end_character":59},"updated":"2016-03-31 17:01:10.000000000","message":"Probably change this test as it\u0027s pretty bogus; it assumes a fixed set of routes.","commit_id":"1cb7e509d884683a441f691b24a814d4bd92b28f"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"72e6d110599208bab3832204bdffe39fe4896ff0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    });"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    it(\u0027should set table and detail path\u0027, function() {"},{"line_number":81,"context_line":"      expect($routeProvider.when.calls.count()).toEqual(3);"},{"line_number":82,"context_line":"      var imagesRouteCallArgs \u003d $routeProvider.when.calls.argsFor(0);"},{"line_number":83,"context_line":"      expect(imagesRouteCallArgs).toEqual(["},{"line_number":84,"context_line":"        \u0027/project/ngimages/\u0027, {templateUrl: staticUrl + \u0027app/core/images/table/images-table.html\u0027}"}],"source_content_type":"text/javascript","patch_set":2,"id":"ba0121b8_d9c28f84","line":81,"range":{"start_line":81,"start_character":7,"end_line":81,"end_character":59},"in_reply_to":"ba0121b8_96462479","updated":"2016-03-31 17:05:41.000000000","message":"Done","commit_id":"1cb7e509d884683a441f691b24a814d4bd92b28f"}],"openstack_dashboard/templates/angular.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"7ce04e646e61ee30183368983f1e8c0004677d6c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":14,"id":"dab17558_054c396f","line":3,"range":{"start_line":3,"start_character":27,"end_line":3,"end_character":33},"updated":"2016-05-06 18:16:17.000000000","message":"Should probably just say \"Angular\"","commit_id":"2216c33b680d3ee346ef8fa879ea8c44bc63d335"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a4d41309ae20fb6c56a62e51f0de54691052dfc3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":15,"id":"dab17558_715f8fe5","line":3,"range":{"start_line":3,"start_character":27,"end_line":3,"end_character":33},"updated":"2016-05-09 16:32:43.000000000","message":"Angular (or nothing?)  It\u0027s not shown.","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":9576,"name":"Thai Tran","email":"tqtran@us.ibm.com","username":"tqtran"},"change_message_id":"356e0cd8d8a13c52be6bafa2a272ead432adf324","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":15,"id":"dab17558_c71cfe15","line":3,"range":{"start_line":3,"start_character":27,"end_line":3,"end_character":33},"in_reply_to":"dab17558_715f8fe5","updated":"2016-05-12 18:56:49.000000000","message":"Probably nothing since this is just a template.","commit_id":"4d1a281082bc17f19e4baabddd6b8e60472835ae"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"34fad5250c266bb68abb47c88a404004e17553cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% trans \"Images\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"{% endblock %}"},{"line_number":7,"context_line":""}],"source_content_type":"text/html","patch_set":16,"id":"dab17558_b90bde2a","line":4,"updated":"2016-05-12 19:47:08.000000000","message":"+{% block breadcrumb_nav %}{% endblock %}\n+","commit_id":"60149481de8497bec572c5c18b5b1d378aa39c01"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"11de41cff7df114cf5783a7785290bb076d1fc67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block breadcrumb_nav %}{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_6f649fb8","line":2,"updated":"2016-05-16 09:15:44.000000000","message":"{% load i18n breadcrumb_nav %}","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e87b677d99db2d718406f0f9df7c4364d06778f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block breadcrumb_nav %}{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_a3b6923b","line":2,"in_reply_to":"dab17558_6f649fb8","updated":"2016-05-16 14:16:45.000000000","message":"I don\u0027t think breadcrumb_nav is necessary given the below comments.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"4fa9007fa49a29fe457eab085cf28aecd2d4c65b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block breadcrumb_nav %}{% endblock %}"},{"line_number":6,"context_line":""}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_1297fc48","line":3,"updated":"2016-05-16 09:37:39.000000000","message":"and we will miss title here","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e87b677d99db2d718406f0f9df7c4364d06778f1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block breadcrumb_nav %}{% endblock %}"},{"line_number":6,"context_line":""}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_000e748b","line":3,"in_reply_to":"dab17558_1297fc48","updated":"2016-05-16 14:16:45.000000000","message":"That is exactly the point...see the breadcrumb notes following.  This is a launching point for Angular single-page-applications, meaning we get all our dynamic content in the ng-view, so fixed titles and breadcrumbs break functionality.  That is the reason for the existence of this template.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"11de41cff7df114cf5783a7785290bb076d1fc67","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block breadcrumb_nav %}{% endblock %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{% block page_header %}"},{"line_number":8,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_8f0623cc","line":5,"updated":"2016-05-16 09:15:44.000000000","message":"{% block breadcrumb_nav %}\n  {% breadcrumb_nav %}\n{% endblock %}","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"e87b677d99db2d718406f0f9df7c4364d06778f1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block breadcrumb_nav %}{% endblock %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{% block page_header %}"},{"line_number":8,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_a0d8481f","line":5,"in_reply_to":"dab17558_8f0623cc","updated":"2016-05-16 14:16:45.000000000","message":"The purpose is we do NOT want a breadcrumb nav, because it breaks the single-page-application view that is created here; you\u0027d see the wrong header once you start clicking into the SPA.  So we leave the breadcrumb up to the SPA to implement in this case, since it changes dynamically on the client side.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1445931b701227335f1c5a94a1f232b6a52a4bc4","unresolved":false,"context_lines":[{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block breadcrumb_nav %}{% endblock %}"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"{% block page_header %}"},{"line_number":8,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_86171c44","line":5,"in_reply_to":"dab17558_a0d8481f","updated":"2016-05-16 14:22:54.000000000","message":"Yep, i got your tips, it really breaks the SPA..","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"a0b9d2a36f7e209510c149dff837a8b004943833","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"{% block main %}"},{"line_number":15,"context_line":"  \u003cdiv ng-view\u003e\u003c/div\u003e"},{"line_number":16,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":18,"id":"dab17558_840602cc","line":16,"updated":"2016-05-16 11:42:46.000000000","message":"This file seems like a sensible idea.","commit_id":"affb9f6bf043abce31763128c15a1c10d49ba450"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"62bf6a45a832f1c6eed40c07f723dbe3d77a335d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block breadcrumb_nav %}{% endblock %}"},{"line_number":6,"context_line":""}],"source_content_type":"text/html","patch_set":19,"id":"dab17558_32e5caa3","line":3,"updated":"2016-05-16 15:31:12.000000000","message":"still no title(title in tab) in image index page","commit_id":"1ca321dfe047fe62fde12b172c34a97b87024403"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"321aecdfebe95bfd0fa8210cd267bc80aee68c3b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":"{% block title %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block breadcrumb_nav %}{% endblock %}"},{"line_number":6,"context_line":""}],"source_content_type":"text/html","patch_set":19,"id":"dab17558_da2c504c","line":3,"in_reply_to":"dab17558_32e5caa3","updated":"2016-05-16 16:38:47.000000000","message":"What is your suggestion, though?  We will have to put something completely generic in here, because Django sets this once and doesn\u0027t refresh it as we move from different Angular views.\n\nI\u0027ll just put \u0027Horizon\u0027 in there for now.","commit_id":"1ca321dfe047fe62fde12b172c34a97b87024403"}]}
