)]}'
{"horizon/static/framework/widgets/details/routed-details-view.controller.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"43ea96fbba857ee7e43d20aa4214aab0b1719aa6","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      if ( result ) {"},{"line_number":74,"context_line":"        // Reduce the results to just item ids ignoring other types the action"},{"line_number":75,"context_line":"        // may have produced"},{"line_number":76,"context_line":"        deletedIds \u003d resultService.getIdsOfType(result.deleted, resourceTypeName);"},{"line_number":77,"context_line":"        updatedIds \u003d resultService.getIdsOfType(result.updated, resourceTypeName);"},{"line_number":78,"context_line":"        createdIds \u003d resultService.getIdsOfType(result.created, resourceTypeName);"},{"line_number":79,"context_line":"        failedIds \u003d resultService.getIdsOfType(result.failed, resourceTypeName);"}],"source_content_type":"text/javascript","patch_set":24,"id":"bab6814e_5e59ef59","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":8},"updated":"2016-05-18 17:15:51.000000000","message":"-1: It is difficult to predict what all tabs in this details view are going to be showing, they may be showing something related that was modified by this action...but that is not the base resource type...won\u0027t be notified of a change because we only reload if *this* resource type was modified by the action.\n\nSafer, and simpler to just always showDetails\u003dfalse on every action.","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"bf1a076835b1cb4fc985d368018a5929cd533297","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      if ( result ) {"},{"line_number":74,"context_line":"        // Reduce the results to just item ids ignoring other types the action"},{"line_number":75,"context_line":"        // may have produced"},{"line_number":76,"context_line":"        deletedIds \u003d resultService.getIdsOfType(result.deleted, resourceTypeName);"},{"line_number":77,"context_line":"        updatedIds \u003d resultService.getIdsOfType(result.updated, resourceTypeName);"},{"line_number":78,"context_line":"        createdIds \u003d resultService.getIdsOfType(result.created, resourceTypeName);"},{"line_number":79,"context_line":"        failedIds \u003d resultService.getIdsOfType(result.failed, resourceTypeName);"}],"source_content_type":"text/javascript","patch_set":24,"id":"bab6814e_6392eff7","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":8},"in_reply_to":"bab6814e_5e59ef59","updated":"2016-05-20 13:07:47.000000000","message":"Yeah, that\u0027s a good idea.  I\u0027ll just simplify that for now as you suggest.","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"38245f6692bad5fd704bd7fb11ee6b2ef27cb1ea","unresolved":false,"context_lines":[{"line_number":73,"context_line":"      if ( result ) {"},{"line_number":74,"context_line":"        // Reduce the results to just item ids ignoring other types the action"},{"line_number":75,"context_line":"        // may have produced"},{"line_number":76,"context_line":"        deletedIds \u003d resultService.getIdsOfType(result.deleted, resourceTypeName);"},{"line_number":77,"context_line":"        updatedIds \u003d resultService.getIdsOfType(result.updated, resourceTypeName);"},{"line_number":78,"context_line":"        createdIds \u003d resultService.getIdsOfType(result.created, resourceTypeName);"},{"line_number":79,"context_line":"        failedIds \u003d resultService.getIdsOfType(result.failed, resourceTypeName);"}],"source_content_type":"text/javascript","patch_set":24,"id":"bab6814e_e2bd3669","line":76,"range":{"start_line":76,"start_character":0,"end_line":76,"end_character":8},"in_reply_to":"bab6814e_6392eff7","updated":"2016-05-20 14:09:36.000000000","message":"Done","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"43ea96fbba857ee7e43d20aa4214aab0b1719aa6","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        // Handle updated and created items"},{"line_number":82,"context_line":"        if ( failedIds.length || deletedIds.length || updatedIds.length || createdIds.length ) {"},{"line_number":83,"context_line":"          ctrl.showDetails \u003d false;"},{"line_number":84,"context_line":"          ctrl.context.loadPromise \u003d ctrl.resourceType.load(ctrl.context.identifier);"},{"line_number":85,"context_line":"          ctrl.context.loadPromise.then(loadData);"},{"line_number":86,"context_line":""}],"source_content_type":"text/javascript","patch_set":24,"id":"bab6814e_deb4bff3","line":83,"range":{"start_line":83,"start_character":15,"end_line":83,"end_character":26},"updated":"2016-05-18 17:15:51.000000000","message":"-1: blanking the page instead of showing the spinner is not consistent with other areas of Horizon","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"38245f6692bad5fd704bd7fb11ee6b2ef27cb1ea","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        // Handle updated and created items"},{"line_number":82,"context_line":"        if ( failedIds.length || deletedIds.length || updatedIds.length || createdIds.length ) {"},{"line_number":83,"context_line":"          ctrl.showDetails \u003d false;"},{"line_number":84,"context_line":"          ctrl.context.loadPromise \u003d ctrl.resourceType.load(ctrl.context.identifier);"},{"line_number":85,"context_line":"          ctrl.context.loadPromise.then(loadData);"},{"line_number":86,"context_line":""}],"source_content_type":"text/javascript","patch_set":24,"id":"bab6814e_c2c2b2e8","line":83,"range":{"start_line":83,"start_character":15,"end_line":83,"end_character":26},"in_reply_to":"bab6814e_23b3c799","updated":"2016-05-20 14:09:36.000000000","message":"Done","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"bf1a076835b1cb4fc985d368018a5929cd533297","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        // Handle updated and created items"},{"line_number":82,"context_line":"        if ( failedIds.length || deletedIds.length || updatedIds.length || createdIds.length ) {"},{"line_number":83,"context_line":"          ctrl.showDetails \u003d false;"},{"line_number":84,"context_line":"          ctrl.context.loadPromise \u003d ctrl.resourceType.load(ctrl.context.identifier);"},{"line_number":85,"context_line":"          ctrl.context.loadPromise.then(loadData);"},{"line_number":86,"context_line":""}],"source_content_type":"text/javascript","patch_set":24,"id":"bab6814e_23b3c799","line":83,"range":{"start_line":83,"start_character":15,"end_line":83,"end_character":26},"in_reply_to":"bab6814e_deb4bff3","updated":"2016-05-20 13:07:47.000000000","message":"Yeah, I\u0027ll see if I can throw the spinner into this.  I don\u0027t consider it a blocker, but I\u0027ll give it a \u0027spin.\u0027","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"43ea96fbba857ee7e43d20aa4214aab0b1719aa6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"          ctrl.context.loadPromise \u003d ctrl.resourceType.load(ctrl.context.identifier);"},{"line_number":85,"context_line":"          ctrl.context.loadPromise.then(loadData);"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"          $timeout(showDetails);"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":"      }"},{"line_number":90,"context_line":""}],"source_content_type":"text/javascript","patch_set":24,"id":"bab6814e_becf3baf","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":10},"updated":"2016-05-18 17:15:51.000000000","message":"-1: I think the burden of re-rendering should be within the hz-details directive, either by having it watch for notifications on the loadPromise, or watch for changes on the loadPromise itself.","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"bf1a076835b1cb4fc985d368018a5929cd533297","unresolved":false,"context_lines":[{"line_number":84,"context_line":"          ctrl.context.loadPromise \u003d ctrl.resourceType.load(ctrl.context.identifier);"},{"line_number":85,"context_line":"          ctrl.context.loadPromise.then(loadData);"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"          $timeout(showDetails);"},{"line_number":88,"context_line":"        }"},{"line_number":89,"context_line":"      }"},{"line_number":90,"context_line":""}],"source_content_type":"text/javascript","patch_set":24,"id":"bab6814e_be234ca6","line":87,"range":{"start_line":87,"start_character":0,"end_line":87,"end_character":10},"in_reply_to":"bab6814e_becf3baf","updated":"2016-05-20 13:07:47.000000000","message":"Since this change you suggest is more of framework optimization/clarification (not sure yet if I agree with it), I\u0027d like to push off this request from this patch.  The change you suggest here wouldn\u0027t change the functionality on the details pages.","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"a28032514660df1911f3d841d2e2406caabfec72","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      // particular action because the actions return data in a standard form."},{"line_number":65,"context_line":"      // That return includes the id and type of each created, updated, deleted"},{"line_number":66,"context_line":"      // and failed item."},{"line_number":67,"context_line":"      // Currently just refreshes the display each time."},{"line_number":68,"context_line":"      if (result) {"},{"line_number":69,"context_line":"        spinnerService.showModalSpinner(gettext(\u0027Please Wait\u0027));"},{"line_number":70,"context_line":"        ctrl.showDetails \u003d false;"}],"source_content_type":"text/javascript","patch_set":25,"id":"bab6814e_b7fb5cc0","line":67,"updated":"2016-05-20 19:45:39.000000000","message":"On delete, the actions remain available (using images). They then just fail. If I force page refresh, the actions correctly disappear.","commit_id":"b568fb5035ccc3635a5ecfcedd05c0eb1890bc84"}],"horizon/static/framework/widgets/details/routed-details-view.html":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"4cf97867a47b61429cf48c80d3d55a62b77d2c20","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \u003cdiv class\u003d\"page-header\"\u003e"},{"line_number":4,"context_line":"    \u003col class\u003d\"breadcrumb\"\u003e"},{"line_number":5,"context_line":"      \u003cli\u003e\u003ca href\u003d\"javascript:history.back()\"\u003eBack\u003c/a\u003e\u003c/li\u003e"},{"line_number":6,"context_line":"    \u003c/ol\u003e"},{"line_number":7,"context_line":"    \u003cdiv class\u003d\"row\"\u003e"},{"line_number":8,"context_line":"      \u003cdiv class\u003d\"col-xs-12 col-sm-9 text-left\"\u003e"}],"source_content_type":"text/html","patch_set":24,"id":"bab6814e_55fb2c47","line":5,"updated":"2016-05-20 08:54:32.000000000","message":"\u003cli\u003e\u003ca href\u003d\"javascript:history.back()\" translate\u003eBack\u003c/a\u003e\u003c/li\u003e should add translate.","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"38245f6692bad5fd704bd7fb11ee6b2ef27cb1ea","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \u003cdiv class\u003d\"page-header\"\u003e"},{"line_number":4,"context_line":"    \u003col class\u003d\"breadcrumb\"\u003e"},{"line_number":5,"context_line":"      \u003cli\u003e\u003ca href\u003d\"javascript:history.back()\"\u003eBack\u003c/a\u003e\u003c/li\u003e"},{"line_number":6,"context_line":"    \u003c/ol\u003e"},{"line_number":7,"context_line":"    \u003cdiv class\u003d\"row\"\u003e"},{"line_number":8,"context_line":"      \u003cdiv class\u003d\"col-xs-12 col-sm-9 text-left\"\u003e"}],"source_content_type":"text/html","patch_set":24,"id":"bab6814e_e2641623","line":5,"in_reply_to":"bab6814e_2342a7ae","updated":"2016-05-20 14:09:36.000000000","message":"Done","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"a9767c43aad65e6f05aec6e6decc49977dc4b190","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  \u003cdiv class\u003d\"page-header\"\u003e"},{"line_number":4,"context_line":"    \u003col class\u003d\"breadcrumb\"\u003e"},{"line_number":5,"context_line":"      \u003cli\u003e\u003ca href\u003d\"javascript:history.back()\"\u003eBack\u003c/a\u003e\u003c/li\u003e"},{"line_number":6,"context_line":"    \u003c/ol\u003e"},{"line_number":7,"context_line":"    \u003cdiv class\u003d\"row\"\u003e"},{"line_number":8,"context_line":"      \u003cdiv class\u003d\"col-xs-12 col-sm-9 text-left\"\u003e"}],"source_content_type":"text/html","patch_set":24,"id":"bab6814e_2342a7ae","line":5,"in_reply_to":"bab6814e_55fb2c47","updated":"2016-05-20 12:59:19.000000000","message":"Yep, thanks!","commit_id":"dde2c9198d57cb5a06d75e2c0501df8c81117a5e"}],"openstack_dashboard/static/app/core/images/detail/image-detail.module.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"90036b91df22c63a759cee058bb70663973e311f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/**"},{"line_number":2,"context_line":" * (c) Copyright 2016 Hewlett-Packard Development Company, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/javascript","patch_set":10,"id":"1a122d0e_bf17ce52","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"updated":"2016-05-05 16:18:37.000000000","message":"We should rename this to just \u0027detail.module.js,\u0027 and also rename this directory to \u0027details.\u0027","commit_id":"544e4fec91f72f52fdf0057afcbd0ce603ac7242"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"90036b91df22c63a759cee058bb70663973e311f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"      .append({"},{"line_number":45,"context_line":"        id: \u0027imageDetailsOverview\u0027,"},{"line_number":46,"context_line":"        name: gettext(\u0027Overview\u0027),"},{"line_number":47,"context_line":"        template: basePath + \u0027detail/overview.html\u0027"},{"line_number":48,"context_line":"      });"},{"line_number":49,"context_line":"    registry.getResourceType(imageResourceType)"},{"line_number":50,"context_line":"      .setPathParser(parsePath)"}],"source_content_type":"text/javascript","patch_set":10,"id":"1a122d0e_9a782091","line":47,"range":{"start_line":47,"start_character":30,"end_line":47,"end_character":36},"updated":"2016-05-05 16:18:37.000000000","message":"change to \u0027details.\u0027","commit_id":"544e4fec91f72f52fdf0057afcbd0ce603ac7242"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"90036b91df22c63a759cee058bb70663973e311f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"      .setPathParser(parsePath)"},{"line_number":51,"context_line":"      .setPathGenerator(pathGenerator)"},{"line_number":52,"context_line":"      .setLoadFunction(loadFunction);"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    function pathGenerator(id) {"},{"line_number":55,"context_line":"      return id;"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    function parsePath(path) {"},{"line_number":59,"context_line":"      return path;"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    function loadFunction(identifier) {"},{"line_number":63,"context_line":"      return glanceApi.getImage(identifier);"}],"source_content_type":"text/javascript","patch_set":10,"id":"1a122d0e_ba4cfc76","line":60,"range":{"start_line":53,"start_character":0,"end_line":60,"end_character":5},"updated":"2016-05-05 16:18:37.000000000","message":"These two can go away as they are the default behavior.","commit_id":"544e4fec91f72f52fdf0057afcbd0ce603ac7242"}],"openstack_dashboard/static/app/core/images/details/details.module.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a154dae031a03afadf37b3a85284c190c69e36","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        template: basePath + \u0027details/overview.html\u0027"},{"line_number":48,"context_line":"      });"},{"line_number":49,"context_line":"    registry.getResourceType(imageResourceType)"},{"line_number":50,"context_line":"      .setPathParser(parsePath)"},{"line_number":51,"context_line":"      .setPathGenerator(pathGenerator)"},{"line_number":52,"context_line":"      .setLoadFunction(loadFunction);"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    function pathGenerator(id) {"}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_14739681","line":51,"range":{"start_line":50,"start_character":4,"end_line":51,"end_character":38},"updated":"2016-05-13 20:00:53.000000000","message":"These are defaults and can go away","commit_id":"7dd3f26d61acb5baa9629a6bb3bd836979592d88"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f7a154dae031a03afadf37b3a85284c190c69e36","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      .setPathGenerator(pathGenerator)"},{"line_number":52,"context_line":"      .setLoadFunction(loadFunction);"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    function pathGenerator(id) {"},{"line_number":55,"context_line":"      return id;"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    function parsePath(path) {"},{"line_number":59,"context_line":"      return path;"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    function loadFunction(identifier) {"},{"line_number":63,"context_line":"      return glanceApi.getImage(identifier);"}],"source_content_type":"text/javascript","patch_set":15,"id":"dab17558_f46d329a","line":60,"range":{"start_line":54,"start_character":4,"end_line":60,"end_character":5},"updated":"2016-05-13 20:00:53.000000000","message":"These are defaults and can go away","commit_id":"7dd3f26d61acb5baa9629a6bb3bd836979592d88"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8d49bbc2de99c612bf499cff8cd285e947613354","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      .setLoadFunction(loadFunction);"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    function pathGenerator(id) {"},{"line_number":55,"context_line":"      return id;"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    function parsePath(path) {"},{"line_number":59,"context_line":"      return path;"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    function loadFunction(identifier) {"},{"line_number":63,"context_line":"      return glanceApi.getImage(identifier);"}],"source_content_type":"text/javascript","patch_set":17,"id":"dab17558_b0c1ade6","line":60,"range":{"start_line":55,"start_character":1,"end_line":60,"end_character":5},"updated":"2016-05-16 17:18:53.000000000","message":"remove","commit_id":"0abc46c00f7d14036c8fc828df029f7f055835fb"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"7404b48c8743129c4a7d0bbece189b362e4b072f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"      .setLoadFunction(loadFunction);"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    function pathGenerator(id) {"},{"line_number":55,"context_line":"      return id;"},{"line_number":56,"context_line":"    }"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    function parsePath(path) {"},{"line_number":59,"context_line":"      return path;"},{"line_number":60,"context_line":"    }"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    function loadFunction(identifier) {"},{"line_number":63,"context_line":"      return glanceApi.getImage(identifier);"}],"source_content_type":"text/javascript","patch_set":17,"id":"dab17558_cb2640b9","line":60,"range":{"start_line":55,"start_character":1,"end_line":60,"end_character":5},"in_reply_to":"dab17558_b0c1ade6","updated":"2016-05-16 17:21:37.000000000","message":"Done","commit_id":"0abc46c00f7d14036c8fc828df029f7f055835fb"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"541a7dc8dcfbf1f5adc2715d329f1c58f70ffae5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    imageResourceType,"},{"line_number":40,"context_line":"    glanceApi,"},{"line_number":41,"context_line":"    registry"},{"line_number":42,"context_line":"  ) {"},{"line_number":43,"context_line":"    registry.getResourceType(imageResourceType).detailsViews"},{"line_number":44,"context_line":"      .append({"},{"line_number":45,"context_line":"        id: \u0027imageDetailsOverview\u0027,"}],"source_content_type":"text/javascript","patch_set":20,"id":"dab17558_1a96cfef","line":42,"updated":"2016-05-16 20:18:53.000000000","message":"Why does this get the resource type twice?  Can you just get resource type once and then use it?","commit_id":"3bd55f09a7e6c9b637aa0ed009e155aeadfd98e1"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"9fc5d6bdbc31ab1c3da31878ad8e5419bbd60fd3","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    imageResourceType,"},{"line_number":40,"context_line":"    glanceApi,"},{"line_number":41,"context_line":"    registry"},{"line_number":42,"context_line":"  ) {"},{"line_number":43,"context_line":"    registry.getResourceType(imageResourceType).detailsViews"},{"line_number":44,"context_line":"      .append({"},{"line_number":45,"context_line":"        id: \u0027imageDetailsOverview\u0027,"}],"source_content_type":"text/javascript","patch_set":20,"id":"dab17558_a5fa04bb","line":42,"in_reply_to":"dab17558_1a96cfef","updated":"2016-05-16 20:27:06.000000000","message":"Restructured a little to better use the chaining feature.","commit_id":"3bd55f09a7e6c9b637aa0ed009e155aeadfd98e1"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"6d3227ab15b5900b963bf9edd705fefb2ea895da","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    registry"},{"line_number":42,"context_line":"  ) {"},{"line_number":43,"context_line":"    registry.getResourceType(imageResourceType)"},{"line_number":44,"context_line":"      .setLoadFunction(loadFunction)"},{"line_number":45,"context_line":"      .detailsViews.append({"},{"line_number":46,"context_line":"        id: \u0027imageDetailsOverview\u0027,"},{"line_number":47,"context_line":"        name: gettext(\u0027Overview\u0027),"}],"source_content_type":"text/javascript","patch_set":21,"id":"dab17558_a37b17bd","line":44,"updated":"2016-05-17 00:42:50.000000000","message":"Now that I really look at this, I wonder why the load function is not registered at the images module level rather than here? TBH, I can see it both ways, so just want to at least have a little conversation first. Setting a pattern of details always comes from the details module makes some sense to me, but one reason I ask is that it seems we probably would want the actions to migrate to using the load function as well and I\u0027m not sure they should require the details module...\n\nE.g.\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/actions/edit.action.service.js#L93","commit_id":"277e5223ae18e54b452fef6ca8d1b11ffc5074ea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"d8e3352ba20af641236d92aa8e1ea998347121ba","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    registry"},{"line_number":42,"context_line":"  ) {"},{"line_number":43,"context_line":"    registry.getResourceType(imageResourceType)"},{"line_number":44,"context_line":"      .setLoadFunction(loadFunction)"},{"line_number":45,"context_line":"      .detailsViews.append({"},{"line_number":46,"context_line":"        id: \u0027imageDetailsOverview\u0027,"},{"line_number":47,"context_line":"        name: gettext(\u0027Overview\u0027),"}],"source_content_type":"text/javascript","patch_set":21,"id":"dab17558_756f05c4","line":44,"in_reply_to":"dab17558_19437414","updated":"2016-05-17 13:31:15.000000000","message":"Good idea, I\u0027ve been wondering that myself.  Yes, perhaps we should register everything at the module level.  Should we discuss this at one of the Wednesday meetings?  Or another time on IRC?\n\nThanks for the review!","commit_id":"277e5223ae18e54b452fef6ca8d1b11ffc5074ea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f095428bfd2c562c6c63ff9ea6dbb8b00b98a738","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    registry"},{"line_number":42,"context_line":"  ) {"},{"line_number":43,"context_line":"    registry.getResourceType(imageResourceType)"},{"line_number":44,"context_line":"      .setLoadFunction(loadFunction)"},{"line_number":45,"context_line":"      .detailsViews.append({"},{"line_number":46,"context_line":"        id: \u0027imageDetailsOverview\u0027,"},{"line_number":47,"context_line":"        name: gettext(\u0027Overview\u0027),"}],"source_content_type":"text/javascript","patch_set":21,"id":"bab6814e_32042c14","line":44,"in_reply_to":"dab17558_756f05c4","updated":"2016-05-18 13:41:52.000000000","message":"I think for now since only the Details features use load(), I\u0027d prefer to localize the registration here.  We can change that easily at any time if we come to a consensus.","commit_id":"277e5223ae18e54b452fef6ca8d1b11ffc5074ea"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"fb80b73d43c7425950a3b778f2106d901332c734","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    registry"},{"line_number":42,"context_line":"  ) {"},{"line_number":43,"context_line":"    registry.getResourceType(imageResourceType)"},{"line_number":44,"context_line":"      .setLoadFunction(loadFunction)"},{"line_number":45,"context_line":"      .detailsViews.append({"},{"line_number":46,"context_line":"        id: \u0027imageDetailsOverview\u0027,"},{"line_number":47,"context_line":"        name: gettext(\u0027Overview\u0027),"}],"source_content_type":"text/javascript","patch_set":21,"id":"dab17558_19437414","line":44,"in_reply_to":"dab17558_a37b17bd","updated":"2016-05-17 01:23:29.000000000","message":"really good question , i prefer registering in images module level.\nhow about have a conversation after the patch:-)","commit_id":"277e5223ae18e54b452fef6ca8d1b11ffc5074ea"}],"openstack_dashboard/static/app/core/images/details/overview.controller.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"4119390484c6668a6e41b4c15290b71e48e9af0a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" *"},{"line_number":3,"context_line":" * Licensed under the Apache License, Version 2.0 (the \u0027License\u0027);"},{"line_number":4,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/javascript","patch_set":21,"id":"dab17558_45b15346","line":1,"updated":"2016-05-17 22:35:28.000000000","message":"missing copyright.","commit_id":"277e5223ae18e54b452fef6ca8d1b11ffc5074ea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f095428bfd2c562c6c63ff9ea6dbb8b00b98a738","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" *"},{"line_number":3,"context_line":" * Licensed under the Apache License, Version 2.0 (the \u0027License\u0027);"},{"line_number":4,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/javascript","patch_set":21,"id":"bab6814e_6fed318b","line":1,"in_reply_to":"dab17558_45b15346","updated":"2016-05-18 13:41:52.000000000","message":"Done","commit_id":"277e5223ae18e54b452fef6ca8d1b11ffc5074ea"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"4119390484c6668a6e41b4c15290b71e48e9af0a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    $scope.context.loadPromise.then(onGetImage);"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    function onGetImage(image) {"},{"line_number":41,"context_line":"      ctrl.image \u003d image.data;"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"      ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function mapProps(prop) {"}],"source_content_type":"text/javascript","patch_set":21,"id":"dab17558_05a3cb00","line":40,"updated":"2016-05-17 22:35:28.000000000","message":"I think the details framework might need to bring events back into it.  When you use the actions, they work, but the page doesn\u0027t reflect the change. This is never re-invoked.","commit_id":"277e5223ae18e54b452fef6ca8d1b11ffc5074ea"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"f095428bfd2c562c6c63ff9ea6dbb8b00b98a738","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    $scope.context.loadPromise.then(onGetImage);"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    function onGetImage(image) {"},{"line_number":41,"context_line":"      ctrl.image \u003d image.data;"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"      ctrl.image.properties \u003d Object.keys(ctrl.image.properties).map(function mapProps(prop) {"}],"source_content_type":"text/javascript","patch_set":21,"id":"bab6814e_4f4aed84","line":40,"in_reply_to":"dab17558_05a3cb00","updated":"2016-05-18 13:41:52.000000000","message":"Yeah, let\u0027s discuss whether this is solved in this patch or as a follow-on.  I think there are enough options that we should do a follow-on to test some ideas.","commit_id":"277e5223ae18e54b452fef6ca8d1b11ffc5074ea"}],"openstack_dashboard/static/app/core/images/details/overview.html":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"121e61b71e0e6f44a650ba1b17a8a3ba66073c36","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \u003cdt translate\u003eVisibility\u003c/dt\u003e"},{"line_number":30,"context_line":"        \u003cdd\u003e{$ ctrl.image | imageVisibility $}\u003c/dd\u003e"},{"line_number":31,"context_line":"        \u003cdt translate\u003eProtected\u003c/dt\u003e"},{"line_number":32,"context_line":"        \u003cdd\u003e{$ ::ctrl.image.protected | yesno $}\u003c/dd\u003e"},{"line_number":33,"context_line":"        \u003cdt translate\u003eChecksum\u003c/dt\u003e"},{"line_number":34,"context_line":"        \u003cdd\u003e{$ ::ctrl.image.checksum $}\u003c/dd\u003e"},{"line_number":35,"context_line":"      \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"dab17558_a3b6a0f6","line":32,"updated":"2016-05-16 10:35:42.000000000","message":"not very sense to use one-time binding","commit_id":"7dd3f26d61acb5baa9629a6bb3bd836979592d88"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8d49bbc2de99c612bf499cff8cd285e947613354","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \u003cdt translate\u003eVisibility\u003c/dt\u003e"},{"line_number":30,"context_line":"        \u003cdd\u003e{$ ctrl.image | imageVisibility $}\u003c/dd\u003e"},{"line_number":31,"context_line":"        \u003cdt translate\u003eProtected\u003c/dt\u003e"},{"line_number":32,"context_line":"        \u003cdd\u003e{$ ::ctrl.image.protected | yesno $}\u003c/dd\u003e"},{"line_number":33,"context_line":"        \u003cdt translate\u003eChecksum\u003c/dt\u003e"},{"line_number":34,"context_line":"        \u003cdd\u003e{$ ::ctrl.image.checksum $}\u003c/dd\u003e"},{"line_number":35,"context_line":"      \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":17,"id":"dab17558_3aa11c95","line":32,"range":{"start_line":32,"start_character":15,"end_line":32,"end_character":37},"updated":"2016-05-16 17:18:53.000000000","message":"Note from before: Don\u0027t use 1-time binding","commit_id":"0abc46c00f7d14036c8fc828df029f7f055835fb"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"7404b48c8743129c4a7d0bbece189b362e4b072f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        \u003cdt translate\u003eVisibility\u003c/dt\u003e"},{"line_number":30,"context_line":"        \u003cdd\u003e{$ ctrl.image | imageVisibility $}\u003c/dd\u003e"},{"line_number":31,"context_line":"        \u003cdt translate\u003eProtected\u003c/dt\u003e"},{"line_number":32,"context_line":"        \u003cdd\u003e{$ ::ctrl.image.protected | yesno $}\u003c/dd\u003e"},{"line_number":33,"context_line":"        \u003cdt translate\u003eChecksum\u003c/dt\u003e"},{"line_number":34,"context_line":"        \u003cdd\u003e{$ ::ctrl.image.checksum $}\u003c/dd\u003e"},{"line_number":35,"context_line":"      \u003c/dl\u003e"}],"source_content_type":"text/html","patch_set":17,"id":"dab17558_6b175445","line":32,"range":{"start_line":32,"start_character":15,"end_line":32,"end_character":37},"in_reply_to":"dab17558_3aa11c95","updated":"2016-05-16 17:21:37.000000000","message":"Done","commit_id":"0abc46c00f7d14036c8fc828df029f7f055835fb"}],"openstack_dashboard/static/app/core/images/images.module.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"541a7dc8dcfbf1f5adc2715d329f1c58f70ffae5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"   */"},{"line_number":28,"context_line":"  angular"},{"line_number":29,"context_line":"    .module(\u0027horizon.app.core.images\u0027, [\u0027ngRoute\u0027,"},{"line_number":30,"context_line":"      \u0027horizon.app.core.images.actions\u0027, \u0027horizon.app.core.images.details\u0027])"},{"line_number":31,"context_line":"    .constant(\u0027horizon.app.core.images.events\u0027, events())"},{"line_number":32,"context_line":"    .constant(\u0027horizon.app.core.images.non_bootable_image_types\u0027, [\u0027aki\u0027, \u0027ari\u0027])"},{"line_number":33,"context_line":"    .constant(\u0027horizon.app.core.images.validationRules\u0027, validationRules())"}],"source_content_type":"text/javascript","patch_set":20,"id":"dab17558_fa682bf7","line":30,"updated":"2016-05-16 20:18:53.000000000","message":"This should be formatted with one module per line.  e.g.\n\nhttps://github.com/openstack/horizon/blob/master/horizon/static/framework/util/util.module.js#L5-L17","commit_id":"3bd55f09a7e6c9b637aa0ed009e155aeadfd98e1"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"9fc5d6bdbc31ab1c3da31878ad8e5419bbd60fd3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"   */"},{"line_number":28,"context_line":"  angular"},{"line_number":29,"context_line":"    .module(\u0027horizon.app.core.images\u0027, [\u0027ngRoute\u0027,"},{"line_number":30,"context_line":"      \u0027horizon.app.core.images.actions\u0027, \u0027horizon.app.core.images.details\u0027])"},{"line_number":31,"context_line":"    .constant(\u0027horizon.app.core.images.events\u0027, events())"},{"line_number":32,"context_line":"    .constant(\u0027horizon.app.core.images.non_bootable_image_types\u0027, [\u0027aki\u0027, \u0027ari\u0027])"},{"line_number":33,"context_line":"    .constant(\u0027horizon.app.core.images.validationRules\u0027, validationRules())"}],"source_content_type":"text/javascript","patch_set":20,"id":"dab17558_851ee009","line":30,"in_reply_to":"dab17558_fa682bf7","updated":"2016-05-16 20:27:06.000000000","message":"Done","commit_id":"3bd55f09a7e6c9b637aa0ed009e155aeadfd98e1"}],"openstack_dashboard/static/app/core/images/table/images-table.html":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"541a7dc8dcfbf1f5adc2715d329f1c58f70ffae5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"horizon.app.core.images.table.ImagesController as table\"\u003e"},{"line_number":2,"context_line":"\u003chz-page-header header\u003d\"{$ \u0027Images\u0027 | translate $}\"\u003e\u003c/hz-page-header\u003e"},{"line_number":3,"context_line":"\u003ctable hz-table ng-cloak"},{"line_number":4,"context_line":"       st-table\u003d\"table.images\""}],"source_content_type":"text/html","patch_set":20,"id":"dab17558_badfc3d4","line":1,"updated":"2016-05-16 20:18:53.000000000","message":"The below should be all indented.","commit_id":"3bd55f09a7e6c9b637aa0ed009e155aeadfd98e1"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"541a7dc8dcfbf1f5adc2715d329f1c58f70ffae5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"horizon.app.core.images.table.ImagesController as table\"\u003e"},{"line_number":2,"context_line":"\u003chz-page-header header\u003d\"{$ \u0027Images\u0027 | translate $}\"\u003e\u003c/hz-page-header\u003e"},{"line_number":3,"context_line":"\u003ctable hz-table ng-cloak"},{"line_number":4,"context_line":"       st-table\u003d\"table.images\""},{"line_number":5,"context_line":"       st-safe-src\u003d\"table.imagesSrc\""}],"source_content_type":"text/html","patch_set":20,"id":"dab17558_da55671e","line":2,"updated":"2016-05-16 20:18:53.000000000","message":"Can \"Images\" come from the resource type registry registered name?","commit_id":"3bd55f09a7e6c9b637aa0ed009e155aeadfd98e1"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"5d5cd01557dac1e0c75faa5234256876a4f2b68a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"horizon.app.core.images.table.ImagesController as table\"\u003e"},{"line_number":2,"context_line":"\u003chz-page-header header\u003d\"{$ \u0027Images\u0027 | translate $}\"\u003e\u003c/hz-page-header\u003e"},{"line_number":3,"context_line":"\u003ctable hz-table ng-cloak"},{"line_number":4,"context_line":"       st-table\u003d\"table.images\""},{"line_number":5,"context_line":"       st-safe-src\u003d\"table.imagesSrc\""},{"line_number":6,"context_line":"       default-sort\u003d\"name\""}],"source_content_type":"text/html","patch_set":20,"id":"dab17558_25ea940f","line":3,"updated":"2016-05-16 20:22:22.000000000","message":"Looks like all comments on this particular file won\u0027t matter since two more patches from here the generic table replaces this.","commit_id":"3bd55f09a7e6c9b637aa0ed009e155aeadfd98e1"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"9fc5d6bdbc31ab1c3da31878ad8e5419bbd60fd3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"horizon.app.core.images.table.ImagesController as table\"\u003e"},{"line_number":2,"context_line":"\u003chz-page-header header\u003d\"{$ \u0027Images\u0027 | translate $}\"\u003e\u003c/hz-page-header\u003e"},{"line_number":3,"context_line":"\u003ctable hz-table ng-cloak"},{"line_number":4,"context_line":"       st-table\u003d\"table.images\""},{"line_number":5,"context_line":"       st-safe-src\u003d\"table.imagesSrc\""},{"line_number":6,"context_line":"       default-sort\u003d\"name\""}],"source_content_type":"text/html","patch_set":20,"id":"dab17558_a5cfa47d","line":3,"in_reply_to":"dab17558_25ea940f","updated":"2016-05-16 20:27:06.000000000","message":"Yeah, this is to just demonstrate the generic details patch until the generic table patch comes along.","commit_id":"3bd55f09a7e6c9b637aa0ed009e155aeadfd98e1"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"7f686565864d3c302165b1fc410433efdd294595","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003cdiv ng-controller\u003d\"horizon.app.core.images.table.ImagesController as table\"\u003e"},{"line_number":2,"context_line":"\u003chz-page-header header\u003d\"{$ \u0027Images\u0027 | translate $}\"\u003e\u003c/hz-page-header\u003e"},{"line_number":3,"context_line":"\u003ctable hz-table ng-cloak"},{"line_number":4,"context_line":"       st-table\u003d\"table.images\""}],"source_content_type":"text/html","patch_set":22,"id":"bab6814e_b3dbfbec","line":1,"range":{"start_line":1,"start_character":70,"end_line":1,"end_character":75},"updated":"2016-05-18 15:27:07.000000000","message":"nit: as ctrl","commit_id":"2478d7042c653d00b902ac39f55f78fbfcb36bc7"}]}
