)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9178,"name":"Sayali Lunkad","email":"sayali.lunkad@suse.com","username":"sayalilunkad"},"change_message_id":"b9d526e70ff0e77915ddd1cfac494dbb4cedcf00","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix allowed() function for CreateSubnet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If neutron quotas disabled, there is no"},{"line_number":10,"context_line":"usages[\u0027subnets\u0027][\u0027available\u0027]."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"So this check raises KeyError exception"},{"line_number":13,"context_line":"and makes \"Create subnet\" button dissapear."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I998c98c190fd4dc4039c7fb8ef7b1ef27bbeb863"},{"line_number":16,"context_line":"Closes-Bug: #1567529"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ba5da102_736709e9","line":13,"range":{"start_line":9,"start_character":1,"end_line":13,"end_character":43},"updated":"2016-11-02 16:44:28.000000000","message":"Please use line wrap of 72 characters njot lesser. Check https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"497bba29503b44086937fdbb0650e43aca32ecc6"}],"openstack_dashboard/dashboards/admin/networks/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9c1afea6dd0e750b49987042cd988c4fd61fbbb1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from django.core.urlresolvers import reverse"},{"line_number":17,"context_line":"from django import http"},{"line_number":18,"context_line":"from django.test.utils import override_settings"},{"line_number":19,"context_line":"from django.utils.http import urlunquote"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from mox3.mox import IsA  # noqa"}],"source_content_type":"text/x-python","patch_set":9,"id":"ffe62b97_6b79a391","line":18,"updated":"2017-03-26 23:03:48.000000000","message":"This is unnecessary","commit_id":"a7e79cdfb39c7a8580515eacf0e1e587b8ebe0b4"}],"openstack_dashboard/dashboards/project/networks/subnets/tables.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f9b2ce84643cf80c2e968eef1a350fa17337f19d","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # when Settings.OPENSTACK_NEUTRON_NETWORK[\u0027enable_quotas\u0027] \u003d False"},{"line_number":108,"context_line":"        # usages[\"subnets\u0027] is empty"},{"line_number":109,"context_line":"        if usages.get(\u0027subnets\u0027, {}).get(\u0027available\u0027, 1) \u003c\u003d 0:"},{"line_number":110,"context_line":"            if \u0027disabled\u0027 not in self.classes:"},{"line_number":111,"context_line":"                self.classes \u003d [c for c in self.classes] + [\u0027disabled\u0027]"},{"line_number":112,"context_line":"                self.verbose_name \u003d _(\u0027Create Subnet (Quota exceeded)\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"ffe62b97_c263ecdb","line":109,"updated":"2017-03-27 04:49:41.000000000","message":"I\u0027m confused by defaulting the available valid to 1 instead of 0 here. I have struggled to find appropriate documentation to indicate what the sensible default would be, but in my mind a quota that is missing an available value would be defaulted to 0 (none available). Please provide some evidence to support defaulting it to 1.","commit_id":"8dc3e4324770bcc963cc213884861a563c2fd8e3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9311d9d937336f36221c10b04c49c6f69329bdec","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # when Settings.OPENSTACK_NEUTRON_NETWORK[\u0027enable_quotas\u0027] \u003d False"},{"line_number":108,"context_line":"        # usages[\"subnets\u0027] is empty"},{"line_number":109,"context_line":"        if usages.get(\u0027subnets\u0027, {}).get(\u0027available\u0027, 1) \u003c\u003d 0:"},{"line_number":110,"context_line":"            if \u0027disabled\u0027 not in self.classes:"},{"line_number":111,"context_line":"                self.classes \u003d [c for c in self.classes] + [\u0027disabled\u0027]"},{"line_number":112,"context_line":"                self.verbose_name \u003d _(\u0027Create Subnet (Quota exceeded)\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7ffa3b31_d490244d","line":109,"in_reply_to":"7ffa3b31_b40c78ec","updated":"2017-04-19 15:05:59.000000000","message":"we have copy-and-paste logic in several places and it looks better to have a method to determine a user can create a new resource or not.","commit_id":"8dc3e4324770bcc963cc213884861a563c2fd8e3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2aa569b2f3eb1057717521543790bc46eca10987","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        # when Settings.OPENSTACK_NEUTRON_NETWORK[\u0027enable_quotas\u0027] \u003d False"},{"line_number":108,"context_line":"        # usages[\"subnets\u0027] is empty"},{"line_number":109,"context_line":"        if usages.get(\u0027subnets\u0027, {}).get(\u0027available\u0027, 1) \u003c\u003d 0:"},{"line_number":110,"context_line":"            if \u0027disabled\u0027 not in self.classes:"},{"line_number":111,"context_line":"                self.classes \u003d [c for c in self.classes] + [\u0027disabled\u0027]"},{"line_number":112,"context_line":"                self.verbose_name \u003d _(\u0027Create Subnet (Quota exceeded)\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7ffa3b31_b40c78ec","line":109,"in_reply_to":"ffe62b97_c263ecdb","updated":"2017-04-19 15:04:31.000000000","message":"In my understanding, when usage for a given resource is unavailable, it means the quota and usage is not maintained and thus it is interpreted as \"resource available\". Defaulting to 1 allows users to create a new resource.\n\nAssume a case where a server project does not have a quota mechanism for some resource. In that case, we don\u0027t have usage information, but users can create a resource in most cases. I think it is a reasonable default\n\nThe same logic is already used in several places in our code base.\n\n-\n https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/security_groups/tables.py#L71\n- https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/routers/tables.py#L95\n- https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/network_topology/utils.py#L22\n-  https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/networks/tables.py#L134","commit_id":"8dc3e4324770bcc963cc213884861a563c2fd8e3"}]}
