)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6c578302b348c470b8bbfa5044fef8273e490ed3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Karikh \u003cpkarikh@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-15 19:18:13 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the Profiler panel to the Developer dashboard"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Provide both pythonic Django part and the static assets (angular"},{"line_number":10,"context_line":"directives and styles) for the new panel."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"3ac371cc_5b8567ab","line":7,"updated":"2016-08-16 01:47:57.000000000","message":"There is no test code added, marked as `WIP` seems more reasonable.","commit_id":"7d1f97e55f87607833daa0efe8809485da85e8a0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"18c3e63850d1c66ac40a7bff047de1fe836e64b9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Paul Karikh \u003cpkarikh@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-15 19:18:13 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add the Profiler panel to the Developer dashboard"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Provide both pythonic Django part and the static assets (angular"},{"line_number":10,"context_line":"directives and styles) for the new panel."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"3ac371cc_9898731d","line":7,"in_reply_to":"3ac371cc_5b8567ab","updated":"2016-08-16 10:25:25.000000000","message":"Not sure if we really need to do this for developer-only feature, it\u0027s not a user-space code. See for example https://review.openstack.org/#/c/313790/","commit_id":"7d1f97e55f87607833daa0efe8809485da85e8a0"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6c578302b348c470b8bbfa5044fef8273e490ed3","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Provide both pythonic Django part and the static assets (angular"},{"line_number":10,"context_line":"directives and styles) for the new panel."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ice7b8b4b4decad2c45a9edef3f3c4cc2ff759de4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"3ac371cc_1ba3ef50","line":11,"updated":"2016-08-16 01:47:57.000000000","message":"Its better to add A LP bug or bp.","commit_id":"7d1f97e55f87607833daa0efe8809485da85e8a0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"18c3e63850d1c66ac40a7bff047de1fe836e64b9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Provide both pythonic Django part and the static assets (angular"},{"line_number":10,"context_line":"directives and styles) for the new panel."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ice7b8b4b4decad2c45a9edef3f3c4cc2ff759de4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":33,"id":"3ac371cc_f88367ca","line":11,"in_reply_to":"3ac371cc_1ba3ef50","updated":"2016-08-16 10:25:25.000000000","message":"Done","commit_id":"7d1f97e55f87607833daa0efe8809485da85e8a0"}],"doc/source/contributing.rst":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"cb12d78b162cd30b55e641e5bbdb62e160324a4a","unresolved":false,"context_lines":[{"line_number":111,"context_line":"re-render the page while profiling it, you\u0027ll need to use \"Profile\" drop-down"},{"line_number":112,"context_line":"menu located left to the User menu in top right corner of the screen. In order to"},{"line_number":113,"context_line":"be able to use \"Profile\" menu the following steps need to be done:"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"#. Copy openstack_dashboard/local/local_settings.d/_9030_toggle_profiler.py.example"},{"line_number":116,"context_line":"file to openstack_dashboard/local/local_settings.d/_9030_toggle_profiler.py"},{"line_number":117,"context_line":"#. Copy openstack_dashboard/contrib/developer/enabled/_9030_profiler.py to"}],"source_content_type":"text/x-rst","patch_set":62,"id":"9a629dbe_6f7e95af","line":114,"updated":"2016-11-09 04:04:22.000000000","message":"Step 0: ensure the developer dashboard is enabled (copy its enabled file if necessary)","commit_id":"a5678013bba993fc7ea5cd6dcd568c42c9ec5bbe"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"732f1f3a10fc278eedf8ac40bc62dce9629711c8","unresolved":false,"context_lines":[{"line_number":111,"context_line":"re-render the page while profiling it, you\u0027ll need to use \"Profile\" drop-down"},{"line_number":112,"context_line":"menu located left to the User menu in top right corner of the screen. In order to"},{"line_number":113,"context_line":"be able to use \"Profile\" menu the following steps need to be done:"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"#. Copy openstack_dashboard/local/local_settings.d/_9030_toggle_profiler.py.example"},{"line_number":116,"context_line":"file to openstack_dashboard/local/local_settings.d/_9030_toggle_profiler.py"},{"line_number":117,"context_line":"#. Copy openstack_dashboard/contrib/developer/enabled/_9030_profiler.py to"}],"source_content_type":"text/x-rst","patch_set":62,"id":"9a629dbe_1348db2c","line":114,"in_reply_to":"9a629dbe_6f7e95af","updated":"2016-11-09 09:01:14.000000000","message":"Done","commit_id":"a5678013bba993fc7ea5cd6dcd568c42c9ec5bbe"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"cb12d78b162cd30b55e641e5bbdb62e160324a4a","unresolved":false,"context_lines":[{"line_number":112,"context_line":"menu located left to the User menu in top right corner of the screen. In order to"},{"line_number":113,"context_line":"be able to use \"Profile\" menu the following steps need to be done:"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"#. Copy openstack_dashboard/local/local_settings.d/_9030_toggle_profiler.py.example"},{"line_number":116,"context_line":"file to openstack_dashboard/local/local_settings.d/_9030_toggle_profiler.py"},{"line_number":117,"context_line":"#. Copy openstack_dashboard/contrib/developer/enabled/_9030_profiler.py to"},{"line_number":118,"context_line":"openstack_dashboard/local/enabled/_9030_profiler.py (and _9001_developer.py file"}],"source_content_type":"text/x-rst","patch_set":62,"id":"9a629dbe_af4eed93","line":115,"updated":"2016-11-09 04:04:22.000000000","message":"Rename this if you agreed with my rename suggestion in the prior patch :-)","commit_id":"a5678013bba993fc7ea5cd6dcd568c42c9ec5bbe"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"732f1f3a10fc278eedf8ac40bc62dce9629711c8","unresolved":false,"context_lines":[{"line_number":112,"context_line":"menu located left to the User menu in top right corner of the screen. In order to"},{"line_number":113,"context_line":"be able to use \"Profile\" menu the following steps need to be done:"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"#. Copy openstack_dashboard/local/local_settings.d/_9030_toggle_profiler.py.example"},{"line_number":116,"context_line":"file to openstack_dashboard/local/local_settings.d/_9030_toggle_profiler.py"},{"line_number":117,"context_line":"#. Copy openstack_dashboard/contrib/developer/enabled/_9030_profiler.py to"},{"line_number":118,"context_line":"openstack_dashboard/local/enabled/_9030_profiler.py (and _9001_developer.py file"}],"source_content_type":"text/x-rst","patch_set":62,"id":"9a629dbe_535253de","line":115,"in_reply_to":"9a629dbe_af4eed93","updated":"2016-11-09 09:01:14.000000000","message":"Done","commit_id":"a5678013bba993fc7ea5cd6dcd568c42c9ec5bbe"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"b8181d25b5981c332b34901e7a9715ead9edbb82","unresolved":false,"context_lines":[{"line_number":123,"context_line":"to be installed on Devstack host (default configuration), see `Installing MongoDB`_."},{"line_number":124,"context_line":"Then, change net:bindIp: key to 0.0.0.0 inside /etc/mongod.conf and invoke"},{"line_number":125,"context_line":"``sudo service mongod restart`` for the changes to have an effect."},{"line_number":126,"context_line":"#. Re-collect and re-compress statics assets."},{"line_number":127,"context_line":"#. Re-start the production web-server in case you are serving Horizon from it."},{"line_number":128,"context_line":"#. Go to Developer-\u003eOpenStack Profiler panel and turn the profiler toggle on there."},{"line_number":129,"context_line":"#. The \"Profile\" drop-down menu should appear in the top-right corner, you are"}],"source_content_type":"text/x-rst","patch_set":66,"id":"7a77a97e_116d9b04","line":126,"updated":"2016-11-15 00:32:19.000000000","message":"nit: static should be singular, assets is plural","commit_id":"3d9134877ab1e657b227e3668a9f7431d03f866e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"86b0429898b7c26378221743182d0c2fa762e369","unresolved":false,"context_lines":[{"line_number":123,"context_line":"to be installed on Devstack host (default configuration), see `Installing MongoDB`_."},{"line_number":124,"context_line":"Then, change net:bindIp: key to 0.0.0.0 inside /etc/mongod.conf and invoke"},{"line_number":125,"context_line":"``sudo service mongod restart`` for the changes to have an effect."},{"line_number":126,"context_line":"#. Re-collect and re-compress statics assets."},{"line_number":127,"context_line":"#. Re-start the production web-server in case you are serving Horizon from it."},{"line_number":128,"context_line":"#. Go to Developer-\u003eOpenStack Profiler panel and turn the profiler toggle on there."},{"line_number":129,"context_line":"#. The \"Profile\" drop-down menu should appear in the top-right corner, you are"}],"source_content_type":"text/x-rst","patch_set":66,"id":"7a77a97e_f5e8f918","line":126,"in_reply_to":"7a77a97e_116d9b04","updated":"2016-11-15 09:49:03.000000000","message":"Done","commit_id":"3d9134877ab1e657b227e3668a9f7431d03f866e"}],"openstack_dashboard/context_processors.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"b8181d25b5981c332b34901e7a9715ead9edbb82","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    context[\u0027WEBROOT\u0027] \u003d getattr(settings, \"WEBROOT\", \"/\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    # Adding profiler support flag"},{"line_number":64,"context_line":"    context[\u0027profiler_enabled\u0027] \u003d settings.OPENSTACK_PROFILER[\u0027enabled\u0027]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # Search for external plugins and append to javascript message catalog"},{"line_number":67,"context_line":"    # internal plugins are under the openstack_dashboard domain"}],"source_content_type":"text/x-python","patch_set":66,"id":"7a77a97e_51b0f38b","line":64,"updated":"2016-11-15 00:32:19.000000000","message":"I would prefer a safer check for the setting\u0027s existence and the default to enabled \u003d False.","commit_id":"3d9134877ab1e657b227e3668a9f7431d03f866e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"86b0429898b7c26378221743182d0c2fa762e369","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    context[\u0027WEBROOT\u0027] \u003d getattr(settings, \"WEBROOT\", \"/\")"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    # Adding profiler support flag"},{"line_number":64,"context_line":"    context[\u0027profiler_enabled\u0027] \u003d settings.OPENSTACK_PROFILER[\u0027enabled\u0027]"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # Search for external plugins and append to javascript message catalog"},{"line_number":67,"context_line":"    # internal plugins are under the openstack_dashboard domain"}],"source_content_type":"text/x-python","patch_set":66,"id":"7a77a97e_d5521ddd","line":64,"in_reply_to":"7a77a97e_51b0f38b","updated":"2016-11-15 09:49:03.000000000","message":"Done","commit_id":"3d9134877ab1e657b227e3668a9f7431d03f866e"}],"openstack_dashboard/contrib/developer/enabled/_9030_profiler.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"b8181d25b5981c332b34901e7a9715ead9edbb82","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Cisco Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":66,"id":"7a77a97e_b155c71e","line":1,"updated":"2016-11-15 00:32:19.000000000","message":"you don\u0027t work for Cisco, that I know of and it\u0027s 2016. Either remove this line or correct it.","commit_id":"3d9134877ab1e657b227e3668a9f7431d03f866e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"86b0429898b7c26378221743182d0c2fa762e369","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Cisco Systems, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":66,"id":"7a77a97e_3526f168","line":1,"in_reply_to":"7a77a97e_b155c71e","updated":"2016-11-15 09:49:03.000000000","message":"Oops.. Fixed.","commit_id":"3d9134877ab1e657b227e3668a9f7431d03f866e"}],"openstack_dashboard/contrib/developer/profiler/middleware.py":[{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6c578302b348c470b8bbfa5044fef8273e490ed3","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                _(\u0027Traced with id %s. Go to \u003ca href\u003d\"%s\"\u003epage\u003c/a\u003e\u0027) %"},{"line_number":103,"context_line":"                (trace_id, url))"},{"line_number":104,"context_line":"            messages.info(request, message)"},{"line_number":105,"context_line":"            return response "},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @staticmethod"},{"line_number":108,"context_line":"    def clear_profiling_cookies(request, response):"}],"source_content_type":"text/x-python","patch_set":33,"id":"3ac371cc_fbc7f30f","line":105,"updated":"2016-08-16 01:47:57.000000000","message":"`trailing white space`","commit_id":"7d1f97e55f87607833daa0efe8809485da85e8a0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"18c3e63850d1c66ac40a7bff047de1fe836e64b9","unresolved":false,"context_lines":[{"line_number":102,"context_line":"                _(\u0027Traced with id %s. Go to \u003ca href\u003d\"%s\"\u003epage\u003c/a\u003e\u0027) %"},{"line_number":103,"context_line":"                (trace_id, url))"},{"line_number":104,"context_line":"            messages.info(request, message)"},{"line_number":105,"context_line":"            return response "},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    @staticmethod"},{"line_number":108,"context_line":"    def clear_profiling_cookies(request, response):"}],"source_content_type":"text/x-python","patch_set":33,"id":"3ac371cc_386e9f2f","line":105,"in_reply_to":"3ac371cc_fbc7f30f","updated":"2016-08-16 10:25:25.000000000","message":"Done","commit_id":"7d1f97e55f87607833daa0efe8809485da85e8a0"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"b8181d25b5981c332b34901e7a9715ead9edbb82","unresolved":false,"context_lines":[{"line_number":29,"context_line":"_REQUIRED_KEYS \u003d (\"base_id\", \"hmac_key\")"},{"line_number":30,"context_line":"_OPTIONAL_KEYS \u003d (\"parent_id\",)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"PROFILER_CONF \u003d settings.OPENSTACK_PROFILER"},{"line_number":33,"context_line":"PROFILER_ENABLED \u003d PROFILER_CONF[\u0027enabled\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":66,"id":"7a77a97e_3117f752","line":32,"updated":"2016-11-15 00:32:19.000000000","message":"why the unsafe settings checks?","commit_id":"3d9134877ab1e657b227e3668a9f7431d03f866e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"86b0429898b7c26378221743182d0c2fa762e369","unresolved":false,"context_lines":[{"line_number":29,"context_line":"_REQUIRED_KEYS \u003d (\"base_id\", \"hmac_key\")"},{"line_number":30,"context_line":"_OPTIONAL_KEYS \u003d (\"parent_id\",)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"PROFILER_CONF \u003d settings.OPENSTACK_PROFILER"},{"line_number":33,"context_line":"PROFILER_ENABLED \u003d PROFILER_CONF[\u0027enabled\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":66,"id":"7a77a97e_f5871910","line":32,"in_reply_to":"7a77a97e_3117f752","updated":"2016-11-15 09:49:03.000000000","message":"Given that basic profiler \u0027enabled\u0027 setting is in the main settings.py file for sure, it looked like a more concise way of writing the code. But I understand all the cautions, will change it.","commit_id":"3d9134877ab1e657b227e3668a9f7431d03f866e"}],"openstack_dashboard/contrib/developer/profiler/panel.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"d245aa1cccf51338e110bb05fff5864377f17b46","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import horizon"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"if settings.OPENSTACK_PROFILER[\u0027enabled\u0027]:"},{"line_number":23,"context_line":"    class Profiler(horizon.Panel):"},{"line_number":24,"context_line":"        name \u003d _(\"OpenStack Profiler\")"},{"line_number":25,"context_line":"        slug \u003d \u0027profiler\u0027"}],"source_content_type":"text/x-python","patch_set":48,"id":"fa7ab95a_3faee0e7","line":22,"updated":"2016-08-31 04:38:47.000000000","message":"Sorry, I forgot to ask this in my prior review: why are you using this mechanism to hide/show the profiler, rather than an enabled file?","commit_id":"e0bce1f48093d609f36df311e0e6d11e83a19dc1"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"1f0bc75f6932e09c17fc5dedaff3a2cd1c45c239","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import horizon"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"if settings.OPENSTACK_PROFILER[\u0027enabled\u0027]:"},{"line_number":23,"context_line":"    class Profiler(horizon.Panel):"},{"line_number":24,"context_line":"        name \u003d _(\"OpenStack Profiler\")"},{"line_number":25,"context_line":"        slug \u003d \u0027profiler\u0027"}],"source_content_type":"text/x-python","patch_set":48,"id":"fa7ab95a_d82fcaa5","line":22,"in_reply_to":"fa7ab95a_3faee0e7","updated":"2016-08-31 06:51:09.000000000","message":"I use both this mechanism and enabled file, but the setting contorl not only the panel visibility, but also other profiler machinery such as middleware enablement, templates inclusion, etc - so it was logical to use to control whether or not the panel should be displayed.","commit_id":"e0bce1f48093d609f36df311e0e6d11e83a19dc1"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"b8181d25b5981c332b34901e7a9715ead9edbb82","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import horizon"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"if settings.OPENSTACK_PROFILER[\u0027enabled\u0027]:"},{"line_number":23,"context_line":"    class Profiler(horizon.Panel):"},{"line_number":24,"context_line":"        name \u003d _(\"OpenStack Profiler\")"},{"line_number":25,"context_line":"        slug \u003d \u0027profiler\u0027"}],"source_content_type":"text/x-python","patch_set":66,"id":"7a77a97e_ccfe2805","line":22,"updated":"2016-11-15 00:32:19.000000000","message":"me too re: unsafe settings checks","commit_id":"3d9134877ab1e657b227e3668a9f7431d03f866e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"86b0429898b7c26378221743182d0c2fa762e369","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import horizon"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"if settings.OPENSTACK_PROFILER[\u0027enabled\u0027]:"},{"line_number":23,"context_line":"    class Profiler(horizon.Panel):"},{"line_number":24,"context_line":"        name \u003d _(\"OpenStack Profiler\")"},{"line_number":25,"context_line":"        slug \u003d \u0027profiler\u0027"}],"source_content_type":"text/x-python","patch_set":66,"id":"7a77a97e_95a0a592","line":22,"in_reply_to":"7a77a97e_ccfe2805","updated":"2016-11-15 09:49:03.000000000","message":"Done","commit_id":"3d9134877ab1e657b227e3668a9f7431d03f866e"}],"openstack_dashboard/contrib/developer/profiler/templates/profiler/_mode_picker.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{% if not_list %}"},{"line_number":2,"context_line":"  \u003cdiv class\u003d\"dropdown\" ng-controller\u003d\"profilerActionsController as ctrl\"\u003e"},{"line_number":3,"context_line":"{% else %}"},{"line_number":4,"context_line":"  \u003cli class\u003d\"dropdown\" ng-controller\u003d\"profilerActionsController as ctrl\"\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_f493935a","line":1,"updated":"2016-07-14 18:36:48.000000000","message":"There is only a single item in this list.  Can this just be a button then?","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":5,"context_line":"{% endif %}"},{"line_number":6,"context_line":"\u003ca data-toggle\u003d\"dropdown\" href\u003d\"#\" ng-if\u003d\"ctrl.state.enabled()\""},{"line_number":7,"context_line":"   class\u003d\"dropdown-toggle\" role\u003d\"button\" aria-expanded\u003d\"false\"\u003e"},{"line_number":8,"context_line":"  \u003cspan class\u003d\"fa fa-calculator\"\u003e\u003c/span\u003e"},{"line_number":9,"context_line":"  Profile"},{"line_number":10,"context_line":"  \u003cspan class\u003d\"fa fa-caret-down\"\u003e\u003c/span\u003e"},{"line_number":11,"context_line":"\u003c/a\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_34751b32","line":8,"updated":"2016-07-14 18:36:48.000000000","message":"Instead of \u0027calculator\u0027 here, can we use the \u0027fa-eye\u0027 icon?","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"\u003ca data-toggle\u003d\"dropdown\" href\u003d\"#\" ng-if\u003d\"ctrl.state.enabled()\""},{"line_number":7,"context_line":"   class\u003d\"dropdown-toggle\" role\u003d\"button\" aria-expanded\u003d\"false\"\u003e"},{"line_number":8,"context_line":"  \u003cspan class\u003d\"fa fa-calculator\"\u003e\u003c/span\u003e"},{"line_number":9,"context_line":"  Profile"},{"line_number":10,"context_line":"  \u003cspan class\u003d\"fa fa-caret-down\"\u003e\u003c/span\u003e"},{"line_number":11,"context_line":"\u003c/a\u003e"},{"line_number":12,"context_line":"\u003cul class\u003d\"dropdown-menu dropdown-menu-right\"\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_94016f6d","line":9,"updated":"2016-07-14 18:36:48.000000000","message":"Can we wrap \u0027Profile\u0027 inside of contextual span here?\n\nAlso, translate?","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"  \u003cspan class\u003d\"fa fa-caret-down\"\u003e\u003c/span\u003e"},{"line_number":11,"context_line":"\u003c/a\u003e"},{"line_number":12,"context_line":"\u003cul class\u003d\"dropdown-menu dropdown-menu-right\"\u003e"},{"line_number":13,"context_line":"  \u003cli\u003e\u003ca href\u003d\"#\" ng-click\u003d\"ctrl.profilePage()\"\u003e"},{"line_number":14,"context_line":"    \u003cspan class\u003d\"fa fa-refresh\"\u003e\u003c/span\u003e Profile Current Page"},{"line_number":15,"context_line":"  \u003c/a\u003e\u003c/li\u003e"},{"line_number":16,"context_line":"\u003c/ul\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_949ccf5e","line":13,"updated":"2016-07-14 18:36:48.000000000","message":"Nit: This spacing is hard to read.  Can we float elements onto new lines?","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":11,"context_line":"\u003c/a\u003e"},{"line_number":12,"context_line":"\u003cul class\u003d\"dropdown-menu dropdown-menu-right\"\u003e"},{"line_number":13,"context_line":"  \u003cli\u003e\u003ca href\u003d\"#\" ng-click\u003d\"ctrl.profilePage()\"\u003e"},{"line_number":14,"context_line":"    \u003cspan class\u003d\"fa fa-refresh\"\u003e\u003c/span\u003e Profile Current Page"},{"line_number":15,"context_line":"  \u003c/a\u003e\u003c/li\u003e"},{"line_number":16,"context_line":"\u003c/ul\u003e"},{"line_number":17,"context_line":"{% if not_list %}"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_94b32fe9","line":14,"updated":"2016-07-14 18:36:48.000000000","message":"Can we wrap \u0027Profile Current Page\u0027 in another contextual span?\n\nTranslate?","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"17466f9251064c192bea392f47c40439d5d1f4af","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% else %}"},{"line_number":4,"context_line":"  \u003cli class\u003d\"dropdown\" ng-controller\u003d\"profilerActionsController as ctrl\"\u003e"},{"line_number":5,"context_line":"{% endif %}"},{"line_number":6,"context_line":"\u003ca data-toggle\u003d\"dropdown\" href\u003d\"#\" ng-if\u003d\"ctrl.state.enabled()\""},{"line_number":7,"context_line":"   class\u003d\"dropdown-toggle\" role\u003d\"button\" aria-expanded\u003d\"false\"\u003e"},{"line_number":8,"context_line":"  \u003cspan class\u003d\"fa fa-calculator\"\u003e\u003c/span\u003e"},{"line_number":9,"context_line":"  Profile"},{"line_number":10,"context_line":"  \u003cspan class\u003d\"fa fa-caret-down\"\u003e\u003c/span\u003e"},{"line_number":11,"context_line":"\u003c/a\u003e"},{"line_number":12,"context_line":"\u003cul class\u003d\"dropdown-menu dropdown-menu-right\"\u003e"},{"line_number":13,"context_line":"  \u003cli\u003e\u003ca href\u003d\"#\" ng-click\u003d\"ctrl.profilePage()\"\u003e"},{"line_number":14,"context_line":"    \u003cspan class\u003d\"fa fa-refresh\"\u003e\u003c/span\u003e Profile Current Page"},{"line_number":15,"context_line":"  \u003c/a\u003e\u003c/li\u003e"},{"line_number":16,"context_line":"\u003c/ul\u003e"},{"line_number":17,"context_line":"{% if not_list %}"},{"line_number":18,"context_line":"  \u003c/div\u003e"},{"line_number":19,"context_line":"{% else %}"}],"source_content_type":"text/html","patch_set":43,"id":"fa7ab95a_802680b8","line":16,"range":{"start_line":6,"start_character":0,"end_line":16,"end_character":5},"updated":"2016-08-26 14:32:17.000000000","message":"could please you ident this for readability? it\u0027s hard to figure out at first sight what\u0027s the parent node of these ones","commit_id":"5ce8e07eb12cc2ae1eacb443b5f3ce6f476352c1"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"eaa1710f208ad8b86bb7e01fae0a5a9b77928869","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% else %}"},{"line_number":4,"context_line":"  \u003cli class\u003d\"dropdown\" ng-controller\u003d\"profilerActionsController as ctrl\"\u003e"},{"line_number":5,"context_line":"{% endif %}"},{"line_number":6,"context_line":"\u003ca data-toggle\u003d\"dropdown\" href\u003d\"#\" ng-if\u003d\"ctrl.state.enabled()\""},{"line_number":7,"context_line":"   class\u003d\"dropdown-toggle\" role\u003d\"button\" aria-expanded\u003d\"false\"\u003e"},{"line_number":8,"context_line":"  \u003cspan class\u003d\"fa fa-calculator\"\u003e\u003c/span\u003e"},{"line_number":9,"context_line":"  Profile"},{"line_number":10,"context_line":"  \u003cspan class\u003d\"fa fa-caret-down\"\u003e\u003c/span\u003e"},{"line_number":11,"context_line":"\u003c/a\u003e"},{"line_number":12,"context_line":"\u003cul class\u003d\"dropdown-menu dropdown-menu-right\"\u003e"},{"line_number":13,"context_line":"  \u003cli\u003e\u003ca href\u003d\"#\" ng-click\u003d\"ctrl.profilePage()\"\u003e"},{"line_number":14,"context_line":"    \u003cspan class\u003d\"fa fa-refresh\"\u003e\u003c/span\u003e Profile Current Page"},{"line_number":15,"context_line":"  \u003c/a\u003e\u003c/li\u003e"},{"line_number":16,"context_line":"\u003c/ul\u003e"},{"line_number":17,"context_line":"{% if not_list %}"},{"line_number":18,"context_line":"  \u003c/div\u003e"},{"line_number":19,"context_line":"{% else %}"}],"source_content_type":"text/html","patch_set":43,"id":"fa7ab95a_953cb6c9","line":16,"range":{"start_line":6,"start_character":0,"end_line":16,"end_character":5},"in_reply_to":"fa7ab95a_802680b8","updated":"2016-08-29 10:21:08.000000000","message":"Done","commit_id":"5ce8e07eb12cc2ae1eacb443b5f3ce6f476352c1"}],"openstack_dashboard/contrib/developer/profiler/templates/profiler/index.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block page_header %}"},{"line_number":9,"context_line":"  \u003ch1\u003eOpenStack Profiler\u003c/h1\u003e"},{"line_number":10,"context_line":"{% endblock %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_344d1bc5","line":9,"updated":"2016-07-14 18:36:48.000000000","message":"Does this need to be translated?","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \u003cthead\u003e"},{"line_number":33,"context_line":"        \u003ctr\u003e"},{"line_number":34,"context_line":"          \u003cth class\u003d\"expander\"\u003e\u003c/th\u003e"},{"line_number":35,"context_line":"          \u003cth\u003eTraced At\u003c/th\u003e"},{"line_number":36,"context_line":"          \u003cth\u003eTrace ID\u003c/th\u003e"},{"line_number":37,"context_line":"          \u003cth\u003eOrigin\u003c/th\u003e"},{"line_number":38,"context_line":"          \u003cth\u003eRequest time\u003c/th\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_7477a308","line":35,"updated":"2016-07-14 18:36:48.000000000","message":"Do these need to be translated?","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"6c578302b348c470b8bbfa5044fef8273e490ed3","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block page_header %}"},{"line_number":9,"context_line":"  \u003ch1\u003eOpenStack Profiler\u003c/h1\u003e"},{"line_number":10,"context_line":"{% endblock %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":33,"id":"3ac371cc_9ba6bf51","line":9,"updated":"2016-08-16 01:47:57.000000000","message":"here also needs \u0027trans\u0027 ?","commit_id":"7d1f97e55f87607833daa0efe8809485da85e8a0"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"18c3e63850d1c66ac40a7bff047de1fe836e64b9","unresolved":false,"context_lines":[{"line_number":6,"context_line":"{% endblock %}"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"{% block page_header %}"},{"line_number":9,"context_line":"  \u003ch1\u003eOpenStack Profiler\u003c/h1\u003e"},{"line_number":10,"context_line":"{% endblock %}"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":33,"id":"3ac371cc_789497e1","line":9,"in_reply_to":"3ac371cc_9ba6bf51","updated":"2016-08-16 10:25:25.000000000","message":"Same reasoning here about developer-only feature.","commit_id":"7d1f97e55f87607833daa0efe8809485da85e8a0"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"42ce86296cbb797a43de7edb974f909ebc5fc932","unresolved":false,"context_lines":[{"line_number":1,"context_line":"e{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block title %}"}],"source_content_type":"text/html","patch_set":44,"id":"fa7ab95a_d2b7f7d5","line":1,"updated":"2016-08-30 06:03:43.000000000","message":"\"e\"","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"31e7bf0e5645277996d5c144eaf38463edc692cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"e{% extends \u0027base.html\u0027 %}"},{"line_number":2,"context_line":"{% load i18n %}"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block title %}"}],"source_content_type":"text/html","patch_set":44,"id":"fa7ab95a_1234cd47","line":1,"in_reply_to":"fa7ab95a_d2b7f7d5","updated":"2016-08-30 17:37:45.000000000","message":"Good catch! Fixed.","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"42ce86296cbb797a43de7edb974f909ebc5fc932","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        \u003cdiv class\u003d\"btn-group\"\u003e"},{"line_number":18,"context_line":"          \u003clabel class\u003d\"btn btn-default btn-toggle\""},{"line_number":19,"context_line":"                 ng-repeat\u003d\"option in ctrl.toggleButtonOptions\""},{"line_number":20,"context_line":"                 ng-model\u003d\"ctrl.profiler.enabled\""},{"line_number":21,"context_line":"                 ng-model-options\u003d\"{ getterSetter: true }\""},{"line_number":22,"context_line":"                 btn-radio\u003d\"option.value\"\u003e{$ ::option.label $}\u003c/label\u003e"},{"line_number":23,"context_line":"        \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":44,"id":"fa7ab95a_8de390a3","line":20,"updated":"2016-08-30 06:03:43.000000000","message":"I can\u0027t confirm this (because I can\u0027t get configure page to work ;-) but won\u0027t this result in the enabled() function being passed the option *object* rather than the intended option.value? Thus it\u0027d \"work\" for enabling, but not for disabling.","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb0978aac8937528c590ef43213889f46e1a296c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"        \u003cdiv class\u003d\"btn-group\"\u003e"},{"line_number":18,"context_line":"          \u003clabel class\u003d\"btn btn-default btn-toggle\""},{"line_number":19,"context_line":"                 ng-repeat\u003d\"option in ctrl.toggleButtonOptions\""},{"line_number":20,"context_line":"                 ng-model\u003d\"ctrl.profiler.enabled\""},{"line_number":21,"context_line":"                 ng-model-options\u003d\"{ getterSetter: true }\""},{"line_number":22,"context_line":"                 btn-radio\u003d\"option.value\"\u003e{$ ::option.label $}\u003c/label\u003e"},{"line_number":23,"context_line":"        \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":44,"id":"fa7ab95a_14111a04","line":20,"in_reply_to":"fa7ab95a_8de390a3","updated":"2016-08-30 18:31:02.000000000","message":"It seems it\u0027s taking passing into `ctrl.profiler.enabled()` the value from [btn-radio] attribute which is a proper boolean type. At least so it works in Chrome debugger :).","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"}],"openstack_dashboard/contrib/developer/static/dashboard/developer/developer.module.js":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"cb12d78b162cd30b55e641e5bbdb62e160324a4a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    .module(\u0027horizon.dashboard.developer\u0027, ["},{"line_number":28,"context_line":"      \u0027horizon.dashboard.developer.theme-preview\u0027,"},{"line_number":29,"context_line":"      \u0027horizon.dashboard.developer.resource-browser\u0027,"},{"line_number":30,"context_line":"      \u0027horizon.dashboard.developer.profiler\u0027  "},{"line_number":31,"context_line":"    ])"},{"line_number":32,"context_line":"    .config(config);"},{"line_number":33,"context_line":""}],"source_content_type":"text/javascript","patch_set":62,"id":"9a629dbe_ef3f05d4","line":30,"updated":"2016-11-09 04:04:22.000000000","message":"Yeah. Red.","commit_id":"a5678013bba993fc7ea5cd6dcd568c42c9ec5bbe"}],"openstack_dashboard/contrib/developer/static/dashboard/developer/profiler/profiler.controller.js":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      var metadata \u003d {};"},{"line_number":91,"context_line":"      angular.forEach(info, function(value, key) {"},{"line_number":92,"context_line":"        var parts \u003d key.split(\".\");"},{"line_number":93,"context_line":"        if (parts[0] \u003d\u003d \"meta\") {"},{"line_number":94,"context_line":"          if (parts.length \u003d\u003d 2){"},{"line_number":95,"context_line":"            this[parts[1]] \u003d value;"},{"line_number":96,"context_line":"          }"}],"source_content_type":"text/javascript","patch_set":18,"id":"1aa78d24_74616311","line":93,"updated":"2016-07-14 18:36:48.000000000","message":"Nit: Spacings before curlie braces here are a little inconsistent.","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        if (parts[0] \u003d\u003d \"meta\") {"},{"line_number":94,"context_line":"          if (parts.length \u003d\u003d 2){"},{"line_number":95,"context_line":"            this[parts[1]] \u003d value;"},{"line_number":96,"context_line":"          }"},{"line_number":97,"context_line":"          else{"},{"line_number":98,"context_line":"            var group_name \u003d parts[1];"},{"line_number":99,"context_line":"            if (!(group_name in this))"}],"source_content_type":"text/javascript","patch_set":18,"id":"1aa78d24_3457db27","line":96,"updated":"2016-07-14 18:36:48.000000000","message":"spacing here ... :-D","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        }"},{"line_number":104,"context_line":"      }, metadata);"},{"line_number":105,"context_line":"      info[\"duration\"] \u003d info[\"finished\"] - info[\"started\"];"},{"line_number":106,"context_line":"      info[\"metadata\"] \u003d \"\u003cpre\u003e\" + JSON.stringify(metadata, \"\", 4) + \"\u003c/pre\u003e\";"},{"line_number":107,"context_line":"      var trace_data \u003d \"\u003cdiv class\u003d\u0027row\u0027\u003e\";"},{"line_number":108,"context_line":"      var columns \u003d [\"name\", \"project\", \"service\", \"host\", \"started\","},{"line_number":109,"context_line":"        \"finished\", \"duration\", \"metadata\"];"}],"source_content_type":"text/javascript","patch_set":18,"id":"1aa78d24_d42017b3","line":106,"updated":"2016-07-14 18:36:48.000000000","message":"We need to move this into its own template, to make it easier to read as well as customizable.","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"42ce86296cbb797a43de7edb974f909ebc5fc932","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    .controller(\u0027topProfilerController\u0027, topProfilerController)"},{"line_number":24,"context_line":"    .controller(\u0027sharedProfilerController\u0027, sharedProfilerController);"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  topProfilerController.$inject \u003d ["},{"line_number":27,"context_line":"    \u0027horizon.framework.util.http.service\u0027,"},{"line_number":28,"context_line":"    \u0027horizon.dashboard.developer.profiler.state\u0027];"},{"line_number":29,"context_line":""}],"source_content_type":"text/javascript","patch_set":44,"id":"fa7ab95a_ed2c1c9b","line":26,"updated":"2016-08-30 06:03:43.000000000","message":"Since you have a few controllers in this file, it\u0027d be nice to have some visual marker to indicate where new controllers start.","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb0978aac8937528c590ef43213889f46e1a296c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    .controller(\u0027topProfilerController\u0027, topProfilerController)"},{"line_number":24,"context_line":"    .controller(\u0027sharedProfilerController\u0027, sharedProfilerController);"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  topProfilerController.$inject \u003d ["},{"line_number":27,"context_line":"    \u0027horizon.framework.util.http.service\u0027,"},{"line_number":28,"context_line":"    \u0027horizon.dashboard.developer.profiler.state\u0027];"},{"line_number":29,"context_line":""}],"source_content_type":"text/javascript","patch_set":44,"id":"fa7ab95a_573804d3","line":26,"in_reply_to":"fa7ab95a_ed2c1c9b","updated":"2016-08-30 18:31:02.000000000","message":"Done","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"42ce86296cbb797a43de7edb974f909ebc5fc932","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    \u0027horizon.framework.util.http.service\u0027,"},{"line_number":28,"context_line":"    \u0027horizon.dashboard.developer.profiler.state\u0027];"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  sharedProfilerController.$inject \u003d [\u0027$modal\u0027];"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  function topProfilerController($http, profilerState) {"},{"line_number":33,"context_line":"    var ctrl \u003d this;"}],"source_content_type":"text/javascript","patch_set":44,"id":"fa7ab95a_2d0c443a","line":30,"updated":"2016-08-30 06:03:43.000000000","message":"This could be down with the sharedProfilerController itself, rather than mixed in here.","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb0978aac8937528c590ef43213889f46e1a296c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    \u0027horizon.framework.util.http.service\u0027,"},{"line_number":28,"context_line":"    \u0027horizon.dashboard.developer.profiler.state\u0027];"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"  sharedProfilerController.$inject \u003d [\u0027$modal\u0027];"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  function topProfilerController($http, profilerState) {"},{"line_number":33,"context_line":"    var ctrl \u003d this;"}],"source_content_type":"text/javascript","patch_set":44,"id":"fa7ab95a_34d45eea","line":30,"in_reply_to":"fa7ab95a_2d0c443a","updated":"2016-08-30 18:31:02.000000000","message":"Done","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"42ce86296cbb797a43de7edb974f909ebc5fc932","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \u0027\u003cdiv class\u003d\"modal-header\"\u003e Trace Point Details \u003c/div\u003e\u0027 +"},{"line_number":130,"context_line":"        \u0027\u003cdiv class\u003d\"modal-body\"\u003e\u0027 + trace_data + \u0027\u003c/div\u003e\u0027 +"},{"line_number":131,"context_line":"        \u0027\u003cdiv class\u003d\"modal-footer\"\u003e\u003cspan class\u003d\"fa fa-cloud\"\u003e\u003c/span\u003e\u003c/div\u003e\u0027"},{"line_number":132,"context_line":"      );"},{"line_number":133,"context_line":"      var modal_instance \u003d $modal.open({"},{"line_number":134,"context_line":"        \"template\": output,"},{"line_number":135,"context_line":"        \"size\": \"lg\""}],"source_content_type":"text/javascript","patch_set":44,"id":"fa7ab95a_ed889c73","line":132,"updated":"2016-08-30 06:03:43.000000000","message":"I know it\u0027s \"just a developer page\" but the above really should be in a HTML template with the info/columns used in template rendering.","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"fb0978aac8937528c590ef43213889f46e1a296c","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        \u0027\u003cdiv class\u003d\"modal-header\"\u003e Trace Point Details \u003c/div\u003e\u0027 +"},{"line_number":130,"context_line":"        \u0027\u003cdiv class\u003d\"modal-body\"\u003e\u0027 + trace_data + \u0027\u003c/div\u003e\u0027 +"},{"line_number":131,"context_line":"        \u0027\u003cdiv class\u003d\"modal-footer\"\u003e\u003cspan class\u003d\"fa fa-cloud\"\u003e\u003c/span\u003e\u003c/div\u003e\u0027"},{"line_number":132,"context_line":"      );"},{"line_number":133,"context_line":"      var modal_instance \u003d $modal.open({"},{"line_number":134,"context_line":"        \"template\": output,"},{"line_number":135,"context_line":"        \"size\": \"lg\""}],"source_content_type":"text/javascript","patch_set":44,"id":"fa7ab95a_7aa96f23","line":132,"in_reply_to":"fa7ab95a_ed889c73","updated":"2016-08-30 18:31:02.000000000","message":"Well, I separated them to a certain extent, hope you like it :).","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"}],"openstack_dashboard/contrib/developer/static/dashboard/developer/profiler/profiler.scss":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"8b43985a4adced6caa2c3bdf58bcd24e00744db4","unresolved":false,"context_lines":[{"line_number":1,"context_line":".profiler {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  .trace {"},{"line_number":4,"context_line":"    min-width: 900px;"}],"source_content_type":"text/x-scss","patch_set":2,"id":"7a1b2928_99629fac","line":1,"updated":"2016-04-10 15:11:53.000000000","message":"Can we inherit these values from theme?","commit_id":"bf8999782d20b1a048a489da7b34a37b321f576e"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"7efccd125d5bde41bec280f7942c9c80cb8243f5","unresolved":false,"context_lines":[{"line_number":1,"context_line":".profiler {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  .trace {"},{"line_number":4,"context_line":"    min-width: 900px;"}],"source_content_type":"text/x-scss","patch_set":4,"id":"dab17558_a0862d62","line":1,"updated":"2016-05-17 22:51:58.000000000","message":"Tons of hard coded values here ... can we inherit these from the theme?","commit_id":"cd7b66acaae874a1217a479511d8a059b93dfbfe"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":".profiler {"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  .trace {"},{"line_number":4,"context_line":"    min-width: 900px;"}],"source_content_type":"text/x-scss","patch_set":18,"id":"1aa78d24_b4b2ab04","line":1,"updated":"2016-07-14 18:36:48.000000000","message":"Lots of hard coding going on here ... can we clean this up to make use of theming vars?","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"}],"openstack_dashboard/contrib/developer/static/dashboard/developer/profiler/profiler.service.js":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"42ce86296cbb797a43de7edb974f909ebc5fc932","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  profilerState.$inject \u003d [\u0027$cookies\u0027];"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  function profilerState($cookies) {"},{"line_number":27,"context_line":"    var _enabled \u003d isSet(\u0027profiler_enabled\u0027);"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    return {"},{"line_number":30,"context_line":"      enabled: enabled"}],"source_content_type":"text/javascript","patch_set":44,"id":"fa7ab95a_ada5b447","line":27,"updated":"2016-08-30 06:03:43.000000000","message":"Does isSet need to be a function, given that it\u0027s only invoked once on creation of the Service singleton?","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"31e7bf0e5645277996d5c144eaf38463edc692cf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  profilerState.$inject \u003d [\u0027$cookies\u0027];"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  function profilerState($cookies) {"},{"line_number":27,"context_line":"    var _enabled \u003d isSet(\u0027profiler_enabled\u0027);"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    return {"},{"line_number":30,"context_line":"      enabled: enabled"}],"source_content_type":"text/javascript","patch_set":44,"id":"fa7ab95a_d7a337b0","line":27,"in_reply_to":"fa7ab95a_ada5b447","updated":"2016-08-30 17:37:45.000000000","message":"Done","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"}],"openstack_dashboard/contrib/developer/static/dashboard/developer/profiler/profiler.trace-table.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003ctable class\u003d\"trace\"\u003e"},{"line_number":2,"context_line":"  \u003cthead\u003e"},{"line_number":3,"context_line":"  \u003ctr class\u003d\"bold text-left\"\u003e"},{"line_number":4,"context_line":"    \u003ctd class\u003d\"level\"\u003eLevels\u003c/td\u003e"},{"line_number":5,"context_line":"    \u003ctd\u003eDuration\u003c/td\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_6f298ef2","line":2,"updated":"2016-07-14 18:36:48.000000000","message":"The spacing in this file is a bit off.","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003ctable class\u003d\"trace\"\u003e"},{"line_number":2,"context_line":"  \u003cthead\u003e"},{"line_number":3,"context_line":"  \u003ctr class\u003d\"bold text-left\"\u003e"},{"line_number":4,"context_line":"    \u003ctd class\u003d\"level\"\u003eLevels\u003c/td\u003e"},{"line_number":5,"context_line":"    \u003ctd\u003eDuration\u003c/td\u003e"},{"line_number":6,"context_line":"    \u003ctd\u003eType\u003c/td\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_2f4826cc","line":3,"updated":"2016-07-14 18:36:48.000000000","message":"Can we use a contextual class here instead of \u0027bold\u0027 ?","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":13,"context_line":"  \u003ctbody\u003e"},{"line_number":14,"context_line":"  \u003ctr node-data\u003d\"data\" root-data\u003d\"data\" visible\u003d\"true\"\u003e"},{"line_number":15,"context_line":"    \u003ctd colspan\u003d\"7\" align\u003d\"center\"\u003e"},{"line_number":16,"context_line":"      \u003ci class\u003d\"fa fa-spin fa-refresh fa-3x\"\u003e\u003c/i\u003e"},{"line_number":17,"context_line":"    \u003c/td\u003e"},{"line_number":18,"context_line":"  \u003c/tr\u003e"},{"line_number":19,"context_line":"  \u003c/tbody\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_6fb4eed3","line":16,"updated":"2016-07-14 18:36:48.000000000","message":"Please use \u003cspan\u003e instead of \u003ci\u003e, but actually you will want to use the spinner directive in the end","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"}],"openstack_dashboard/contrib/developer/static/dashboard/developer/profiler/profiler.tree-node.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"27957fef16c5fd5e4a4642bb5c5c45e5c1cba7c7","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  \u003ctd ng-click\u003d\"ctrl.display(data);\"\u003e {$ data.info.service  || \"n/a\" $} \u003c/td\u003e"},{"line_number":17,"context_line":"  \u003ctd ng-click\u003d\"ctrl.display(data);\"\u003e {$ data.info.host || \"n/a\"$} \u003c/td\u003e"},{"line_number":18,"context_line":"  \u003ctd class\u003d\"details\"\u003e"},{"line_number":19,"context_line":"    \u003ca href\u003d\"#\" ng-click\u003d\"ctrl.display(data);\"\u003e Details \u003c/a\u003e"},{"line_number":20,"context_line":"  \u003c/td\u003e"},{"line_number":21,"context_line":"\u003c/tr\u003e"},{"line_number":22,"context_line":"\u003ctr ng-repeat\u003d\"child in data.children\" node-data\u003d\"child\" visible\u003d\"child.visible\" root-data\u003d\"rootData\"\u003e\u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":18,"id":"1aa78d24_ef245e0f","line":19,"updated":"2016-07-14 18:36:48.000000000","message":"Can we remove the extra spaces here ... it can muck up intended paddings.\n\nThis needs to be translated too?","commit_id":"e86237175cb2818cf958d3c8eab256d88672e25c"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"42ce86296cbb797a43de7edb974f909ebc5fc932","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"\u003ctr ng-if\u003d\"data\" ng-show\u003d\"visible\"\u003e"},{"line_number":3,"context_line":"  \u003ctd class\u003d\"level\" ng-style\u003d\"{\u0027padding-left\u0027: data.level * 5 + \u0027px\u0027}\"\u003e"},{"line_number":4,"context_line":"    \u003cbutton type\u003d\"button\" class\u003d\"btn btn-default btn-xs\" ng-disabled\u003d\"data.is_leaf\" ng-click\u003d\"ctrl.toggleChildren(data)\"\u003e"},{"line_number":5,"context_line":"      \u003cspan class\u003d\"fa\" ng-class\u003d\"[ctrl.getLeafCls(data), ctrl.getBranchCls(data)]\"\u003e\u003c/span\u003e"},{"line_number":6,"context_line":"      {$ data.level || 0 $}"},{"line_number":7,"context_line":"    \u003c/button\u003e"}],"source_content_type":"text/html","patch_set":44,"id":"fa7ab95a_2d47e477","line":4,"updated":"2016-08-30 06:03:43.000000000","message":"minor: please wrap this long line.","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"31e7bf0e5645277996d5c144eaf38463edc692cf","unresolved":false,"context_lines":[{"line_number":1,"context_line":""},{"line_number":2,"context_line":"\u003ctr ng-if\u003d\"data\" ng-show\u003d\"visible\"\u003e"},{"line_number":3,"context_line":"  \u003ctd class\u003d\"level\" ng-style\u003d\"{\u0027padding-left\u0027: data.level * 5 + \u0027px\u0027}\"\u003e"},{"line_number":4,"context_line":"    \u003cbutton type\u003d\"button\" class\u003d\"btn btn-default btn-xs\" ng-disabled\u003d\"data.is_leaf\" ng-click\u003d\"ctrl.toggleChildren(data)\"\u003e"},{"line_number":5,"context_line":"      \u003cspan class\u003d\"fa\" ng-class\u003d\"[ctrl.getLeafCls(data), ctrl.getBranchCls(data)]\"\u003e\u003c/span\u003e"},{"line_number":6,"context_line":"      {$ data.level || 0 $}"},{"line_number":7,"context_line":"    \u003c/button\u003e"}],"source_content_type":"text/html","patch_set":44,"id":"fa7ab95a_771eeb0c","line":4,"in_reply_to":"fa7ab95a_2d47e477","updated":"2016-08-30 17:37:45.000000000","message":"Done","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"42ce86296cbb797a43de7edb974f909ebc5fc932","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  \u003ctd\u003e{$ data.info.host || \"n/a\"$}\u003c/td\u003e"},{"line_number":24,"context_line":"  \u003ctd\u003e\u003ca href\u003d\"#\" ng-click\u003d\"ctrl.display(data);\"\u003eDetails\u003c/a\u003e\u003c/td\u003e"},{"line_number":25,"context_line":"\u003c/tr\u003e"},{"line_number":26,"context_line":"\u003ctr ng-repeat\u003d\"child in data.children\" node-data\u003d\"child\" visible\u003d\"child.visible\" root-data\u003d\"rootData\"\u003e\u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":44,"id":"fa7ab95a_ed37bcfc","line":26,"updated":"2016-08-30 06:03:43.000000000","message":"Please also wrap.","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"31e7bf0e5645277996d5c144eaf38463edc692cf","unresolved":false,"context_lines":[{"line_number":23,"context_line":"  \u003ctd\u003e{$ data.info.host || \"n/a\"$}\u003c/td\u003e"},{"line_number":24,"context_line":"  \u003ctd\u003e\u003ca href\u003d\"#\" ng-click\u003d\"ctrl.display(data);\"\u003eDetails\u003c/a\u003e\u003c/td\u003e"},{"line_number":25,"context_line":"\u003c/tr\u003e"},{"line_number":26,"context_line":"\u003ctr ng-repeat\u003d\"child in data.children\" node-data\u003d\"child\" visible\u003d\"child.visible\" root-data\u003d\"rootData\"\u003e\u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":44,"id":"fa7ab95a_9719af24","line":26,"in_reply_to":"fa7ab95a_ed37bcfc","updated":"2016-08-30 17:37:45.000000000","message":"Done","commit_id":"3f6892e93bdca8594cb5c05242323567fe630f17"}],"releasenotes/notes/openstack-profiler-at-developer-dashboard-da1b1556e30aa858.yaml":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"cb12d78b162cd30b55e641e5bbdb62e160324a4a","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    Initially profiler is disabled. To enable it the value"},{"line_number":9,"context_line":"    ``OPENSTACK_PROFILER[\u0027enabled\u0027]`` has to be ``True``."},{"line_number":10,"context_line":"    This in turn can be achieved by copying files"},{"line_number":11,"context_line":"    _9030_toggle_profiler.py.example and _9030_profiler.py to"},{"line_number":12,"context_line":"    openstack_dashboard/local/local_settings.d/_9030_toggle_profiler.py"},{"line_number":13,"context_line":"    and openstack_dashboard/local/enabled/_9030_profiler.py"},{"line_number":14,"context_line":"    Also, by default it expects MongoDB cluster"}],"source_content_type":"text/x-yaml","patch_set":62,"id":"9a629dbe_6f03f50f","line":11,"updated":"2016-11-09 04:04:22.000000000","message":"Rename here?","commit_id":"a5678013bba993fc7ea5cd6dcd568c42c9ec5bbe"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"732f1f3a10fc278eedf8ac40bc62dce9629711c8","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    Initially profiler is disabled. To enable it the value"},{"line_number":9,"context_line":"    ``OPENSTACK_PROFILER[\u0027enabled\u0027]`` has to be ``True``."},{"line_number":10,"context_line":"    This in turn can be achieved by copying files"},{"line_number":11,"context_line":"    _9030_toggle_profiler.py.example and _9030_profiler.py to"},{"line_number":12,"context_line":"    openstack_dashboard/local/local_settings.d/_9030_toggle_profiler.py"},{"line_number":13,"context_line":"    and openstack_dashboard/local/enabled/_9030_profiler.py"},{"line_number":14,"context_line":"    Also, by default it expects MongoDB cluster"}],"source_content_type":"text/x-yaml","patch_set":62,"id":"9a629dbe_f321a74e","line":11,"in_reply_to":"9a629dbe_6f03f50f","updated":"2016-11-09 09:01:14.000000000","message":"Done","commit_id":"a5678013bba993fc7ea5cd6dcd568c42c9ec5bbe"}]}
