)]}'
{"openstack_dashboard/dashboards/project/stacks/workflows.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"c24f729bd560c616c10d2692a029dc70ecbab6cf","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            help_text\u003d_(\u0027This is required for operations to be performed \u0027"},{"line_number":192,"context_line":"                        \u0027throughout the lifecycle of the stack\u0027),"},{"line_number":193,"context_line":"            required\u003dTrue,"},{"line_number":194,"context_line":"            widget\u003dforms.PasswordInput())"},{"line_number":195,"context_line":"        params \u003d self.template_validate.get(\u0027Parameters\u0027, {})"},{"line_number":196,"context_line":"        for param_key, param in params.items():"},{"line_number":197,"context_line":"            field_key \u003d self.param_prefix + param_key"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2Fqxc%3D","line":194,"updated":"2013-05-28 05:58:16.000000000","message":"Since the password field is masked, you probably need another field for confirm password.  Also please use the password validator from horizon.utils.\n\nYou can find a sample here.","commit_id":"41221f577930934070fa1c26f90510f860fed6d2"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"87018e661d732e03b1419fede36bdb55e772e566","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            help_text\u003d_(\u0027This is required for operations to be performed \u0027"},{"line_number":192,"context_line":"                        \u0027throughout the lifecycle of the stack\u0027),"},{"line_number":193,"context_line":"            required\u003dTrue,"},{"line_number":194,"context_line":"            widget\u003dforms.PasswordInput())"},{"line_number":195,"context_line":"        params \u003d self.template_validate.get(\u0027Parameters\u0027, {})"},{"line_number":196,"context_line":"        for param_key, param in params.items():"},{"line_number":197,"context_line":"            field_key \u003d self.param_prefix + param_key"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FnvA%3D","line":194,"in_reply_to":"AAAAPH%2F%2FoB0%3D","updated":"2013-05-29 05:24:52.000000000","message":"ah, thanks for the clarification. Looks good then.\n\nWill review it again when the gating job passes.","commit_id":"41221f577930934070fa1c26f90510f860fed6d2"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"3f2ff431121243beb949a658d177c6c092f5003e","unresolved":false,"context_lines":[{"line_number":191,"context_line":"            help_text\u003d_(\u0027This is required for operations to be performed \u0027"},{"line_number":192,"context_line":"                        \u0027throughout the lifecycle of the stack\u0027),"},{"line_number":193,"context_line":"            required\u003dTrue,"},{"line_number":194,"context_line":"            widget\u003dforms.PasswordInput())"},{"line_number":195,"context_line":"        params \u003d self.template_validate.get(\u0027Parameters\u0027, {})"},{"line_number":196,"context_line":"        for param_key, param in params.items():"},{"line_number":197,"context_line":"            field_key \u003d self.param_prefix + param_key"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2FoB0%3D","line":194,"in_reply_to":"AAAAPH%2F%2Fqxc%3D","updated":"2013-05-29 00:33:54.000000000","message":"The password prompt is for authentication, not for changing the password. The API will respond with an authentication failed message if an incorrect password is entered.","commit_id":"41221f577930934070fa1c26f90510f860fed6d2"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"8d0f2b2f78a4896149d2e5a15c100b03c548b863","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            (k[prefix_length:], v) for (k, v) in cleaned.iteritems()"},{"line_number":161,"context_line":"                if k.startswith(self.param_prefix))"},{"line_number":162,"context_line":"        fields \u003d {"},{"line_number":163,"context_line":"            \u0027password\u0027: context.get(\u0027password\u0027),"},{"line_number":164,"context_line":"            \u0027stack_name\u0027: context.get(\u0027stack_name\u0027),"},{"line_number":165,"context_line":"            \u0027timeout_mins\u0027: context.get(\u0027timeout_mins\u0027),"},{"line_number":166,"context_line":"            \u0027disable_rollback\u0027: not(context.get(\u0027enable_rollback\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPX%2F%2FsYU%3D","line":163,"updated":"2013-06-12 17:14:29.000000000","message":"password should be treated as sensitive data.  See openstack_dashboard/dashboards/admin/users for examples in views.py and forms.py","commit_id":"1bc78e69f6cbc8686b8ba91e752c1726d5053cba"},{"author":{"_account_id":4571,"name":"Steve Baker","email":"sbaker@redhat.com","username":"steve-stevebaker"},"change_message_id":"d4870ecbf665cf748b73c9b83674579dfd226c13","unresolved":false,"context_lines":[{"line_number":160,"context_line":"            (k[prefix_length:], v) for (k, v) in cleaned.iteritems()"},{"line_number":161,"context_line":"                if k.startswith(self.param_prefix))"},{"line_number":162,"context_line":"        fields \u003d {"},{"line_number":163,"context_line":"            \u0027password\u0027: context.get(\u0027password\u0027),"},{"line_number":164,"context_line":"            \u0027stack_name\u0027: context.get(\u0027stack_name\u0027),"},{"line_number":165,"context_line":"            \u0027timeout_mins\u0027: context.get(\u0027timeout_mins\u0027),"},{"line_number":166,"context_line":"            \u0027disable_rollback\u0027: not(context.get(\u0027enable_rollback\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAPn%2F%2F4uw%3D","line":163,"in_reply_to":"AAAAPX%2F%2FsYU%3D","updated":"2013-06-18 23:24:44.000000000","message":"It wasn\u0027t clear where the sensitive_post_parameters decorator would be applied here, so let me know if I did the right thing.","commit_id":"1bc78e69f6cbc8686b8ba91e752c1726d5053cba"}]}
