)]}'
{"openstack_dashboard/dashboards/admin/groups/tables.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"36c5c8215da48858da7b1bf5eda193abd954e81d","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"LOGOUT_URL \u003d \u0027logout\u0027"},{"line_number":33,"context_line":"STATUS_CHOICES \u003d ("},{"line_number":34,"context_line":"    (\"true\", True),"},{"line_number":35,"context_line":"    (\"false\", False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2Ft%2Fo%3D","line":32,"updated":"2013-05-24 15:43:57.000000000","message":"this should be auth/logout","commit_id":"f55bd29da93636650cb0bca60fde9695339b1b20"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"76b549054b649bd28592b5c73693ffa49d4d7713","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"LOGOUT_URL \u003d \u0027logout\u0027"},{"line_number":33,"context_line":"STATUS_CHOICES \u003d ("},{"line_number":34,"context_line":"    (\"true\", True),"},{"line_number":35,"context_line":"    (\"false\", False)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPH%2F%2FttA%3D","line":32,"in_reply_to":"AAAAPH%2F%2Ft%2Fo%3D","updated":"2013-05-24 17:20:43.000000000","message":"This is right, it is supposed to be the url namespace.  \n\nI missed a call to reverse() in line 138 though, added it in the next patch","commit_id":"f55bd29da93636650cb0bca60fde9695339b1b20"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e1c5cfebaa1b15257a499863fd724a4ed829c0b6","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                                       user_id\u003duser_obj.id)"},{"line_number":135,"context_line":"        # Keystone revokes the token of the user removed from the group."},{"line_number":136,"context_line":"        # If the logon user was removed, redirect the user to logout."},{"line_number":137,"context_line":"        if request.user.id \u003d\u003d user_obj.id:"},{"line_number":138,"context_line":"            self.success_url \u003d reverse(LOGOUT_URL)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fqz0%3D","line":137,"updated":"2013-05-28 04:44:28.000000000","message":"I\u0027ll be removing this code. It causes more harm than good, the success_url persist across page reloads. After hitting this code, the user gets logout whenever a user is removed.\n\nThis probably need to be handled the same way as https://bugs.launchpad.net/horizon/+bug/1166794","commit_id":"abe3b53a8502d363541566445312079250bca9ca"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e1c5cfebaa1b15257a499863fd724a4ed829c0b6","unresolved":false,"context_lines":[{"line_number":191,"context_line":"                                    user_id\u003duser_obj.id)"},{"line_number":192,"context_line":"        # Keystone revokes the token of the user added to the group."},{"line_number":193,"context_line":"        # If the logon user was added, redirect the user to logout."},{"line_number":194,"context_line":"        if request.user.id \u003d\u003d user_obj.id:"},{"line_number":195,"context_line":"            self.success_url \u003d LOGOUT_URL"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    def get_success_url(self, request\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fqzw%3D","line":194,"updated":"2013-05-28 04:44:28.000000000","message":"same here, going to remove this logic.","commit_id":"abe3b53a8502d363541566445312079250bca9ca"}],"openstack_dashboard/dashboards/admin/groups/views.py":[{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"fd63cb77b979505c8dc8644d02fa6a0909e0963b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _add_group_id_attribute(self, users):"},{"line_number":91,"context_line":"        group_details \u003d {\u0027group_id\u0027: self.kwargs[\u0027group_id\u0027]}"},{"line_number":92,"context_line":"        for user in users:"},{"line_number":93,"context_line":"            user._add_details(group_details)"},{"line_number":94,"context_line":"        return users"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _get_group_members(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Frio%3D","line":93,"updated":"2013-05-27 14:01:06.000000000","message":"This seems like a bad idea. I haven\u0027t run the code, so I might be missing something, but why does this need to be set on every user? The group id is already stored in the table, right?","commit_id":"abe3b53a8502d363541566445312079250bca9ca"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"e1c5cfebaa1b15257a499863fd724a4ed829c0b6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _add_group_id_attribute(self, users):"},{"line_number":91,"context_line":"        group_details \u003d {\u0027group_id\u0027: self.kwargs[\u0027group_id\u0027]}"},{"line_number":92,"context_line":"        for user in users:"},{"line_number":93,"context_line":"            user._add_details(group_details)"},{"line_number":94,"context_line":"        return users"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _get_group_members(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fqz8%3D","line":93,"in_reply_to":"AAAAPH%2F%2Fq90%3D","updated":"2013-05-28 04:44:28.000000000","message":"The patch needs rebasing, I\u0027ll clean this up in the next patch. Good catch.","commit_id":"abe3b53a8502d363541566445312079250bca9ca"},{"author":{"_account_id":5733,"name":"Kieran Spear","email":"kispear@gmail.com","username":"kspear"},"change_message_id":"babbaaaf222392e81554c674aa5420f7823cf488","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _add_group_id_attribute(self, users):"},{"line_number":91,"context_line":"        group_details \u003d {\u0027group_id\u0027: self.kwargs[\u0027group_id\u0027]}"},{"line_number":92,"context_line":"        for user in users:"},{"line_number":93,"context_line":"            user._add_details(group_details)"},{"line_number":94,"context_line":"        return users"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _get_group_members(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2Fq90%3D","line":93,"in_reply_to":"AAAAPH%2F%2FrOo%3D","updated":"2013-05-28 02:03:33.000000000","message":"Agree, not a blocker. But it would be good to eliminate it in the future if it\u0027s not required.","commit_id":"abe3b53a8502d363541566445312079250bca9ca"},{"author":{"_account_id":1816,"name":"Gabriel Hurley","email":"gabriel.hurley@nebula.com","username":"gabriel-hurley"},"change_message_id":"d5379f5f576e912ab1ed1fd6662146ff058a7936","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _add_group_id_attribute(self, users):"},{"line_number":91,"context_line":"        group_details \u003d {\u0027group_id\u0027: self.kwargs[\u0027group_id\u0027]}"},{"line_number":92,"context_line":"        for user in users:"},{"line_number":93,"context_line":"            user._add_details(group_details)"},{"line_number":94,"context_line":"        return users"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def _get_group_members(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPH%2F%2FrOo%3D","line":93,"in_reply_to":"AAAAPH%2F%2Frio%3D","updated":"2013-05-27 18:22:34.000000000","message":"I\u0027m not stoked on calling an internal method from keystonclient, but at the same time, it\u0027s quite harmless in this situation. It\u0027s just going to end up doing a setattr(user, \u0027group_id\u0027, \u003cvalue\u003e). There\u0027s no chance of other data being overwritten here, etc. I don\u0027t see this is a blocker currently.","commit_id":"abe3b53a8502d363541566445312079250bca9ca"}]}
