)]}'
{"openstack_dashboard/dashboards/project/instances/forms.py":[{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"24f68a653d3bf202d0cd114eb296ae1ae1eba71c","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                volumes.append((volume.name, \u0027%s (%s)\u0027 % (volume.name,"},{"line_number":200,"context_line":"                                                          volume.id)))"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        if volume_list:"},{"line_number":203,"context_line":"            volumes.insert(0, (\"\", _(\"Select a volume\")))"},{"line_number":204,"context_line":"        else:"},{"line_number":205,"context_line":"            volumes \u003d (\"\", _(\"No volumes available\"))"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_d6d64b26","line":202,"range":{"start_line":202,"start_character":8,"end_line":202,"end_character":23},"updated":"2016-04-18 15:28:49.000000000","message":"shouldn\u0027t you be checking against the length of variable \"volumes\" instead of volume_list? I noticed that the dropdown always shows the option \"Select a  volume\" even if all the volumes are already attached","commit_id":"c3c322998ae1608baee8a9d3643529c5faf11694"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"a39f4848592fb0d97e8c38281d96899bb7771a73","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        for volume in volume_list:"},{"line_number":196,"context_line":"            # Only show volumes that aren\u0027t attached to an instance already"},{"line_number":197,"context_line":"            if not volume.attachments:"},{"line_number":198,"context_line":"                volumes.append((volume.name, \u0027%s (%s)\u0027 % (volume.name,"},{"line_number":199,"context_line":"                                                          volume.id)))"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        if volumes:"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_46333214","line":198,"range":{"start_line":198,"start_character":35,"end_line":198,"end_character":36},"updated":"2016-04-28 15:59:49.000000000","message":"you might want to use named string parameters to make i18n work easier","commit_id":"5d04b0145c702c591da628e6b744c390cfd4afbe"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"db8a64535bd79ef7f0ab3df406ba75503ddd3415","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":236,"context_line":"            exceptions.handle(request,"},{"line_number":237,"context_line":"                              _(\u0027Unable to attach volume.\u0027),"},{"line_number":238,"context_line":"                              redirect\u003dredirect)"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"class DetachVolume(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_02155d9a","line":238,"updated":"2016-05-02 13:42:00.000000000","message":"might want to still return something here","commit_id":"13469e64e6bd7c003690918f9241658bca81e6f6"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"db8a64535bd79ef7f0ab3df406ba75503ddd3415","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            exceptions.handle(request,"},{"line_number":294,"context_line":"                              _(\"Unable to detach volume.\"),"},{"line_number":295,"context_line":"                              redirect\u003dredirect)"},{"line_number":296,"context_line":"        return True"},{"line_number":297,"context_line":""},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"class AttachInterface(forms.SelfHandlingForm):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_a224690e","line":296,"updated":"2016-05-02 13:42:00.000000000","message":"make this method\u0027s handling of \"return True\" look like the Attach version above.  Either pattern is fine, but just be consistent for readability.","commit_id":"13469e64e6bd7c003690918f9241658bca81e6f6"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"04c0fdea15509e1c4b224a7490d5485ec2305955","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class AttachVolume(forms.SelfHandlingForm):"},{"line_number":172,"context_line":"    volume \u003d forms.ChoiceField(label\u003d_(\"Volume ID\"),"},{"line_number":173,"context_line":"                               help_text\u003d_(\"Select a voume to attach\""},{"line_number":174,"context_line":"                                           \"to this instance.\"))"},{"line_number":175,"context_line":"    device \u003d forms.CharField(label\u003d_(\"Device Name\"),"},{"line_number":176,"context_line":"                             widget\u003dforms.HiddenInput(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_004a6b55","line":173,"updated":"2016-05-02 23:09:34.000000000","message":"volume*\n\nalso need space after \u0027attach\u0027","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"300a8426698a97669d5c9e89c9f096d366a586f8","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class AttachVolume(forms.SelfHandlingForm):"},{"line_number":172,"context_line":"    volume \u003d forms.ChoiceField(label\u003d_(\"Volume ID\"),"},{"line_number":173,"context_line":"                               help_text\u003d_(\"Select a voume to attach\""},{"line_number":174,"context_line":"                                           \"to this instance.\"))"},{"line_number":175,"context_line":"    device \u003d forms.CharField(label\u003d_(\"Device Name\"),"},{"line_number":176,"context_line":"                             widget\u003dforms.HiddenInput(),"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_efd10158","line":173,"in_reply_to":"1a122d0e_004a6b55","updated":"2016-05-03 16:10:36.000000000","message":"Done","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"04c0fdea15509e1c4b224a7490d5485ec2305955","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"class DetachVolume(forms.SelfHandlingForm):"},{"line_number":242,"context_line":"    volume \u003d forms.ChoiceField(label\u003d_(\"Volume ID\"),"},{"line_number":243,"context_line":"                               help_text\u003d_(\"Select a voume to detach\""},{"line_number":244,"context_line":"                                           \"from this instance.\"))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_a0aa97d0","line":243,"updated":"2016-05-02 23:09:34.000000000","message":"volume","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"300a8426698a97669d5c9e89c9f096d366a586f8","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"class DetachVolume(forms.SelfHandlingForm):"},{"line_number":242,"context_line":"    volume \u003d forms.ChoiceField(label\u003d_(\"Volume ID\"),"},{"line_number":243,"context_line":"                               help_text\u003d_(\"Select a voume to detach\""},{"line_number":244,"context_line":"                                           \"from this instance.\"))"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_8fdccd75","line":243,"in_reply_to":"1a122d0e_a0aa97d0","updated":"2016-05-03 16:10:36.000000000","message":"Done","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1e6883dd98fa3aa83ee21146983d7d0007cb331c","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            messages.info(request, message)"},{"line_number":225,"context_line":"        except Exception:"},{"line_number":226,"context_line":"            redirect \u003d reverse(\u0027horizon:project:instances:index\u0027)"},{"line_number":227,"context_line":"            exceptions.handle(request,"},{"line_number":228,"context_line":"                              _(\u0027Unable to attach volume.\u0027),"},{"line_number":229,"context_line":"                              redirect\u003dredirect)"},{"line_number":230,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_90501b60","line":227,"updated":"2016-05-10 02:52:08.000000000","message":"When an error occur, can we show a more useful message to operators? In this case, user cannot understand why the operation failed.\n\nFor example, if the user try to detach the root device volume, the novaclient return 403 error together with the info of \"{\"message\": \"Can\u0027t detach root device volume\", \"code\": 403}}\"","commit_id":"38db1dc33bae176e3c2899f21f9290216f9254ec"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"0194904ce186476dc6874ed45fb2f0a0b24449c6","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"class AttachVolume(forms.SelfHandlingForm):"},{"line_number":172,"context_line":"    volume \u003d forms.ChoiceField(label\u003d_(\"Volume ID\"),"},{"line_number":173,"context_line":"                               help_text\u003d_(\"Select a volume to attach \""},{"line_number":174,"context_line":"                                           \"to this instance.\"))"},{"line_number":175,"context_line":"    device \u003d forms.CharField(label\u003d_(\"Device Name\"),"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_ca48f9b5","line":172,"updated":"2016-06-14 01:04:26.000000000","message":"should this just be called \u0027Volume\u0027 because it contains the name and id?","commit_id":"afd664a53c6c4530f672f82f544a71e179209efc"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"0194904ce186476dc6874ed45fb2f0a0b24449c6","unresolved":false,"context_lines":[{"line_number":178,"context_line":"                             help_text\u003d_(\"Actual device name may differ due \""},{"line_number":179,"context_line":"                                         \"to hypervisor settings. If not \""},{"line_number":180,"context_line":"                                         \"specified, then hypervisor will \""},{"line_number":181,"context_line":"                                         \"select a device name.\"))"},{"line_number":182,"context_line":"    instance_id \u003d forms.CharField(widget\u003dforms.HiddenInput(),"},{"line_number":183,"context_line":"                                  required\u003dTrue)"},{"line_number":184,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_a53b1ed0","line":181,"updated":"2016-06-14 01:04:26.000000000","message":"we don\u0027t need help text since this isn\u0027t displayed at all\nnit: we don\u0027t need the require\u003dFalse either","commit_id":"afd664a53c6c4530f672f82f544a71e179209efc"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"0194904ce186476dc6874ed45fb2f0a0b24449c6","unresolved":false,"context_lines":[{"line_number":205,"context_line":"        instance_id \u003d self.initial.get(\"instance_id\", None)"},{"line_number":206,"context_line":"        volume_choice \u003d dict(self.fields[\u0027volume\u0027].choices)"},{"line_number":207,"context_line":"        volume_name \u003d volume_choice.get(data[\u0027volume\u0027],"},{"line_number":208,"context_line":"                                        _(\"Unknown volume (None)\"))"},{"line_number":209,"context_line":"        volume_id \u003d volume_name.rsplit(\" (\")[1]"},{"line_number":210,"context_line":"        volume_id \u003d volume_id.rsplit(\")\")[0]"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_c58aaa63","line":208,"updated":"2016-06-14 01:04:26.000000000","message":"better to call it \u0027volume\u0027 for less confusion","commit_id":"afd664a53c6c4530f672f82f544a71e179209efc"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"0194904ce186476dc6874ed45fb2f0a0b24449c6","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        volume_choice \u003d dict(self.fields[\u0027volume\u0027].choices)"},{"line_number":207,"context_line":"        volume_name \u003d volume_choice.get(data[\u0027volume\u0027],"},{"line_number":208,"context_line":"                                        _(\"Unknown volume (None)\"))"},{"line_number":209,"context_line":"        volume_id \u003d volume_name.rsplit(\" (\")[1]"},{"line_number":210,"context_line":"        volume_id \u003d volume_id.rsplit(\")\")[0]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        device \u003d data.get(\u0027device\u0027) or None"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_25ea8e0f","line":209,"updated":"2016-06-14 01:04:26.000000000","message":"ditto","commit_id":"afd664a53c6c4530f672f82f544a71e179209efc"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"0194904ce186476dc6874ed45fb2f0a0b24449c6","unresolved":false,"context_lines":[{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def handle(self, request, data):"},{"line_number":266,"context_line":"        instance_id \u003d self.initial.get(\"instance_id\", None)"},{"line_number":267,"context_line":"        volume_choice \u003d dict(self.fields[\u0027volume\u0027].choices)"},{"line_number":268,"context_line":"        volume_name \u003d volume_choice.get(data[\u0027volume\u0027],"},{"line_number":269,"context_line":"                                        _(\"Unknown volume (None)\"))"},{"line_number":270,"context_line":"        volume_id \u003d volume_name.rsplit(\" (\")[1]"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_c54f4a32","line":267,"updated":"2016-06-14 01:04:26.000000000","message":"volume_choices*","commit_id":"afd664a53c6c4530f672f82f544a71e179209efc"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"0194904ce186476dc6874ed45fb2f0a0b24449c6","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        volume_name \u003d volume_choice.get(data[\u0027volume\u0027],"},{"line_number":269,"context_line":"                                        _(\"Unknown volume (None)\"))"},{"line_number":270,"context_line":"        volume_id \u003d volume_name.rsplit(\" (\")[1]"},{"line_number":271,"context_line":"        volume_id \u003d volume_id.rsplit(\")\")[0]"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        try:"},{"line_number":274,"context_line":"            api.nova.instance_volume_detach(request,"}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_8549c233","line":271,"updated":"2016-06-14 01:04:26.000000000","message":"same","commit_id":"afd664a53c6c4530f672f82f544a71e179209efc"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"94f88377997b2813cde1688a9a5f11490adaad50","unresolved":false,"context_lines":[{"line_number":206,"context_line":"        volume_choices \u003d dict(self.fields[\u0027volume\u0027].choices)"},{"line_number":207,"context_line":"        volume \u003d volume_choices.get(data[\u0027volume\u0027],"},{"line_number":208,"context_line":"                                    _(\"Unknown volume (None)\"))"},{"line_number":209,"context_line":"        volume_id \u003d volume.rsplit(\" (\")[1]"},{"line_number":210,"context_line":"        volume_id \u003d volume_id.rsplit(\")\")[0]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        device \u003d data.get(\u0027device\u0027) or None"}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_9beefe1f","line":209,"updated":"2016-06-27 11:27:07.000000000","message":"yikes!\n\nIm not sure why you are doing this. On __init__ you should construct the volumes list setting the volume.id as the value for the select:\n\nline 194:\nvolumes.append((volume.id, \u0027%(name)s (%(id)s)\u0027 % {\"name\": volume.name, \"id\": volume.id}))\n\n\nThen in here you only need to check the data.get(\u0027volume\u0027) and you would get the volume id directly instead of doing split ops on strings :)","commit_id":"5e4af7c1bccb5aa8651655df6efc419190b2e013"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"94f88377997b2813cde1688a9a5f11490adaad50","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        volume_choices \u003d dict(self.fields[\u0027volume\u0027].choices)"},{"line_number":268,"context_line":"        volume \u003d volume_choices.get(data[\u0027volume\u0027],"},{"line_number":269,"context_line":"                                    _(\"Unknown volume (None)\"))"},{"line_number":270,"context_line":"        volume_id \u003d volume.rsplit(\" (\")[1]"},{"line_number":271,"context_line":"        volume_id \u003d volume_id.rsplit(\")\")[0]"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":17,"id":"3aaa91ec_1bdb2e7d","line":270,"updated":"2016-06-27 11:27:07.000000000","message":"same as up there.","commit_id":"5e4af7c1bccb5aa8651655df6efc419190b2e013"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"ccf1ec5023955f753841398af784a68cb65aaccc","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            volume_list \u003d api.nova.instance_volumes_list(self.request,"},{"line_number":248,"context_line":"                                                         instance_id)"},{"line_number":249,"context_line":"            for volume in volume_list:"},{"line_number":250,"context_line":"                volumes.append((volume.name, \u0027%s (%s)\u0027 % (volume.name,"},{"line_number":251,"context_line":"                                                          volume.id)))"},{"line_number":252,"context_line":"            if volume_list:"},{"line_number":253,"context_line":"                volumes.insert(0, (\"\", _(\"Select a volume\")))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_7caf9a7d","line":250,"updated":"2016-06-28 05:57:31.000000000","message":"This is \"volume.id\"","commit_id":"6ae9c67356464c9858e29a886feee2b2767e33b9"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"50d7128fd9b91b56f697fdfa34008a492b98abf0","unresolved":false,"context_lines":[{"line_number":247,"context_line":"            volume_list \u003d api.nova.instance_volumes_list(self.request,"},{"line_number":248,"context_line":"                                                         instance_id)"},{"line_number":249,"context_line":"            for volume in volume_list:"},{"line_number":250,"context_line":"                volumes.append((volume.name, \u0027%s (%s)\u0027 % (volume.name,"},{"line_number":251,"context_line":"                                                          volume.id)))"},{"line_number":252,"context_line":"            if volume_list:"},{"line_number":253,"context_line":"                volumes.insert(0, (\"\", _(\"Select a volume\")))"}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_9fd17cfe","line":250,"in_reply_to":"3aaa91ec_7caf9a7d","updated":"2016-06-28 14:41:10.000000000","message":"Done. \n\nThank you. You are right. I think it worked locally because when I created the Volumes for manual testing the default is that the volume.name becomes the id unless specified. So it worked. Good catch. Thank you Kenji","commit_id":"6ae9c67356464c9858e29a886feee2b2767e33b9"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"4db8f4e990183d450f4d1dcb1572cdcd58453e6f","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        volume_id \u003d data.get(\u0027volume\u0027)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        try:"},{"line_number":271,"context_line":"            api.nova.instance_volume_detach(request,"},{"line_number":272,"context_line":"                                            instance_id,"},{"line_number":273,"context_line":"                                            volume_id)"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3aaa91ec_1a93fe50","line":271,"updated":"2016-06-28 02:04:11.000000000","message":"Is it not volume_id but attachment_id ?","commit_id":"6ae9c67356464c9858e29a886feee2b2767e33b9"}],"openstack_dashboard/dashboards/project/instances/tables.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"3e264effddfdf359ee5021f559ba2334990fec6f","unresolved":false,"context_lines":[{"line_number":462,"context_line":"    verbose_name \u003d _(\"Manage Attachments\")"},{"line_number":463,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":464,"context_line":"    icon \u003d \"pencil\""},{"line_number":465,"context_line":"    url \u003d \"horizon:project:instances:attach_volume\""},{"line_number":466,"context_line":"    policy_rules \u003d ((\"compute\", \"volume\"),)"},{"line_number":467,"context_line":""},{"line_number":468,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_0e50885c","line":465,"updated":"2016-04-13 21:26:03.000000000","message":"perhaps this should not be instances - but be a volume url ?","commit_id":"20e6f6abfa372ab7e0bde5d37f501944bbd28de5"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"04c0fdea15509e1c4b224a7490d5485ec2305955","unresolved":false,"context_lines":[{"line_number":925,"context_line":"    verbose_name \u003d _(\"Attach Volume\")"},{"line_number":926,"context_line":"    url \u003d \"horizon:project:instances:attach_volume\""},{"line_number":927,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":928,"context_line":"    icon \u003d \"camera\""},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    # This action should be disabled if the instance"},{"line_number":931,"context_line":"    # is not active, or the instance is being deleted"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_6c2fdba7","line":928,"updated":"2016-05-02 23:09:34.000000000","message":"icon doesn\u0027t seem right","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"300a8426698a97669d5c9e89c9f096d366a586f8","unresolved":false,"context_lines":[{"line_number":925,"context_line":"    verbose_name \u003d _(\"Attach Volume\")"},{"line_number":926,"context_line":"    url \u003d \"horizon:project:instances:attach_volume\""},{"line_number":927,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":928,"context_line":"    icon \u003d \"camera\""},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    # This action should be disabled if the instance"},{"line_number":931,"context_line":"    # is not active, or the instance is being deleted"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_cfbd2504","line":928,"in_reply_to":"1a122d0e_6c2fdba7","updated":"2016-05-03 16:10:36.000000000","message":"Done","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"04c0fdea15509e1c4b224a7490d5485ec2305955","unresolved":false,"context_lines":[{"line_number":939,"context_line":"    verbose_name \u003d _(\"Detach Volume\")"},{"line_number":940,"context_line":"    url \u003d \"horizon:project:instances:detach_volume\""},{"line_number":941,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":942,"context_line":"    icon \u003d \"camera\""},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    # This action should be disabled if the instance"},{"line_number":945,"context_line":"    # is not active, or the instance is being deleted"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_4c349ffa","line":942,"updated":"2016-05-02 23:09:34.000000000","message":"icon doesn\u0027t seem right","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"300a8426698a97669d5c9e89c9f096d366a586f8","unresolved":false,"context_lines":[{"line_number":939,"context_line":"    verbose_name \u003d _(\"Detach Volume\")"},{"line_number":940,"context_line":"    url \u003d \"horizon:project:instances:detach_volume\""},{"line_number":941,"context_line":"    classes \u003d (\"ajax-modal\",)"},{"line_number":942,"context_line":"    icon \u003d \"camera\""},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    # This action should be disabled if the instance"},{"line_number":945,"context_line":"    # is not active, or the instance is being deleted"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_afb8a912","line":942,"in_reply_to":"1a122d0e_4c349ffa","updated":"2016-05-03 16:10:36.000000000","message":"Done","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1e6883dd98fa3aa83ee21146983d7d0007cb331c","unresolved":false,"context_lines":[{"line_number":933,"context_line":"            and not is_deleting(instance)"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"class DetachVolume(policy.PolicyTargetMixin, tables.LinkAction):"},{"line_number":937,"context_line":"    name \u003d \"detach_volume\""},{"line_number":938,"context_line":"    verbose_name \u003d _(\"Detach Volume\")"},{"line_number":939,"context_line":"    url \u003d \"horizon:project:instances:detach_volume\""}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_90d93b86","line":936,"updated":"2016-05-10 02:52:08.000000000","message":"Do we need the policy.PolicyTargetMixin ?","commit_id":"38db1dc33bae176e3c2899f21f9290216f9254ec"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1e6883dd98fa3aa83ee21146983d7d0007cb331c","unresolved":false,"context_lines":[{"line_number":934,"context_line":""},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"class DetachVolume(policy.PolicyTargetMixin, tables.LinkAction):"},{"line_number":937,"context_line":"    name \u003d \"detach_volume\""},{"line_number":938,"context_line":"    verbose_name \u003d _(\"Detach Volume\")"},{"line_number":939,"context_line":"    url \u003d \"horizon:project:instances:detach_volume\""},{"line_number":940,"context_line":"    classes \u003d (\"ajax-modal\",)"}],"source_content_type":"text/x-python","patch_set":12,"id":"dab17558_b0739f7f","line":937,"updated":"2016-05-10 02:52:08.000000000","message":"If differences are only name and url, how about below?\n\nclass DetachVolume(AttachVolume):\n    name \u003d \"detach_volume\"\n    verbose_name \u003d _(\"Detach Volume\")\n    url \u003d \"horizon:project:instances:detach_volume\"","commit_id":"38db1dc33bae176e3c2899f21f9290216f9254ec"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"27274bcda7ddbe9608b7bf2ae33f5a8bdd6412a0","unresolved":false,"context_lines":[{"line_number":920,"context_line":"        api.nova.server_unlock(request, obj_id)"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"class AttachVolume(tables.LinkAction):"},{"line_number":924,"context_line":"    name \u003d \"attach_volume\""},{"line_number":925,"context_line":"    verbose_name \u003d _(\"Attach Volume\")"},{"line_number":926,"context_line":"    url \u003d \"horizon:project:instances:attach_volume\""}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_42ed978d","line":923,"updated":"2016-05-24 14:06:34.000000000","message":"Looks like we\u0027re missing policy on this action. See https://github.com/openstack/nova/blob/master/etc/nova/policy.json#L47","commit_id":"9c15f1905224690cfb9d7819659fb0e4caaf5312"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"27274bcda7ddbe9608b7bf2ae33f5a8bdd6412a0","unresolved":false,"context_lines":[{"line_number":933,"context_line":"            and not is_deleting(instance)"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":""},{"line_number":936,"context_line":"class DetachVolume(AttachVolume):"},{"line_number":937,"context_line":"    name \u003d \"detach_volume\""},{"line_number":938,"context_line":"    verbose_name \u003d _(\"Detach Volume\")"},{"line_number":939,"context_line":"    url \u003d \"horizon:project:instances:detach_volume\""}],"source_content_type":"text/x-python","patch_set":14,"id":"bab6814e_62ec1b90","line":936,"updated":"2016-05-24 14:06:34.000000000","message":"ditto","commit_id":"9c15f1905224690cfb9d7819659fb0e4caaf5312"}],"openstack_dashboard/dashboards/project/instances/templates/instances/_attach_volume.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"04c0fdea15509e1c4b224a7490d5485ec2305955","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block modal-body-right %}"},{"line_number":5,"context_line":"        \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":6,"context_line":"        \u003cp\u003e{% trans \"Attach Volume to Running Instance.\" %}\u003c/p\u003e"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":10,"id":"1a122d0e_807afb75","line":6,"updated":"2016-05-02 23:09:34.000000000","message":"nit: too much indent","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"300a8426698a97669d5c9e89c9f096d366a586f8","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block modal-body-right %}"},{"line_number":5,"context_line":"        \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":6,"context_line":"        \u003cp\u003e{% trans \"Attach Volume to Running Instance.\" %}\u003c/p\u003e"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":10,"id":"1a122d0e_0f36fdb3","line":6,"in_reply_to":"1a122d0e_807afb75","updated":"2016-05-03 16:10:36.000000000","message":"Done","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"}],"openstack_dashboard/dashboards/project/instances/templates/instances/_detach_volume.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"04c0fdea15509e1c4b224a7490d5485ec2305955","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block modal-body-right %}"},{"line_number":5,"context_line":"        \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":6,"context_line":"        \u003cp\u003e{% trans \"Detach Volume from Running Instance.\" %}\u003c/p\u003e"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":10,"id":"1a122d0e_40e74346","line":6,"updated":"2016-05-02 23:09:34.000000000","message":"too much indent","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"300a8426698a97669d5c9e89c9f096d366a586f8","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"{% block modal-body-right %}"},{"line_number":5,"context_line":"        \u003ch3\u003e{% trans \"Description:\" %}\u003c/h3\u003e"},{"line_number":6,"context_line":"        \u003cp\u003e{% trans \"Detach Volume from Running Instance.\" %}\u003c/p\u003e"},{"line_number":7,"context_line":"{% endblock %}"}],"source_content_type":"text/html","patch_set":10,"id":"1a122d0e_ef38e1a1","line":6,"in_reply_to":"1a122d0e_40e74346","updated":"2016-05-03 16:10:36.000000000","message":"Done","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"}],"openstack_dashboard/dashboards/project/instances/templates/instances/detach_volume.html":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"1e6883dd98fa3aa83ee21146983d7d0007cb331c","unresolved":false,"context_lines":[{"line_number":3,"context_line":"{% block title %}{% trans \"Manage Volume\" %}{% endblock %}"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"{% block page_header %}"},{"line_number":6,"context_line":"      {% include \"horizon/common/_page_header.html\" with title\u003d_(\"Detach a Volume\") %}"},{"line_number":7,"context_line":"{% endblock page_header %}"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"{% block main %}"}],"source_content_type":"text/html","patch_set":12,"id":"dab17558_b5b1d191","line":6,"updated":"2016-05-10 02:52:08.000000000","message":"Indentation is different at L10.","commit_id":"38db1dc33bae176e3c2899f21f9290216f9254ec"}],"openstack_dashboard/dashboards/project/instances/views.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"db8a64535bd79ef7f0ab3df406ba75503ddd3415","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        context[\u0027submit_url\u0027] \u003d reverse(self.submit_url, args\u003dargs)"},{"line_number":500,"context_line":"        return context"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def post(self, request, *args, **kwargs):"},{"line_number":503,"context_line":"        form \u003d self.get_form()"},{"line_number":504,"context_line":"        if form.is_valid():"},{"line_number":505,"context_line":"            return self.form_valid(form)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_e275c1fa","line":502,"range":{"start_line":502,"start_character":30,"end_line":502,"end_character":31},"updated":"2016-05-02 13:42:00.000000000","message":"why is this method needed?  it seems like these are pretty basic forms, and you don\u0027t need to override post().   If you have a valid reason why, just add some comments here please.  (most forms don\u0027t do this)","commit_id":"13469e64e6bd7c003690918f9241658bca81e6f6"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"db8a64535bd79ef7f0ab3df406ba75503ddd3415","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        context[\u0027submit_url\u0027] \u003d reverse(self.submit_url, args\u003dargs)"},{"line_number":536,"context_line":"        return context"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    def post(self, request, *args, **kwargs):"},{"line_number":539,"context_line":"        form \u003d self.get_form()"},{"line_number":540,"context_line":"        if form.is_valid():"},{"line_number":541,"context_line":"            return self.form_valid(form)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a122d0e_c2724511","line":538,"updated":"2016-05-02 13:42:00.000000000","message":"same comment as above","commit_id":"13469e64e6bd7c003690918f9241658bca81e6f6"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"5290c1c048d25335571dbd6cc5cd256946c93c87","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        context[\u0027submit_url\u0027] \u003d reverse(self.submit_url, args\u003dargs)"},{"line_number":500,"context_line":"        return context"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def post(self, request, *args, **kwargs):"},{"line_number":503,"context_line":"        form \u003d self.get_form()"},{"line_number":504,"context_line":"        if form.is_valid():"},{"line_number":505,"context_line":"            return self.form_valid(form)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_21ccb2ba","line":502,"updated":"2016-05-03 15:26:48.000000000","message":"see comment below","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"5290c1c048d25335571dbd6cc5cd256946c93c87","unresolved":false,"context_lines":[{"line_number":535,"context_line":"        context[\u0027submit_url\u0027] \u003d reverse(self.submit_url, args\u003dargs)"},{"line_number":536,"context_line":"        return context"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"    def post(self, request, *args, **kwargs):"},{"line_number":539,"context_line":"        form \u003d self.get_form()"},{"line_number":540,"context_line":"        if form.is_valid():"},{"line_number":541,"context_line":"            return self.form_valid(form)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_61d7ca4f","line":538,"updated":"2016-05-03 15:26:48.000000000","message":"overriding the post method is gross, this is hiding some other issue imo","commit_id":"613f2d0ad489f98e1e44cef67ccfce604b8c4965"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"0194904ce186476dc6874ed45fb2f0a0b24449c6","unresolved":false,"context_lines":[{"line_number":471,"context_line":"            return api.nova.server_get(self.request,"},{"line_number":472,"context_line":"                                       self.kwargs[\"instance_id\"])"},{"line_number":473,"context_line":"        except Exception:"},{"line_number":474,"context_line":"            self._object \u003d None"},{"line_number":475,"context_line":"            exceptions.handle(self.request,"},{"line_number":476,"context_line":"                              _(\"Unable to retrieve instance.\"))"},{"line_number":477,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"7aa08908_8a8711b4","line":474,"updated":"2016-06-14 01:04:26.000000000","message":"is this needed?","commit_id":"afd664a53c6c4530f672f82f544a71e179209efc"}]}
