)]}'
{"openstack_dashboard/dashboards/identity/users/tables.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f1c8d9d4d44e7e84d70dc35b8a5aa36f887234da","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                           (\"target.user.domain_id\", \"domain_id\"))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def allowed(self, request, user\u003dNone):"},{"line_number":111,"context_line":"        if not api.keystone.keystone_can_edit_user() or \\"},{"line_number":112,"context_line":"                user.id \u003d\u003d request.user.id:"},{"line_number":113,"context_line":"            return False"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_02a770aa","line":111,"updated":"2016-04-15 02:46:41.000000000","message":"It is better not to use a slash. Instead of this, you can use brackets.\n\n        if (not api.keystone.keystone_can_edit_user() or\n                user.id \u003d\u003d request.user.id):","commit_id":"dee572fa99d7508a89c681e8e9d41521cc8f5046"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"0b686a9d2b0a23e91eea0125fa286833c26b9f93","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                           (\"target.user.domain_id\", \"domain_id\"))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def allowed(self, request, user\u003dNone):"},{"line_number":111,"context_line":"        if not api.keystone.keystone_can_edit_user() or \\"},{"line_number":112,"context_line":"                user.id \u003d\u003d request.user.id:"},{"line_number":113,"context_line":"            return False"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_992f763e","line":111,"in_reply_to":"5a18252c_0229309e","updated":"2016-04-15 04:20:24.000000000","message":"Yes but previously, another developer in horizon said to me so.\nI think it is enough to address only codes added on this patch, and other places (like lines 160) are out of scope on this patch. Thank you for reply!","commit_id":"dee572fa99d7508a89c681e8e9d41521cc8f5046"},{"author":{"_account_id":20454,"name":"Ryan Evans","email":"rmevans88@gmail.com","username":"rmevans"},"change_message_id":"2026c789e93dc3b91e4c290f3f658522928e4a3c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                           (\"target.user.domain_id\", \"domain_id\"))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def allowed(self, request, user\u003dNone):"},{"line_number":111,"context_line":"        if not api.keystone.keystone_can_edit_user() or \\"},{"line_number":112,"context_line":"                user.id \u003d\u003d request.user.id:"},{"line_number":113,"context_line":"            return False"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_0229309e","line":111,"in_reply_to":"5a18252c_02a770aa","updated":"2016-04-15 03:10:18.000000000","message":"The slash was being used in other places in this file (lines 160 and 188), so I was just following that convention. Do you still think I should use the parenthesis here? Or get rid of those slashes as well?","commit_id":"dee572fa99d7508a89c681e8e9d41521cc8f5046"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f1c8d9d4d44e7e84d70dc35b8a5aa36f887234da","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            self.current_present_action \u003d ENABLE"},{"line_number":123,"context_line":"        return True"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def update(self, request, user\u003dNone):"},{"line_number":126,"context_line":"        super(ToggleEnabled, self).update(request, user)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def action(self, request, obj_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a18252c_22a8ac76","line":125,"updated":"2016-04-15 02:46:41.000000000","message":"It seems that this method no longer need.","commit_id":"dee572fa99d7508a89c681e8e9d41521cc8f5046"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1207608d2beac97f8eaa9c905c7b1d0166038b0d","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        return True"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def action(self, request, obj_id):"},{"line_number":126,"context_line":"        if obj_id \u003d\u003d request.user.id:"},{"line_number":127,"context_line":"            messages.info(request, _(\u0027You cannot disable the user you are \u0027"},{"line_number":128,"context_line":"                                     \u0027currently logged in as.\u0027))"},{"line_number":129,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_6b30209f","line":126,"updated":"2016-04-18 22:36:52.000000000","message":"this check is not really necessary any longer either. Since we\u0027re not showing the action for the current user and there is no table action for toggling enabled","commit_id":"aeca2ec036ce9700ec9129d607014ad5a2b6ba32"}]}