)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f53d6d8400f9b7817a1e5d3966e6ba5089d88199","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to assist admins in locating where a router resides."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I62bedcc587791df3a101b9d81a03ba2540dfa033"},{"line_number":13,"context_line":"Partially implements: blueprint admin-neutron-l3-agents"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bab6814e_97184677","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"updated":"2016-05-24 21:58:20.000000000","message":"Is there any pending patch other than this?","commit_id":"a6ac72bbbadc68688b0b84d3158d94d88663039f"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"a894be40b5ed4e9d337a63ee8fba59e1b3a22d32","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to assist admins in locating where a router resides."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I62bedcc587791df3a101b9d81a03ba2540dfa033"},{"line_number":13,"context_line":"Partially implements: blueprint admin-neutron-l3-agents"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"bab6814e_caa3199d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"in_reply_to":"bab6814e_97184677","updated":"2016-05-25 15:31:49.000000000","message":"There is no more pending patch - it has been merged","commit_id":"a6ac72bbbadc68688b0b84d3158d94d88663039f"}],"openstack_dashboard/dashboards/admin/routers/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"47ad41f65c7a0f6fc03f84658e9a130915cdeafd","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.assertMessageCount(response\u003dres, success\u003d1)"},{"line_number":192,"context_line":"        self.assertIn(\u0027Deleted Router: \u0027 + router.name,"},{"line_number":193,"context_line":"                      res.content.decode(\u0027utf-8\u0027))"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _get_detail(self, router, extraroute\u003dTrue):"},{"line_number":196,"context_line":"        res \u003d super(RouterTests, self)._get_detail(router, extraroute,"},{"line_number":197,"context_line":"                                                   lookup_l3\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_c8570525","line":194,"updated":"2016-05-24 06:30:09.000000000","message":"I think it is better to be placed at the beginning of the class.","commit_id":"d2e85e1e346163da29c0a1fe46d4e2b1cda2ff3a"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"99a88f4a3f32d78ae12bf38b9a7f6c13571093d4","unresolved":false,"context_lines":[{"line_number":191,"context_line":"        self.assertMessageCount(response\u003dres, success\u003d1)"},{"line_number":192,"context_line":"        self.assertIn(\u0027Deleted Router: \u0027 + router.name,"},{"line_number":193,"context_line":"                      res.content.decode(\u0027utf-8\u0027))"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    def _get_detail(self, router, extraroute\u003dTrue):"},{"line_number":196,"context_line":"        res \u003d super(RouterTests, self)._get_detail(router, extraroute,"},{"line_number":197,"context_line":"                                                   lookup_l3\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_8e8b1768","line":194,"in_reply_to":"bab6814e_c8570525","updated":"2016-05-24 20:35:56.000000000","message":"Done","commit_id":"d2e85e1e346163da29c0a1fe46d4e2b1cda2ff3a"}],"openstack_dashboard/dashboards/admin/routers/views.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9c809441f1c393551e90c34d2cdf1e01fea3951","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                                              router.id)"},{"line_number":75,"context_line":"            router.l3_host_agents \u003d agents"},{"line_number":76,"context_line":"        except Exception:"},{"line_number":77,"context_line":"            pass"},{"line_number":78,"context_line":"        context[\"actions\"] \u003d table.render_row_actions(router)"},{"line_number":79,"context_line":"        return context"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_a7d4401f","line":77,"updated":"2016-05-04 02:07:46.000000000","message":"I think it is better to show some error message.. By doing so, admin can know whether the router is not hosted or some error occurs when retrieving information.","commit_id":"c444043b314c55a39d603a0a6aff048c8eb3adc8"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"332b8935d6d80c53e1396b71928cc70f2ad637b3","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        router \u003d context[\"router\"]"},{"line_number":75,"context_line":"        # try to lookup the l3 agent location so we know where to troubleshoot"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            agents \u003d api.neutron.list_l3_agent_hosting_router(self.request,"},{"line_number":78,"context_line":"                                                              router.id)"},{"line_number":79,"context_line":"            router.l3_host_agents \u003d agents"},{"line_number":80,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9abb7d3a_15282b32","line":77,"updated":"2016-06-01 20:46:48.000000000","message":"why not just assign directly to router.l3_host_agents?","commit_id":"0ee88956cc1fcf0e004e74ab601939de27a49ce4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cbf93733b3b4662c3a02e1b0c8fbf52ac8cc1025","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        router \u003d context[\"router\"]"},{"line_number":75,"context_line":"        # try to lookup the l3 agent location so we know where to troubleshoot"},{"line_number":76,"context_line":"        try:"},{"line_number":77,"context_line":"            agents \u003d api.neutron.list_l3_agent_hosting_router(self.request,"},{"line_number":78,"context_line":"                                                              router.id)"},{"line_number":79,"context_line":"            router.l3_host_agents \u003d agents"},{"line_number":80,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9abb7d3a_266f07fd","line":77,"in_reply_to":"9abb7d3a_15282b32","updated":"2016-06-01 22:00:24.000000000","message":"I think it is due to the line length. we can fix in a later patch.","commit_id":"0ee88956cc1fcf0e004e74ab601939de27a49ce4"}],"openstack_dashboard/dashboards/project/routers/tabs.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"332b8935d6d80c53e1396b71928cc70f2ad637b3","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def get_context_data(self, request):"},{"line_number":33,"context_line":"        return {\"router\": self.tab_group.kwargs[\u0027router\u0027],"},{"line_number":34,"context_line":"                \u0027ha_supported\u0027: api.neutron."},{"line_number":35,"context_line":"                get_feature_permission(self.request, \"l3-ha\", \"get\")"},{"line_number":36,"context_line":"                }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9abb7d3a_75a6d7ae","line":35,"range":{"start_line":35,"start_character":39,"end_line":35,"end_character":43},"updated":"2016-06-01 20:46:48.000000000","message":"self. is not necessary since \"request\" is already passed","commit_id":"0ee88956cc1fcf0e004e74ab601939de27a49ce4"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"cbf93733b3b4662c3a02e1b0c8fbf52ac8cc1025","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def get_context_data(self, request):"},{"line_number":33,"context_line":"        return {\"router\": self.tab_group.kwargs[\u0027router\u0027],"},{"line_number":34,"context_line":"                \u0027ha_supported\u0027: api.neutron."},{"line_number":35,"context_line":"                get_feature_permission(self.request, \"l3-ha\", \"get\")"},{"line_number":36,"context_line":"                }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9abb7d3a_867a33bb","line":35,"range":{"start_line":35,"start_character":39,"end_line":35,"end_character":43},"in_reply_to":"9abb7d3a_75a6d7ae","updated":"2016-06-01 22:00:24.000000000","message":"Sounds reasonable. Let\u0027s fix in a later patch.","commit_id":"0ee88956cc1fcf0e004e74ab601939de27a49ce4"}],"openstack_dashboard/dashboards/project/routers/templates/routers/_detail_overview.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9c809441f1c393551e90c34d2cdf1e01fea3951","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      \u003cdt\u003e{% trans \"High Availability Mode\" %}\u003c/dt\u003e"},{"line_number":21,"context_line":"      \u003cdd\u003e{{ router.ha|yesno|capfirst }}\u003c/dd\u003e"},{"line_number":22,"context_line":"    {% endif %}"},{"line_number":23,"context_line":"    {% if router.l3_host_agents %}"},{"line_number":24,"context_line":"      \u003cdt\u003e{% trans \"L3 Agent\" %}\u003c/dt\u003e"},{"line_number":25,"context_line":"      \u003cdd\u003e"},{"line_number":26,"context_line":"        \u003ctable class\u003d\"table table-striped table-hover\"\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"1a122d0e_e7275861","line":23,"updated":"2016-05-04 02:07:46.000000000","message":"Currently if a router is not hosted yet, there is no information displayed.\nI think it is better to show information that the router is not hosted. Thought?","commit_id":"c444043b314c55a39d603a0a6aff048c8eb3adc8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9c809441f1c393551e90c34d2cdf1e01fea3951","unresolved":false,"context_lines":[{"line_number":28,"context_line":"            \u003ctr\u003e"},{"line_number":29,"context_line":"              \u003cth\u003e\u003cstrong\u003e{% trans \"Host\" %}\u003c/strong\u003e\u003c/th\u003e"},{"line_number":30,"context_line":"              \u003cth\u003e\u003cstrong\u003e{% trans \"ID\" %}\u003c/strong\u003e\u003c/th\u003e"},{"line_number":31,"context_line":"              \u003cth\u003e\u003cstrong\u003e{% trans \"HA Status\" %}\u003c/strong\u003e\u003c/th\u003e"},{"line_number":32,"context_line":"            \u003c/tr\u003e"},{"line_number":33,"context_line":"          \u003c/thead\u003e"},{"line_number":34,"context_line":"          \u003ctbody\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"1a122d0e_6ab7b6f5","line":31,"updated":"2016-05-04 02:07:46.000000000","message":"ha_state should be visible only when ha_supported is True.\n\nLooking at L.20, \"High Availability Status\" might be better.","commit_id":"c444043b314c55a39d603a0a6aff048c8eb3adc8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e9c809441f1c393551e90c34d2cdf1e01fea3951","unresolved":false,"context_lines":[{"line_number":36,"context_line":"             \u003ctr\u003e"},{"line_number":37,"context_line":"              \u003ctd\u003e{{ agent.host }}\u003c/td\u003e"},{"line_number":38,"context_line":"              \u003ctd\u003e{{ agent.id }}\u003c/td\u003e"},{"line_number":39,"context_line":"              \u003ctd\u003e{{ agent.ha_state|default:_(\"None\") }}\u003c/td\u003e"},{"line_number":40,"context_line":"            \u003c/tr\u003e"},{"line_number":41,"context_line":"        {% endfor %}"},{"line_number":42,"context_line":"          \u003c/tbody\u003e"}],"source_content_type":"text/html","patch_set":7,"id":"1a122d0e_67fd08b1","line":39,"updated":"2016-05-04 02:07:46.000000000","message":"same comment as for L.31.","commit_id":"c444043b314c55a39d603a0a6aff048c8eb3adc8"}],"openstack_dashboard/dashboards/project/routers/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"47ad41f65c7a0f6fc03f84658e9a130915cdeafd","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if lookup_l3:"},{"line_number":46,"context_line":"            agent \u003d self.agents.list()[1]"},{"line_number":47,"context_line":"            api.neutron.list_l3_agent_hosting_router(IsA(http.HttpRequest), router.id)\\"},{"line_number":48,"context_line":"                .AndReturn([agent, ])"},{"line_number":49,"context_line":"        self.mox.ReplayAll()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        res \u003d self.client.get(reverse(\u0027horizon:%s\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_88017d3c","line":48,"range":{"start_line":48,"start_character":27,"end_line":48,"end_character":36},"updated":"2016-05-24 06:30:09.000000000","message":"A comma is unnecessary.\n\n [agent]","commit_id":"d2e85e1e346163da29c0a1fe46d4e2b1cda2ff3a"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"99a88f4a3f32d78ae12bf38b9a7f6c13571093d4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        if lookup_l3:"},{"line_number":46,"context_line":"            agent \u003d self.agents.list()[1]"},{"line_number":47,"context_line":"            api.neutron.list_l3_agent_hosting_router(IsA(http.HttpRequest), router.id)\\"},{"line_number":48,"context_line":"                .AndReturn([agent, ])"},{"line_number":49,"context_line":"        self.mox.ReplayAll()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        res \u003d self.client.get(reverse(\u0027horizon:%s\u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"bab6814e_eee8e318","line":48,"range":{"start_line":48,"start_character":27,"end_line":48,"end_character":36},"in_reply_to":"bab6814e_88017d3c","updated":"2016-05-24 20:35:56.000000000","message":"Done","commit_id":"d2e85e1e346163da29c0a1fe46d4e2b1cda2ff3a"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"e44487f4ddd6e49a91a20004f8e937aea7ef4d10","unresolved":false,"context_lines":[{"line_number":39,"context_line":"if ROOT_PATH not in sys.path:"},{"line_number":40,"context_line":"    sys.path.append(ROOT_PATH)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"DEBUG \u003d True"},{"line_number":43,"context_line":"TEMPLATE_DEBUG \u003d DEBUG"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"SITE_BRANDING \u003d \u0027OpenStack Dashboard\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_533ba5eb","line":42,"updated":"2016-04-15 20:48:11.000000000","message":"let\u0027s not commit the changes in this file.","commit_id":"3b52c02421b10c42cc5e970ff62434364eb1c093"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"6b37f8a22023d9af4f9a4d39a0a0dcde19a6abcc","unresolved":false,"context_lines":[{"line_number":141,"context_line":"    \u0027compressor.filters.css_default.CssAbsoluteFilter\u0027,"},{"line_number":142,"context_line":")"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"COMPRESS_ENABLED \u003d False"},{"line_number":145,"context_line":"COMPRESS_OUTPUT_DIR \u003d \u0027dashboard\u0027"},{"line_number":146,"context_line":"COMPRESS_CSS_HASHING_METHOD \u003d \u0027hash\u0027"},{"line_number":147,"context_line":"COMPRESS_PARSER \u003d \u0027compressor.parser.HtmlParser\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_c054f355","line":144,"updated":"2016-04-16 11:38:11.000000000","message":"this line ditto","commit_id":"3b52c02421b10c42cc5e970ff62434364eb1c093"}]}
