)]}'
{"horizon/utils/secret_key.py":[{"author":{"_account_id":20316,"name":"Marcellin Fom Tchassem","email":"mf6510@att.com","username":"ciello89"},"change_message_id":"6cc2ee6d2792a9e403d11d2b264baea8a25a90c8","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        key \u003d read_from_file(key_file)"},{"line_number":64,"context_line":"        return key"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # otherwise, first lock to make sure only one process"},{"line_number":67,"context_line":"    lock \u003d lockutils.external_lock(key_file + \".lock\","},{"line_number":68,"context_line":"                                   lock_path\u003dos.path.dirname(abspath))"},{"line_number":69,"context_line":"    with lock:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_65491f31","line":66,"range":{"start_line":66,"start_character":50,"end_line":66,"end_character":57},"updated":"2016-04-27 20:19:11.000000000","message":"processes","commit_id":"66c718c08a93a3bab02868b03e58a8d90b0d6d94"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"7229abb90350232a62fbbe40bac55f351585da43","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                   lock_path\u003dos.path.dirname(abspath))"},{"line_number":69,"context_line":"    with lock:"},{"line_number":70,"context_line":"        if not os.path.exists(key_file):"},{"line_number":71,"context_line":"                key \u003d generate_key(key_length)"},{"line_number":72,"context_line":"                old_umask \u003d os.umask(0o177)  # Use \u00270600\u0027 file permissions"},{"line_number":73,"context_line":"                with open(key_file, \u0027w\u0027) as f:"},{"line_number":74,"context_line":"                    f.write(key)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_cca3854e","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":16},"updated":"2016-04-22 10:25:23.000000000","message":"Is it better to only leave 4 blank spaces for indent?","commit_id":"66c718c08a93a3bab02868b03e58a8d90b0d6d94"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"9d0b981a75e0009b206a0a1cb6a19dec9b642de3","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                   lock_path\u003dos.path.dirname(abspath))"},{"line_number":69,"context_line":"    with lock:"},{"line_number":70,"context_line":"        if not os.path.exists(key_file):"},{"line_number":71,"context_line":"                key \u003d generate_key(key_length)"},{"line_number":72,"context_line":"                old_umask \u003d os.umask(0o177)  # Use \u00270600\u0027 file permissions"},{"line_number":73,"context_line":"                with open(key_file, \u0027w\u0027) as f:"},{"line_number":74,"context_line":"                    f.write(key)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_ef6c730a","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":16},"in_reply_to":"1a122d0e_cca3854e","updated":"2016-04-22 10:46:55.000000000","message":"probably yes. Looks like a copy/past issue for me. I thought I had this solved already.","commit_id":"66c718c08a93a3bab02868b03e58a8d90b0d6d94"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"1649c99bdd82736f700b0974423fb8b11e147c1a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                                   lock_path\u003dos.path.dirname(abspath))"},{"line_number":69,"context_line":"    with lock:"},{"line_number":70,"context_line":"        if not os.path.exists(key_file):"},{"line_number":71,"context_line":"                key \u003d generate_key(key_length)"},{"line_number":72,"context_line":"                old_umask \u003d os.umask(0o177)  # Use \u00270600\u0027 file permissions"},{"line_number":73,"context_line":"                with open(key_file, \u0027w\u0027) as f:"},{"line_number":74,"context_line":"                    f.write(key)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_456b43b9","line":71,"range":{"start_line":71,"start_character":12,"end_line":71,"end_character":16},"in_reply_to":"1a122d0e_ef6c730a","updated":"2016-04-27 20:10:01.000000000","message":"I thought you will change the 8 blank spaces to 4. If it\u0027s OK, sorry for not removed -1.","commit_id":"66c718c08a93a3bab02868b03e58a8d90b0d6d94"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"7229abb90350232a62fbbe40bac55f351585da43","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                with open(key_file, \u0027w\u0027) as f:"},{"line_number":74,"context_line":"                    f.write(key)"},{"line_number":75,"context_line":"                os.umask(old_umask)"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            key \u003d read_from_file(key_file)"},{"line_number":78,"context_line":"        return key"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_8c67cd24","line":76,"updated":"2016-04-22 10:25:23.000000000","message":"It will return if key_file exists so the code will never go here.","commit_id":"66c718c08a93a3bab02868b03e58a8d90b0d6d94"},{"author":{"_account_id":4264,"name":"Matthias Runge","email":"mrunge@redhat.com","username":"mrunge"},"change_message_id":"9d0b981a75e0009b206a0a1cb6a19dec9b642de3","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                with open(key_file, \u0027w\u0027) as f:"},{"line_number":74,"context_line":"                    f.write(key)"},{"line_number":75,"context_line":"                os.umask(old_umask)"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            key \u003d read_from_file(key_file)"},{"line_number":78,"context_line":"        return key"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_cf71b7e2","line":76,"in_reply_to":"1a122d0e_8c67cd24","updated":"2016-04-22 10:46:55.000000000","message":"not so fast: You can have two processes not finding a key file, trying to generate a lock etc...","commit_id":"66c718c08a93a3bab02868b03e58a8d90b0d6d94"},{"author":{"_account_id":8686,"name":"Wang Bo","email":"bo.wang@easystack.cn","username":"wangbo"},"change_message_id":"53c1f97641a28caa767da7b99e29144bc1e1db9b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                with open(key_file, \u0027w\u0027) as f:"},{"line_number":74,"context_line":"                    f.write(key)"},{"line_number":75,"context_line":"                os.umask(old_umask)"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            key \u003d read_from_file(key_file)"},{"line_number":78,"context_line":"        return key"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_f5b047ff","line":76,"in_reply_to":"1a122d0e_cf71b7e2","updated":"2016-04-27 14:38:31.000000000","message":"I think you are right. learned something. thanks!","commit_id":"66c718c08a93a3bab02868b03e58a8d90b0d6d94"}]}
