)]}'
{"openstack_dashboard/test/integration_tests/helpers.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"824567c2af61e10a9fb2c0681d40e3ab92a0d72a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"# under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from StringIO import StringIO"},{"line_number":14,"context_line":"import contextlib"},{"line_number":15,"context_line":"import datetime"},{"line_number":16,"context_line":"import logging"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_45fce371","line":13,"updated":"2016-04-20 10:05:46.000000000","message":"I think the ordering causes pep8 error.","commit_id":"1aaa349250440c43f0208a244121ec4500e1df35"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"824567c2af61e10a9fb2c0681d40e3ab92a0d72a","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    CONFIG \u003d config.get_config()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def setUp(self):"},{"line_number":89,"context_line":"        LOGGER.handlers[:] \u003d []"},{"line_number":90,"context_line":"        stream_handler \u003d logging.StreamHandler(stream\u003dself._log_buffer)"},{"line_number":91,"context_line":"        stream_handler.setLevel(logging.DEBUG)"},{"line_number":92,"context_line":"        formatter \u003d logging.Formatter("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_e566cf4f","line":89,"updated":"2016-04-20 10:05:46.000000000","message":"Could you please move this chunk to a separate helper function (name starting with _) and provide a docstring, explaining that it helps to capture selenium interaction logs?","commit_id":"1aaa349250440c43f0208a244121ec4500e1df35"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"18c480419f6a10aae37151c48a25da21b6ed27b2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"    CONFIG \u003d config.get_config()"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def setUp(self):"},{"line_number":89,"context_line":"        LOGGER.handlers[:] \u003d []"},{"line_number":90,"context_line":"        stream_handler \u003d logging.StreamHandler(stream\u003dself._log_buffer)"},{"line_number":91,"context_line":"        stream_handler.setLevel(logging.DEBUG)"},{"line_number":92,"context_line":"        formatter \u003d logging.Formatter("}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_78dd42df","line":89,"in_reply_to":"1a122d0e_e566cf4f","updated":"2016-04-20 10:12:13.000000000","message":"of course","commit_id":"1aaa349250440c43f0208a244121ec4500e1df35"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"824567c2af61e10a9fb2c0681d40e3ab92a0d72a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    def _attach_screenshot(self, exc_info):"},{"line_number":159,"context_line":"        screen_path \u003d os.path.join(self._test_report_dir,"},{"line_number":160,"context_line":"                                   self._testMethodName + \u0027_screenshot.png\u0027)"},{"line_number":161,"context_line":"        self.driver.get_screenshot_as_file(screen_path)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _attach_browser_log(self, exc_info):"},{"line_number":164,"context_line":"        browser_log_path \u003d os.path.join(self._test_report_dir,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_78438242","line":161,"updated":"2016-04-20 10:05:46.000000000","message":"This needs to be protected against exceptions as well.","commit_id":"1aaa349250440c43f0208a244121ec4500e1df35"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"18c480419f6a10aae37151c48a25da21b6ed27b2","unresolved":false,"context_lines":[{"line_number":158,"context_line":"    def _attach_screenshot(self, exc_info):"},{"line_number":159,"context_line":"        screen_path \u003d os.path.join(self._test_report_dir,"},{"line_number":160,"context_line":"                                   self._testMethodName + \u0027_screenshot.png\u0027)"},{"line_number":161,"context_line":"        self.driver.get_screenshot_as_file(screen_path)"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    def _attach_browser_log(self, exc_info):"},{"line_number":164,"context_line":"        browser_log_path \u003d os.path.join(self._test_report_dir,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_38cf4a2a","line":161,"in_reply_to":"1a122d0e_78438242","updated":"2016-04-20 10:12:13.000000000","message":"yep! my fault","commit_id":"1aaa349250440c43f0208a244121ec4500e1df35"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"824567c2af61e10a9fb2c0681d40e3ab92a0d72a","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            self.driver.quit()"},{"line_number":220,"context_line":"        if hasattr(self, \u0027vdisplay\u0027):"},{"line_number":221,"context_line":"            self.vdisplay.stop()"},{"line_number":222,"context_line":"        self._log_buffer.truncate(0)  # flush buffed log for each test"},{"line_number":223,"context_line":"        super(BaseTestCase, self).tearDown()"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a122d0e_d86456ba","line":222,"range":{"start_line":222,"start_character":46,"end_line":222,"end_character":52},"updated":"2016-04-20 10:05:46.000000000","message":"buffered :)","commit_id":"1aaa349250440c43f0208a244121ec4500e1df35"},{"author":{"_account_id":12281,"name":"Itxaka","email":"igarcia@suse.com","username":"itxaka"},"change_message_id":"674c940543766035ae6a99d674823c053a2688fb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import logging"},{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":"import socket"},{"line_number":17,"context_line":"from StringIO import StringIO"},{"line_number":18,"context_line":"import tempfile"},{"line_number":19,"context_line":"import time"},{"line_number":20,"context_line":"import traceback"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_193debbb","line":17,"updated":"2016-04-21 12:32:52.000000000","message":"I dont think this is compatible with python3, I think it changed to be \"from io import StringIO\" which also works in python2\n\nSo it would be good to change this to use six:\n\nhttps://pythonhosted.org/six/#six.StringIO","commit_id":"54689f9a837e359b53525dd04af8f6edf8320e68"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"db27d2a66de2189dc3c82f1f97a0b44ca39df544","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            self.driver.quit()"},{"line_number":220,"context_line":"        if hasattr(self, \u0027vdisplay\u0027):"},{"line_number":221,"context_line":"            self.vdisplay.stop()"},{"line_number":222,"context_line":"        self._log_buffer.truncate(0)  # flush buffered log for each test"},{"line_number":223,"context_line":"        super(BaseTestCase, self).tearDown()"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1a122d0e_f17c1a22","line":222,"updated":"2016-04-25 11:14:25.000000000","message":"You won\u0027t need this, if you will create StringIO() in _configure_log() (invoked at the beginning of every test, so buffer is going to be clean).","commit_id":"51505216dad7c326ee32dd484fc9ab810935b6d4"}],"tools/gate/integration/post_test_hook.sh":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"824567c2af61e10a9fb2c0681d40e3ab92a0d72a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"retval\u003d$?"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [ -d openstack_dashboard/test/integration_tests/test_reports/ ]; then"},{"line_number":12,"context_line":"  cp -r openstack_dashboard/test/integration_tests/test_reports/ /home/jenkins/workspace/gate-horizon-dsvm-integration/integration_tests_screenshots/"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":"exit $retval"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"1a122d0e_e5d6cf4d","line":12,"range":{"start_line":12,"start_character":137,"end_line":12,"end_character":148},"updated":"2016-04-20 10:05:46.000000000","message":"just screenshots or reports?\n\nAnyways, that change should have a successor - the change to https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/horizon.yaml#L60 \u0027publish-screenshots\u0027 handler and its invocation here https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/horizon.yaml#L58","commit_id":"1aaa349250440c43f0208a244121ec4500e1df35"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"fd8fe61995fd018dc6d41bacaf62d4ac9c68a0e1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"retval\u003d$?"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [ -d openstack_dashboard/test/integration_tests/test_reports/ ]; then"},{"line_number":12,"context_line":"  cp -r openstack_dashboard/test/integration_tests/test_reports/ /home/jenkins/workspace/gate-horizon-dsvm-integration/integration_tests_screenshots/"},{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":"exit $retval"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"1a122d0e_d8bc56bd","line":12,"range":{"start_line":12,"start_character":137,"end_line":12,"end_character":148},"in_reply_to":"1a122d0e_e5d6cf4d","updated":"2016-04-20 10:09:22.000000000","message":"yep, I should send pr to infra to change directory name and support tree structure (not flat as now)","commit_id":"1aaa349250440c43f0208a244121ec4500e1df35"}]}
