)]}'
{"doc/source/topics/settings.rst":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f8b36fd2e71a23eb28361697a59c69504b425a06","unresolved":false,"context_lines":[{"line_number":1500,"context_line":""},{"line_number":1501,"context_line":"It defines the minimum and maximum micro API version supported for a set of"},{"line_number":1502,"context_line":"specific features. The minimum is defined using keyword \"min\", the maximum"},{"line_number":1503,"context_line":"is defined using keyword \"max\"."},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"``POLICY_FILES``"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a71b18c_05d3f904","line":1503,"updated":"2016-12-05 20:05:13.000000000","message":"Also add, \"API version is defined by ``OPENSTACK_API_VERSIONS`` setting\" ?","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aefe228e48a7a62a6dfc4b3ebf9c2e56c8da115f","unresolved":false,"context_lines":[{"line_number":1500,"context_line":""},{"line_number":1501,"context_line":"It defines the minimum and maximum micro API version supported for a set of"},{"line_number":1502,"context_line":"specific features. The minimum is defined using keyword \"min\", the maximum"},{"line_number":1503,"context_line":"is defined using keyword \"max\"."},{"line_number":1504,"context_line":""},{"line_number":1505,"context_line":""},{"line_number":1506,"context_line":"``POLICY_FILES``"}],"source_content_type":"text/x-rst","patch_set":20,"id":"3a71b18c_69971f48","line":1503,"in_reply_to":"3a71b18c_05d3f904","updated":"2016-12-06 02:28:11.000000000","message":"Okay","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"}],"openstack_dashboard/api/microversions.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2a81e1d63771ad5e77ce31d450739d8766141b29","unresolved":false,"context_lines":[{"line_number":28,"context_line":"MICROVERSION_FEATURES \u003d {"},{"line_number":29,"context_line":"    \"nova\": {"},{"line_number":30,"context_line":"        \"locked_attribute\": [\"2.9\", \"2.42\"],"},{"line_number":31,"context_line":"        \"instance_description\": [\"2.19\", \"2.42\"],"},{"line_number":32,"context_line":"    },"},{"line_number":33,"context_line":"    \"cinder\": {"},{"line_number":34,"context_line":"        \"consistency_groups\": [\"2.0\", \"3.10\"],"}],"source_content_type":"text/x-python","patch_set":38,"id":"3f4b6375_01ae4b97","line":31,"range":{"start_line":31,"start_character":42,"end_line":31,"end_character":46},"updated":"2017-10-24 15:25:02.000000000","message":"The current version is 2.53, it is better to use the current version if there is no reason.","commit_id":"92abf8d0291f69a456a009cd2f5b7509e63e8831"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9c011d4799a09b769bf0ae9be222b5f47739fd6f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"MICROVERSION_FEATURES \u003d {"},{"line_number":29,"context_line":"    \"nova\": {"},{"line_number":30,"context_line":"        \"locked_attribute\": [\"2.9\", \"2.42\"],"},{"line_number":31,"context_line":"        \"instance_description\": [\"2.19\", \"2.42\"],"},{"line_number":32,"context_line":"    },"},{"line_number":33,"context_line":"    \"cinder\": {"},{"line_number":34,"context_line":"        \"consistency_groups\": [\"2.0\", \"3.10\"],"}],"source_content_type":"text/x-python","patch_set":38,"id":"3f4b6375_77dffdd5","line":31,"range":{"start_line":31,"start_character":42,"end_line":31,"end_character":46},"in_reply_to":"3f4b6375_01ae4b97","updated":"2017-10-24 16:34:18.000000000","message":"Please ignore my above comment. This is based on my wrong misunderstanding.","commit_id":"92abf8d0291f69a456a009cd2f5b7509e63e8831"}],"openstack_dashboard/api/nova.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7c35c5e44bf45d2318f113c03350e71ae6f37001","unresolved":false,"context_lines":[{"line_number":50,"context_line":"VERSIONS \u003d base.APIVersionManager(\"compute\", preferred_version\u003d2)"},{"line_number":51,"context_line":"VERSIONS.load_supported_version(1.1, {\"client\": nova_client, \"version\": 1.1})"},{"line_number":52,"context_line":"VERSIONS.load_supported_version(2, {\"client\": nova_client, \"version\": 2})"},{"line_number":53,"context_line":"VERSIONS.load_supported_version(2.19, {\"client\": nova_client, \"version\": 2.19})"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# API static values"},{"line_number":56,"context_line":"INSTANCE_ACTIVE_STATE \u003d \u0027ACTIVE\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_7f3ded2b","line":53,"updated":"2016-06-15 12:57:20.000000000","message":"The preferred_version is 2 (L.50), so if OPENSTACK_API_VERSIONS is not specified, version\u003d2 is used.\nIn addition, even if OPENSTACK_API_VERSION contains nova entry, it does work only if nova version is 2.19. If a later version is specified, I think it does not work.\n\nAm I missing something?\nI think we need more efficient way to handle the micro-versioning in Nova.","commit_id":"e7cdf6ef07fd53259916b7f405f7caead2adb490"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"feca9cfd25410b668591635309c962806f26c616","unresolved":false,"context_lines":[{"line_number":50,"context_line":"VERSIONS \u003d base.APIVersionManager(\"compute\", preferred_version\u003d2)"},{"line_number":51,"context_line":"VERSIONS.load_supported_version(1.1, {\"client\": nova_client, \"version\": 1.1})"},{"line_number":52,"context_line":"VERSIONS.load_supported_version(2, {\"client\": nova_client, \"version\": 2})"},{"line_number":53,"context_line":"VERSIONS.load_supported_version(2.19, {\"client\": nova_client, \"version\": 2.19})"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# API static values"},{"line_number":56,"context_line":"INSTANCE_ACTIVE_STATE \u003d \u0027ACTIVE\u0027"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_fd636a3f","line":53,"in_reply_to":"7aa08908_7f3ded2b","updated":"2016-06-21 08:55:08.000000000","message":"Yes, you are right, one can not specify a version is not loaded here. If someone want to use a higher version, he/she must have some requirements to the functionality related to the nova micro version.\n\nAnd seems that horizon doesn\u0027t provide a better way to handle microversion currently. \n\nSo i think it shouldn\u0027t the blocker for this patch for now, there was already a patch merged with microversion 2.9 :( [1].\n\nWe can come back to modify this if we finally find a better way, it will have only a few lines to change anyway:)\n\nWhat do you think?\n\n[1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/api/nova.py#L54","commit_id":"e7cdf6ef07fd53259916b7f405f7caead2adb490"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7c35c5e44bf45d2318f113c03350e71ae6f37001","unresolved":false,"context_lines":[{"line_number":744,"context_line":""},{"line_number":745,"context_line":"def server_update(request, instance_id, name, description\u003dNone):"},{"line_number":746,"context_line":"    return novaclient(request).servers.update(instance_id, name\u003dname,"},{"line_number":747,"context_line":"                                              description\u003ddescription)"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"def server_migrate(request, instance_id):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7aa08908_df7b41f3","line":747,"range":{"start_line":747,"start_character":45,"end_line":747,"end_character":69},"updated":"2016-06-15 12:57:20.000000000","message":"what happens if an older version of novaclient or API is used?","commit_id":"e7cdf6ef07fd53259916b7f405f7caead2adb490"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"feca9cfd25410b668591635309c962806f26c616","unresolved":false,"context_lines":[{"line_number":744,"context_line":""},{"line_number":745,"context_line":"def server_update(request, instance_id, name, description\u003dNone):"},{"line_number":746,"context_line":"    return novaclient(request).servers.update(instance_id, name\u003dname,"},{"line_number":747,"context_line":"                                              description\u003ddescription)"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":""},{"line_number":750,"context_line":"def server_migrate(request, instance_id):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a9d85d2_62835705","line":747,"range":{"start_line":747,"start_character":45,"end_line":747,"end_character":69},"in_reply_to":"7aa08908_df7b41f3","updated":"2016-06-21 08:55:08.000000000","message":"Hmm, seems i need to update the novaclient version to 3.3.0 in requirements.txt","commit_id":"e7cdf6ef07fd53259916b7f405f7caead2adb490"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6309eea619a5134b128ba756883ee0a191eac092","unresolved":false,"context_lines":[{"line_number":53,"context_line":"VERSIONS.load_supported_version(2, {\"client\": nova_client, \"version\": 2})"},{"line_number":54,"context_line":"VERSIONS.load_supported_version(2.9, {\"client\": nova_client, \"version\": 2.9})"},{"line_number":55,"context_line":"# TODO(lyj): We will need a more efficient way to support the microversion"},{"line_number":56,"context_line":"VERSIONS.load_supported_version(2.19, {\"client\": nova_client, \"version\": 2.19})"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# API static values"},{"line_number":59,"context_line":"INSTANCE_ACTIVE_STATE \u003d \u0027ACTIVE\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_167b0529","line":56,"updated":"2016-10-09 12:17:01.000000000","message":"As we discussed before, I know horizon does not \n\nAt least, you need to check there are incompatible changes between the  old version (2.9) and new version (2.19) when you bump the micro-version. Does 2.19 support all horizon behaviors? This is required to do to ensure not to break the existing horizon.","commit_id":"c7ad8294672e4dc1a8849e00fd5860a2b14dde96"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f8b36fd2e71a23eb28361697a59c69504b425a06","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"    return features.get(\u0027enable_quotas\u0027, True)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"def feature_supported(request, feature):"},{"line_number":1179,"context_line":"    current_version \u003d novaclient(request).versions.get_current()"},{"line_number":1180,"context_line":"    versions \u003d getattr("},{"line_number":1181,"context_line":"        settings, \u0027OPENSTACK_MICROVERSIONS_CAPABILITY\u0027, {}).get(feature, {})"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_bd641f22","line":1178,"updated":"2016-12-05 20:05:13.000000000","message":"wondering if we can move this out so it can be used by other APIs (reusability)","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aefe228e48a7a62a6dfc4b3ebf9c2e56c8da115f","unresolved":false,"context_lines":[{"line_number":1175,"context_line":"    return features.get(\u0027enable_quotas\u0027, True)"},{"line_number":1176,"context_line":""},{"line_number":1177,"context_line":""},{"line_number":1178,"context_line":"def feature_supported(request, feature):"},{"line_number":1179,"context_line":"    current_version \u003d novaclient(request).versions.get_current()"},{"line_number":1180,"context_line":"    versions \u003d getattr("},{"line_number":1181,"context_line":"        settings, \u0027OPENSTACK_MICROVERSIONS_CAPABILITY\u0027, {}).get(feature, {})"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_e9a24fad","line":1178,"in_reply_to":"3a71b18c_bd641f22","updated":"2016-12-06 02:28:11.000000000","message":"Yes, we can","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"}],"openstack_dashboard/api/rest/nova.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6309eea619a5134b128ba756883ee0a191eac092","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"@urls.register"},{"line_number":54,"context_line":"class Version(generic.View):"},{"line_number":55,"context_line":"    \"\"\"API for active nova version."},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":"    url_regex \u003d r\u0027nova/version/$\u0027"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @rest_utils.ajax()"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_161f8508","line":56,"range":{"start_line":55,"start_character":5,"end_line":56,"end_character":7},"updated":"2016-10-09 12:17:01.000000000","message":"Should be one line.","commit_id":"c7ad8294672e4dc1a8849e00fd5860a2b14dde96"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f8b36fd2e71a23eb28361697a59c69504b425a06","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"@urls.register"},{"line_number":54,"context_line":"class Version(generic.View):"},{"line_number":55,"context_line":"    \"\"\"API for check if version supported.\"\"\""},{"line_number":56,"context_line":"    url_regex \u003d r\u0027nova/version/$\u0027"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_92b74dd7","line":54,"updated":"2016-12-05 20:05:13.000000000","message":"should we call this something else, like FeatureVersion? \n\nbecause we use Version in Glance and Keystone API as just returning the version number?","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aefe228e48a7a62a6dfc4b3ebf9c2e56c8da115f","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"@urls.register"},{"line_number":54,"context_line":"class Version(generic.View):"},{"line_number":55,"context_line":"    \"\"\"API for check if version supported.\"\"\""},{"line_number":56,"context_line":"    url_regex \u003d r\u0027nova/version/$\u0027"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_2997e73a","line":54,"in_reply_to":"3a71b18c_92b74dd7","updated":"2016-12-06 02:28:11.000000000","message":"Looks better","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f8b36fd2e71a23eb28361697a59c69504b425a06","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"@urls.register"},{"line_number":54,"context_line":"class Version(generic.View):"},{"line_number":55,"context_line":"    \"\"\"API for check if version supported.\"\"\""},{"line_number":56,"context_line":"    url_regex \u003d r\u0027nova/version/$\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @rest_utils.ajax()"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_d2e465e1","line":55,"updated":"2016-12-05 20:05:13.000000000","message":"for that feature*","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aefe228e48a7a62a6dfc4b3ebf9c2e56c8da115f","unresolved":false,"context_lines":[{"line_number":52,"context_line":""},{"line_number":53,"context_line":"@urls.register"},{"line_number":54,"context_line":"class Version(generic.View):"},{"line_number":55,"context_line":"    \"\"\"API for check if version supported.\"\"\""},{"line_number":56,"context_line":"    url_regex \u003d r\u0027nova/version/$\u0027"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @rest_utils.ajax()"}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_c9a8337a","line":55,"in_reply_to":"3a71b18c_d2e465e1","updated":"2016-12-06 02:28:11.000000000","message":"Done","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f8b36fd2e71a23eb28361697a59c69504b425a06","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @rest_utils.ajax()"},{"line_number":59,"context_line":"    def get(self, request):"},{"line_number":60,"context_line":"        \"\"\"Check if version supported\"\"\""},{"line_number":61,"context_line":"        feature \u003d request.GET.get(\u0027feature\u0027)"},{"line_number":62,"context_line":"        return api.nova.feature_supported(request, feature)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_72d631f2","line":60,"updated":"2016-12-05 20:05:13.000000000","message":"for that feature*","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aefe228e48a7a62a6dfc4b3ebf9c2e56c8da115f","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @rest_utils.ajax()"},{"line_number":59,"context_line":"    def get(self, request):"},{"line_number":60,"context_line":"        \"\"\"Check if version supported\"\"\""},{"line_number":61,"context_line":"        feature \u003d request.GET.get(\u0027feature\u0027)"},{"line_number":62,"context_line":"        return api.nova.feature_supported(request, feature)"},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"3a71b18c_09bdcbb6","line":60,"in_reply_to":"3a71b18c_72d631f2","updated":"2016-12-06 02:28:11.000000000","message":"Done","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"813681d2ad44048067e823b48bab1d747f546908","unresolved":false,"context_lines":[{"line_number":51,"context_line":"@urls.register"},{"line_number":52,"context_line":"class FeatureVersion(generic.View):"},{"line_number":53,"context_line":"    \"\"\"API for check if version supported the feature.\"\"\""},{"line_number":54,"context_line":"    url_regex \u003d r\u0027nova/version/$\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @rest_utils.ajax()"},{"line_number":57,"context_line":"    def get(self, request):"}],"source_content_type":"text/x-python","patch_set":26,"id":"5ff73747_15915f53","line":54,"range":{"start_line":54,"start_character":18,"end_line":54,"end_character":32},"updated":"2017-04-23 21:18:23.000000000","message":"I wonder why this is not \u0027nova/features\u0027. This returns the availability of a requested feature, so I think \u0027nova/features/\u003cfeature-name\u003e\u0027 would be more appropriate.","commit_id":"6c00c3f84204f5a4874dc75721b386a942d5b2f3"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"45fe410abf341a8eb67e399373b338f2cd2a135f","unresolved":false,"context_lines":[{"line_number":51,"context_line":"@urls.register"},{"line_number":52,"context_line":"class FeatureVersion(generic.View):"},{"line_number":53,"context_line":"    \"\"\"API for check if version supported the feature.\"\"\""},{"line_number":54,"context_line":"    url_regex \u003d r\u0027nova/version/$\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @rest_utils.ajax()"},{"line_number":57,"context_line":"    def get(self, request):"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f044301_2621d74e","line":54,"range":{"start_line":54,"start_character":18,"end_line":54,"end_character":32},"in_reply_to":"5ff73747_15915f53","updated":"2017-05-04 06:30:37.000000000","message":"Done","commit_id":"6c00c3f84204f5a4874dc75721b386a942d5b2f3"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2a81e1d63771ad5e77ce31d450739d8766141b29","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @rest_utils.ajax()"},{"line_number":53,"context_line":"    def get(self, request):"},{"line_number":54,"context_line":"        \"\"\"Check if version supported for the feature.\"\"\""},{"line_number":55,"context_line":"        feature \u003d request.GET.get(\u0027feature\u0027)"},{"line_number":56,"context_line":"        return api.nova.is_feature_available(request, feature)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"3f4b6375_81a7dba7","line":55,"range":{"start_line":55,"start_character":18,"end_line":55,"end_character":44},"updated":"2017-10-24 15:25:02.000000000","message":"I think it is not a common pattern to pass a parameter via body.\nWhy don\u0027t you pass a feature name as URL?\nThere are several good examples here in this module like \"Server\" class (not \"Servers\" class).","commit_id":"92abf8d0291f69a456a009cd2f5b7509e63e8831"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ac19fb2d5c25014b5ce3f34c0b0bf2e642d3b640","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    @rest_utils.ajax()"},{"line_number":53,"context_line":"    def get(self, request):"},{"line_number":54,"context_line":"        \"\"\"Check if version supported for the feature.\"\"\""},{"line_number":55,"context_line":"        feature \u003d request.GET.get(\u0027feature\u0027)"},{"line_number":56,"context_line":"        return api.nova.is_feature_available(request, feature)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"3f4b6375_fe4293aa","line":55,"range":{"start_line":55,"start_character":18,"end_line":55,"end_character":44},"in_reply_to":"3f4b6375_81a7dba7","updated":"2017-10-25 09:48:04.000000000","message":"Done","commit_id":"92abf8d0291f69a456a009cd2f5b7509e63e8831"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f17cbf88418646c5cdc2babb94c80e11769698e8","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@urls.register"},{"line_number":47,"context_line":"class FeatureVersion(generic.View):"},{"line_number":48,"context_line":"    \"\"\"API for check if version supported the feature.\"\"\""},{"line_number":49,"context_line":"    url_regex \u003d r\u0027nova/features/(?P\u003cname\u003e[^/]+)/$\u0027"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"3f4b6375_19e229a1","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":20},"updated":"2017-10-25 10:10:25.000000000","message":"The provided method checks a specific feature is available, but version information is unrelated. Does \"Features\" make more sense?","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"fa4da36f45cb8ba446745aed92d861a04c623a1b","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@urls.register"},{"line_number":47,"context_line":"class FeatureVersion(generic.View):"},{"line_number":48,"context_line":"    \"\"\"API for check if version supported the feature.\"\"\""},{"line_number":49,"context_line":"    url_regex \u003d r\u0027nova/features/(?P\u003cname\u003e[^/]+)/$\u0027"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"3f4b6375_8d447e48","line":47,"range":{"start_line":47,"start_character":6,"end_line":47,"end_character":20},"in_reply_to":"3f4b6375_19e229a1","updated":"2017-10-26 02:29:28.000000000","message":"Done","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f17cbf88418646c5cdc2babb94c80e11769698e8","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@urls.register"},{"line_number":47,"context_line":"class FeatureVersion(generic.View):"},{"line_number":48,"context_line":"    \"\"\"API for check if version supported the feature.\"\"\""},{"line_number":49,"context_line":"    url_regex \u003d r\u0027nova/features/(?P\u003cname\u003e[^/]+)/$\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @rest_utils.ajax()"}],"source_content_type":"text/x-python","patch_set":39,"id":"3f4b6375_f9de2dd8","line":48,"range":{"start_line":48,"start_character":21,"end_line":48,"end_character":53},"updated":"2017-10-25 10:10:25.000000000","message":"\u0027version\u0027 is not related again.\n\n API for check if a specified feature is available","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"fa4da36f45cb8ba446745aed92d861a04c623a1b","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@urls.register"},{"line_number":47,"context_line":"class FeatureVersion(generic.View):"},{"line_number":48,"context_line":"    \"\"\"API for check if version supported the feature.\"\"\""},{"line_number":49,"context_line":"    url_regex \u003d r\u0027nova/features/(?P\u003cname\u003e[^/]+)/$\u0027"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @rest_utils.ajax()"}],"source_content_type":"text/x-python","patch_set":39,"id":"3f4b6375_6d794292","line":48,"range":{"start_line":48,"start_character":21,"end_line":48,"end_character":53},"in_reply_to":"3f4b6375_f9de2dd8","updated":"2017-10-26 02:29:28.000000000","message":"Done","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f17cbf88418646c5cdc2babb94c80e11769698e8","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @rest_utils.ajax()"},{"line_number":52,"context_line":"    def get(self, request, name):"},{"line_number":53,"context_line":"        \"\"\"Check if version supported for the feature.\"\"\""},{"line_number":54,"context_line":"        return api.nova.is_feature_available(request, name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"3f4b6375_d9f1316d","line":53,"updated":"2017-10-25 10:10:25.000000000","message":"ditto","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"fa4da36f45cb8ba446745aed92d861a04c623a1b","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @rest_utils.ajax()"},{"line_number":52,"context_line":"    def get(self, request, name):"},{"line_number":53,"context_line":"        \"\"\"Check if version supported for the feature.\"\"\""},{"line_number":54,"context_line":"        return api.nova.is_feature_available(request, name)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"3f4b6375_ed6c12cf","line":53,"in_reply_to":"3f4b6375_d9f1316d","updated":"2017-10-26 02:29:28.000000000","message":"Done","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"}],"openstack_dashboard/dashboards/project/instances/tables.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6309eea619a5134b128ba756883ee0a191eac092","unresolved":false,"context_lines":[{"line_number":1200,"context_line":"                                 verbose_name\u003d_(\"Instance Name\"))"},{"line_number":1201,"context_line":"    if api.nova.get_version() \u003e\u003d 2.19:"},{"line_number":1202,"context_line":"        description \u003d tables.Column(\"description\","},{"line_number":1203,"context_line":"                                    verbose_name\u003d_(\"Description\"))"},{"line_number":1204,"context_line":"    image_name \u003d tables.Column(\"image_name\","},{"line_number":1205,"context_line":"                               verbose_name\u003d_(\"Image Name\"))"},{"line_number":1206,"context_line":"    ip \u003d tables.Column(get_ips,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1a95cdbc_b6dc1147","line":1203,"updated":"2016-10-09 12:17:01.000000000","message":"The number of Instances table columns looks overflowed.\nDo we really need to add this from UX perspective?","commit_id":"c7ad8294672e4dc1a8849e00fd5860a2b14dde96"}],"openstack_dashboard/dashboards/project/instances/templates/instances/_detail_overview.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2a81e1d63771ad5e77ce31d450739d8766141b29","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":5,"context_line":"    \u003cdt\u003e{% trans \"Name\" %}\u003c/dt\u003e"},{"line_number":6,"context_line":"    \u003cdd data-display\u003d\"{{ instance.name|default:instance.id }}\"\u003e{{ instance.name }}\u003c/dd\u003e"},{"line_number":7,"context_line":"    {% if instance.description %}"},{"line_number":8,"context_line":"    \u003cdt\u003e{% trans \"Description\" %}\u003c/dt\u003e"},{"line_number":9,"context_line":"    \u003cdd\u003e{{ instance.description }}\u003c/dd\u003e"},{"line_number":10,"context_line":"    {% endif %}"}],"source_content_type":"text/html","patch_set":38,"id":"3f4b6375_4180c3c0","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":33},"updated":"2017-10-24 15:25:02.000000000","message":"what happens if \u0027description\u0027 field is empty? I believe we should show the field if \u0027description\u0027 field exists but it is empty.","commit_id":"92abf8d0291f69a456a009cd2f5b7509e63e8831"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"ac19fb2d5c25014b5ce3f34c0b0bf2e642d3b640","unresolved":false,"context_lines":[{"line_number":4,"context_line":"  \u003cdl class\u003d\"dl-horizontal\"\u003e"},{"line_number":5,"context_line":"    \u003cdt\u003e{% trans \"Name\" %}\u003c/dt\u003e"},{"line_number":6,"context_line":"    \u003cdd data-display\u003d\"{{ instance.name|default:instance.id }}\"\u003e{{ instance.name }}\u003c/dd\u003e"},{"line_number":7,"context_line":"    {% if instance.description %}"},{"line_number":8,"context_line":"    \u003cdt\u003e{% trans \"Description\" %}\u003c/dt\u003e"},{"line_number":9,"context_line":"    \u003cdd\u003e{{ instance.description }}\u003c/dd\u003e"},{"line_number":10,"context_line":"    {% endif %}"}],"source_content_type":"text/html","patch_set":38,"id":"3f4b6375_79723daf","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":33},"in_reply_to":"3f4b6375_4180c3c0","updated":"2017-10-25 09:48:04.000000000","message":"Done","commit_id":"92abf8d0291f69a456a009cd2f5b7509e63e8831"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/details/details.controller.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f8b36fd2e71a23eb28361697a59c69504b425a06","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  ) {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    var ctrl \u003d this;"},{"line_number":47,"context_line":"    ctrl.description \u003d novaAPI.versionSupported("},{"line_number":48,"context_line":"      \u0027nova.instance_description\u0027).then(versionSupported, noop);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    // Error text for invalid fields"}],"source_content_type":"text/javascript","patch_set":20,"id":"3a71b18c_e55a7df1","line":47,"updated":"2016-12-05 20:05:13.000000000","message":"think the method should be called featureSupported","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aefe228e48a7a62a6dfc4b3ebf9c2e56c8da115f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  ) {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    var ctrl \u003d this;"},{"line_number":47,"context_line":"    ctrl.description \u003d novaAPI.versionSupported("},{"line_number":48,"context_line":"      \u0027nova.instance_description\u0027).then(versionSupported, noop);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    // Error text for invalid fields"}],"source_content_type":"text/javascript","patch_set":20,"id":"3a71b18c_69cc7f6a","line":47,"in_reply_to":"3a71b18c_e55a7df1","updated":"2016-12-06 02:28:11.000000000","message":"Done","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f8b36fd2e71a23eb28361697a59c69504b425a06","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    ////////////////////"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    function versionSupported(data) {"},{"line_number":111,"context_line":"      ctrl.description \u003d data.data;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""}],"source_content_type":"text/javascript","patch_set":20,"id":"3a71b18c_65674db7","line":110,"updated":"2016-12-05 20:05:13.000000000","message":"ditto","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aefe228e48a7a62a6dfc4b3ebf9c2e56c8da115f","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    ////////////////////"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    function versionSupported(data) {"},{"line_number":111,"context_line":"      ctrl.description \u003d data.data;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""}],"source_content_type":"text/javascript","patch_set":20,"id":"3a71b18c_09e4ebde","line":110,"in_reply_to":"3a71b18c_65674db7","updated":"2016-12-06 02:28:11.000000000","message":"Done","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"46cbd20268ced5bf8f71f23deb5763b0de35b1ee","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  ) {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    var ctrl \u003d this;"},{"line_number":47,"context_line":"    ctrl.description \u003d novaAPI.featureSupported("},{"line_number":48,"context_line":"      \u0027instance_description\u0027).then(featureSupported, noop);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    // Error text for invalid fields"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_3fee07ed","line":47,"updated":"2017-06-25 04:28:28.000000000","message":"I don\u0027t think you need the assignment here. ctrl.description is set on line 111.","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"77ae4aa64b1a3b834a982137ce83820a68e5a1ee","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  ) {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    var ctrl \u003d this;"},{"line_number":47,"context_line":"    ctrl.description \u003d novaAPI.featureSupported("},{"line_number":48,"context_line":"      \u0027instance_description\u0027).then(featureSupported, noop);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    // Error text for invalid fields"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_4757b527","line":47,"in_reply_to":"5f201791_3fee07ed","updated":"2017-06-26 02:12:45.000000000","message":"the function on line 111 is used to fetch data, not duplicated.","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"a86af35fe3f1717e0d6c285865c8e78c32964bc3","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  ) {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    var ctrl \u003d this;"},{"line_number":47,"context_line":"    ctrl.description \u003d novaAPI.featureSupported("},{"line_number":48,"context_line":"      \u0027instance_description\u0027).then(featureSupported, noop);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    // Error text for invalid fields"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_dde4b6e2","line":47,"in_reply_to":"5f201791_4757b527","updated":"2017-06-26 03:56:24.000000000","message":"I meant you should just call the api without assigning to ctrl.description which is set after the data is fetched.","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"e1e5d2b43e006f246dee8c5cb3726b8f30ed93e7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  ) {"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    var ctrl \u003d this;"},{"line_number":47,"context_line":"    ctrl.description \u003d novaAPI.featureSupported("},{"line_number":48,"context_line":"      \u0027instance_description\u0027).then(featureSupported, noop);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    // Error text for invalid fields"}],"source_content_type":"text/javascript","patch_set":32,"id":"1f1a1f67_b0ffc5a9","line":47,"in_reply_to":"5f201791_dde4b6e2","updated":"2017-07-18 01:09:20.000000000","message":"Done","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"46cbd20268ced5bf8f71f23deb5763b0de35b1ee","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    var ctrl \u003d this;"},{"line_number":47,"context_line":"    ctrl.description \u003d novaAPI.featureSupported("},{"line_number":48,"context_line":"      \u0027instance_description\u0027).then(featureSupported, noop);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    // Error text for invalid fields"},{"line_number":51,"context_line":"    ctrl.instanceNameError \u003d gettext(\u0027A name is required for your instance.\u0027);"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_1f16abf2","line":48,"updated":"2017-06-25 04:28:28.000000000","message":"Instead of defining noop, you can just skip the second parameter.","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"77ae4aa64b1a3b834a982137ce83820a68e5a1ee","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    var ctrl \u003d this;"},{"line_number":47,"context_line":"    ctrl.description \u003d novaAPI.featureSupported("},{"line_number":48,"context_line":"      \u0027instance_description\u0027).then(featureSupported, noop);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    // Error text for invalid fields"},{"line_number":51,"context_line":"    ctrl.instanceNameError \u003d gettext(\u0027A name is required for your instance.\u0027);"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_2754b920","line":48,"in_reply_to":"5f201791_1f16abf2","updated":"2017-06-26 02:12:45.000000000","message":"Done","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"46cbd20268ced5bf8f71f23deb5763b0de35b1ee","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    ////////////////////"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    function featureSupported(data) {"},{"line_number":111,"context_line":"      ctrl.description \u003d data.data;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    function getMaxInstances() {"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_bf81f7fd","line":111,"updated":"2017-06-25 04:28:28.000000000","message":"novaAPI.featureSupported just returns if the feature is supported not the instance description.","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"a86af35fe3f1717e0d6c285865c8e78c32964bc3","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    ////////////////////"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    function featureSupported(data) {"},{"line_number":111,"context_line":"      ctrl.description \u003d data.data;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    function getMaxInstances() {"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_3d43aab1","line":111,"in_reply_to":"5f201791_2729599a","updated":"2017-06-26 03:56:24.000000000","message":"Can you update the variable name too? That\u0027s more important than the function name.","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"e1e5d2b43e006f246dee8c5cb3726b8f30ed93e7","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    ////////////////////"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    function featureSupported(data) {"},{"line_number":111,"context_line":"      ctrl.description \u003d data.data;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    function getMaxInstances() {"}],"source_content_type":"text/javascript","patch_set":32,"id":"1f1a1f67_d0f6c1d7","line":111,"in_reply_to":"5f201791_3d43aab1","updated":"2017-07-18 01:09:20.000000000","message":"Done","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"77ae4aa64b1a3b834a982137ce83820a68e5a1ee","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    ////////////////////"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    function featureSupported(data) {"},{"line_number":111,"context_line":"      ctrl.description \u003d data.data;"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    function getMaxInstances() {"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_2729599a","line":111,"in_reply_to":"5f201791_bf81f7fd","updated":"2017-06-26 02:12:45.000000000","message":"renamed the function to isDescriptionSupported","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"change_message_id":"510b90d9a99e09933ddc6f2ff9ca7b72ff8be5d1","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    ////////////////////"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    function isDescriptionSupported(data) {"},{"line_number":110,"context_line":"      ctrl.isDescriptionSupported \u003d data.data;"},{"line_number":111,"context_line":"    }"},{"line_number":112,"context_line":""}],"source_content_type":"text/javascript","patch_set":37,"id":"df3967d1_920e7fe3","line":109,"range":{"start_line":109,"start_character":36,"end_line":109,"end_character":40},"updated":"2017-07-31 06:05:28.000000000","message":"use \u0027response\u0027 will make more sence","commit_id":"63d97431f3f4cefe5c07e3cc7397633c432b9639"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/details/details.controller.spec.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f8b36fd2e71a23eb28361697a59c69504b425a06","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          deferred.resolve({ data: true });"},{"line_number":69,"context_line":"          return deferred.promise;"},{"line_number":70,"context_line":"        });"},{"line_number":71,"context_line":"        expect(ctrl.description).toBe(true);"},{"line_number":72,"context_line":"      });"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"      it(\u0027should define error messages for invalid fields\u0027, function() {"}],"source_content_type":"text/javascript","patch_set":20,"id":"3a71b18c_12417da9","line":71,"updated":"2016-12-05 20:05:13.000000000","message":"before the spyOn, could we check \n\nexpect(ctrl.description).toBe(false);  ?","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aefe228e48a7a62a6dfc4b3ebf9c2e56c8da115f","unresolved":false,"context_lines":[{"line_number":68,"context_line":"          deferred.resolve({ data: true });"},{"line_number":69,"context_line":"          return deferred.promise;"},{"line_number":70,"context_line":"        });"},{"line_number":71,"context_line":"        expect(ctrl.description).toBe(true);"},{"line_number":72,"context_line":"      });"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"      it(\u0027should define error messages for invalid fields\u0027, function() {"}],"source_content_type":"text/javascript","patch_set":20,"id":"3a71b18c_89f71b8a","line":71,"in_reply_to":"3a71b18c_12417da9","updated":"2016-12-06 02:28:11.000000000","message":"Done","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"46cbd20268ced5bf8f71f23deb5763b0de35b1ee","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        scope.$apply();"},{"line_number":63,"context_line":"      }));"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"      it(\u0027should have version defined\u0027, function() {"},{"line_number":66,"context_line":"        spyOn(novaAPI, \u0027featureSupported\u0027).and.callFake(function () {"},{"line_number":67,"context_line":"          var deferred \u003d $q.defer();"},{"line_number":68,"context_line":"          deferred.resolve({ data: true });"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_dfc27359","line":65,"updated":"2017-06-25 04:28:28.000000000","message":"Should it be \u0027should have description defined\u0027 instead?","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"77ae4aa64b1a3b834a982137ce83820a68e5a1ee","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        scope.$apply();"},{"line_number":63,"context_line":"      }));"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"      it(\u0027should have version defined\u0027, function() {"},{"line_number":66,"context_line":"        spyOn(novaAPI, \u0027featureSupported\u0027).and.callFake(function () {"},{"line_number":67,"context_line":"          var deferred \u003d $q.defer();"},{"line_number":68,"context_line":"          deferred.resolve({ data: true });"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_2772794a","line":65,"in_reply_to":"5f201791_dfc27359","updated":"2017-06-26 02:12:45.000000000","message":"Done","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"34245c58be01809a57527d0a463f1f9b7979c7e0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        scope.$apply();"},{"line_number":63,"context_line":"      }));"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"      it(\u0027should have description version defined\u0027, function() {"},{"line_number":66,"context_line":"        spyOn(novaAPI, \u0027isFeatureSupported\u0027).and.callFake(function () {"},{"line_number":67,"context_line":"          var deferred \u003d $q.defer();"},{"line_number":68,"context_line":"          deferred.resolve({ data: true });"}],"source_content_type":"text/javascript","patch_set":34,"id":"5f201791_7d6b621d","line":65,"updated":"2017-06-26 04:00:23.000000000","message":"\"version\" should be removed and this should be updated accordingly when you rename the variable description.","commit_id":"d6820d3455113345f01c318bb66b76137281b55c"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"551ffc6f1f71fabf5e3a07eb2850306b7e5ec7fa","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        scope.$apply();"},{"line_number":63,"context_line":"      }));"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"      it(\u0027should have description version defined\u0027, function() {"},{"line_number":66,"context_line":"        spyOn(novaAPI, \u0027isFeatureSupported\u0027).and.callFake(function () {"},{"line_number":67,"context_line":"          var deferred \u003d $q.defer();"},{"line_number":68,"context_line":"          deferred.resolve({ data: true });"}],"source_content_type":"text/javascript","patch_set":34,"id":"5f201791_d3cee72b","line":65,"in_reply_to":"5f201791_7d6b621d","updated":"2017-06-26 05:57:14.000000000","message":"Done","commit_id":"d6820d3455113345f01c318bb66b76137281b55c"}],"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/details/details.html":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6309eea619a5134b128ba756883ee0a191eac092","unresolved":false,"context_lines":[{"line_number":19,"context_line":"          \u003c/span\u003e"},{"line_number":20,"context_line":"      \u003c/div\u003e"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"      \u003cdiv ng-if\u003d\"ctrl.version \u003e\u003d 2.19\" class\u003d\"form-group\"\u003e"},{"line_number":23,"context_line":"        \u003clabel class\u003d\"control-label\" translate for\u003d\"description\"\u003eDescription\u003c/label\u003e"},{"line_number":24,"context_line":"        \u003cinput id\u003d\"description\" name\u003d\"description\" type\u003d\"text\" class\u003d\"form-control\""},{"line_number":25,"context_line":"               ng-model\u003d\"model.newInstanceSpec.description\"\u003e"}],"source_content_type":"text/html","patch_set":15,"id":"1a95cdbc_36dba11c","line":22,"updated":"2016-10-09 12:17:01.000000000","message":"I think we first need to decide whether we have a check of nova API micro-version in the client side code or the server side code for maintenance-ability. I think this needs more input from horizon folks involved in AngularJS work more.","commit_id":"c7ad8294672e4dc1a8849e00fd5860a2b14dde96"}],"openstack_dashboard/static/app/core/openstack-service-api/nova.service.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f8b36fd2e71a23eb28361697a59c69504b425a06","unresolved":false,"context_lines":[{"line_number":96,"context_line":"     * Check if the version is supported."},{"line_number":97,"context_line":"     * @returns {Object} The result of the API call"},{"line_number":98,"context_line":"     */"},{"line_number":99,"context_line":"    function versionSupported(feature) {"},{"line_number":100,"context_line":"      var params \u003d { params: {feature: feature }};"},{"line_number":101,"context_line":"      return apiService.get(\u0027/api/nova/version/\u0027, params)"},{"line_number":102,"context_line":"        .error(function () {"}],"source_content_type":"text/javascript","patch_set":20,"id":"3a71b18c_6553cd39","line":99,"updated":"2016-12-05 20:05:13.000000000","message":"featureSupported*","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aefe228e48a7a62a6dfc4b3ebf9c2e56c8da115f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"     * Check if the version is supported."},{"line_number":97,"context_line":"     * @returns {Object} The result of the API call"},{"line_number":98,"context_line":"     */"},{"line_number":99,"context_line":"    function versionSupported(feature) {"},{"line_number":100,"context_line":"      var params \u003d { params: {feature: feature }};"},{"line_number":101,"context_line":"      return apiService.get(\u0027/api/nova/version/\u0027, params)"},{"line_number":102,"context_line":"        .error(function () {"}],"source_content_type":"text/javascript","patch_set":20,"id":"3a71b18c_49018369","line":99,"in_reply_to":"3a71b18c_6553cd39","updated":"2016-12-06 02:28:11.000000000","message":"Done","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"46cbd20268ced5bf8f71f23deb5763b0de35b1ee","unresolved":false,"context_lines":[{"line_number":92,"context_line":"     * Check if the version is supported."},{"line_number":93,"context_line":"     * @returns {Object} The result of the API call"},{"line_number":94,"context_line":"     */"},{"line_number":95,"context_line":"    function featureSupported(feature) {"},{"line_number":96,"context_line":"      var params \u003d { params: {feature: feature }};"},{"line_number":97,"context_line":"      return apiService.get(\u0027/api/nova/features/\u0027, params)"},{"line_number":98,"context_line":"        .error(function () {"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_5f7c231e","line":95,"updated":"2017-06-25 04:28:28.000000000","message":"It\u0027s better to name it as isFeatureSupported.","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"77ae4aa64b1a3b834a982137ce83820a68e5a1ee","unresolved":false,"context_lines":[{"line_number":92,"context_line":"     * Check if the version is supported."},{"line_number":93,"context_line":"     * @returns {Object} The result of the API call"},{"line_number":94,"context_line":"     */"},{"line_number":95,"context_line":"    function featureSupported(feature) {"},{"line_number":96,"context_line":"      var params \u003d { params: {feature: feature }};"},{"line_number":97,"context_line":"      return apiService.get(\u0027/api/nova/features/\u0027, params)"},{"line_number":98,"context_line":"        .error(function () {"}],"source_content_type":"text/javascript","patch_set":32,"id":"5f201791_47757531","line":95,"in_reply_to":"5f201791_5f7c231e","updated":"2017-06-26 02:12:45.000000000","message":"Done","commit_id":"89e886907a62b78cfeac2b9fb0845f31276fb1a8"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f17cbf88418646c5cdc2babb94c80e11769698e8","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    ///////////"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    // Version"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    /**"},{"line_number":91,"context_line":"     * @name isFeatureSupported"}],"source_content_type":"text/javascript","patch_set":39,"id":"3f4b6375_d996d1f0","line":88,"range":{"start_line":88,"start_character":6,"end_line":88,"end_character":14},"updated":"2017-10-25 10:10:25.000000000","message":"-\u003e Feature","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"fa4da36f45cb8ba446745aed92d861a04c623a1b","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    ///////////"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    // Version"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    /**"},{"line_number":91,"context_line":"     * @name isFeatureSupported"}],"source_content_type":"text/javascript","patch_set":39,"id":"3f4b6375_ad629ad6","line":88,"range":{"start_line":88,"start_character":6,"end_line":88,"end_character":14},"in_reply_to":"3f4b6375_d996d1f0","updated":"2017-10-26 02:29:28.000000000","message":"Done","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f17cbf88418646c5cdc2babb94c80e11769698e8","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    /**"},{"line_number":91,"context_line":"     * @name isFeatureSupported"},{"line_number":92,"context_line":"     * @description"},{"line_number":93,"context_line":"     * Check if the version is supported."},{"line_number":94,"context_line":"     * @returns {Object} The result of the API call"},{"line_number":95,"context_line":"     */"},{"line_number":96,"context_line":"    function isFeatureSupported(feature) {"}],"source_content_type":"text/javascript","patch_set":39,"id":"3f4b6375_19fb4947","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":27},"updated":"2017-10-25 10:10:25.000000000","message":"-\u003e feature","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"fa4da36f45cb8ba446745aed92d861a04c623a1b","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    /**"},{"line_number":91,"context_line":"     * @name isFeatureSupported"},{"line_number":92,"context_line":"     * @description"},{"line_number":93,"context_line":"     * Check if the version is supported."},{"line_number":94,"context_line":"     * @returns {Object} The result of the API call"},{"line_number":95,"context_line":"     */"},{"line_number":96,"context_line":"    function isFeatureSupported(feature) {"}],"source_content_type":"text/javascript","patch_set":39,"id":"3f4b6375_8d5d9e16","line":93,"range":{"start_line":93,"start_character":20,"end_line":93,"end_character":27},"in_reply_to":"3f4b6375_19fb4947","updated":"2017-10-26 02:29:28.000000000","message":"Done","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f17cbf88418646c5cdc2babb94c80e11769698e8","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    function isFeatureSupported(feature) {"},{"line_number":97,"context_line":"      return apiService.get(\u0027/api/nova/features/\u0027 + feature)"},{"line_number":98,"context_line":"        .error(function () {"},{"line_number":99,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to check the Nova service version.\u0027));"},{"line_number":100,"context_line":"        });"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":""}],"source_content_type":"text/javascript","patch_set":39,"id":"3f4b6375_59054145","line":99,"range":{"start_line":99,"start_character":78,"end_line":99,"end_character":85},"updated":"2017-10-25 10:10:25.000000000","message":"version -\u003e feature?","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"fa4da36f45cb8ba446745aed92d861a04c623a1b","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    function isFeatureSupported(feature) {"},{"line_number":97,"context_line":"      return apiService.get(\u0027/api/nova/features/\u0027 + feature)"},{"line_number":98,"context_line":"        .error(function () {"},{"line_number":99,"context_line":"          toastService.add(\u0027error\u0027, gettext(\u0027Unable to check the Nova service version.\u0027));"},{"line_number":100,"context_line":"        });"},{"line_number":101,"context_line":"    }"},{"line_number":102,"context_line":""}],"source_content_type":"text/javascript","patch_set":39,"id":"3f4b6375_4da1e6f7","line":99,"range":{"start_line":99,"start_character":78,"end_line":99,"end_character":85},"in_reply_to":"3f4b6375_59054145","updated":"2017-10-26 02:29:28.000000000","message":"Done","commit_id":"a7c34910bb4b4088ba09f32440464d81d157c657"}],"releasenotes/notes/bp-support-description-for-instance-232f31e9033f59f3.yaml":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"f8b36fd2e71a23eb28361697a59c69504b425a06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new setting OPENSTACK_MICROVERSIONS_CAPABILITY which is a dictionary"},{"line_number":4,"context_line":"    defines the minimum and maximum micro API version supported for a set of"},{"line_number":5,"context_line":"    specific features. The minimum is defined using keyword \"min\", the maximum"},{"line_number":6,"context_line":"    is defined using keyword \"max\"."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3a71b18c_cff04200","line":3,"updated":"2016-12-05 20:05:13.000000000","message":"dictionary that*","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"},{"author":{"_account_id":4428,"name":"Liyingjun","email":"yinjalee@163.com","username":"liyingjun"},"change_message_id":"aefe228e48a7a62a6dfc4b3ebf9c2e56c8da115f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add a new setting OPENSTACK_MICROVERSIONS_CAPABILITY which is a dictionary"},{"line_number":4,"context_line":"    defines the minimum and maximum micro API version supported for a set of"},{"line_number":5,"context_line":"    specific features. The minimum is defined using keyword \"min\", the maximum"},{"line_number":6,"context_line":"    is defined using keyword \"max\"."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"3a71b18c_4938a33d","line":3,"in_reply_to":"3a71b18c_cff04200","updated":"2016-12-06 02:28:11.000000000","message":"Done","commit_id":"7e9e46e42cfc5a4fd028afdb02342794c4c6e24a"}]}
