)]}'
{"openstack_dashboard/test/integration_tests/tests/test_images.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"5032ace6f056c2f14facac5827d3ecc80e6d521c","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                images_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":183,"context_line":"            self.image_delete()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_edit_image_description(self):"},{"line_number":186,"context_line":"        \"\"\"tests that image description is editable"},{"line_number":187,"context_line":"        * creates image from locally downloaded file"},{"line_number":188,"context_line":"        * verifies the image appears in the images table as active"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_f8969b4a","line":185,"updated":"2016-04-26 14:34:45.000000000","message":"I suggest to merge both tests into one - test_edit_image, where both name and description are changed. That will make it a bit faster.","commit_id":"ec552919d9ada5e954804762d409900bd394518d"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"c432e061343d1d1e0b1ee3b7da31e89889cff891","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                images_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":183,"context_line":"            self.image_delete()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_edit_image_description(self):"},{"line_number":186,"context_line":"        \"\"\"tests that image description is editable"},{"line_number":187,"context_line":"        * creates image from locally downloaded file"},{"line_number":188,"context_line":"        * verifies the image appears in the images table as active"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_07813c8f","line":185,"in_reply_to":"1a122d0e_f8969b4a","updated":"2016-05-11 11:25:15.000000000","message":"fixed","commit_id":"ec552919d9ada5e954804762d409900bd394518d"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"fb40fda822c230dcb3a652a73e35659bea8fd433","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        * verifies the image does not appear in the table after deletion"},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":"        new_description_text \u003d helpers.gen_random_resource_name(\"description\")"},{"line_number":196,"context_line":"        with helpers.gen_temporary_file() as file_name:"},{"line_number":197,"context_line":"            images_page \u003d self.image_create(local_file\u003dfile_name)"},{"line_number":198,"context_line":"            images_page.edit_image(self.IMAGE_NAME,"},{"line_number":199,"context_line":"                                   description\u003dnew_description_text)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_381e53bb","line":196,"updated":"2016-04-26 14:39:07.000000000","message":"`file_path` or `file_name` ?","commit_id":"ec552919d9ada5e954804762d409900bd394518d"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"c432e061343d1d1e0b1ee3b7da31e89889cff891","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        * verifies the image does not appear in the table after deletion"},{"line_number":194,"context_line":"        \"\"\""},{"line_number":195,"context_line":"        new_description_text \u003d helpers.gen_random_resource_name(\"description\")"},{"line_number":196,"context_line":"        with helpers.gen_temporary_file() as file_name:"},{"line_number":197,"context_line":"            images_page \u003d self.image_create(local_file\u003dfile_name)"},{"line_number":198,"context_line":"            images_page.edit_image(self.IMAGE_NAME,"},{"line_number":199,"context_line":"                                   description\u003dnew_description_text)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_2769e0f9","line":196,"in_reply_to":"1a122d0e_381e53bb","updated":"2016-05-11 11:25:15.000000000","message":"Basically it is a \u0027name\u0027 attribute of NamedTemporaryFile https://docs.python.org/2/library/tempfile.html#tempfile.NamedTemporaryFile\n\nThe attribute is used in term of \u0027visible name in the file system\u0027. So I used file_name here and above.","commit_id":"ec552919d9ada5e954804762d409900bd394518d"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"5032ace6f056c2f14facac5827d3ecc80e6d521c","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            images_page \u003d self.image_create(local_file\u003dfile_name)"},{"line_number":198,"context_line":"            images_page.edit_image(self.IMAGE_NAME,"},{"line_number":199,"context_line":"                                   description\u003dnew_description_text)"},{"line_number":200,"context_line":"            self.assertTrue("},{"line_number":201,"context_line":"                images_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            results \u003d images_page.check_image_details(self.IMAGE_NAME,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7889eb25","line":200,"updated":"2016-04-26 14:34:45.000000000","message":"We need also to check for absence of messages.ERROR.","commit_id":"ec552919d9ada5e954804762d409900bd394518d"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"c432e061343d1d1e0b1ee3b7da31e89889cff891","unresolved":false,"context_lines":[{"line_number":197,"context_line":"            images_page \u003d self.image_create(local_file\u003dfile_name)"},{"line_number":198,"context_line":"            images_page.edit_image(self.IMAGE_NAME,"},{"line_number":199,"context_line":"                                   description\u003dnew_description_text)"},{"line_number":200,"context_line":"            self.assertTrue("},{"line_number":201,"context_line":"                images_page.find_message_and_dismiss(messages.SUCCESS))"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"            results \u003d images_page.check_image_details(self.IMAGE_NAME,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_a775d0cb","line":200,"in_reply_to":"1a122d0e_7889eb25","updated":"2016-05-11 11:25:15.000000000","message":"fixed","commit_id":"ec552919d9ada5e954804762d409900bd394518d"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"fb40fda822c230dcb3a652a73e35659bea8fd433","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            results \u003d images_page.check_image_details(self.IMAGE_NAME,"},{"line_number":204,"context_line":"                                                      {\u0027Description\u0027:"},{"line_number":205,"context_line":"                                                       new_description_text})"},{"line_number":206,"context_line":"            self.assertSequenceTrue(results)  # custom matcher"},{"line_number":207,"context_line":"            self.image_delete()"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def test_edit_image_name(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_7813abb8","line":206,"updated":"2016-04-26 14:39:07.000000000","message":"I suppose, not need to add comment `# custom matcher`. I used that in my example for you just to keep attention.","commit_id":"ec552919d9ada5e954804762d409900bd394518d"},{"author":{"_account_id":19282,"name":"Yury Tregubov","email":"ramentrum@gmail.com","username":"ytregubov"},"change_message_id":"c432e061343d1d1e0b1ee3b7da31e89889cff891","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            results \u003d images_page.check_image_details(self.IMAGE_NAME,"},{"line_number":204,"context_line":"                                                      {\u0027Description\u0027:"},{"line_number":205,"context_line":"                                                       new_description_text})"},{"line_number":206,"context_line":"            self.assertSequenceTrue(results)  # custom matcher"},{"line_number":207,"context_line":"            self.image_delete()"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def test_edit_image_name(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dab17558_e77b58bc","line":206,"in_reply_to":"1a122d0e_7813abb8","updated":"2016-05-11 11:25:15.000000000","message":"fixed here and above","commit_id":"ec552919d9ada5e954804762d409900bd394518d"}]}
