)]}'
{"openstack_dashboard/api/neutron.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f19b2a3995dc2f65e9e7626a91e5544c6e8196bc","unresolved":false,"context_lines":[{"line_number":951,"context_line":"    return [Router(r) for r in routers]"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"def router_list_l3_agent(request, l3_agent_id, **params):"},{"line_number":955,"context_line":"    routers \u003d neutronclient(request).\\"},{"line_number":956,"context_line":"        list_routers_on_l3_agent(l3_agent_id,"},{"line_number":957,"context_line":"                                 **params).get(\u0027routers\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_a705607a","line":954,"range":{"start_line":954,"start_character":4,"end_line":954,"end_character":24},"updated":"2016-05-04 02:22:17.000000000","message":"I prefer to \"router_list_on_l3_agent\".","commit_id":"87f19d9634094d99e7a635e0b957a6b0b0c496a3"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"e0602ec91138678f2730b11bc5be77157b5b88a5","unresolved":false,"context_lines":[{"line_number":951,"context_line":"    return [Router(r) for r in routers]"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":""},{"line_number":954,"context_line":"def router_list_l3_agent(request, l3_agent_id, **params):"},{"line_number":955,"context_line":"    routers \u003d neutronclient(request).\\"},{"line_number":956,"context_line":"        list_routers_on_l3_agent(l3_agent_id,"},{"line_number":957,"context_line":"                                 **params).get(\u0027routers\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"faac7902_726c189d","line":954,"range":{"start_line":954,"start_character":4,"end_line":954,"end_character":24},"in_reply_to":"1a122d0e_a705607a","updated":"2016-05-05 19:34:02.000000000","message":"Done","commit_id":"87f19d9634094d99e7a635e0b957a6b0b0c496a3"}],"openstack_dashboard/dashboards/admin/info/tables.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"34187fa760ba5795a9cf916c7cfdfc2ad0c43289","unresolved":false,"context_lines":[{"line_number":168,"context_line":"class NetworkL3AgentRoutersLinkAction(tables.LinkAction):"},{"line_number":169,"context_line":"    name \u003d \"l3_agent_router_link\""},{"line_number":170,"context_line":"    verbose_name \u003d _(\"View Routers\")"},{"line_number":171,"context_line":"    policy_rules \u003d ((\"volume\", \"volume_extension:volume_manage\"),)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def allowed(self, request, datum):"},{"line_number":174,"context_line":"        # Determine whether this action is allowed for the current request."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_187c7cea","line":171,"updated":"2016-04-22 19:48:58.000000000","message":"policy is wrong","commit_id":"4eb4bc05b85b865d8e4ce8770ba22071eca24960"}],"openstack_dashboard/dashboards/admin/routers/tests.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f19b2a3995dc2f65e9e7626a91e5544c6e8196bc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        agents \u003d self.agents.list()[1:]"},{"line_number":71,"context_line":"        api.neutron.agent_list("},{"line_number":72,"context_line":"            IsA(http.HttpRequest),"},{"line_number":73,"context_line":"            id\u003dagents[0].id).AndReturn(agents)"},{"line_number":74,"context_line":"        api.neutron.router_list_l3_agent("},{"line_number":75,"context_line":"            IsA(http.HttpRequest),"},{"line_number":76,"context_line":"            agents[0].id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a122d0e_07e6d4e7","line":73,"range":{"start_line":73,"start_character":39,"end_line":73,"end_character":45},"updated":"2016-05-04 02:22:17.000000000","message":"At now, self.agents contains two agents, so it works, but it is better to ensure \u0027agents\u0027 contains only one agent. My suggestion is to change [1:] at L.70 to [1:2].\n\nIn addition, you always use agents[0] except here.\nHow about change L.70 to:\n\n  agent \u003d self.agents.list()[1]\n\nand \u0027agents\u0027 here to:\n\n  [agent]","commit_id":"87f19d9634094d99e7a635e0b957a6b0b0c496a3"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"e0602ec91138678f2730b11bc5be77157b5b88a5","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        agents \u003d self.agents.list()[1:]"},{"line_number":71,"context_line":"        api.neutron.agent_list("},{"line_number":72,"context_line":"            IsA(http.HttpRequest),"},{"line_number":73,"context_line":"            id\u003dagents[0].id).AndReturn(agents)"},{"line_number":74,"context_line":"        api.neutron.router_list_l3_agent("},{"line_number":75,"context_line":"            IsA(http.HttpRequest),"},{"line_number":76,"context_line":"            agents[0].id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"faac7902_b2d20033","line":73,"range":{"start_line":73,"start_character":39,"end_line":73,"end_character":45},"in_reply_to":"1a122d0e_07e6d4e7","updated":"2016-05-05 19:34:02.000000000","message":"Done","commit_id":"87f19d9634094d99e7a635e0b957a6b0b0c496a3"}],"openstack_dashboard/dashboards/admin/routers/views.py":[{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"34187fa760ba5795a9cf916c7cfdfc2ad0c43289","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            agent_id \u003d self.kwargs[\u0027l3_agent_id\u0027]"},{"line_number":86,"context_line":"            agents \u003d api.neutron.agent_list(self.request, id\u003dagent_id)"},{"line_number":87,"context_line":"            if agents:"},{"line_number":88,"context_line":"                self.page_title \u003d \"Routers on %s\" % agents[0].host"},{"line_number":89,"context_line":"            routers \u003d api.neutron.router_list_l3_agent(self.request,"},{"line_number":90,"context_line":"                                                       agent_id,"},{"line_number":91,"context_line":"                                                       search_opts\u003dsearch_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_18159c9a","line":88,"updated":"2016-04-22 19:48:58.000000000","message":"needs i18n","commit_id":"4eb4bc05b85b865d8e4ce8770ba22071eca24960"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"34187fa760ba5795a9cf916c7cfdfc2ad0c43289","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            routers \u003d []"},{"line_number":94,"context_line":"            exceptions.handle(self.request,"},{"line_number":95,"context_line":"                              _(\u0027Unable to retrieve router list.\u0027))"},{"line_number":96,"context_line":"        if routers:"},{"line_number":97,"context_line":"            tenant_dict \u003d self._get_tenant_list()"},{"line_number":98,"context_line":"            ext_net_dict \u003d self._list_external_networks()"},{"line_number":99,"context_line":"            for r in routers:"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a122d0e_d81b24c9","line":96,"updated":"2016-04-22 19:48:58.000000000","message":"this block is the same with it\u0027s parent class - it might make sense to refactor this info reusable function / method","commit_id":"4eb4bc05b85b865d8e4ce8770ba22071eca24960"}]}
