)]}'
{"horizon/static/framework/widgets/wizard/wizard.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"062e846be565877cae36700562231fc25a04625a","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      \u003c/div\u003e"},{"line_number":49,"context_line":"    \u003c/div\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    \u003chelp-panel class\u003d\"wizard-help\"\u003e"},{"line_number":52,"context_line":"      \u003cng-include src\u003d\"step.helpUrl\""},{"line_number":53,"context_line":"                  ng-repeat\u003d\"step in steps\""},{"line_number":54,"context_line":"                  ng-show\u003d\"currentIndex\u003d\u003d\u003d$index\"\u003e\u003c/ng-include\u003e"}],"source_content_type":"text/html","patch_set":19,"id":"7aa08908_b3461e79","line":51,"updated":"2016-06-16 19:08:32.000000000","message":"when i click on the \u0027?\u0027 icon, it opens up the help panel in a very narrow area, then it expands to the width of the modal. Looks odd.","commit_id":"b9ce484efeb965fa3d6874cd718dc669a29eace8"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"26a4e31be490841a01c5f18db8dba707db3c52fc","unresolved":false,"context_lines":[{"line_number":48,"context_line":"      \u003c/div\u003e"},{"line_number":49,"context_line":"    \u003c/div\u003e"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    \u003chelp-panel class\u003d\"wizard-help\"\u003e"},{"line_number":52,"context_line":"      \u003cng-include src\u003d\"step.helpUrl\""},{"line_number":53,"context_line":"                  ng-repeat\u003d\"step in steps\""},{"line_number":54,"context_line":"                  ng-show\u003d\"currentIndex\u003d\u003d\u003d$index\"\u003e\u003c/ng-include\u003e"}],"source_content_type":"text/html","patch_set":19,"id":"7aa08908_51da1279","line":51,"in_reply_to":"7aa08908_b3461e79","updated":"2016-06-17 22:02:22.000000000","message":"Cindy,\n\nWhich modal do you see this one?  I\u0027m trying on the new LI and don\u0027t see it.","commit_id":"b9ce484efeb965fa3d6874cd718dc669a29eace8"}],"horizon/static/horizon/js/horizon.tables.js":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"dc6e67acc3ced9343363e1c06e9bf799d4fc9bf3","unresolved":false,"context_lines":[{"line_number":253,"context_line":"  var $data_display \u003d $closest_table.find(\u0027tr[data-display]\u0027);"},{"line_number":254,"context_line":"  if ($data_display.length \u003e 0) {"},{"line_number":255,"context_line":"    var $actions_div \u003d $action.closest(\"div\");"},{"line_number":256,"context_line":"    if ($actions_div.hasClass(\"table_actions\") || $actions_div.hasClass(\"table_actions_menu\")) {"},{"line_number":257,"context_line":"      // One or more checkboxes selected"},{"line_number":258,"context_line":"      $data_display.has(\".table-row-multi-select:checked\").each(function() {"},{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_e1776cd2","line":256,"range":{"start_line":256,"start_character":8,"end_line":256,"end_character":93},"updated":"2016-06-06 10:11:11.000000000","message":"This won\u0027t work for row actions, which delete something, because row action div doesn\u0027t have .table_actions class, thus name_array will be empty and material theme client_side template, which uses it, will look this way: http://imgur.com/iNCKU5C","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"51345f69013b678593e043ac3727b308f00b1af0","unresolved":false,"context_lines":[{"line_number":253,"context_line":"  var $data_display \u003d $closest_table.find(\u0027tr[data-display]\u0027);"},{"line_number":254,"context_line":"  if ($data_display.length \u003e 0) {"},{"line_number":255,"context_line":"    var $actions_div \u003d $action.closest(\"div\");"},{"line_number":256,"context_line":"    if ($actions_div.hasClass(\"table_actions\") || $actions_div.hasClass(\"table_actions_menu\")) {"},{"line_number":257,"context_line":"      // One or more checkboxes selected"},{"line_number":258,"context_line":"      $data_display.has(\".table-row-multi-select:checked\").each(function() {"},{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_b6575301","line":256,"range":{"start_line":256,"start_character":8,"end_line":256,"end_character":93},"in_reply_to":"7aa08908_40a0e59f","updated":"2016-06-06 15:32:19.000000000","message":"Diana, these were existing problems with the modals which were invisible until your patch exposed them :). Before the proposed change the material theme confirmation dialog in case of row action used `name_string` variable which was set on line 265, but now it uses `name_array` variable, which _isn\u0027t_ set in case you\u0027re deleting an instance with row action, hence the confirmation dialog misses instance name which is being deleted.","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"cb31a1182cdfe165bfc00321caa0743876eadb2b","unresolved":false,"context_lines":[{"line_number":253,"context_line":"  var $data_display \u003d $closest_table.find(\u0027tr[data-display]\u0027);"},{"line_number":254,"context_line":"  if ($data_display.length \u003e 0) {"},{"line_number":255,"context_line":"    var $actions_div \u003d $action.closest(\"div\");"},{"line_number":256,"context_line":"    if ($actions_div.hasClass(\"table_actions\") || $actions_div.hasClass(\"table_actions_menu\")) {"},{"line_number":257,"context_line":"      // One or more checkboxes selected"},{"line_number":258,"context_line":"      $data_display.has(\".table-row-multi-select:checked\").each(function() {"},{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_71a3ce9e","line":256,"range":{"start_line":256,"start_character":8,"end_line":256,"end_character":93},"in_reply_to":"7aa08908_70329e5f","updated":"2016-06-17 22:04:00.000000000","message":"Done","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"dbec51b383ea927e90fefd7a96d96de1d4c3ff41","unresolved":false,"context_lines":[{"line_number":253,"context_line":"  var $data_display \u003d $closest_table.find(\u0027tr[data-display]\u0027);"},{"line_number":254,"context_line":"  if ($data_display.length \u003e 0) {"},{"line_number":255,"context_line":"    var $actions_div \u003d $action.closest(\"div\");"},{"line_number":256,"context_line":"    if ($actions_div.hasClass(\"table_actions\") || $actions_div.hasClass(\"table_actions_menu\")) {"},{"line_number":257,"context_line":"      // One or more checkboxes selected"},{"line_number":258,"context_line":"      $data_display.has(\".table-row-multi-select:checked\").each(function() {"},{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_8b62653c","line":256,"range":{"start_line":256,"start_character":8,"end_line":256,"end_character":93},"in_reply_to":"7aa08908_70329e5f","updated":"2016-06-14 09:37:18.000000000","message":"Yes, but instead of marking several items and then deleting them with a batch action, try deleting a single item with row action - things will be different there.","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"2cd07c9212b55c5c9706aa3855b0ba05dfac3af4","unresolved":false,"context_lines":[{"line_number":253,"context_line":"  var $data_display \u003d $closest_table.find(\u0027tr[data-display]\u0027);"},{"line_number":254,"context_line":"  if ($data_display.length \u003e 0) {"},{"line_number":255,"context_line":"    var $actions_div \u003d $action.closest(\"div\");"},{"line_number":256,"context_line":"    if ($actions_div.hasClass(\"table_actions\") || $actions_div.hasClass(\"table_actions_menu\")) {"},{"line_number":257,"context_line":"      // One or more checkboxes selected"},{"line_number":258,"context_line":"      $data_display.has(\".table-row-multi-select:checked\").each(function() {"},{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_70329e5f","line":256,"range":{"start_line":256,"start_character":8,"end_line":256,"end_character":93},"in_reply_to":"7aa08908_b6575301","updated":"2016-06-13 20:46:29.000000000","message":"Slightly confused when I\u0027m trying to recreate this problem, this is what I see: https://i.imgur.com/2WlILeN.png\n\nYou were testing this on the instances table?","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"cc1a251c665a425584c4109a419632bda1d26b48","unresolved":false,"context_lines":[{"line_number":253,"context_line":"  var $data_display \u003d $closest_table.find(\u0027tr[data-display]\u0027);"},{"line_number":254,"context_line":"  if ($data_display.length \u003e 0) {"},{"line_number":255,"context_line":"    var $actions_div \u003d $action.closest(\"div\");"},{"line_number":256,"context_line":"    if ($actions_div.hasClass(\"table_actions\") || $actions_div.hasClass(\"table_actions_menu\")) {"},{"line_number":257,"context_line":"      // One or more checkboxes selected"},{"line_number":258,"context_line":"      $data_display.has(\".table-row-multi-select:checked\").each(function() {"},{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_40a0e59f","line":256,"range":{"start_line":256,"start_character":8,"end_line":256,"end_character":93},"in_reply_to":"7aa08908_e1776cd2","updated":"2016-06-06 15:11:55.000000000","message":"Timur, are these new problems introduced with this patch or existing problems with the modals?","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"dc6e67acc3ced9343363e1c06e9bf799d4fc9bf3","unresolved":false,"context_lines":[{"line_number":258,"context_line":"      $data_display.has(\".table-row-multi-select:checked\").each(function() {"},{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"},{"line_number":260,"context_line":"      });"},{"line_number":261,"context_line":"      name_array.join(\", \");"},{"line_number":262,"context_line":"      name_string \u003d name_array.toString();"},{"line_number":263,"context_line":"    } else {"},{"line_number":264,"context_line":"      // If no checkbox is selected"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_4cd83754","line":261,"range":{"start_line":261,"start_character":6,"end_line":261,"end_character":28},"updated":"2016-06-06 10:11:11.000000000","message":"This won\u0027t change anything unless you store the result of .join() somewhere. I guess if we had linter enabled for these files, it would catch this \u0027no-side-effect-statement\u0027.","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"cb31a1182cdfe165bfc00321caa0743876eadb2b","unresolved":false,"context_lines":[{"line_number":258,"context_line":"      $data_display.has(\".table-row-multi-select:checked\").each(function() {"},{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"},{"line_number":260,"context_line":"      });"},{"line_number":261,"context_line":"      name_array.join(\", \");"},{"line_number":262,"context_line":"      name_string \u003d name_array.toString();"},{"line_number":263,"context_line":"    } else {"},{"line_number":264,"context_line":"      // If no checkbox is selected"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_f18e9e25","line":261,"range":{"start_line":261,"start_character":6,"end_line":261,"end_character":28},"in_reply_to":"7aa08908_4cd83754","updated":"2016-06-17 22:04:00.000000000","message":"Done","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"cc1a251c665a425584c4109a419632bda1d26b48","unresolved":false,"context_lines":[{"line_number":258,"context_line":"      $data_display.has(\".table-row-multi-select:checked\").each(function() {"},{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"},{"line_number":260,"context_line":"      });"},{"line_number":261,"context_line":"      name_array.join(\", \");"},{"line_number":262,"context_line":"      name_string \u003d name_array.toString();"},{"line_number":263,"context_line":"    } else {"},{"line_number":264,"context_line":"      // If no checkbox is selected"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_608d2131","line":261,"range":{"start_line":261,"start_character":6,"end_line":261,"end_character":28},"in_reply_to":"7aa08908_4cd83754","updated":"2016-06-06 15:11:55.000000000","message":"Timur, are these new problems introduced with this patch or existing problems with the modals?","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8546b73f90f64a25ecbb1b2572cc844115025628","unresolved":false,"context_lines":[{"line_number":258,"context_line":"      $data_display.has(\".table-row-multi-select:checked\").each(function() {"},{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"},{"line_number":260,"context_line":"      });"},{"line_number":261,"context_line":"      name_array.join(\", \");"},{"line_number":262,"context_line":"      name_string \u003d name_array.toString();"},{"line_number":263,"context_line":"    } else {"},{"line_number":264,"context_line":"      // If no checkbox is selected"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_b1091d2f","line":261,"in_reply_to":"7aa08908_608d2131","updated":"2016-06-06 15:46:29.000000000","message":"That\u0027s definitely not the problem your patch introduced, just some old crappy legacy js. Wouldn\u0027t have even noticed unless I had hit the above issue.","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"dc6e67acc3ced9343363e1c06e9bf799d4fc9bf3","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"},{"line_number":260,"context_line":"      });"},{"line_number":261,"context_line":"      name_array.join(\", \");"},{"line_number":262,"context_line":"      name_string \u003d name_array.toString();"},{"line_number":263,"context_line":"    } else {"},{"line_number":264,"context_line":"      // If no checkbox is selected"},{"line_number":265,"context_line":"      name_string \u003d \" \\\"\" + $action.closest(\"tr\").attr(\"data-display\") + \"\\\"\";"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_6c889323","line":262,"updated":"2016-06-06 10:11:11.000000000","message":"An this string makes the previous one redundant. Yet, I would prefer this to be\n\n  name_string \u003d name_array.join(\", \");\n\nsince it\u0027s more explicit about delimiter.","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"cb31a1182cdfe165bfc00321caa0743876eadb2b","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"},{"line_number":260,"context_line":"      });"},{"line_number":261,"context_line":"      name_array.join(\", \");"},{"line_number":262,"context_line":"      name_string \u003d name_array.toString();"},{"line_number":263,"context_line":"    } else {"},{"line_number":264,"context_line":"      // If no checkbox is selected"},{"line_number":265,"context_line":"      name_string \u003d \" \\\"\" + $action.closest(\"tr\").attr(\"data-display\") + \"\\\"\";"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_d193a24d","line":262,"in_reply_to":"7aa08908_6c889323","updated":"2016-06-17 22:04:00.000000000","message":"Done","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"cc1a251c665a425584c4109a419632bda1d26b48","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"},{"line_number":260,"context_line":"      });"},{"line_number":261,"context_line":"      name_array.join(\", \");"},{"line_number":262,"context_line":"      name_string \u003d name_array.toString();"},{"line_number":263,"context_line":"    } else {"},{"line_number":264,"context_line":"      // If no checkbox is selected"},{"line_number":265,"context_line":"      name_string \u003d \" \\\"\" + $action.closest(\"tr\").attr(\"data-display\") + \"\\\"\";"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_c0821500","line":262,"in_reply_to":"7aa08908_6c889323","updated":"2016-06-06 15:11:55.000000000","message":"Timur, are these new problems introduced with this patch or existing problems with the modals?","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"8546b73f90f64a25ecbb1b2572cc844115025628","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        name_array.push(\" \\\"\" + $(this).attr(\"data-display\") + \"\\\"\");"},{"line_number":260,"context_line":"      });"},{"line_number":261,"context_line":"      name_array.join(\", \");"},{"line_number":262,"context_line":"      name_string \u003d name_array.toString();"},{"line_number":263,"context_line":"    } else {"},{"line_number":264,"context_line":"      // If no checkbox is selected"},{"line_number":265,"context_line":"      name_string \u003d \" \\\"\" + $action.closest(\"tr\").attr(\"data-display\") + \"\\\"\";"}],"source_content_type":"text/javascript","patch_set":17,"id":"7aa08908_f113a55a","line":262,"in_reply_to":"7aa08908_c0821500","updated":"2016-06-06 15:46:29.000000000","message":"Same as above.","commit_id":"039e9b5b6b2484aca97557601d0ee3413edf81f7"}],"horizon/templates/horizon/client_side/_confirm.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"062e846be565877cae36700562231fc25a04625a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  \u003cdiv class\u003d\"confirm-wrapper\"\u003e"},{"line_number":8,"context_line":"    \u003cspan class\u003d\"confirm-list\"\u003e{% trans \u0027You have selected:\u0027 %} [[selection]]. \u003c/span\u003e"},{"line_number":9,"context_line":"    \u003cspan class\u003d\"confirm-text\"\u003e{% trans \u0027Please confirm your selection.\u0027%} \u003c/span\u003e"},{"line_number":10,"context_line":"    \u003cspan class\u003d\"confirm-help\"\u003e[[help]]\u003c/span\u003e"},{"line_number":11,"context_line":"  \u003c/div\u003e"},{"line_number":12,"context_line":"{% endjstemplate %}{% endspaceless %}{% endblock %}"}],"source_content_type":"text/html","patch_set":19,"id":"7aa08908_9e17a953","line":10,"updated":"2016-06-16 19:08:32.000000000","message":"is there a reason we can\u0027t just use the new material confirm template?","commit_id":"b9ce484efeb965fa3d6874cd718dc669a29eace8"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"26a4e31be490841a01c5f18db8dba707db3c52fc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"  \u003cdiv class\u003d\"confirm-wrapper\"\u003e"},{"line_number":8,"context_line":"    \u003cspan class\u003d\"confirm-list\"\u003e{% trans \u0027You have selected:\u0027 %} [[selection]]. \u003c/span\u003e"},{"line_number":9,"context_line":"    \u003cspan class\u003d\"confirm-text\"\u003e{% trans \u0027Please confirm your selection.\u0027%} \u003c/span\u003e"},{"line_number":10,"context_line":"    \u003cspan class\u003d\"confirm-help\"\u003e[[help]]\u003c/span\u003e"},{"line_number":11,"context_line":"  \u003c/div\u003e"},{"line_number":12,"context_line":"{% endjstemplate %}{% endspaceless %}{% endblock %}"}],"source_content_type":"text/html","patch_set":19,"id":"7aa08908_31c6669c","line":10,"in_reply_to":"7aa08908_9e17a953","updated":"2016-06-17 22:02:22.000000000","message":"No reason. Its nice to showcase how it can be changed through a theme.  If this modal is found to be preferable, I can pull it in as the default confirmation though.","commit_id":"b9ce484efeb965fa3d6874cd718dc669a29eace8"}],"openstack_dashboard/contrib/developer/static/dashboard/developer/theme-preview/theme-preview.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"062e846be565877cae36700562231fc25a04625a","unresolved":false,"context_lines":[{"line_number":1324,"context_line":"  \u003c/div\u003e"},{"line_number":1325,"context_line":"  \u003cdiv class\u003d\"row\"\u003e"},{"line_number":1326,"context_line":"    \u003cdiv class\u003d\"col-lg-12\"\u003e"},{"line_number":1327,"context_line":"      \u003ch2 translate\u003eModals\u003c/h2\u003e"},{"line_number":1328,"context_line":"    \u003c/div\u003e"},{"line_number":1329,"context_line":"  \u003c/div\u003e"},{"line_number":1330,"context_line":"  \u003cdiv class\u003d\"row\"\u003e"}],"source_content_type":"text/html","patch_set":19,"id":"7aa08908_f976c73d","line":1327,"updated":"2016-06-16 19:08:32.000000000","message":"nit: maybe show case confirm modal too?","commit_id":"b9ce484efeb965fa3d6874cd718dc669a29eace8"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"26a4e31be490841a01c5f18db8dba707db3c52fc","unresolved":false,"context_lines":[{"line_number":1324,"context_line":"  \u003c/div\u003e"},{"line_number":1325,"context_line":"  \u003cdiv class\u003d\"row\"\u003e"},{"line_number":1326,"context_line":"    \u003cdiv class\u003d\"col-lg-12\"\u003e"},{"line_number":1327,"context_line":"      \u003ch2 translate\u003eModals\u003c/h2\u003e"},{"line_number":1328,"context_line":"    \u003c/div\u003e"},{"line_number":1329,"context_line":"  \u003c/div\u003e"},{"line_number":1330,"context_line":"  \u003cdiv class\u003d\"row\"\u003e"}],"source_content_type":"text/html","patch_set":19,"id":"7aa08908_7172ae7d","line":1327,"in_reply_to":"7aa08908_f976c73d","updated":"2016-06-17 22:02:22.000000000","message":"I haven\u0027t been showing anything that is entirely horizon specific except for some of the smaller themable form elements.  Was hoping to eventually have a similar preview page for horizon specifics (workflows, table actions, etc) ... eventually.","commit_id":"b9ce484efeb965fa3d6874cd718dc669a29eace8"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"062e846be565877cae36700562231fc25a04625a","unresolved":false,"context_lines":[{"line_number":1426,"context_line":"    \u003cdiv class\u003d\"col-lg-12\"\u003e"},{"line_number":1427,"context_line":"      \u003cdiv class\u003d\"bs-component\"\u003e"},{"line_number":1428,"context_line":"        \u003cdiv class\u003d\"modal\"\u003e"},{"line_number":1429,"context_line":"          \u003cdiv class\u003d\"modal-dialog modal-xl\"\u003e"},{"line_number":1430,"context_line":"            \u003cdiv class\u003d\"modal-content\"\u003e"},{"line_number":1431,"context_line":"              \u003cdiv class\u003d\"modal-header\"\u003e"},{"line_number":1432,"context_line":"                \u003cbutton type\u003d\"button\" class\u003d\"close\" data-dismiss\u003d\"modal\" aria-hidden\u003d\"true\"\u003e"}],"source_content_type":"text/html","patch_set":19,"id":"7aa08908_1395723f","line":1429,"updated":"2016-06-16 19:08:32.000000000","message":"seems to get cut off even though i\u0027m on a huge screen...\n\nthe source code text uses \"modal title\" for all the text (title, content, footer buttons) - this seems to be the case for Panel\u0027s source code too. Is this intended behavior? - That it doesn\u0027t match the text that is displayed?","commit_id":"b9ce484efeb965fa3d6874cd718dc669a29eace8"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"26a4e31be490841a01c5f18db8dba707db3c52fc","unresolved":false,"context_lines":[{"line_number":1426,"context_line":"    \u003cdiv class\u003d\"col-lg-12\"\u003e"},{"line_number":1427,"context_line":"      \u003cdiv class\u003d\"bs-component\"\u003e"},{"line_number":1428,"context_line":"        \u003cdiv class\u003d\"modal\"\u003e"},{"line_number":1429,"context_line":"          \u003cdiv class\u003d\"modal-dialog modal-xl\"\u003e"},{"line_number":1430,"context_line":"            \u003cdiv class\u003d\"modal-content\"\u003e"},{"line_number":1431,"context_line":"              \u003cdiv class\u003d\"modal-header\"\u003e"},{"line_number":1432,"context_line":"                \u003cbutton type\u003d\"button\" class\u003d\"close\" data-dismiss\u003d\"modal\" aria-hidden\u003d\"true\"\u003e"}],"source_content_type":"text/html","patch_set":19,"id":"7aa08908_9198fa76","line":1429,"in_reply_to":"7aa08908_1395723f","updated":"2016-06-17 22:02:22.000000000","message":"Yes, the modal-xl will get cut off in the preview page, because it takes up a good portion of the screen (using view width (vw) of 95%).  When used, it won\u0027t show this way, as it will be an overlay on the page.\n\nUpdated the Modal Titles.","commit_id":"b9ce484efeb965fa3d6874cd718dc669a29eace8"}],"releasenotes/notes/theme-modal-sizes-924e5835efe9bb79.yaml":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"062e846be565877cae36700562231fc25a04625a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - Modal sizes now inherit their value from theme"},{"line_number":7,"context_line":"    variables.  Two additional sizes are available now"},{"line_number":8,"context_line":"    for use in Horizon, extra to the standard 3 sizes"},{"line_number":9,"context_line":"    of Boostrap Modals, modal-xs and modal-xl."},{"line_number":10,"context_line":"deprecations:"},{"line_number":11,"context_line":"  - Fullscreen Modals have been deprecated in favor of"},{"line_number":12,"context_line":"    modal-xl.  Currently, it is set to 95% of the viewable"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7aa08908_0057d9ca","line":9,"updated":"2016-06-16 19:08:32.000000000","message":"in addition to the standard 3 sizes of Bootstrap* Modals","commit_id":"b9ce484efeb965fa3d6874cd718dc669a29eace8"},{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"26a4e31be490841a01c5f18db8dba707db3c52fc","unresolved":false,"context_lines":[{"line_number":6,"context_line":"  - Modal sizes now inherit their value from theme"},{"line_number":7,"context_line":"    variables.  Two additional sizes are available now"},{"line_number":8,"context_line":"    for use in Horizon, extra to the standard 3 sizes"},{"line_number":9,"context_line":"    of Boostrap Modals, modal-xs and modal-xl."},{"line_number":10,"context_line":"deprecations:"},{"line_number":11,"context_line":"  - Fullscreen Modals have been deprecated in favor of"},{"line_number":12,"context_line":"    modal-xl.  Currently, it is set to 95% of the viewable"}],"source_content_type":"text/x-yaml","patch_set":19,"id":"7aa08908_f104dec6","line":9,"in_reply_to":"7aa08908_0057d9ca","updated":"2016-06-17 22:02:22.000000000","message":"Done","commit_id":"b9ce484efeb965fa3d6874cd718dc669a29eace8"}]}
