)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"21afa20287dabe94f297f3552abd1b6ad7e0e229","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergei Chipiga \u003cschipiga@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-25 19:06:35 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Wait for user menu items visible before actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I312e63eafa7a92ce05028de3505f37547a0bc139"},{"line_number":10,"context_line":"Closes-Bug: #1574734"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_453891a0","line":7,"range":{"start_line":7,"start_character":40,"end_line":7,"end_character":47},"updated":"2016-04-26 11:05:59.000000000","message":"clicking them","commit_id":"8d44bf6daef220f0059ed17771d211cbb701a3c4"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"21afa20287dabe94f297f3552abd1b6ad7e0e229","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergei Chipiga \u003cschipiga@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-04-25 19:06:35 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Wait for user menu items visible before actions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I312e63eafa7a92ce05028de3505f37547a0bc139"},{"line_number":10,"context_line":"Closes-Bug: #1574734"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a122d0e_a5c24583","line":7,"range":{"start_line":7,"start_character":25,"end_line":7,"end_character":32},"updated":"2016-04-26 11:05:59.000000000","message":"to become visible","commit_id":"8d44bf6daef220f0059ed17771d211cbb701a3c4"}],"openstack_dashboard/test/integration_tests/regions/menus.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"21afa20287dabe94f297f3552abd1b6ad7e0e229","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\"Opens menu by clicking on the first child of the source element.\"\"\""},{"line_number":200,"context_line":"        if self.is_open() is False:"},{"line_number":201,"context_line":"            self._get_element(*self._menu_first_child_locator).click()"},{"line_number":202,"context_line":"            self._wait_till_element_visible(self._menu_container_locator)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class UserDropDownMenuRegion(DropDownMenuRegion):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_25d6354f","line":202,"updated":"2016-04-26 11:05:59.000000000","message":"I\u0027m confused by the ordering here. The intention was to first check if dropdown menu is visible and then click its element, right? But here I\u0027m seeing the opposite.","commit_id":"8d44bf6daef220f0059ed17771d211cbb701a3c4"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"1db811743ffcb0c2b1ae7372e8ab9a1d3a281a9a","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\"Opens menu by clicking on the first child of the source element.\"\"\""},{"line_number":200,"context_line":"        if self.is_open() is False:"},{"line_number":201,"context_line":"            self._get_element(*self._menu_first_child_locator).click()"},{"line_number":202,"context_line":"            self._wait_till_element_visible(self._menu_container_locator)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class UserDropDownMenuRegion(DropDownMenuRegion):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_60d13b57","line":202,"in_reply_to":"1a122d0e_25bc75ba","updated":"2016-04-26 11:45:21.000000000","message":"Thanks, now it makes sense to me.","commit_id":"8d44bf6daef220f0059ed17771d211cbb701a3c4"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"91193a4074488ff3e8c8fff807eb9049878f02c6","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\"Opens menu by clicking on the first child of the source element.\"\"\""},{"line_number":200,"context_line":"        if self.is_open() is False:"},{"line_number":201,"context_line":"            self._get_element(*self._menu_first_child_locator).click()"},{"line_number":202,"context_line":"            self._wait_till_element_visible(self._menu_container_locator)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class UserDropDownMenuRegion(DropDownMenuRegion):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_25bc75ba","line":202,"in_reply_to":"1a122d0e_25d6354f","updated":"2016-04-26 11:21:12.000000000","message":"I think you are confused due to locator name \"_menu_first_child_locator\". Let me show what happens IRL.\n\n_menu_first_child_locator is a locator of top-right corner link to open dropdown settings. When you click this link, the dropdown menu is opened. And in my patch I suggest to wait while dropdown menu will be really opened before to exit from open(self).\n\nIn horizon _menu_first_child_locator is visible always and its clicking leads to dropdown menu opening. _menu_first_child_locator and _menu_container_locator are in the same DOM-level.","commit_id":"8d44bf6daef220f0059ed17771d211cbb701a3c4"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"359362f1790ce98421b22492e4351b7be8c809c7","unresolved":false,"context_lines":[{"line_number":199,"context_line":"        \"\"\"Opens menu by clicking on the first child of the source element.\"\"\""},{"line_number":200,"context_line":"        if self.is_open() is False:"},{"line_number":201,"context_line":"            self._get_element(*self._menu_first_child_locator).click()"},{"line_number":202,"context_line":"            self._wait_till_element_visible(self._menu_container_locator)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"class UserDropDownMenuRegion(DropDownMenuRegion):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_96f01dff","line":202,"in_reply_to":"1a122d0e_60d13b57","updated":"2016-04-26 12:55:08.000000000","message":"any other comments leading to negative score?","commit_id":"8d44bf6daef220f0059ed17771d211cbb701a3c4"}]}
