)]}'
{"doc/source/ref/tables.rst":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  .. seealso::"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    For a usage information, tips \u0026 tricks and more examples check out the :doc:`DataTables Topic"},{"line_number":16,"context_line":"    Guide \u003c/topics/tables\u003e`."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DataTable"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9BM%3D","line":15,"updated":"2013-08-09 13:15:30.000000000","message":"\"For usage\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"  .. seealso::"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"    For a usage information, tips \u0026 tricks and more examples check out the :doc:`DataTables Topic"},{"line_number":16,"context_line":"    Guide \u003c/topics/tables\u003e`."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DataTable"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F9%2Fc%3D","line":15,"in_reply_to":"AAAAQn%2F%2B9BM%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"}],"doc/source/topics/tables.rst":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Table cells can be easily upgraded with in-line editing. With use of"},{"line_number":135,"context_line":"django.form.Field, we are able to run validations of the field and correctly"},{"line_number":136,"context_line":"parsing the data. The updating process is fully encapsulated into table"},{"line_number":137,"context_line":"functionality, communication with server goes through AJAX in JSON format."},{"line_number":138,"context_line":"The javacript wrapper for inline editing allows each table cell that have"},{"line_number":139,"context_line":"in-line editing available to:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9Dk%3D","line":136,"updated":"2013-08-09 13:15:30.000000000","message":"\"and correctly parse\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":133,"context_line":""},{"line_number":134,"context_line":"Table cells can be easily upgraded with in-line editing. With use of"},{"line_number":135,"context_line":"django.form.Field, we are able to run validations of the field and correctly"},{"line_number":136,"context_line":"parsing the data. The updating process is fully encapsulated into table"},{"line_number":137,"context_line":"functionality, communication with server goes through AJAX in JSON format."},{"line_number":138,"context_line":"The javacript wrapper for inline editing allows each table cell that have"},{"line_number":139,"context_line":"in-line editing available to:"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F9%2FA%3D","line":136,"in_reply_to":"AAAAQn%2F%2B9Dk%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Table cells can be easily upgraded with in-line editing. With use of"},{"line_number":135,"context_line":"django.form.Field, we are able to run validations of the field and correctly"},{"line_number":136,"context_line":"parsing the data. The updating process is fully encapsulated into table"},{"line_number":137,"context_line":"functionality, communication with server goes through AJAX in JSON format."},{"line_number":138,"context_line":"The javacript wrapper for inline editing allows each table cell that have"},{"line_number":139,"context_line":"in-line editing available to:"},{"line_number":140,"context_line":"  #. Refresh itself with new data from the server."}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9Dg%3D","line":137,"updated":"2013-08-09 13:15:30.000000000","message":"\"with the server\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":134,"context_line":"Table cells can be easily upgraded with in-line editing. With use of"},{"line_number":135,"context_line":"django.form.Field, we are able to run validations of the field and correctly"},{"line_number":136,"context_line":"parsing the data. The updating process is fully encapsulated into table"},{"line_number":137,"context_line":"functionality, communication with server goes through AJAX in JSON format."},{"line_number":138,"context_line":"The javacript wrapper for inline editing allows each table cell that have"},{"line_number":139,"context_line":"in-line editing available to:"},{"line_number":140,"context_line":"  #. Refresh itself with new data from the server."}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F9%2B8%3D","line":137,"in_reply_to":"AAAAQn%2F%2B9Dg%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":135,"context_line":"django.form.Field, we are able to run validations of the field and correctly"},{"line_number":136,"context_line":"parsing the data. The updating process is fully encapsulated into table"},{"line_number":137,"context_line":"functionality, communication with server goes through AJAX in JSON format."},{"line_number":138,"context_line":"The javacript wrapper for inline editing allows each table cell that have"},{"line_number":139,"context_line":"in-line editing available to:"},{"line_number":140,"context_line":"  #. Refresh itself with new data from the server."},{"line_number":141,"context_line":"  #. Display in edit mod."}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9Dc%3D","line":138,"updated":"2013-08-09 13:15:30.000000000","message":"\"each table cell that has\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":135,"context_line":"django.form.Field, we are able to run validations of the field and correctly"},{"line_number":136,"context_line":"parsing the data. The updating process is fully encapsulated into table"},{"line_number":137,"context_line":"functionality, communication with server goes through AJAX in JSON format."},{"line_number":138,"context_line":"The javacript wrapper for inline editing allows each table cell that have"},{"line_number":139,"context_line":"in-line editing available to:"},{"line_number":140,"context_line":"  #. Refresh itself with new data from the server."},{"line_number":141,"context_line":"  #. Display in edit mod."}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F9%2Bs%3D","line":138,"in_reply_to":"AAAAQn%2F%2B9Dc%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":139,"context_line":"in-line editing available to:"},{"line_number":140,"context_line":"  #. Refresh itself with new data from the server."},{"line_number":141,"context_line":"  #. Display in edit mod."},{"line_number":142,"context_line":"  #. Sent changed data to server."},{"line_number":143,"context_line":"  #. Display validation error/"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"There are basically 3 things needed to be defined in table order to have the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9DY%3D","line":142,"updated":"2013-08-09 13:15:30.000000000","message":"\"Send\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":139,"context_line":"in-line editing available to:"},{"line_number":140,"context_line":"  #. Refresh itself with new data from the server."},{"line_number":141,"context_line":"  #. Display in edit mod."},{"line_number":142,"context_line":"  #. Sent changed data to server."},{"line_number":143,"context_line":"  #. Display validation error/"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"There are basically 3 things needed to be defined in table order to have the"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F9%2Bo%3D","line":142,"in_reply_to":"AAAAQn%2F%2B9DY%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  #. Refresh itself with new data from the server."},{"line_number":141,"context_line":"  #. Display in edit mod."},{"line_number":142,"context_line":"  #. Sent changed data to server."},{"line_number":143,"context_line":"  #. Display validation error/"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"There are basically 3 things needed to be defined in table order to have the"},{"line_number":146,"context_line":"in-line editing."}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9DU%3D","line":143,"updated":"2013-08-09 13:15:30.000000000","message":"\"/\" should be a dot? Probably error should be \"errors\" too.","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":140,"context_line":"  #. Refresh itself with new data from the server."},{"line_number":141,"context_line":"  #. Display in edit mod."},{"line_number":142,"context_line":"  #. Sent changed data to server."},{"line_number":143,"context_line":"  #. Display validation error/"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"There are basically 3 things needed to be defined in table order to have the"},{"line_number":146,"context_line":"in-line editing."}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F9%2Bc%3D","line":143,"in_reply_to":"AAAAQn%2F%2B9DU%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  #. Sent changed data to server."},{"line_number":143,"context_line":"  #. Display validation error/"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"There are basically 3 things needed to be defined in table order to have the"},{"line_number":146,"context_line":"in-line editing."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Fetching the row data"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9DA%3D","line":145,"updated":"2013-08-09 13:15:30.000000000","message":"\"3 things that need to be defined in the table in order to enable in-line editing\"?","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":142,"context_line":"  #. Sent changed data to server."},{"line_number":143,"context_line":"  #. Display validation error/"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"There are basically 3 things needed to be defined in table order to have the"},{"line_number":146,"context_line":"in-line editing."},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"Fetching the row data"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F9%2BQ%3D","line":145,"in_reply_to":"AAAAQn%2F%2B9DA%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":148,"context_line":"Fetching the row data"},{"line_number":149,"context_line":"---------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Defining an ``get_data`` method in class inherited from ``tables.Row``."},{"line_number":152,"context_line":"This method takes care of fetching the row data. This class have to be then"},{"line_number":153,"context_line":"defined in table Meta class as ``row_class \u003d UpdateRow``."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9C0%3D","line":151,"updated":"2013-08-09 13:15:30.000000000","message":"\"in a class\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":148,"context_line":"Fetching the row data"},{"line_number":149,"context_line":"---------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Defining an ``get_data`` method in class inherited from ``tables.Row``."},{"line_number":152,"context_line":"This method takes care of fetching the row data. This class have to be then"},{"line_number":153,"context_line":"defined in table Meta class as ``row_class \u003d UpdateRow``."},{"line_number":154,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F9%2BA%3D","line":151,"in_reply_to":"AAAAQn%2F%2B9C0%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":149,"context_line":"---------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Defining an ``get_data`` method in class inherited from ``tables.Row``."},{"line_number":152,"context_line":"This method takes care of fetching the row data. This class have to be then"},{"line_number":153,"context_line":"defined in table Meta class as ``row_class \u003d UpdateRow``."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Example::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9Cw%3D","line":152,"updated":"2013-08-09 13:15:30.000000000","message":"\"has to be\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":149,"context_line":"---------------------"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Defining an ``get_data`` method in class inherited from ``tables.Row``."},{"line_number":152,"context_line":"This method takes care of fetching the row data. This class have to be then"},{"line_number":153,"context_line":"defined in table Meta class as ``row_class \u003d UpdateRow``."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Example::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F998%3D","line":152,"in_reply_to":"AAAAQn%2F%2B9Cw%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Defining an ``get_data`` method in class inherited from ``tables.Row``."},{"line_number":152,"context_line":"This method takes care of fetching the row data. This class have to be then"},{"line_number":153,"context_line":"defined in table Meta class as ``row_class \u003d UpdateRow``."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Example::"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9Cs%3D","line":153,"updated":"2013-08-09 13:15:30.000000000","message":"\"in the table\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"Defining an ``get_data`` method in class inherited from ``tables.Row``."},{"line_number":152,"context_line":"This method takes care of fetching the row data. This class have to be then"},{"line_number":153,"context_line":"defined in table Meta class as ``row_class \u003d UpdateRow``."},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"Example::"},{"line_number":156,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F99w%3D","line":153,"in_reply_to":"AAAAQn%2F%2B9Cs%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Updating changed cell data"},{"line_number":168,"context_line":"--------------------------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Defining an ``update_cell`` method in class inherited from"},{"line_number":171,"context_line":"``tables.UpdateAction``. This method takes care of saving the data of the"},{"line_number":172,"context_line":"table cell. There can be one class for every cell thanks to ``cell_name``"},{"line_number":173,"context_line":"parameter. This class is then defined in tables column as"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9CY%3D","line":170,"updated":"2013-08-09 13:15:30.000000000","message":"\"Define\" \"in the class\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":167,"context_line":"Updating changed cell data"},{"line_number":168,"context_line":"--------------------------"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Defining an ``update_cell`` method in class inherited from"},{"line_number":171,"context_line":"``tables.UpdateAction``. This method takes care of saving the data of the"},{"line_number":172,"context_line":"table cell. There can be one class for every cell thanks to ``cell_name``"},{"line_number":173,"context_line":"parameter. This class is then defined in tables column as"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F99s%3D","line":170,"in_reply_to":"AAAAQn%2F%2B9CY%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Defining an ``update_cell`` method in class inherited from"},{"line_number":171,"context_line":"``tables.UpdateAction``. This method takes care of saving the data of the"},{"line_number":172,"context_line":"table cell. There can be one class for every cell thanks to ``cell_name``"},{"line_number":173,"context_line":"parameter. This class is then defined in tables column as"},{"line_number":174,"context_line":"``update_action\u003dUpdateCell``, so each column can have it\u0027s own updating"},{"line_number":175,"context_line":"method."}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9CM%3D","line":172,"updated":"2013-08-09 13:15:30.000000000","message":"\"thanks to the\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"Defining an ``update_cell`` method in class inherited from"},{"line_number":171,"context_line":"``tables.UpdateAction``. This method takes care of saving the data of the"},{"line_number":172,"context_line":"table cell. There can be one class for every cell thanks to ``cell_name``"},{"line_number":173,"context_line":"parameter. This class is then defined in tables column as"},{"line_number":174,"context_line":"``update_action\u003dUpdateCell``, so each column can have it\u0027s own updating"},{"line_number":175,"context_line":"method."}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F99g%3D","line":172,"in_reply_to":"AAAAQn%2F%2B9CM%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":171,"context_line":"``tables.UpdateAction``. This method takes care of saving the data of the"},{"line_number":172,"context_line":"table cell. There can be one class for every cell thanks to ``cell_name``"},{"line_number":173,"context_line":"parameter. This class is then defined in tables column as"},{"line_number":174,"context_line":"``update_action\u003dUpdateCell``, so each column can have it\u0027s own updating"},{"line_number":175,"context_line":"method."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Example::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9CE%3D","line":174,"updated":"2013-08-09 13:15:30.000000000","message":"\"its own\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":171,"context_line":"``tables.UpdateAction``. This method takes care of saving the data of the"},{"line_number":172,"context_line":"table cell. There can be one class for every cell thanks to ``cell_name``"},{"line_number":173,"context_line":"parameter. This class is then defined in tables column as"},{"line_number":174,"context_line":"``update_action\u003dUpdateCell``, so each column can have it\u0027s own updating"},{"line_number":175,"context_line":"method."},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"Example::"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F99c%3D","line":174,"in_reply_to":"AAAAQn%2F%2B9CE%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":215,"context_line":"------------------------------------------------------------------------"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Form field should be django.form.Field instance, so we can use django"},{"line_number":218,"context_line":"validations and parsing of the values send by POST (in example validation"},{"line_number":219,"context_line":"required\u003dTrue and correct parsing of the checkbox value from the POST data)."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Form field can be also django.form.Widget class, if we need to just display"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9B4%3D","line":218,"updated":"2013-08-09 13:15:30.000000000","message":"\"sent\"\n\"in the example\"","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":215,"context_line":"------------------------------------------------------------------------"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"Form field should be django.form.Field instance, so we can use django"},{"line_number":218,"context_line":"validations and parsing of the values send by POST (in example validation"},{"line_number":219,"context_line":"required\u003dTrue and correct parsing of the checkbox value from the POST data)."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Form field can be also django.form.Widget class, if we need to just display"}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F99A%3D","line":218,"in_reply_to":"AAAAQn%2F%2B9B4%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":219,"context_line":"required\u003dTrue and correct parsing of the checkbox value from the POST data)."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Form field can be also django.form.Widget class, if we need to just display"},{"line_number":222,"context_line":"the form widget in the table and we don\u0027t need Field functionality."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Then connecting UpdateRow and UpdateCell classes to the table."},{"line_number":225,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQn%2F%2B9Bo%3D","line":222,"updated":"2013-08-09 13:15:30.000000000","message":"It\u0027d be neat to have class names between ``double backquotes`` in these paragraphs too, to be consistent with the previous ones.","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":219,"context_line":"required\u003dTrue and correct parsing of the checkbox value from the POST data)."},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"Form field can be also django.form.Widget class, if we need to just display"},{"line_number":222,"context_line":"the form widget in the table and we don\u0027t need Field functionality."},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"Then connecting UpdateRow and UpdateCell classes to the table."},{"line_number":225,"context_line":""}],"source_content_type":"text/x-rst","patch_set":13,"id":"AAAAQ3%2F%2F98c%3D","line":222,"in_reply_to":"AAAAQn%2F%2B9Bo%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"}],"horizon/static/horizon/js/horizon.tables_inline_edit.js":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    self.form_element \u003d self.td_element.find(\"input,textarea\");"},{"line_number":6,"context_line":"    self.url \u003d td_element.data(\u0027update-url\u0027);"},{"line_number":7,"context_line":"    self.inline_edit_mod \u003d false;"},{"line_number":8,"context_line":"    self.successfull_update \u003d false;"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    self.refresh \u003d function () {"},{"line_number":11,"context_line":"      horizon.inline_edit._request \u003d $.ajax({"}],"source_content_type":"text/javascript","patch_set":13,"id":"AAAAQn%2F%2B9BA%3D","line":8,"updated":"2013-08-09 13:15:30.000000000","message":"This variable should be \"successful_update\" (and is referenced that way later on)","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    self.form_element \u003d self.td_element.find(\"input,textarea\");"},{"line_number":6,"context_line":"    self.url \u003d td_element.data(\u0027update-url\u0027);"},{"line_number":7,"context_line":"    self.inline_edit_mod \u003d false;"},{"line_number":8,"context_line":"    self.successfull_update \u003d false;"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    self.refresh \u003d function () {"},{"line_number":11,"context_line":"      horizon.inline_edit._request \u003d $.ajax({"}],"source_content_type":"text/javascript","patch_set":13,"id":"AAAAQ3%2F%2F97c%3D","line":8,"in_reply_to":"AAAAQn%2F%2B9BA%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        url: self.url,"},{"line_number":13,"context_line":"        data: {\u0027inline_edit_mod\u0027: self.inline_edit_mod},"},{"line_number":14,"context_line":"        beforeSend: function () {"},{"line_number":15,"context_line":"          //horizon.inline_edit.modal_spinner(gettext(\"Loading\"));"},{"line_number":16,"context_line":"        },"},{"line_number":17,"context_line":"        complete: function () {"},{"line_number":18,"context_line":"          // Clear the global storage;"}],"source_content_type":"text/javascript","patch_set":13,"id":"AAAAQn%2F%2B9A0%3D","line":15,"updated":"2013-08-09 13:15:30.000000000","message":"Do we need to keep the function if the content is commented out? Same question for update below.","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        url: self.url,"},{"line_number":13,"context_line":"        data: {\u0027inline_edit_mod\u0027: self.inline_edit_mod},"},{"line_number":14,"context_line":"        beforeSend: function () {"},{"line_number":15,"context_line":"          //horizon.inline_edit.modal_spinner(gettext(\"Loading\"));"},{"line_number":16,"context_line":"        },"},{"line_number":17,"context_line":"        complete: function () {"},{"line_number":18,"context_line":"          // Clear the global storage;"}],"source_content_type":"text/javascript","patch_set":13,"id":"AAAAQ3%2F%2F97U%3D","line":15,"in_reply_to":"AAAAQn%2F%2B9A0%3D","updated":"2013-08-12 11:22:39.000000000","message":"adding a spinner, I was waiting for a design","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":22,"context_line":"          // enter and the cell is reloaded, tool-tip stays. So just to be sure, I am"},{"line_number":23,"context_line":"          // removing tool-tips manually"},{"line_number":24,"context_line":"          $(\".tooltip.fade.top.in\").remove();"},{"line_number":25,"context_line":"          //horizon.inline_edit.spinner.modal(\u0027hide\u0027);"},{"line_number":26,"context_line":"        },"},{"line_number":27,"context_line":"        error: function(jqXHR, status, errorThrown) {"},{"line_number":28,"context_line":"          if (jqXHR.status \u003d\u003d\u003d 401){"}],"source_content_type":"text/javascript","patch_set":13,"id":"AAAAQn%2F%2B9As%3D","line":25,"updated":"2013-08-09 13:15:30.000000000","message":"Commented out code?","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":22,"context_line":"          // enter and the cell is reloaded, tool-tip stays. So just to be sure, I am"},{"line_number":23,"context_line":"          // removing tool-tips manually"},{"line_number":24,"context_line":"          $(\".tooltip.fade.top.in\").remove();"},{"line_number":25,"context_line":"          //horizon.inline_edit.spinner.modal(\u0027hide\u0027);"},{"line_number":26,"context_line":"        },"},{"line_number":27,"context_line":"        error: function(jqXHR, status, errorThrown) {"},{"line_number":28,"context_line":"          if (jqXHR.status \u003d\u003d\u003d 401){"}],"source_content_type":"text/javascript","patch_set":13,"id":"AAAAQ3%2F%2F97Q%3D","line":25,"in_reply_to":"AAAAQn%2F%2B9As%3D","updated":"2013-08-12 11:22:39.000000000","message":"also adding a spinner","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"82990d5fd1c8fd20da5374719ecc81162176db7e","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    self.reset_with(td_element);"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    self.refresh \u003d function () {"},{"line_number":44,"context_line":"      $.ajax({"},{"line_number":45,"context_line":"        url: self.url,"},{"line_number":46,"context_line":"        data: {\u0027inline_edit_mod\u0027: self.inline_edit_mod},"},{"line_number":47,"context_line":"        beforeSend: function () {"}],"source_content_type":"text/javascript","patch_set":17,"id":"AAAATH%2F%2FgAA%3D","line":44,"updated":"2013-10-15 11:33:26.000000000","message":"I see this patch is quite old, and there is a function horizon.ajax.queue() to handle Ajax calls.. Maybe should be used here too.","commit_id":"f30e5630d68986591e312295a4c64d447665002b"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"daed69b4b62340e96462e4eca74d2acaa417f8ec","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    self.reset_with(td_element);"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    self.refresh \u003d function () {"},{"line_number":44,"context_line":"      $.ajax({"},{"line_number":45,"context_line":"        url: self.url,"},{"line_number":46,"context_line":"        data: {\u0027inline_edit_mod\u0027: self.inline_edit_mod},"},{"line_number":47,"context_line":"        beforeSend: function () {"}],"source_content_type":"text/javascript","patch_set":17,"id":"AAAATH%2F%2FfQs%3D","line":44,"in_reply_to":"AAAATH%2F%2FgAA%3D","updated":"2013-10-15 14:40:37.000000000","message":"I see, I remember implementing it also to rickshaw linechart. I guess it make sense here.","commit_id":"f30e5630d68986591e312295a4c64d447665002b"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"82990d5fd1c8fd20da5374719ecc81162176db7e","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    evt.preventDefault();"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  $(document).on(\u0027click\u0027, \u0027.inline-edit-submit\u0027, function (evt) {"},{"line_number":236,"context_line":"    submit_form(evt, this);"},{"line_number":237,"context_line":"  });"},{"line_number":238,"context_line":""}],"source_content_type":"text/javascript","patch_set":17,"id":"AAAASn%2F%2FZXA%3D","line":235,"updated":"2013-10-15 11:33:26.000000000","message":"As long as we talk about table editing here, wouldn\u0027t it be better to narrow scope to $(\u0027table\u0027) instead of $(document) ?","commit_id":"f30e5630d68986591e312295a4c64d447665002b"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"daed69b4b62340e96462e4eca74d2acaa417f8ec","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    evt.preventDefault();"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  $(document).on(\u0027click\u0027, \u0027.inline-edit-submit\u0027, function (evt) {"},{"line_number":236,"context_line":"    submit_form(evt, this);"},{"line_number":237,"context_line":"  });"},{"line_number":238,"context_line":""}],"source_content_type":"text/javascript","patch_set":17,"id":"AAAATH%2F%2FfQM%3D","line":235,"in_reply_to":"AAAASn%2F%2FZXA%3D","updated":"2013-10-15 14:40:37.000000000","message":"I guess yeah, it\u0027s not planned to use it outside of the table. There was a popup edit version before, but that got canceled.","commit_id":"f30e5630d68986591e312295a4c64d447665002b"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"82990d5fd1c8fd20da5374719ecc81162176db7e","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    submit_form(evt, this);"},{"line_number":237,"context_line":"  });"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"  $(document).on(\u0027keypress\u0027, \u0027.inline-edit-form\u0027, function (evt) {"},{"line_number":240,"context_line":"    if (evt.which \u003d\u003d 13 \u0026\u0026 !evt.shiftKey) {"},{"line_number":241,"context_line":"      submit_form(evt, this);"},{"line_number":242,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":17,"id":"AAAATH%2F%2FgAQ%3D","line":239,"updated":"2013-10-15 11:33:26.000000000","message":"Scope....","commit_id":"f30e5630d68986591e312295a4c64d447665002b"},{"author":{"_account_id":2455,"name":"Tihomir Trifonov","email":"t.trifonov@gmail.com","username":"ttrifonov"},"change_message_id":"82990d5fd1c8fd20da5374719ecc81162176db7e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    }"},{"line_number":243,"context_line":"  });"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"  $(document).on(\u0027click\u0027, \u0027.inline-edit-cancel\u0027, function (evt) {"},{"line_number":246,"context_line":"    var $cancel \u003d $(this);"},{"line_number":247,"context_line":"    var td_element \u003d $cancel.parents(\u0027td\u0027).first();"},{"line_number":248,"context_line":""}],"source_content_type":"text/javascript","patch_set":17,"id":"AAAATH%2F%2FgAM%3D","line":245,"updated":"2013-10-15 11:33:26.000000000","message":"Scope....","commit_id":"f30e5630d68986591e312295a4c64d447665002b"}],"horizon/templates/horizon/common/_data_table_row.html":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\t\t{% for cell in row %}"},{"line_number":4,"context_line":"\t\t\t{% include \"horizon/common/_data_table_cell.html\" %}"},{"line_number":5,"context_line":"\t\t{% endfor %}"},{"line_number":6,"context_line":"\t{% endspaceless %}"},{"line_number":7,"context_line":"\u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":13,"id":"AAAAQn%2F%2B9AA%3D","line":6,"updated":"2013-08-09 13:15:30.000000000","message":"Should be spaces rather than tabs","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\t\t{% for cell in row %}"},{"line_number":4,"context_line":"\t\t\t{% include \"horizon/common/_data_table_cell.html\" %}"},{"line_number":5,"context_line":"\t\t{% endfor %}"},{"line_number":6,"context_line":"\t{% endspaceless %}"},{"line_number":7,"context_line":"\u003c/tr\u003e"}],"source_content_type":"text/html","patch_set":13,"id":"AAAAQ3%2F%2F960%3D","line":6,"in_reply_to":"AAAAQn%2F%2B9AA%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"}],"horizon/test/tests/tables.py":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        self.table \u003d TempTable(self.request, TEST_DATA)"},{"line_number":263,"context_line":"        self.assertQuerysetEqual(self.table.columns.values(),"},{"line_number":264,"context_line":"                                 [\u0027\u003cColumn: multi_select\u003e\u0027,"},{"line_number":265,"context_line":"                                  \u0027\u003cColumn: id\u003e\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_table_natural_no_actions_column(self):"},{"line_number":268,"context_line":"        class TempTable(MyTable):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAQn%2F%2B8%2Fw%3D","side":"PARENT","line":265,"updated":"2013-08-09 13:15:30.000000000","message":"Any reason for removing this test?","commit_id":"ea8ca57bab452a58b6e36d2623a0d9e7b00939a8"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":262,"context_line":"        self.table \u003d TempTable(self.request, TEST_DATA)"},{"line_number":263,"context_line":"        self.assertQuerysetEqual(self.table.columns.values(),"},{"line_number":264,"context_line":"                                 [\u0027\u003cColumn: multi_select\u003e\u0027,"},{"line_number":265,"context_line":"                                  \u0027\u003cColumn: id\u003e\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def test_table_natural_no_actions_column(self):"},{"line_number":268,"context_line":"        class TempTable(MyTable):"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAQ3%2F%2F95Y%3D","side":"PARENT","line":265,"in_reply_to":"AAAAQn%2F%2B8%2Fw%3D","updated":"2013-08-12 11:22:39.000000000","message":"Good observation, deleted by coincidence. Giving it back.","commit_id":"ea8ca57bab452a58b6e36d2623a0d9e7b00939a8"}],"openstack_dashboard/dashboards/admin/projects/tables.py":[{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            # getting all project attributes, update needs all attributes"},{"line_number":114,"context_line":"            project_info_obj \u003d api.keystone.tenant_get(request, project_id,"},{"line_number":115,"context_line":"                                                       admin\u003dTrue)"},{"line_number":116,"context_line":"            project_info \u003d vars(project_info_obj)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            # updating changed value by new value"},{"line_number":119,"context_line":"            project_info[cell_name] \u003d new_cell_value"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAQn%2F%2B8%2FE%3D","line":116,"updated":"2013-08-09 13:15:30.000000000","message":"Usage of vars(), locals() is generally discouraged in favour of explicitly naming variables. It seems to only be done here to be able to access the properties as an array? Why not simply do \"project_info.name\" etc? setattr() can also be used for changing the cell value. (The example in the docs should also be updated.)","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            # getting all project attributes, update needs all attributes"},{"line_number":114,"context_line":"            project_info_obj \u003d api.keystone.tenant_get(request, project_id,"},{"line_number":115,"context_line":"                                                       admin\u003dTrue)"},{"line_number":116,"context_line":"            project_info \u003d vars(project_info_obj)"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"            # updating changed value by new value"},{"line_number":119,"context_line":"            project_info[cell_name] \u003d new_cell_value"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAQ3%2F%2F93o%3D","line":116,"in_reply_to":"AAAAQn%2F%2B8%2FE%3D","updated":"2013-08-12 11:22:39.000000000","message":"neat, changed to \"project_info.name\"... and setattr()\n\nthank you","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":4978,"name":"Julie Pichon","email":"jpichon@redhat.com","username":"jpichon"},"change_message_id":"18f6378536db0e0d869d1fb33297ae67c84b4887","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            exc_type, exc_value, exc_traceback \u003d ("},{"line_number":130,"context_line":"                sys.exc_info())"},{"line_number":131,"context_line":"            # What an ugly message returned back form API"},{"line_number":132,"context_line":"            # message \u003d exc_value.message"},{"line_number":133,"context_line":"            message \u003d _(\"This name is already taken.\")"},{"line_number":134,"context_line":"            raise ValidationError(message)"},{"line_number":135,"context_line":"        except:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAQn%2F%2B8%2B0%3D","line":132,"updated":"2013-08-09 13:15:30.000000000","message":"Many simply explaining we\u0027re giving back a clearer error message and removing the commented out code? :)","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"919a49dcf05a964edeab84b280fc4ef0b59b5025","unresolved":false,"context_lines":[{"line_number":129,"context_line":"            exc_type, exc_value, exc_traceback \u003d ("},{"line_number":130,"context_line":"                sys.exc_info())"},{"line_number":131,"context_line":"            # What an ugly message returned back form API"},{"line_number":132,"context_line":"            # message \u003d exc_value.message"},{"line_number":133,"context_line":"            message \u003d _(\"This name is already taken.\")"},{"line_number":134,"context_line":"            raise ValidationError(message)"},{"line_number":135,"context_line":"        except:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAQ3%2F%2F92Y%3D","line":132,"in_reply_to":"AAAAQn%2F%2B8%2B0%3D","updated":"2013-08-12 11:22:39.000000000","message":"Done","commit_id":"149d17dea6a1dba639d349cbd327216bcb140fcf"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"4516fed5caa9b1e554c908d5c93729dbedf40254","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        return project_info"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class UpdateCell(tables.UpdateAction):"},{"line_number":107,"context_line":"    def update_cell(self, request, datum, project_id,"},{"line_number":108,"context_line":"                    cell_name, new_cell_value):"},{"line_number":109,"context_line":"        # inline update project info"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAARH%2F%2F3y4%3D","line":106,"updated":"2013-08-15 22:22:29.000000000","message":"Update row feature should only be availble  if api.keystone.keystone_can_edit_project() is True. \n\nSee line:56","commit_id":"9a94dc2e845e61d6f016b952eb0776c84dc7996c"},{"author":{"_account_id":7585,"name":"Ladislav Smola","email":"lsmola@redhat.com","username":"lsmola"},"change_message_id":"6e25bad7463ecec7d5aba663502eaf20723dd583","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        return project_info"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"class UpdateCell(tables.UpdateAction):"},{"line_number":107,"context_line":"    def update_cell(self, request, datum, project_id,"},{"line_number":108,"context_line":"                    cell_name, new_cell_value):"},{"line_number":109,"context_line":"        # inline update project info"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAARH%2F%2F1Cs%3D","line":106,"in_reply_to":"AAAARH%2F%2F3y4%3D","updated":"2013-08-16 16:09:48.000000000","message":"Yes, I was thinking that it should probably be that way.\n\nThank you for pointing that out, will implement it on Monday.","commit_id":"9a94dc2e845e61d6f016b952eb0776c84dc7996c"}]}
