)]}'
{"openstack_dashboard/api/nova.py":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"106038e387c3efafa29bd8c54150592f654fde17","unresolved":false,"context_lines":[{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def __str__(self):"},{"line_number":235,"context_line":"        ports \u003d \u0027{0}:{1}\u0027.format(self.from_port, self.to_port)"},{"line_number":236,"context_line":"        if self.from_port \u003d\u003d \u0027-1\u0027 and self.to_port \u003d\u003d \u0027-1\u0027:"},{"line_number":237,"context_line":"            ports \u003d \u0027any port\u0027"},{"line_number":238,"context_line":"        if \u0027name\u0027 in self.group:"},{"line_number":239,"context_line":"            vals \u003d {\u0027ports\u0027: ports,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_00ca686e","line":236,"updated":"2016-06-15 22:59:12.000000000","message":"I think this line should be as follows:\n\nif self.from_port \u003d\u003d -1 and self.to_port \u003d\u003d -1\n\nOtherwise, this will return false, even when the from port and to port are both -1.","commit_id":"3c0cb347e9db69d7c1f88702abed6cc92c67e221"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"e3e98e0f7ae37ef90e67a944ddbd3b0c5a8ee375","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    _attrs \u003d [\u0027id\u0027, \u0027ip_protocol\u0027, \u0027from_port\u0027, \u0027to_port\u0027, \u0027ip_range\u0027, \u0027group\u0027]"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def __str__(self):"},{"line_number":235,"context_line":"        ports \u003d \u0027{0}:{1}\u0027.format(self.from_port, self.to_port)"},{"line_number":236,"context_line":"        if self.from_port \u003d\u003d -1 and self.to_port \u003d\u003d -1:"},{"line_number":237,"context_line":"            ports \u003d \u0027any port\u0027"},{"line_number":238,"context_line":"        if \u0027name\u0027 in self.group:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_46dae379","line":235,"updated":"2016-07-18 06:17:49.000000000","message":"There\u0027s not really much point in formatting this string if it\u0027s ignored in the next statement. I think this should be included as an else: clause below.","commit_id":"d0762f0a9cbbbc864e3553446a96167d23a90bda"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"26ec05b44493e733e8b1150dffbed28c9c830219","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    _attrs \u003d [\u0027id\u0027, \u0027ip_protocol\u0027, \u0027from_port\u0027, \u0027to_port\u0027, \u0027ip_range\u0027, \u0027group\u0027]"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def __str__(self):"},{"line_number":235,"context_line":"        ports \u003d \u0027{0}:{1}\u0027.format(self.from_port, self.to_port)"},{"line_number":236,"context_line":"        if self.from_port \u003d\u003d -1 and self.to_port \u003d\u003d -1:"},{"line_number":237,"context_line":"            ports \u003d \u0027any port\u0027"},{"line_number":238,"context_line":"        if \u0027name\u0027 in self.group:"}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_fb9b1b64","line":235,"in_reply_to":"dada55a8_46dae379","updated":"2016-07-20 15:46:01.000000000","message":"Done","commit_id":"d0762f0a9cbbbc864e3553446a96167d23a90bda"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"9a4f49d87294d2d9d34374ab52b29e0cc2c53b73","unresolved":false,"context_lines":[{"line_number":234,"context_line":"    def __str__(self):"},{"line_number":235,"context_line":"        if self.from_port \u003d\u003d -1 and self.to_port \u003d\u003d -1:"},{"line_number":236,"context_line":"            if \u0027name\u0027 in self.group:"},{"line_number":237,"context_line":"                vals \u003d {\u0027ports\u0027: \u0027any port\u0027,"},{"line_number":238,"context_line":"                        \u0027ip_protocol\u0027: self.ip_protocol,"},{"line_number":239,"context_line":"                        \u0027group\u0027: self.group[\u0027name\u0027]}"},{"line_number":240,"context_line":"                return (_(\u0027ALLOW %(ports)s/%(ip_protocol)s from %(group)s\u0027) %"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_018dc2d5","line":237,"updated":"2016-07-21 06:30:29.000000000","message":"As a formatting argument this is unnecessary, really. Same below.","commit_id":"53a6fb47bd954b41c4187877f8a670cac5f8bf8c"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"d4577382a9fbba431ea942060e8b93ec622f7ed5","unresolved":false,"context_lines":[{"line_number":257,"context_line":"                        \u0027ip_protocol\u0027: self.ip_protocol,"},{"line_number":258,"context_line":"                        \u0027cidr\u0027: self.ip_range[\u0027cidr\u0027]}"},{"line_number":259,"context_line":"                return (_(\u0027ALLOW %(from)s:%(to)s/%(ip_protocol)s \u0027"},{"line_number":260,"context_line":"                          \u0027from %(cidr)s\u0027) % vals)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    # The following attributes are defined to keep compatibility with Neutron"},{"line_number":263,"context_line":"    @property"}],"source_content_type":"text/x-python","patch_set":5,"id":"dada55a8_b9eb1012","line":260,"updated":"2016-07-22 05:59:13.000000000","message":"Sorry to be so darned picky over this short piece of code, but the above contains a lot of duplication :-(\n\nWhat do you think of:\n\n vals \u003d {\n        \u0027range\u0027: \u0027%s:%s\u0027 % (self.from_port, self.to_port),\n        \u0027ip_protocol\u0027: self.ip_protocol,\n        \u0027group\u0027: self.group.get(\u0027name\u0027),\n        \u0027cidr\u0027: self.ip_range[\u0027cidr\u0027]\n }\n\n if self.from_port \u003d\u003d -1 and self.to_port \u003d\u003d -1:\n     vals[\u0027range\u0027] \u003d \u0027any port\u0027\n\n if \u0027name\u0027 in group:\n     return (_(\u0027ALLOW %(range)s/%(ip_protocol)s from %(group)s\u0027) % vals)\n else:\n     return (_(\u0027ALLOW %(range)s/%(ip_protocol)s from %(cidr)s\u0027) % vals)","commit_id":"4582db94a24ce926081a75166f7ba8ed572c74d1"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c9f83d51d6bd3b007fdaf01dbfa86e93eb5736f2","unresolved":false,"context_lines":[{"line_number":235,"context_line":"        vals \u003d {"},{"line_number":236,"context_line":"            \u0027range\u0027: \u0027%s:%s\u0027 % (self.from_port, self.to_port),"},{"line_number":237,"context_line":"            \u0027ip_protocol\u0027: self.ip_protocol,"},{"line_number":238,"context_line":"            \u0027group\u0027: self.group[\u0027name\u0027],"},{"line_number":239,"context_line":"            \u0027cidr\u0027: self.ip_range[\u0027cidr\u0027]"},{"line_number":240,"context_line":"        }"},{"line_number":241,"context_line":"        if self.from_port \u003d\u003d -1 and self.to_port \u003d\u003d -1:"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_b372c30f","line":238,"updated":"2016-07-25 05:33:38.000000000","message":"this needs to be a .get(\u0027name\u0027)","commit_id":"c8e7bde54f8090dcf2d6f40e9da9fd1b907c514b"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"c9f83d51d6bd3b007fdaf01dbfa86e93eb5736f2","unresolved":false,"context_lines":[{"line_number":236,"context_line":"            \u0027range\u0027: \u0027%s:%s\u0027 % (self.from_port, self.to_port),"},{"line_number":237,"context_line":"            \u0027ip_protocol\u0027: self.ip_protocol,"},{"line_number":238,"context_line":"            \u0027group\u0027: self.group[\u0027name\u0027],"},{"line_number":239,"context_line":"            \u0027cidr\u0027: self.ip_range[\u0027cidr\u0027]"},{"line_number":240,"context_line":"        }"},{"line_number":241,"context_line":"        if self.from_port \u003d\u003d -1 and self.to_port \u003d\u003d -1:"},{"line_number":242,"context_line":"            vals[\u0027range\u0027] \u003d \u0027any port\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"dada55a8_f3f0bb68","line":239,"updated":"2016-07-25 05:33:38.000000000","message":"And this *probably* needs to be a .get(\u0027cidr\u0027) - I don\u0027t know whether name and cidr are mutually exclusive or not.","commit_id":"c8e7bde54f8090dcf2d6f40e9da9fd1b907c514b"}]}
