)]}'
{"openstack_dashboard/dashboards/admin/networks/views.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"772b0836b7ee3cb1881af289151337170ae25431","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            agents \u003d api.neutron.list_dhcp_agent_hosting_networks(self.request,"},{"line_number":137,"context_line":"                                                                  network_id)"},{"line_number":138,"context_line":"        except Exception:"},{"line_number":139,"context_line":"            if api.neutron.is_extension_supported(self.request,"},{"line_number":140,"context_line":"                                                  \u0027dhcp_agent_scheduler\u0027):"},{"line_number":141,"context_line":"                msg \u003d _(\u0027Unable to list dhcp agents hosting network.\u0027)"},{"line_number":142,"context_line":"                exceptions.handle(self.request, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_5b2bc230","line":139,"updated":"2016-05-06 19:09:00.000000000","message":"why not have this check on line 135 instead of after the error has already occurred ?","commit_id":"43a33f0c93dd7c53e5fa53bb4d40d44dc3c4bdad"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"3f5eb11a846ad09233672ef32e4a79e8aa35548d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            agents \u003d api.neutron.list_dhcp_agent_hosting_networks(self.request,"},{"line_number":137,"context_line":"                                                                  network_id)"},{"line_number":138,"context_line":"        except Exception:"},{"line_number":139,"context_line":"            if api.neutron.is_extension_supported(self.request,"},{"line_number":140,"context_line":"                                                  \u0027dhcp_agent_scheduler\u0027):"},{"line_number":141,"context_line":"                msg \u003d _(\u0027Unable to list dhcp agents hosting network.\u0027)"},{"line_number":142,"context_line":"                exceptions.handle(self.request, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_e3bc1a6e","line":139,"in_reply_to":"dab17558_32de9711","updated":"2016-05-16 14:20:15.000000000","message":"Done","commit_id":"43a33f0c93dd7c53e5fa53bb4d40d44dc3c4bdad"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"cd077d3fb9a72e94a542abf0c9774bce284776c8","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            agents \u003d api.neutron.list_dhcp_agent_hosting_networks(self.request,"},{"line_number":137,"context_line":"                                                                  network_id)"},{"line_number":138,"context_line":"        except Exception:"},{"line_number":139,"context_line":"            if api.neutron.is_extension_supported(self.request,"},{"line_number":140,"context_line":"                                                  \u0027dhcp_agent_scheduler\u0027):"},{"line_number":141,"context_line":"                msg \u003d _(\u0027Unable to list dhcp agents hosting network.\u0027)"},{"line_number":142,"context_line":"                exceptions.handle(self.request, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_832f0e87","line":139,"in_reply_to":"dab17558_32de9711","updated":"2016-05-10 14:52:32.000000000","message":"It wasn\u0027t just one test that failed, though. It was like all of the tests.","commit_id":"43a33f0c93dd7c53e5fa53bb4d40d44dc3c4bdad"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"3f5eb11a846ad09233672ef32e4a79e8aa35548d","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            agents \u003d api.neutron.list_dhcp_agent_hosting_networks(self.request,"},{"line_number":137,"context_line":"                                                                  network_id)"},{"line_number":138,"context_line":"        except Exception:"},{"line_number":139,"context_line":"            if api.neutron.is_extension_supported(self.request,"},{"line_number":140,"context_line":"                                                  \u0027dhcp_agent_scheduler\u0027):"},{"line_number":141,"context_line":"                msg \u003d _(\u0027Unable to list dhcp agents hosting network.\u0027)"},{"line_number":142,"context_line":"                exceptions.handle(self.request, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_a39052ee","line":139,"in_reply_to":"dab17558_5b2bc230","updated":"2016-05-16 14:20:15.000000000","message":"Done","commit_id":"43a33f0c93dd7c53e5fa53bb4d40d44dc3c4bdad"},{"author":{"_account_id":21522,"name":"Yosef Hoffman","email":"yh128t@att.com","username":"yohoffman"},"change_message_id":"8ae9321898af850d4145113283a3fcad2222a151","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            agents \u003d api.neutron.list_dhcp_agent_hosting_networks(self.request,"},{"line_number":137,"context_line":"                                                                  network_id)"},{"line_number":138,"context_line":"        except Exception:"},{"line_number":139,"context_line":"            if api.neutron.is_extension_supported(self.request,"},{"line_number":140,"context_line":"                                                  \u0027dhcp_agent_scheduler\u0027):"},{"line_number":141,"context_line":"                msg \u003d _(\u0027Unable to list dhcp agents hosting network.\u0027)"},{"line_number":142,"context_line":"                exceptions.handle(self.request, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_dbf9724f","line":139,"in_reply_to":"dab17558_5b2bc230","updated":"2016-05-06 19:21:06.000000000","message":"That\u0027s what I did in Patch Set 1 actually because I had the same thought process as you, David. But then it failed a whole number of tests that check to make sure that the api call on line 136 is made.","commit_id":"43a33f0c93dd7c53e5fa53bb4d40d44dc3c4bdad"},{"author":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"change_message_id":"663531c57cb3245049f97aee2670b5fdb32b533b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"            agents \u003d api.neutron.list_dhcp_agent_hosting_networks(self.request,"},{"line_number":137,"context_line":"                                                                  network_id)"},{"line_number":138,"context_line":"        except Exception:"},{"line_number":139,"context_line":"            if api.neutron.is_extension_supported(self.request,"},{"line_number":140,"context_line":"                                                  \u0027dhcp_agent_scheduler\u0027):"},{"line_number":141,"context_line":"                msg \u003d _(\u0027Unable to list dhcp agents hosting network.\u0027)"},{"line_number":142,"context_line":"                exceptions.handle(self.request, msg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_32de9711","line":139,"in_reply_to":"dab17558_dbf9724f","updated":"2016-05-10 01:22:23.000000000","message":"Maybe you can make some changes in the test.","commit_id":"43a33f0c93dd7c53e5fa53bb4d40d44dc3c4bdad"}]}
