)]}'
{"horizon/static/framework/widgets/table/hz-dynamic-table.html":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"9d7c8cc991d6e07afeded1abf850e34e3368f1dc","unresolved":false,"context_lines":[{"line_number":13,"context_line":"    default-sort-reverse\u003d\"false\""},{"line_number":14,"context_line":"    class\u003d\"table table-striped table-rsp table-detail\"\u003e"},{"line_number":15,"context_line":"    \u003cthead\u003e"},{"line_number":16,"context_line":"      \u003ctr\u003e"},{"line_number":17,"context_line":"        \u003cth colspan\u003d\"100\"\u003e"},{"line_number":18,"context_line":"          \u003chz-magic-search-bar ng-if\u003d\"filterFacets\"\u003e"},{"line_number":19,"context_line":"          \u003c/hz-magic-search-bar\u003e"},{"line_number":20,"context_line":"          \u003cactions ng-if\u003d\"batchActions\" allowed\u003d\"batchActions\" type\u003d\"batch\" result-handler\u003d\"resultHandler\"\u003e\u003c/actions\u003e"},{"line_number":21,"context_line":"        \u003c/th\u003e"},{"line_number":22,"context_line":"      \u003c/tr\u003e"},{"line_number":23,"context_line":"      \u003c!--"},{"line_number":24,"context_line":"        Table-column-headers:"},{"line_number":25,"context_line":"        Set selectAll to True if you want to enable select all checkbox."}],"source_content_type":"text/html","patch_set":3,"id":"dab17558_6599921f","line":22,"range":{"start_line":16,"start_character":5,"end_line":22,"end_character":11},"updated":"2016-05-09 14:01:04.000000000","message":"We won\u0027t want to re-add the search bar back into this place...we\u0027ll want it outside of the table.","commit_id":"aafd58905c43d43a47b4989e9954b51ec24718c3"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"9bc5a252e776cccba832cda43a9a0d1a77ed4771","unresolved":false,"context_lines":[{"line_number":19,"context_line":"          \u003c/hz-magic-search-bar\u003e"},{"line_number":20,"context_line":"          \u003cactions ng-if\u003d\"batchActions\" allowed\u003d\"batchActions\" type\u003d\"batch\" result-handler\u003d\"resultHandler\"\u003e\u003c/actions\u003e"},{"line_number":21,"context_line":"        \u003c/th\u003e"},{"line_number":22,"context_line":"      \u003c/tr\u003e"},{"line_number":23,"context_line":"      \u003c!--"},{"line_number":24,"context_line":"        Table-column-headers:"},{"line_number":25,"context_line":"        Set selectAll to True if you want to enable select all checkbox."}],"source_content_type":"text/html","patch_set":3,"id":"dab17558_87ff4866","line":22,"in_reply_to":"dab17558_6599921f","updated":"2016-05-09 21:35:10.000000000","message":"Could I get a reason why please? The actions have to be inside the table to work correctly, and the design of this UI has the search bar and actions on the same row.","commit_id":"aafd58905c43d43a47b4989e9954b51ec24718c3"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"d9a088d689b6d543874b74d8ce4dd33cf110f391","unresolved":false,"context_lines":[{"line_number":19,"context_line":"          \u003c/hz-magic-search-bar\u003e"},{"line_number":20,"context_line":"          \u003cactions ng-if\u003d\"batchActions\" allowed\u003d\"batchActions\" type\u003d\"batch\" result-handler\u003d\"resultHandler\"\u003e\u003c/actions\u003e"},{"line_number":21,"context_line":"        \u003c/th\u003e"},{"line_number":22,"context_line":"      \u003c/tr\u003e"},{"line_number":23,"context_line":"      \u003c!--"},{"line_number":24,"context_line":"        Table-column-headers:"},{"line_number":25,"context_line":"        Set selectAll to True if you want to enable select all checkbox."}],"source_content_type":"text/html","patch_set":3,"id":"dab17558_6d396341","line":22,"in_reply_to":"dab17558_87ff4866","updated":"2016-05-09 22:38:45.000000000","message":"Done","commit_id":"aafd58905c43d43a47b4989e9954b51ec24718c3"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"55352de56a95f984c5cc58244feb53fe0536b2b3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    st-safe-src\u003d\"safeSrcItems\""},{"line_number":11,"context_line":"    default-sort\u003d\"name\""},{"line_number":12,"context_line":"    default-sort-reverse\u003d\"false\"\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    \u003chz-magic-search-bar ng-if\u003d\"filterFacets\"\u003e"},{"line_number":15,"context_line":"    \u003c/hz-magic-search-bar\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    \u003cactions ng-if\u003d\"batchActions\" allowed\u003d\"batchActions\" type\u003d\"batch\" result-handler\u003d\"resultHandler\"\u003e\u003c/actions\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    \u003ctable class\u003d\"table table-striped table-rsp table-detail\"\u003e"},{"line_number":20,"context_line":"      \u003cthead\u003e"}],"source_content_type":"text/html","patch_set":8,"id":"dab17558_b7b3594c","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":111},"updated":"2016-05-16 21:39:08.000000000","message":"We talked about this in IRC, but if you want these lined up together we should just place them both in a bootstrap row rather than reformat/shift the hz-table and surrounding features about.  Thanks!  Sorry about the confusion.","commit_id":"d20321aed6dce4c1e8743eb249b5003279e31e86"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"3ce371cd8afd1348e38a558af183a1a32820e5dc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    st-safe-src\u003d\"safeSrcItems\""},{"line_number":11,"context_line":"    default-sort\u003d\"name\""},{"line_number":12,"context_line":"    default-sort-reverse\u003d\"false\"\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    \u003chz-magic-search-bar ng-if\u003d\"filterFacets\"\u003e"},{"line_number":15,"context_line":"    \u003c/hz-magic-search-bar\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    \u003cactions ng-if\u003d\"batchActions\" allowed\u003d\"batchActions\" type\u003d\"batch\" result-handler\u003d\"resultHandler\"\u003e\u003c/actions\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    \u003ctable class\u003d\"table table-striped table-rsp table-detail\"\u003e"},{"line_number":20,"context_line":"      \u003cthead\u003e"}],"source_content_type":"text/html","patch_set":8,"id":"dab17558_7b1eb8bb","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":111},"in_reply_to":"dab17558_3743e914","updated":"2016-05-17 23:41:37.000000000","message":"It seems like batch actions are really closely coupled to hz-table, which seems like a bad idea.\n\nhttps://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/action-list/actions-delete-selected.template.html#L2\n\nIt seems like we could have batch actions independent of hz-table if we took an input for selected to be reflect to or to take a function and do something like register a watch on selected inside of hz-table. You could have actions take an input of items (item actions takes an input of item) and bind the two. That way you could separate the table from the batch actions.","commit_id":"d20321aed6dce4c1e8743eb249b5003279e31e86"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"26822f61c091267b9982a538e1c2c1147c399dca","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    st-safe-src\u003d\"safeSrcItems\""},{"line_number":11,"context_line":"    default-sort\u003d\"name\""},{"line_number":12,"context_line":"    default-sort-reverse\u003d\"false\"\u003e"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    \u003chz-magic-search-bar ng-if\u003d\"filterFacets\"\u003e"},{"line_number":15,"context_line":"    \u003c/hz-magic-search-bar\u003e"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"    \u003cactions ng-if\u003d\"batchActions\" allowed\u003d\"batchActions\" type\u003d\"batch\" result-handler\u003d\"resultHandler\"\u003e\u003c/actions\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"    \u003ctable class\u003d\"table table-striped table-rsp table-detail\"\u003e"},{"line_number":20,"context_line":"      \u003cthead\u003e"}],"source_content_type":"text/html","patch_set":8,"id":"dab17558_3743e914","line":17,"range":{"start_line":13,"start_character":0,"end_line":17,"end_character":111},"in_reply_to":"dab17558_b7b3594c","updated":"2016-05-16 21:43:13.000000000","message":"In a different vein, I\u0027d just sidestepped the issue by using the hz-magic-search-context feature: https://review.openstack.org/#/c/309482/19/horizon/static/framework/widgets/table/generic-table.html","commit_id":"d20321aed6dce4c1e8743eb249b5003279e31e86"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"9684edf9e3201137085c7a9e603cf89cb3d956a7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  Dynamic table template"},{"line_number":3,"context_line":"--\u003e"},{"line_number":4,"context_line":"\u003chz-magic-search-context filter-facets\u003d\"filterFacets\"\u003e"},{"line_number":5,"context_line":"  \u003cdiv hz-table"},{"line_number":6,"context_line":"    track-rows-by\u003d\"{$ config.trackId $}\""},{"line_number":7,"context_line":"    ng-cloak"},{"line_number":8,"context_line":"    st-magic-search"}],"source_content_type":"text/html","patch_set":11,"id":"bab6814e_74073218","line":5,"range":{"start_line":5,"start_character":7,"end_line":5,"end_character":15},"updated":"2016-05-20 19:09:20.000000000","message":"I guess I\u0027m confused by this approach, where we\u0027re placing the hz-table and st-magic-search inside this div.  I\u0027d much more prefer we just have the hz-table, st-table, st-magic-search, etc. be in the table below as before, and just place the other items in a row or rows above the table.  This can be done with hz-magic-search-context.\n\n\u003chz-magic-search-context ...\u003e\n   \u003chz-magic-search-bar .../\u003e\n   \u003cactions .../\u003e\n   \u003ctable .../\u003e\n\u003c/hz-magic-search-context\u003e\n\nThat just seems cleaner than sort of overlaying hz-table and its friends onto a div because it happens to pick up below.\n\nAlso, I\u0027m actually against having the stacking/non-stacking actions, but if we\u0027re going to do it, rather than use the logic below, why don\u0027t we just have a searchColumnSpan and an actionColumnSpan, remove the other logic, and let Bootstrap figure out how to lay them out?  Because if you give both values 12, then they\u0027ll stack, and if you give them, say, 8 and 4, they\u0027ll be pleasantly aligned.","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"674a902b6d4941fd2783392b483ea875b7f2c6e1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"  Dynamic table template"},{"line_number":3,"context_line":"--\u003e"},{"line_number":4,"context_line":"\u003chz-magic-search-context filter-facets\u003d\"filterFacets\"\u003e"},{"line_number":5,"context_line":"  \u003cdiv hz-table"},{"line_number":6,"context_line":"    track-rows-by\u003d\"{$ config.trackId $}\""},{"line_number":7,"context_line":"    ng-cloak"},{"line_number":8,"context_line":"    st-magic-search"}],"source_content_type":"text/html","patch_set":11,"id":"bab6814e_d9583c59","line":5,"in_reply_to":"bab6814e_74073218","updated":"2016-05-25 03:48:06.000000000","message":"OK, again, the \u003cactions\u003e directive needs to have access to the tCtrl to access to the selected items in the table. That tCtrl is owned by the hz-table directive, so for \u003cactions\u003e to *work* then it *must* be inside the hz-table directive\u0027s DOM. Since accessibility dictates that we can\u0027t have the \u003cactions\u003e directive inside the \u003ctable\u003e then we must move hz-table out of the \u003ctable\u003e\n\nOr are you arguing that hz-magic-search should take responsilbility for the selection stuff?\n\nI\u0027m not particularly fond of searchColumnSpan, so I\u0027ll see how your suggestion works out. I\u0027m also not sure how else to implement the stacking/non-stacking actions - and I am pretty sure we need to have the option for both, since some tables have very long action button rows, but in the case of swift the action buttons row is really short, and looks ridiculous on a separate row :-)","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ba35644e2140c853ca7ed9bb45584d5cc33fbec9","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            class\u003d\"rsp-p{$ column.priority $}\"\u003e"},{"line_number":72,"context_line":"            \u003chz-cell\u003e\u003c/hz-cell\u003e"},{"line_number":73,"context_line":"          \u003c/td\u003e"},{"line_number":74,"context_line":"          \u003ctd ng-if\u003d\"itemActions\" class\u003d\"action_column\"\u003e"},{"line_number":75,"context_line":"            \u003c!--"},{"line_number":76,"context_line":"              Table-row-action-column:"},{"line_number":77,"context_line":"              Actions taken here apply to a single item/row."}],"source_content_type":"text/html","patch_set":11,"id":"bab6814e_23c74797","line":74,"range":{"start_line":74,"start_character":41,"end_line":74,"end_character":54},"updated":"2016-05-20 13:02:32.000000000","message":"Its a bit off topic, but since we\u0027re fixing so much here - could you make this \"actions_column\"? Right now its broken.","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"674a902b6d4941fd2783392b483ea875b7f2c6e1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            class\u003d\"rsp-p{$ column.priority $}\"\u003e"},{"line_number":72,"context_line":"            \u003chz-cell\u003e\u003c/hz-cell\u003e"},{"line_number":73,"context_line":"          \u003c/td\u003e"},{"line_number":74,"context_line":"          \u003ctd ng-if\u003d\"itemActions\" class\u003d\"action_column\"\u003e"},{"line_number":75,"context_line":"            \u003c!--"},{"line_number":76,"context_line":"              Table-row-action-column:"},{"line_number":77,"context_line":"              Actions taken here apply to a single item/row."}],"source_content_type":"text/html","patch_set":11,"id":"bab6814e_39eb487a","line":74,"in_reply_to":"bab6814e_23c74797","updated":"2016-05-25 03:48:06.000000000","message":"Done","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5954f72d2475bfd5576539586f8223d569670181","unresolved":false,"context_lines":[{"line_number":20,"context_line":"      \u003c/actions\u003e"},{"line_number":21,"context_line":"    \u003c/div\u003e"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    \u003cdiv ng-if\u003d\"config.searchColumnSpan \u003d\u003d\u003d 12\" class\u003d\"row\"\u003e"},{"line_number":24,"context_line":"      \u003cactions ng-if\u003d\"batchActions\" allowed\u003d\"batchActions\" type\u003d\"batch\" result-handler\u003d\"resultHandler\"\u003e"},{"line_number":25,"context_line":"      \u003c/actions\u003e"},{"line_number":26,"context_line":"    \u003c/div\u003e"}],"source_content_type":"text/html","patch_set":14,"id":"9abb7d3a_4546a14f","line":23,"range":{"start_line":23,"start_character":15,"end_line":23,"end_character":48},"updated":"2016-06-01 13:25:55.000000000","message":"I\u0027ll test to see if we could just use normal bootstrap to handle the wrapping; this seems unnecessary to me right now...see my example follow-on patch:\n\nhttps://review.openstack.org/#/c/323859/","commit_id":"c0ff7ac47b3a742aced756c9615f1b7c5a75994e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5954f72d2475bfd5576539586f8223d569670181","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            class\u003d\"rsp-p{$ column.priority $}\"\u003e"},{"line_number":72,"context_line":"            \u003chz-cell\u003e\u003c/hz-cell\u003e"},{"line_number":73,"context_line":"          \u003c/td\u003e"},{"line_number":74,"context_line":"          \u003ctd ng-if\u003d\"itemActions\" class\u003d\"actions_column\"\u003e"},{"line_number":75,"context_line":"            \u003c!--"},{"line_number":76,"context_line":"              Table-row-action-column:"},{"line_number":77,"context_line":"              Actions taken here apply to a single item/row."}],"source_content_type":"text/html","patch_set":14,"id":"9abb7d3a_0a6ca633","line":74,"range":{"start_line":74,"start_character":41,"end_line":74,"end_character":55},"updated":"2016-06-01 13:25:55.000000000","message":"Seems like classes should be in the form: \"actions-column,\" but that is a nit for another patch.","commit_id":"c0ff7ac47b3a742aced756c9615f1b7c5a75994e"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/objects-batch-actions.service.js":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ba35644e2140c853ca7ed9bb45584d5cc33fbec9","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \u0027$modal\u0027"},{"line_number":85,"context_line":"  ];"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  // TODO consider https://github.com/nervgh/angular-file-upload"},{"line_number":88,"context_line":"  function uploadService(swiftAPI, basePath, model, $qExtensions, modalWaitSpinnerService,"},{"line_number":89,"context_line":"                         toastService, $modal) {"},{"line_number":90,"context_line":"    var service \u003d {"}],"source_content_type":"text/javascript","patch_set":11,"id":"bab6814e_439b6b72","line":87,"updated":"2016-05-20 13:02:32.000000000","message":"If we\u0027re going to add TODOs, lets have some accountability with a bug/bp or a name. Personally this one could probably be left out, since Timur is already working on it.","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"674a902b6d4941fd2783392b483ea875b7f2c6e1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    \u0027$modal\u0027"},{"line_number":85,"context_line":"  ];"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  // TODO consider https://github.com/nervgh/angular-file-upload"},{"line_number":88,"context_line":"  function uploadService(swiftAPI, basePath, model, $qExtensions, modalWaitSpinnerService,"},{"line_number":89,"context_line":"                         toastService, $modal) {"},{"line_number":90,"context_line":"    var service \u003d {"}],"source_content_type":"text/javascript","patch_set":11,"id":"bab6814e_b92a988e","line":87,"in_reply_to":"bab6814e_439b6b72","updated":"2016-05-25 03:48:06.000000000","message":"Done","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ba35644e2140c853ca7ed9bb45584d5cc33fbec9","unresolved":false,"context_lines":[{"line_number":112,"context_line":"          interpolate(gettext(\u0027File %(name)s uploaded.\u0027), uploadInfo, true)"},{"line_number":113,"context_line":"        );"},{"line_number":114,"context_line":"        model.updateContainer();"},{"line_number":115,"context_line":"        // TODO optimize me"},{"line_number":116,"context_line":"        model.selectContainer("},{"line_number":117,"context_line":"          model.container.name,"},{"line_number":118,"context_line":"          model.folder"}],"source_content_type":"text/javascript","patch_set":11,"id":"bab6814e_838f1329","line":115,"updated":"2016-05-20 13:02:32.000000000","message":"ditto","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"674a902b6d4941fd2783392b483ea875b7f2c6e1","unresolved":false,"context_lines":[{"line_number":112,"context_line":"          interpolate(gettext(\u0027File %(name)s uploaded.\u0027), uploadInfo, true)"},{"line_number":113,"context_line":"        );"},{"line_number":114,"context_line":"        model.updateContainer();"},{"line_number":115,"context_line":"        // TODO optimize me"},{"line_number":116,"context_line":"        model.selectContainer("},{"line_number":117,"context_line":"          model.container.name,"},{"line_number":118,"context_line":"          model.folder"}],"source_content_type":"text/javascript","patch_set":11,"id":"bab6814e_19180484","line":115,"in_reply_to":"bab6814e_838f1329","updated":"2016-05-25 03:48:06.000000000","message":"Done","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ba35644e2140c853ca7ed9bb45584d5cc33fbec9","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        return $qExtensions.booleanAsPromise(true);"},{"line_number":139,"context_line":"      },"},{"line_number":140,"context_line":"      perform: function perform() {"},{"line_number":141,"context_line":"        // TODO consider https://github.com/nervgh/angular-file-upload"},{"line_number":142,"context_line":"        uploadModal(basePath + \u0027create-folder-modal.html\u0027, $modal)"},{"line_number":143,"context_line":"          .then(service.createFolderCallback);"},{"line_number":144,"context_line":"      },"}],"source_content_type":"text/javascript","patch_set":11,"id":"bab6814e_e3809ff9","line":141,"updated":"2016-05-20 13:02:32.000000000","message":"grrr","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"674a902b6d4941fd2783392b483ea875b7f2c6e1","unresolved":false,"context_lines":[{"line_number":138,"context_line":"        return $qExtensions.booleanAsPromise(true);"},{"line_number":139,"context_line":"      },"},{"line_number":140,"context_line":"      perform: function perform() {"},{"line_number":141,"context_line":"        // TODO consider https://github.com/nervgh/angular-file-upload"},{"line_number":142,"context_line":"        uploadModal(basePath + \u0027create-folder-modal.html\u0027, $modal)"},{"line_number":143,"context_line":"          .then(service.createFolderCallback);"},{"line_number":144,"context_line":"      },"}],"source_content_type":"text/javascript","patch_set":11,"id":"bab6814e_990cf443","line":141,"in_reply_to":"bab6814e_e3809ff9","updated":"2016-05-25 03:48:06.000000000","message":"Done","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ba35644e2140c853ca7ed9bb45584d5cc33fbec9","unresolved":false,"context_lines":[{"line_number":157,"context_line":"              interpolate(gettext(\u0027Folder %(name)s created.\u0027), {name: name}, true)"},{"line_number":158,"context_line":"            );"},{"line_number":159,"context_line":"            model.updateContainer();"},{"line_number":160,"context_line":"            // TODO optimize me"},{"line_number":161,"context_line":"            model.selectContainer("},{"line_number":162,"context_line":"              model.container.name,"},{"line_number":163,"context_line":"              model.folder"}],"source_content_type":"text/javascript","patch_set":11,"id":"bab6814e_c3859b07","line":160,"updated":"2016-05-20 13:02:32.000000000","message":"0.o","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"674a902b6d4941fd2783392b483ea875b7f2c6e1","unresolved":false,"context_lines":[{"line_number":157,"context_line":"              interpolate(gettext(\u0027Folder %(name)s created.\u0027), {name: name}, true)"},{"line_number":158,"context_line":"            );"},{"line_number":159,"context_line":"            model.updateContainer();"},{"line_number":160,"context_line":"            // TODO optimize me"},{"line_number":161,"context_line":"            model.selectContainer("},{"line_number":162,"context_line":"              model.container.name,"},{"line_number":163,"context_line":"              model.folder"}],"source_content_type":"text/javascript","patch_set":11,"id":"bab6814e_59128c63","line":160,"in_reply_to":"bab6814e_c3859b07","updated":"2016-05-25 03:48:06.000000000","message":"Done","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"ba35644e2140c853ca7ed9bb45584d5cc33fbec9","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        // do the follow-up regardless of success or error"},{"line_number":195,"context_line":"        return $modal.open(localSpec).result.finally(function finished() {"},{"line_number":196,"context_line":"          model.updateContainer();"},{"line_number":197,"context_line":"          // TODO optimize me"},{"line_number":198,"context_line":"          model.selectContainer("},{"line_number":199,"context_line":"            model.container.name,"},{"line_number":200,"context_line":"            model.folder"}],"source_content_type":"text/javascript","patch_set":11,"id":"bab6814e_a3917749","line":197,"updated":"2016-05-20 13:02:32.000000000","message":"\u003e.\u003c","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"674a902b6d4941fd2783392b483ea875b7f2c6e1","unresolved":false,"context_lines":[{"line_number":194,"context_line":"        // do the follow-up regardless of success or error"},{"line_number":195,"context_line":"        return $modal.open(localSpec).result.finally(function finished() {"},{"line_number":196,"context_line":"          model.updateContainer();"},{"line_number":197,"context_line":"          // TODO optimize me"},{"line_number":198,"context_line":"          model.selectContainer("},{"line_number":199,"context_line":"            model.container.name,"},{"line_number":200,"context_line":"            model.folder"}],"source_content_type":"text/javascript","patch_set":11,"id":"bab6814e_f91a607b","line":197,"in_reply_to":"bab6814e_a3917749","updated":"2016-05-25 03:48:06.000000000","message":"Done","commit_id":"9f469a3637f1897bf456ec29057f01557d578066"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"e725bca4752f622ebaa56bf2ca616bbe6a163c7e","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        return $modal.open(localSpec).result.then(function finished() {"},{"line_number":191,"context_line":"          return actionResultService.getActionResult().deleted("},{"line_number":192,"context_line":"            \u0027OS::Swift::Object\u0027, \u0027DELETED\u0027"},{"line_number":193,"context_line":"          ).result;"},{"line_number":194,"context_line":"        });"},{"line_number":195,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":20,"id":"7aa08908_2f35c145","line":192,"range":{"start_line":192,"start_character":34,"end_line":192,"end_character":41},"updated":"2016-06-10 10:09:37.000000000","message":"Shouldn\u0027t some kind of id be passed here? At least that what\u0027s documentation tells.","commit_id":"241cf1bd7e809c8e104d14a91246374dc86b7836"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"59043efae454f07d1bff1f2e1f3aaa8744c9a40a","unresolved":false,"context_lines":[{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        return $modal.open(localSpec).result.then(function finished() {"},{"line_number":191,"context_line":"          return actionResultService.getActionResult().deleted("},{"line_number":192,"context_line":"            \u0027OS::Swift::Object\u0027, \u0027DELETED\u0027"},{"line_number":193,"context_line":"          ).result;"},{"line_number":194,"context_line":"        });"},{"line_number":195,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":20,"id":"7aa08908_dab83dca","line":192,"in_reply_to":"7aa08908_2f35c145","updated":"2016-06-10 10:20:07.000000000","message":"Yes, it should be the id(s) of the deleted objects. The issue I have is that I can\u0027t easily pass that in with the current other structure of the code. I\u0027ll have to refactor a few things to fully support the ActionResult feature, which I believe will bloat out this patch to an unreasonable size/scope. That\u0027s why I\u0027ve nominated to postpone full ActionResult support to a follow-on patch as noted in the change message, and for now a simple dummy value is passed (no value is actually used - the consumer of these ActionResults is also quite simple).","commit_id":"241cf1bd7e809c8e104d14a91246374dc86b7836"}],"openstack_dashboard/dashboards/project/static/dashboard/project/containers/objects-row-actions.service.js":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"e725bca4752f622ebaa56bf2ca616bbe6a163c7e","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        return $modal.open(localSpec).result.then(function finished() {"},{"line_number":148,"context_line":"          return actionResultService.getActionResult().deleted("},{"line_number":149,"context_line":"            \u0027OS::Swift::Object\u0027, file.name"},{"line_number":150,"context_line":"          ).result;"},{"line_number":151,"context_line":"        });"},{"line_number":152,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":20,"id":"7aa08908_2f6dc104","line":149,"range":{"start_line":149,"start_character":12,"end_line":149,"end_character":31},"updated":"2016-06-10 10:09:37.000000000","message":"Ideally, this kind of literal is better be defined at containers module level as a constant. However, I don\u0027t mind to see this change in another patch (that could be more difficult than it seems).","commit_id":"241cf1bd7e809c8e104d14a91246374dc86b7836"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"59043efae454f07d1bff1f2e1f3aaa8744c9a40a","unresolved":false,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        return $modal.open(localSpec).result.then(function finished() {"},{"line_number":148,"context_line":"          return actionResultService.getActionResult().deleted("},{"line_number":149,"context_line":"            \u0027OS::Swift::Object\u0027, file.name"},{"line_number":150,"context_line":"          ).result;"},{"line_number":151,"context_line":"        });"},{"line_number":152,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":20,"id":"7aa08908_5af3ad9f","line":149,"in_reply_to":"7aa08908_2f6dc104","updated":"2016-06-10 10:20:07.000000000","message":"Yep, it should be, and will be when I migrate this code to comply with the angular type registry, which will be in a follow-on patch to reduce the size/scope of this patch.","commit_id":"241cf1bd7e809c8e104d14a91246374dc86b7836"}]}
