)]}'
{"horizon/static/framework/conf/resource-type-registry.service.js":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"2e2680a896201f7048024c7f95a771efde9cf778","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      this.setLoadFunction \u003d setLoadFunction;"},{"line_number":73,"context_line":"      this.load \u003d load;"},{"line_number":74,"context_line":"      this.loadFunction \u003d function def() { return Promise.resolve({data: {}}); };"},{"line_number":75,"context_line":"      this.loadFunctionSet \u003d false;"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      // These members support the ability of a type to provide a function"},{"line_number":78,"context_line":"      // that, given an object in the structure presented by the"}],"source_content_type":"text/javascript","patch_set":16,"id":"5a9d85d2_055c2aec","line":75,"updated":"2016-06-21 01:33:41.000000000","message":"As an alternative to this, how about loadFunction starts off null and you can detect whether it\u0027s set by checking whether it\u0027s null. Then in load() you can perform that check and return the dummy promise instead.\n\nI don\u0027t like keeping around a separate variable like this as it could get out of sync with reality, especially since loadFunction is public.","commit_id":"bf32be2c62167163618fe393f83b36e7c045af46"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"2e9d2def5cf43e4450fa29cacd2eab7fb2dd811e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"      this.setLoadFunction \u003d setLoadFunction;"},{"line_number":73,"context_line":"      this.load \u003d load;"},{"line_number":74,"context_line":"      this.loadFunction \u003d function def() { return Promise.resolve({data: {}}); };"},{"line_number":75,"context_line":"      this.loadFunctionSet \u003d false;"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"      // These members support the ability of a type to provide a function"},{"line_number":78,"context_line":"      // that, given an object in the structure presented by the"}],"source_content_type":"text/javascript","patch_set":16,"id":"1aa78d24_f01ba81a","line":75,"in_reply_to":"5a9d85d2_055c2aec","updated":"2016-07-14 15:15:47.000000000","message":"it is better for loadFunction to always be a valid promise. This allows things like hz-resource-panel to just work with newly registered resources without lots of external error checking.\n\nI too prefer that loadFunction be private. I think that would be a good general improvement to the registry code to \"private\" as much as possible and \"encourage\" access through getter/setters as we\u0027ve discussed on your doc patch.\n\nI\u0027ll look into that change...but I\u0027m pretty sure others will disagree about the value. I don\u0027t want this patch to get stalled by that kind of debate.","commit_id":"bf32be2c62167163618fe393f83b36e7c045af46"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"60df0093dab8ac1a2724cb5e70280872c0b61926","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    \u0027compressor.filters.css_default.CssAbsoluteFilter\u0027,"},{"line_number":156,"context_line":")"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"COMPRESS_ENABLED \u003d False"},{"line_number":159,"context_line":"COMPRESS_OUTPUT_DIR \u003d \u0027dashboard\u0027"},{"line_number":160,"context_line":"COMPRESS_CSS_HASHING_METHOD \u003d \u0027hash\u0027"},{"line_number":161,"context_line":"COMPRESS_PARSER \u003d \u0027compressor.parser.HtmlParser\u0027"}],"source_content_type":"text/x-python","patch_set":13,"id":"7aa08908_33734e17","line":158,"range":{"start_line":158,"start_character":0,"end_line":158,"end_character":24},"updated":"2016-06-10 19:52:08.000000000","message":"whoops?","commit_id":"5ecc1dcae9ddeb3729ddb1477439bf245e981db0"}]}