)]}'
{"horizon/utils/compute_utils.py":[{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"4e1a0096d21ec7657199360d8f967b64df262095","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def is_deleting(instance):"},{"line_number":15,"context_line":"    task_state \u003d getattr(instance, \"OS-EXT-STS:task_state\", None)"},{"line_number":16,"context_line":"    if not task_state:"},{"line_number":17,"context_line":"        return False"},{"line_number":18,"context_line":"    return task_state.lower() \u003d\u003d \"deleting\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_9fbe09fe","line":15,"updated":"2016-12-13 00:05:54.000000000","message":"Can you set the default value as an empty string and remove the following two lines? Thanks.","commit_id":"4d4677a670afeff4ebd4b3c77b2f964961bc3aa8"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"6188c0fd932b29d86a24cbb59cd7b2841822c7f1","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"def is_deleting(instance):"},{"line_number":15,"context_line":"    task_state \u003d getattr(instance, \"OS-EXT-STS:task_state\", None)"},{"line_number":16,"context_line":"    if not task_state:"},{"line_number":17,"context_line":"        return False"},{"line_number":18,"context_line":"    return task_state.lower() \u003d\u003d \"deleting\""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a6eadb0_66ba2ac2","line":15,"in_reply_to":"1a6eadb0_9fbe09fe","updated":"2016-12-14 16:16:18.000000000","message":"Done","commit_id":"4d4677a670afeff4ebd4b3c77b2f964961bc3aa8"}],"openstack_dashboard/dashboards/admin/instances/tables.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"f2ca9e757ff1b6c4c031d0eb113e8fbe68bfe268","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    task_state \u003d getattr(instance, \"OS-EXT-STS:task_state\", None)"},{"line_number":34,"context_line":"    if not task_state:"},{"line_number":35,"context_line":"        return False"},{"line_number":36,"context_line":"    return task_state.lower() \u003d\u003d \"deleting\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class AdminEditInstance(project_tables.EditInstance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_ae77329e","line":36,"updated":"2016-06-02 10:36:31.000000000","message":"This is identical to the project version correct? Either reuse the existing function, or even better, pull it into a utils file. No need to duplicate and maintain both.","commit_id":"b193e74ef84ce297e01c69f9e65c6a0fed88ae2d"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"a2272e4ab020bad5be1c0436725225c5d7b946b1","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    task_state \u003d getattr(instance, \"OS-EXT-STS:task_state\", None)"},{"line_number":34,"context_line":"    if not task_state:"},{"line_number":35,"context_line":"        return False"},{"line_number":36,"context_line":"    return task_state.lower() \u003d\u003d \"deleting\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class AdminEditInstance(project_tables.EditInstance):"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_0b874710","line":36,"in_reply_to":"9abb7d3a_ae77329e","updated":"2016-06-05 22:51:28.000000000","message":"Done","commit_id":"b193e74ef84ce297e01c69f9e65c6a0fed88ae2d"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"dd73a029dc20bb5303fe253faebe77a952986dd7","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ResetState(policy.PolicyTargetMixin, tables.BatchAction):"},{"line_number":52,"context_line":"    name \u003d \"reset_state\""},{"line_number":53,"context_line":"    classes \u003d (\u0027btn-reboot\u0027,)"},{"line_number":54,"context_line":"    policy_rules \u003d ((\"compute\", \"compute:reboot\"),)"},{"line_number":55,"context_line":"    help_text \u003d _(\"Reset instances will lose any data\""},{"line_number":56,"context_line":"                  \" not saved in persistent storage.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_ce29d6f4","line":53,"range":{"start_line":53,"start_character":4,"end_line":53,"end_character":29},"updated":"2016-06-02 10:38:35.000000000","message":"This can be removed. Doesnt seem to be used for anything?","commit_id":"b193e74ef84ce297e01c69f9e65c6a0fed88ae2d"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"a2272e4ab020bad5be1c0436725225c5d7b946b1","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class ResetState(policy.PolicyTargetMixin, tables.BatchAction):"},{"line_number":52,"context_line":"    name \u003d \"reset_state\""},{"line_number":53,"context_line":"    classes \u003d (\u0027btn-reboot\u0027,)"},{"line_number":54,"context_line":"    policy_rules \u003d ((\"compute\", \"compute:reboot\"),)"},{"line_number":55,"context_line":"    help_text \u003d _(\"Reset instances will lose any data\""},{"line_number":56,"context_line":"                  \" not saved in persistent storage.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_6b7c0b21","line":53,"range":{"start_line":53,"start_character":4,"end_line":53,"end_character":29},"in_reply_to":"9abb7d3a_ce29d6f4","updated":"2016-06-05 22:51:28.000000000","message":"Done","commit_id":"b193e74ef84ce297e01c69f9e65c6a0fed88ae2d"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"f2ca9e757ff1b6c4c031d0eb113e8fbe68bfe268","unresolved":false,"context_lines":[{"line_number":51,"context_line":"class ResetState(policy.PolicyTargetMixin, tables.BatchAction):"},{"line_number":52,"context_line":"    name \u003d \"reset_state\""},{"line_number":53,"context_line":"    classes \u003d (\u0027btn-reboot\u0027,)"},{"line_number":54,"context_line":"    policy_rules \u003d ((\"compute\", \"compute:reboot\"),)"},{"line_number":55,"context_line":"    help_text \u003d _(\"Reset instances will lose any data\""},{"line_number":56,"context_line":"                  \" not saved in persistent storage.\")"},{"line_number":57,"context_line":"    action_type \u003d \"danger\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_ae029207","line":54,"updated":"2016-06-02 10:36:31.000000000","message":"Wouldn\u0027t this be \"compute_extension:admin_actions:resetState\"?","commit_id":"b193e74ef84ce297e01c69f9e65c6a0fed88ae2d"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"a2272e4ab020bad5be1c0436725225c5d7b946b1","unresolved":false,"context_lines":[{"line_number":51,"context_line":"class ResetState(policy.PolicyTargetMixin, tables.BatchAction):"},{"line_number":52,"context_line":"    name \u003d \"reset_state\""},{"line_number":53,"context_line":"    classes \u003d (\u0027btn-reboot\u0027,)"},{"line_number":54,"context_line":"    policy_rules \u003d ((\"compute\", \"compute:reboot\"),)"},{"line_number":55,"context_line":"    help_text \u003d _(\"Reset instances will lose any data\""},{"line_number":56,"context_line":"                  \" not saved in persistent storage.\")"},{"line_number":57,"context_line":"    action_type \u003d \"danger\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_4b794f2f","line":54,"in_reply_to":"9abb7d3a_ae029207","updated":"2016-06-05 22:51:28.000000000","message":"Done","commit_id":"b193e74ef84ce297e01c69f9e65c6a0fed88ae2d"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"dd73a029dc20bb5303fe253faebe77a952986dd7","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class ResetStateActive(policy.PolicyTargetMixin, tables.BatchAction):"},{"line_number":87,"context_line":"    name \u003d \"reset_state_active\""},{"line_number":88,"context_line":"    classes \u003d (\u0027btn-reboot\u0027,)"},{"line_number":89,"context_line":"    policy_rules \u003d ((\"compute\", \"compute:reboot\"),)"},{"line_number":90,"context_line":"    help_text \u003d _(\"Reset instances back to active state.\")"},{"line_number":91,"context_line":"    action_type \u003d \"danger\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_8e486ece","line":88,"range":{"start_line":88,"start_character":4,"end_line":88,"end_character":29},"updated":"2016-06-02 10:38:35.000000000","message":"ditto","commit_id":"b193e74ef84ce297e01c69f9e65c6a0fed88ae2d"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"a2272e4ab020bad5be1c0436725225c5d7b946b1","unresolved":false,"context_lines":[{"line_number":85,"context_line":""},{"line_number":86,"context_line":"class ResetStateActive(policy.PolicyTargetMixin, tables.BatchAction):"},{"line_number":87,"context_line":"    name \u003d \"reset_state_active\""},{"line_number":88,"context_line":"    classes \u003d (\u0027btn-reboot\u0027,)"},{"line_number":89,"context_line":"    policy_rules \u003d ((\"compute\", \"compute:reboot\"),)"},{"line_number":90,"context_line":"    help_text \u003d _(\"Reset instances back to active state.\")"},{"line_number":91,"context_line":"    action_type \u003d \"danger\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_ab76f33b","line":88,"range":{"start_line":88,"start_character":4,"end_line":88,"end_character":29},"in_reply_to":"9abb7d3a_8e486ece","updated":"2016-06-05 22:51:28.000000000","message":"Done","commit_id":"b193e74ef84ce297e01c69f9e65c6a0fed88ae2d"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"f2ca9e757ff1b6c4c031d0eb113e8fbe68bfe268","unresolved":false,"context_lines":[{"line_number":86,"context_line":"class ResetStateActive(policy.PolicyTargetMixin, tables.BatchAction):"},{"line_number":87,"context_line":"    name \u003d \"reset_state_active\""},{"line_number":88,"context_line":"    classes \u003d (\u0027btn-reboot\u0027,)"},{"line_number":89,"context_line":"    policy_rules \u003d ((\"compute\", \"compute:reboot\"),)"},{"line_number":90,"context_line":"    help_text \u003d _(\"Reset instances back to active state.\")"},{"line_number":91,"context_line":"    action_type \u003d \"danger\""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_0e1f5e5c","line":89,"updated":"2016-06-02 10:36:31.000000000","message":"ditto","commit_id":"b193e74ef84ce297e01c69f9e65c6a0fed88ae2d"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"a2272e4ab020bad5be1c0436725225c5d7b946b1","unresolved":false,"context_lines":[{"line_number":86,"context_line":"class ResetStateActive(policy.PolicyTargetMixin, tables.BatchAction):"},{"line_number":87,"context_line":"    name \u003d \"reset_state_active\""},{"line_number":88,"context_line":"    classes \u003d (\u0027btn-reboot\u0027,)"},{"line_number":89,"context_line":"    policy_rules \u003d ((\"compute\", \"compute:reboot\"),)"},{"line_number":90,"context_line":"    help_text \u003d _(\"Reset instances back to active state.\")"},{"line_number":91,"context_line":"    action_type \u003d \"danger\""},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_8b73374d","line":89,"in_reply_to":"9abb7d3a_0e1f5e5c","updated":"2016-06-05 22:51:28.000000000","message":"Done","commit_id":"b193e74ef84ce297e01c69f9e65c6a0fed88ae2d"},{"author":{"_account_id":14151,"name":"ziyu032","email":"chen.qiaomin@99cloud.net","username":"ziyu032"},"change_message_id":"1e8c2692588c7e0fb87c68676d119efdc8a0d70e","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        if instance is not None:"},{"line_number":103,"context_line":"            return ((instance.status \u003d\u003d \"ERROR\")"},{"line_number":104,"context_line":"                    and not is_deleting(instance))"},{"line_number":105,"context_line":"        else:"},{"line_number":106,"context_line":"            return True"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def action(self, request, obj_id):"},{"line_number":109,"context_line":"        api.nova.server_reset_state_active(request, obj_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1aa78d24_e6823bc7","line":106,"range":{"start_line":105,"start_character":8,"end_line":106,"end_character":23},"updated":"2016-07-07 06:57:36.000000000","message":"should return False?\nOr not need this \"else\".","commit_id":"b40e4ca62bbb777a99602def1cc5c8ee5921e078"}]}
