)]}'
{"doc/source/topics/settings.rst":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"6578bb19cdc09050a6ca060026ff61375238842f","unresolved":false,"context_lines":[{"line_number":883,"context_line":""},{"line_number":884,"context_line":"Default: ``\"legacy\"``"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"Valid values are  ``\"direct\"``, ``\"legacy\"`` (default) and ``False``. ``False``"},{"line_number":887,"context_line":"effectively disables image creation from a local file and is roughly equivalent"},{"line_number":888,"context_line":"to ``False`` value of deprecated setting HORIZON_IMAGES_ALLOW_UPLOAD. To enable"},{"line_number":889,"context_line":"image creation from local file as before, with piping the image file through"},{"line_number":890,"context_line":"Horizon\u0027s web-server set it to ``\"legacy\"``. This is equivalent to the ``True``"},{"line_number":891,"context_line":"value of HORIZON_IMAGES_ALLOW_UPLOAD. The new HORIZON_IMAGES_UPLOAD_MODE"},{"line_number":892,"context_line":"``\"direct\"`` option allows to bypass sending image file to web-server and send"},{"line_number":893,"context_line":"it to directly Glance server instead (just the file contents, metadata is processed"},{"line_number":894,"context_line":"as usual). This prevents filling up the web-server\u0027s filesystem free space,"},{"line_number":895,"context_line":"but requires a modern Web Browser and the CORS support enabled on Glance service"},{"line_number":896,"context_line":"side (otherwise browser would forbid the PUT request to a location different"},{"line_number":897,"context_line":"from the one form content came from). To enable CORS support for Glance service,"},{"line_number":898,"context_line":"you will need to edit [cors] section of glance-api.conf file, setting"},{"line_number":899,"context_line":"`allowed_origin` setting to the full hostname of the web server (say,"},{"line_number":900,"context_line":"http://\u003cHOST_IP\u003e/dashboard) and restart glance-api process. This is the preferred"},{"line_number":901,"context_line":"mode, but since it requires manually configuring Glance service, it is not enabled"},{"line_number":902,"context_line":"by default."},{"line_number":903,"context_line":""},{"line_number":904,"context_line":".. note::"},{"line_number":905,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"1aa78d24_288052f7","line":902,"range":{"start_line":886,"start_character":0,"end_line":902,"end_character":11},"updated":"2016-07-13 21:26:59.000000000","message":"Can you consider the following text instead?\n\nValid values are  ``\"direct\"``, ``\"legacy\"`` (default) and ``False``. ``False``\ndisables the ability to upload images via Horizon. It is equivalent\nto setting ``False`` on the deprecated setting ``HORIZON_IMAGES_ALLOW_UPLOAD``.\n``\"legacy\"`` enables local file upload by piping the image file through\nHorizon\u0027s web server. It is equivalent to setting ``True`` on the deprecated\nsetting ``HORIZON_IMAGES_ALLOW_UPLOAD``.\n``\"direct\"`` sends the image file directly from the web browser\nto Glance. This bypasses the horizon web server which both reduces network\nhops and prevents filling up the Horizon web server\u0027s filesystem. \n``\"direct\"`` is the preferred mode, but due to the following requirements\nit is not the default. The\n``\"direct\"`` setting requires a modern web browser, network access from\nthe browser to the public Glance endpoint, and CORS support to be enabled\non the Glance API service. Without CORS support, the browser will forbid\nthe PUT request to a location different than the Horizon server.\nTo enable CORS support for the Glance API service,\nyou will need to edit [cors] section of glance-api.conf file. Set\n`allowed_origin` to the full hostname of the horizon web server (e.g.\nhttp://\u003cHORIZON_IP\u003e/dashboard) and restart the glance-api process.","commit_id":"26d4544016fee535115ccabdd083d58870481e82"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"6222d494d6060d010842614a391f706e38c0e562","unresolved":false,"context_lines":[{"line_number":899,"context_line":"`allowed_origin` setting to the full hostname of the web server (say,"},{"line_number":900,"context_line":"http://\u003cHOST_IP\u003e/dashboard) and restart glance-api process. This is the preferred"},{"line_number":901,"context_line":"mode, but since it requires manually configuring Glance service, it is not enabled"},{"line_number":902,"context_line":"by default."},{"line_number":903,"context_line":""},{"line_number":904,"context_line":".. note::"},{"line_number":905,"context_line":""}],"source_content_type":"text/x-rst","patch_set":21,"id":"1aa78d24_832a098f","line":902,"in_reply_to":"1aa78d24_288052f7","updated":"2016-07-13 21:59:46.000000000","message":"Done","commit_id":"26d4544016fee535115ccabdd083d58870481e82"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"22a0b7a67407c3e7e2daf8185d6e51ba268ee7b8","unresolved":false,"context_lines":[{"line_number":886,"context_line":"Valid values are  ``\"direct\"``, ``\"legacy\"`` (default) and ``False``. ``False``"},{"line_number":887,"context_line":"disables the ability to upload images via Horizon. It is equivalent to setting"},{"line_number":888,"context_line":"``False`` on the deprecated setting ``HORIZON_IMAGES_ALLOW_UPLOAD``. ``legacy``"},{"line_number":889,"context_line":"enables local file upload by piping the image file through the Horizon\u0027s"},{"line_number":890,"context_line":"web-server. It is equivalent to setting ``True`` on the deprecated setting"},{"line_number":891,"context_line":"``HORIZON_IMAGES_ALLOW_UPLOAD``. ``direct`` sends the image file directly from"},{"line_number":892,"context_line":"the web browser to Glance. This bypasses the Horizon web-server which both"}],"source_content_type":"text/x-rst","patch_set":23,"id":"1aa78d24_ed3c6ec1","line":889,"range":{"start_line":889,"start_character":59,"end_line":889,"end_character":62},"updated":"2016-07-14 17:28:12.000000000","message":"nit (probably my fault. don\u0027t need \"the\")","commit_id":"dcbe6b2d4e861f8512d9d03ae93eec96bd8e751e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bdaddea8bedeb1a4ac75525a53ab9f730152c531","unresolved":false,"context_lines":[{"line_number":886,"context_line":"Valid values are  ``\"direct\"``, ``\"legacy\"`` (default) and ``False``. ``False``"},{"line_number":887,"context_line":"disables the ability to upload images via Horizon. It is equivalent to setting"},{"line_number":888,"context_line":"``False`` on the deprecated setting ``HORIZON_IMAGES_ALLOW_UPLOAD``. ``legacy``"},{"line_number":889,"context_line":"enables local file upload by piping the image file through the Horizon\u0027s"},{"line_number":890,"context_line":"web-server. It is equivalent to setting ``True`` on the deprecated setting"},{"line_number":891,"context_line":"``HORIZON_IMAGES_ALLOW_UPLOAD``. ``direct`` sends the image file directly from"},{"line_number":892,"context_line":"the web browser to Glance. This bypasses the Horizon web-server which both"}],"source_content_type":"text/x-rst","patch_set":23,"id":"1aa78d24_deccb663","line":889,"in_reply_to":"1aa78d24_ed3c6ec1","updated":"2016-07-14 17:49:55.000000000","message":"Done","commit_id":"dcbe6b2d4e861f8512d9d03ae93eec96bd8e751e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"22a0b7a67407c3e7e2daf8185d6e51ba268ee7b8","unresolved":false,"context_lines":[{"line_number":898,"context_line":"request to a location different than the Horizon server. To enable CORS support"},{"line_number":899,"context_line":"for Glance API service, you will need to edit [cors] section of glance-api.conf"},{"line_number":900,"context_line":"file. Set `allowed_origin` to the full hostname of the Horizon web server (e.g."},{"line_number":901,"context_line":"http://\u003cHOST_IP\u003e/dashboard) and restart glance-api process."},{"line_number":902,"context_line":""},{"line_number":903,"context_line":".. note::"},{"line_number":904,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"1aa78d24_00a2619a","line":901,"updated":"2016-07-14 17:28:12.000000000","message":"Probably should add a reference to this: http://docs.openstack.org/developer/oslo.middleware/cors.html#configuration-for-oslo-config\n\nBecause I had to go find this to figure out how to add a second origin.","commit_id":"dcbe6b2d4e861f8512d9d03ae93eec96bd8e751e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bdaddea8bedeb1a4ac75525a53ab9f730152c531","unresolved":false,"context_lines":[{"line_number":898,"context_line":"request to a location different than the Horizon server. To enable CORS support"},{"line_number":899,"context_line":"for Glance API service, you will need to edit [cors] section of glance-api.conf"},{"line_number":900,"context_line":"file. Set `allowed_origin` to the full hostname of the Horizon web server (e.g."},{"line_number":901,"context_line":"http://\u003cHOST_IP\u003e/dashboard) and restart glance-api process."},{"line_number":902,"context_line":""},{"line_number":903,"context_line":".. note::"},{"line_number":904,"context_line":""}],"source_content_type":"text/x-rst","patch_set":23,"id":"1aa78d24_1e73de16","line":901,"in_reply_to":"1aa78d24_00a2619a","updated":"2016-07-14 17:49:55.000000000","message":"Done","commit_id":"dcbe6b2d4e861f8512d9d03ae93eec96bd8e751e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"cb948bbcd6f23907182e2fc00d0b8eb2284c280b","unresolved":false,"context_lines":[{"line_number":883,"context_line":""},{"line_number":884,"context_line":"Default: ``\"legacy\"``"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"Valid values are  ``\"direct\"``, ``\"legacy\"`` (default) and ``False``. ``False``"},{"line_number":887,"context_line":"disables the ability to upload images via Horizon. It is equivalent to setting"},{"line_number":888,"context_line":"``False`` on the deprecated setting ``HORIZON_IMAGES_ALLOW_UPLOAD``. ``legacy``"},{"line_number":889,"context_line":"enables local file upload by piping the image file through the Horizon\u0027s"}],"source_content_type":"text/x-rst","patch_set":24,"id":"1aa78d24_c2e68f43","line":886,"updated":"2016-07-14 23:14:10.000000000","message":"I would prefer to see the third value be \"disabled\" rather than a different type to the other two values.","commit_id":"bac92d9f3401b4f28054f0edd2f88ff91e6decdf"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f9e7369ee4ab11e052d9ca9e7a1532fd4d21c926","unresolved":false,"context_lines":[{"line_number":907,"context_line":"    To maintain the compatibility with the deprecated HORIZON_IMAGES_ALLOW_UPLOAD"},{"line_number":908,"context_line":"    setting, neither ``\"direct\"``, nor ``\"legacy\"`` modes will have an effect if"},{"line_number":909,"context_line":"    HORIZON_IMAGES_ALLOW_UPLOAD is set to ``False`` - as if HORIZON_IMAGES_UPLOAD_MODE"},{"line_number":910,"context_line":"    was set to ``False`` itself. When HORIZON_IMAGES_ALLOW_UPLOAD is set to ``True``,"},{"line_number":911,"context_line":"    all three modes are considered, as if HORIZON_IMAGES_ALLOW_UPLOAD setting"},{"line_number":912,"context_line":"    was removed."},{"line_number":913,"context_line":""}],"source_content_type":"text/x-rst","patch_set":25,"id":"fad55976_bb4bf558","line":910,"updated":"2016-07-15 20:34:47.000000000","message":".. set to \"off\" itself.","commit_id":"bcd6134302bc76075a165d078633f0f763db4e73"}],"openstack_dashboard/api/glance.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"22a0b7a67407c3e7e2daf8185d6e51ba268ee7b8","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        base_dict \u003d super(ExternallyUploadedImage, self).to_dict()"},{"line_number":225,"context_line":"        base_dict.update({"},{"line_number":226,"context_line":"            \u0027upload_url\u0027: self._url,"},{"line_number":227,"context_line":"            \u0027token_id\u0027: self._token_id"},{"line_number":228,"context_line":"        })"},{"line_number":229,"context_line":"        return base_dict"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1aa78d24_6d7cfeeb","line":227,"updated":"2016-07-14 17:28:12.000000000","message":"Ideally, I\u0027d like to see this patch go through:\n\nhttps://review.openstack.org/#/c/311189\n\nAnd then use the token from it via,\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/openstack-service-api/user-session.service.js#L69\n\nHowever, I will not block this patch since the setting you\u0027ve added still provides control over the token and even if the token is provided via that other patch, the upload settings you put here still would be necessary.\n\n^ You do not have to do this to get my +2.","commit_id":"dcbe6b2d4e861f8512d9d03ae93eec96bd8e751e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bdaddea8bedeb1a4ac75525a53ab9f730152c531","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        base_dict \u003d super(ExternallyUploadedImage, self).to_dict()"},{"line_number":225,"context_line":"        base_dict.update({"},{"line_number":226,"context_line":"            \u0027upload_url\u0027: self._url,"},{"line_number":227,"context_line":"            \u0027token_id\u0027: self._token_id"},{"line_number":228,"context_line":"        })"},{"line_number":229,"context_line":"        return base_dict"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1aa78d24_59858057","line":227,"in_reply_to":"1aa78d24_6d7cfeeb","updated":"2016-07-14 17:49:55.000000000","message":"Let\u0027s reuse Kevin\u0027s work here as soon as it\u0027s merged :).","commit_id":"dcbe6b2d4e861f8512d9d03ae93eec96bd8e751e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bda55b30b5aa3bf73586ba066c8e15606f586f80","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                LOG.warning(msg)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def get_image_upload_mode():"},{"line_number":208,"context_line":"    if getattr(settings, \u0027HORIZON_IMAGES_ALLOW_UPLOAD\u0027, None) is False:"},{"line_number":209,"context_line":"        return False"},{"line_number":210,"context_line":"    mode \u003d getattr(settings, \u0027HORIZON_IMAGES_UPLOAD_MODE\u0027, \u0027legacy\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"fad55976_5489f1c9","line":207,"updated":"2016-07-15 17:03:22.000000000","message":"I\u0027m not sure that having this function still return different data types fully addresses Richard\u0027s previous concerns. Will need to see his thoughts here.","commit_id":"bcd6134302bc76075a165d078633f0f763db4e73"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f9e7369ee4ab11e052d9ca9e7a1532fd4d21c926","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                LOG.warning(msg)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def get_image_upload_mode():"},{"line_number":208,"context_line":"    if getattr(settings, \u0027HORIZON_IMAGES_ALLOW_UPLOAD\u0027, None) is False:"},{"line_number":209,"context_line":"        return False"},{"line_number":210,"context_line":"    mode \u003d getattr(settings, \u0027HORIZON_IMAGES_UPLOAD_MODE\u0027, \u0027legacy\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"fad55976_7bafbde3","line":207,"in_reply_to":"fad55976_5489f1c9","updated":"2016-07-15 20:34:47.000000000","message":"Yep. The \"legacy\" usage of this function treats the value as boolean, but the there\u0027s other usages which look at the string.\n\nI think this needs to be two functions. One of them is_image_upload_allowed() returning boolean and the other get_image_upload_mode() which returns string.","commit_id":"bcd6134302bc76075a165d078633f0f763db4e73"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"d98d3ea1e16378cae25036b057505718f75b5ed8","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                LOG.warning(msg)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def get_image_upload_mode():"},{"line_number":208,"context_line":"    if getattr(settings, \u0027HORIZON_IMAGES_ALLOW_UPLOAD\u0027, None) is False:"},{"line_number":209,"context_line":"        return False"},{"line_number":210,"context_line":"    mode \u003d getattr(settings, \u0027HORIZON_IMAGES_UPLOAD_MODE\u0027, \u0027legacy\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"dada55a8_23c7e646","line":207,"in_reply_to":"fad55976_61cb8a73","updated":"2016-07-17 23:45:24.000000000","message":"Seems reasonable to me. I\u0027m just afraid we\u0027ll then have a bunch of tests in code for get_image_upload_mode() \u003d\u003d \u0027off\u0027 ...","commit_id":"bcd6134302bc76075a165d078633f0f763db4e73"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"d4166aa8ff18ada2a73bcaf608495d2a368bc6de","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                LOG.warning(msg)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def get_image_upload_mode():"},{"line_number":208,"context_line":"    if getattr(settings, \u0027HORIZON_IMAGES_ALLOW_UPLOAD\u0027, None) is False:"},{"line_number":209,"context_line":"        return False"},{"line_number":210,"context_line":"    mode \u003d getattr(settings, \u0027HORIZON_IMAGES_UPLOAD_MODE\u0027, \u0027legacy\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"fad55976_a18d827d","line":207,"in_reply_to":"fad55976_7bafbde3","updated":"2016-07-15 21:29:54.000000000","message":"Then only reason for having this as a function was to hide the complexity of deprecating one setting and introducing a new one behind a simple facade. Two functions are as bad as 2 settings, so I think, I\u0027ll just use 2 settings.","commit_id":"bcd6134302bc76075a165d078633f0f763db4e73"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"1cdd6895d16dd8ce930b710eafcff34751a91d8b","unresolved":false,"context_lines":[{"line_number":204,"context_line":"                LOG.warning(msg)"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"def get_image_upload_mode():"},{"line_number":208,"context_line":"    if getattr(settings, \u0027HORIZON_IMAGES_ALLOW_UPLOAD\u0027, None) is False:"},{"line_number":209,"context_line":"        return False"},{"line_number":210,"context_line":"    mode \u003d getattr(settings, \u0027HORIZON_IMAGES_UPLOAD_MODE\u0027, \u0027legacy\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"fad55976_61cb8a73","line":207,"in_reply_to":"fad55976_a18d827d","updated":"2016-07-15 21:32:31.000000000","message":"Another thought, Richard: how would you look upon it, if get_image_upload_mode() returned \u0027off\u0027 in case HORIZON_IMAGES_ALLOW_UPLOAD was False, regardless of what value HORIZON_IMAGES_UPLOAD_MODE had? I would still prefer to have one setting/function for reducing code complexity.","commit_id":"bcd6134302bc76075a165d078633f0f763db4e73"}],"openstack_dashboard/settings.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"22a0b7a67407c3e7e2daf8185d6e51ba268ee7b8","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# Horizon server. When enabled, a file form field will appear on the create"},{"line_number":86,"context_line":"# image form. If set to False, there will be no file form field on the create"},{"line_number":87,"context_line":"# image form. See documentation for deployment considerations."},{"line_number":88,"context_line":"HORIZON_IMAGES_UPLOAD_MODE \u003d \u0027legacy\u0027"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# The OPENSTACK_IMAGE_BACKEND settings can be used to customize features"},{"line_number":91,"context_line":"# in the OpenStack Dashboard related to the Image service, such as the list"}],"source_content_type":"text/x-python","patch_set":23,"id":"1aa78d24_3e8fba76","line":88,"updated":"2016-07-14 17:28:12.000000000","message":"Just spoke with Dave about this.  Since you have the defaults set in code [0], you shouldn\u0027t but this in settings.py. This section should actual be moved to local_settings.py.example (but commented out) \n\n[0] https://review.openstack.org/#/c/317365/23/openstack_dashboard/api/glance.py","commit_id":"dcbe6b2d4e861f8512d9d03ae93eec96bd8e751e"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"bdaddea8bedeb1a4ac75525a53ab9f730152c531","unresolved":false,"context_lines":[{"line_number":85,"context_line":"# Horizon server. When enabled, a file form field will appear on the create"},{"line_number":86,"context_line":"# image form. If set to False, there will be no file form field on the create"},{"line_number":87,"context_line":"# image form. See documentation for deployment considerations."},{"line_number":88,"context_line":"HORIZON_IMAGES_UPLOAD_MODE \u003d \u0027legacy\u0027"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"# The OPENSTACK_IMAGE_BACKEND settings can be used to customize features"},{"line_number":91,"context_line":"# in the OpenStack Dashboard related to the Image service, such as the list"}],"source_content_type":"text/x-python","patch_set":23,"id":"1aa78d24_3efb3a49","line":88,"in_reply_to":"1aa78d24_3e8fba76","updated":"2016-07-14 17:49:55.000000000","message":"Done","commit_id":"dcbe6b2d4e861f8512d9d03ae93eec96bd8e751e"}],"openstack_dashboard/test/settings.py":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"6578bb19cdc09050a6ca060026ff61375238842f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"HORIZON_CONFIG[\u0027swift_panel\u0027] \u003d \u0027legacy\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"find_static_files(HORIZON_CONFIG)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"# Set to \"legacy\" to allow users to upload images to glance via Horizon server."},{"line_number":107,"context_line":"# When enabled, a file form field will appear on the create image form."},{"line_number":108,"context_line":"# See documentation for deployment considerations."}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_a8c28232","line":105,"updated":"2016-07-13 21:26:59.000000000","message":"Missing the \"direct\" docs from the non-test settings.py","commit_id":"26d4544016fee535115ccabdd083d58870481e82"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"6222d494d6060d010842614a391f706e38c0e562","unresolved":false,"context_lines":[{"line_number":102,"context_line":"HORIZON_CONFIG[\u0027swift_panel\u0027] \u003d \u0027legacy\u0027"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"find_static_files(HORIZON_CONFIG)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"# Set to \"legacy\" to allow users to upload images to glance via Horizon server."},{"line_number":107,"context_line":"# When enabled, a file form field will appear on the create image form."},{"line_number":108,"context_line":"# See documentation for deployment considerations."}],"source_content_type":"text/x-python","patch_set":21,"id":"1aa78d24_fe0ba022","line":105,"in_reply_to":"1aa78d24_a8c28232","updated":"2016-07-13 21:59:46.000000000","message":"Done","commit_id":"26d4544016fee535115ccabdd083d58870481e82"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f9e7369ee4ab11e052d9ca9e7a1532fd4d21c926","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"# Set to \u0027legacy\u0027 or \u0027direct\u0027 to allow users to upload images to glance via"},{"line_number":107,"context_line":"# Horizon server. When enabled, a file form field will appear on the create"},{"line_number":108,"context_line":"# image form. If set to False, there will be no file form field on the create"},{"line_number":109,"context_line":"# image form. See documentation for deployment considerations."},{"line_number":110,"context_line":"HORIZON_IMAGES_UPLOAD_MODE \u003d \u0027legacy\u0027"},{"line_number":111,"context_line":""}],"source_content_type":"text/x-python","patch_set":25,"id":"fad55976_3b7c2572","line":108,"updated":"2016-07-15 20:34:47.000000000","message":"s/False/\"off\"","commit_id":"bcd6134302bc76075a165d078633f0f763db4e73"}]}
