)]}'
{"horizon/static/framework/widgets/wizard/wizard.controller.js":[{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"3a53ccbfa47f88e7822caf8b723e79cee1c88c62","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    function showError(errorMessage) {"},{"line_number":96,"context_line":"      viewModel.showSpinner \u003d false;"},{"line_number":97,"context_line":"      if (errorMessage \u0026\u0026 angular.isString(errorMessage.data)) {"},{"line_number":98,"context_line":"        viewModel.errorMessage \u003d errorMessage.data;"},{"line_number":99,"context_line":"        viewModel.hasError \u003d true;"},{"line_number":100,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":5,"id":"7aa08908_d1d63fc2","line":97,"range":{"start_line":97,"start_character":56,"end_line":97,"end_character":60},"updated":"2016-06-10 21:52:41.000000000","message":"-1: I\u0027d revert this entire hunk. using \".data\" sort of assumes that the error is the error handler from a http request. \n\nInstead, I think the wizard controller behavior is basically correct, displaying whatever errorMessage the consumer provides. \n\nIn this case, create.action.service.js makes the mistake of not providing a glance.createImage error handler to translate the server side error message into client-side,  \"create image\" specific error string appropriate for the createImageWorkflow. \n\nIt isn\u0027t really the wizards fault that create.action.service.js told it to display an object.  At most, the isString check might be helpful.","commit_id":"7afcc02d01e8384cb7ca6a2b2a1bf6171271cca4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"2fcc83c8e3f05445901579539c5441a570801b4b","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    function showError(errorMessage) {"},{"line_number":96,"context_line":"      viewModel.showSpinner \u003d false;"},{"line_number":97,"context_line":"      if (errorMessage \u0026\u0026 angular.isString(errorMessage.data)) {"},{"line_number":98,"context_line":"        viewModel.errorMessage \u003d errorMessage.data;"},{"line_number":99,"context_line":"        viewModel.hasError \u003d true;"},{"line_number":100,"context_line":"      }"}],"source_content_type":"text/javascript","patch_set":5,"id":"7aa08908_8219ced3","line":97,"range":{"start_line":97,"start_character":56,"end_line":97,"end_character":60},"in_reply_to":"7aa08908_d1d63fc2","updated":"2016-06-17 19:51:18.000000000","message":"I\u0027m changing the behavior to not assume a .data element, but understand that API calls for a submit() is a normal case; in fact it is the most common case.  A wizard\u0027s \u0027submit\u0027 member is associated with a promise from an API call in most cases.  We can push the handling around to another area, but we shouldn\u0027t push it onto the services to register functions that aren\u0027t API-promise-based.","commit_id":"7afcc02d01e8384cb7ca6a2b2a1bf6171271cca4"}]}
