)]}'
{"openstack_dashboard/dashboards/project/volumes/volumes/forms.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"50a98b4810cd087146b78ec13abadc764ebd1eac","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":714,"context_line":"        super(ExtendForm, self).__init__(request, *args, **kwargs)"},{"line_number":715,"context_line":"        min_value \u003d self.initial[\u0027orig_size\u0027]"},{"line_number":716,"context_line":"        self.fields[\u0027new_size\u0027] \u003d forms.IntegerField(label\u003d_(\"New Size (GiB)\"),"},{"line_number":717,"context_line":"                                                     min_value\u003d(min_value + 1),"},{"line_number":718,"context_line":"                                                     initial\u003d(min_value + 1))"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    def clean(self):"},{"line_number":721,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_0727ec12","line":718,"range":{"start_line":716,"start_character":34,"end_line":718,"end_character":77},"updated":"2016-05-25 11:14:22.000000000","message":"only need to set min_value and initial attributes of new size here instead of creating a new IntegerField object.","commit_id":"fe9b5d08e5c7a097cb24438924234cf50af6770c"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"41b563e5296d0159edddb4a108f66c4633f82bee","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":714,"context_line":"        super(ExtendForm, self).__init__(request, *args, **kwargs)"},{"line_number":715,"context_line":"        min_value \u003d self.initial[\u0027orig_size\u0027]"},{"line_number":716,"context_line":"        self.fields[\u0027new_size\u0027] \u003d forms.IntegerField(label\u003d_(\"New Size (GiB)\"),"},{"line_number":717,"context_line":"                                                     min_value\u003d(min_value + 1),"},{"line_number":718,"context_line":"                                                     initial\u003d(min_value + 1))"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    def clean(self):"},{"line_number":721,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_28db947d","line":718,"range":{"start_line":716,"start_character":34,"end_line":718,"end_character":77},"in_reply_to":"bab6814e_0727ec12","updated":"2016-05-26 15:15:20.000000000","message":"This ensures that the minimum size that can be selected is 1 GiB greater than the current size. The only way I could figure out how to do this was to initialize the form with the minimum value of x+1","commit_id":"fe9b5d08e5c7a097cb24438924234cf50af6770c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"059700813b82bdf3daa163244eb5ab3f74241712","unresolved":false,"context_lines":[{"line_number":713,"context_line":"    def __init__(self, request, *args, **kwargs):"},{"line_number":714,"context_line":"        super(ExtendForm, self).__init__(request, *args, **kwargs)"},{"line_number":715,"context_line":"        min_value \u003d self.initial[\u0027orig_size\u0027]"},{"line_number":716,"context_line":"        self.fields[\u0027new_size\u0027] \u003d forms.IntegerField(label\u003d_(\"New Size (GiB)\"),"},{"line_number":717,"context_line":"                                                     min_value\u003d(min_value + 1),"},{"line_number":718,"context_line":"                                                     initial\u003d(min_value + 1))"},{"line_number":719,"context_line":""},{"line_number":720,"context_line":"    def clean(self):"},{"line_number":721,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_c354ff22","line":718,"range":{"start_line":716,"start_character":34,"end_line":718,"end_character":77},"in_reply_to":"bab6814e_28db947d","updated":"2016-06-02 15:24:17.000000000","message":"if you have to initialize the form here again, the lable and min_value in L711 seems unnecessary.","commit_id":"fe9b5d08e5c7a097cb24438924234cf50af6770c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"50a98b4810cd087146b78ec13abadc764ebd1eac","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"},{"line_number":722,"context_line":"        new_size \u003d cleaned_data.get(\u0027new_size\u0027)"},{"line_number":723,"context_line":"        orig_size \u003d self.initial[\u0027orig_size\u0027]"},{"line_number":724,"context_line":"        if not new_size:"},{"line_number":725,"context_line":"            new_size \u003d 0"},{"line_number":726,"context_line":"        if new_size \u003c\u003d orig_size:"},{"line_number":727,"context_line":"            error_msg \u003d _(\"New size must be greater than current size.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_27f83049","line":724,"range":{"start_line":724,"start_character":7,"end_line":724,"end_character":24},"updated":"2016-05-25 11:14:22.000000000","message":"not sure how this could happen, it has a min_value and it\u0027s a required field.","commit_id":"fe9b5d08e5c7a097cb24438924234cf50af6770c"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"0e5186556fa3daac2a924a374d8b8893fec2a642","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"},{"line_number":722,"context_line":"        new_size \u003d cleaned_data.get(\u0027new_size\u0027)"},{"line_number":723,"context_line":"        orig_size \u003d self.initial[\u0027orig_size\u0027]"},{"line_number":724,"context_line":"        if not new_size:"},{"line_number":725,"context_line":"            new_size \u003d 0"},{"line_number":726,"context_line":"        if new_size \u003c\u003d orig_size:"},{"line_number":727,"context_line":"            error_msg \u003d _(\"New size must be greater than current size.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_abb9d330","line":724,"range":{"start_line":724,"start_character":7,"end_line":724,"end_character":24},"in_reply_to":"9abb7d3a_160f3a89","updated":"2016-06-05 21:32:35.000000000","message":"Hello, any hints on how to go about writing a test for min_value validation. I took a stab at it but got completely lost.","commit_id":"fe9b5d08e5c7a097cb24438924234cf50af6770c"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"184afeb474183daf4ba041fa29a55e6037fc9b23","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"},{"line_number":722,"context_line":"        new_size \u003d cleaned_data.get(\u0027new_size\u0027)"},{"line_number":723,"context_line":"        orig_size \u003d self.initial[\u0027orig_size\u0027]"},{"line_number":724,"context_line":"        if not new_size:"},{"line_number":725,"context_line":"            new_size \u003d 0"},{"line_number":726,"context_line":"        if new_size \u003c\u003d orig_size:"},{"line_number":727,"context_line":"            error_msg \u003d _(\"New size must be greater than current size.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_c616b654","line":724,"range":{"start_line":724,"start_character":7,"end_line":724,"end_character":24},"in_reply_to":"9abb7d3a_9ec36a8a","updated":"2016-06-02 22:30:24.000000000","message":"You are probably right. Its this weird py34 issue I have faced in a couple of my other patches. When it runs the tests (tox -e py34), somehow new_size gets set back to None. I have not been able to figure out why it does this. But have had it happen in 2 of my other patchsets.","commit_id":"fe9b5d08e5c7a097cb24438924234cf50af6770c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"c4ba13d58b797ff21b42dc60a738e918c13971bf","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"},{"line_number":722,"context_line":"        new_size \u003d cleaned_data.get(\u0027new_size\u0027)"},{"line_number":723,"context_line":"        orig_size \u003d self.initial[\u0027orig_size\u0027]"},{"line_number":724,"context_line":"        if not new_size:"},{"line_number":725,"context_line":"            new_size \u003d 0"},{"line_number":726,"context_line":"        if new_size \u003c\u003d orig_size:"},{"line_number":727,"context_line":"            error_msg \u003d _(\"New size must be greater than current size.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_160f3a89","line":724,"range":{"start_line":724,"start_character":7,"end_line":724,"end_character":24},"in_reply_to":"9abb7d3a_c616b654","updated":"2016-06-03 07:45:02.000000000","message":"I think that\u0027s because it doesn\u0027t pass the min_value validator, you need to change the test case for min_value check instead of the old behavior.","commit_id":"fe9b5d08e5c7a097cb24438924234cf50af6770c"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"41b563e5296d0159edddb4a108f66c4633f82bee","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"},{"line_number":722,"context_line":"        new_size \u003d cleaned_data.get(\u0027new_size\u0027)"},{"line_number":723,"context_line":"        orig_size \u003d self.initial[\u0027orig_size\u0027]"},{"line_number":724,"context_line":"        if not new_size:"},{"line_number":725,"context_line":"            new_size \u003d 0"},{"line_number":726,"context_line":"        if new_size \u003c\u003d orig_size:"},{"line_number":727,"context_line":"            error_msg \u003d _(\"New size must be greater than current size.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_6843dcaf","line":724,"range":{"start_line":724,"start_character":7,"end_line":724,"end_character":24},"in_reply_to":"bab6814e_27f83049","updated":"2016-05-26 15:15:20.000000000","message":"Just additional error checking. the py34 test run of extend_volume_with_wrong_size was failing due to new_size being set to \u0027None\u0027","commit_id":"fe9b5d08e5c7a097cb24438924234cf50af6770c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"059700813b82bdf3daa163244eb5ab3f74241712","unresolved":false,"context_lines":[{"line_number":721,"context_line":"        cleaned_data \u003d super(ExtendForm, self).clean()"},{"line_number":722,"context_line":"        new_size \u003d cleaned_data.get(\u0027new_size\u0027)"},{"line_number":723,"context_line":"        orig_size \u003d self.initial[\u0027orig_size\u0027]"},{"line_number":724,"context_line":"        if not new_size:"},{"line_number":725,"context_line":"            new_size \u003d 0"},{"line_number":726,"context_line":"        if new_size \u003c\u003d orig_size:"},{"line_number":727,"context_line":"            error_msg \u003d _(\"New size must be greater than current size.\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"9abb7d3a_9ec36a8a","line":724,"range":{"start_line":724,"start_character":7,"end_line":724,"end_character":24},"in_reply_to":"bab6814e_6843dcaf","updated":"2016-06-02 15:24:17.000000000","message":"if so, I think you should change the test case, seems you do all this is just to make an old unit test happy, you already added min_value, this check is not needed any more.","commit_id":"fe9b5d08e5c7a097cb24438924234cf50af6770c"},{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"50a98b4810cd087146b78ec13abadc764ebd1eac","unresolved":false,"context_lines":[{"line_number":723,"context_line":"        orig_size \u003d self.initial[\u0027orig_size\u0027]"},{"line_number":724,"context_line":"        if not new_size:"},{"line_number":725,"context_line":"            new_size \u003d 0"},{"line_number":726,"context_line":"        if new_size \u003c\u003d orig_size:"},{"line_number":727,"context_line":"            error_msg \u003d _(\"New size must be greater than current size.\")"},{"line_number":728,"context_line":"            self._errors[\u0027new_size\u0027] \u003d self.error_class([error_msg])"},{"line_number":729,"context_line":"            return cleaned_data"}],"source_content_type":"text/x-python","patch_set":7,"id":"bab6814e_27a67053","line":726,"range":{"start_line":726,"start_character":7,"end_line":726,"end_character":33},"updated":"2016-05-25 11:14:22.000000000","message":"Is this also needed if you added a min_value?","commit_id":"fe9b5d08e5c7a097cb24438924234cf50af6770c"}],"openstack_dashboard/dashboards/project/volumes/volumes/tests.py":[{"author":{"_account_id":8984,"name":"George Peristerakis","email":"gperiste@redhat.com","username":"peristeri"},"change_message_id":"93d4b60273c8697faf5679deb2450deaefb557ee","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"        redirect_url \u003d VOLUME_INDEX_URL"},{"line_number":1500,"context_line":"        self.assertRedirectsNoFollow(res, redirect_url)"},{"line_number":1501,"context_line":""},{"line_number":1502,"context_line":"    @test.create_stubs({cinder: (\u0027volume_get\u0027,),"},{"line_number":1503,"context_line":"                        quotas: (\u0027tenant_limit_usages\u0027,)})"},{"line_number":1504,"context_line":"    def test_extend_volume_with_wrong_size(self):"},{"line_number":1505,"context_line":"        volume \u003d self.cinder_volumes.first()"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_93d877f1","side":"PARENT","line":1502,"updated":"2016-05-18 15:08:45.000000000","message":"Why remove this test?\n\nThe test should show the ability for the form to handle incorrect input, even if the form now has validation.","commit_id":"fc06637e4a27e7c67d8f34605eed505c8c61e5e4"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8d66533121bbbccdc9399fe8c17c35833bc66d22","unresolved":false,"context_lines":[{"line_number":1499,"context_line":"        redirect_url \u003d VOLUME_INDEX_URL"},{"line_number":1500,"context_line":"        self.assertRedirectsNoFollow(res, redirect_url)"},{"line_number":1501,"context_line":""},{"line_number":1502,"context_line":"        @test.create_stubs({cinder: (\u0027volume_get\u0027,),"},{"line_number":1503,"context_line":"                            quotas: (\u0027tenant_limit_usages\u0027,)})"},{"line_number":1504,"context_line":"        def test_extend_volume_with_wrong_size(self):"},{"line_number":1505,"context_line":"            volume \u003d self.cinder_volumes.first()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bab6814e_cbbd11d9","line":1502,"updated":"2016-05-19 00:27:58.000000000","message":"Indentation seems not to be correct.","commit_id":"27d35960296869e6579eccd857b8eb3aed5cf5c1"}]}
