)]}'
{"openstack_dashboard/dashboards/project/instances/tables.py":[{"author":{"_account_id":10442,"name":"Masco Kaliyamoorthy","email":"mkaliyam@redhat.com","username":"masco"},"change_message_id":"7bc974b7e23f27164a88db6b16a0cfd2e13dab35","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        )"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"    def allowed(self, request, instance):"},{"line_number":173,"context_line":"        if instance and getattr(instance, \u0027locked\u0027, False):"},{"line_number":174,"context_line":"            return False"},{"line_number":175,"context_line":"        if instance:"},{"line_number":176,"context_line":"            return (instance.status in ACTIVE_STATES and"},{"line_number":177,"context_line":"                    not is_deleting(instance))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_3d0c98ec","line":174,"range":{"start_line":173,"start_character":8,"end_line":174,"end_character":24},"updated":"2016-05-20 04:56:05.000000000","message":"you have added one more condition here. which is not mentioned either in commit message or bug report. please update the commit message for future reference.","commit_id":"678ecd24215d6ebf0a21478eb5379ef386426a9c"}],"openstack_dashboard/dashboards/project/instances/tests.py":[{"author":{"_account_id":6610,"name":"Zhenguo Niu","email":"Niu.ZGlinux@gmail.com","username":"niu-zglinux"},"change_message_id":"f3b3277f699adbf199ad69170d4f826c13a9a1da","unresolved":false,"context_lines":[{"line_number":5382,"context_line":"        self.assertTrue(self.soft_reboot_instance.allowed(self.client.request,"},{"line_number":5383,"context_line":"                                                          self.server))"},{"line_number":5384,"context_line":""},{"line_number":5385,"context_line":"    def test_not_allowed_non_active(self):"},{"line_number":5386,"context_line":"        \"\"\"Soft reboot of a non-active server is not allowed"},{"line_number":5387,"context_line":"        \"\"\""},{"line_number":5388,"context_line":"        self.server.status \u003d \"SHUTOFF\""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_5f14a54b","line":5385,"range":{"start_line":5385,"start_character":7,"end_line":5385,"end_character":35},"updated":"2016-05-23 08:21:24.000000000","message":"why not do these tests in InstanceTests like test_soft_reboot_instance_shelved? or you may need to move thoses tests here.","commit_id":"b2b98d076cca3fbe1b905fbce4b3635397be995c"},{"author":{"_account_id":21795,"name":"Vijay Katam","email":"vijkatam@cisco.com","username":"vijkatam"},"change_message_id":"056e4ae108f1c81532294726def17f47ae7ac56f","unresolved":false,"context_lines":[{"line_number":5382,"context_line":"        self.assertTrue(self.soft_reboot_instance.allowed(self.client.request,"},{"line_number":5383,"context_line":"                                                          self.server))"},{"line_number":5384,"context_line":""},{"line_number":5385,"context_line":"    def test_not_allowed_non_active(self):"},{"line_number":5386,"context_line":"        \"\"\"Soft reboot of a non-active server is not allowed"},{"line_number":5387,"context_line":"        \"\"\""},{"line_number":5388,"context_line":"        self.server.status \u003d \"SHUTOFF\""}],"source_content_type":"text/x-python","patch_set":2,"id":"bab6814e_4ae7b0ab","line":5385,"range":{"start_line":5385,"start_character":7,"end_line":5385,"end_character":35},"in_reply_to":"bab6814e_5f14a54b","updated":"2016-06-08 21:13:49.000000000","message":"These tests are much more focused testing exactly the change that was made. The tests above are gnarly and having to assert content in a message cookie is not very clean. I wrote those as well to be consistent with existing ones but I prefer focused unit tests like these.","commit_id":"b2b98d076cca3fbe1b905fbce4b3635397be995c"}]}