)]}'
{"openstack_dashboard/static/app/core/core.module.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"25d370ffe9f816c30258e591cfc4186e0ad26359","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027horizon.framework.util\u0027,"},{"line_number":39,"context_line":"      \u0027horizon.framework.widgets\u0027,"},{"line_number":40,"context_line":"      \u0027horizon.dashboard.project.workflow\u0027"},{"line_number":41,"context_line":"    ], config)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  config.$inject \u003d [\u0027$provide\u0027, \u0027$windowProvider\u0027, \u0027$routeProvider\u0027];"},{"line_number":44,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"9abb7d3a_32063720","line":41,"updated":"2016-06-01 15:16:28.000000000","message":"Add a semicolon here","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1e46a095d0ba120d47963026a0ddc3a44ecd658c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"      \u0027horizon.framework.util\u0027,"},{"line_number":39,"context_line":"      \u0027horizon.framework.widgets\u0027,"},{"line_number":40,"context_line":"      \u0027horizon.dashboard.project.workflow\u0027"},{"line_number":41,"context_line":"    ], config)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  config.$inject \u003d [\u0027$provide\u0027, \u0027$windowProvider\u0027, \u0027$routeProvider\u0027];"},{"line_number":44,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_0bbbc773","line":41,"in_reply_to":"9abb7d3a_32063720","updated":"2016-06-06 02:43:42.000000000","message":"I got the point.","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"}],"openstack_dashboard/static/app/core/volumes/details/drawer.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"7855102689f228f7d6744fa9635fc7f68d9cbee6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":21,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":22,"context_line":"    \u003cdt translate\u003eTransfer\u003c/dt\u003e"},{"line_number":23,"context_line":"    \u003cdd\u003e{$ itemm.transfer | noValue $}\u003c/dd\u003e"},{"line_number":24,"context_line":"  \u003c/dl\u003e"},{"line_number":25,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":26,"context_line":"    \u003cdt translate\u003eVolume Image Metadata\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"3aaa91ec_c5cdeeb8","line":23,"updated":"2016-06-22 22:28:00.000000000","message":"item*","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"51714c8069724155a7dd5fea4931512718d44986","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\u003cdiv class\u003d\"row\"\u003e"},{"line_number":21,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":22,"context_line":"    \u003cdt translate\u003eTransfer\u003c/dt\u003e"},{"line_number":23,"context_line":"    \u003cdd\u003e{$ itemm.transfer | noValue $}\u003c/dd\u003e"},{"line_number":24,"context_line":"  \u003c/dl\u003e"},{"line_number":25,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":26,"context_line":"    \u003cdt translate\u003eVolume Image Metadata\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"3aaa91ec_9d2deb48","line":23,"in_reply_to":"3aaa91ec_c5cdeeb8","updated":"2016-06-23 08:02:05.000000000","message":"Done","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"7855102689f228f7d6744fa9635fc7f68d9cbee6","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  \u003c/dl\u003e"},{"line_number":25,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":26,"context_line":"    \u003cdt translate\u003eVolume Image Metadata\u003c/dt\u003e"},{"line_number":27,"context_line":"    \u003cdd\u003e{$ itemm.volume_image_metadata | noValue $}\u003c/dd\u003e"},{"line_number":28,"context_line":"  \u003c/dl\u003e"},{"line_number":29,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":30,"context_line":"    \u003cdt translate\u003eCreated At\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"3aaa91ec_45ba9e0b","line":27,"updated":"2016-06-22 22:28:00.000000000","message":"item*","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"51714c8069724155a7dd5fea4931512718d44986","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  \u003c/dl\u003e"},{"line_number":25,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":26,"context_line":"    \u003cdt translate\u003eVolume Image Metadata\u003c/dt\u003e"},{"line_number":27,"context_line":"    \u003cdd\u003e{$ itemm.volume_image_metadata | noValue $}\u003c/dd\u003e"},{"line_number":28,"context_line":"  \u003c/dl\u003e"},{"line_number":29,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":30,"context_line":"    \u003cdt translate\u003eCreated At\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":3,"id":"3aaa91ec_dd277362","line":27,"in_reply_to":"3aaa91ec_45ba9e0b","updated":"2016-06-23 08:02:05.000000000","message":"Done","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"dbfbf324e2ee0343173d982b416b2a39045e1608","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  \u003c/dl\u003e"},{"line_number":25,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":26,"context_line":"    \u003cdt translate\u003eVolume Image Metadata\u003c/dt\u003e"},{"line_number":27,"context_line":"    \u003cdd\u003e{$ item.volume_image_metadata | noValue $}\u003c/dd\u003e"},{"line_number":28,"context_line":"  \u003c/dl\u003e"},{"line_number":29,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":30,"context_line":"    \u003cdt translate\u003eCreated At\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"3aaa91ec_f51f78b4","line":27,"updated":"2016-06-25 01:08:25.000000000","message":"should be moved after Created At, because it overlaps (see http://imgur.com/QjtFytZ)\n\nit would be nice if it was formatted nicely too (maybe out of this patch\u0027s scope)","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1ea5c6e956336ed3ead222ef7a4029312af5a9ea","unresolved":false,"context_lines":[{"line_number":24,"context_line":"  \u003c/dl\u003e"},{"line_number":25,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":26,"context_line":"    \u003cdt translate\u003eVolume Image Metadata\u003c/dt\u003e"},{"line_number":27,"context_line":"    \u003cdd\u003e{$ item.volume_image_metadata | noValue $}\u003c/dd\u003e"},{"line_number":28,"context_line":"  \u003c/dl\u003e"},{"line_number":29,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":30,"context_line":"    \u003cdt translate\u003eCreated At\u003c/dt\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"3aaa91ec_edb33096","line":27,"in_reply_to":"3aaa91ec_f51f78b4","updated":"2016-06-28 03:49:13.000000000","message":"Done","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"dbfbf324e2ee0343173d982b416b2a39045e1608","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  \u003c/dl\u003e"},{"line_number":29,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":30,"context_line":"    \u003cdt translate\u003eCreated At\u003c/dt\u003e"},{"line_number":31,"context_line":"    \u003cdd\u003e{$ item.created_at | toIsoDate $}\u003c/dd\u003e"},{"line_number":32,"context_line":"  \u003c/dl\u003e"},{"line_number":33,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"3aaa91ec_758268c9","line":31,"updated":"2016-06-25 01:08:25.000000000","message":"date should should just be YYYY-MM-DD","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1ea5c6e956336ed3ead222ef7a4029312af5a9ea","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  \u003c/dl\u003e"},{"line_number":29,"context_line":"  \u003cdl class\u003d\"col-md-2\"\u003e"},{"line_number":30,"context_line":"    \u003cdt translate\u003eCreated At\u003c/dt\u003e"},{"line_number":31,"context_line":"    \u003cdd\u003e{$ item.created_at | toIsoDate $}\u003c/dd\u003e"},{"line_number":32,"context_line":"  \u003c/dl\u003e"},{"line_number":33,"context_line":"\u003c/div\u003e"}],"source_content_type":"text/html","patch_set":4,"id":"3aaa91ec_8db8ac76","line":31,"in_reply_to":"3aaa91ec_758268c9","updated":"2016-06-28 03:49:13.000000000","message":"I see.\nI will modify the same way as image table.","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"}],"openstack_dashboard/static/app/core/volumes/volumes.module.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f72376982905a98f322ce9e1635549a3c15ea014","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        label: gettext(\u0027ID\u0027)"},{"line_number":70,"context_line":"      })"},{"line_number":71,"context_line":"      .setProperty(\u0027imageRef\u0027, {"},{"line_number":72,"context_line":"        label: gettext(\u0027Image Ref\u0027)"},{"line_number":73,"context_line":"      })"},{"line_number":74,"context_line":"      .setProperty(\u0027name\u0027, {"},{"line_number":75,"context_line":"        label: gettext(\u0027Name\u0027)"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_d5fcf5b9","line":72,"updated":"2016-06-08 18:20:25.000000000","message":"Should this be Image Reference?","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"7188a36342b69f4f362b67b34ff1fc17948c75c7","unresolved":false,"context_lines":[{"line_number":69,"context_line":"        label: gettext(\u0027ID\u0027)"},{"line_number":70,"context_line":"      })"},{"line_number":71,"context_line":"      .setProperty(\u0027imageRef\u0027, {"},{"line_number":72,"context_line":"        label: gettext(\u0027Image Ref\u0027)"},{"line_number":73,"context_line":"      })"},{"line_number":74,"context_line":"      .setProperty(\u0027name\u0027, {"},{"line_number":75,"context_line":"        label: gettext(\u0027Name\u0027)"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_1ed48e45","line":72,"in_reply_to":"7aa08908_d5fcf5b9","updated":"2016-06-09 23:35:26.000000000","message":"I agree with you.\nI\u0027ll modify and re-commit later.\nthanks.","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"25d370ffe9f816c30258e591cfc4186e0ad26359","unresolved":false,"context_lines":[{"line_number":142,"context_line":"      });"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    function listFunction() {"},{"line_number":145,"context_line":"      console.log(cinder.getVolumes());"},{"line_number":146,"context_line":"      return cinder.getVolumes();"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":2,"id":"9abb7d3a_7529c989","line":145,"range":{"start_line":145,"start_character":6,"end_line":145,"end_character":39},"updated":"2016-06-01 15:16:28.000000000","message":"Remove this console log","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1e46a095d0ba120d47963026a0ddc3a44ecd658c","unresolved":false,"context_lines":[{"line_number":142,"context_line":"      });"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    function listFunction() {"},{"line_number":145,"context_line":"      console.log(cinder.getVolumes());"},{"line_number":146,"context_line":"      return cinder.getVolumes();"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_abaa7317","line":145,"range":{"start_line":145,"start_character":6,"end_line":145,"end_character":39},"in_reply_to":"7aa08908_cbba5fc0","updated":"2016-06-06 02:43:42.000000000","message":"Sorry.\nI forgot to remove it.","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"896c0ac67e7f289575a00e04639877f2e7e6b614","unresolved":false,"context_lines":[{"line_number":142,"context_line":"      });"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    function listFunction() {"},{"line_number":145,"context_line":"      console.log(cinder.getVolumes());"},{"line_number":146,"context_line":"      return cinder.getVolumes();"},{"line_number":147,"context_line":"    }"},{"line_number":148,"context_line":"  }"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_cbba5fc0","line":145,"range":{"start_line":145,"start_character":6,"end_line":145,"end_character":39},"in_reply_to":"9abb7d3a_7529c989","updated":"2016-06-05 22:54:21.000000000","message":"DEBUG code:-)","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"896c0ac67e7f289575a00e04639877f2e7e6b614","unresolved":false,"context_lines":[{"line_number":156,"context_line":"   * @name config"},{"line_number":157,"context_line":"   * @param {Object} $provide"},{"line_number":158,"context_line":"   * @param {Object} $windowProvider"},{"line_number":159,"context_line":"   * @param {Object} $routeProvider"},{"line_number":160,"context_line":"   * @description Routes used by this module."},{"line_number":161,"context_line":"   * @returns {undefined} Returns nothing"},{"line_number":162,"context_line":"   */"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_2bb043dd","line":159,"updated":"2016-06-05 22:54:21.000000000","message":"delete the line","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1e46a095d0ba120d47963026a0ddc3a44ecd658c","unresolved":false,"context_lines":[{"line_number":156,"context_line":"   * @name config"},{"line_number":157,"context_line":"   * @param {Object} $provide"},{"line_number":158,"context_line":"   * @param {Object} $windowProvider"},{"line_number":159,"context_line":"   * @param {Object} $routeProvider"},{"line_number":160,"context_line":"   * @description Routes used by this module."},{"line_number":161,"context_line":"   * @returns {undefined} Returns nothing"},{"line_number":162,"context_line":"   */"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_8ba7b74e","line":159,"in_reply_to":"7aa08908_2bb043dd","updated":"2016-06-06 02:43:42.000000000","message":"I got the point.\nthanks","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"0e995947bbffe9cd8e2a926ce8357453a7b284d7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      })"},{"line_number":98,"context_line":"      .setListFunction(listFunction)"},{"line_number":99,"context_line":"      .tableColumns"},{"line_number":100,"context_line":"      .append({"},{"line_number":101,"context_line":"        id: \u0027name\u0027,"},{"line_number":102,"context_line":"        priority: 1,"},{"line_number":103,"context_line":"        sortDefault: true,"},{"line_number":104,"context_line":"        template: \u0027\u003ca ng-href\u003d\"{$ \\\u0027project/ngdetails/OS::Cinder::Volume/\\\u0027 + item.id $}\"\u003e\u0027 +"},{"line_number":105,"context_line":"          \u0027{$ item.name $}\u003c/a\u003e\u0027"},{"line_number":106,"context_line":"      })"},{"line_number":107,"context_line":"      .append({"},{"line_number":108,"context_line":"        id: \u0027description\u0027,"},{"line_number":109,"context_line":"        priority: 1"}],"source_content_type":"text/javascript","patch_set":3,"id":"7aa08908_c02f91a5","line":106,"range":{"start_line":100,"start_character":7,"end_line":106,"end_character":8},"updated":"2016-06-16 17:23:39.000000000","message":"Somehow, this needs to supply the ID when the name is blank, which is possible.","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"2cecd7a0da66b76ba2941ec03515d89d1f15d687","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      })"},{"line_number":98,"context_line":"      .setListFunction(listFunction)"},{"line_number":99,"context_line":"      .tableColumns"},{"line_number":100,"context_line":"      .append({"},{"line_number":101,"context_line":"        id: \u0027name\u0027,"},{"line_number":102,"context_line":"        priority: 1,"},{"line_number":103,"context_line":"        sortDefault: true,"},{"line_number":104,"context_line":"        template: \u0027\u003ca ng-href\u003d\"{$ \\\u0027project/ngdetails/OS::Cinder::Volume/\\\u0027 + item.id $}\"\u003e\u0027 +"},{"line_number":105,"context_line":"          \u0027{$ item.name $}\u003c/a\u003e\u0027"},{"line_number":106,"context_line":"      })"},{"line_number":107,"context_line":"      .append({"},{"line_number":108,"context_line":"        id: \u0027description\u0027,"},{"line_number":109,"context_line":"        priority: 1"}],"source_content_type":"text/javascript","patch_set":3,"id":"5a9d85d2_1bab1e8b","line":106,"range":{"start_line":100,"start_character":7,"end_line":106,"end_character":8},"in_reply_to":"5a9d85d2_07e74ae5","updated":"2016-06-20 04:50:22.000000000","message":"hi matt, the volume name will always be there, thoughts?","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"9eaadc68e876ca9d0cc1799192fb341727619dda","unresolved":false,"context_lines":[{"line_number":97,"context_line":"      })"},{"line_number":98,"context_line":"      .setListFunction(listFunction)"},{"line_number":99,"context_line":"      .tableColumns"},{"line_number":100,"context_line":"      .append({"},{"line_number":101,"context_line":"        id: \u0027name\u0027,"},{"line_number":102,"context_line":"        priority: 1,"},{"line_number":103,"context_line":"        sortDefault: true,"},{"line_number":104,"context_line":"        template: \u0027\u003ca ng-href\u003d\"{$ \\\u0027project/ngdetails/OS::Cinder::Volume/\\\u0027 + item.id $}\"\u003e\u0027 +"},{"line_number":105,"context_line":"          \u0027{$ item.name $}\u003c/a\u003e\u0027"},{"line_number":106,"context_line":"      })"},{"line_number":107,"context_line":"      .append({"},{"line_number":108,"context_line":"        id: \u0027description\u0027,"},{"line_number":109,"context_line":"        priority: 1"}],"source_content_type":"text/javascript","patch_set":3,"id":"5a9d85d2_07e74ae5","line":106,"range":{"start_line":100,"start_character":7,"end_line":106,"end_character":8},"in_reply_to":"7aa08908_c02f91a5","updated":"2016-06-19 12:24:52.000000000","message":"I got the point.","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"0e995947bbffe9cd8e2a926ce8357453a7b284d7","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      })"},{"line_number":107,"context_line":"      .append({"},{"line_number":108,"context_line":"        id: \u0027description\u0027,"},{"line_number":109,"context_line":"        priority: 1"},{"line_number":110,"context_line":"      })"},{"line_number":111,"context_line":"      .append({"},{"line_number":112,"context_line":"        id: \u0027size\u0027,"}],"source_content_type":"text/javascript","patch_set":3,"id":"7aa08908_60297d9b","line":109,"updated":"2016-06-16 17:23:39.000000000","message":"Add the \u0027noValue\u0027 filter here so it displays a \u0027-\u0027 when blank:\n\nfilters: [\u0027noValue\u0027]","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"9eaadc68e876ca9d0cc1799192fb341727619dda","unresolved":false,"context_lines":[{"line_number":106,"context_line":"      })"},{"line_number":107,"context_line":"      .append({"},{"line_number":108,"context_line":"        id: \u0027description\u0027,"},{"line_number":109,"context_line":"        priority: 1"},{"line_number":110,"context_line":"      })"},{"line_number":111,"context_line":"      .append({"},{"line_number":112,"context_line":"        id: \u0027size\u0027,"}],"source_content_type":"text/javascript","patch_set":3,"id":"5a9d85d2_47d152fb","line":109,"in_reply_to":"7aa08908_60297d9b","updated":"2016-06-19 12:24:52.000000000","message":"I got the point.","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"0e995947bbffe9cd8e2a926ce8357453a7b284d7","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        id: \u0027bootable\u0027,"},{"line_number":135,"context_line":"        priority: 2"},{"line_number":136,"context_line":"        // Remove yesno filter until fixed this bug"},{"line_number":137,"context_line":"        // https://bugs.launchpad.net/cinder/+bug/1589865"},{"line_number":138,"context_line":"        // filters: [\u0027yesno\u0027]"},{"line_number":139,"context_line":"      })"},{"line_number":140,"context_line":"      .append({"}],"source_content_type":"text/javascript","patch_set":3,"id":"7aa08908_2a2f5389","line":137,"range":{"start_line":137,"start_character":11,"end_line":137,"end_character":57},"updated":"2016-06-16 17:23:39.000000000","message":"Please place a TODO: here.\n\n// TODO: Remove yesno...","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"cdf57e9799af05de00c8f8511f1202fd981b8a6d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        id: \u0027bootable\u0027,"},{"line_number":135,"context_line":"        priority: 2"},{"line_number":136,"context_line":"        // Remove yesno filter until fixed this bug"},{"line_number":137,"context_line":"        // https://bugs.launchpad.net/cinder/+bug/1589865"},{"line_number":138,"context_line":"        // filters: [\u0027yesno\u0027]"},{"line_number":139,"context_line":"      })"},{"line_number":140,"context_line":"      .append({"}],"source_content_type":"text/javascript","patch_set":3,"id":"7aa08908_caf20f06","line":137,"range":{"start_line":137,"start_character":11,"end_line":137,"end_character":57},"in_reply_to":"7aa08908_2a2f5389","updated":"2016-06-16 17:27:58.000000000","message":"Another alternative, that I suggest rather than changing Cinder since that may be a pain, is to handle the listFunction to interpret the results on the fly.","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"2cecd7a0da66b76ba2941ec03515d89d1f15d687","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        id: \u0027bootable\u0027,"},{"line_number":135,"context_line":"        priority: 2"},{"line_number":136,"context_line":"        // Remove yesno filter until fixed this bug"},{"line_number":137,"context_line":"        // https://bugs.launchpad.net/cinder/+bug/1589865"},{"line_number":138,"context_line":"        // filters: [\u0027yesno\u0027]"},{"line_number":139,"context_line":"      })"},{"line_number":140,"context_line":"      .append({"}],"source_content_type":"text/javascript","patch_set":3,"id":"5a9d85d2_dbd23634","line":137,"range":{"start_line":137,"start_character":11,"end_line":137,"end_character":57},"in_reply_to":"7aa08908_6a8afb1b","updated":"2016-06-20 04:50:22.000000000","message":"Add TODO, and work the item later, custom function is fine for me","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"dc52b9bc23d20608dda8a6611f4a58f71fcd92f3","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        id: \u0027bootable\u0027,"},{"line_number":135,"context_line":"        priority: 2"},{"line_number":136,"context_line":"        // Remove yesno filter until fixed this bug"},{"line_number":137,"context_line":"        // https://bugs.launchpad.net/cinder/+bug/1589865"},{"line_number":138,"context_line":"        // filters: [\u0027yesno\u0027]"},{"line_number":139,"context_line":"      })"},{"line_number":140,"context_line":"      .append({"}],"source_content_type":"text/javascript","patch_set":3,"id":"7aa08908_6a8afb1b","line":137,"range":{"start_line":137,"start_character":11,"end_line":137,"end_character":57},"in_reply_to":"7aa08908_caf20f06","updated":"2016-06-16 17:30:29.000000000","message":"Finally, you can also just provide a function for a filter, e.g.\n\nfilters: [specialFunction]\n\nfunction specialFunction(x) {\n  if ...x is a string, etc...,\n  return the.correct.value;\n}\n\nI\u0027d be happy to go with just a local function like this.","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"cdf57e9799af05de00c8f8511f1202fd981b8a6d","unresolved":false,"context_lines":[{"line_number":144,"context_line":"      });"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    function listFunction() {"},{"line_number":147,"context_line":"      return cinder.getVolumes();"},{"line_number":148,"context_line":"    }"},{"line_number":149,"context_line":"  }"},{"line_number":150,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"7aa08908_0a72577c","line":147,"updated":"2016-06-16 17:27:58.000000000","message":"As part of what I mean above, you can do something like (this is pseudocode):\n\ncinder.getVolumes().then(onLoad);\n\nfunction onLoad(response) {\n  response.data.map/forEach(...change or add a value to be boolean rather than string...)\n  return {DATA: my.new.list};\n}","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"9eaadc68e876ca9d0cc1799192fb341727619dda","unresolved":false,"context_lines":[{"line_number":144,"context_line":"      });"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    function listFunction() {"},{"line_number":147,"context_line":"      return cinder.getVolumes();"},{"line_number":148,"context_line":"    }"},{"line_number":149,"context_line":"  }"},{"line_number":150,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"5a9d85d2_e702fe6e","line":147,"in_reply_to":"7aa08908_0a72577c","updated":"2016-06-19 12:24:52.000000000","message":"Great Idea.\nI am trying to change Cinder, however it takes time for merge because it\u0027s a breaking API change.\nSo, as you say, I use a local function to handle parameter.","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"2cecd7a0da66b76ba2941ec03515d89d1f15d687","unresolved":false,"context_lines":[{"line_number":144,"context_line":"      });"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    function listFunction() {"},{"line_number":147,"context_line":"      return cinder.getVolumes();"},{"line_number":148,"context_line":"    }"},{"line_number":149,"context_line":"  }"},{"line_number":150,"context_line":""}],"source_content_type":"text/javascript","patch_set":3,"id":"5a9d85d2_3b79ba30","line":147,"in_reply_to":"7aa08908_0a72577c","updated":"2016-06-20 04:50:22.000000000","message":"hi matt, add track id, here? but why not use volume.id as the trackBy, it is unique enough.","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"2cecd7a0da66b76ba2941ec03515d89d1f15d687","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    var template \u003d \u0027\u003chz-resource-panel resource-type-name\u003d\"OS::Cinder::Volume\"\u003e\u0027 +"},{"line_number":170,"context_line":"      \u0027\u003chz-resource-table resource-type-name\u003d\"OS::Cinder::Volume\"\u003e\u0027 +"},{"line_number":171,"context_line":"      \u0027\u003c/hz-resource-table\u003e\u003c/hz-resource-panel\u003e\u0027;"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    $routeProvider.when(\u0027/project/ngvolumes/\u0027, {"},{"line_number":174,"context_line":"      template: template"}],"source_content_type":"text/javascript","patch_set":3,"id":"5a9d85d2_9bf1ced0","line":171,"updated":"2016-06-20 04:50:22.000000000","message":"use panel.html","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"51714c8069724155a7dd5fea4931512718d44986","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    var template \u003d \u0027\u003chz-resource-panel resource-type-name\u003d\"OS::Cinder::Volume\"\u003e\u0027 +"},{"line_number":170,"context_line":"      \u0027\u003chz-resource-table resource-type-name\u003d\"OS::Cinder::Volume\"\u003e\u0027 +"},{"line_number":171,"context_line":"      \u0027\u003c/hz-resource-table\u003e\u003c/hz-resource-panel\u003e\u0027;"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    $routeProvider.when(\u0027/project/ngvolumes/\u0027, {"},{"line_number":174,"context_line":"      template: template"}],"source_content_type":"text/javascript","patch_set":3,"id":"3aaa91ec_3d1797ee","line":171,"in_reply_to":"5a9d85d2_9bf1ced0","updated":"2016-06-23 08:02:05.000000000","message":"Done","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"bddb9cd5f87037745c91a3b218ed8eead64d90b6","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    var template \u003d \u0027\u003chz-resource-panel resource-type-name\u003d\"OS::Cinder::Volume\"\u003e\u0027 +"},{"line_number":170,"context_line":"      \u0027\u003chz-resource-table resource-type-name\u003d\"OS::Cinder::Volume\"\u003e\u0027 +"},{"line_number":171,"context_line":"      \u0027\u003c/hz-resource-table\u003e\u003c/hz-resource-panel\u003e\u0027;"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    $routeProvider.when(\u0027/project/ngvolumes/\u0027, {"},{"line_number":174,"context_line":"      template: template"},{"line_number":175,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":3,"id":"5a9d85d2_cbad2d33","line":172,"updated":"2016-06-20 15:13:13.000000000","message":"Use, please extract this out from the JS.","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"51714c8069724155a7dd5fea4931512718d44986","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    var template \u003d \u0027\u003chz-resource-panel resource-type-name\u003d\"OS::Cinder::Volume\"\u003e\u0027 +"},{"line_number":170,"context_line":"      \u0027\u003chz-resource-table resource-type-name\u003d\"OS::Cinder::Volume\"\u003e\u0027 +"},{"line_number":171,"context_line":"      \u0027\u003c/hz-resource-table\u003e\u003c/hz-resource-panel\u003e\u0027;"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    $routeProvider.when(\u0027/project/ngvolumes/\u0027, {"},{"line_number":174,"context_line":"      template: template"},{"line_number":175,"context_line":"    });"}],"source_content_type":"text/javascript","patch_set":3,"id":"3aaa91ec_9dd4cb20","line":172,"in_reply_to":"5a9d85d2_cbad2d33","updated":"2016-06-23 08:02:05.000000000","message":"Done","commit_id":"3caa423319ff848ddb688738ae59f061ded21645"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"f339269a9c40667f287b716a70cd06a9ffb6b3c2","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  function run(registry, cinder, basePath, volumeResourceType) {"},{"line_number":44,"context_line":"    registry.getResourceType(volumeResourceType)"},{"line_number":45,"context_line":"      .setNames(gettext(\u0027Volume\u0027), gettext(\u0027Volumes\u0027))"},{"line_number":46,"context_line":"      .setSummaryTemplateUrl(basePath + \u0027details/drawer.html\u0027)"},{"line_number":47,"context_line":"      .setProperty(\u0027attachments\u0027, {"},{"line_number":48,"context_line":"        label: gettext(\u0027Attached To\u0027)"}],"source_content_type":"text/javascript","patch_set":4,"id":"3aaa91ec_63392bd7","line":45,"updated":"2016-06-24 14:30:36.000000000","message":"shall we delete following code: https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/resources/resources.module.js#L61-L62","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1ea5c6e956336ed3ead222ef7a4029312af5a9ea","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"  function run(registry, cinder, basePath, volumeResourceType) {"},{"line_number":44,"context_line":"    registry.getResourceType(volumeResourceType)"},{"line_number":45,"context_line":"      .setNames(gettext(\u0027Volume\u0027), gettext(\u0027Volumes\u0027))"},{"line_number":46,"context_line":"      .setSummaryTemplateUrl(basePath + \u0027details/drawer.html\u0027)"},{"line_number":47,"context_line":"      .setProperty(\u0027attachments\u0027, {"},{"line_number":48,"context_line":"        label: gettext(\u0027Attached To\u0027)"}],"source_content_type":"text/javascript","patch_set":4,"id":"3aaa91ec_ab3b7e37","line":45,"in_reply_to":"3aaa91ec_63392bd7","updated":"2016-06-28 03:49:13.000000000","message":"I got the point.","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"dbfbf324e2ee0343173d982b416b2a39045e1608","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        priority: 2"},{"line_number":124,"context_line":"      })"},{"line_number":125,"context_line":"      .append({"},{"line_number":126,"context_line":"        id: \u0027attachments\u0027,"},{"line_number":127,"context_line":"        priority: 2,"},{"line_number":128,"context_line":"        filters: [\u0027noValue\u0027]"},{"line_number":129,"context_line":"      })"}],"source_content_type":"text/javascript","patch_set":4,"id":"3aaa91ec_15668450","line":126,"updated":"2016-06-25 01:08:25.000000000","message":"not showing up...","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1ea5c6e956336ed3ead222ef7a4029312af5a9ea","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        priority: 2"},{"line_number":124,"context_line":"      })"},{"line_number":125,"context_line":"      .append({"},{"line_number":126,"context_line":"        id: \u0027attachments\u0027,"},{"line_number":127,"context_line":"        priority: 2,"},{"line_number":128,"context_line":"        filters: [\u0027noValue\u0027]"},{"line_number":129,"context_line":"      })"}],"source_content_type":"text/javascript","patch_set":4,"id":"3aaa91ec_0b20d2f6","line":126,"in_reply_to":"3aaa91ec_15668450","updated":"2016-06-28 03:49:13.000000000","message":"Add a new function to handle it.\nthanks.","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"dbfbf324e2ee0343173d982b416b2a39045e1608","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        id: \u0027encrypted\u0027,"},{"line_number":141,"context_line":"        priority: 2,"},{"line_number":142,"context_line":"        filters: [\u0027yesno\u0027]"},{"line_number":143,"context_line":"      });"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    function listFunction() {"},{"line_number":146,"context_line":"      return cinder.getVolumes().then(modifyResponse);"}],"source_content_type":"text/javascript","patch_set":4,"id":"3aaa91ec_f54db8c4","line":143,"updated":"2016-06-25 01:08:25.000000000","message":"should hide the \u0027selectAll\u0027 checkboxes because there are no actions associated with it now","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1ea5c6e956336ed3ead222ef7a4029312af5a9ea","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        id: \u0027encrypted\u0027,"},{"line_number":141,"context_line":"        priority: 2,"},{"line_number":142,"context_line":"        filters: [\u0027yesno\u0027]"},{"line_number":143,"context_line":"      });"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    function listFunction() {"},{"line_number":146,"context_line":"      return cinder.getVolumes().then(modifyResponse);"}],"source_content_type":"text/javascript","patch_set":4,"id":"3aaa91ec_ab509e5f","line":143,"in_reply_to":"3aaa91ec_f54db8c4","updated":"2016-06-28 03:49:13.000000000","message":"I got the point.","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"e0e432b3945e3266e988ac3922792aba2cf53a74","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        id: \u0027encrypted\u0027,"},{"line_number":141,"context_line":"        priority: 2,"},{"line_number":142,"context_line":"        filters: [\u0027yesno\u0027]"},{"line_number":143,"context_line":"      });"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    function listFunction() {"},{"line_number":146,"context_line":"      return cinder.getVolumes().then(modifyResponse);"}],"source_content_type":"text/javascript","patch_set":4,"id":"1aa78d24_00e734e5","line":143,"in_reply_to":"3aaa91ec_f54db8c4","updated":"2016-07-02 06:11:34.000000000","message":"It seems that a selectAll option is hardcoded.\nhttps://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/table/hz-resource-table.controller.js#L43","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"dbfbf324e2ee0343173d982b416b2a39045e1608","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            case \"false\": volume.bootable \u003d false;"},{"line_number":157,"context_line":"            default: volume.bootable \u003d Boolean(volume.bootable);"},{"line_number":158,"context_line":"          }"},{"line_number":159,"context_line":"          return volume"},{"line_number":160,"context_line":"        }"},{"line_number":161,"context_line":"      }"},{"line_number":162,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":4,"id":"3aaa91ec_d5487cb5","line":159,"updated":"2016-06-25 01:08:25.000000000","message":";","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1ea5c6e956336ed3ead222ef7a4029312af5a9ea","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            case \"false\": volume.bootable \u003d false;"},{"line_number":157,"context_line":"            default: volume.bootable \u003d Boolean(volume.bootable);"},{"line_number":158,"context_line":"          }"},{"line_number":159,"context_line":"          return volume"},{"line_number":160,"context_line":"        }"},{"line_number":161,"context_line":"      }"},{"line_number":162,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":4,"id":"3aaa91ec_2b64ae47","line":159,"in_reply_to":"3aaa91ec_d5487cb5","updated":"2016-06-28 03:49:13.000000000","message":"Done","commit_id":"230f601b780c59d8ea9b705d68f0eed350cd5265"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"4dfc7efd0387e5fa9c5888bcd9d555261e13ca75","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        priority: 1,"},{"line_number":104,"context_line":"        sortDefault: true,"},{"line_number":105,"context_line":"        template: \u0027\u003ca ng-href\u003d\"{$ \\\u0027project/ngdetails/OS::Cinder::Volume/\\\u0027 + item.id $}\"\u003e\u0027 +"},{"line_number":106,"context_line":"          \u0027{$ (item.name ? item.name: item.id) $}\u003c/a\u003e\u0027"},{"line_number":107,"context_line":"      })"},{"line_number":108,"context_line":"      .append({"},{"line_number":109,"context_line":"        id: \u0027description\u0027,"}],"source_content_type":"text/javascript","patch_set":8,"id":"1aa78d24_48db631b","line":106,"updated":"2016-07-07 02:08:42.000000000","message":"Please update to use new urlFunction method. See example here:\nhttps://review.openstack.org/#/c/334065/9/openstack_dashboard/static/app/core/images/images.module.js","commit_id":"b634e2ba56a039eadb178f92765cb09a7be0ac3d"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"ee4dfa8bbffc6ce6d2d32ab914a1fab7ae8c8d7a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        priority: 1,"},{"line_number":104,"context_line":"        sortDefault: true,"},{"line_number":105,"context_line":"        template: \u0027\u003ca ng-href\u003d\"{$ \\\u0027project/ngdetails/OS::Cinder::Volume/\\\u0027 + item.id $}\"\u003e\u0027 +"},{"line_number":106,"context_line":"          \u0027{$ (item.name ? item.name: item.id) $}\u003c/a\u003e\u0027"},{"line_number":107,"context_line":"      })"},{"line_number":108,"context_line":"      .append({"},{"line_number":109,"context_line":"        id: \u0027description\u0027,"}],"source_content_type":"text/javascript","patch_set":8,"id":"1aa78d24_a692f349","line":106,"in_reply_to":"1aa78d24_48db631b","updated":"2016-07-07 06:50:32.000000000","message":"Does urlFunction fit this item?\n\nValue of name field must be set to ID if Name is None.\nSo, I set the value to \"{$ (item.name ? item.name: item.id) $}\" by using template.","commit_id":"b634e2ba56a039eadb178f92765cb09a7be0ac3d"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"1dae0172a73444b0d6186ee6e26639b57abae0fa","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        priority: 1,"},{"line_number":104,"context_line":"        sortDefault: true,"},{"line_number":105,"context_line":"        template: \u0027\u003ca ng-href\u003d\"{$ \\\u0027project/ngdetails/OS::Cinder::Volume/\\\u0027 + item.id $}\"\u003e\u0027 +"},{"line_number":106,"context_line":"          \u0027{$ (item.name ? item.name: item.id) $}\u003c/a\u003e\u0027"},{"line_number":107,"context_line":"      })"},{"line_number":108,"context_line":"      .append({"},{"line_number":109,"context_line":"        id: \u0027description\u0027,"}],"source_content_type":"text/javascript","patch_set":8,"id":"1aa78d24_a823ddbb","line":106,"in_reply_to":"1aa78d24_a692f349","updated":"2016-07-07 08:00:58.000000000","message":"if not , maybe we could fix that.","commit_id":"b634e2ba56a039eadb178f92765cb09a7be0ac3d"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"281371c6b077ed90d20e6c787efd3b56f1020662","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        priority: 1,"},{"line_number":104,"context_line":"        sortDefault: true,"},{"line_number":105,"context_line":"        template: \u0027\u003ca ng-href\u003d\"{$ \\\u0027project/ngdetails/OS::Cinder::Volume/\\\u0027 + item.id $}\"\u003e\u0027 +"},{"line_number":106,"context_line":"          \u0027{$ (item.name ? item.name: item.id) $}\u003c/a\u003e\u0027"},{"line_number":107,"context_line":"      })"},{"line_number":108,"context_line":"      .append({"},{"line_number":109,"context_line":"        id: \u0027description\u0027,"}],"source_content_type":"text/javascript","patch_set":8,"id":"1aa78d24_ab52b764","line":106,"in_reply_to":"1aa78d24_a823ddbb","updated":"2016-07-07 08:21:19.000000000","message":"I got the point.\nthanks.","commit_id":"b634e2ba56a039eadb178f92765cb09a7be0ac3d"}],"openstack_dashboard/static/app/resources/resources.module.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"25d370ffe9f816c30258e591cfc4186e0ad26359","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      .setNames(gettext(\u0027DNS Domain\u0027), gettext(\u0027DNS Domains\u0027));"},{"line_number":55,"context_line":"    registry.getResourceType(\u0027OS::Designate::RecordSet\u0027)"},{"line_number":56,"context_line":"      .setNames(gettext(\u0027DNS Record\u0027), gettext(\u0027DNS Records\u0027));"},{"line_number":57,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Volume\u0027)"},{"line_number":58,"context_line":"      .setNames(gettext(\u0027Volume\u0027), gettext(\u0027Volumes\u0027));"},{"line_number":59,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Backup\u0027)"},{"line_number":60,"context_line":"      .setNames(gettext(\u0027Volume Backup\u0027), gettext(\u0027Volume Backups\u0027));"},{"line_number":61,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Snapshot\u0027)"}],"source_content_type":"text/javascript","patch_set":2,"id":"9abb7d3a_3562a1d8","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":55},"updated":"2016-06-01 15:16:28.000000000","message":"You can actually remove this as it duplicates the other registration in volumes.module.js. We were putting all the unregistered/unimplemented resource types here.","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"39ab732ebc2ae64c8bcb5b7eb3c70c3e96e0e08a","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      .setNames(gettext(\u0027DNS Domain\u0027), gettext(\u0027DNS Domains\u0027));"},{"line_number":55,"context_line":"    registry.getResourceType(\u0027OS::Designate::RecordSet\u0027)"},{"line_number":56,"context_line":"      .setNames(gettext(\u0027DNS Record\u0027), gettext(\u0027DNS Records\u0027));"},{"line_number":57,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Volume\u0027)"},{"line_number":58,"context_line":"      .setNames(gettext(\u0027Volume\u0027), gettext(\u0027Volumes\u0027));"},{"line_number":59,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Backup\u0027)"},{"line_number":60,"context_line":"      .setNames(gettext(\u0027Volume Backup\u0027), gettext(\u0027Volume Backups\u0027));"},{"line_number":61,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Snapshot\u0027)"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_30c2a7e9","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":55},"in_reply_to":"7aa08908_435db3e8","updated":"2016-06-08 18:44:10.000000000","message":"yes, thanks!","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":7121,"name":"Hiroyuki Eguchi","email":"h-eguchi@az.jp.nec.com","username":"HiroyukiEguchi"},"change_message_id":"1e46a095d0ba120d47963026a0ddc3a44ecd658c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      .setNames(gettext(\u0027DNS Domain\u0027), gettext(\u0027DNS Domains\u0027));"},{"line_number":55,"context_line":"    registry.getResourceType(\u0027OS::Designate::RecordSet\u0027)"},{"line_number":56,"context_line":"      .setNames(gettext(\u0027DNS Record\u0027), gettext(\u0027DNS Records\u0027));"},{"line_number":57,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Volume\u0027)"},{"line_number":58,"context_line":"      .setNames(gettext(\u0027Volume\u0027), gettext(\u0027Volumes\u0027));"},{"line_number":59,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Backup\u0027)"},{"line_number":60,"context_line":"      .setNames(gettext(\u0027Volume Backup\u0027), gettext(\u0027Volume Backups\u0027));"},{"line_number":61,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Snapshot\u0027)"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_435db3e8","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":55},"in_reply_to":"7aa08908_eb03db74","updated":"2016-06-06 02:43:42.000000000","message":"I understand that resource registered here is the unregistered/unimplemented one.\nSo, I will delete this modification because I add the volume resource newly in volumes.module.js.","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"896c0ac67e7f289575a00e04639877f2e7e6b614","unresolved":false,"context_lines":[{"line_number":54,"context_line":"      .setNames(gettext(\u0027DNS Domain\u0027), gettext(\u0027DNS Domains\u0027));"},{"line_number":55,"context_line":"    registry.getResourceType(\u0027OS::Designate::RecordSet\u0027)"},{"line_number":56,"context_line":"      .setNames(gettext(\u0027DNS Record\u0027), gettext(\u0027DNS Records\u0027));"},{"line_number":57,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Volume\u0027)"},{"line_number":58,"context_line":"      .setNames(gettext(\u0027Volume\u0027), gettext(\u0027Volumes\u0027));"},{"line_number":59,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Backup\u0027)"},{"line_number":60,"context_line":"      .setNames(gettext(\u0027Volume Backup\u0027), gettext(\u0027Volume Backups\u0027));"},{"line_number":61,"context_line":"    registry.getResourceType(\u0027OS::Cinder::Snapshot\u0027)"}],"source_content_type":"text/javascript","patch_set":2,"id":"7aa08908_eb03db74","line":58,"range":{"start_line":57,"start_character":0,"end_line":58,"end_character":55},"in_reply_to":"9abb7d3a_3562a1d8","updated":"2016-06-05 22:54:21.000000000","message":"We were putting all the unregistered/unimplemented resource types here, so i don\u0027t think it\u0027s a good idea to remove the cinder volume registration here:-)","commit_id":"4e6c9276a3e00f554be57cd2b2d300595193d18b"}]}