)]}'
{"doc/source/topics/settings.rst":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"b72811a864d8ad84b6e233d55a71860c0dad6d4a","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"reasons."},{"line_number":1521,"context_line":""},{"line_number":1522,"context_line":""},{"line_number":1523,"context_line":"``ADMIN_FILTER_DATA_FIRST``"},{"line_number":1524,"context_line":"---------------------------"},{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":".. versionadded:: 9.0.0(Mitaka)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abb7d3a_ac530c38","line":1523,"updated":"2016-06-01 07:28:46.000000000","message":"We need to add this setting in local_settings.py","commit_id":"ebeba385ef7cfe2bb79e478c4108f7ba90432dc1"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"de878e8b10c0fc1de31aea4687a1dad9660424f1","unresolved":false,"context_lines":[{"line_number":1520,"context_line":"reasons."},{"line_number":1521,"context_line":""},{"line_number":1522,"context_line":""},{"line_number":1523,"context_line":"``ADMIN_FILTER_DATA_FIRST``"},{"line_number":1524,"context_line":"---------------------------"},{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":".. versionadded:: 9.0.0(Mitaka)"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abb7d3a_52501b32","line":1523,"in_reply_to":"9abb7d3a_ac530c38","updated":"2016-06-01 15:14:26.000000000","message":"Done","commit_id":"ebeba385ef7cfe2bb79e478c4108f7ba90432dc1"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"b72811a864d8ad84b6e233d55a71860c0dad6d4a","unresolved":false,"context_lines":[{"line_number":1523,"context_line":"``ADMIN_FILTER_DATA_FIRST``"},{"line_number":1524,"context_line":"---------------------------"},{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":".. versionadded:: 9.0.0(Mitaka)"},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"Default ``False``"},{"line_number":1529,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abb7d3a_ec2cf49a","line":1526,"updated":"2016-06-01 07:28:46.000000000","message":"Not Mitaka","commit_id":"ebeba385ef7cfe2bb79e478c4108f7ba90432dc1"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"de878e8b10c0fc1de31aea4687a1dad9660424f1","unresolved":false,"context_lines":[{"line_number":1523,"context_line":"``ADMIN_FILTER_DATA_FIRST``"},{"line_number":1524,"context_line":"---------------------------"},{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":".. versionadded:: 9.0.0(Mitaka)"},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"Default ``False``"},{"line_number":1529,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abb7d3a_b243476b","line":1526,"in_reply_to":"9abb7d3a_ec2cf49a","updated":"2016-06-01 15:14:26.000000000","message":"Done","commit_id":"ebeba385ef7cfe2bb79e478c4108f7ba90432dc1"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"b72811a864d8ad84b6e233d55a71860c0dad6d4a","unresolved":false,"context_lines":[{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":".. versionadded:: 9.0.0(Mitaka)"},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"Default ``False``"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"If True, when admin views load, an empty table will be rendered and the"},{"line_number":1531,"context_line":"user will be asked to provide a search criteria first (in case no search"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abb7d3a_4c5540f8","line":1528,"updated":"2016-06-01 07:28:46.000000000","message":"missing \":\"","commit_id":"ebeba385ef7cfe2bb79e478c4108f7ba90432dc1"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"de878e8b10c0fc1de31aea4687a1dad9660424f1","unresolved":false,"context_lines":[{"line_number":1525,"context_line":""},{"line_number":1526,"context_line":".. versionadded:: 9.0.0(Mitaka)"},{"line_number":1527,"context_line":""},{"line_number":1528,"context_line":"Default ``False``"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"If True, when admin views load, an empty table will be rendered and the"},{"line_number":1531,"context_line":"user will be asked to provide a search criteria first (in case no search"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9abb7d3a_92460379","line":1528,"in_reply_to":"9abb7d3a_4c5540f8","updated":"2016-06-01 15:14:26.000000000","message":"Done","commit_id":"ebeba385ef7cfe2bb79e478c4108f7ba90432dc1"}],"horizon/tables/base.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"76945c866200dd0feec7a3ed6a394a1b68d1b861","unresolved":false,"context_lines":[{"line_number":1065,"context_line":"        self.filter_first_message \u003d \\"},{"line_number":1066,"context_line":"            getattr(options,"},{"line_number":1067,"context_line":"                    \u0027filter_first_message\u0027,"},{"line_number":1068,"context_line":"                    \u0027Please specify a search criteria first.\u0027)"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"class DataTableMetaclass(type):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7aa08908_402bd094","line":1068,"updated":"2016-06-20 20:27:14.000000000","message":"This needs to be translated, use:\n_(\u0027Please .... first.\u0027)","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f9bdb1dfe2a7ae9352a78a29336fc44db850f07d","unresolved":false,"context_lines":[{"line_number":1065,"context_line":"        self.filter_first_message \u003d \\"},{"line_number":1066,"context_line":"            getattr(options,"},{"line_number":1067,"context_line":"                    \u0027filter_first_message\u0027,"},{"line_number":1068,"context_line":"                    \u0027Please specify a search criteria first.\u0027)"},{"line_number":1069,"context_line":""},{"line_number":1070,"context_line":""},{"line_number":1071,"context_line":"class DataTableMetaclass(type):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_47c78d45","line":1068,"in_reply_to":"7aa08908_402bd094","updated":"2016-06-21 19:36:41.000000000","message":"Done","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"}],"horizon/tables/views.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"c4943f48c90845d0cb6ca59659ee5b2a7de1356f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self._tables \u003d {}"},{"line_number":34,"context_line":"        self._data_methods \u003d defaultdict(list)"},{"line_number":35,"context_line":"        self.get_data_methods(self.table_classes, self._data_methods)"},{"line_number":36,"context_line":"        self.admin_filter_first \u003d getattr(settings,"},{"line_number":37,"context_line":"                                          \u0027ADMIN_FILTER_DATA_FIRST\u0027,"},{"line_number":38,"context_line":"                                          False)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_59047b7d","line":36,"updated":"2016-06-22 06:22:55.000000000","message":"I\u0027m not sure but if this config is for horizon framework, should it be defined as HORIZON_CONFIG ?","commit_id":"cbadae3712dd0d290d2b627472ec73a98b54260d"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"e80a7cfebe7127d9c2cf32a6a008855db0df4fcd","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        self._tables \u003d {}"},{"line_number":34,"context_line":"        self._data_methods \u003d defaultdict(list)"},{"line_number":35,"context_line":"        self.get_data_methods(self.table_classes, self._data_methods)"},{"line_number":36,"context_line":"        self.admin_filter_first \u003d getattr(settings,"},{"line_number":37,"context_line":"                                          \u0027ADMIN_FILTER_DATA_FIRST\u0027,"},{"line_number":38,"context_line":"                                          False)"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_6d97d590","line":36,"in_reply_to":"3aaa91ec_59047b7d","updated":"2016-06-22 15:19:40.000000000","message":"good point but I\u0027m really not sure what\u0027s the criteria to add a new config value to HORIZON_CONFIG. I\u0027ve seen other settings configurations being used in the horizon framework.","commit_id":"cbadae3712dd0d290d2b627472ec73a98b54260d"}],"openstack_dashboard/dashboards/admin/images/tests.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"c4943f48c90845d0cb6ca59659ee5b2a7de1356f","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.update_settings(ADMIN_FILTER_DATA_FIRST\u003dTrue)"},{"line_number":72,"context_line":"    def test_images_list_with_admin_filter_first(self):"},{"line_number":73,"context_line":"        self.mox.ReplayAll()"},{"line_number":74,"context_line":"        res \u003d self.client.get(reverse(\u0027horizon:admin:images:index\u0027))"},{"line_number":75,"context_line":"        self.assertTemplateUsed(res, \u0027admin/images/index.html\u0027)"},{"line_number":76,"context_line":"        images \u003d res.context[\u0027table\u0027].data"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_b948ff2e","line":73,"updated":"2016-06-22 06:22:55.000000000","message":"This line also seems unnecessary","commit_id":"cbadae3712dd0d290d2b627472ec73a98b54260d"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"e80a7cfebe7127d9c2cf32a6a008855db0df4fcd","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.update_settings(ADMIN_FILTER_DATA_FIRST\u003dTrue)"},{"line_number":72,"context_line":"    def test_images_list_with_admin_filter_first(self):"},{"line_number":73,"context_line":"        self.mox.ReplayAll()"},{"line_number":74,"context_line":"        res \u003d self.client.get(reverse(\u0027horizon:admin:images:index\u0027))"},{"line_number":75,"context_line":"        self.assertTemplateUsed(res, \u0027admin/images/index.html\u0027)"},{"line_number":76,"context_line":"        images \u003d res.context[\u0027table\u0027].data"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_4d0f792e","line":73,"in_reply_to":"3aaa91ec_b948ff2e","updated":"2016-06-22 15:19:40.000000000","message":"Done","commit_id":"cbadae3712dd0d290d2b627472ec73a98b54260d"}],"openstack_dashboard/dashboards/admin/images/views.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"76945c866200dd0feec7a3ed6a394a1b68d1b861","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_data(self):"},{"line_number":59,"context_line":"        images \u003d []"},{"line_number":60,"context_line":"        default_filters_length \u003d len(self.DEFAULT_FILTERS)"},{"line_number":61,"context_line":"        if not policy.check(((\"image\", \"get_images\"),), self.request):"},{"line_number":62,"context_line":"            msg \u003d _(\"Insufficient privilege level to retrieve image list.\")"},{"line_number":63,"context_line":"            messages.info(self.request, msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_6ebb59c5","line":60,"updated":"2016-06-20 20:27:14.000000000","message":"not sure why the variable, just make the call below","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f9bdb1dfe2a7ae9352a78a29336fc44db850f07d","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def get_data(self):"},{"line_number":59,"context_line":"        images \u003d []"},{"line_number":60,"context_line":"        default_filters_length \u003d len(self.DEFAULT_FILTERS)"},{"line_number":61,"context_line":"        if not policy.check(((\"image\", \"get_images\"),), self.request):"},{"line_number":62,"context_line":"            msg \u003d _(\"Insufficient privilege level to retrieve image list.\")"},{"line_number":63,"context_line":"            messages.info(self.request, msg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_a7c47140","line":60,"in_reply_to":"5a9d85d2_6ebb59c5","updated":"2016-06-21 19:36:41.000000000","message":"Done","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"76945c866200dd0feec7a3ed6a394a1b68d1b861","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            return images"},{"line_number":65,"context_line":"        filters \u003d self.get_filters()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if self.admin_filter_first and len(filters) \u003d\u003d default_filters_length:"},{"line_number":68,"context_line":"            self._prev \u003d False"},{"line_number":69,"context_line":"            self._more \u003d False"},{"line_number":70,"context_line":"            self._needs_filter_first \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_6e099995","line":67,"updated":"2016-06-20 20:27:14.000000000","message":"\u003d\u003d len(self.DEFAULT_FILTERS)","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f9bdb1dfe2a7ae9352a78a29336fc44db850f07d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            return images"},{"line_number":65,"context_line":"        filters \u003d self.get_filters()"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if self.admin_filter_first and len(filters) \u003d\u003d default_filters_length:"},{"line_number":68,"context_line":"            self._prev \u003d False"},{"line_number":69,"context_line":"            self._more \u003d False"},{"line_number":70,"context_line":"            self._needs_filter_first \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_e7dcb91a","line":67,"in_reply_to":"5a9d85d2_6e099995","updated":"2016-06-21 19:36:41.000000000","message":"Done","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"76945c866200dd0feec7a3ed6a394a1b68d1b861","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self._needs_filter_first \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        prev_marker \u003d self.request.GET.get("},{"line_number":76,"context_line":"            project_tables.AdminImagesTable._meta.prev_pagination_param, None)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if prev_marker is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_54c9d077","line":75,"updated":"2016-06-20 20:27:14.000000000","message":"should add a test for this new functionality like you did for instances.","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f9bdb1dfe2a7ae9352a78a29336fc44db850f07d","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        self._needs_filter_first \u003d False"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        prev_marker \u003d self.request.GET.get("},{"line_number":76,"context_line":"            project_tables.AdminImagesTable._meta.prev_pagination_param, None)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        if prev_marker is not None:"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_c7e1bdd2","line":75,"in_reply_to":"5a9d85d2_54c9d077","updated":"2016-06-21 19:36:41.000000000","message":"Done","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"}],"openstack_dashboard/dashboards/admin/instances/tests.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"76945c866200dd0feec7a3ed6a394a1b68d1b861","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5a9d85d2_34efe4e9","line":389,"updated":"2016-06-20 20:27:14.000000000","message":"How about testing with a filter passed in and ADMIN_FILTER_DATA_FIRST set?","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f9bdb1dfe2a7ae9352a78a29336fc44db850f07d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3aaa91ec_476aed1b","line":389,"in_reply_to":"5a9d85d2_34efe4e9","updated":"2016-06-21 19:36:41.000000000","message":"Pending, I wasn\u0027t able to find a working example related to this. All the post calls examples I found returns a ResponseRedirect (for instance a redirect to the index view... as a GET). Still don\u0027t know how to emulate the GET request sending the table filter","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"6ed59599f43eceacb9bf457e142a2e1eeb49ea2f","unresolved":false,"context_lines":[{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    @test.update_settings(ADMIN_FILTER_DATA_FIRST\u003dTrue)"},{"line_number":405,"context_line":"    def test_index_with_admin_filter_first(self):"},{"line_number":406,"context_line":"        self.mox.ReplayAll()"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        res \u003d self.client.get(INDEX_URL)"},{"line_number":409,"context_line":"        self.assertTemplateUsed(res, \u0027admin/instances/index.html\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_8d734f4d","line":406,"updated":"2016-06-21 22:42:06.000000000","message":"since we\u0027re not mocking anything, this line seems unnecessary.","commit_id":"cbadae3712dd0d290d2b627472ec73a98b54260d"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"e80a7cfebe7127d9c2cf32a6a008855db0df4fcd","unresolved":false,"context_lines":[{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    @test.update_settings(ADMIN_FILTER_DATA_FIRST\u003dTrue)"},{"line_number":405,"context_line":"    def test_index_with_admin_filter_first(self):"},{"line_number":406,"context_line":"        self.mox.ReplayAll()"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        res \u003d self.client.get(INDEX_URL)"},{"line_number":409,"context_line":"        self.assertTemplateUsed(res, \u0027admin/instances/index.html\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_0dce11b4","line":406,"in_reply_to":"3aaa91ec_8d734f4d","updated":"2016-06-22 15:19:40.000000000","message":"Done","commit_id":"cbadae3712dd0d290d2b627472ec73a98b54260d"}],"openstack_dashboard/dashboards/admin/instances/views.py":[{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"76945c866200dd0feec7a3ed6a394a1b68d1b861","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        instances \u003d []"},{"line_number":78,"context_line":"        marker \u003d self.request.GET.get("},{"line_number":79,"context_line":"            project_tables.AdminInstancesTable._meta.pagination_param, None)"},{"line_number":80,"context_line":"        search_opts \u003d {\u0027marker\u0027: marker, \u0027paginate\u0027: True}"},{"line_number":81,"context_line":"        len_search_opts \u003d len(search_opts)"},{"line_number":82,"context_line":"        search_opts \u003d self.get_filters(search_opts)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_f3ad7632","line":80,"updated":"2016-06-20 20:27:14.000000000","message":"I don\u0027t like the reuse of the var name here, also the next var is unnecessary if you use a new variable name.","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"9117261b1981a8cfb72fbf21f27ad337bfa006ec","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        instances \u003d []"},{"line_number":78,"context_line":"        marker \u003d self.request.GET.get("},{"line_number":79,"context_line":"            project_tables.AdminInstancesTable._meta.pagination_param, None)"},{"line_number":80,"context_line":"        search_opts \u003d {\u0027marker\u0027: marker, \u0027paginate\u0027: True}"},{"line_number":81,"context_line":"        len_search_opts \u003d len(search_opts)"},{"line_number":82,"context_line":"        search_opts \u003d self.get_filters(search_opts)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_acba98be","line":80,"in_reply_to":"3aaa91ec_ac78d890","updated":"2016-06-21 19:15:33.000000000","message":"right, but why make it overly complicated? \ncall this default_search_opts and leave the result of get_filters() as search_opts, then you can call len on both vars directly in the if below.","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f9bdb1dfe2a7ae9352a78a29336fc44db850f07d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        instances \u003d []"},{"line_number":78,"context_line":"        marker \u003d self.request.GET.get("},{"line_number":79,"context_line":"            project_tables.AdminInstancesTable._meta.pagination_param, None)"},{"line_number":80,"context_line":"        search_opts \u003d {\u0027marker\u0027: marker, \u0027paginate\u0027: True}"},{"line_number":81,"context_line":"        len_search_opts \u003d len(search_opts)"},{"line_number":82,"context_line":"        search_opts \u003d self.get_filters(search_opts)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_e75f9973","line":80,"in_reply_to":"3aaa91ec_acba98be","updated":"2016-06-21 19:36:41.000000000","message":"Done","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"0ca72a2164d985f6d1ddba21e38f622a0db2d3d9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        instances \u003d []"},{"line_number":78,"context_line":"        marker \u003d self.request.GET.get("},{"line_number":79,"context_line":"            project_tables.AdminInstancesTable._meta.pagination_param, None)"},{"line_number":80,"context_line":"        search_opts \u003d {\u0027marker\u0027: marker, \u0027paginate\u0027: True}"},{"line_number":81,"context_line":"        len_search_opts \u003d len(search_opts)"},{"line_number":82,"context_line":"        search_opts \u003d self.get_filters(search_opts)"},{"line_number":83,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_ac78d890","line":80,"in_reply_to":"5a9d85d2_f3ad7632","updated":"2016-06-21 19:11:09.000000000","message":"I didn\u0027t understand what\u0027s the problem here. What I\u0027m trying to do here is get the \"default filters\" (the marker and paginate) length because if there is another filter, the search_opts var will mutate and the length will be different to the default one (I did not want to hardcode the number 2 to check the length)","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"76945c866200dd0feec7a3ed6a394a1b68d1b861","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        marker \u003d self.request.GET.get("},{"line_number":79,"context_line":"            project_tables.AdminInstancesTable._meta.pagination_param, None)"},{"line_number":80,"context_line":"        search_opts \u003d {\u0027marker\u0027: marker, \u0027paginate\u0027: True}"},{"line_number":81,"context_line":"        len_search_opts \u003d len(search_opts)"},{"line_number":82,"context_line":"        search_opts \u003d self.get_filters(search_opts)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        \"\"\"If admin_filter_first is set and if there are not other filters"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_736866f6","line":81,"updated":"2016-06-20 20:27:14.000000000","message":"this goes away","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f9bdb1dfe2a7ae9352a78a29336fc44db850f07d","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        marker \u003d self.request.GET.get("},{"line_number":79,"context_line":"            project_tables.AdminInstancesTable._meta.pagination_param, None)"},{"line_number":80,"context_line":"        search_opts \u003d {\u0027marker\u0027: marker, \u0027paginate\u0027: True}"},{"line_number":81,"context_line":"        len_search_opts \u003d len(search_opts)"},{"line_number":82,"context_line":"        search_opts \u003d self.get_filters(search_opts)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        \"\"\"If admin_filter_first is set and if there are not other filters"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_c7641d4b","line":81,"in_reply_to":"5a9d85d2_736866f6","updated":"2016-06-21 19:36:41.000000000","message":"Done","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"76945c866200dd0feec7a3ed6a394a1b68d1b861","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \"\"\"If admin_filter_first is set and if there are not other filters"},{"line_number":85,"context_line":"        selected, then search criteria must be provided and return an empty"},{"line_number":86,"context_line":"        list\"\"\""},{"line_number":87,"context_line":"        if self.admin_filter_first and len(search_opts) \u003d\u003d len_search_opts:"},{"line_number":88,"context_line":"            self._needs_filter_first \u003d True"},{"line_number":89,"context_line":"            self._more \u003d False"},{"line_number":90,"context_line":"            return instances"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a9d85d2_f37456d0","line":87,"updated":"2016-06-20 20:27:14.000000000","message":"this len calls search_opts_dict or whatever it\u0027s called","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"f9bdb1dfe2a7ae9352a78a29336fc44db850f07d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \"\"\"If admin_filter_first is set and if there are not other filters"},{"line_number":85,"context_line":"        selected, then search criteria must be provided and return an empty"},{"line_number":86,"context_line":"        list\"\"\""},{"line_number":87,"context_line":"        if self.admin_filter_first and len(search_opts) \u003d\u003d len_search_opts:"},{"line_number":88,"context_line":"            self._needs_filter_first \u003d True"},{"line_number":89,"context_line":"            self._more \u003d False"},{"line_number":90,"context_line":"            return instances"}],"source_content_type":"text/x-python","patch_set":5,"id":"3aaa91ec_275a4184","line":87,"in_reply_to":"5a9d85d2_f37456d0","updated":"2016-06-21 19:36:41.000000000","message":"Done","commit_id":"08c1e3840e387642a9efa21417109c1d88616018"},{"author":{"_account_id":11885,"name":"Ying Zuo","email":"yingzuo4@gmail.com","username":"yingzuo"},"change_message_id":"ed15b3be258f01685591c4da0ea1ef5c2cbd3d04","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        if self.admin_filter_first and \\"},{"line_number":88,"context_line":"                len(search_opts) \u003d\u003d len(default_search_opts):"},{"line_number":89,"context_line":"            self._needs_filter_first \u003d True"},{"line_number":90,"context_line":"            self._more \u003d False"},{"line_number":91,"context_line":"            return instances"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        self._needs_filter_first \u003d False"}],"source_content_type":"text/x-python","patch_set":8,"id":"3aaa91ec_4e727a4a","line":90,"updated":"2016-06-23 22:59:30.000000000","message":"I think you need to set self._prev to False here as well?","commit_id":"488efd784f95250b5f505de0ac1c84644eb37570"}]}
