)]}'
{"horizon/static/framework/widgets/magic-search/magic-search.controller.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9071d51f224ccc1050f0ec19472fa3eea85374b0","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    initSearch(service.getSearchTermsFromQueryString($window.location.search));"},{"line_number":74,"context_line":"    emitQuery();"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    $scope.$on(\u0027initSearch\u0027, function(event, data) {"},{"line_number":77,"context_line":"      if ( data ) {"},{"line_number":78,"context_line":"        if ( data.textSearch ) {"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_22108458","line":75,"updated":"2016-06-15 00:05:00.000000000","message":"This should be based on https://review.openstack.org/#/c/328551/\n\nand then use a constant. Let\u0027s not propagate any more strings like this.","commit_id":"ff4ad149ecc9ffa3279c2bbc50d9804c52ef61f7"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"6c17e6f1ed81cf4fbc3eebe15c59510875d1449b","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    initSearch(service.getSearchTermsFromQueryString($window.location.search));"},{"line_number":74,"context_line":"    emitQuery();"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    $scope.$on(\u0027initSearch\u0027, function(event, data) {"},{"line_number":77,"context_line":"      if ( data ) {"},{"line_number":78,"context_line":"        if ( data.textSearch ) {"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_cc7267e3","line":75,"in_reply_to":"7aa08908_22108458","updated":"2016-06-15 19:00:27.000000000","message":"Done","commit_id":"ff4ad149ecc9ffa3279c2bbc50d9804c52ef61f7"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9071d51f224ccc1050f0ec19472fa3eea85374b0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    initSearch(service.getSearchTermsFromQueryString($window.location.search));"},{"line_number":74,"context_line":"    emitQuery();"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    $scope.$on(\u0027initSearch\u0027, function(event, data) {"},{"line_number":77,"context_line":"      if ( data ) {"},{"line_number":78,"context_line":"        if ( data.textSearch ) {"},{"line_number":79,"context_line":"          // the requested text search will show up as a \u0027search in results\u0027 facet"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_c21c2079","line":76,"updated":"2016-06-15 00:05:00.000000000","message":"I\u0027d rather see this be based on the events code and have this add this event as a constant.","commit_id":"ff4ad149ecc9ffa3279c2bbc50d9804c52ef61f7"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"6c17e6f1ed81cf4fbc3eebe15c59510875d1449b","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    initSearch(service.getSearchTermsFromQueryString($window.location.search));"},{"line_number":74,"context_line":"    emitQuery();"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"    $scope.$on(\u0027initSearch\u0027, function(event, data) {"},{"line_number":77,"context_line":"      if ( data ) {"},{"line_number":78,"context_line":"        if ( data.textSearch ) {"},{"line_number":79,"context_line":"          // the requested text search will show up as a \u0027search in results\u0027 facet"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_2c804b8b","line":76,"in_reply_to":"7aa08908_c21c2079","updated":"2016-06-15 19:00:27.000000000","message":"Done","commit_id":"ff4ad149ecc9ffa3279c2bbc50d9804c52ef61f7"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"9071d51f224ccc1050f0ec19472fa3eea85374b0","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      if ( data ) {"},{"line_number":78,"context_line":"        if ( data.textSearch ) {"},{"line_number":79,"context_line":"          // the requested text search will show up as a \u0027search in results\u0027 facet"},{"line_number":80,"context_line":"          ctrl.textSearch \u003d data.textSearch;"},{"line_number":81,"context_line":"        } else {"},{"line_number":82,"context_line":"          // no requested text search, clear any prior text search"},{"line_number":83,"context_line":"          ctrl.textSearch \u003d undefined;"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_1d55edf8","line":80,"updated":"2016-06-15 00:05:00.000000000","message":"Can we initialize facets as well?","commit_id":"ff4ad149ecc9ffa3279c2bbc50d9804c52ef61f7"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"6c17e6f1ed81cf4fbc3eebe15c59510875d1449b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"      if ( data ) {"},{"line_number":78,"context_line":"        if ( data.textSearch ) {"},{"line_number":79,"context_line":"          // the requested text search will show up as a \u0027search in results\u0027 facet"},{"line_number":80,"context_line":"          ctrl.textSearch \u003d data.textSearch;"},{"line_number":81,"context_line":"        } else {"},{"line_number":82,"context_line":"          // no requested text search, clear any prior text search"},{"line_number":83,"context_line":"          ctrl.textSearch \u003d undefined;"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_2c05eb13","line":80,"in_reply_to":"7aa08908_1d55edf8","updated":"2016-06-15 19:00:27.000000000","message":"Yes. That is already supported using the \u0027facetsChanged\u0027 event.","commit_id":"ff4ad149ecc9ffa3279c2bbc50d9804c52ef61f7"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"ca298381fb6b528e6e188450e88fc382b9f32a2d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    initSearch(service.getSearchTermsFromQueryString($window.location.search));"},{"line_number":85,"context_line":"    emitQuery();"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    $scope.$on(magicSearchEvents.INIT_SEARCH, function(event, data) {"},{"line_number":88,"context_line":"      if ( data ) {"},{"line_number":89,"context_line":"        if ( data.textSearch ) {"},{"line_number":90,"context_line":"          // the requested text search will show up as a \u0027search in results\u0027 facet"}],"source_content_type":"text/javascript","patch_set":7,"id":"7aa08908_590f5888","line":87,"updated":"2016-06-15 19:35:07.000000000","message":"Referring back to comments on PS 6 and initializing the search.  I thought facetsChange was for initializing the available facets, not the selected facets and their values.  I\u0027m talking being able to set the currently selected facets / values at the time of initializing the search.","commit_id":"38ae383a6a07fe1daf90d6db563903a868dfb362"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"f47fc2daeb3b311eb77c501c58621549aa47e6fe","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    initSearch(service.getSearchTermsFromQueryString($window.location.search));"},{"line_number":85,"context_line":"    emitQuery();"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    $scope.$on(magicSearchEvents.INIT_SEARCH, function(event, data) {"},{"line_number":88,"context_line":"      if ( data ) {"},{"line_number":89,"context_line":"        if ( data.textSearch ) {"},{"line_number":90,"context_line":"          // the requested text search will show up as a \u0027search in results\u0027 facet"}],"source_content_type":"text/javascript","patch_set":7,"id":"fad55976_303f3027","line":87,"in_reply_to":"7aa08908_590f5888","updated":"2016-07-15 14:57:26.000000000","message":"It is a two step process.\n\nINIT_SEARCH allows the current search text and currently selected facets to be set. It then dispatches a CHECK_FACETS event which allows containing code to set the available facets given the currently selected search parameters.","commit_id":"38ae383a6a07fe1daf90d6db563903a868dfb362"}],"horizon/static/framework/widgets/magic-search/magic-search.module.js":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"f5b4ba656084d5eee121dd8596d737908256040e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        CHECK_FACETS: \u0027checkFacets\u0027,"},{"line_number":36,"context_line":"        FACETS_CHANGED: \u0027facetsChanged\u0027,"},{"line_number":37,"context_line":"        SERVER_SEARCH_UPDATED: \u0027serverSearchUpdated\u0027,"},{"line_number":38,"context_line":"        INIT_SEARCH: \u0027initSearch\u0027"},{"line_number":39,"context_line":"      }"},{"line_number":40,"context_line":"    );"},{"line_number":41,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"9a89bdaa_74dc0475","line":38,"updated":"2016-09-09 05:27:26.000000000","message":"I\u0027m a little concerned that none of these strings are scoped in any way, and could potentially collide with other events down the track. Perhaps just a \"ms:\" prefix?","commit_id":"c7df8a90b06deed1a06638efed599227cc6786fe"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"1066bfe32efd8322b7a04b288052f0a0e1a6464c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        CHECK_FACETS: \u0027checkFacets\u0027,"},{"line_number":36,"context_line":"        FACETS_CHANGED: \u0027facetsChanged\u0027,"},{"line_number":37,"context_line":"        SERVER_SEARCH_UPDATED: \u0027serverSearchUpdated\u0027,"},{"line_number":38,"context_line":"        INIT_SEARCH: \u0027initSearch\u0027"},{"line_number":39,"context_line":"      }"},{"line_number":40,"context_line":"    );"},{"line_number":41,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"9a89bdaa_b628cc34","line":38,"in_reply_to":"9a89bdaa_0c9176f1","updated":"2016-09-12 21:48:00.000000000","message":"I think the precedent is already set. A separate patch would be the place to resolve it for all. But Tyr\u0027s point about breaking plugins yet again is also a good one.","commit_id":"c7df8a90b06deed1a06638efed599227cc6786fe"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"e85b14f9c9100b68a18373a9c3ddb64e2d1a10fc","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        CHECK_FACETS: \u0027checkFacets\u0027,"},{"line_number":36,"context_line":"        FACETS_CHANGED: \u0027facetsChanged\u0027,"},{"line_number":37,"context_line":"        SERVER_SEARCH_UPDATED: \u0027serverSearchUpdated\u0027,"},{"line_number":38,"context_line":"        INIT_SEARCH: \u0027initSearch\u0027"},{"line_number":39,"context_line":"      }"},{"line_number":40,"context_line":"    );"},{"line_number":41,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"9a89bdaa_0c9176f1","line":38,"in_reply_to":"9a89bdaa_74dc0475","updated":"2016-09-12 17:37:43.000000000","message":"I share your concern Richard. I\u0027d like to see us use the full constant path as part of the event name.\n\nHowever, at this point in the release, I don\u0027t think it would be a good idea to do that kind of refactor as we might accidentally break plugins that attempt to use magic search.\n\nI filed https://bugs.launchpad.net/horizon/+bug/1622698 as possible Ocata work. Does that address your concern enough for the Newton release?","commit_id":"c7df8a90b06deed1a06638efed599227cc6786fe"}]}
