)]}'
{"openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"560b8fc0dcdd4b6a3398b2cb19f427802ec7d659","unresolved":false,"context_lines":[{"line_number":71,"context_line":"     */"},{"line_number":72,"context_line":"    ctrl.bootSourcesOptions \u003d ["},{"line_number":73,"context_line":"      { type: bootSourceTypes.IMAGE, label: gettext(\u0027Image\u0027) },"},{"line_number":74,"context_line":"      { type: bootSourceTypes.INSTANCE_SNAPSHOT, label: gettext(\u0027Instance Snapshot\u0027) },"},{"line_number":75,"context_line":"      { type: bootSourceTypes.VOLUME, label: gettext(\u0027Volume\u0027) },"},{"line_number":76,"context_line":"      { type: bootSourceTypes.VOLUME_SNAPSHOT, label: gettext(\u0027Volume Snapshot\u0027) }"},{"line_number":77,"context_line":"    ];"}],"source_content_type":"text/javascript","patch_set":3,"id":"7aa08908_57047448","line":74,"updated":"2016-06-14 23:21:56.000000000","message":"Instance snapshot also can be boot to volume.","commit_id":"f4bc4aebfebf99833fb4cae354b2cdef9cf558e4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"560b8fc0dcdd4b6a3398b2cb19f427802ec7d659","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    function updateBootSourceSelection(selectedSource) {"},{"line_number":395,"context_line":"      ctrl.currentBootSource \u003d selectedSource;"},{"line_number":396,"context_line":"      if (selectedSource \u003d\u003d\u003d bootSourceTypes.IMAGE \u0026\u0026 $scope.model.volumeBootable) {"},{"line_number":397,"context_line":"        $scope.model.newInstanceSpec.vol_create \u003d true;"},{"line_number":398,"context_line":"      } else {"},{"line_number":399,"context_line":"        $scope.model.newInstanceSpec.vol_create \u003d false;"}],"source_content_type":"text/javascript","patch_set":3,"id":"7aa08908_d7bd0469","line":396,"updated":"2016-06-14 23:21:56.000000000","message":"INSTANCE_SNAPSHOT is also volume bootable. See above:\n\nAnd here:\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.controller.js#L74","commit_id":"f4bc4aebfebf99833fb4cae354b2cdef9cf558e4"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"258fcc42c145efea4436753340aeb94c104296fa","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    function updateBootSourceSelection(selectedSource) {"},{"line_number":403,"context_line":"      ctrl.currentBootSource \u003d selectedSource;"},{"line_number":404,"context_line":"      if ((selectedSource \u003d\u003d\u003d bootSourceTypes.IMAGE ||"},{"line_number":405,"context_line":"           selectedSource \u003d\u003d\u003d bootSourceTypes.INSTANCE_SNAPSHOT) \u0026\u0026"},{"line_number":406,"context_line":"           $scope.model.volumeBootable) {"},{"line_number":407,"context_line":"        $scope.model.newInstanceSpec.vol_create \u003d true;"},{"line_number":408,"context_line":"      } else {"}],"source_content_type":"text/javascript","patch_set":7,"id":"5a8bc5a2_cf825652","line":405,"range":{"start_line":405,"start_character":11,"end_line":405,"end_character":63},"updated":"2016-09-23 12:42:07.000000000","message":"This is a little bit inconsistent with what I see at https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/static/dashboard/project/workflow/launch-instance/source/source.html#L23-L36 - i.e., only for \u0027image\u0027 source type this control is expected to be visible.","commit_id":"ed74698413932a0ce91bd92877a4cca26c9ac0c2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5efa04e6896a83ddce048c7a3b30a99e8aed2d4e","unresolved":false,"context_lines":[{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    function updateBootSourceSelection(selectedSource) {"},{"line_number":403,"context_line":"      ctrl.currentBootSource \u003d selectedSource;"},{"line_number":404,"context_line":"      if ((selectedSource \u003d\u003d\u003d bootSourceTypes.IMAGE) \u0026\u0026 $scope.model.volumeBootable) {"},{"line_number":405,"context_line":"        $scope.model.newInstanceSpec.vol_create \u003d true;"},{"line_number":406,"context_line":"      } else {"},{"line_number":407,"context_line":"        $scope.model.newInstanceSpec.vol_create \u003d false;"}],"source_content_type":"text/javascript","patch_set":9,"id":"5a8bc5a2_214c869d","line":404,"updated":"2016-09-25 04:42:51.000000000","message":"It is correct from the current Horizon implementation.\n\nOn the other hand, it is a valid operation to create a new volume from image snapshot and it is supported in Nova API and CLI. I noticed this and filed a bug https://launchpad.net/bugs/1627416 so patch set 7 looks fine. However, it is not sufficient just to revert it to patch set 7. I can rebase my patch https://review.openstack.org/#/c/375927/1 on top of this.","commit_id":"723e547e848f580bf5f16899cd2bffa23c77c763"}]}