)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"45eb6c19a4cfb393df4fed96c83e5507a03d71fd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improved table deletion efficiency"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volums pagination Integration test used to delete row per row using table"},{"line_number":10,"context_line":"action, now it will select all rows then delete them with the table action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7f8fdc7e0ccefdd0f6d71f9f92c8a2aefeec8d54"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_d0bd1103","line":9,"updated":"2016-06-01 20:58:10.000000000","message":"Volums -\u003e Volumes","commit_id":"f2af3a37bcbd2668a9edea735f71ba95afef83e9"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"c682f97266b06ce4023563ca7444f4e478b44f0e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improved table deletion efficiency"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volums pagination Integration test used to delete row per row using table"},{"line_number":10,"context_line":"action, now it will select all rows then delete them with the table action."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7f8fdc7e0ccefdd0f6d71f9f92c8a2aefeec8d54"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_7d64b948","line":9,"in_reply_to":"9abb7d3a_d0bd1103","updated":"2016-06-02 21:15:09.000000000","message":"Fixed the typo and fixed the size of each line","commit_id":"f2af3a37bcbd2668a9edea735f71ba95afef83e9"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"aa5ac593404086f2d4994996660d434b303ca45d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improved table deletion efficiency"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volumes and instances integration tests delete and validates row per row, now"},{"line_number":10,"context_line":"they are able to delete and validate multiple rows."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7f8fdc7e0ccefdd0f6d71f9f92c8a2aefeec8d54"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3aaa91ec_13d14bce","line":9,"range":{"start_line":9,"start_character":45,"end_line":9,"end_character":46},"updated":"2016-06-21 18:32:26.000000000","message":"ed","commit_id":"9f62f636ed4c70142375b7394136bbb4d4f0e13f"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"aa5ac593404086f2d4994996660d434b303ca45d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improved table deletion efficiency"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volumes and instances integration tests delete and validates row per row, now"},{"line_number":10,"context_line":"they are able to delete and validate multiple rows."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7f8fdc7e0ccefdd0f6d71f9f92c8a2aefeec8d54"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3aaa91ec_33d8c7ef","line":9,"range":{"start_line":9,"start_character":59,"end_line":9,"end_character":60},"updated":"2016-06-21 18:32:26.000000000","message":"ed","commit_id":"9f62f636ed4c70142375b7394136bbb4d4f0e13f"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"aa5ac593404086f2d4994996660d434b303ca45d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Improved table deletion efficiency"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volumes and instances integration tests delete and validates row per row, now"},{"line_number":10,"context_line":"they are able to delete and validate multiple rows."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I7f8fdc7e0ccefdd0f6d71f9f92c8a2aefeec8d54"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"3aaa91ec_d3ed0390","line":9,"range":{"start_line":9,"start_character":61,"end_line":9,"end_character":72},"updated":"2016-06-21 18:32:26.000000000","message":"entities one row at a time","commit_id":"9f62f636ed4c70142375b7394136bbb4d4f0e13f"}],"openstack_dashboard/test/integration_tests/pages/project/compute/volumes/volumespage.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"84bb341eaea67dce38fb5c37690e04c07fdd04b8","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        confirm_delete_volumes_form \u003d self.volumes_table.delete_volume()"},{"line_number":138,"context_line":"        confirm_delete_volumes_form.submit()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def delete_all_volumes(self):"},{"line_number":141,"context_line":"        select_all_checkbox \u003d self._get_element("},{"line_number":142,"context_line":"            By.CSS_SELECTOR, \u0027.themable-checkbox\u0027)"},{"line_number":143,"context_line":"        select_all_checkbox.click()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_d89c0160","line":140,"updated":"2016-06-02 08:47:18.000000000","message":"Not exactly what we would to have in case of parallelizing the tests. If 2 tests on volumes are run in parallel, then one test deleting _all_ volumes could interfere with the results of another test. A safer bet is to pass a list of volume names to be deleted here.","commit_id":"f2af3a37bcbd2668a9edea735f71ba95afef83e9"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"c682f97266b06ce4023563ca7444f4e478b44f0e","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        confirm_delete_volumes_form \u003d self.volumes_table.delete_volume()"},{"line_number":138,"context_line":"        confirm_delete_volumes_form.submit()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def delete_all_volumes(self):"},{"line_number":141,"context_line":"        select_all_checkbox \u003d self._get_element("},{"line_number":142,"context_line":"            By.CSS_SELECTOR, \u0027.themable-checkbox\u0027)"},{"line_number":143,"context_line":"        select_all_checkbox.click()"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_7d99591f","line":140,"in_reply_to":"9abb7d3a_d89c0160","updated":"2016-06-02 21:15:09.000000000","message":"Now is deleting the created volumes","commit_id":"f2af3a37bcbd2668a9edea735f71ba95afef83e9"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"ae483d9b3c962304dce4ada2294f5ce0bf101d30","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        confirm_delete_volumes_form \u003d self.volumes_table.delete_volume()"},{"line_number":138,"context_line":"        confirm_delete_volumes_form.submit()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def delete_volumes(self, volumes_names\u003d{}):"},{"line_number":141,"context_line":"        for volume_name in volumes_names:"},{"line_number":142,"context_line":"            row\u003dself._get_row_with_volume_name(volume_name)"},{"line_number":143,"context_line":"            row.mark()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_9af984cb","line":140,"range":{"start_line":140,"start_character":43,"end_line":140,"end_character":45},"updated":"2016-06-03 10:22:40.000000000","message":"Setting mutable type as a default value is dangerous because if it\u0027s modified, it will be stored between calls. Also, are you sure that dict has to be used here?","commit_id":"2aba06d99a6ea48564c90c6b9f048f0bc0c84e15"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"bdfbfcb31290ba244bdd97905148c44c7078cb5c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        confirm_delete_volumes_form \u003d self.volumes_table.delete_volume()"},{"line_number":138,"context_line":"        confirm_delete_volumes_form.submit()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def delete_volumes(self, volumes_names\u003d{}):"},{"line_number":141,"context_line":"        for volume_name in volumes_names:"},{"line_number":142,"context_line":"            row\u003dself._get_row_with_volume_name(volume_name)"},{"line_number":143,"context_line":"            row.mark()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_942388bc","line":140,"range":{"start_line":140,"start_character":43,"end_line":140,"end_character":45},"in_reply_to":"9abb7d3a_9af984cb","updated":"2016-06-08 21:10:02.000000000","message":"Done","commit_id":"2aba06d99a6ea48564c90c6b9f048f0bc0c84e15"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"ae483d9b3c962304dce4ada2294f5ce0bf101d30","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def delete_volumes(self, volumes_names\u003d{}):"},{"line_number":141,"context_line":"        for volume_name in volumes_names:"},{"line_number":142,"context_line":"            row\u003dself._get_row_with_volume_name(volume_name)"},{"line_number":143,"context_line":"            row.mark()"},{"line_number":144,"context_line":"        confirm_delete_volumes_form \u003d self.volumes_table.delete_volume()"},{"line_number":145,"context_line":"        confirm_delete_volumes_form.submit()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_1ad0f452","line":142,"range":{"start_line":142,"start_character":15,"end_line":142,"end_character":16},"updated":"2016-06-03 10:22:40.000000000","message":"pep8 check is yelling at missing spaces here. You could merge this and below line into one and get rid of `row` variable.","commit_id":"2aba06d99a6ea48564c90c6b9f048f0bc0c84e15"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"bdfbfcb31290ba244bdd97905148c44c7078cb5c","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def delete_volumes(self, volumes_names\u003d{}):"},{"line_number":141,"context_line":"        for volume_name in volumes_names:"},{"line_number":142,"context_line":"            row\u003dself._get_row_with_volume_name(volume_name)"},{"line_number":143,"context_line":"            row.mark()"},{"line_number":144,"context_line":"        confirm_delete_volumes_form \u003d self.volumes_table.delete_volume()"},{"line_number":145,"context_line":"        confirm_delete_volumes_form.submit()"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_543da0db","line":142,"range":{"start_line":142,"start_character":15,"end_line":142,"end_character":16},"in_reply_to":"9abb7d3a_1ad0f452","updated":"2016-06-08 21:10:02.000000000","message":"Done","commit_id":"2aba06d99a6ea48564c90c6b9f048f0bc0c84e15"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"ae483d9b3c962304dce4ada2294f5ce0bf101d30","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        return self.volumes_table.is_row_deleted("},{"line_number":167,"context_line":"            lambda: self._get_row_with_volume_name(name))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def are_volumes_deleted(self, volumes_names\u003d{}):"},{"line_number":170,"context_line":"        for volume_name in volumes_names:"},{"line_number":171,"context_line":"            if not self.is_volume_deleted(volume_name):"},{"line_number":172,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_3a297838","line":169,"range":{"start_line":169,"start_character":48,"end_line":169,"end_character":50},"updated":"2016-06-03 10:22:40.000000000","message":"ditto","commit_id":"2aba06d99a6ea48564c90c6b9f048f0bc0c84e15"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"bdfbfcb31290ba244bdd97905148c44c7078cb5c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        return self.volumes_table.is_row_deleted("},{"line_number":167,"context_line":"            lambda: self._get_row_with_volume_name(name))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def are_volumes_deleted(self, volumes_names\u003d{}):"},{"line_number":170,"context_line":"        for volume_name in volumes_names:"},{"line_number":171,"context_line":"            if not self.is_volume_deleted(volume_name):"},{"line_number":172,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_f42e4ca3","line":169,"range":{"start_line":169,"start_character":48,"end_line":169,"end_character":50},"in_reply_to":"9abb7d3a_3a297838","updated":"2016-06-08 21:10:02.000000000","message":"Done","commit_id":"2aba06d99a6ea48564c90c6b9f048f0bc0c84e15"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"ae483d9b3c962304dce4ada2294f5ce0bf101d30","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            lambda: self._get_row_with_volume_name(name))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def are_volumes_deleted(self, volumes_names\u003d{}):"},{"line_number":170,"context_line":"        for volume_name in volumes_names:"},{"line_number":171,"context_line":"            if not self.is_volume_deleted(volume_name):"},{"line_number":172,"context_line":"                return False"},{"line_number":173,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"9abb7d3a_35718ba9","line":170,"updated":"2016-06-03 10:22:40.000000000","message":"The approach with calling self.is_volume_deleted() for each volume will call https://github.com/openstack/horizon/blob/master/openstack_dashboard/test/integration_tests/regions/tables.py#L153 as many times as there are volumes, which at worst case will wait inside _wait_until() for a full timeout (equal to 5 minutes). A better approach would be to create another implementation of is_row_deleted, called \u0027are_rows_deleted\u0027 - to make a predicate inside _wait_until wait until all rows are deleted (only one 5-minute timeout in worst case).\n\nPlease contact me in #openstack-horizon IRC channel if you have any questions.","commit_id":"2aba06d99a6ea48564c90c6b9f048f0bc0c84e15"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"bdfbfcb31290ba244bdd97905148c44c7078cb5c","unresolved":false,"context_lines":[{"line_number":167,"context_line":"            lambda: self._get_row_with_volume_name(name))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def are_volumes_deleted(self, volumes_names\u003d{}):"},{"line_number":170,"context_line":"        for volume_name in volumes_names:"},{"line_number":171,"context_line":"            if not self.is_volume_deleted(volume_name):"},{"line_number":172,"context_line":"                return False"},{"line_number":173,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_5414804b","line":170,"in_reply_to":"9abb7d3a_35718ba9","updated":"2016-06-08 21:10:02.000000000","message":"I did a fix, I don\u0027t really know if it\u0027s the best one, I would really appreciate your feedback.","commit_id":"2aba06d99a6ea48564c90c6b9f048f0bc0c84e15"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"cf3ebcf8614ef05aa5047c23dc621b0c26b68878","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self.VOLUMES_TABLE_NAME_COLUMN, name)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _get_rows_with_volumes_names(self, names):"},{"line_number":108,"context_line":"        rows \u003d []"},{"line_number":109,"context_line":"        for name in names:"},{"line_number":110,"context_line":"            rows.append(self.volumes_table.get_row("},{"line_number":111,"context_line":"                self.VOLUMES_TABLE_NAME_COLUMN, name))"},{"line_number":112,"context_line":"        return rows"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @property"},{"line_number":115,"context_line":"    def volumes_table(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_f71e325e","line":112,"range":{"start_line":108,"start_character":8,"end_line":112,"end_character":19},"updated":"2016-06-09 11:11:15.000000000","message":"Writing this as\n\n  return [self.volumes_table.get_row(self.VOLUMES_TABLE_NAME_COLUMN, n)\n          for n in names]\n\nwould be more concise.","commit_id":"3fe34b3cfaafbc0a8dc158f61951b2d4f84a5079"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"a370a6612969c8ecab585fd9184850b259640919","unresolved":false,"context_lines":[{"line_number":105,"context_line":"            self.VOLUMES_TABLE_NAME_COLUMN, name)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def _get_rows_with_volumes_names(self, names):"},{"line_number":108,"context_line":"        rows \u003d []"},{"line_number":109,"context_line":"        for name in names:"},{"line_number":110,"context_line":"            rows.append(self.volumes_table.get_row("},{"line_number":111,"context_line":"                self.VOLUMES_TABLE_NAME_COLUMN, name))"},{"line_number":112,"context_line":"        return rows"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    @property"},{"line_number":115,"context_line":"    def volumes_table(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_fb727f48","line":112,"range":{"start_line":108,"start_character":8,"end_line":112,"end_character":19},"in_reply_to":"7aa08908_f71e325e","updated":"2016-06-09 20:12:47.000000000","message":"Done, Wow for being honest I\u0027m new also in the language but it looks pretty good the stuff that can be done to improve the lines of code.","commit_id":"3fe34b3cfaafbc0a8dc158f61951b2d4f84a5079"},{"author":{"_account_id":6890,"name":"Martin Pavlásek","email":"mpavlase@redhat.com","username":"mpavlase"},"change_message_id":"a0e5ca1dc610b18720ca59fe0fcc00bb5f133292","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def delete_volumes(self, volumes_names):"},{"line_number":145,"context_line":"        for volume_name in volumes_names:"},{"line_number":146,"context_line":"            self._get_row_with_volume_name(volume_name).mark()"},{"line_number":147,"context_line":"        confirm_delete_volumes_form \u003d self.volumes_table.delete_volume()"},{"line_number":148,"context_line":"        confirm_delete_volumes_form.submit()"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_35529913","line":146,"range":{"start_line":146,"start_character":55,"end_line":146,"end_character":62},"updated":"2016-06-14 15:22:04.000000000","message":"I didn\u0027t try this patch, I can be wrong, but according to just reading it seems that this .mark() method couldn\u0027t work. Method _get_rows_with_volumes_names returns always list and not an instance of object self.volumes_table.get_row.","commit_id":"3585dca2169363a8376b666cb5db1c5ccf675194"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"eb77f43bf2b86212dd60dc9503ff1173f3635df9","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def delete_volumes(self, volumes_names):"},{"line_number":145,"context_line":"        for volume_name in volumes_names:"},{"line_number":146,"context_line":"            self._get_row_with_volume_name(volume_name).mark()"},{"line_number":147,"context_line":"        confirm_delete_volumes_form \u003d self.volumes_table.delete_volume()"},{"line_number":148,"context_line":"        confirm_delete_volumes_form.submit()"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_b074d7ce","line":146,"range":{"start_line":146,"start_character":55,"end_line":146,"end_character":62},"in_reply_to":"7aa08908_35529913","updated":"2016-06-14 15:40:56.000000000","message":"In this method I\u0027m calling _get_row_with_volume_name(volume_name) giving it the parameter volume name that is taken from the list of all previously created volumes, the other method is used for the validation when the volumes are deleted.","commit_id":"3585dca2169363a8376b666cb5db1c5ccf675194"}],"openstack_dashboard/test/integration_tests/regions/tables.py":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"cf3ebcf8614ef05aa5047c23dc621b0c26b68878","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            if self._is_element_present(*self._empty_table_locator):"},{"line_number":170,"context_line":"                return True"},{"line_number":171,"context_line":"            with self.waits_disabled():"},{"line_number":172,"context_line":"                rows \u003d rows_getter()"},{"line_number":173,"context_line":"                result \u003d True"},{"line_number":174,"context_line":"                for row in rows:"},{"line_number":175,"context_line":"                    result \u003d result and not self._is_element_displayed(row)"},{"line_number":176,"context_line":"                return result"},{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            self._wait_until(predicate)"},{"line_number":179,"context_line":"        except exceptions.TimeoutException:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_f7e592dc","line":176,"range":{"start_line":172,"start_character":16,"end_line":176,"end_character":29},"updated":"2016-06-09 11:11:15.000000000","message":"Is equivalent to\n\n  return all([not self._is_element_displayed(row) for row \n              in rows_getter()])\n\nAnd that this check is also one (or two, given pep8 limitations) liner, we can abstract away most part of is_row_deleted()/are_rows_deleted() and pass a short predicate into both, something like\n\n    def is_row_deleted(self, row_getter):\n        return self._is_row_deleted(\n            lambda: not self._is_element_displayed(row_getter()))\n\n    def are_rows_deleted(self, rows_getter):\n        return self._is_row_deleted(\n            lambda: all([not self._is_element_displayed(row) for row\n                         in rows_getter()]))","commit_id":"3fe34b3cfaafbc0a8dc158f61951b2d4f84a5079"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"a370a6612969c8ecab585fd9184850b259640919","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            if self._is_element_present(*self._empty_table_locator):"},{"line_number":170,"context_line":"                return True"},{"line_number":171,"context_line":"            with self.waits_disabled():"},{"line_number":172,"context_line":"                rows \u003d rows_getter()"},{"line_number":173,"context_line":"                result \u003d True"},{"line_number":174,"context_line":"                for row in rows:"},{"line_number":175,"context_line":"                    result \u003d result and not self._is_element_displayed(row)"},{"line_number":176,"context_line":"                return result"},{"line_number":177,"context_line":"        try:"},{"line_number":178,"context_line":"            self._wait_until(predicate)"},{"line_number":179,"context_line":"        except exceptions.TimeoutException:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_3bcb6720","line":176,"range":{"start_line":172,"start_character":16,"end_line":176,"end_character":29},"in_reply_to":"7aa08908_f7e592dc","updated":"2016-06-09 20:12:47.000000000","message":"Done","commit_id":"3fe34b3cfaafbc0a8dc158f61951b2d4f84a5079"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"b92f072e36fd9bc9dfa41618c094097cecf9a221","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        return [RowRegion(self.driver, self.conf, elem, self.column_names)"},{"line_number":151,"context_line":"                for elem in self._get_elements(*self._rows_locator)]"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _is_row_deleted(self, evaluate):"},{"line_number":154,"context_line":"        def predicate(driver):"},{"line_number":155,"context_line":"            if self._is_element_present(*self._empty_table_locator):"},{"line_number":156,"context_line":"                return True"}],"source_content_type":"text/x-python","patch_set":7,"id":"7aa08908_d2496834","line":153,"range":{"start_line":153,"start_character":30,"end_line":153,"end_character":38},"updated":"2016-06-15 16:41:36.000000000","message":"My only (and highly opinionated) concern is about argument name - generally, when a function is passed as a value, it\u0027s given a name which is a noun (like \u0027predicate\u0027, \u0027evaluator\u0027, etc), not the verb.","commit_id":"51dee7722c4258535fc14fd9c6763130d34cdfab"}],"openstack_dashboard/test/integration_tests/tests/test_volumes.py":[{"author":{"_account_id":7179,"name":"Brad Pokorny","email":"brad_pokorny@symantec.com","username":"bpokorny"},"change_message_id":"45eb6c19a4cfb393df4fed96c83e5507a03d71fd","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        volumes_page \u003d self.volumes_page"},{"line_number":142,"context_line":"        volumes_page.delete_all_volumes()"},{"line_number":143,"context_line":"        volumes_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":144,"context_line":"        self.assertTrue(volumes_page.is_volume_deleted(volume_name))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class TestAdminVolumes(helpers.AdminTestCase, TestVolumesBasic):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_70db857c","line":144,"updated":"2016-06-01 20:58:10.000000000","message":"I don\u0027t think this checks what was originally intended anymore. It used to validate that each volume_name in a list was deleted, but it now only validates one volume was deleted (probably the last volume_name from the loop at line 104). The assert here should be modified to validate all volumes deleted by delete_all_volumes() were actually deleted.","commit_id":"f2af3a37bcbd2668a9edea735f71ba95afef83e9"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"84bb341eaea67dce38fb5c37690e04c07fdd04b8","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        volumes_page \u003d self.volumes_page"},{"line_number":142,"context_line":"        volumes_page.delete_all_volumes()"},{"line_number":143,"context_line":"        volumes_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":144,"context_line":"        self.assertTrue(volumes_page.is_volume_deleted(volume_name))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class TestAdminVolumes(helpers.AdminTestCase, TestVolumesBasic):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_f8246561","line":144,"in_reply_to":"9abb7d3a_70db857c","updated":"2016-06-02 08:47:18.000000000","message":"I second that notion.","commit_id":"f2af3a37bcbd2668a9edea735f71ba95afef83e9"},{"author":{"_account_id":20506,"name":"Juan Pablo lopez Gutierrez","email":"juan.pablo.lopez.gutierrez@intel.com","username":"jlopezgu"},"change_message_id":"c682f97266b06ce4023563ca7444f4e478b44f0e","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        volumes_page \u003d self.volumes_page"},{"line_number":142,"context_line":"        volumes_page.delete_all_volumes()"},{"line_number":143,"context_line":"        volumes_page.find_message_and_dismiss(messages.SUCCESS)"},{"line_number":144,"context_line":"        self.assertTrue(volumes_page.is_volume_deleted(volume_name))"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"class TestAdminVolumes(helpers.AdminTestCase, TestVolumesBasic):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_dde7a5aa","line":144,"in_reply_to":"9abb7d3a_f8246561","updated":"2016-06-02 21:15:09.000000000","message":"should I check each deletion like in the new patch or just omit the check?","commit_id":"f2af3a37bcbd2668a9edea735f71ba95afef83e9"}]}
