)]}'
{"openstack_dashboard/dashboards/project/loadbalancers/workflows.py":[{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"057a0b9f5f6c068dcb74e757830cb9353929dc64","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.fields[\u0027lb_method\u0027].choices \u003d lb_method_choices"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    class Meta:"},{"line_number":74,"context_line":"        name \u003d _(\"Pool Details\")"},{"line_number":75,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":76,"context_line":"        help_text \u003d _(\"Create Pool for current tenant.\\n\\n\""},{"line_number":77,"context_line":"                      \"Assign a name and description for the pool. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FxpQ%3D","line":74,"updated":"2013-06-10 21:54:51.000000000","message":"Old wf template uses \"Add New Pool\"","commit_id":"12f85427cb1ff1f3c4dc9add4a0a075deaa11501"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"bdb89f675a94e03211d6faeba96f5aacf8e19ba1","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        self.fields[\u0027lb_method\u0027].choices \u003d lb_method_choices"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    class Meta:"},{"line_number":74,"context_line":"        name \u003d _(\"Pool Details\")"},{"line_number":75,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":76,"context_line":"        help_text \u003d _(\"Create Pool for current tenant.\\n\\n\""},{"line_number":77,"context_line":"                      \"Assign a name and description for the pool. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FwsU%3D","line":74,"in_reply_to":"AAAAPX%2F%2FxpQ%3D","updated":"2013-06-11 06:44:01.000000000","message":"Done","commit_id":"12f85427cb1ff1f3c4dc9add4a0a075deaa11501"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"057a0b9f5f6c068dcb74e757830cb9353929dc64","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return cleaned_data"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    class Meta:"},{"line_number":179,"context_line":"        name \u003d _(\"Vip Details\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create a VIP for this pool. \""},{"line_number":182,"context_line":"                      \"Assign a name and description for the VIP. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FxpU%3D","line":179,"updated":"2013-06-10 21:54:51.000000000","message":"User \"VIP\" instead of \"Vip\".\n\nFrom the old wf template, it uses \"Specify Vip\". Maybe we should the \"Specify VIP\"","commit_id":"12f85427cb1ff1f3c4dc9add4a0a075deaa11501"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"bdb89f675a94e03211d6faeba96f5aacf8e19ba1","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return cleaned_data"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    class Meta:"},{"line_number":179,"context_line":"        name \u003d _(\"Vip Details\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create a VIP for this pool. \""},{"line_number":182,"context_line":"                      \"Assign a name and description for the VIP. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2FwsY%3D","line":179,"in_reply_to":"AAAAPX%2F%2FxpU%3D","updated":"2013-06-11 06:44:01.000000000","message":"Done","commit_id":"12f85427cb1ff1f3c4dc9add4a0a075deaa11501"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"057a0b9f5f6c068dcb74e757830cb9353929dc64","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            key\u003dlambda member: member[1])"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    class Meta:"},{"line_number":315,"context_line":"        name \u003d _(\"Member Details\")"},{"line_number":316,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":317,"context_line":"        help_text \u003d _(\"Add member to selected pool.\\n\\n\""},{"line_number":318,"context_line":"                      \"Choose one or more listed instances to be \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fxpc%3D","line":315,"updated":"2013-06-10 21:54:51.000000000","message":"From the old wf template, it uses \"Add New Member\"","commit_id":"12f85427cb1ff1f3c4dc9add4a0a075deaa11501"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"bdb89f675a94e03211d6faeba96f5aacf8e19ba1","unresolved":false,"context_lines":[{"line_number":312,"context_line":"            key\u003dlambda member: member[1])"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    class Meta:"},{"line_number":315,"context_line":"        name \u003d _(\"Member Details\")"},{"line_number":316,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":317,"context_line":"        help_text \u003d _(\"Add member to selected pool.\\n\\n\""},{"line_number":318,"context_line":"                      \"Choose one or more listed instances to be \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fwsg%3D","line":315,"in_reply_to":"AAAAPX%2F%2Fxpc%3D","updated":"2013-06-11 06:44:01.000000000","message":"Done","commit_id":"12f85427cb1ff1f3c4dc9add4a0a075deaa11501"},{"author":{"_account_id":1941,"name":"Lin Hua Cheng","email":"os.lcheng@gmail.com","username":"lin-hua-cheng"},"change_message_id":"057a0b9f5f6c068dcb74e757830cb9353929dc64","unresolved":false,"context_lines":[{"line_number":462,"context_line":"        return cleaned_data"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    class Meta:"},{"line_number":465,"context_line":"        name \u003d _(\"Monitor Details\")"},{"line_number":466,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":467,"context_line":"        help_text \u003d _(\"Create a monitor for a pool.\\n\\n\""},{"line_number":468,"context_line":"                      \"Select target pool and type of monitoring. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fxps%3D","line":465,"updated":"2013-06-10 21:54:51.000000000","message":"From the old wf template, the name was \"Add New Monitor\".","commit_id":"12f85427cb1ff1f3c4dc9add4a0a075deaa11501"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"bdb89f675a94e03211d6faeba96f5aacf8e19ba1","unresolved":false,"context_lines":[{"line_number":462,"context_line":"        return cleaned_data"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"    class Meta:"},{"line_number":465,"context_line":"        name \u003d _(\"Monitor Details\")"},{"line_number":466,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":467,"context_line":"        help_text \u003d _(\"Create a monitor for a pool.\\n\\n\""},{"line_number":468,"context_line":"                      \"Select target pool and type of monitoring. \""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPX%2F%2Fwsc%3D","line":465,"in_reply_to":"AAAAPX%2F%2Fxps%3D","updated":"2013-06-11 06:44:01.000000000","message":"Done","commit_id":"12f85427cb1ff1f3c4dc9add4a0a075deaa11501"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f0dae87ac107250b4d22ec6d7140802cfbf528f2","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return cleaned_data"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    class Meta:"},{"line_number":179,"context_line":"        name \u003d _(\"Specify VIP\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create a VIP for this pool. \""},{"line_number":182,"context_line":"                      \"Assign a name and description for the VIP. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FwhE%3D","line":179,"updated":"2013-06-11 08:44:43.000000000","message":"Why not \"Add VIP\"? While other AddXXXAction classes use \"Add XXX\", this does not.","commit_id":"7309bcb8928339c79ee94a7fd9ec107dd8debb66"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"808609e380c2a2fafc3935e904599f7d305e8a46","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return cleaned_data"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    class Meta:"},{"line_number":179,"context_line":"        name \u003d _(\"Specify VIP\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create a VIP for this pool. \""},{"line_number":182,"context_line":"                      \"Assign a name and description for the VIP. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fqpo%3D","line":179,"in_reply_to":"AAAAPX%2F%2Fv4s%3D","updated":"2013-06-13 06:34:06.000000000","message":"I agree. Moreover, in the previous review I had to do such transition and I can say that we would get nearly nothing: the code would be simpler a bit but we would have to add two templates instead of adding nothing and using the generic one.","commit_id":"7309bcb8928339c79ee94a7fd9ec107dd8debb66"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"45aa1cb76a5fd8f5d743b58ed0d513a322174a93","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return cleaned_data"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    class Meta:"},{"line_number":179,"context_line":"        name \u003d _(\"Specify VIP\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create a VIP for this pool. \""},{"line_number":182,"context_line":"                      \"Assign a name and description for the VIP. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2Fv4s%3D","line":179,"in_reply_to":"AAAAPX%2F%2FwWc%3D","updated":"2013-06-11 13:39:14.000000000","message":"I remember we have the same discussion in the previous review. At that time, we decided to keep workflow unchanged since the transition from workflow to form and vice versa requires non-trivial efforts but we would not get much :-(","commit_id":"7309bcb8928339c79ee94a7fd9ec107dd8debb66"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2c6f9fb2f3bc7a7274653a68d4f85efa3bf386f1","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return cleaned_data"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    class Meta:"},{"line_number":179,"context_line":"        name \u003d _(\"Specify VIP\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create a VIP for this pool. \""},{"line_number":182,"context_line":"                      \"Assign a name and description for the VIP. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FwYg%3D","line":179,"in_reply_to":"AAAAPX%2F%2FwY4%3D","updated":"2013-06-11 10:05:39.000000000","message":"I forgot to write. \"Specify VIP\" looks better to me than \"Add VIP\", so we can keep it.","commit_id":"7309bcb8928339c79ee94a7fd9ec107dd8debb66"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"5fabf4e03ac1c70099cee82605ce9c0c0efd612e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return cleaned_data"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    class Meta:"},{"line_number":179,"context_line":"        name \u003d _(\"Specify VIP\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create a VIP for this pool. \""},{"line_number":182,"context_line":"                      \"Assign a name and description for the VIP. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FwWc%3D","line":179,"in_reply_to":"AAAAPX%2F%2FwY4%3D","updated":"2013-06-11 10:18:49.000000000","message":"Oh I see. Thank you. \n\nAs for workflow, I thought about it. May be we should file a separate bug or wish.","commit_id":"7309bcb8928339c79ee94a7fd9ec107dd8debb66"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"5fabf4e03ac1c70099cee82605ce9c0c0efd612e","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return cleaned_data"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    class Meta:"},{"line_number":179,"context_line":"        name \u003d _(\"Specify VIP\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create a VIP for this pool. \""},{"line_number":182,"context_line":"                      \"Assign a name and description for the VIP. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FwXM%3D","line":179,"in_reply_to":"AAAAPX%2F%2FwYg%3D","updated":"2013-06-11 10:18:49.000000000","message":"Okay, so I\u0027ll keep it.","commit_id":"7309bcb8928339c79ee94a7fd9ec107dd8debb66"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"45ae5c90a6f2801e68c8d1388e40283ff4ef7897","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return cleaned_data"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    class Meta:"},{"line_number":179,"context_line":"        name \u003d _(\"Specify VIP\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create a VIP for this pool. \""},{"line_number":182,"context_line":"                      \"Assign a name and description for the VIP. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FwY4%3D","line":179,"in_reply_to":"AAAAPX%2F%2FwbI%3D","updated":"2013-06-11 10:04:11.000000000","message":"When I open \"Add VIP\" link in the pool table, I see \"Specify VIP\". This is the reason I commented.\n\nHonestly to say, workflow is not needed for these operations since they have only one tab per operation.... but it is not an issue discussed here.","commit_id":"7309bcb8928339c79ee94a7fd9ec107dd8debb66"},{"author":{"_account_id":6914,"name":"Tatiana Ovchinnikova","email":"t.v.ovtchinnikova@gmail.com","username":"tmazur"},"change_message_id":"d09f5a5a158115de6c27ad9edc2d87da79cafa8f","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        return cleaned_data"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"    class Meta:"},{"line_number":179,"context_line":"        name \u003d _(\"Specify VIP\")"},{"line_number":180,"context_line":"        permissions \u003d (\u0027openstack.services.network\u0027,)"},{"line_number":181,"context_line":"        help_text \u003d _(\"Create a VIP for this pool. \""},{"line_number":182,"context_line":"                      \"Assign a name and description for the VIP. \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPX%2F%2FwbI%3D","line":179,"in_reply_to":"AAAAPX%2F%2FwhE%3D","updated":"2013-06-11 09:42:53.000000000","message":"That\u0027s from the old workflow template, as it was before refactoring. There\u0027s no tab for VIPs as there are for pools, monitors and members, so I think consistency is not so necessary. But if you think that we should change title to \"Add New VIP\", I\u0027ll change.","commit_id":"7309bcb8928339c79ee94a7fd9ec107dd8debb66"}]}