)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"4cf61abaad18ab4d7a98663eaca6eddb8fd280b1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sergei Chipiga \u003cschipiga@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-06-01 17:34:19 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Miss exception handlers if test was skipped."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If9f031d010d293db57482f902f28ca29110cacac"},{"line_number":10,"context_line":"Closes-Bug: #1587922"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9abb7d3a_f20f8f34","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2016-06-01 15:12:55.000000000","message":"\u0027Do not run\u0027 would be a more proper wording here ;).","commit_id":"e3ff8d40ba7081140899ab877d7e1b0779e433c0"}],"openstack_dashboard/test/integration_tests/helpers.py":[{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"304b245a84bec898b87f847c65f8d8034c68a604","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    def addOnException(self, exception_handler):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        def wrapped_handler(exc_info):"},{"line_number":142,"context_line":"            if exc_info[0].__name__ \u003d\u003d \u0027SkipTest\u0027:"},{"line_number":143,"context_line":"                return"},{"line_number":144,"context_line":"            return exception_handler(exc_info)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_b780fa47","line":142,"updated":"2016-06-02 23:34:36.000000000","message":"Why are we comparing the *name* here? Why isn\u0027t this \"isinstance(exc_info[0], SkipTest)\"?","commit_id":"9d3ec698f1f10aff265d61bdbc3d93092785d80b"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"93a2110892e682f5841d6e8c4813a9b5b36f9f2a","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    def addOnException(self, exception_handler):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        def wrapped_handler(exc_info):"},{"line_number":142,"context_line":"            if exc_info[0].__name__ \u003d\u003d \u0027SkipTest\u0027:"},{"line_number":143,"context_line":"                return"},{"line_number":144,"context_line":"            return exception_handler(exc_info)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_ebe61615","line":142,"in_reply_to":"9abb7d3a_8b45ca18","updated":"2016-06-03 05:09:02.000000000","message":"I mean, not be used except one time in isinstance","commit_id":"9d3ec698f1f10aff265d61bdbc3d93092785d80b"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"c6f3c3c7f084d638ab525ac85fabf0f76b5e9619","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    def addOnException(self, exception_handler):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        def wrapped_handler(exc_info):"},{"line_number":142,"context_line":"            if exc_info[0].__name__ \u003d\u003d \u0027SkipTest\u0027:"},{"line_number":143,"context_line":"                return"},{"line_number":144,"context_line":"            return exception_handler(exc_info)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_8b45ca18","line":142,"in_reply_to":"9abb7d3a_b780fa47","updated":"2016-06-03 05:06:14.000000000","message":"to avoid import of class, which will not be used","commit_id":"9d3ec698f1f10aff265d61bdbc3d93092785d80b"},{"author":{"_account_id":20772,"name":"Sergei Chipiga","email":"schipiga@mirantis.com","username":"schipiga"},"change_message_id":"5f2bb00c1aa7085f50897c3ff6940071bda9776f","unresolved":false,"context_lines":[{"line_number":139,"context_line":"    def addOnException(self, exception_handler):"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        def wrapped_handler(exc_info):"},{"line_number":142,"context_line":"            if exc_info[0].__name__ \u003d\u003d \u0027SkipTest\u0027:"},{"line_number":143,"context_line":"                return"},{"line_number":144,"context_line":"            return exception_handler(exc_info)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9abb7d3a_8ba30a4f","line":142,"in_reply_to":"9abb7d3a_ebe61615","updated":"2016-06-03 05:18:10.000000000","message":"And you variant will work, because exc_info[0] is not instance, it\u0027s class. But exc_info[0] \u003d\u003d SkipTest.\nAnd btw what is problem to compare class1.__name__ \u003d\u003d class2.__name__ instead class1 \u003d\u003d class2? I seem, no difference","commit_id":"9d3ec698f1f10aff265d61bdbc3d93092785d80b"}]}
