)]}'
{"horizon/utils/secret_key.py":[{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"d0e585207861ca301955b805ec8ae025ff4e206b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    if hasattr(random, \u0027SystemRandom\u0027):"},{"line_number":39,"context_line":"        choice \u003d random.SystemRandom().choice"},{"line_number":40,"context_line":"    else:"},{"line_number":41,"context_line":"        msg \u003d _(\"SystemRandom not present. Using insecure random.choice.\")"},{"line_number":42,"context_line":"        LOG.warning(msg)"},{"line_number":43,"context_line":"        choice \u003d random.choice"},{"line_number":44,"context_line":"    return \u0027\u0027.join(map(lambda x: choice(string.digits + string.ascii_letters),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_1363c71b","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":73},"updated":"2016-06-03 09:00:24.000000000","message":"Probably want to expand this a little, as we can\u0027t guarantee there will be anything surrounding this log message that would make it immediately obvious what it was referring to. So, something like \"SystemRandom not present. Using insecure random.choice to generate keys\" would point people in the write direction.","commit_id":"76fc083491e31022a4da4cc422521d3035afe04e"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"84aa61cece5ec20dfbf50bb0248e70ccc8309f02","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    if hasattr(random, \u0027SystemRandom\u0027):"},{"line_number":39,"context_line":"        choice \u003d random.SystemRandom().choice"},{"line_number":40,"context_line":"    else:"},{"line_number":41,"context_line":"        msg \u003d _(\"SystemRandom not present. Using insecure random.choice.\")"},{"line_number":42,"context_line":"        LOG.warning(msg)"},{"line_number":43,"context_line":"        choice \u003d random.choice"},{"line_number":44,"context_line":"    return \u0027\u0027.join(map(lambda x: choice(string.digits + string.ascii_letters),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9abb7d3a_6c46a050","line":41,"range":{"start_line":41,"start_character":16,"end_line":41,"end_character":73},"in_reply_to":"9abb7d3a_1363c71b","updated":"2016-06-03 14:17:58.000000000","message":"Sounds good...I\u0027ll concoct something a little more context-fulfilling.","commit_id":"76fc083491e31022a4da4cc422521d3035afe04e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"f0187687a3ef2a55065d3b387a32e6b900650a35","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    The quality of randomness depends on operating system support,"},{"line_number":32,"context_line":"    see http://docs.python.org/library/random.html#random.SystemRandom."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    if hasattr(random, \u0027SystemRandom\u0027):"},{"line_number":35,"context_line":"        print(\u0027Generating a secure random key using SystemRandom.\u0027)"},{"line_number":36,"context_line":"        choice \u003d random.SystemRandom().choice"},{"line_number":37,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_20ca521b","line":34,"updated":"2016-06-08 19:44:59.000000000","message":"Shouldn\u0027t this be using a logger instead of print?\n\ne.g. https://github.com/openstack/horizon/blob/master/horizon/utils/file_discovery.py#L111","commit_id":"951f72bdc41fa9b7b1399bfd4b29af3bbb442bc7"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"7ef8aa6cf26ce86c02f538b1df48c4a0bef36f87","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    The quality of randomness depends on operating system support,"},{"line_number":32,"context_line":"    see http://docs.python.org/library/random.html#random.SystemRandom."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":"    if hasattr(random, \u0027SystemRandom\u0027):"},{"line_number":35,"context_line":"        print(\u0027Generating a secure random key using SystemRandom.\u0027)"},{"line_number":36,"context_line":"        choice \u003d random.SystemRandom().choice"},{"line_number":37,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_8924110d","line":34,"in_reply_to":"7aa08908_20ca521b","updated":"2016-06-08 20:43:06.000000000","message":"Read back my previous notes on previous attempts.  I switched to print() because no logger for the name was available at the time of running this.","commit_id":"951f72bdc41fa9b7b1399bfd4b29af3bbb442bc7"}]}
