)]}'
{"horizon/static/horizon/js/horizon.tables.js":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"87823b31e14e5f734dfb614321bb98e951b31799","unresolved":false,"context_lines":[{"line_number":527,"context_line":""},{"line_number":528,"context_line":"horizon.datatables.set_table_server_filter \u003d function(parent) {"},{"line_number":529,"context_line":"  $(parent).find(\u0027table\u0027).each(function (index, ele) {"},{"line_number":530,"context_line":"    var input \u003d $($(ele).find(\u0027div.table_search.server input\u0027)),"},{"line_number":531,"context_line":"        select \u003d $($(ele).find(\u0027div.table_search.server select\u0027));"},{"line_number":532,"context_line":"    select.change(function() {"},{"line_number":533,"context_line":"      input.attr(\u0027placeholder\u0027, \"Filter by \" + $(this).val());"}],"source_content_type":"text/javascript","patch_set":7,"id":"1aa78d24_cc1c397a","line":530,"updated":"2016-07-03 15:06:28.000000000","message":"A couple of things.  I don\u0027t think that this is necessary at all.  The select already shows what you are going to be filtering on and now it is not possible for someone to customize the value of the placeholder downstream.\n\n1. There is no need to do multiple jQuery constructors, ever.  A find will already return a list of jQuery objects that can be chained on. \n\n2. jQuery objects chain, so there is no need to use an \u0027each\u0027 at all\n\n3. Use \u0027.on\u0027 with event delegation ON the document, so that new stuff rendered after this code runs works the same: http://api.jquery.com/on/\n\n4. \"Filter by\" needs to be translated\n\n5. Name jQuery variables with prepending \u0027$\u0027\n\nIt is better to write it like this (haven\u0027t tested this code):\n\nhorizon.datatables.set_table_server_filter \u003d function(parent) {\n  $(document).on(\u0027change\u0027, \u0027.table_search.search select\u0027, function() {\n    var $(this);\n    $this.sibling(\u0027input\u0027).attr(\u0027placeholder\u0027, \u0027Filter by \u0027 + $this.val();\n  });\n};","commit_id":"6be22c552dffeafb8633994eef49cacd3ecea24d"},{"author":{"_account_id":9155,"name":"Eddie Ramirez","email":"eddie.ramirez@intel.com","username":"ediardo"},"change_message_id":"093e04d961fbc3bd507f4273b1bb2c8b89e3609b","unresolved":false,"context_lines":[{"line_number":525,"context_line":"  });"},{"line_number":526,"context_line":"};"},{"line_number":527,"context_line":""},{"line_number":528,"context_line":"horizon.datatables.set_table_server_filter \u003d function(parent) {"},{"line_number":529,"context_line":"  $(parent).find(\u0027table\u0027).each(function (index, ele) {"},{"line_number":530,"context_line":"    var input \u003d $($(ele).find(\u0027div.table_search.server input\u0027)),"},{"line_number":531,"context_line":"        select \u003d $($(ele).find(\u0027div.table_search.server select\u0027));"},{"line_number":532,"context_line":"    select.change(function() {"},{"line_number":533,"context_line":"      input.attr(\u0027placeholder\u0027, \"Filter by \" + $(this).val());"},{"line_number":534,"context_line":"    });"},{"line_number":535,"context_line":"  });"},{"line_number":536,"context_line":"};"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"horizon.datatables.set_table_query_filter \u003d function (parent) {"},{"line_number":539,"context_line":"  horizon.datatables.qs \u003d {};"}],"source_content_type":"text/javascript","patch_set":7,"id":"7aa08908_589a6bc6","line":536,"range":{"start_line":528,"start_character":0,"end_line":536,"end_character":2},"updated":"2016-06-30 21:31:07.000000000","message":"This code need not to be present in this patch. It\u0027s an UX enhacement","commit_id":"6be22c552dffeafb8633994eef49cacd3ecea24d"}],"horizon/tables/actions.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"9d7b6e40556f0f7403c027b8cab81742df97503a","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        \"\"\""},{"line_number":519,"context_line":"        if self.filter_type \u003d\u003d \u0027server\u0027:"},{"line_number":520,"context_line":"            for choice in self.filter_choices:"},{"line_number":521,"context_line":"                if (choice[0] \u003d\u003d filter_field and choice[2] is True):"},{"line_number":522,"context_line":"                    return True"},{"line_number":523,"context_line":"        return False"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_7b7dabe6","line":521,"updated":"2016-07-05 13:40:11.000000000","message":"This change doesn\u0027t seem to be related. It will result in an IndexError if any of the filter_choices is shorter than 3 elements -- did you verify that no code uses less than 3 elements anywhere?","commit_id":"6be22c552dffeafb8633994eef49cacd3ecea24d"}],"horizon/templates/horizon/common/_data_table_table_actions.html":[{"author":{"_account_id":11778,"name":"Diana Whitten","email":"hurgleburgler@gmail.com","username":"hurgleburgler"},"change_message_id":"87823b31e14e5f734dfb614321bb98e951b31799","unresolved":false,"context_lines":[{"line_number":23,"context_line":"      \u003c/div\u003e"},{"line_number":24,"context_line":"    \u003c/div\u003e"},{"line_number":25,"context_line":"  {% elif filter.filter_type \u003d\u003d \u0027server\u0027 %}"},{"line_number":26,"context_line":"    \u003cdiv class\u003d\"table_search server\"\u003e"},{"line_number":27,"context_line":"      {% with name\u003dfilter.get_param_name|add:\u0027_field\u0027 options\u003dfilter.get_select_options stand_alone\u003d1 value\u003dfilter.filter_field %}"},{"line_number":28,"context_line":"        {% include \u0027horizon/common/fields/_themable_select.html\u0027 %}"},{"line_number":29,"context_line":"      {% endwith %}"}],"source_content_type":"text/html","patch_set":7,"id":"1aa78d24_ac81ed91","line":26,"updated":"2016-07-03 15:06:28.000000000","message":"this is extremely vague and I can see the possibility of collisions in the future.  I know it may seem extremely verbose, but can we call this: class\u003d\"table_search table_search-server\" instead?\n\nWe should probably update the \u0027client\u0027 above to also be a little more verbose.","commit_id":"6be22c552dffeafb8633994eef49cacd3ecea24d"}],"openstack_dashboard/api/keystone.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"ecb5d6bcc3778f7bf793837ad129ae19d3951f34","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            try:"},{"line_number":347,"context_line":"                tenants \u003d [tenant_get(request, kwargs[\u0027id\u0027])]"},{"line_number":348,"context_line":"            except Exception:"},{"line_number":349,"context_line":"                pass"},{"line_number":350,"context_line":"        else:"},{"line_number":351,"context_line":"            tenants \u003d manager.list(**kwargs)"},{"line_number":352,"context_line":"    return tenants, has_more_data"}],"source_content_type":"text/x-python","patch_set":13,"id":"1ac06dbe_82c84f76","line":349,"updated":"2016-08-19 12:45:24.000000000","message":"Do we want to handle the exception here, so that if it\u0027s a 401 we can re-login, and so that the user gets a message on failure?","commit_id":"f61a6a8775ee953f49cb7ff5a9b70e3b158ece47"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"e0a9a9881381ec0a3cb7e1e160b8b6e1ae533868","unresolved":false,"context_lines":[{"line_number":345,"context_line":"            try:"},{"line_number":346,"context_line":"                tenants \u003d [tenant_get(request, kwargs[\u0027id\u0027])]"},{"line_number":347,"context_line":"            except keystone_exceptions.NotFound:"},{"line_number":348,"context_line":"                raise exceptions.NotFound()"},{"line_number":349,"context_line":"        else:"},{"line_number":350,"context_line":"            tenants \u003d manager.list(**kwargs)"},{"line_number":351,"context_line":"    return tenants, has_more_data"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a89bdaa_86529965","line":348,"updated":"2016-09-13 12:02:06.000000000","message":"What we should really do here, IMO, is catch the NotFound exception and ignore it. We don\u0027t really want to be throwing an error for nothing being found, because a big red error message to a user implies something has gone wrong. Then we should just do usual catchall and pass it to exceptions.handle, which will handle things like 401. Does that make sense?","commit_id":"0237cf10835fcaca071fd18cdf04b0982919e799"},{"author":{"_account_id":12826,"name":"Rob Cresswell","display_name":"robcresswell","email":"robert.cresswell@outlook.com","username":"rob-cresswell"},"change_message_id":"e0a9a9881381ec0a3cb7e1e160b8b6e1ae533868","unresolved":false,"context_lines":[{"line_number":656,"context_line":"        try:"},{"line_number":657,"context_line":"            roles \u003d [manager.get(kwargs[\u0027id\u0027])]"},{"line_number":658,"context_line":"        except keystone_exceptions.NotFound:"},{"line_number":659,"context_line":"            raise exceptions.NotFound()"},{"line_number":660,"context_line":"    else:"},{"line_number":661,"context_line":"        roles \u003d manager.list(**kwargs)"},{"line_number":662,"context_line":"    return roles"}],"source_content_type":"text/x-python","patch_set":15,"id":"9a89bdaa_c64821b6","line":659,"updated":"2016-09-13 12:02:06.000000000","message":"ditto","commit_id":"0237cf10835fcaca071fd18cdf04b0982919e799"},{"author":{"_account_id":6650,"name":"Eric Peterson","email":"ejpetey@gmail.com","username":"ericpeterson-l"},"change_message_id":"daf36dfe4e5a31c851456e66b8414f06a637ec4f","unresolved":false,"context_lines":[{"line_number":309,"context_line":"def tenant_delete(request, project):"},{"line_number":310,"context_line":"    manager \u003d VERSIONS.get_project_manager(request, admin\u003dTrue)"},{"line_number":311,"context_line":"    return manager.delete(project)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"def tenant_list(request, paginate\u003dFalse, marker\u003dNone, domain\u003dNone, user\u003dNone,"},{"line_number":315,"context_line":"                admin\u003dTrue, filters\u003dNone):"}],"source_content_type":"text/x-python","patch_set":16,"id":"9a89bdaa_f50e9339","line":312,"updated":"2016-09-14 14:29:23.000000000","message":"this file seems like reasonable changes, could even be broken into another / separate patch","commit_id":"bc1fb4910b1d500ee9e5a2d9045d8238073373f7"}],"openstack_dashboard/dashboards/identity/groups/tables.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f2a1ab82d580946d95c7e13ded96060fcc9dfbcf","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"class GroupFilterAction(tables.FilterAction):"},{"line_number":103,"context_line":"    filter_type \u003d \"server\""},{"line_number":104,"context_line":"    filter_choices \u003d ((\"name\", _(\"Group Name\"), True),"},{"line_number":105,"context_line":"                      (\"id\", _(\"Group ID\"), True))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a9d85d2_c57d35e9","line":104,"updated":"2016-06-20 03:12:33.000000000","message":"\"Group Name \u003d\"","commit_id":"6be22c552dffeafb8633994eef49cacd3ecea24d"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f2a1ab82d580946d95c7e13ded96060fcc9dfbcf","unresolved":false,"context_lines":[{"line_number":102,"context_line":"class GroupFilterAction(tables.FilterAction):"},{"line_number":103,"context_line":"    filter_type \u003d \"server\""},{"line_number":104,"context_line":"    filter_choices \u003d ((\"name\", _(\"Group Name\"), True),"},{"line_number":105,"context_line":"                      (\"id\", _(\"Group ID\"), True))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class GroupsTable(tables.DataTable):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a9d85d2_258359ce","line":105,"updated":"2016-06-20 03:12:33.000000000","message":"\"Group ID \u003d\"\n\nOther places like Project are also same as above. These should be addressed.","commit_id":"6be22c552dffeafb8633994eef49cacd3ecea24d"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"9c3c57f2338c0e568407f92bc47e24343d65241f","unresolved":false,"context_lines":[{"line_number":101,"context_line":""},{"line_number":102,"context_line":"class GroupFilterAction(tables.FilterAction):"},{"line_number":103,"context_line":"    filter_type \u003d \"server\""},{"line_number":104,"context_line":"    filter_choices \u003d ((\"name\", _(\"Group Name\"), True),"},{"line_number":105,"context_line":"                      (\"id\", _(\"Group ID\"), True))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"dada55a8_8415409d","line":104,"updated":"2016-07-21 07:59:25.000000000","message":"_(\"Group Name\") -\u003e _(\"Group Name \u003d\")","commit_id":"970848cb68fa170c7da77daa21b3173847c40f27"}],"openstack_dashboard/dashboards/identity/groups/views.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"9d7b6e40556f0f7403c027b8cab81742df97503a","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                        elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":75,"context_line":"                            filter_string \u003d False"},{"line_number":76,"context_line":"                    filters[filter_field] \u003d filter_string"},{"line_number":77,"context_line":"        return filters"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"class CreateView(forms.ModalFormView):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_5bca6f6e","line":77,"updated":"2016-07-05 13:40:11.000000000","message":"This","commit_id":"6be22c552dffeafb8633994eef49cacd3ecea24d"}],"openstack_dashboard/dashboards/identity/projects/views.py":[{"author":{"_account_id":8648,"name":"Radomir Dopieralski","email":"openstack@dopieralski.pl","username":"thesheep"},"change_message_id":"9d7b6e40556f0f7403c027b8cab81742df97503a","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                        elif _(\"no\") \u003d\u003d filter_string.lower():"},{"line_number":146,"context_line":"                            filter_string \u003d False"},{"line_number":147,"context_line":"                    filters[filter_field] \u003d filter_string"},{"line_number":148,"context_line":"        return filters"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"class ProjectUsageView(usage.UsageView):"}],"source_content_type":"text/x-python","patch_set":7,"id":"1aa78d24_3b9cc368","line":148,"updated":"2016-07-05 13:40:11.000000000","message":"This code snippet repeats at least 4 times, do you think you could maybe put it in one place somewhere?","commit_id":"6be22c552dffeafb8633994eef49cacd3ecea24d"}]}
