)]}'
{"horizon/static/framework/conf/resource-type-registry.service.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"360371710c5e785ed7087dc13382fe2f15e54ce4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   *"},{"line_number":67,"context_line":"   * initActions(type, scope) -- run from a controller that will be using"},{"line_number":68,"context_line":"   *   a ResourceType to invoke actions\u0027 initScope (where defined)."},{"line_number":69,"context_line":"   *   TODO why is this not a method ResourceType??"},{"line_number":70,"context_line":"   *"},{"line_number":71,"context_line":"   * getGlobalActions()   -- retrieves all global actions"},{"line_number":72,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":2,"id":"9abb7d3a_95eeb2b2","line":69,"range":{"start_line":69,"start_character":7,"end_line":69,"end_character":51},"updated":"2016-06-02 13:35:39.000000000","message":"That is a good point, this could lie off of the ResourceType; I think the original reason was that we were cycling through types which may or may not have had resourceTypes registered, but that use case seems bunk now.  Agreed.","commit_id":"6e31a93011ca878c321a122d1cebe27c759a23cd"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"1638c02543049da40e42733b430becc82e13a848","unresolved":false,"context_lines":[{"line_number":66,"context_line":"   *"},{"line_number":67,"context_line":"   * initActions(type, scope) -- run from a controller that will be using"},{"line_number":68,"context_line":"   *   a ResourceType to invoke actions\u0027 initScope (where defined)."},{"line_number":69,"context_line":"   *   TODO why is this not a method ResourceType??"},{"line_number":70,"context_line":"   *"},{"line_number":71,"context_line":"   * getGlobalActions()   -- retrieves all global actions"},{"line_number":72,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":2,"id":"9abb7d3a_abe6cee5","line":69,"in_reply_to":"9abb7d3a_95eeb2b2","updated":"2016-06-03 06:33:30.000000000","message":"OK, i will propose to move that in this patch - there\u0027s only two uses of initActions currently in the codebase.","commit_id":"6e31a93011ca878c321a122d1cebe27c759a23cd"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"360371710c5e785ed7087dc13382fe2f15e54ce4","unresolved":false,"context_lines":[{"line_number":75,"context_line":"   *"},{"line_number":76,"context_line":"   * setDefaultSummaryTemplateUrl, getDefaultSummaryTemplateUrl,"},{"line_number":77,"context_line":"   *     setDefaultDetailsTemplateUrl, getDefaultDetailsTemplateUrl"},{"line_number":78,"context_line":"   *     TODO these are not actually used anywhere, no idea why they exist?!"},{"line_number":79,"context_line":"   *"},{"line_number":80,"context_line":"   */"},{"line_number":81,"context_line":"  function registryService(extensibleService) {"}],"source_content_type":"text/javascript","patch_set":2,"id":"9abb7d3a_b51f76b6","line":78,"updated":"2016-06-02 13:35:39.000000000","message":"They \u0027should\u0027 probably be established, they are used in Searchlight but I\u0027d like consensus on what to do before implementing in Horizon.  I\u0027m fine creating a patch that registers a default summary template.","commit_id":"6e31a93011ca878c321a122d1cebe27c759a23cd"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"1638c02543049da40e42733b430becc82e13a848","unresolved":false,"context_lines":[{"line_number":75,"context_line":"   *"},{"line_number":76,"context_line":"   * setDefaultSummaryTemplateUrl, getDefaultSummaryTemplateUrl,"},{"line_number":77,"context_line":"   *     setDefaultDetailsTemplateUrl, getDefaultDetailsTemplateUrl"},{"line_number":78,"context_line":"   *     TODO these are not actually used anywhere, no idea why they exist?!"},{"line_number":79,"context_line":"   *"},{"line_number":80,"context_line":"   */"},{"line_number":81,"context_line":"  function registryService(extensibleService) {"}],"source_content_type":"text/javascript","patch_set":2,"id":"9abb7d3a_e7048ac7","line":78,"in_reply_to":"9abb7d3a_b51f76b6","updated":"2016-06-03 06:33:30.000000000","message":"Hmm.","commit_id":"6e31a93011ca878c321a122d1cebe27c759a23cd"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"360371710c5e785ed7087dc13382fe2f15e54ce4","unresolved":false,"context_lines":[{"line_number":185,"context_line":"      extensibleService(this.tableColumns, this.tableColumns);"},{"line_number":186,"context_line":"      this.getTableColumns \u003d getTableColumns;"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"      // TODO: the following is not used??"},{"line_number":189,"context_line":"      // These members support summary templates which are views that are meant"},{"line_number":190,"context_line":"      // to exist in a confined area, such as a drawer in a table row."},{"line_number":191,"context_line":"      this.summaryTemplateUrl \u003d false;"}],"source_content_type":"text/javascript","patch_set":2,"id":"9abb7d3a_d5631a40","line":188,"range":{"start_line":188,"start_character":15,"end_line":188,"end_character":41},"updated":"2016-06-02 13:35:39.000000000","message":"see above note about default summary view.","commit_id":"6e31a93011ca878c321a122d1cebe27c759a23cd"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"360371710c5e785ed7087dc13382fe2f15e54ce4","unresolved":false,"context_lines":[{"line_number":195,"context_line":"      // type, with the data as a result in a promise.  For example, Images code"},{"line_number":196,"context_line":"      // would register a list function that returns a promise that will resolve"},{"line_number":197,"context_line":"      // to all the Images data in list form."},{"line_number":198,"context_line":"      // TODO where is list()?!"},{"line_number":199,"context_line":"      this.listFunction \u003d angular.noop;"},{"line_number":200,"context_line":"      this.setListFunction \u003d setListFunction;"},{"line_number":201,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"9abb7d3a_b5c77663","line":198,"updated":"2016-06-02 13:35:39.000000000","message":"There is no list; this is registering a list-fetching function.  This provides the list-fetching function so pages like \u0027tables\u0027 pages can fetch lists.  The resource-type object thus doesn\u0027t contain any lists.","commit_id":"6e31a93011ca878c321a122d1cebe27c759a23cd"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"1638c02543049da40e42733b430becc82e13a848","unresolved":false,"context_lines":[{"line_number":195,"context_line":"      // type, with the data as a result in a promise.  For example, Images code"},{"line_number":196,"context_line":"      // would register a list function that returns a promise that will resolve"},{"line_number":197,"context_line":"      // to all the Images data in list form."},{"line_number":198,"context_line":"      // TODO where is list()?!"},{"line_number":199,"context_line":"      this.listFunction \u003d angular.noop;"},{"line_number":200,"context_line":"      this.setListFunction \u003d setListFunction;"},{"line_number":201,"context_line":""}],"source_content_type":"text/javascript","patch_set":2,"id":"9abb7d3a_ebda96e8","line":198,"in_reply_to":"9abb7d3a_b5c77663","updated":"2016-06-03 06:33:30.000000000","message":"Ahh, it\u0027s used in the generic table patch, roger. So the API is to invoke listFunction directly? So let\u0027s just call it list(), I reckon :-)","commit_id":"6e31a93011ca878c321a122d1cebe27c759a23cd"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"b34e90d7ba74025cda8ecf1a6f546ac4ce25fc7f","unresolved":false,"context_lines":[{"line_number":212,"context_line":"       * Performs initialization (namely, scope-setting) of all actions"},{"line_number":213,"context_line":"       * for the given type.  This requires the proper scope be passed."},{"line_number":214,"context_line":"       * If an action does not have an initScope() function, it is ignored."},{"line_number":215,"context_line":"       */"},{"line_number":216,"context_line":"      function initActions(scope) {"},{"line_number":217,"context_line":"        angular.forEach(type.itemActions, setActionScope);"},{"line_number":218,"context_line":"        angular.forEach(type.batchActions, setActionScope);"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_b4e73a45","line":215,"updated":"2016-06-16 13:31:48.000000000","message":"This is great, I agree it makes a lot of sense to places this at the type level.","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"b34e90d7ba74025cda8ecf1a6f546ac4ce25fc7f","unresolved":false,"context_lines":[{"line_number":593,"context_line":"    // not needed."},{"line_number":594,"context_line":"    var registry \u003d {"},{"line_number":595,"context_line":"      resourceTypes: {},"},{"line_number":596,"context_line":"      slugs: {},"},{"line_number":597,"context_line":"      defaultSummaryTemplateUrl: false,"},{"line_number":598,"context_line":"      defaultDetailsTemplateUrl: false,"},{"line_number":599,"context_line":"      getResourceType: getResourceType,"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_f232750e","line":596,"range":{"start_line":596,"start_character":16,"end_line":596,"end_character":16},"updated":"2016-06-16 13:31:48.000000000","message":"Note: the slug features have gone away.","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"afb440a4136d31a1810e931d3842dc60c11fbdab","unresolved":false,"context_lines":[{"line_number":593,"context_line":"    // not needed."},{"line_number":594,"context_line":"    var registry \u003d {"},{"line_number":595,"context_line":"      resourceTypes: {},"},{"line_number":596,"context_line":"      slugs: {},"},{"line_number":597,"context_line":"      defaultSummaryTemplateUrl: false,"},{"line_number":598,"context_line":"      defaultDetailsTemplateUrl: false,"},{"line_number":599,"context_line":"      getResourceType: getResourceType,"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_1b8e20d0","line":596,"in_reply_to":"7aa08908_f232750e","updated":"2016-06-16 23:23:46.000000000","message":"Done","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"b34e90d7ba74025cda8ecf1a6f546ac4ce25fc7f","unresolved":false,"context_lines":[{"line_number":604,"context_line":"      getDefaultDetailsTemplateUrl: getDefaultDetailsTemplateUrl"},{"line_number":605,"context_line":"    };"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"    function getTypeNameBySlug(slug) {"},{"line_number":608,"context_line":"      return registry.slugs[slug];"},{"line_number":609,"context_line":"    }"},{"line_number":610,"context_line":""},{"line_number":611,"context_line":"    function setSlug(slug, typeName) {"},{"line_number":612,"context_line":"      registry.slugs[slug] \u003d typeName;"},{"line_number":613,"context_line":"      return registry;"},{"line_number":614,"context_line":"    }"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    function getDefaultSummaryTemplateUrl() {"},{"line_number":617,"context_line":"      return registry.defaultSummaryTemplateUrl;"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_72584558","line":614,"range":{"start_line":607,"start_character":0,"end_line":614,"end_character":5},"updated":"2016-06-16 13:31:48.000000000","message":"Note, the slug features have gone away.","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"afb440a4136d31a1810e931d3842dc60c11fbdab","unresolved":false,"context_lines":[{"line_number":611,"context_line":"    function setSlug(slug, typeName) {"},{"line_number":612,"context_line":"      registry.slugs[slug] \u003d typeName;"},{"line_number":613,"context_line":"      return registry;"},{"line_number":614,"context_line":"    }"},{"line_number":615,"context_line":""},{"line_number":616,"context_line":"    function getDefaultSummaryTemplateUrl() {"},{"line_number":617,"context_line":"      return registry.defaultSummaryTemplateUrl;"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_db83f8a7","line":614,"in_reply_to":"7aa08908_72584558","updated":"2016-06-16 23:23:46.000000000","message":"Done","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"b34e90d7ba74025cda8ecf1a6f546ac4ce25fc7f","unresolved":false,"context_lines":[{"line_number":666,"context_line":"     * @description"},{"line_number":667,"context_line":"     * Retrieves all information about a resource type.  If the resource"},{"line_number":668,"context_line":"     * type doesn\u0027t exist in the registry, this creates a new entry."},{"line_number":669,"context_line":"     *"},{"line_number":670,"context_line":"     * Optionally set some of the ResourceType properties at the same"},{"line_number":671,"context_line":"     * time (usually used to set names):"},{"line_number":672,"context_line":"     *"},{"line_number":673,"context_line":"     *   var resourceType \u003d registryService.getResourceType("},{"line_number":674,"context_line":"     *       \u0027OS::Glance::Image\u0027,"},{"line_number":675,"context_line":"     *       { names: [gettext(\u0027Image\u0027), gettext(\u0027Images\u0027)] }"},{"line_number":676,"context_line":"     *   );"},{"line_number":677,"context_line":"     *"},{"line_number":678,"context_line":"     */"},{"line_number":679,"context_line":"    function getResourceType(typeCode, presets) {"},{"line_number":680,"context_line":"      if (!registry.resourceTypes.hasOwnProperty(typeCode)) {"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_b4729aae","line":677,"range":{"start_line":669,"start_character":0,"end_line":677,"end_character":6},"updated":"2016-06-16 13:31:48.000000000","message":"This feature has gone away, it was really confusing as we now have methods to set everything.  There is a release note about its removal.","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"afb440a4136d31a1810e931d3842dc60c11fbdab","unresolved":false,"context_lines":[{"line_number":674,"context_line":"     *       \u0027OS::Glance::Image\u0027,"},{"line_number":675,"context_line":"     *       { names: [gettext(\u0027Image\u0027), gettext(\u0027Images\u0027)] }"},{"line_number":676,"context_line":"     *   );"},{"line_number":677,"context_line":"     *"},{"line_number":678,"context_line":"     */"},{"line_number":679,"context_line":"    function getResourceType(typeCode, presets) {"},{"line_number":680,"context_line":"      if (!registry.resourceTypes.hasOwnProperty(typeCode)) {"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_7bbbe475","line":677,"in_reply_to":"7aa08908_b4729aae","updated":"2016-06-16 23:23:46.000000000","message":"Done","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"b34e90d7ba74025cda8ecf1a6f546ac4ce25fc7f","unresolved":false,"context_lines":[{"line_number":681,"context_line":"        registry.resourceTypes[typeCode] \u003d new ResourceType(typeCode);"},{"line_number":682,"context_line":"      }"},{"line_number":683,"context_line":"      var type \u003d registry.resourceTypes[typeCode];"},{"line_number":684,"context_line":"      if (angular.isDefined(presets)) {"},{"line_number":685,"context_line":"        angular.extend(type, presets);"},{"line_number":686,"context_line":"      }"},{"line_number":687,"context_line":"      return type;"},{"line_number":688,"context_line":"    }"},{"line_number":689,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_f46c22d2","line":686,"range":{"start_line":684,"start_character":0,"end_line":686,"end_character":7},"updated":"2016-06-16 13:31:48.000000000","message":"This logic is now gone.","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"afb440a4136d31a1810e931d3842dc60c11fbdab","unresolved":false,"context_lines":[{"line_number":683,"context_line":"      var type \u003d registry.resourceTypes[typeCode];"},{"line_number":684,"context_line":"      if (angular.isDefined(presets)) {"},{"line_number":685,"context_line":"        angular.extend(type, presets);"},{"line_number":686,"context_line":"      }"},{"line_number":687,"context_line":"      return type;"},{"line_number":688,"context_line":"    }"},{"line_number":689,"context_line":""}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_fb8874c8","line":686,"in_reply_to":"7aa08908_f46c22d2","updated":"2016-06-16 23:23:46.000000000","message":"Done","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * @description"},{"line_number":33,"context_line":"   *"},{"line_number":34,"context_line":"   * The type registry collects up implementations of user interface components for"},{"line_number":35,"context_line":"   * angular panels in Horizon. These are tied to types using the HEAT type names, for"},{"line_number":36,"context_line":"   * example, \u0027OS::Glance::Image\u0027, so types encapsulate a single object retreieved from"},{"line_number":37,"context_line":"   * a service API. Other types might include Nova servers or Swift objects."},{"line_number":38,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_c7592bff","line":35,"range":{"start_line":35,"start_character":5,"end_line":35,"end_character":19},"updated":"2016-06-17 18:47:02.000000000","message":"nit: The registry is not dependent upon panels, or angular.  Consider instead:\n\n...collects per-resource views and actions that can be used in the client-side user interface.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * @description"},{"line_number":33,"context_line":"   *"},{"line_number":34,"context_line":"   * The type registry collects up implementations of user interface components for"},{"line_number":35,"context_line":"   * angular panels in Horizon. These are tied to types using the HEAT type names, for"},{"line_number":36,"context_line":"   * example, \u0027OS::Glance::Image\u0027, so types encapsulate a single object retreieved from"},{"line_number":37,"context_line":"   * a service API. Other types might include Nova servers or Swift objects."},{"line_number":38,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_27210f4e","line":35,"range":{"start_line":35,"start_character":66,"end_line":35,"end_character":81},"updated":"2016-06-17 18:47:02.000000000","message":"nit: consider linking to http://docs.openstack.org/developer/heat/template_guide/openstack.html","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * @description"},{"line_number":33,"context_line":"   *"},{"line_number":34,"context_line":"   * The type registry collects up implementations of user interface components for"},{"line_number":35,"context_line":"   * angular panels in Horizon. These are tied to types using the HEAT type names, for"},{"line_number":36,"context_line":"   * example, \u0027OS::Glance::Image\u0027, so types encapsulate a single object retreieved from"},{"line_number":37,"context_line":"   * a service API. Other types might include Nova servers or Swift objects."},{"line_number":38,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_858ded7d","line":35,"in_reply_to":"7aa08908_27210f4e","updated":"2016-06-20 03:49:54.000000000","message":"Done","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * @description"},{"line_number":33,"context_line":"   *"},{"line_number":34,"context_line":"   * The type registry collects up implementations of user interface components for"},{"line_number":35,"context_line":"   * angular panels in Horizon. These are tied to types using the HEAT type names, for"},{"line_number":36,"context_line":"   * example, \u0027OS::Glance::Image\u0027, so types encapsulate a single object retreieved from"},{"line_number":37,"context_line":"   * a service API. Other types might include Nova servers or Swift objects."},{"line_number":38,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_65dd6170","line":35,"in_reply_to":"7aa08908_c7592bff","updated":"2016-06-20 03:49:54.000000000","message":"Done, with slightly different words. One of my goals with this edit was to make the docs more concrete, so I\u0027ve kept the angular panels reference, but only as a \"for example\".","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   *   var resourceType \u003d registryService.getResourceType("},{"line_number":47,"context_line":"   *       \u0027OS::Glance::Image\u0027,"},{"line_number":48,"context_line":"   *       { names: [gettext(\u0027Image\u0027), gettext(\u0027Images\u0027)] }"},{"line_number":49,"context_line":"   *   );"},{"line_number":50,"context_line":"   *"},{"line_number":51,"context_line":"   * Types may have a number of aspects associated with them:"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_c7b5abed","line":48,"range":{"start_line":48,"start_character":11,"end_line":48,"end_character":59},"updated":"2016-06-17 18:47:02.000000000","message":"I don\u0027t think this method is encouraged. Use setNames instead.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   *   var resourceType \u003d registryService.getResourceType("},{"line_number":47,"context_line":"   *       \u0027OS::Glance::Image\u0027,"},{"line_number":48,"context_line":"   *       { names: [gettext(\u0027Image\u0027), gettext(\u0027Images\u0027)] }"},{"line_number":49,"context_line":"   *   );"},{"line_number":50,"context_line":"   *"},{"line_number":51,"context_line":"   * Types may have a number of aspects associated with them:"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_85e4cd3b","line":48,"in_reply_to":"7aa08908_c7b5abed","updated":"2016-06-20 03:49:54.000000000","message":"Yep, thanks!","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"   *"},{"line_number":51,"context_line":"   * Types may have a number of aspects associated with them:"},{"line_number":52,"context_line":"   *"},{"line_number":53,"context_line":"   * - a simplified name for the type (singular and plural)"},{"line_number":54,"context_line":"   * - a mechanism for retrieving objects of the type by id and listing objects"},{"line_number":55,"context_line":"   * - actions that may be performed on individual or batches of objects and"},{"line_number":56,"context_line":"   *   globally (independent of any objects existing)"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_4799bb78","line":53,"range":{"start_line":53,"start_character":38,"end_line":53,"end_character":59},"updated":"2016-06-17 18:47:02.000000000","message":"russian has 3 pluralities...","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":50,"context_line":"   *"},{"line_number":51,"context_line":"   * Types may have a number of aspects associated with them:"},{"line_number":52,"context_line":"   *"},{"line_number":53,"context_line":"   * - a simplified name for the type (singular and plural)"},{"line_number":54,"context_line":"   * - a mechanism for retrieving objects of the type by id and listing objects"},{"line_number":55,"context_line":"   * - actions that may be performed on individual or batches of objects and"},{"line_number":56,"context_line":"   *   globally (independent of any objects existing)"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_055d7de9","line":53,"in_reply_to":"7aa08908_4799bb78","updated":"2016-06-20 03:49:54.000000000","message":"I think I\u0027m missing something here. There\u0027 still only a singular and plural form specified...","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   * Types may have a number of aspects associated with them:"},{"line_number":52,"context_line":"   *"},{"line_number":53,"context_line":"   * - a simplified name for the type (singular and plural)"},{"line_number":54,"context_line":"   * - a mechanism for retrieving objects of the type by id and listing objects"},{"line_number":55,"context_line":"   * - actions that may be performed on individual or batches of objects and"},{"line_number":56,"context_line":"   *   globally (independent of any objects existing)"},{"line_number":57,"context_line":"   * - details view(s) for individual objects (may tabbed multiple views)"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_47a7fba6","line":54,"range":{"start_line":54,"start_character":5,"end_line":54,"end_character":79},"updated":"2016-06-17 18:47:02.000000000","message":"nit: consider instead\n-  listFunction - load all items of a given type\n- loadFunction - load 1 item of a given type","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"   * Types may have a number of aspects associated with them:"},{"line_number":52,"context_line":"   *"},{"line_number":53,"context_line":"   * - a simplified name for the type (singular and plural)"},{"line_number":54,"context_line":"   * - a mechanism for retrieving objects of the type by id and listing objects"},{"line_number":55,"context_line":"   * - actions that may be performed on individual or batches of objects and"},{"line_number":56,"context_line":"   *   globally (independent of any objects existing)"},{"line_number":57,"context_line":"   * - details view(s) for individual objects (may tabbed multiple views)"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_85004dac","line":54,"in_reply_to":"7aa08908_47a7fba6","updated":"2016-06-20 03:49:54.000000000","message":"I feel like this starts bordering on duplicating the API docs for ResourceType.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"   * Types should be defined at the Angular module level, using the .run() function."},{"line_number":63,"context_line":"   * This allows actions to be configured (and extended) by any module."},{"line_number":64,"context_line":"   *"},{"line_number":65,"context_line":"   * Apart from getResourceType, there are a number of other methods on the"},{"line_number":66,"context_line":"   * service:"},{"line_number":67,"context_line":"   *"},{"line_number":68,"context_line":"   * getGlobalActions()   -- retrieves all global actions"},{"line_number":69,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_8730c357","line":66,"range":{"start_line":65,"start_character":5,"end_line":66,"end_character":13},"updated":"2016-06-17 18:47:02.000000000","message":"nit: There are many other methods too...this block is probably redundant with the code below","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"   * This allows actions to be configured (and extended) by any module."},{"line_number":64,"context_line":"   *"},{"line_number":65,"context_line":"   * Apart from getResourceType, there are a number of other methods on the"},{"line_number":66,"context_line":"   * service:"},{"line_number":67,"context_line":"   *"},{"line_number":68,"context_line":"   * getGlobalActions()   -- retrieves all global actions"},{"line_number":69,"context_line":"   *"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_451dc50e","line":66,"in_reply_to":"7aa08908_8730c357","updated":"2016-06-20 03:49:54.000000000","message":"Done","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"       *"},{"line_number":89,"context_line":"       * An overview of the ResourceType API:"},{"line_number":90,"context_line":"       *"},{"line_number":91,"context_line":"       * initActions(type, scope) -- run from a controller that will be using"},{"line_number":92,"context_line":"       *   a ResourceType to invoke actions\u0027 initScope (where defined)."},{"line_number":93,"context_line":"       *"},{"line_number":94,"context_line":"       * getName(count) -- returns a generic human-readable name for the type, handling"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_47f6db5d","line":91,"updated":"2016-06-17 18:47:02.000000000","message":"nit: this block has some great detail, but will fall out of date as changes are made to methods. Consider instead moving each section to the specific method.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":88,"context_line":"       *"},{"line_number":89,"context_line":"       * An overview of the ResourceType API:"},{"line_number":90,"context_line":"       *"},{"line_number":91,"context_line":"       * initActions(type, scope) -- run from a controller that will be using"},{"line_number":92,"context_line":"       *   a ResourceType to invoke actions\u0027 initScope (where defined)."},{"line_number":93,"context_line":"       *"},{"line_number":94,"context_line":"       * getName(count) -- returns a generic human-readable name for the type, handling"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_85c5ed5c","line":91,"in_reply_to":"7aa08908_47f6db5d","updated":"2016-06-20 03:49:54.000000000","message":"Done","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"       *"},{"line_number":114,"context_line":"       * Additionally there are several extensible array properties:"},{"line_number":115,"context_line":"       *"},{"line_number":116,"context_line":"       * itemActions -- allowed \"row\" type actions for an \u003cactions\u003e directive"},{"line_number":117,"context_line":"       *"},{"line_number":118,"context_line":"       * batchActions -- allowed \"batch\" type actions for an \u003cactions\u003e directive"},{"line_number":119,"context_line":"       *"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_270d8f3e","line":116,"range":{"start_line":116,"start_character":59,"end_line":116,"end_character":66},"updated":"2016-06-17 18:47:02.000000000","message":"I don\u0027t think the registry should be limited to only using the \u003cactions\u003e directive. Instead, I\u0027d prefer a focus on the kind of data one needs to register...and suggest that the \u003cactions\u003e directive is one example of a directive that can use it.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":113,"context_line":"       *"},{"line_number":114,"context_line":"       * Additionally there are several extensible array properties:"},{"line_number":115,"context_line":"       *"},{"line_number":116,"context_line":"       * itemActions -- allowed \"row\" type actions for an \u003cactions\u003e directive"},{"line_number":117,"context_line":"       *"},{"line_number":118,"context_line":"       * batchActions -- allowed \"batch\" type actions for an \u003cactions\u003e directive"},{"line_number":119,"context_line":"       *"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_e7b26795","line":116,"range":{"start_line":116,"start_character":23,"end_line":116,"end_character":24},"updated":"2016-06-17 18:47:02.000000000","message":"consider: \"actions that operate on one item\"","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":113,"context_line":"       *"},{"line_number":114,"context_line":"       * Additionally there are several extensible array properties:"},{"line_number":115,"context_line":"       *"},{"line_number":116,"context_line":"       * itemActions -- allowed \"row\" type actions for an \u003cactions\u003e directive"},{"line_number":117,"context_line":"       *"},{"line_number":118,"context_line":"       * batchActions -- allowed \"batch\" type actions for an \u003cactions\u003e directive"},{"line_number":119,"context_line":"       *"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_45a02591","line":116,"in_reply_to":"7aa08908_270d8f3e","updated":"2016-06-20 03:49:54.000000000","message":"The \u003cactions\u003e tag defines the data structure that itemActions must adhere to, hence the direct reference here so that a potential developer author of a new RegistryType has some clue what they\u0027re supposed to be writing.\n\nWithout that direct reference, we\u0027d have to duplicate the data structure documentation here, causing it to potentially go out of sync.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":115,"context_line":"       *"},{"line_number":116,"context_line":"       * itemActions -- allowed \"row\" type actions for an \u003cactions\u003e directive"},{"line_number":117,"context_line":"       *"},{"line_number":118,"context_line":"       * batchActions -- allowed \"batch\" type actions for an \u003cactions\u003e directive"},{"line_number":119,"context_line":"       *"},{"line_number":120,"context_line":"       * globalActions -- actions for an \u003cactions\u003e directive which do not operate on"},{"line_number":121,"context_line":"       *   an item or batch. They will be generated using the \"batch\" type, even though"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_47a41b4a","line":118,"updated":"2016-06-17 18:47:02.000000000","message":"consider: \"actions that operate on 1 or more items\"","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":115,"context_line":"       *"},{"line_number":116,"context_line":"       * itemActions -- allowed \"row\" type actions for an \u003cactions\u003e directive"},{"line_number":117,"context_line":"       *"},{"line_number":118,"context_line":"       * batchActions -- allowed \"batch\" type actions for an \u003cactions\u003e directive"},{"line_number":119,"context_line":"       *"},{"line_number":120,"context_line":"       * globalActions -- actions for an \u003cactions\u003e directive which do not operate on"},{"line_number":121,"context_line":"       *   an item or batch. They will be generated using the \"batch\" type, even though"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_85aa0d6f","line":118,"in_reply_to":"7aa08908_47a41b4a","updated":"2016-06-20 03:49:54.000000000","message":"As above.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":117,"context_line":"       *"},{"line_number":118,"context_line":"       * batchActions -- allowed \"batch\" type actions for an \u003cactions\u003e directive"},{"line_number":119,"context_line":"       *"},{"line_number":120,"context_line":"       * globalActions -- actions for an \u003cactions\u003e directive which do not operate on"},{"line_number":121,"context_line":"       *   an item or batch. They will be generated using the \"batch\" type, even though"},{"line_number":122,"context_line":"       *   no items will be passed to them."},{"line_number":123,"context_line":"       *"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_677e77b0","line":120,"updated":"2016-06-17 18:47:02.000000000","message":"consider: \"actions that do not require an item argument\"","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":117,"context_line":"       *"},{"line_number":118,"context_line":"       * batchActions -- allowed \"batch\" type actions for an \u003cactions\u003e directive"},{"line_number":119,"context_line":"       *"},{"line_number":120,"context_line":"       * globalActions -- actions for an \u003cactions\u003e directive which do not operate on"},{"line_number":121,"context_line":"       *   an item or batch. They will be generated using the \"batch\" type, even though"},{"line_number":122,"context_line":"       *   no items will be passed to them."},{"line_number":123,"context_line":"       *"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_45c78545","line":120,"in_reply_to":"7aa08908_677e77b0","updated":"2016-06-20 03:49:54.000000000","message":"As above.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"       *   an item or batch. They will be generated using the \"batch\" type, even though"},{"line_number":122,"context_line":"       *   no items will be passed to them."},{"line_number":123,"context_line":"       *"},{"line_number":124,"context_line":"       * detailsViews -- views for a \u003chz-details\u003e directive"},{"line_number":125,"context_line":"       *"},{"line_number":126,"context_line":"       * tableColumns -- columns for a \u003chz-dynamic-table\u003e directive. Note that"},{"line_number":127,"context_line":"       *   getTableColumns() is provided as a convenience for listing those columns"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_8279d195","line":124,"range":{"start_line":124,"start_character":37,"end_line":124,"end_character":49},"updated":"2016-06-17 18:47:02.000000000","message":"please don\u0027t limit to hz-details. Instead, describe the format of the data registered and give hz-details of an example of one possible way to render these views.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":121,"context_line":"       *   an item or batch. They will be generated using the \"batch\" type, even though"},{"line_number":122,"context_line":"       *   no items will be passed to them."},{"line_number":123,"context_line":"       *"},{"line_number":124,"context_line":"       * detailsViews -- views for a \u003chz-details\u003e directive"},{"line_number":125,"context_line":"       *"},{"line_number":126,"context_line":"       * tableColumns -- columns for a \u003chz-dynamic-table\u003e directive. Note that"},{"line_number":127,"context_line":"       *   getTableColumns() is provided as a convenience for listing those columns"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_65d1e1fb","line":124,"in_reply_to":"7aa08908_8279d195","updated":"2016-06-20 03:49:54.000000000","message":"Again, the original document suffered from being too vague. I\u0027m trying to make this documentation more concrete so people coming into it have some grounding to understand what is going on. I can\u0027t think of a way to word this without making it sound too unnecessarily obtuse. The structure of detailsViews is deliberately designed to work with hz-details, so I see no reason we can\u0027t be specific in this documentation about what detailsViews should look like for a potential developer trying to write something against this API.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":123,"context_line":"       *"},{"line_number":124,"context_line":"       * detailsViews -- views for a \u003chz-details\u003e directive"},{"line_number":125,"context_line":"       *"},{"line_number":126,"context_line":"       * tableColumns -- columns for a \u003chz-dynamic-table\u003e directive. Note that"},{"line_number":127,"context_line":"       *   getTableColumns() is provided as a convenience for listing those columns"},{"line_number":128,"context_line":"       *   with the title property automatically filled in."},{"line_number":129,"context_line":"       *"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_c27d996e","line":126,"range":{"start_line":126,"start_character":39,"end_line":126,"end_character":57},"updated":"2016-06-17 18:47:02.000000000","message":"again...table columns are a fairly generic concept, there will be other components that take advantage of them.  Prefer a description of the data format that needs registration.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"       *"},{"line_number":124,"context_line":"       * detailsViews -- views for a \u003chz-details\u003e directive"},{"line_number":125,"context_line":"       *"},{"line_number":126,"context_line":"       * tableColumns -- columns for a \u003chz-dynamic-table\u003e directive. Note that"},{"line_number":127,"context_line":"       *   getTableColumns() is provided as a convenience for listing those columns"},{"line_number":128,"context_line":"       *   with the title property automatically filled in."},{"line_number":129,"context_line":"       *"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_c52ff5f4","line":126,"in_reply_to":"7aa08908_c27d996e","updated":"2016-06-20 03:49:54.000000000","message":"Again, the specification for the data structure here is defined by hz-dynamic-table, hence the direct reference.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"       *   getTableColumns() is provided as a convenience for listing those columns"},{"line_number":128,"context_line":"       *   with the title property automatically filled in."},{"line_number":129,"context_line":"       *"},{"line_number":130,"context_line":"       * Actions may perform post-config (in the angular sense) intialisation by"},{"line_number":131,"context_line":"       * providing an initScope method which can be invoked using initActions() on the"},{"line_number":132,"context_line":"       * ResourceType. Actions should not perform complex actions in their"},{"line_number":133,"context_line":"       * construction, for example API calls, because as injectables their constructor"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_c2f479f2","line":130,"range":{"start_line":130,"start_character":64,"end_line":130,"end_character":77},"updated":"2016-06-17 18:47:02.000000000","message":"(sp) initialization","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"       *   getTableColumns() is provided as a convenience for listing those columns"},{"line_number":128,"context_line":"       *   with the title property automatically filled in."},{"line_number":129,"context_line":"       *"},{"line_number":130,"context_line":"       * Actions may perform post-config (in the angular sense) intialisation by"},{"line_number":131,"context_line":"       * providing an initScope method which can be invoked using initActions() on the"},{"line_number":132,"context_line":"       * ResourceType. Actions should not perform complex actions in their"},{"line_number":133,"context_line":"       * construction, for example API calls, because as injectables their constructor"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_4266c9bb","line":130,"range":{"start_line":130,"start_character":21,"end_line":130,"end_character":40},"updated":"2016-06-17 18:47:02.000000000","message":"I don\u0027t understand what \"post-config\" means or how it relates to initializing an action scope.\n\nIn fact, now that actions return promises, they have little to no need for scope.\n\nMy first preference is to remove initActions entirely","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"fb29fcd7dc84b51f92f768228be8472dfd352091","unresolved":false,"context_lines":[{"line_number":127,"context_line":"       *   getTableColumns() is provided as a convenience for listing those columns"},{"line_number":128,"context_line":"       *   with the title property automatically filled in."},{"line_number":129,"context_line":"       *"},{"line_number":130,"context_line":"       * Actions may perform post-config (in the angular sense) intialisation by"},{"line_number":131,"context_line":"       * providing an initScope method which can be invoked using initActions() on the"},{"line_number":132,"context_line":"       * ResourceType. Actions should not perform complex actions in their"},{"line_number":133,"context_line":"       * construction, for example API calls, because as injectables their constructor"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_0b561529","line":130,"in_reply_to":"5a9d85d2_e5c67115","updated":"2016-06-20 15:13:15.000000000","message":"Richard, you have a very liberal sense of the word \u0027argued.\u0027  As I recall you berated me about something I had nothing to do with.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"       *   getTableColumns() is provided as a convenience for listing those columns"},{"line_number":128,"context_line":"       *   with the title property automatically filled in."},{"line_number":129,"context_line":"       *"},{"line_number":130,"context_line":"       * Actions may perform post-config (in the angular sense) intialisation by"},{"line_number":131,"context_line":"       * providing an initScope method which can be invoked using initActions() on the"},{"line_number":132,"context_line":"       * ResourceType. Actions should not perform complex actions in their"},{"line_number":133,"context_line":"       * construction, for example API calls, because as injectables their constructor"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_e5c67115","line":130,"in_reply_to":"7aa08908_4266c9bb","updated":"2016-06-20 03:49:54.000000000","message":"\"post-config (in the angular sense)\" refers to code that is run after the angular configuration phase.\n\nI argued with Matt at the summit that initScope was evil and must die. I\u0027m glad you agree :-)","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":127,"context_line":"       *   getTableColumns() is provided as a convenience for listing those columns"},{"line_number":128,"context_line":"       *   with the title property automatically filled in."},{"line_number":129,"context_line":"       *"},{"line_number":130,"context_line":"       * Actions may perform post-config (in the angular sense) intialisation by"},{"line_number":131,"context_line":"       * providing an initScope method which can be invoked using initActions() on the"},{"line_number":132,"context_line":"       * ResourceType. Actions should not perform complex actions in their"},{"line_number":133,"context_line":"       * construction, for example API calls, because as injectables their constructor"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_a5f2a998","line":130,"in_reply_to":"7aa08908_c2f479f2","updated":"2016-06-20 03:49:54.000000000","message":"Spelled correctly for my locale, I will fix though, yeah :-P","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":154,"context_line":"       *   parser may be replaced using set setPathParser(func)."},{"line_number":155,"context_line":"       *"},{"line_number":156,"context_line":"       */"},{"line_number":157,"context_line":"      var type \u003d this;    // disambiguate uses of \"this\" later in this code"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      type.names \u003d [];"},{"line_number":160,"context_line":"      type.properties \u003d {};"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_827ef1e1","line":157,"range":{"start_line":157,"start_character":10,"end_line":157,"end_character":14},"updated":"2016-06-17 18:47:02.000000000","message":"-1: perhaps self would be more clear?  \"type\" leads to things like \"type.type\"  which is confusing.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":154,"context_line":"       *   parser may be replaced using set setPathParser(func)."},{"line_number":155,"context_line":"       *"},{"line_number":156,"context_line":"       */"},{"line_number":157,"context_line":"      var type \u003d this;    // disambiguate uses of \"this\" later in this code"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      type.names \u003d [];"},{"line_number":160,"context_line":"      type.properties \u003d {};"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_25b6b98a","line":157,"in_reply_to":"7aa08908_827ef1e1","updated":"2016-06-20 03:49:54.000000000","message":"I\u0027m comfortable with \"self\". The only reason I used \"type\" is because we\u0027ve used a non-\"self\" naming convention in other parts of our code.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":156,"context_line":"       */"},{"line_number":157,"context_line":"      var type \u003d this;    // disambiguate uses of \"this\" later in this code"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      type.names \u003d [];"},{"line_number":160,"context_line":"      type.properties \u003d {};"},{"line_number":161,"context_line":"      type.initActions \u003d initActions;"},{"line_number":162,"context_line":"      type.setProperty \u003d setProperty;"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_c2ac79a1","line":159,"updated":"2016-06-17 18:47:02.000000000","message":"-1: The interface is unclear here. It is very hard to tell which of these attributes are intended to be private, and which are public. In many cases, there are getters, setters AND the local attribute exposed.\n\nIn general, let\u0027s prefer getters and setters because we want registrations to not step on each other.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":156,"context_line":"       */"},{"line_number":157,"context_line":"      var type \u003d this;    // disambiguate uses of \"this\" later in this code"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      type.names \u003d [];"},{"line_number":160,"context_line":"      type.properties \u003d {};"},{"line_number":161,"context_line":"      type.initActions \u003d initActions;"},{"line_number":162,"context_line":"      type.setProperty \u003d setProperty;"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_e562f115","line":159,"in_reply_to":"7aa08908_c2ac79a1","updated":"2016-06-20 03:49:54.000000000","message":"This closure hack to make private \"properties\" is new to me, and I understand it now a lot better than I did when I first hit this code. Perhaps some comment in the original stating the intent would\u0027ve helped me then :/ I\u0027ll revert the changes that exposed those private things.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      type.load \u003d load;"},{"line_number":170,"context_line":"      type.loadFunction \u003d function def() {"},{"line_number":171,"context_line":"        $log.error(\u0027No load function defined for\u0027, typeCode);"},{"line_number":172,"context_line":"        return Promise.resolve({data: {}});"},{"line_number":173,"context_line":"      };"},{"line_number":174,"context_line":"      type.itemName \u003d itemName;"},{"line_number":175,"context_line":"      type.setItemNameFunction \u003d setItemNameFunction;"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_828d5133","line":172,"range":{"start_line":172,"start_character":23,"end_line":172,"end_character":30},"updated":"2016-06-17 18:47:02.000000000","message":"-1: an \"unset\" load function should \"reject\" I think.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":169,"context_line":"      type.load \u003d load;"},{"line_number":170,"context_line":"      type.loadFunction \u003d function def() {"},{"line_number":171,"context_line":"        $log.error(\u0027No load function defined for\u0027, typeCode);"},{"line_number":172,"context_line":"        return Promise.resolve({data: {}});"},{"line_number":173,"context_line":"      };"},{"line_number":174,"context_line":"      type.itemName \u003d itemName;"},{"line_number":175,"context_line":"      type.setItemNameFunction \u003d setItemNameFunction;"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_8555ed1e","line":172,"in_reply_to":"7aa08908_828d5133","updated":"2016-06-20 03:49:54.000000000","message":"I agree. I just copied over the previous implementation here :-)","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":193,"context_line":"      type.getTableColumns \u003d getTableColumns;"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"      type.listFunction \u003d function def() {"},{"line_number":196,"context_line":"        return Promise.resolve({data: {items: []}});"},{"line_number":197,"context_line":"      };"},{"line_number":198,"context_line":"      type.setListFunction \u003d setListFunction;"},{"line_number":199,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_22a45da4","line":196,"range":{"start_line":196,"start_character":23,"end_line":196,"end_character":30},"updated":"2016-06-17 18:47:02.000000000","message":"-1: reject if uninitialized?","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":193,"context_line":"      type.getTableColumns \u003d getTableColumns;"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"      type.listFunction \u003d function def() {"},{"line_number":196,"context_line":"        return Promise.resolve({data: {items: []}});"},{"line_number":197,"context_line":"      };"},{"line_number":198,"context_line":"      type.setListFunction \u003d setListFunction;"},{"line_number":199,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_4093f3a3","line":196,"in_reply_to":"7aa08908_22a45da4","updated":"2016-06-20 03:49:54.000000000","message":"Yep, as above.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":197,"context_line":"      };"},{"line_number":198,"context_line":"      type.setListFunction \u003d setListFunction;"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"      // TODO: the following is not used??"},{"line_number":201,"context_line":"      // These members support summary templates which are views that are meant"},{"line_number":202,"context_line":"      // to exist in a confined area, such as a drawer in a table row."},{"line_number":203,"context_line":"      type.summaryTemplateUrl \u003d false;"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_c2e8f9b5","line":200,"range":{"start_line":200,"start_character":13,"end_line":200,"end_character":14},"updated":"2016-06-17 18:47:02.000000000","message":"-1: a summary view is used by plugins like searchlight-ui. As hz-table is extended, it is possible they will be used by it or others.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":197,"context_line":"      };"},{"line_number":198,"context_line":"      type.setListFunction \u003d setListFunction;"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"      // TODO: the following is not used??"},{"line_number":201,"context_line":"      // These members support summary templates which are views that are meant"},{"line_number":202,"context_line":"      // to exist in a confined area, such as a drawer in a table row."},{"line_number":203,"context_line":"      type.summaryTemplateUrl \u003d false;"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_e0e81f19","line":200,"in_reply_to":"7aa08908_c2e8f9b5","updated":"2016-06-20 03:49:54.000000000","message":"It\u0027s not documented. It\u0027s not used by any code currently in Horizon, so therefore I couldn\u0027t document it fully in this edit. Hence this comment.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":214,"context_line":"       * If an action does not have an initScope() function, it is ignored."},{"line_number":215,"context_line":"       */"},{"line_number":216,"context_line":"      function initActions(scope) {"},{"line_number":217,"context_line":"        angular.forEach(type.itemActions, setActionScope);"},{"line_number":218,"context_line":"        angular.forEach(type.batchActions, setActionScope);"},{"line_number":219,"context_line":"        angular.forEach(type.globalActions, setActionScope);"},{"line_number":220,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_2240dda4","line":217,"updated":"2016-06-17 18:47:02.000000000","message":"nit: because they itemActions, etc are not protected as private variables, consider adding null checks","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":214,"context_line":"       * If an action does not have an initScope() function, it is ignored."},{"line_number":215,"context_line":"       */"},{"line_number":216,"context_line":"      function initActions(scope) {"},{"line_number":217,"context_line":"        angular.forEach(type.itemActions, setActionScope);"},{"line_number":218,"context_line":"        angular.forEach(type.batchActions, setActionScope);"},{"line_number":219,"context_line":"        angular.forEach(type.globalActions, setActionScope);"},{"line_number":220,"context_line":""}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_20ca27a2","line":217,"in_reply_to":"7aa08908_2240dda4","updated":"2016-06-20 03:49:54.000000000","message":"I think that\u0027s overkill, since they\u0027re documented as extensible arrays, no-one should ever assign to them.","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":312,"context_line":"       * @description"},{"line_number":313,"context_line":"       * Provides the table columns for this type and generates a \u0027title\u0027"},{"line_number":314,"context_line":"       * property on if not already present, using the label provided for"},{"line_number":315,"context_line":"       * the ResourceType\u0027s property of the same name."},{"line_number":316,"context_line":"       * @example"},{"line_number":317,"context_line":"       ```"},{"line_number":318,"context_line":"       resourceType.setProperty(\u0027owner\u0027, {"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_62e2e5a1","line":315,"range":{"start_line":315,"start_character":37,"end_line":315,"end_character":53},"updated":"2016-06-17 18:47:02.000000000","message":"-1: ambiguous. Is this \"title\" or ?","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":312,"context_line":"       * @description"},{"line_number":313,"context_line":"       * Provides the table columns for this type and generates a \u0027title\u0027"},{"line_number":314,"context_line":"       * property on if not already present, using the label provided for"},{"line_number":315,"context_line":"       * the ResourceType\u0027s property of the same name."},{"line_number":316,"context_line":"       * @example"},{"line_number":317,"context_line":"       ```"},{"line_number":318,"context_line":"       resourceType.setProperty(\u0027owner\u0027, {"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_a0be17fd","line":315,"in_reply_to":"7aa08908_62e2e5a1","updated":"2016-06-20 03:49:54.000000000","message":"Yep, fixed, I hope :-)","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14307,"name":"Tyr Johanson","email":"tyr@hpe.com","username":"tyr"},"change_message_id":"09de7d1be6dd8ddbb17aae59441bf4b98112a6d6","unresolved":false,"context_lines":[{"line_number":588,"context_line":"      }"},{"line_number":589,"context_line":"    }"},{"line_number":590,"context_line":""},{"line_number":591,"context_line":"    // The slugs are only used to align Django routes with heat"},{"line_number":592,"context_line":"    // type names.  In a context without Django routing this is"},{"line_number":593,"context_line":"    // not needed."},{"line_number":594,"context_line":"    var registry \u003d {"},{"line_number":595,"context_line":"      resourceTypes: {},"},{"line_number":596,"context_line":"      defaultSummaryTemplateUrl: false,"}],"source_content_type":"text/javascript","patch_set":8,"id":"7aa08908_a295ede4","line":593,"range":{"start_line":591,"start_character":0,"end_line":593,"end_character":18},"updated":"2016-06-17 18:47:02.000000000","message":"-1: slugs no longer apply","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"011b10fab7418bc6e7ee7cb3618e0d83d74b97c4","unresolved":false,"context_lines":[{"line_number":590,"context_line":""},{"line_number":591,"context_line":"    // The slugs are only used to align Django routes with heat"},{"line_number":592,"context_line":"    // type names.  In a context without Django routing this is"},{"line_number":593,"context_line":"    // not needed."},{"line_number":594,"context_line":"    var registry \u003d {"},{"line_number":595,"context_line":"      resourceTypes: {},"},{"line_number":596,"context_line":"      defaultSummaryTemplateUrl: false,"}],"source_content_type":"text/javascript","patch_set":8,"id":"5a9d85d2_2041870c","line":593,"in_reply_to":"7aa08908_a295ede4","updated":"2016-06-20 03:49:54.000000000","message":"Done","commit_id":"399a85f558c09bf1fa7d2698cb01380637156e6a"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8d81c19197277f940c8d0c97901d924c9ccba458","unresolved":false,"context_lines":[{"line_number":253,"context_line":"        return self;"},{"line_number":254,"context_line":"      }"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"      /**"},{"line_number":257,"context_line":"       * @ngdoc function"},{"line_number":258,"context_line":"       * @name list"},{"line_number":259,"context_line":"       * @description"},{"line_number":260,"context_line":"       * Loads a list of items of the type. The actual listing"},{"line_number":261,"context_line":"       * is performed by the function passed into setListFunction()."},{"line_number":262,"context_line":"       *"},{"line_number":263,"context_line":"       * @example"},{"line_number":264,"context_line":"       ```"},{"line_number":265,"context_line":"       getResourceType(\u0027thing\u0027).setListFunction(func);"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"       function func(descriptor) {"},{"line_number":268,"context_line":"         return someApi.list();"},{"line_number":269,"context_line":"       }"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"       var listPromise \u003d resourceType.list();"},{"line_number":272,"context_line":"       ```"},{"line_number":273,"context_line":"       */"},{"line_number":274,"context_line":"      function list() {"},{"line_number":275,"context_line":"        return listFunction();"},{"line_number":276,"context_line":"      }"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"      /**"},{"line_number":279,"context_line":"       * @ngdoc function"}],"source_content_type":"text/javascript","patch_set":9,"id":"5a9d85d2_e6af80e1","line":276,"range":{"start_line":256,"start_character":0,"end_line":276,"end_character":7},"updated":"2016-06-20 15:41:25.000000000","message":"Similar to below, not really sure why this is needed. :)","commit_id":"4ac16d5999844001f73c4e9188dff66973b1c6c8"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"8d81c19197277f940c8d0c97901d924c9ccba458","unresolved":false,"context_lines":[{"line_number":406,"context_line":"      }"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"      /**"},{"line_number":409,"context_line":"       * @ngdoc function"},{"line_number":410,"context_line":"       * @name detailsPath"},{"line_number":411,"context_line":"       * @description"},{"line_number":412,"context_line":"       * Generate a URL path for a resource item. Uses the function"},{"line_number":413,"context_line":"       * provided through setPathGenerator."},{"line_number":414,"context_line":"       * @example"},{"line_number":415,"context_line":"       ```"},{"line_number":416,"context_line":"       getResourceType(\u0027thing\u0027).setPathGenerator(func);"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"       function func(descriptor) {"},{"line_number":419,"context_line":"         return \u0027load-balancer/\u0027 + descriptor.balancerId"},{"line_number":420,"context_line":"           + \u0027/listener/\u0027 + descriptor.id"},{"line_number":421,"context_line":"       }"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"       var path \u003d resourceType.detailsPath({id: 12, balancerId: \u0027abasefasdf\u0027});"},{"line_number":424,"context_line":"       ```"},{"line_number":425,"context_line":"       */"},{"line_number":426,"context_line":"      function detailsPath(spec) {"},{"line_number":427,"context_line":"        return pathGenerator(spec);"},{"line_number":428,"context_line":"      }"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"      // The reason for this function as opposed to just setting the value"},{"line_number":431,"context_line":"      // is solely to make it easy to chain commands."}],"source_content_type":"text/javascript","patch_set":9,"id":"5a9d85d2_264ce86f","line":428,"range":{"start_line":409,"start_character":1,"end_line":428,"end_character":7},"updated":"2016-06-20 15:41:25.000000000","message":"This just isn\u0027t needed...they can just call \u0027pathGenerator(arg)\u0027 rather than this function.  Is there a reason we need this added layer?","commit_id":"4ac16d5999844001f73c4e9188dff66973b1c6c8"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * @description"},{"line_number":33,"context_line":"   *"},{"line_number":34,"context_line":"   * The type registry collects up implementations of user interface components for"},{"line_number":35,"context_line":"   * client-side user interface, for example angular panels in Horizon. These are"},{"line_number":36,"context_line":"   * tied to types using the HEAT type names, for example, \u0027OS::Glance::Image\u0027,"},{"line_number":37,"context_line":"   * so types encapsulate a single object retreieved from a service API. Other types"},{"line_number":38,"context_line":"   * might include Nova servers or Swift objects. The HEAT type names are listed:"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_66e64b45","line":35,"updated":"2016-07-12 23:44:19.000000000","message":"first sentence sounds confusing\n\nMaybe something like:\n\nThe type registry collects up implementation details for client-side user interface, for example, the angular panels in Horizon. It provides a single location for common features that are used in display and behavior related to that resource type.","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"   * @description"},{"line_number":33,"context_line":"   *"},{"line_number":34,"context_line":"   * The type registry collects up implementations of user interface components for"},{"line_number":35,"context_line":"   * client-side user interface, for example angular panels in Horizon. These are"},{"line_number":36,"context_line":"   * tied to types using the HEAT type names, for example, \u0027OS::Glance::Image\u0027,"},{"line_number":37,"context_line":"   * so types encapsulate a single object retreieved from a service API. Other types"},{"line_number":38,"context_line":"   * might include Nova servers or Swift objects. The HEAT type names are listed:"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_457aee26","line":35,"in_reply_to":"1aa78d24_66e64b45","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   * The type registry collects up implementations of user interface components for"},{"line_number":35,"context_line":"   * client-side user interface, for example angular panels in Horizon. These are"},{"line_number":36,"context_line":"   * tied to types using the HEAT type names, for example, \u0027OS::Glance::Image\u0027,"},{"line_number":37,"context_line":"   * so types encapsulate a single object retreieved from a service API. Other types"},{"line_number":38,"context_line":"   * might include Nova servers or Swift objects. The HEAT type names are listed:"},{"line_number":39,"context_line":"   *"},{"line_number":40,"context_line":"   *   http://docs.openstack.org/developer/heat/template_guide/openstack.html"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_4bb3584d","line":37,"updated":"2016-07-12 23:44:19.000000000","message":"retrieved*","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"   * The type registry collects up implementations of user interface components for"},{"line_number":35,"context_line":"   * client-side user interface, for example angular panels in Horizon. These are"},{"line_number":36,"context_line":"   * tied to types using the HEAT type names, for example, \u0027OS::Glance::Image\u0027,"},{"line_number":37,"context_line":"   * so types encapsulate a single object retreieved from a service API. Other types"},{"line_number":38,"context_line":"   * might include Nova servers or Swift objects. The HEAT type names are listed:"},{"line_number":39,"context_line":"   *"},{"line_number":40,"context_line":"   *   http://docs.openstack.org/developer/heat/template_guide/openstack.html"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_2577e23c","line":37,"in_reply_to":"1aa78d24_4bb3584d","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":43,"context_line":"   *"},{"line_number":44,"context_line":"   *   var resourceType \u003d registryService.getResourceType(\u0027OS::Glance::Image\u0027);"},{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * Types may have a number of aspects associated with them:"},{"line_number":47,"context_line":"   *"},{"line_number":48,"context_line":"   * - a simplified name for the type."},{"line_number":49,"context_line":"   * - a mechanism for retrieving objects of the type by id and listing objects"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_0152d166","line":46,"updated":"2016-07-12 23:44:19.000000000","message":"To name a few:","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":43,"context_line":"   *"},{"line_number":44,"context_line":"   *   var resourceType \u003d registryService.getResourceType(\u0027OS::Glance::Image\u0027);"},{"line_number":45,"context_line":"   *"},{"line_number":46,"context_line":"   * Types may have a number of aspects associated with them:"},{"line_number":47,"context_line":"   *"},{"line_number":48,"context_line":"   * - a simplified name for the type."},{"line_number":49,"context_line":"   * - a mechanism for retrieving objects of the type by id and listing objects"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_25c5223d","line":46,"in_reply_to":"1aa78d24_0152d166","updated":"2016-07-13 20:02:35.000000000","message":"I disagree: this list should be complete, not partial.","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":48,"context_line":"   * - a simplified name for the type."},{"line_number":49,"context_line":"   * - a mechanism for retrieving objects of the type by id and listing objects"},{"line_number":50,"context_line":"   * - actions that may be performed on individual or batches of objects and"},{"line_number":51,"context_line":"   *   globally (independent of any objects existing)"},{"line_number":52,"context_line":"   * - details view(s) for individual objects (may tabbed multiple views)"},{"line_number":53,"context_line":"   * - information about properties, including:"},{"line_number":54,"context_line":"   *   - labels used in places like table headers or forms"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_6b6bb485","line":51,"updated":"2016-07-12 23:44:19.000000000","message":"\"individual or batches of objects and globally\"\n\n\u003d\u003d\u003e\n\n\"individual objects, multiple (batch) objects, and globally (independent of any existing objects; e.g. Create Image)\"","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":48,"context_line":"   * - a simplified name for the type."},{"line_number":49,"context_line":"   * - a mechanism for retrieving objects of the type by id and listing objects"},{"line_number":50,"context_line":"   * - actions that may be performed on individual or batches of objects and"},{"line_number":51,"context_line":"   *   globally (independent of any objects existing)"},{"line_number":52,"context_line":"   * - details view(s) for individual objects (may tabbed multiple views)"},{"line_number":53,"context_line":"   * - information about properties, including:"},{"line_number":54,"context_line":"   *   - labels used in places like table headers or forms"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_45cf8e57","line":51,"in_reply_to":"1aa78d24_6b6bb485","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"df51e304f8d0b4a42ee7cbddb369d27bd7d4499e","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   * - a mechanism for retrieving objects of the type by id and listing objects"},{"line_number":50,"context_line":"   * - actions that may be performed on individual or batches of objects and"},{"line_number":51,"context_line":"   *   globally (independent of any objects existing)"},{"line_number":52,"context_line":"   * - details view(s) for individual objects (may tabbed multiple views)"},{"line_number":53,"context_line":"   * - information about properties, including:"},{"line_number":54,"context_line":"   *   - labels used in places like table headers or forms"},{"line_number":55,"context_line":"   *   - formatting mechanisms for property values"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_6b90a196","line":52,"range":{"start_line":52,"start_character":47,"end_line":52,"end_character":50},"updated":"2016-07-01 22:22:20.000000000","message":"may?","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   * - a mechanism for retrieving objects of the type by id and listing objects"},{"line_number":50,"context_line":"   * - actions that may be performed on individual or batches of objects and"},{"line_number":51,"context_line":"   *   globally (independent of any objects existing)"},{"line_number":52,"context_line":"   * - details view(s) for individual objects (may tabbed multiple views)"},{"line_number":53,"context_line":"   * - information about properties, including:"},{"line_number":54,"context_line":"   *   - labels used in places like table headers or forms"},{"line_number":55,"context_line":"   *   - formatting mechanisms for property values"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_85d97625","line":52,"range":{"start_line":52,"start_character":47,"end_line":52,"end_character":50},"in_reply_to":"1aa78d24_6b90a196","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":69,"context_line":"       * registryService.getResourceType(typeCode) call."},{"line_number":70,"context_line":"       *"},{"line_number":71,"context_line":"       * There are several extensible (using Horizon\u0027s extensible service)"},{"line_number":72,"context_line":"       * array properties:"},{"line_number":73,"context_line":"       *"},{"line_number":74,"context_line":"       * itemActions -- allowed \"row\" type actions for an \u003cactions\u003e directive."},{"line_number":75,"context_line":"       *"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_21570d59","line":72,"updated":"2016-07-12 23:44:19.000000000","message":"This service uses Horizon\u0027s extensibility service to decorate some of the array properties:","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"       * registryService.getResourceType(typeCode) call."},{"line_number":70,"context_line":"       *"},{"line_number":71,"context_line":"       * There are several extensible (using Horizon\u0027s extensible service)"},{"line_number":72,"context_line":"       * array properties:"},{"line_number":73,"context_line":"       *"},{"line_number":74,"context_line":"       * itemActions -- allowed \"row\" type actions for an \u003cactions\u003e directive."},{"line_number":75,"context_line":"       *"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_453dce2b","line":72,"in_reply_to":"1aa78d24_21570d59","updated":"2016-07-13 20:02:35.000000000","message":"I\u0027ve tried a slightly different wording here.","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":88,"context_line":"       * filterFacets - filter facets registered here may be used in a \u003cmagic-search\u003e"},{"line_number":89,"context_line":"       *   bar."},{"line_number":90,"context_line":"       *"},{"line_number":91,"context_line":"       * Actions may perform post-config (in the angular sense) intialization by"},{"line_number":92,"context_line":"       * providing an initScope method which can be invoked using initActions() on the"},{"line_number":93,"context_line":"       * ResourceType. Actions should not perform complex actions in their"},{"line_number":94,"context_line":"       * construction, for example API calls, because as injectables their constructor"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_cb0aa81f","line":91,"updated":"2016-07-12 23:44:19.000000000","message":"initialization*","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":88,"context_line":"       * filterFacets - filter facets registered here may be used in a \u003cmagic-search\u003e"},{"line_number":89,"context_line":"       *   bar."},{"line_number":90,"context_line":"       *"},{"line_number":91,"context_line":"       * Actions may perform post-config (in the angular sense) intialization by"},{"line_number":92,"context_line":"       * providing an initScope method which can be invoked using initActions() on the"},{"line_number":93,"context_line":"       * ResourceType. Actions should not perform complex actions in their"},{"line_number":94,"context_line":"       * construction, for example API calls, because as injectables their constructor"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_050aa679","line":91,"in_reply_to":"1aa78d24_cb0aa81f","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"df51e304f8d0b4a42ee7cbddb369d27bd7d4499e","unresolved":false,"context_lines":[{"line_number":99,"context_line":"       *"},{"line_number":100,"context_line":"       * Path generation and parsing:"},{"line_number":101,"context_line":"       *"},{"line_number":102,"context_line":"       * The purpose here is to allow details to be retrieved automatically"},{"line_number":103,"context_line":"       * from such a path, or similarly to create a path to such a route from any"},{"line_number":104,"context_line":"       * reference. TODO what is a \"reference\"?"},{"line_number":105,"context_line":"       *"},{"line_number":106,"context_line":"       * This establishes a two-way relationship between the path and the"},{"line_number":107,"context_line":"       * identifier(s) for the item. The path could be used as part of a details route,"},{"line_number":108,"context_line":"       * for example an identifier of \u0027abc-defg\u0027 would yield \u0027abc-defg\u0027 which could"},{"line_number":109,"context_line":"       * be used in a details route, such as: \u0027/details/OS::Glance::Image/abc-defg\u0027."},{"line_number":110,"context_line":"       * See parsePath() and detailsPath() for more information."},{"line_number":111,"context_line":"       * TODO this documentation says \"could\" - how is someone trying to implement a"},{"line_number":112,"context_line":"       * resource type supposed to interpret that?"},{"line_number":113,"context_line":"       * TODO the above doesn\u0027t match the documentation against the functions"},{"line_number":114,"context_line":"       *"},{"line_number":115,"context_line":"       */"},{"line_number":116,"context_line":"      var self \u003d this;    // disambiguate uses of \"this\" later in this code"},{"line_number":117,"context_line":""}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_6b5541c5","line":114,"range":{"start_line":102,"start_character":6,"end_line":114,"end_character":8},"updated":"2016-07-01 22:22:20.000000000","message":"This is still confusingly written and has TODOs. Matt, can you provide a better description?","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"c2b6b7757e82ce9baa523f22698f0fcd41e48f1c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"       *"},{"line_number":100,"context_line":"       * Path generation and parsing:"},{"line_number":101,"context_line":"       *"},{"line_number":102,"context_line":"       * The purpose here is to allow details to be retrieved automatically"},{"line_number":103,"context_line":"       * from such a path, or similarly to create a path to such a route from any"},{"line_number":104,"context_line":"       * reference. TODO what is a \"reference\"?"},{"line_number":105,"context_line":"       *"},{"line_number":106,"context_line":"       * This establishes a two-way relationship between the path and the"},{"line_number":107,"context_line":"       * identifier(s) for the item. The path could be used as part of a details route,"},{"line_number":108,"context_line":"       * for example an identifier of \u0027abc-defg\u0027 would yield \u0027abc-defg\u0027 which could"},{"line_number":109,"context_line":"       * be used in a details route, such as: \u0027/details/OS::Glance::Image/abc-defg\u0027."},{"line_number":110,"context_line":"       * See parsePath() and detailsPath() for more information."},{"line_number":111,"context_line":"       * TODO this documentation says \"could\" - how is someone trying to implement a"},{"line_number":112,"context_line":"       * resource type supposed to interpret that?"},{"line_number":113,"context_line":"       * TODO the above doesn\u0027t match the documentation against the functions"},{"line_number":114,"context_line":"       *"},{"line_number":115,"context_line":"       */"},{"line_number":116,"context_line":"      var self \u003d this;    // disambiguate uses of \"this\" later in this code"},{"line_number":117,"context_line":""}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_cde869b7","line":114,"range":{"start_line":102,"start_character":6,"end_line":114,"end_character":8},"in_reply_to":"1aa78d24_6b5541c5","updated":"2016-07-05 13:01:44.000000000","message":"It\u0027s basic serialization/deserialization of an ID, for use in a URL.  You use it when linking to a view that concerns a specific object, like a Details page.  The use case is: \"I have an object and need to convey it uniquely in a URL,\" and sometimes it\u0027s more than just a simple string/ID.  The converse use case is \"I\u0027m a page that got a URL and need to find the exact object.\"  That\u0027s what both of these functions perform.  Most of the time you just use the identifier, which is the ID, but the \u0027identifier\u0027 object could also be an object, a compound key, etc.","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":99,"context_line":"       *"},{"line_number":100,"context_line":"       * Path generation and parsing:"},{"line_number":101,"context_line":"       *"},{"line_number":102,"context_line":"       * The purpose here is to allow details to be retrieved automatically"},{"line_number":103,"context_line":"       * from such a path, or similarly to create a path to such a route from any"},{"line_number":104,"context_line":"       * reference. TODO what is a \"reference\"?"},{"line_number":105,"context_line":"       *"},{"line_number":106,"context_line":"       * This establishes a two-way relationship between the path and the"},{"line_number":107,"context_line":"       * identifier(s) for the item. The path could be used as part of a details route,"},{"line_number":108,"context_line":"       * for example an identifier of \u0027abc-defg\u0027 would yield \u0027abc-defg\u0027 which could"},{"line_number":109,"context_line":"       * be used in a details route, such as: \u0027/details/OS::Glance::Image/abc-defg\u0027."},{"line_number":110,"context_line":"       * See parsePath() and detailsPath() for more information."},{"line_number":111,"context_line":"       * TODO this documentation says \"could\" - how is someone trying to implement a"},{"line_number":112,"context_line":"       * resource type supposed to interpret that?"},{"line_number":113,"context_line":"       * TODO the above doesn\u0027t match the documentation against the functions"},{"line_number":114,"context_line":"       *"},{"line_number":115,"context_line":"       */"},{"line_number":116,"context_line":"      var self \u003d this;    // disambiguate uses of \"this\" later in this code"},{"line_number":117,"context_line":""}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_456b0e20","line":114,"range":{"start_line":102,"start_character":6,"end_line":114,"end_character":8},"in_reply_to":"1aa78d24_cde869b7","updated":"2016-07-13 20:02:35.000000000","message":"This is still confusing to me; I\u0027ll work through clarifying this with Matt.","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      extensibleService(self.tableColumns, self.tableColumns);"},{"line_number":154,"context_line":"      self.getTableColumns \u003d getTableColumns;"},{"line_number":155,"context_line":"      this.filterFacets \u003d [];"},{"line_number":156,"context_line":"      extensibleService(this.filterFacets, this.filterFacets);"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      // TODO: there is no information in the Horizon code base to refer"},{"line_number":159,"context_line":"      // to here, thus I cannot determine what these URLs should point to,"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_a1977dea","line":156,"updated":"2016-07-12 23:44:19.000000000","message":"s/this/self","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"      extensibleService(self.tableColumns, self.tableColumns);"},{"line_number":154,"context_line":"      self.getTableColumns \u003d getTableColumns;"},{"line_number":155,"context_line":"      this.filterFacets \u003d [];"},{"line_number":156,"context_line":"      extensibleService(this.filterFacets, this.filterFacets);"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      // TODO: there is no information in the Horizon code base to refer"},{"line_number":159,"context_line":"      // to here, thus I cannot determine what these URLs should point to,"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_e55cba7f","line":156,"in_reply_to":"1aa78d24_a1977dea","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"df51e304f8d0b4a42ee7cbddb369d27bd7d4499e","unresolved":false,"context_lines":[{"line_number":155,"context_line":"      this.filterFacets \u003d [];"},{"line_number":156,"context_line":"      extensibleService(this.filterFacets, this.filterFacets);"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      // TODO: there is no information in the Horizon code base to refer"},{"line_number":159,"context_line":"      // to here, thus I cannot determine what these URLs should point to,"},{"line_number":160,"context_line":"      // thus what a valid template spec should be."},{"line_number":161,"context_line":"      // These members support summary templates which are views that are meant"},{"line_number":162,"context_line":"      // to exist in a confined area, such as a drawer in a table row."},{"line_number":163,"context_line":"      this.summaryTemplateUrl \u003d false;"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_ab0449c6","line":160,"range":{"start_line":158,"start_character":0,"end_line":160,"end_character":51},"updated":"2016-07-01 22:22:20.000000000","message":"https://github.com/openstack/horizon/blob/36e6bea4ced96403c9d6aa0a066825e413d11a4a/horizon/static/framework/widgets/table/hz-resource-table.controller.js#L42","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":155,"context_line":"      this.filterFacets \u003d [];"},{"line_number":156,"context_line":"      extensibleService(this.filterFacets, this.filterFacets);"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      // TODO: there is no information in the Horizon code base to refer"},{"line_number":159,"context_line":"      // to here, thus I cannot determine what these URLs should point to,"},{"line_number":160,"context_line":"      // thus what a valid template spec should be."},{"line_number":161,"context_line":"      // These members support summary templates which are views that are meant"},{"line_number":162,"context_line":"      // to exist in a confined area, such as a drawer in a table row."},{"line_number":163,"context_line":"      this.summaryTemplateUrl \u003d false;"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_25fd223c","line":160,"range":{"start_line":158,"start_character":0,"end_line":160,"end_character":51},"in_reply_to":"1aa78d24_ab0449c6","updated":"2016-07-13 20:02:35.000000000","message":"So in that usage it\u0027s called detailsTemplateUrl - should that be what it\u0027s called here?","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"df51e304f8d0b4a42ee7cbddb369d27bd7d4499e","unresolved":false,"context_lines":[{"line_number":200,"context_line":"         label: gettext(\"Kernel ID\")  // just provides the label."},{"line_number":201,"context_line":"                                      // values will be shown directly"},{"line_number":202,"context_line":"       })"},{"line_number":203,"context_line":"         .setproperty(\"disk_size\", {"},{"line_number":204,"context_line":"           label: gettext(\"disk size\"),"},{"line_number":205,"context_line":"           value_function: function(size) {      // uses function to"},{"line_number":206,"context_line":"             return interpolate(\"%s GiB\", size); // display values."}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_eb0e51e4","line":203,"range":{"start_line":203,"start_character":13,"end_line":203,"end_character":14},"updated":"2016-07-01 22:22:20.000000000","message":"P","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"df51e304f8d0b4a42ee7cbddb369d27bd7d4499e","unresolved":false,"context_lines":[{"line_number":202,"context_line":"       })"},{"line_number":203,"context_line":"         .setproperty(\"disk_size\", {"},{"line_number":204,"context_line":"           label: gettext(\"disk size\"),"},{"line_number":205,"context_line":"           value_function: function(size) {      // uses function to"},{"line_number":206,"context_line":"             return interpolate(\"%s GiB\", size); // display values."},{"line_number":207,"context_line":"           }"},{"line_number":208,"context_line":"         })"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_2b205949","line":205,"range":{"start_line":205,"start_character":11,"end_line":205,"end_character":25},"updated":"2016-07-01 22:22:20.000000000","message":"this is using python naming convention (underscore) and not javascript (camelCase). I don\u0027t see any real uses of it yet, so I\u0027m wondering if we should change that now. (I won\u0027t block this patch for that change. Just asking).","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":202,"context_line":"       })"},{"line_number":203,"context_line":"         .setproperty(\"disk_size\", {"},{"line_number":204,"context_line":"           label: gettext(\"disk size\"),"},{"line_number":205,"context_line":"           value_function: function(size) {      // uses function to"},{"line_number":206,"context_line":"             return interpolate(\"%s GiB\", size); // display values."},{"line_number":207,"context_line":"           }"},{"line_number":208,"context_line":"         })"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_816881f6","line":205,"range":{"start_line":205,"start_character":11,"end_line":205,"end_character":25},"in_reply_to":"1aa78d24_2b205949","updated":"2016-07-12 23:44:19.000000000","message":"+1","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":202,"context_line":"       })"},{"line_number":203,"context_line":"         .setproperty(\"disk_size\", {"},{"line_number":204,"context_line":"           label: gettext(\"disk size\"),"},{"line_number":205,"context_line":"           value_function: function(size) {      // uses function to"},{"line_number":206,"context_line":"             return interpolate(\"%s GiB\", size); // display values."},{"line_number":207,"context_line":"           }"},{"line_number":208,"context_line":"         })"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_005614ce","line":205,"range":{"start_line":205,"start_character":11,"end_line":205,"end_character":25},"in_reply_to":"1aa78d24_816881f6","updated":"2016-07-13 20:02:35.000000000","message":"format() is removed (in the next revision of this patch) so these properties are no longer relevant.","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":231,"context_line":"             initial: gettext(\"Initial\"),    // look up values"},{"line_number":232,"context_line":"             running: gettext(\"Running\")"},{"line_number":233,"context_line":"           },"},{"line_number":234,"context_line":"           default_function: function(input) { // uses function if no match"},{"line_number":235,"context_line":"             return input.toUpperCase();"},{"line_number":236,"context_line":"           }"},{"line_number":237,"context_line":"         })"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_814fe190","line":234,"updated":"2016-07-12 23:44:19.000000000","message":"ditto","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":252,"context_line":"       *"},{"line_number":253,"context_line":"       * @example"},{"line_number":254,"context_line":"       ```"},{"line_number":255,"context_line":"       getResourceType(\u0027thing\u0027).setListFunction(func);"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"       function func(descriptor) {"},{"line_number":258,"context_line":"         return someApi.list();"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_41521936","line":255,"updated":"2016-07-12 23:44:19.000000000","message":"replace getResourceType(\u0027thing\u0027) with resourceType","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":252,"context_line":"       *"},{"line_number":253,"context_line":"       * @example"},{"line_number":254,"context_line":"       ```"},{"line_number":255,"context_line":"       getResourceType(\u0027thing\u0027).setListFunction(func);"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"       function func(descriptor) {"},{"line_number":258,"context_line":"         return someApi.list();"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_401e5c0e","line":255,"in_reply_to":"1aa78d24_41521936","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"       function func(descriptor) {"},{"line_number":258,"context_line":"         return someApi.list();"},{"line_number":259,"context_line":"       }"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"       var listPromise \u003d resourceType.list();"},{"line_number":262,"context_line":"       ```"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_2128ad99","line":259,"updated":"2016-07-12 23:44:19.000000000","message":"function func(params) {\n      return someApi.getItems(params);\n}\n\ne.g.\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/images.module.js#L219","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"       function func(descriptor) {"},{"line_number":258,"context_line":"         return someApi.list();"},{"line_number":259,"context_line":"       }"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"       var listPromise \u003d resourceType.list();"},{"line_number":262,"context_line":"       ```"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_60ec38f4","line":259,"in_reply_to":"1aa78d24_2128ad99","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"df51e304f8d0b4a42ee7cbddb369d27bd7d4499e","unresolved":false,"context_lines":[{"line_number":258,"context_line":"         return someApi.list();"},{"line_number":259,"context_line":"       }"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"       var listPromise \u003d resourceType.list();"},{"line_number":262,"context_line":"       ```"},{"line_number":263,"context_line":"       */"},{"line_number":264,"context_line":"      function setListFunction(func) {"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_abb9e9ee","line":261,"updated":"2016-07-01 22:22:20.000000000","message":"Given the recent facet code added, should this mention that list function should also typically be able to handle a parameters object input?\n\nhttps://github.com/openstack/horizon/blob/36e6bea4ced96403c9d6aa0a066825e413d11a4a/openstack_dashboard/static/app/core/images/images.module.js#L219-L231","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":258,"context_line":"         return someApi.list();"},{"line_number":259,"context_line":"       }"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"       var listPromise \u003d resourceType.list();"},{"line_number":262,"context_line":"       ```"},{"line_number":263,"context_line":"       */"},{"line_number":264,"context_line":"      function setListFunction(func) {"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_60a8b878","line":261,"in_reply_to":"1aa78d24_abb9e9ee","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"df51e304f8d0b4a42ee7cbddb369d27bd7d4499e","unresolved":false,"context_lines":[{"line_number":289,"context_line":"       * @description"},{"line_number":290,"context_line":"       * Provides the table columns for this type and generates a \u0027title\u0027"},{"line_number":291,"context_line":"       * if not already present, using the label provided for"},{"line_number":292,"context_line":"       * the ResourceType\u0027s property in the column."},{"line_number":293,"context_line":"       * @example"},{"line_number":294,"context_line":"       ```"},{"line_number":295,"context_line":"       resourceType.setProperty(\u0027owner\u0027, {"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_2bce9983","line":292,"updated":"2016-07-01 22:22:20.000000000","message":"Refer people to hz-dynamic-table for spec on the format of that?","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":289,"context_line":"       * @description"},{"line_number":290,"context_line":"       * Provides the table columns for this type and generates a \u0027title\u0027"},{"line_number":291,"context_line":"       * if not already present, using the label provided for"},{"line_number":292,"context_line":"       * the ResourceType\u0027s property in the column."},{"line_number":293,"context_line":"       * @example"},{"line_number":294,"context_line":"       ```"},{"line_number":295,"context_line":"       resourceType.setProperty(\u0027owner\u0027, {"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_b4282187","line":292,"in_reply_to":"1aa78d24_2bce9983","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"df51e304f8d0b4a42ee7cbddb369d27bd7d4499e","unresolved":false,"context_lines":[{"line_number":401,"context_line":"       * @description"},{"line_number":402,"context_line":"       * Sets a function that is used generate paths.  Accepts the"},{"line_number":403,"context_line":"       * resource-type-specific id/object."},{"line_number":404,"context_line":"       * TODO does it accept an id *or* an object? It can\u0027t accept both!"},{"line_number":405,"context_line":"       * TODO the default detailsPath seems to accept *just* an id??"},{"line_number":406,"context_line":"       * The subpath returned should NOT have a leading slash. WHY?"},{"line_number":407,"context_line":"       * @example"},{"line_number":408,"context_line":"       ```"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_aba0c9a6","line":405,"range":{"start_line":404,"start_character":0,"end_line":405,"end_character":68},"updated":"2016-07-01 22:22:20.000000000","message":"More confusion.","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":401,"context_line":"       * @description"},{"line_number":402,"context_line":"       * Sets a function that is used generate paths.  Accepts the"},{"line_number":403,"context_line":"       * resource-type-specific id/object."},{"line_number":404,"context_line":"       * TODO does it accept an id *or* an object? It can\u0027t accept both!"},{"line_number":405,"context_line":"       * TODO the default detailsPath seems to accept *just* an id??"},{"line_number":406,"context_line":"       * The subpath returned should NOT have a leading slash. WHY?"},{"line_number":407,"context_line":"       * @example"},{"line_number":408,"context_line":"       ```"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_5449fd31","line":405,"range":{"start_line":404,"start_character":0,"end_line":405,"end_character":68},"in_reply_to":"1aa78d24_4dfe3938","updated":"2016-07-13 20:02:35.000000000","message":"Why does a type name need to be provided given that this is a method *on* a type object?","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"c251c950f4785a9f12136e97958231689e44a9fe","unresolved":false,"context_lines":[{"line_number":401,"context_line":"       * @description"},{"line_number":402,"context_line":"       * Sets a function that is used generate paths.  Accepts the"},{"line_number":403,"context_line":"       * resource-type-specific id/object."},{"line_number":404,"context_line":"       * TODO does it accept an id *or* an object? It can\u0027t accept both!"},{"line_number":405,"context_line":"       * TODO the default detailsPath seems to accept *just* an id??"},{"line_number":406,"context_line":"       * The subpath returned should NOT have a leading slash. WHY?"},{"line_number":407,"context_line":"       * @example"},{"line_number":408,"context_line":"       ```"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_4dfe3938","line":405,"range":{"start_line":404,"start_character":0,"end_line":405,"end_character":68},"in_reply_to":"1aa78d24_aba0c9a6","updated":"2016-07-05 13:10:16.000000000","message":"The original intent was to accept the \"identifier\" portion of an object descriptor.  A descriptor is an object that has a \"type\" (e.g. \"OS::Glance::Image\") and an \"identifier\" which could either be a string, or if necessary, a descriptive object.  So in that case, yes, it takes a string or an object...since both the serialization and deserialization are specific to the object type.\n\nIf that\u0027s too confusing, then sure, we could change it to take an object (the item) and default to item.id, but then we will have to change some of the code that used the descriptor approach, for the details views, etc.","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":406,"context_line":"       * The subpath returned should NOT have a leading slash. WHY?"},{"line_number":407,"context_line":"       * @example"},{"line_number":408,"context_line":"       ```"},{"line_number":409,"context_line":"       getResourceType(\u0027thing\u0027).setPathGenerator(func);"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"       function func(descriptor) {"},{"line_number":412,"context_line":"         return \u0027load-balancer/\u0027 + descriptor.balancerId"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_459d04bb","line":409,"updated":"2016-07-12 23:44:19.000000000","message":"resourceType*","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":406,"context_line":"       * The subpath returned should NOT have a leading slash. WHY?"},{"line_number":407,"context_line":"       * @example"},{"line_number":408,"context_line":"       ```"},{"line_number":409,"context_line":"       getResourceType(\u0027thing\u0027).setPathGenerator(func);"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"       function func(descriptor) {"},{"line_number":412,"context_line":"         return \u0027load-balancer/\u0027 + descriptor.balancerId"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_346391df","line":409,"in_reply_to":"1aa78d24_459d04bb","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"df51e304f8d0b4a42ee7cbddb369d27bd7d4499e","unresolved":false,"context_lines":[{"line_number":430,"context_line":"       ```"},{"line_number":431,"context_line":"       var path \u003d resourceType.detailsPath({id: 12, balancerId: \u0027abasefasdf\u0027});"},{"line_number":432,"context_line":"       ```"},{"line_number":433,"context_line":"       TODO this doesn\u0027t make sense based on the default implementation"},{"line_number":434,"context_line":"       */"},{"line_number":435,"context_line":"      function detailsPath(spec) {"},{"line_number":436,"context_line":"        return spec;"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_8ba50db7","line":433,"range":{"start_line":433,"start_character":7,"end_line":433,"end_character":71},"updated":"2016-07-01 22:22:20.000000000","message":"TODO","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"c251c950f4785a9f12136e97958231689e44a9fe","unresolved":false,"context_lines":[{"line_number":430,"context_line":"       ```"},{"line_number":431,"context_line":"       var path \u003d resourceType.detailsPath({id: 12, balancerId: \u0027abasefasdf\u0027});"},{"line_number":432,"context_line":"       ```"},{"line_number":433,"context_line":"       TODO this doesn\u0027t make sense based on the default implementation"},{"line_number":434,"context_line":"       */"},{"line_number":435,"context_line":"      function detailsPath(spec) {"},{"line_number":436,"context_line":"        return spec;"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_d06f5ec3","line":433,"range":{"start_line":433,"start_character":7,"end_line":433,"end_character":71},"in_reply_to":"1aa78d24_8ba50db7","updated":"2016-07-05 13:10:16.000000000","message":"So, this boils down to the serialization/deserialization.  Before I didn\u0027t describe it as a Details Path because it isn\u0027t a details path.  It\u0027s a partial-URL representation of an object identifier.  It\u0027s not meant to be a full path to a details view, because several different views could want such serialization/deserialization.  By changing it to \u0027detailsPath\u0027 it\u0027s getting very specific in its intent, and isn\u0027t really an accurate description.\n\nidentifierToPartialUrl and PartialUrlToIdentifier are probably the \u0027most accurate\u0027 names fors these functions, though they also might confuse people.\n\nDo we need a quick meeting to settle what to name the serialization/deserialization functions?","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":430,"context_line":"       ```"},{"line_number":431,"context_line":"       var path \u003d resourceType.detailsPath({id: 12, balancerId: \u0027abasefasdf\u0027});"},{"line_number":432,"context_line":"       ```"},{"line_number":433,"context_line":"       TODO this doesn\u0027t make sense based on the default implementation"},{"line_number":434,"context_line":"       */"},{"line_number":435,"context_line":"      function detailsPath(spec) {"},{"line_number":436,"context_line":"        return spec;"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_94ab6575","line":433,"range":{"start_line":433,"start_character":7,"end_line":433,"end_character":71},"in_reply_to":"1aa78d24_d06f5ec3","updated":"2016-07-13 20:02:35.000000000","message":"Yep we need to talk about this some more :-)","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":519,"context_line":"       *"},{"line_number":520,"context_line":"       * @example"},{"line_number":521,"context_line":"       ```"},{"line_number":522,"context_line":"       var name \u003d resourceType.propLabel(\u0027disk_format\u0027); // Yields \u0027Disk Format\u0027"},{"line_number":523,"context_line":"       ```"},{"line_number":524,"context_line":"       */"},{"line_number":525,"context_line":"      function label(name) {"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_c5745469","line":522,"updated":"2016-07-12 23:44:19.000000000","message":"resourceType.label(\u0027disk_format\u0027)\n\nthere is no propLabel","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":519,"context_line":"       *"},{"line_number":520,"context_line":"       * @example"},{"line_number":521,"context_line":"       ```"},{"line_number":522,"context_line":"       var name \u003d resourceType.propLabel(\u0027disk_format\u0027); // Yields \u0027Disk Format\u0027"},{"line_number":523,"context_line":"       ```"},{"line_number":524,"context_line":"       */"},{"line_number":525,"context_line":"      function label(name) {"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_d4b32deb","line":522,"in_reply_to":"1aa78d24_c5745469","updated":"2016-07-13 20:02:35.000000000","message":"Done","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":539,"context_line":"       * The formatting is determined by evaluating various options on the"},{"line_number":540,"context_line":"       * property."},{"line_number":541,"context_line":"       *"},{"line_number":542,"context_line":"       * \u0027value_function\u0027 provides a single or a list of functions that will"},{"line_number":543,"context_line":"       * evaluate the source value as input and return output; or in the case"},{"line_number":544,"context_line":"       * of multiple functions, will chain the output of one to the input of"},{"line_number":545,"context_line":"       * the next."}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_c54d743f","line":542,"updated":"2016-07-12 23:44:19.000000000","message":"fix based on Travis\u0027s comment","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":539,"context_line":"       * The formatting is determined by evaluating various options on the"},{"line_number":540,"context_line":"       * property."},{"line_number":541,"context_line":"       *"},{"line_number":542,"context_line":"       * \u0027value_function\u0027 provides a single or a list of functions that will"},{"line_number":543,"context_line":"       * evaluate the source value as input and return output; or in the case"},{"line_number":544,"context_line":"       * of multiple functions, will chain the output of one to the input of"},{"line_number":545,"context_line":"       * the next."}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_94c24533","line":542,"in_reply_to":"1aa78d24_c54d743f","updated":"2016-07-13 20:02:35.000000000","message":".format() is being removed entirely.","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"2aff461f5dee5413234bec3db45bc19dd6a0deee","unresolved":false,"context_lines":[{"line_number":544,"context_line":"       * of multiple functions, will chain the output of one to the input of"},{"line_number":545,"context_line":"       * the next."},{"line_number":546,"context_line":"       *"},{"line_number":547,"context_line":"       * \u0027value_mapping\u0027 provides a hash where, if a matching key is found,"},{"line_number":548,"context_line":"       * the value is returned.  If no matching key is found, then if"},{"line_number":549,"context_line":"       * \u0027value_mapping_default_function\u0027 is present, the value is passed"},{"line_number":550,"context_line":"       * to the function and the result is returned.  Finally, if there was"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_a548282e","line":547,"updated":"2016-07-12 23:44:19.000000000","message":"ditto","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"7a138b6e135c165802a8b04b3035677a684c189c","unresolved":false,"context_lines":[{"line_number":544,"context_line":"       * of multiple functions, will chain the output of one to the input of"},{"line_number":545,"context_line":"       * the next."},{"line_number":546,"context_line":"       *"},{"line_number":547,"context_line":"       * \u0027value_mapping\u0027 provides a hash where, if a matching key is found,"},{"line_number":548,"context_line":"       * the value is returned.  If no matching key is found, then if"},{"line_number":549,"context_line":"       * \u0027value_mapping_default_function\u0027 is present, the value is passed"},{"line_number":550,"context_line":"       * to the function and the result is returned.  Finally, if there was"}],"source_content_type":"text/javascript","patch_set":11,"id":"1aa78d24_d4da0d1d","line":547,"in_reply_to":"1aa78d24_a548282e","updated":"2016-07-13 20:02:35.000000000","message":"as above.","commit_id":"a1cdc7154777f0c469894b8f2ea11221e9300ca4"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"89066091ba745804a1eb95bdb9f52df197c62d5d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"       * filterFacets - filter facets registered here may be used in a \u003cmagic-search\u003e"},{"line_number":91,"context_line":"       *   bar."},{"line_number":92,"context_line":"       *"},{"line_number":93,"context_line":"       * Actions may perform post-config (in the angular sense) initialization by"},{"line_number":94,"context_line":"       * providing an initScope method which can be invoked using initActions() on the"},{"line_number":95,"context_line":"       * ResourceType. Actions should not perform complex actions in their"},{"line_number":96,"context_line":"       * construction, for example API calls, because as injectables their constructor"},{"line_number":97,"context_line":"       * is run during injection, meaning API calls would be executed as the module"},{"line_number":98,"context_line":"       * is initialized.  This would mean those calls would be executed on any"},{"line_number":99,"context_line":"       * Angular context initialization, such as going to the login page."},{"line_number":100,"context_line":"       *"},{"line_number":101,"context_line":"       *"},{"line_number":102,"context_line":"       * Path generation and parsing is used to enable identification and retrieval"},{"line_number":103,"context_line":"       * of resource items from URL fragments (subpaths). The path will commonly be"}],"source_content_type":"text/javascript","patch_set":13,"id":"1aa78d24_72716e77","line":100,"range":{"start_line":93,"start_character":8,"end_line":100,"end_character":8},"updated":"2016-07-14 21:13:56.000000000","message":"Not opposed to this being here, but if not on the actions documentation themselves, this should also be copied there.","commit_id":"6ef42baa27af95fd426de38f38cb649744932e8e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"61fffedc11776673aa5684c2802f5835361b95a6","unresolved":false,"context_lines":[{"line_number":97,"context_line":"       * is run during injection, meaning API calls would be executed as the module"},{"line_number":98,"context_line":"       * is initialized.  This would mean those calls would be executed on any"},{"line_number":99,"context_line":"       * Angular context initialization, such as going to the login page."},{"line_number":100,"context_line":"       *"},{"line_number":101,"context_line":"       *"},{"line_number":102,"context_line":"       * Path generation and parsing is used to enable identification and retrieval"},{"line_number":103,"context_line":"       * of resource items from URL fragments (subpaths). The path will commonly be"}],"source_content_type":"text/javascript","patch_set":13,"id":"1aa78d24_78530d6d","line":100,"in_reply_to":"1aa78d24_72716e77","updated":"2016-07-14 21:51:47.000000000","message":"Yep, this belongs over on the actions (there\u0027s enough information in this doc on the initActions() method).","commit_id":"6ef42baa27af95fd426de38f38cb649744932e8e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"89066091ba745804a1eb95bdb9f52df197c62d5d","unresolved":false,"context_lines":[{"line_number":99,"context_line":"       * Angular context initialization, such as going to the login page."},{"line_number":100,"context_line":"       *"},{"line_number":101,"context_line":"       *"},{"line_number":102,"context_line":"       * Path generation and parsing is used to enable identification and retrieval"},{"line_number":103,"context_line":"       * of resource items from URL fragments (subpaths). The path will commonly be"},{"line_number":104,"context_line":"       * used as part of a details route, and in most cases will consist of just"},{"line_number":105,"context_line":"       * the item\u0027s id. For example an item with identifier of \u0027abc-defg\u0027 would"},{"line_number":106,"context_line":"       * yield a subpath \u0027abc-defg\u0027 which could be used in a details route,"},{"line_number":107,"context_line":"       * such as: \u0027/details/OS::Glance::Image/abc-defg\u0027. See parsePath() and path()"},{"line_number":108,"context_line":"       * for more information."},{"line_number":109,"context_line":"       */"},{"line_number":110,"context_line":"      var self \u003d this;    // disambiguate uses of \"this\" later in this code"},{"line_number":111,"context_line":""}],"source_content_type":"text/javascript","patch_set":13,"id":"1aa78d24_d2bdc268","line":108,"range":{"start_line":102,"start_character":0,"end_line":108,"end_character":30},"updated":"2016-07-14 21:13:56.000000000","message":"why is this here and not down with the patch functions?","commit_id":"6ef42baa27af95fd426de38f38cb649744932e8e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"61fffedc11776673aa5684c2802f5835361b95a6","unresolved":false,"context_lines":[{"line_number":105,"context_line":"       * the item\u0027s id. For example an item with identifier of \u0027abc-defg\u0027 would"},{"line_number":106,"context_line":"       * yield a subpath \u0027abc-defg\u0027 which could be used in a details route,"},{"line_number":107,"context_line":"       * such as: \u0027/details/OS::Glance::Image/abc-defg\u0027. See parsePath() and path()"},{"line_number":108,"context_line":"       * for more information."},{"line_number":109,"context_line":"       */"},{"line_number":110,"context_line":"      var self \u003d this;    // disambiguate uses of \"this\" later in this code"},{"line_number":111,"context_line":""}],"source_content_type":"text/javascript","patch_set":13,"id":"1aa78d24_fd29aff3","line":108,"in_reply_to":"1aa78d24_d2bdc268","updated":"2016-07-14 21:51:47.000000000","message":"Agreed.","commit_id":"6ef42baa27af95fd426de38f38cb649744932e8e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"89066091ba745804a1eb95bdb9f52df197c62d5d","unresolved":false,"context_lines":[{"line_number":211,"context_line":"       * Sets the list() function that returns a promise, that resolves with a list"},{"line_number":212,"context_line":"       * of all the items of a given type."},{"line_number":213,"context_line":"       *"},{"line_number":214,"context_line":"       * The function will be called with parameters provided by magic"},{"line_number":215,"context_line":"       * search facets. This will be an object with keys based on the filterFacets"},{"line_number":216,"context_line":"       * define on the resourceType and values entered by the user into the"},{"line_number":217,"context_line":"       * magic search field."},{"line_number":218,"context_line":"       *"},{"line_number":219,"context_line":"       * @example"},{"line_number":220,"context_line":"       ```"}],"source_content_type":"text/javascript","patch_set":13,"id":"1aa78d24_12846a09","line":217,"range":{"start_line":214,"start_character":9,"end_line":217,"end_character":28},"updated":"2016-07-14 21:13:56.000000000","message":"This is only true when this is used with hz-resource-table.  However, for users that simply get the resource type and ask for the list function this sentence doesn\u0027t make much sense.  I think you should note that this only applies when being named with hz-resource-table.","commit_id":"6ef42baa27af95fd426de38f38cb649744932e8e"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"61fffedc11776673aa5684c2802f5835361b95a6","unresolved":false,"context_lines":[{"line_number":214,"context_line":"       * The function will be called with parameters provided by magic"},{"line_number":215,"context_line":"       * search facets. This will be an object with keys based on the filterFacets"},{"line_number":216,"context_line":"       * define on the resourceType and values entered by the user into the"},{"line_number":217,"context_line":"       * magic search field."},{"line_number":218,"context_line":"       *"},{"line_number":219,"context_line":"       * @example"},{"line_number":220,"context_line":"       ```"}],"source_content_type":"text/javascript","patch_set":13,"id":"1aa78d24_f8c53d0a","line":217,"in_reply_to":"1aa78d24_12846a09","updated":"2016-07-14 21:51:47.000000000","message":"I\u0027ve had a crack at making this clearer.","commit_id":"6ef42baa27af95fd426de38f38cb649744932e8e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"89066091ba745804a1eb95bdb9f52df197c62d5d","unresolved":false,"context_lines":[{"line_number":295,"context_line":"       function func(path) {"},{"line_number":296,"context_line":"         return path.replace(\u0027-\u0027, \u0027\u0027);"},{"line_number":297,"context_line":"       }"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"       var descriptor \u003d resourceType.parsePath(path);"},{"line_number":300,"context_line":"       var item \u003d resourceType.load(descriptor);"},{"line_number":301,"context_line":"       ```"}],"source_content_type":"text/javascript","patch_set":13,"id":"1aa78d24_120e2a8c","line":298,"updated":"2016-07-14 21:13:56.000000000","message":"It would be very helpful to have an example of what the \"path\" input here looks like.\n\njust put it in a comment (// inline)","commit_id":"6ef42baa27af95fd426de38f38cb649744932e8e"},{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"89066091ba745804a1eb95bdb9f52df197c62d5d","unresolved":false,"context_lines":[{"line_number":296,"context_line":"         return path.replace(\u0027-\u0027, \u0027\u0027);"},{"line_number":297,"context_line":"       }"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"       var descriptor \u003d resourceType.parsePath(path);"},{"line_number":300,"context_line":"       var item \u003d resourceType.load(descriptor);"},{"line_number":301,"context_line":"       ```"},{"line_number":302,"context_line":"       */"}],"source_content_type":"text/javascript","patch_set":13,"id":"1aa78d24_92f69a5b","line":299,"updated":"2016-07-14 21:13:56.000000000","message":"With an example of what descriptor looks like here.","commit_id":"6ef42baa27af95fd426de38f38cb649744932e8e"}],"horizon/static/framework/conf/resource-type-registry.service.spec.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"b34e90d7ba74025cda8ecf1a6f546ac4ce25fc7f","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        expect(value).toBe(value2);"},{"line_number":61,"context_line":"      });"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"      it(\u0027can set names on creation\u0027, function() {"},{"line_number":64,"context_line":"        var names \u003d [\u0027Image\u0027, \u0027Images\u0027];"},{"line_number":65,"context_line":"        var value \u003d service.getResourceType(\u0027something\u0027, {names: names});"},{"line_number":66,"context_line":"        expect(value.names).toEqual(names);"},{"line_number":67,"context_line":"      });"},{"line_number":68,"context_line":"    });"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    it(\u0027get/setDefaultDetailsTemplateUrl sets/retrieves a URL\u0027, function() {"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_94279eb4","line":67,"range":{"start_line":63,"start_character":0,"end_line":67,"end_character":9},"updated":"2016-06-16 13:31:48.000000000","message":"This method of setting a configuration via a second parameter in getResourceType() has gone away.","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"afb440a4136d31a1810e931d3842dc60c11fbdab","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        var names \u003d [\u0027Image\u0027, \u0027Images\u0027];"},{"line_number":65,"context_line":"        var value \u003d service.getResourceType(\u0027something\u0027, {names: names});"},{"line_number":66,"context_line":"        expect(value.names).toEqual(names);"},{"line_number":67,"context_line":"      });"},{"line_number":68,"context_line":"    });"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    it(\u0027get/setDefaultDetailsTemplateUrl sets/retrieves a URL\u0027, function() {"}],"source_content_type":"text/javascript","patch_set":6,"id":"7aa08908_9bb85077","line":67,"in_reply_to":"7aa08908_94279eb4","updated":"2016-06-16 23:23:46.000000000","message":"Done","commit_id":"2001fd33bfaad7be64c125e9596e115a0887690f"}],"horizon/static/framework/widgets/action-list/actions.directive.js":[{"author":{"_account_id":7665,"name":"Travis Tripp","email":"os.travis.tripp@gmail.com","username":"travis.tripp"},"change_message_id":"25a05db6b730025ac1e79b3b0b8edbfc82e32e17","unresolved":false,"context_lines":[{"line_number":143,"context_line":"   * var createService \u003d {"},{"line_number":144,"context_line":"   *   allowed: function() {"},{"line_number":145,"context_line":"   *     return $q.all("},{"line_number":146,"context_line":"   *       policy.ifAllowed({ rules: [[\u0027image\u0027, \u0027add_image\u0027]] }),"},{"line_number":147,"context_line":"   *       imageServiceEnabledPromise"},{"line_number":148,"context_line":"   *     );"},{"line_number":149,"context_line":"   *   },"}],"source_content_type":"text/javascript","patch_set":14,"id":"1aa78d24_2c85cace","line":146,"updated":"2016-07-14 22:11:47.000000000","message":"I\u0027d get rid of showing the policy check in the allowed here as well. It shows a non-best practice (as does line 129) above. Policy checks only have to be performed once for the lifetime of the action unless the policy takes dynamic input.  The following would be a better example to show here because it contains both 1 time eval functions and per item eval functions:\n\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/images/actions/edit.action.service.js#L77-L88","commit_id":"8b14f8b2e65ceb167e055c8f03e8d3359d09cc88"},{"author":{"_account_id":12071,"name":"Richard Jones","email":"r1chardj0n3s@gmail.com","username":"richard"},"change_message_id":"49c39efc920008c87c7fe2e870d37e128a5acf7a","unresolved":false,"context_lines":[{"line_number":143,"context_line":"   * var createService \u003d {"},{"line_number":144,"context_line":"   *   allowed: function() {"},{"line_number":145,"context_line":"   *     return $q.all("},{"line_number":146,"context_line":"   *       policy.ifAllowed({ rules: [[\u0027image\u0027, \u0027add_image\u0027]] }),"},{"line_number":147,"context_line":"   *       imageServiceEnabledPromise"},{"line_number":148,"context_line":"   *     );"},{"line_number":149,"context_line":"   *   },"}],"source_content_type":"text/javascript","patch_set":14,"id":"1aa78d24_2fdf7c3b","line":146,"in_reply_to":"1aa78d24_2c85cace","updated":"2016-07-14 22:24:03.000000000","message":"Done","commit_id":"8b14f8b2e65ceb167e055c8f03e8d3359d09cc88"}],"openstack_dashboard/static/app/core/images/table/images.controller.js":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"c8994bb4269ea02a6926db0853b78802cb3b947d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"  ) {"},{"line_number":69,"context_line":"    var ctrl \u003d this;"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    ctrl.detailsRoute \u003d detailsRoute;"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    ctrl.checked \u003d {};"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    ctrl.metadataDefs \u003d null;"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    ctrl.imageResourceType \u003d typeRegistry.getResourceType(imageResourceType);"},{"line_number":78,"context_line":"    ctrl.actionResultHandler \u003d actionResultHandler;"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    ctrl.imageResourceType.initActions($scope);"},{"line_number":81,"context_line":"    init();"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    ////////////////////////////////"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    function init() {"},{"line_number":86,"context_line":"      // if user has permission"},{"line_number":87,"context_line":"      // fetch table data and populate it"},{"line_number":88,"context_line":"      ctrl.images \u003d [];"},{"line_number":89,"context_line":"      ctrl.imagesSrc \u003d [];"},{"line_number":90,"context_line":"      var rules \u003d [[\u0027image\u0027, \u0027get_images\u0027]];"},{"line_number":91,"context_line":"      policy.ifAllowed({ rules: rules }).then(loadImages, policyFailed);"},{"line_number":92,"context_line":"    }"},{"line_number":93,"context_line":""}],"source_content_type":"text/javascript","patch_set":9,"id":"3aaa91ec_1cd753c0","line":90,"range":{"start_line":71,"start_character":6,"end_line":90,"end_character":44},"updated":"2016-06-22 20:15:14.000000000","message":"This is the merge conflict source...I removed this file.","commit_id":"4ac16d5999844001f73c4e9188dff66973b1c6c8"}]}
