)]}'
{"openstack_dashboard/dashboards/admin/networks/ports/forms.py":[{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"8758a7de936db8f10a803314a6defa12212218db","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        required\u003dFalse)"},{"line_number":62,"context_line":"    subnet_id \u003d forms.ChoiceField(label\u003d_(\"Subnet\"),"},{"line_number":63,"context_line":"                                  required\u003dFalse,"},{"line_number":64,"context_line":"                                  help_text\u003d_(\"In case of using spcific IP \""},{"line_number":65,"context_line":"                                              \"address, select using subnet\"),"},{"line_number":66,"context_line":"                                  widget\u003dforms.Select(attrs\u003d{"},{"line_number":67,"context_line":"                                      \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":68,"context_line":"                                      \u0027data-slug\u0027: \u0027source\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_439a966f","line":65,"range":{"start_line":64,"start_character":46,"end_line":65,"end_character":76},"updated":"2016-06-10 15:40:30.000000000","message":"Wouldn\u0027t be better to change this for something like: \"To specify a fixed IP, select a subnet\"","commit_id":"ead089b5f692d21abaf604ce32b4e771be78589a"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"c5a2aa93fa48767ec7a2dc4b5d2fbf8c60b0d806","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        required\u003dFalse)"},{"line_number":62,"context_line":"    subnet_id \u003d forms.ChoiceField(label\u003d_(\"Subnet\"),"},{"line_number":63,"context_line":"                                  required\u003dFalse,"},{"line_number":64,"context_line":"                                  help_text\u003d_(\"In case of using spcific IP \""},{"line_number":65,"context_line":"                                              \"address, select using subnet\"),"},{"line_number":66,"context_line":"                                  widget\u003dforms.Select(attrs\u003d{"},{"line_number":67,"context_line":"                                      \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":68,"context_line":"                                      \u0027data-slug\u0027: \u0027source\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_98415d66","line":65,"range":{"start_line":64,"start_character":46,"end_line":65,"end_character":76},"in_reply_to":"7aa08908_439a966f","updated":"2016-06-13 03:05:23.000000000","message":"Done","commit_id":"ead089b5f692d21abaf604ce32b4e771be78589a"},{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"8758a7de936db8f10a803314a6defa12212218db","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    fixed_ips \u003d forms.IPField(label\u003d_(\"Fixed IP Address\"),"},{"line_number":72,"context_line":"                              required\u003dFalse,"},{"line_number":73,"context_line":"                              help_text\u003d_(\"Specify IP address for new port\"),"},{"line_number":74,"context_line":"                              widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":75,"context_line":"                                  \u0027class\u0027: \u0027switched\u0027,"},{"line_number":76,"context_line":"                                  \u0027data-switch-on\u0027: \u0027source\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_0e1b951d","line":73,"range":{"start_line":73,"start_character":43,"end_line":73,"end_character":74},"updated":"2016-06-10 15:40:30.000000000","message":"maybe change this for something like: \"Specify the subnet IP address for the new port\"  ?","commit_id":"ead089b5f692d21abaf604ce32b4e771be78589a"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"c5a2aa93fa48767ec7a2dc4b5d2fbf8c60b0d806","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    fixed_ips \u003d forms.IPField(label\u003d_(\"Fixed IP Address\"),"},{"line_number":72,"context_line":"                              required\u003dFalse,"},{"line_number":73,"context_line":"                              help_text\u003d_(\"Specify IP address for new port\"),"},{"line_number":74,"context_line":"                              widget\u003dforms.TextInput(attrs\u003d{"},{"line_number":75,"context_line":"                                  \u0027class\u0027: \u0027switched\u0027,"},{"line_number":76,"context_line":"                                  \u0027data-switch-on\u0027: \u0027source\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_f34fe231","line":73,"range":{"start_line":73,"start_character":43,"end_line":73,"end_character":74},"in_reply_to":"7aa08908_0e1b951d","updated":"2016-06-13 03:05:23.000000000","message":"Done","commit_id":"ead089b5f692d21abaf604ce32b4e771be78589a"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"d12d8101c2c163cbc2642544e054e141682e7297","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            data[\u0027tenant_id\u0027] \u003d network.tenant_id"},{"line_number":153,"context_line":"            data[\u0027admin_state_up\u0027] \u003d (data[\u0027admin_state\u0027] \u003d\u003d \u0027True\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            if \u0027subnet_id\u0027 in data and data[\u0027subnet_id\u0027] !\u003d \u0027\u0027 and \\"},{"line_number":156,"context_line":"               \u0027fixed_ips\u0027 in data and data[\u0027fixed_ips\u0027]:"},{"line_number":157,"context_line":"                data[\u0027fixed_ips\u0027] \u003d [{\"subnet_id\": data[\u0027subnet_id\u0027],"},{"line_number":158,"context_line":"                                      \"ip_address\": data[\u0027fixed_ips\u0027]}]"},{"line_number":159,"context_line":"            else:"},{"line_number":160,"context_line":"                if \u0027fixed_ips\u0027 in data:"},{"line_number":161,"context_line":"                    del data[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7aa08908_52d07453","line":158,"range":{"start_line":155,"start_character":0,"end_line":158,"end_character":71},"updated":"2016-06-17 10:30:00.000000000","message":"As I know if you supply subnet_id and fixed_ip both when you create a neutron port, you will get a neutron port with two fixed IPs. I don\u0027t think this behavior is what you want. So you should only supply one of subnet_id or ip_address, not both.\nFor instance:\nneutron port-create --fixed-ip subnet_id\u003dba280c8a-c761-407d-bcfe-741dae8a37d3 --fixed-ip ip_address\u003d192.168.111.111 16eca00d-bc1d-4d8d-9580-41856ba33c1b\nCreated a new port:\n+-----------------------+----------------------------------------------------------------------------------------+\n| Field                 | Value                                                                                  |\n+-----------------------+----------------------------------------------------------------------------------------+\n| admin_state_up        | True                                                                                   |\n| allowed_address_pairs |                                                                                        |\n| binding:host_id       |                                                                                        |\n| binding:profile       | {}                                                                                     |\n| binding:vif_details   | {}                                                                                     |\n| binding:vif_type      | unbound                                                                                |\n| binding:vnic_type     | normal                                                                                 |\n| created_at            | 2016-06-17T10:25:01                                                                    |\n| description           |                                                                                        |\n| device_id             |                                                                                        |\n| device_owner          |                                                                                        |\n| dns_name              |                                                                                        |\n| extra_dhcp_opts       |                                                                                        |\n| fixed_ips             | {\"subnet_id\": \"ba280c8a-c761-407d-bcfe-741dae8a37d3\", \"ip_address\": \"192.168.111.111\"} |\n|                       | {\"subnet_id\": \"ba280c8a-c761-407d-bcfe-741dae8a37d3\", \"ip_address\": \"192.168.111.112\"} |\n| id                    | aff2733c-ab76-437f-9957-3ebba5771941                                                   |\n| mac_address           | fa:16:3e:1b:c2:7d                                                                      |\n| name                  |                                                                                        |\n| network_id            | 16eca00d-bc1d-4d8d-9580-41856ba33c1b                                                   |\n| port_security_enabled | True                                                                                   |\n| security_groups       | d3ebbd92-c127-4a7f-b9e9-15fb92c5b781                                                   |\n| status                | DOWN                                                                                   |\n| tenant_id             | 5ff1da9c235c4ebcaefeecf3fff7eb11                                                       |\n| updated_at            | 2016-06-17T10:25:01                                                                    |\n+-----------------------+----------------------------------------------------------------------------------------+","commit_id":"3000ec144d01d7f968a26773984fb91b7a8c1846"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"fe08c90ac4cbcb1378b8900f8529b693620aad5c","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            data[\u0027tenant_id\u0027] \u003d network.tenant_id"},{"line_number":153,"context_line":"            data[\u0027admin_state_up\u0027] \u003d (data[\u0027admin_state\u0027] \u003d\u003d \u0027True\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            if \u0027subnet_id\u0027 in data and data[\u0027subnet_id\u0027] !\u003d \u0027\u0027 and \\"},{"line_number":156,"context_line":"               \u0027fixed_ips\u0027 in data and data[\u0027fixed_ips\u0027]:"},{"line_number":157,"context_line":"                data[\u0027fixed_ips\u0027] \u003d [{\"subnet_id\": data[\u0027subnet_id\u0027],"},{"line_number":158,"context_line":"                                      \"ip_address\": data[\u0027fixed_ips\u0027]}]"},{"line_number":159,"context_line":"            else:"},{"line_number":160,"context_line":"                if \u0027fixed_ips\u0027 in data:"},{"line_number":161,"context_line":"                    del data[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a9d85d2_47113fac","line":158,"range":{"start_line":155,"start_character":0,"end_line":158,"end_character":71},"in_reply_to":"5a9d85d2_01ff2c02","updated":"2016-06-20 11:06:03.000000000","message":"Fine, the request you made here is somthing like this:\n\ncurl -g -i -X POST http://controller:9696/v2.0/ports.json -d \u0027{\"port\": {\"network_id\": \"16eca00d-bc1d-4d8d-9580-41856ba33c1b\", \"fixed_ips\": [{\"subnet_id\": \"ba280c8a-c761-407d-bcfe-741dae8a37d3\"}, {\"ip_address\": \"192.168.111.112\"}], \"admin_state_up\": true}}\u0027\n\nBut, actually, only \u0027{ ... \"fixed_ips\": [{\"ip_address\": \"192.168.111.112\"}] ...\u0027 is needed. The subnet id is redundant in the fixed_ips list.\nIn this port create form, user just need to fill subnet_id or ip_address, not both.\nAnd you can use the subnet_id to check whether the ip_address input is under the CIDR of the chosen subnet. For now, I can do somthing like, chose subnet_a(1.1.1.0/24), but fill ip_address with 2.2.2.2.","commit_id":"3000ec144d01d7f968a26773984fb91b7a8c1846"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"0789accdd7c56a25c9d3fff9d909a7e19f463e1a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            data[\u0027tenant_id\u0027] \u003d network.tenant_id"},{"line_number":153,"context_line":"            data[\u0027admin_state_up\u0027] \u003d (data[\u0027admin_state\u0027] \u003d\u003d \u0027True\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            if \u0027subnet_id\u0027 in data and data[\u0027subnet_id\u0027] !\u003d \u0027\u0027 and \\"},{"line_number":156,"context_line":"               \u0027fixed_ips\u0027 in data and data[\u0027fixed_ips\u0027]:"},{"line_number":157,"context_line":"                data[\u0027fixed_ips\u0027] \u003d [{\"subnet_id\": data[\u0027subnet_id\u0027],"},{"line_number":158,"context_line":"                                      \"ip_address\": data[\u0027fixed_ips\u0027]}]"},{"line_number":159,"context_line":"            else:"},{"line_number":160,"context_line":"                if \u0027fixed_ips\u0027 in data:"},{"line_number":161,"context_line":"                    del data[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a9d85d2_baaaba6e","line":158,"range":{"start_line":155,"start_character":0,"end_line":158,"end_character":71},"in_reply_to":"5a9d85d2_47113fac","updated":"2016-06-20 11:18:14.000000000","message":"Sorry for the inaccurate, after check the neutron log, the request you made here is \u0027... \"fixed_ips\": [{\"subnet_id\": \"xxx-xxx-xxx\", \"ip_address\": \"y.y.y.y\"}] ...\u0027\nAlso redundant of subnet_id.","commit_id":"3000ec144d01d7f968a26773984fb91b7a8c1846"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"62e9b063cd0456b1e0880ab857fb298672c5d06e","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            data[\u0027tenant_id\u0027] \u003d network.tenant_id"},{"line_number":153,"context_line":"            data[\u0027admin_state_up\u0027] \u003d (data[\u0027admin_state\u0027] \u003d\u003d \u0027True\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            if \u0027subnet_id\u0027 in data and data[\u0027subnet_id\u0027] !\u003d \u0027\u0027 and \\"},{"line_number":156,"context_line":"               \u0027fixed_ips\u0027 in data and data[\u0027fixed_ips\u0027]:"},{"line_number":157,"context_line":"                data[\u0027fixed_ips\u0027] \u003d [{\"subnet_id\": data[\u0027subnet_id\u0027],"},{"line_number":158,"context_line":"                                      \"ip_address\": data[\u0027fixed_ips\u0027]}]"},{"line_number":159,"context_line":"            else:"},{"line_number":160,"context_line":"                if \u0027fixed_ips\u0027 in data:"},{"line_number":161,"context_line":"                    del data[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"3aaa91ec_7cb67a8b","line":158,"range":{"start_line":155,"start_character":0,"end_line":158,"end_character":71},"in_reply_to":"5a9d85d2_baaaba6e","updated":"2016-06-22 10:16:53.000000000","message":"I understood! As you say, it is unnecessary to specify both subnet_id and fixed_ip. so I could these implementation simply :)","commit_id":"3000ec144d01d7f968a26773984fb91b7a8c1846"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"c70646d8a6637f5b083366f87ec50718aaddc6c2","unresolved":false,"context_lines":[{"line_number":152,"context_line":"            data[\u0027tenant_id\u0027] \u003d network.tenant_id"},{"line_number":153,"context_line":"            data[\u0027admin_state_up\u0027] \u003d (data[\u0027admin_state\u0027] \u003d\u003d \u0027True\u0027)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"            if \u0027subnet_id\u0027 in data and data[\u0027subnet_id\u0027] !\u003d \u0027\u0027 and \\"},{"line_number":156,"context_line":"               \u0027fixed_ips\u0027 in data and data[\u0027fixed_ips\u0027]:"},{"line_number":157,"context_line":"                data[\u0027fixed_ips\u0027] \u003d [{\"subnet_id\": data[\u0027subnet_id\u0027],"},{"line_number":158,"context_line":"                                      \"ip_address\": data[\u0027fixed_ips\u0027]}]"},{"line_number":159,"context_line":"            else:"},{"line_number":160,"context_line":"                if \u0027fixed_ips\u0027 in data:"},{"line_number":161,"context_line":"                    del data[\u0027fixed_ips\u0027]"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a9d85d2_01ff2c02","line":158,"range":{"start_line":155,"start_character":0,"end_line":158,"end_character":71},"in_reply_to":"7aa08908_52d07453","updated":"2016-06-20 07:31:58.000000000","message":"As you say, when I create a port by neutron cli, two ips were allocated.\nOn the other hand, when I create a port by horizon (using current implementation), result is below.\nIt seems that this result is as expected for me.\nIn this result, if you have any problem, please let me know :)\n\n$ neutron port-show 34c99d51-b942-4531-a70f-3aed5f9f521d\n+-----------------------+----------------------------------------------------------------------------------+\n| Field                 | Value                                                                            |\n+-----------------------+----------------------------------------------------------------------------------+\n| admin_state_up        | True                                                                             |\n| allowed_address_pairs |                                                                                  |\n| binding:host_id       |                                                                                  |\n| binding:profile       | {}                                                                               |\n| binding:vif_details   | {}                                                                               |\n| binding:vif_type      | unbound                                                                          |\n| binding:vnic_type     | normal                                                                           |\n| created_at            | 2016-06-20T07:16:00                                                              |\n| description           |                                                                                  |\n| device_id             |                                                                                  |\n| device_owner          |                                                                                  |\n| extra_dhcp_opts       |                                                                                  |\n| fixed_ips             | {\"subnet_id\": \"e4cc13a5-9d46-453e-8a12-70a9c67b869d\", \"ip_address\": \"10.0.0.50\"} |\n| id                    | 34c99d51-b942-4531-a70f-3aed5f9f521d                                             |\n| mac_address           | fa:16:3e:06:2c:47                                                                |\n| name                  | test_port                                                                        |\n| network_id            | 2361be8f-b5b8-48dc-9b42-9829e75dbd61                                             |\n| port_security_enabled | True                                                                             |\n| qos_policy_id         |                                                                                  |\n| security_groups       | a71f972f-87a0-420e-a22f-c82dbdce912e                                             |\n| status                | DOWN                                                                             |\n| tenant_id             | 3d49c828e03045e7b0dc3193d79d55c3                                                 |\n| updated_at            | 2016-06-20T07:16:00                                                              |\n+-----------------------+----------------------------------------------------------------------------------+","commit_id":"3000ec144d01d7f968a26773984fb91b7a8c1846"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"f5cbad1d9b89bd42ddebc1f9c70ae7d04e547c12","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        help_text\u003d_(\"The ID of the host where the port is allocated. In some \""},{"line_number":59,"context_line":"                    \"cases, different implementations can run on different \""},{"line_number":60,"context_line":"                    \"hosts.\"),"},{"line_number":61,"context_line":"        required\u003dFalse)"},{"line_number":62,"context_line":"    fixed_ips \u003d forms.IPField(label\u003d_(\"Fixed IP Address\"),"},{"line_number":63,"context_line":"                              required\u003dFalse,"},{"line_number":64,"context_line":"                              help_text\u003d_(\"Specify the subnet IP address\""}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_8a8fbe74","line":61,"updated":"2016-07-08 01:59:30.000000000","message":"It\u0027s better to add the subnet choice here. For user, it can indicate which subnet (ip address/ CIDR) can be used. For this patch, it can  help to check the `fixed_ips` input whether under the subnet CIDR. For instance, I choose the subnet-A (192.168.0.0/24), then the `fixed_ips` must be set under that CIDR.","commit_id":"c3f6b37e3681807e80fb87881c6679230e1d189d"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"9f0e75aa0da442d2699795d61f59369f45b677e8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        help_text\u003d_(\"The ID of the host where the port is allocated. In some \""},{"line_number":59,"context_line":"                    \"cases, different implementations can run on different \""},{"line_number":60,"context_line":"                    \"hosts.\"),"},{"line_number":61,"context_line":"        required\u003dFalse)"},{"line_number":62,"context_line":"    fixed_ips \u003d forms.IPField(label\u003d_(\"Fixed IP Address\"),"},{"line_number":63,"context_line":"                              required\u003dFalse,"},{"line_number":64,"context_line":"                              help_text\u003d_(\"Specify the subnet IP address\""}],"source_content_type":"text/x-python","patch_set":10,"id":"1aa78d24_cd2b4e32","line":61,"in_reply_to":"1aa78d24_8a8fbe74","updated":"2016-07-11 04:53:17.000000000","message":"I addressed your comment. In addition, this patch will support not only \u0027fixed_ips\u0027 case but also \u0027subnet_id\u0027 case.\n\ncase 1: When a user doesn\u0027t chose any subnet, process will be same as previous.\ncase 2: When a user only chose subnet, port in subnet which is specified will be created.\ncase 3: When a user chose not only subnet but also fixed_ip, port which is used IP specified by a user will be created.","commit_id":"c3f6b37e3681807e80fb87881c6679230e1d189d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"07a4b1271f6233469613e161f315d04ecdd91342","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    subnet_id \u003d forms.ChoiceField("},{"line_number":63,"context_line":"        label\u003d_(\"Subnet\"),"},{"line_number":64,"context_line":"        required\u003dFalse,"},{"line_number":65,"context_line":"        help_text\u003d_(\"To specify a subnet or a fiexed IP, select a subnet\"),"},{"line_number":66,"context_line":"        widget\u003dforms.Select(attrs\u003d{"},{"line_number":67,"context_line":"                            \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":68,"context_line":"                            \u0027data-slug\u0027: \u0027source\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_a6dfaa38","line":65,"range":{"start_line":65,"start_character":46,"end_line":65,"end_character":52},"updated":"2016-08-02 06:44:02.000000000","message":"-\u003e fixed","commit_id":"554f8765a2d42bc1ae497bfcdbd08dca6767f1f7"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f59b3a66defb85528d4201834c0b92c791e490ce","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    subnet_id \u003d forms.ChoiceField("},{"line_number":63,"context_line":"        label\u003d_(\"Subnet\"),"},{"line_number":64,"context_line":"        required\u003dFalse,"},{"line_number":65,"context_line":"        help_text\u003d_(\"To specify a subnet or a fiexed IP, select a subnet\"),"},{"line_number":66,"context_line":"        widget\u003dforms.Select(attrs\u003d{"},{"line_number":67,"context_line":"                            \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":68,"context_line":"                            \u0027data-slug\u0027: \u0027source\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_3909b7de","line":65,"range":{"start_line":65,"start_character":46,"end_line":65,"end_character":52},"in_reply_to":"bacf61ea_a6dfaa38","updated":"2016-08-03 06:24:06.000000000","message":"Done","commit_id":"554f8765a2d42bc1ae497bfcdbd08dca6767f1f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"07a4b1271f6233469613e161f315d04ecdd91342","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            network_id \u003d kwargs[\u0027initial\u0027][\u0027network_id\u0027]"},{"line_number":135,"context_line":"            subnets \u003d api.neutron.subnet_list(request, network_id\u003dnetwork_id)"},{"line_number":136,"context_line":"            if not subnets:"},{"line_number":137,"context_line":"                self.fields[\u0027fixed_ips\u0027].widget \u003d forms.HiddenInput()"},{"line_number":138,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_c6af3e7b","line":135,"updated":"2016-08-02 06:44:02.000000000","message":"Both L.135 and L.145 retrieves a subnet list for a given network.\nThere is no need to call the API twice. Can you keep the results and reuse it?","commit_id":"554f8765a2d42bc1ae497bfcdbd08dca6767f1f7"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f59b3a66defb85528d4201834c0b92c791e490ce","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        try:"},{"line_number":134,"context_line":"            network_id \u003d kwargs[\u0027initial\u0027][\u0027network_id\u0027]"},{"line_number":135,"context_line":"            subnets \u003d api.neutron.subnet_list(request, network_id\u003dnetwork_id)"},{"line_number":136,"context_line":"            if not subnets:"},{"line_number":137,"context_line":"                self.fields[\u0027fixed_ips\u0027].widget \u003d forms.HiddenInput()"},{"line_number":138,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_61b5357d","line":135,"in_reply_to":"bacf61ea_c6af3e7b","updated":"2016-08-03 06:24:06.000000000","message":"Yes, the L86 condition is same meaning with here\u0027s condition. I\u0027ll integrate.","commit_id":"554f8765a2d42bc1ae497bfcdbd08dca6767f1f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"07a4b1271f6233469613e161f315d04ecdd91342","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            data[\u0027tenant_id\u0027] \u003d network.tenant_id"},{"line_number":159,"context_line":"            data[\u0027admin_state_up\u0027] \u003d (data[\u0027admin_state\u0027] \u003d\u003d \u0027True\u0027)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            if \u0027subnet_id\u0027 in data and data[\u0027subnet_id\u0027] !\u003d \u0027\u0027:"},{"line_number":162,"context_line":"                if \u0027fixed_ips\u0027 in data and data[\u0027fixed_ips\u0027]:"},{"line_number":163,"context_line":"                    data[\u0027fixed_ips\u0027] \u003d [{\"ip_address\": data[\u0027fixed_ips\u0027]}]"},{"line_number":164,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_66665252","line":161,"range":{"start_line":161,"start_character":15,"end_line":161,"end_character":63},"updated":"2016-08-02 06:44:02.000000000","message":"Consider:\n\n  if data.get(\u0027subnet_id\u0027):","commit_id":"554f8765a2d42bc1ae497bfcdbd08dca6767f1f7"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f59b3a66defb85528d4201834c0b92c791e490ce","unresolved":false,"context_lines":[{"line_number":158,"context_line":"            data[\u0027tenant_id\u0027] \u003d network.tenant_id"},{"line_number":159,"context_line":"            data[\u0027admin_state_up\u0027] \u003d (data[\u0027admin_state\u0027] \u003d\u003d \u0027True\u0027)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            if \u0027subnet_id\u0027 in data and data[\u0027subnet_id\u0027] !\u003d \u0027\u0027:"},{"line_number":162,"context_line":"                if \u0027fixed_ips\u0027 in data and data[\u0027fixed_ips\u0027]:"},{"line_number":163,"context_line":"                    data[\u0027fixed_ips\u0027] \u003d [{\"ip_address\": data[\u0027fixed_ips\u0027]}]"},{"line_number":164,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_21785df8","line":161,"range":{"start_line":161,"start_character":15,"end_line":161,"end_character":63},"in_reply_to":"bacf61ea_66665252","updated":"2016-08-03 06:24:06.000000000","message":"Done","commit_id":"554f8765a2d42bc1ae497bfcdbd08dca6767f1f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"07a4b1271f6233469613e161f315d04ecdd91342","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            data[\u0027admin_state_up\u0027] \u003d (data[\u0027admin_state\u0027] \u003d\u003d \u0027True\u0027)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            if \u0027subnet_id\u0027 in data and data[\u0027subnet_id\u0027] !\u003d \u0027\u0027:"},{"line_number":162,"context_line":"                if \u0027fixed_ips\u0027 in data and data[\u0027fixed_ips\u0027]:"},{"line_number":163,"context_line":"                    data[\u0027fixed_ips\u0027] \u003d [{\"ip_address\": data[\u0027fixed_ips\u0027]}]"},{"line_number":164,"context_line":"                else:"},{"line_number":165,"context_line":"                    data[\u0027fixed_ips\u0027] \u003d [{\"subnet_id\": data[\u0027subnet_id\u0027]}]"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_0e594135","line":162,"range":{"start_line":162,"start_character":19,"end_line":162,"end_character":61},"updated":"2016-08-02 06:44:02.000000000","message":"Consider:\n\n  if data.get(\u0027fixed_ips\u0027):","commit_id":"554f8765a2d42bc1ae497bfcdbd08dca6767f1f7"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f59b3a66defb85528d4201834c0b92c791e490ce","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            data[\u0027admin_state_up\u0027] \u003d (data[\u0027admin_state\u0027] \u003d\u003d \u0027True\u0027)"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            if \u0027subnet_id\u0027 in data and data[\u0027subnet_id\u0027] !\u003d \u0027\u0027:"},{"line_number":162,"context_line":"                if \u0027fixed_ips\u0027 in data and data[\u0027fixed_ips\u0027]:"},{"line_number":163,"context_line":"                    data[\u0027fixed_ips\u0027] \u003d [{\"ip_address\": data[\u0027fixed_ips\u0027]}]"},{"line_number":164,"context_line":"                else:"},{"line_number":165,"context_line":"                    data[\u0027fixed_ips\u0027] \u003d [{\"subnet_id\": data[\u0027subnet_id\u0027]}]"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_017d59e7","line":162,"range":{"start_line":162,"start_character":19,"end_line":162,"end_character":61},"in_reply_to":"bacf61ea_0e594135","updated":"2016-08-03 06:24:06.000000000","message":"Done","commit_id":"554f8765a2d42bc1ae497bfcdbd08dca6767f1f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"07a4b1271f6233469613e161f315d04ecdd91342","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                    del data[\u0027fixed_ips\u0027]"},{"line_number":169,"context_line":"            if \u0027subnet_id\u0027 in data:"},{"line_number":170,"context_line":"                del data[\u0027subnet_id\u0027]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"            del data[\u0027network_name\u0027]"},{"line_number":173,"context_line":"            del data[\u0027admin_state\u0027]"},{"line_number":174,"context_line":"            if \u0027mac_state\u0027 in data:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_2ef24506","line":171,"updated":"2016-08-02 06:44:02.000000000","message":"The original code passes \u0027data\u0027 dict to api.neutron.port_create, but I think it forces us to use many \"del data[something]\". How about using a new dict to prepare parameters passed to api.neutron.port_create? I believe it simplifies the code.\n\n  params \u003d {\n      \u0027tenant_id\u0027: network.tenant_id,\n      \u0027network_id\u0027: data[\u0027network_id\u0027],\n      \u0027admin_state_up\u0027: data[\u0027admin_state\u0027] \u003d\u003d True,\n      \u0027name\u0027: ...,\n      \u0027device_id\u0027: ....,\n      \u0027device_owner\u0027: ...,\n  }\n  \u003cyour above logic\u003e","commit_id":"554f8765a2d42bc1ae497bfcdbd08dca6767f1f7"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"f59b3a66defb85528d4201834c0b92c791e490ce","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                    del data[\u0027fixed_ips\u0027]"},{"line_number":169,"context_line":"            if \u0027subnet_id\u0027 in data:"},{"line_number":170,"context_line":"                del data[\u0027subnet_id\u0027]"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"            del data[\u0027network_name\u0027]"},{"line_number":173,"context_line":"            del data[\u0027admin_state\u0027]"},{"line_number":174,"context_line":"            if \u0027mac_state\u0027 in data:"}],"source_content_type":"text/x-python","patch_set":13,"id":"bacf61ea_8422f7ff","line":171,"in_reply_to":"bacf61ea_2ef24506","updated":"2016-08-03 06:24:06.000000000","message":"Done","commit_id":"554f8765a2d42bc1ae497bfcdbd08dca6767f1f7"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"714933bc687e973ec7910c77834a393ede785fd7","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    subnet_id \u003d forms.ChoiceField("},{"line_number":63,"context_line":"        label\u003d_(\"Subnet\"),"},{"line_number":64,"context_line":"        required\u003dFalse,"},{"line_number":65,"context_line":"        help_text\u003d_(\"To specify a subnet or a fixed IP, select a subnet\"),"},{"line_number":66,"context_line":"        widget\u003dforms.Select(attrs\u003d{"},{"line_number":67,"context_line":"                            \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":68,"context_line":"                            \u0027data-slug\u0027: \u0027source\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_ab7b63f3","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":74},"updated":"2016-08-03 17:53:10.000000000","message":"After trying your patch, I found this interface is not so easy to understand. Alternative idea in my mind is to have a checkbox \"Specify IP address or subnet\" and show the subnet and IP address fields.","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6cd29b3e1de1d30ff596cb64d199e4e3d1edcaa2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    subnet_id \u003d forms.ChoiceField("},{"line_number":63,"context_line":"        label\u003d_(\"Subnet\"),"},{"line_number":64,"context_line":"        required\u003dFalse,"},{"line_number":65,"context_line":"        help_text\u003d_(\"To specify a subnet or a fixed IP, select a subnet\"),"},{"line_number":66,"context_line":"        widget\u003dforms.Select(attrs\u003d{"},{"line_number":67,"context_line":"                            \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":68,"context_line":"                            \u0027data-slug\u0027: \u0027source\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_7dbc746c","line":65,"range":{"start_line":65,"start_character":8,"end_line":65,"end_character":74},"in_reply_to":"bacf61ea_ab7b63f3","updated":"2016-08-04 07:48:58.000000000","message":"Done.\n\nAlso, I considered the case that it uses ChoiceField like \u0027No specify\u0027, \u0027Subnet\u0027, \u0027Fixed IP\u0027. Then if a user specify \u0027subnet\u0027, only subnet field will appear. \u0027Fixed IP\u0027 case is also same. \nCheckbox and Choice, both are good for a user.\nIf you think it\u0027s better to you latter, I\u0027ll change the patch. Thanks :)","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"714933bc687e973ec7910c77834a393ede785fd7","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        help_text\u003d_(\"To specify a subnet or a fixed IP, select a subnet\"),"},{"line_number":66,"context_line":"        widget\u003dforms.Select(attrs\u003d{"},{"line_number":67,"context_line":"                            \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":68,"context_line":"                            \u0027data-slug\u0027: \u0027source\u0027,"},{"line_number":69,"context_line":"                            }))"},{"line_number":70,"context_line":"    fixed_ips \u003d forms.IPField("},{"line_number":71,"context_line":"        label\u003d_(\"Fixed IP Address\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_ebd39bd3","line":68,"range":{"start_line":68,"start_character":41,"end_line":68,"end_character":50},"updated":"2016-08-03 17:53:10.000000000","message":"It is better to use more meaningful name. Why do you use \u0027source\u0027 for subnet?","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6cd29b3e1de1d30ff596cb64d199e4e3d1edcaa2","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        help_text\u003d_(\"To specify a subnet or a fixed IP, select a subnet\"),"},{"line_number":66,"context_line":"        widget\u003dforms.Select(attrs\u003d{"},{"line_number":67,"context_line":"                            \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":68,"context_line":"                            \u0027data-slug\u0027: \u0027source\u0027,"},{"line_number":69,"context_line":"                            }))"},{"line_number":70,"context_line":"    fixed_ips \u003d forms.IPField("},{"line_number":71,"context_line":"        label\u003d_(\"Fixed IP Address\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_332193fc","line":68,"range":{"start_line":68,"start_character":41,"end_line":68,"end_character":50},"in_reply_to":"bacf61ea_ebd39bd3","updated":"2016-08-04 07:48:58.000000000","message":"Done","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"714933bc687e973ec7910c77834a393ede785fd7","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                            \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":68,"context_line":"                            \u0027data-slug\u0027: \u0027source\u0027,"},{"line_number":69,"context_line":"                            }))"},{"line_number":70,"context_line":"    fixed_ips \u003d forms.IPField("},{"line_number":71,"context_line":"        label\u003d_(\"Fixed IP Address\"),"},{"line_number":72,"context_line":"        required\u003dFalse,"},{"line_number":73,"context_line":"        help_text\u003d_(\"Specify the subnet IP address for the new port\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_2bfdb33b","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":13},"updated":"2016-08-03 17:53:10.000000000","message":"Why plural case? This field takes a single IP address.","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6cd29b3e1de1d30ff596cb64d199e4e3d1edcaa2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                            \u0027class\u0027: \u0027switchable\u0027,"},{"line_number":68,"context_line":"                            \u0027data-slug\u0027: \u0027source\u0027,"},{"line_number":69,"context_line":"                            }))"},{"line_number":70,"context_line":"    fixed_ips \u003d forms.IPField("},{"line_number":71,"context_line":"        label\u003d_(\"Fixed IP Address\"),"},{"line_number":72,"context_line":"        required\u003dFalse,"},{"line_number":73,"context_line":"        help_text\u003d_(\"Specify the subnet IP address for the new port\"),"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_5dbff05f","line":70,"range":{"start_line":70,"start_character":4,"end_line":70,"end_character":13},"in_reply_to":"bacf61ea_2bfdb33b","updated":"2016-08-04 07:48:58.000000000","message":"Done","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"714933bc687e973ec7910c77834a393ede785fd7","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # prepare subnet choices and input area for each subnet"},{"line_number":85,"context_line":"        subnet_choices \u003d self._get_subnet_choices(kwargs[\u0027initial\u0027])"},{"line_number":86,"context_line":"        if len(subnet_choices) \u003e 1:"},{"line_number":87,"context_line":"            self.fields[\u0027subnet_id\u0027].choices \u003d subnet_choices"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            for (id, name) in subnet_choices:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_36f996c9","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":35},"updated":"2016-08-03 17:53:10.000000000","message":"If my comment at L.135 is applied, this logic would be:\n\n  if subnet_choices:\n     subnet_choices.insert((\u0027\u0027, _(\"Select a subnet\"))\n     self.fields[\u0027subnet_id\u0027].choices \u003d subnet_choices\n     for id, name in subnet_choices:\n         self.fields[\u0027fixed_ips\u0027].....\n  else:\n     ...","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6cd29b3e1de1d30ff596cb64d199e4e3d1edcaa2","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        # prepare subnet choices and input area for each subnet"},{"line_number":85,"context_line":"        subnet_choices \u003d self._get_subnet_choices(kwargs[\u0027initial\u0027])"},{"line_number":86,"context_line":"        if len(subnet_choices) \u003e 1:"},{"line_number":87,"context_line":"            self.fields[\u0027subnet_id\u0027].choices \u003d subnet_choices"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            for (id, name) in subnet_choices:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_bdb6ec87","line":86,"range":{"start_line":86,"start_character":8,"end_line":86,"end_character":35},"in_reply_to":"bacf61ea_36f996c9","updated":"2016-08-04 07:48:58.000000000","message":"Done","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"714933bc687e973ec7910c77834a393ede785fd7","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if len(subnet_choices) \u003e 1:"},{"line_number":87,"context_line":"            self.fields[\u0027subnet_id\u0027].choices \u003d subnet_choices"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            for (id, name) in subnet_choices:"},{"line_number":90,"context_line":"                if not len(id):"},{"line_number":91,"context_line":"                    continue"},{"line_number":92,"context_line":"                self.fields[\u0027fixed_ips\u0027].widget.attrs[\u0027data-source-\u0027 + id] \u003d \\"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_76030eb9","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":26},"updated":"2016-08-03 17:53:10.000000000","message":"Parenthese are unnecessary.","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6cd29b3e1de1d30ff596cb64d199e4e3d1edcaa2","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if len(subnet_choices) \u003e 1:"},{"line_number":87,"context_line":"            self.fields[\u0027subnet_id\u0027].choices \u003d subnet_choices"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            for (id, name) in subnet_choices:"},{"line_number":90,"context_line":"                if not len(id):"},{"line_number":91,"context_line":"                    continue"},{"line_number":92,"context_line":"                self.fields[\u0027fixed_ips\u0027].widget.attrs[\u0027data-source-\u0027 + id] \u003d \\"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_9db9687c","line":89,"range":{"start_line":89,"start_character":16,"end_line":89,"end_character":26},"in_reply_to":"bacf61ea_76030eb9","updated":"2016-08-04 07:48:58.000000000","message":"Done","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"714933bc687e973ec7910c77834a393ede785fd7","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            self.fields[\u0027subnet_id\u0027].choices \u003d subnet_choices"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            for (id, name) in subnet_choices:"},{"line_number":90,"context_line":"                if not len(id):"},{"line_number":91,"context_line":"                    continue"},{"line_number":92,"context_line":"                self.fields[\u0027fixed_ips\u0027].widget.attrs[\u0027data-source-\u0027 + id] \u003d \\"},{"line_number":93,"context_line":"                    _(\u0027Fixed IP Address\u0027)"},{"line_number":94,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_36207649","line":91,"range":{"start_line":90,"start_character":16,"end_line":91,"end_character":28},"updated":"2016-08-03 17:53:10.000000000","message":"If you follow my above comment, this will be unnecessary.","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6cd29b3e1de1d30ff596cb64d199e4e3d1edcaa2","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            self.fields[\u0027subnet_id\u0027].choices \u003d subnet_choices"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"            for (id, name) in subnet_choices:"},{"line_number":90,"context_line":"                if not len(id):"},{"line_number":91,"context_line":"                    continue"},{"line_number":92,"context_line":"                self.fields[\u0027fixed_ips\u0027].widget.attrs[\u0027data-source-\u0027 + id] \u003d \\"},{"line_number":93,"context_line":"                    _(\u0027Fixed IP Address\u0027)"},{"line_number":94,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_3dab1c1f","line":91,"range":{"start_line":90,"start_character":16,"end_line":91,"end_character":28},"in_reply_to":"bacf61ea_36207649","updated":"2016-08-04 07:48:58.000000000","message":"Done","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"714933bc687e973ec7910c77834a393ede785fd7","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            exceptions.handle(self.request, msg)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def _get_subnet_choices(self, kwargs):"},{"line_number":135,"context_line":"        subnet_choices \u003d [(\u0027\u0027, _(\"Select a subnet\"))]"},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            network_id \u003d kwargs[\u0027network_id\u0027]"},{"line_number":138,"context_line":"            network \u003d api.neutron.network_get(self.request, network_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_16aa92d2","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":53},"updated":"2016-08-03 17:53:10.000000000","message":"This makes the if condition at L.86 a bit confusing.\nI would suggest not to include this default value and to return only the available choices. This makes the logic around L.86 clear.","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6cd29b3e1de1d30ff596cb64d199e4e3d1edcaa2","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            exceptions.handle(self.request, msg)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def _get_subnet_choices(self, kwargs):"},{"line_number":135,"context_line":"        subnet_choices \u003d [(\u0027\u0027, _(\"Select a subnet\"))]"},{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            network_id \u003d kwargs[\u0027network_id\u0027]"},{"line_number":138,"context_line":"            network \u003d api.neutron.network_get(self.request, network_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_9d7048de","line":135,"range":{"start_line":135,"start_character":8,"end_line":135,"end_character":53},"in_reply_to":"bacf61ea_16aa92d2","updated":"2016-08-04 07:48:58.000000000","message":"Done","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"714933bc687e973ec7910c77834a393ede785fd7","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                \u0027device_owner\u0027: data[\u0027device_owner\u0027],"},{"line_number":158,"context_line":"                \u0027binding__host_id\u0027: data[\u0027binding__host_id\u0027]"},{"line_number":159,"context_line":"            }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            if data.get(\u0027subnet_id\u0027):"},{"line_number":162,"context_line":"                if data.get(\u0027fixed_ips\u0027):"},{"line_number":163,"context_line":"                    params[\u0027fixed_ips\u0027] \u003d [{\"ip_address\": data[\u0027fixed_ips\u0027]}]"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_b6874611","line":160,"updated":"2016-08-03 17:53:10.000000000","message":"Basic question: we can specify multiple IP addresses/subnets for subnet-create. For example, we can specify both IPv4 and IPv6 addresses. We also can specify IPv4 subnet and Ipv6 subnet.\nThis patch only supports one subnet. Is it your intended behavior?","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6cd29b3e1de1d30ff596cb64d199e4e3d1edcaa2","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                \u0027device_owner\u0027: data[\u0027device_owner\u0027],"},{"line_number":158,"context_line":"                \u0027binding__host_id\u0027: data[\u0027binding__host_id\u0027]"},{"line_number":159,"context_line":"            }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            if data.get(\u0027subnet_id\u0027):"},{"line_number":162,"context_line":"                if data.get(\u0027fixed_ips\u0027):"},{"line_number":163,"context_line":"                    params[\u0027fixed_ips\u0027] \u003d [{\"ip_address\": data[\u0027fixed_ips\u0027]}]"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_f8ca324e","line":160,"in_reply_to":"bacf61ea_b6874611","updated":"2016-08-04 07:48:58.000000000","message":"Yes, currently I assume only a single one. As you say, this feature can specify multi subnet or addresses but it may need more complicated UI and logic. If we need such a feature on Horizon, I think we would be able to tackle as a improvement of this patch.","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"630eabeee6898abe804fa5cb429c491fcca9e74c","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                \u0027device_owner\u0027: data[\u0027device_owner\u0027],"},{"line_number":158,"context_line":"                \u0027binding__host_id\u0027: data[\u0027binding__host_id\u0027]"},{"line_number":159,"context_line":"            }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"            if data.get(\u0027subnet_id\u0027):"},{"line_number":162,"context_line":"                if data.get(\u0027fixed_ips\u0027):"},{"line_number":163,"context_line":"                    params[\u0027fixed_ips\u0027] \u003d [{\"ip_address\": data[\u0027fixed_ips\u0027]}]"}],"source_content_type":"text/x-python","patch_set":14,"id":"9ad45d7e_07b640f8","line":160,"in_reply_to":"bacf61ea_f8ca324e","updated":"2016-08-12 03:24:54.000000000","message":"Thanks for clarifying the scope of this patch. Sounds reasonable to me.","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7808bd9462a85be2bca0bbffcb5fc213abb88e2a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        help_text\u003d_(\"To specify a subnet or a fixed IP, select any options.\"),"},{"line_number":65,"context_line":"        initial\u003dFalse,"},{"line_number":66,"context_line":"        required\u003dFalse,"},{"line_number":67,"context_line":"        choices\u003d[(\u0027\u0027, _(\"No specify\")),"},{"line_number":68,"context_line":"                 (\u0027subnet_id\u0027, _(\"Subnet\")),"},{"line_number":69,"context_line":"                 (\u0027fixed_ip\u0027, _(\"Fixed IP Address\"))],"},{"line_number":70,"context_line":"        widget\u003dforms.Select(attrs\u003d{"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ac06dbe_5063f841","line":67,"range":{"start_line":67,"start_character":25,"end_line":67,"end_character":35},"updated":"2016-08-23 18:38:40.000000000","message":"\u0027specify\u0027 is a verb, so we cannot say \u0027No specify\u0027. \"Unspecified\"?\nNative-speaker reviewers are welcome.","commit_id":"86d5e4d6aa1579012a629ff19f9eb1e3e8dbe437"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8f4dde9ed0bfc693f536d89d41ec421782eb48c5","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        help_text\u003d_(\"To specify a subnet or a fixed IP, select any options.\"),"},{"line_number":65,"context_line":"        initial\u003dFalse,"},{"line_number":66,"context_line":"        required\u003dFalse,"},{"line_number":67,"context_line":"        choices\u003d[(\u0027\u0027, _(\"No specify\")),"},{"line_number":68,"context_line":"                 (\u0027subnet_id\u0027, _(\"Subnet\")),"},{"line_number":69,"context_line":"                 (\u0027fixed_ip\u0027, _(\"Fixed IP Address\"))],"},{"line_number":70,"context_line":"        widget\u003dforms.Select(attrs\u003d{"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ac06dbe_f9763b04","line":67,"range":{"start_line":67,"start_character":25,"end_line":67,"end_character":35},"in_reply_to":"1ac06dbe_5063f841","updated":"2016-08-24 05:05:27.000000000","message":"Done. I modified to \u0027Unspecified\u0027. As far as I see in .po file, \u0027unspecified\u0027 or \u0027not specified\u0027 seem to be used and former is more used than latter.","commit_id":"86d5e4d6aa1579012a629ff19f9eb1e3e8dbe437"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7808bd9462a85be2bca0bbffcb5fc213abb88e2a","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            network_id \u003d kwargs[\u0027network_id\u0027]"},{"line_number":147,"context_line":"            network \u003d api.neutron.network_get(self.request, network_id)"},{"line_number":148,"context_line":"        except Exception:"},{"line_number":149,"context_line":"            return subnet_choices"},{"line_number":150,"context_line":"        for subnet in network.subnets:"},{"line_number":151,"context_line":"            subnet_choices.append("},{"line_number":152,"context_line":"                (subnet.id, \u0027%s(%s)\u0027 % (subnet.name, subnet.cidr)))"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ac06dbe_50f1386a","line":149,"range":{"start_line":149,"start_character":12,"end_line":149,"end_character":33},"updated":"2016-08-23 18:38:40.000000000","message":"return []","commit_id":"86d5e4d6aa1579012a629ff19f9eb1e3e8dbe437"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8f4dde9ed0bfc693f536d89d41ec421782eb48c5","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            network_id \u003d kwargs[\u0027network_id\u0027]"},{"line_number":147,"context_line":"            network \u003d api.neutron.network_get(self.request, network_id)"},{"line_number":148,"context_line":"        except Exception:"},{"line_number":149,"context_line":"            return subnet_choices"},{"line_number":150,"context_line":"        for subnet in network.subnets:"},{"line_number":151,"context_line":"            subnet_choices.append("},{"line_number":152,"context_line":"                (subnet.id, \u0027%s(%s)\u0027 % (subnet.name, subnet.cidr)))"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ac06dbe_59a14f45","line":149,"range":{"start_line":149,"start_character":12,"end_line":149,"end_character":33},"in_reply_to":"1ac06dbe_50f1386a","updated":"2016-08-24 05:05:27.000000000","message":"Done","commit_id":"86d5e4d6aa1579012a629ff19f9eb1e3e8dbe437"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7808bd9462a85be2bca0bbffcb5fc213abb88e2a","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            network \u003d api.neutron.network_get(self.request, network_id)"},{"line_number":148,"context_line":"        except Exception:"},{"line_number":149,"context_line":"            return subnet_choices"},{"line_number":150,"context_line":"        for subnet in network.subnets:"},{"line_number":151,"context_line":"            subnet_choices.append("},{"line_number":152,"context_line":"                (subnet.id, \u0027%s(%s)\u0027 % (subnet.name, subnet.cidr)))"},{"line_number":153,"context_line":"        return subnet_choices"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def handle(self, request, data):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ac06dbe_d08c08dc","line":152,"range":{"start_line":150,"start_character":8,"end_line":152,"end_character":67},"updated":"2016-08-23 18:38:40.000000000","message":"Consider:\n\n  return [(subnet.id, \u0027%s(%s)\u0027 % (subnet.name, subnet.cidr))\n          for subnet in network.subnets]\n\nIn addition, there is a case where a subnet has no name (empty).\nIt is better to use subnet.name_or_id rather than subnet.name.\nMy suggestion is:\n\n  \u0027%s %s\" % (subnet.name_or_id, subnet.cidr)\n\nIt is to avoid double parentheses.","commit_id":"86d5e4d6aa1579012a629ff19f9eb1e3e8dbe437"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8f4dde9ed0bfc693f536d89d41ec421782eb48c5","unresolved":false,"context_lines":[{"line_number":147,"context_line":"            network \u003d api.neutron.network_get(self.request, network_id)"},{"line_number":148,"context_line":"        except Exception:"},{"line_number":149,"context_line":"            return subnet_choices"},{"line_number":150,"context_line":"        for subnet in network.subnets:"},{"line_number":151,"context_line":"            subnet_choices.append("},{"line_number":152,"context_line":"                (subnet.id, \u0027%s(%s)\u0027 % (subnet.name, subnet.cidr)))"},{"line_number":153,"context_line":"        return subnet_choices"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def handle(self, request, data):"}],"source_content_type":"text/x-python","patch_set":16,"id":"1ac06dbe_3e43946d","line":152,"range":{"start_line":150,"start_character":8,"end_line":152,"end_character":67},"in_reply_to":"1ac06dbe_d08c08dc","updated":"2016-08-24 05:05:27.000000000","message":"Done, thanks!","commit_id":"86d5e4d6aa1579012a629ff19f9eb1e3e8dbe437"}],"openstack_dashboard/dashboards/admin/networks/ports/tests.py":[{"author":{"_account_id":20509,"name":"Daniel Castellanos","email":"luis.daniel.castellanos@intel.com","username":"lcastell"},"change_message_id":"79cf299d32e55bc907849270f9f98a49a619fdfa","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        redir_url \u003d reverse(NETWORKS_DETAIL_URL, args\u003d[port.network_id])"},{"line_number":174,"context_line":"        self.assertRedirectsNoFollow(res, redir_url)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def test_port_create_posti_with_fixed_ip(self):"},{"line_number":177,"context_line":"        self._test_port_create_post_with_fixed_ip()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @test.create_stubs({api.neutron: (\u0027network_get\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_d9d7c8eb","line":176,"range":{"start_line":176,"start_character":25,"end_line":176,"end_character":30},"updated":"2016-06-09 21:55:24.000000000","message":"typo?","commit_id":"3ab81569b236ed6ea526357f273f673b7871476e"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"35939c19569deec2aa36b17e1a561bac18a70740","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        redir_url \u003d reverse(NETWORKS_DETAIL_URL, args\u003d[port.network_id])"},{"line_number":174,"context_line":"        self.assertRedirectsNoFollow(res, redir_url)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def test_port_create_posti_with_fixed_ip(self):"},{"line_number":177,"context_line":"        self._test_port_create_post_with_fixed_ip()"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @test.create_stubs({api.neutron: (\u0027network_get\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7aa08908_b250edd5","line":176,"range":{"start_line":176,"start_character":25,"end_line":176,"end_character":30},"in_reply_to":"7aa08908_d9d7c8eb","updated":"2016-06-10 13:40:19.000000000","message":"Done","commit_id":"3ab81569b236ed6ea526357f273f673b7871476e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"714933bc687e973ec7910c77834a393ede785fd7","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    @test.create_stubs({api.neutron: (\u0027network_get\u0027,"},{"line_number":177,"context_line":"                                      \u0027is_extension_supported\u0027,"},{"line_number":178,"context_line":"                                      \u0027port_create\u0027,)})"},{"line_number":179,"context_line":"    def _test_port_create_post_with_fixed_ip(self, mac_learning\u003dFalse,"},{"line_number":180,"context_line":"                                             binding\u003dFalse):"},{"line_number":181,"context_line":"        network \u003d self.networks.first()"},{"line_number":182,"context_line":"        port \u003d self.ports.first()"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_56d6caf1","line":179,"range":{"start_line":179,"start_character":8,"end_line":179,"end_character":44},"updated":"2016-08-03 17:53:10.000000000","message":"I wonder why you need to define this private method....\nThis method is called only from one place (L.174).","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"6cd29b3e1de1d30ff596cb64d199e4e3d1edcaa2","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    @test.create_stubs({api.neutron: (\u0027network_get\u0027,"},{"line_number":177,"context_line":"                                      \u0027is_extension_supported\u0027,"},{"line_number":178,"context_line":"                                      \u0027port_create\u0027,)})"},{"line_number":179,"context_line":"    def _test_port_create_post_with_fixed_ip(self, mac_learning\u003dFalse,"},{"line_number":180,"context_line":"                                             binding\u003dFalse):"},{"line_number":181,"context_line":"        network \u003d self.networks.first()"},{"line_number":182,"context_line":"        port \u003d self.ports.first()"}],"source_content_type":"text/x-python","patch_set":14,"id":"bacf61ea_deaf57e1","line":179,"range":{"start_line":179,"start_character":8,"end_line":179,"end_character":44},"in_reply_to":"bacf61ea_56d6caf1","updated":"2016-08-04 07:48:58.000000000","message":"Done","commit_id":"6be67114ed34c7d39c95b8c944eccd0fed051244"}]}
