)]}'
{"openstack_dashboard/dashboards/admin/networks/forms.py":[{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"2c8a17296b8cd79fe33f23f7adb6084d180a8534","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        if api.neutron.is_port_profiles_supported():"},{"line_number":150,"context_line":"            self.fields[\u0027net_profile_id\u0027].choices \u003d ("},{"line_number":151,"context_line":"                self.get_network_profile_choices(request))"},{"line_number":152,"context_line":"        try:"},{"line_number":153,"context_line":"            if api.neutron.is_extension_supported(request, \u0027provider\u0027):"},{"line_number":154,"context_line":"                neutron_settings \u003d getattr(settings,"},{"line_number":155,"context_line":"                                           \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_6bcd4f65","line":152,"updated":"2016-06-09 03:04:36.000000000","message":"If we have to catch the exception from \"api.neutron.is_extension_supported\", how about the code like below ? If possible so, we could maintain less nested structure.\n\ntry:\n    is_extension_supported \u003d api.neutron.is_extension_supported(request, \u0027provider\u0027)\nexcept Exception:\n    msg \u003d _(\"Unable to verify Neutron service providers\")\n    exceptions.handle(self.request, msg)\n    self._hide_provider_network_type()\n\nif is_extension_supported:\n    neutron_settings \u003d getattr(settings,\n                               \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})\n    …","commit_id":"4d4cb4b86c68461c8e40c41909eeb0904616a866"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"24de9c773945c07567e4584962fa1514ce57acff","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        if api.neutron.is_port_profiles_supported():"},{"line_number":150,"context_line":"            self.fields[\u0027net_profile_id\u0027].choices \u003d ("},{"line_number":151,"context_line":"                self.get_network_profile_choices(request))"},{"line_number":152,"context_line":"        try:"},{"line_number":153,"context_line":"            if api.neutron.is_extension_supported(request, \u0027provider\u0027):"},{"line_number":154,"context_line":"                neutron_settings \u003d getattr(settings,"},{"line_number":155,"context_line":"                                           \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aa08908_524eb46f","line":152,"in_reply_to":"7aa08908_6bcd4f65","updated":"2016-06-12 20:43:53.000000000","message":"Done","commit_id":"4d4cb4b86c68461c8e40c41909eeb0904616a866"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"9704dca3e6acd407aead4d47884ed9aac82f7d21","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            exceptions.handle(self.request, msg)"},{"line_number":158,"context_line":"            self._hide_provider_network_type()"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        if is_extension_supported:"},{"line_number":161,"context_line":"            neutron_settings \u003d getattr(settings,"},{"line_number":162,"context_line":"                                       \u0027OPENSTACK_NEUTRON_NETWORK\u0027, {})"},{"line_number":163,"context_line":"            self.seg_id_range \u003d SEGMENTATION_ID_RANGE.copy()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_895aae28","line":160,"updated":"2016-07-29 20:30:02.000000000","message":"this variable is out of scope in the exception case and would cause a runtime error","commit_id":"046247bfb30daed665174abe67d1f819db756147"},{"author":{"_account_id":5623,"name":"David Lyle","email":"dklyle0@gmail.com","username":"david-lyle"},"change_message_id":"9704dca3e6acd407aead4d47884ed9aac82f7d21","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                self.seg_id_range.update(seg_id_range)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"            self.provider_types \u003d PROVIDER_TYPES.copy()"},{"line_number":169,"context_line":"            extra_provider_types \u003d \\"},{"line_number":170,"context_line":"                neutron_settings.get(\u0027extra_provider_types\u0027)"},{"line_number":171,"context_line":"            if extra_provider_types:"},{"line_number":172,"context_line":"                self.provider_types.update(extra_provider_types)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_495436fe","line":169,"updated":"2016-07-29 20:30:02.000000000","message":"all these extra formatting changes are unrelated to the patch and honestly don\u0027t seem to be an improvement.","commit_id":"046247bfb30daed665174abe67d1f819db756147"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"b00a6328f4a15fb906e6085052dc11d37fb9d611","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                self.seg_id_range.update(seg_id_range)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"            self.provider_types \u003d PROVIDER_TYPES.copy()"},{"line_number":169,"context_line":"            extra_provider_types \u003d \\"},{"line_number":170,"context_line":"                neutron_settings.get(\u0027extra_provider_types\u0027)"},{"line_number":171,"context_line":"            if extra_provider_types:"},{"line_number":172,"context_line":"                self.provider_types.update(extra_provider_types)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_79ca5e1c","line":169,"in_reply_to":"bacf61ea_495436fe","updated":"2016-08-01 18:00:40.000000000","message":"due to pep8 line length limits. will refactor","commit_id":"046247bfb30daed665174abe67d1f819db756147"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6fbbf8f15a9c077843e016d71a97f4b857c9f3","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            msg \u003d _(\"Unable to verify Neutron service providers\")"},{"line_number":158,"context_line":"            exceptions.handle(self.request, msg)"},{"line_number":159,"context_line":"            self._hide_provider_network_type()"},{"line_number":160,"context_line":"            is_extension_supported \u003d None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        if is_extension_supported:"},{"line_number":163,"context_line":"            neutron_settings \u003d getattr(settings,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_99ff19aa","line":160,"range":{"start_line":160,"start_character":37,"end_line":160,"end_character":41},"updated":"2016-08-12 13:11:13.000000000","message":"is_extension_support is a boolean value, so I prefer to False rather than None.","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3fa94695a8f146ee81e0f31059254c6c2281a074","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            msg \u003d _(\"Unable to verify Neutron service providers\")"},{"line_number":158,"context_line":"            exceptions.handle(self.request, msg)"},{"line_number":159,"context_line":"            self._hide_provider_network_type()"},{"line_number":160,"context_line":"            is_extension_supported \u003d None"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        if is_extension_supported:"},{"line_number":163,"context_line":"            neutron_settings \u003d getattr(settings,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_b2cae26c","line":160,"range":{"start_line":160,"start_character":37,"end_line":160,"end_character":41},"in_reply_to":"9ad45d7e_99ff19aa","updated":"2016-08-12 18:41:59.000000000","message":"Done","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6fbbf8f15a9c077843e016d71a97f4b857c9f3","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                self.seg_id_range.update(seg_id_range)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"            self.provider_types \u003d PROVIDER_TYPES.copy()"},{"line_number":171,"context_line":"            extra_provider_types \u003d \\"},{"line_number":172,"context_line":"                neutron_settings.get(\u0027extra_provider_types\u0027)"},{"line_number":173,"context_line":"            if extra_provider_types:"},{"line_number":174,"context_line":"                self.provider_types.update(extra_provider_types)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_9951d9db","line":172,"range":{"start_line":171,"start_character":12,"end_line":172,"end_character":60},"updated":"2016-08-12 13:11:13.000000000","message":"Looks unnecessary change.","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3fa94695a8f146ee81e0f31059254c6c2281a074","unresolved":false,"context_lines":[{"line_number":168,"context_line":"                self.seg_id_range.update(seg_id_range)"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"            self.provider_types \u003d PROVIDER_TYPES.copy()"},{"line_number":171,"context_line":"            extra_provider_types \u003d \\"},{"line_number":172,"context_line":"                neutron_settings.get(\u0027extra_provider_types\u0027)"},{"line_number":173,"context_line":"            if extra_provider_types:"},{"line_number":174,"context_line":"                self.provider_types.update(extra_provider_types)"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_328c3235","line":172,"range":{"start_line":171,"start_character":12,"end_line":172,"end_character":60},"in_reply_to":"9ad45d7e_9951d9db","updated":"2016-08-12 18:41:59.000000000","message":"Done","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6fbbf8f15a9c077843e016d71a97f4b857c9f3","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            self.nettypes_with_seg_id \u003d ["},{"line_number":177,"context_line":"                net_type for net_type in self.provider_types"},{"line_number":178,"context_line":"                if self.provider_types[net_type]"},{"line_number":179,"context_line":"                [\u0027require_segmentation_id\u0027]]"},{"line_number":180,"context_line":"            self.nettypes_with_physnet \u003d ["},{"line_number":181,"context_line":"                net_type for net_type in self.provider_types"},{"line_number":182,"context_line":"                if self.provider_types[net_type]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f95c55f2","line":179,"updated":"2016-08-12 13:11:13.000000000","message":"ditto","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3fa94695a8f146ee81e0f31059254c6c2281a074","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            self.nettypes_with_seg_id \u003d ["},{"line_number":177,"context_line":"                net_type for net_type in self.provider_types"},{"line_number":178,"context_line":"                if self.provider_types[net_type]"},{"line_number":179,"context_line":"                [\u0027require_segmentation_id\u0027]]"},{"line_number":180,"context_line":"            self.nettypes_with_physnet \u003d ["},{"line_number":181,"context_line":"                net_type for net_type in self.provider_types"},{"line_number":182,"context_line":"                if self.provider_types[net_type]"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f2729a48","line":179,"in_reply_to":"9ad45d7e_f95c55f2","updated":"2016-08-12 18:41:59.000000000","message":"Done","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6fbbf8f15a9c077843e016d71a97f4b857c9f3","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self.nettypes_with_physnet \u003d ["},{"line_number":181,"context_line":"                net_type for net_type in self.provider_types"},{"line_number":182,"context_line":"                if self.provider_types[net_type]"},{"line_number":183,"context_line":"                [\u0027require_physical_network\u0027]]"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            supported_provider_types \u003d neutron_settings.get("},{"line_number":186,"context_line":"                \u0027supported_provider_types\u0027, DEFAULT_PROVIDER_TYPES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_d96191aa","line":183,"updated":"2016-08-12 13:11:13.000000000","message":"ditto","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3fa94695a8f146ee81e0f31059254c6c2281a074","unresolved":false,"context_lines":[{"line_number":180,"context_line":"            self.nettypes_with_physnet \u003d ["},{"line_number":181,"context_line":"                net_type for net_type in self.provider_types"},{"line_number":182,"context_line":"                if self.provider_types[net_type]"},{"line_number":183,"context_line":"                [\u0027require_physical_network\u0027]]"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"            supported_provider_types \u003d neutron_settings.get("},{"line_number":186,"context_line":"                \u0027supported_provider_types\u0027, DEFAULT_PROVIDER_TYPES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_32939251","line":183,"in_reply_to":"9ad45d7e_d96191aa","updated":"2016-08-12 18:41:59.000000000","message":"Done","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6fbbf8f15a9c077843e016d71a97f4b857c9f3","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"            seg_id_help \u003d ["},{"line_number":198,"context_line":"                _(\"For %(type)s networks, \""},{"line_number":199,"context_line":"                  \"valid IDs are %(min)s to %(max)s.\")"},{"line_number":200,"context_line":"                % {\u0027type\u0027: net_type,"},{"line_number":201,"context_line":"                   \u0027min\u0027: self.seg_id_range[net_type][0],"},{"line_number":202,"context_line":"                   \u0027max\u0027: self.seg_id_range[net_type][1]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_195cc9ec","line":199,"updated":"2016-08-12 13:11:13.000000000","message":"ditto","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3fa94695a8f146ee81e0f31059254c6c2281a074","unresolved":false,"context_lines":[{"line_number":196,"context_line":""},{"line_number":197,"context_line":"            seg_id_help \u003d ["},{"line_number":198,"context_line":"                _(\"For %(type)s networks, \""},{"line_number":199,"context_line":"                  \"valid IDs are %(min)s to %(max)s.\")"},{"line_number":200,"context_line":"                % {\u0027type\u0027: net_type,"},{"line_number":201,"context_line":"                   \u0027min\u0027: self.seg_id_range[net_type][0],"},{"line_number":202,"context_line":"                   \u0027max\u0027: self.seg_id_range[net_type][1]}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f2a9fa7c","line":199,"in_reply_to":"9ad45d7e_195cc9ec","updated":"2016-08-12 18:41:59.000000000","message":"Done","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6c6fbbf8f15a9c077843e016d71a97f4b857c9f3","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                   \u0027max\u0027: self.seg_id_range[net_type][1]}"},{"line_number":203,"context_line":"                for net_type in self.nettypes_with_seg_id]"},{"line_number":204,"context_line":"            self.fields[\u0027segmentation_id\u0027]\\"},{"line_number":205,"context_line":"                .help_text \u003d \u0027 \u0027.join(seg_id_help)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"            # Register network types which require segmentation ID"},{"line_number":208,"context_line":"            attrs \u003d dict((\u0027data-network_type-%s\u0027 % network_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_79718577","line":205,"updated":"2016-08-12 13:11:13.000000000","message":"ditto","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"3fa94695a8f146ee81e0f31059254c6c2281a074","unresolved":false,"context_lines":[{"line_number":202,"context_line":"                   \u0027max\u0027: self.seg_id_range[net_type][1]}"},{"line_number":203,"context_line":"                for net_type in self.nettypes_with_seg_id]"},{"line_number":204,"context_line":"            self.fields[\u0027segmentation_id\u0027]\\"},{"line_number":205,"context_line":"                .help_text \u003d \u0027 \u0027.join(seg_id_help)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"            # Register network types which require segmentation ID"},{"line_number":208,"context_line":"            attrs \u003d dict((\u0027data-network_type-%s\u0027 % network_type,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_92afde7c","line":205,"in_reply_to":"9ad45d7e_79718577","updated":"2016-08-12 18:41:59.000000000","message":"Done","commit_id":"82fb50f0974b9efcc1204a817bb4cba2ebc1c5a1"}]}
