)]}'
{"openstack_dashboard/api/rest/config.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"c5cc924f3a3604db7a6edb7ff8739a0485233efb","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"@urls.register"},{"line_number":50,"context_line":"class Notifications(generic.View):"},{"line_number":51,"context_line":"    \"\"\"API for retrieving notifications defined by MESSAGE_PTATH."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    url_regex \u003d r\u0027settings/notifications$\u0027"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_3eab678b","line":51,"updated":"2016-06-21 21:24:49.000000000","message":"MESSAGE_PATH*","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8c155e018d18f58d62f03c6f807e898608add458","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"@urls.register"},{"line_number":50,"context_line":"class Notifications(generic.View):"},{"line_number":51,"context_line":"    \"\"\"API for retrieving notifications defined by MESSAGE_PTATH."},{"line_number":52,"context_line":"    \"\"\""},{"line_number":53,"context_line":"    url_regex \u003d r\u0027settings/notifications$\u0027"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_ee3d5fbc","line":51,"in_reply_to":"3aaa91ec_3eab678b","updated":"2016-06-23 08:47:28.000000000","message":"Done","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"c5cc924f3a3604db7a6edb7ff8739a0485233efb","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    @rest_utils.ajax()"},{"line_number":56,"context_line":"    def get(self, request):"},{"line_number":57,"context_line":"        MESSAGES_PATH \u003d getattr(settings, \u0027MESSAGES_PATH\u0027, None)"},{"line_number":58,"context_line":"        ns \u003d notifications.get_processed_messages(MESSAGES_PATH)"},{"line_number":59,"context_line":"        msgs \u003d []"},{"line_number":60,"context_line":"        for notification in ns[\u0027messages\u0027]:"},{"line_number":61,"context_line":"            msg \u003d {\u0027level\u0027: notification.level_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_9eeedbea","line":58,"updated":"2016-06-21 21:24:49.000000000","message":"should check that ns[\u0027messages\u0027] exists so that it doesn\u0027t fail on L60 with\n\u0027NoneType\u0027 object has no attribute \u0027__getitem__\u0027\n\nrandom thought: should we hide the panel if there are no notifications?","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8c155e018d18f58d62f03c6f807e898608add458","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    @rest_utils.ajax()"},{"line_number":56,"context_line":"    def get(self, request):"},{"line_number":57,"context_line":"        MESSAGES_PATH \u003d getattr(settings, \u0027MESSAGES_PATH\u0027, None)"},{"line_number":58,"context_line":"        ns \u003d notifications.get_processed_messages(MESSAGES_PATH)"},{"line_number":59,"context_line":"        msgs \u003d []"},{"line_number":60,"context_line":"        for notification in ns[\u0027messages\u0027]:"},{"line_number":61,"context_line":"            msg \u003d {\u0027level\u0027: notification.level_name,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_11228a52","line":58,"in_reply_to":"3aaa91ec_9eeedbea","updated":"2016-06-23 08:47:28.000000000","message":"Done.\n\n\u003erandom thought: should we hide the panel if there are no notifications?\n\nI think this panel need to be displayed even if there are no notifications so as to be able to judge whether there are notifications or not (actually there are any notifications but at the moment they are hide. or there are merely no notifications.).","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"59b4e707352a1c64f2404f838afabb3b4876333f","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            msg \u003d {\u0027level\u0027: notification.level_name,"},{"line_number":71,"context_line":"                   \u0027message\u0027: notification.message}"},{"line_number":72,"context_line":"            msgs.append(msg)"},{"line_number":73,"context_line":"        return {\u0027items\u0027: msgs, \u0027time\u0027: time}"}],"source_content_type":"text/x-python","patch_set":21,"id":"1ac06dbe_16f3e69f","line":73,"updated":"2016-08-19 20:06:22.000000000","message":"time is not used. remove?","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"62bd39d437728a3611cfa88b9e2996adff2a8c06","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            msg \u003d {\u0027level\u0027: notification.level_name,"},{"line_number":71,"context_line":"                   \u0027message\u0027: notification.message}"},{"line_number":72,"context_line":"            msgs.append(msg)"},{"line_number":73,"context_line":"        return {\u0027items\u0027: msgs, \u0027time\u0027: time}"}],"source_content_type":"text/x-python","patch_set":21,"id":"1ac06dbe_de781cf5","line":73,"in_reply_to":"1ac06dbe_16f3e69f","updated":"2016-08-22 05:11:49.000000000","message":"Done","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"5a46642ab9c5c3d1851ca8283aa37bccc5a2ebdb","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        messages \u003d ns.get(\u0027messages\u0027, [])"},{"line_number":67,"context_line":"        msgs \u003d []"},{"line_number":68,"context_line":"        for notification in messages:"},{"line_number":69,"context_line":"            msg \u003d {\u0027level\u0027: notification.level_name,"},{"line_number":70,"context_line":"                   \u0027message\u0027: notification.message}"},{"line_number":71,"context_line":"            msgs.append(msg)"},{"line_number":72,"context_line":"        return {\u0027items\u0027: msgs}"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa7ab95a_c82cbf04","line":69,"updated":"2016-08-30 01:28:38.000000000","message":"notifications.level?","commit_id":"d835754e1698850a98f97b2c5bcc3357abad7d1b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"82f87c056c384cc02b5e1eb4a7f20bbf07f2cffc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        messages \u003d ns.get(\u0027messages\u0027, [])"},{"line_number":67,"context_line":"        msgs \u003d []"},{"line_number":68,"context_line":"        for notification in messages:"},{"line_number":69,"context_line":"            msg \u003d {\u0027level\u0027: notification.level_name,"},{"line_number":70,"context_line":"                   \u0027message\u0027: notification.message}"},{"line_number":71,"context_line":"            msgs.append(msg)"},{"line_number":72,"context_line":"        return {\u0027items\u0027: msgs}"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa7ab95a_2895cf87","line":69,"in_reply_to":"fa7ab95a_c82cbf04","updated":"2016-08-31 01:25:51.000000000","message":"JSONMessage has attributes \u0027level\u0027 and \u0027level_name\u0027.\nThe former is message object and the latter is string indicating just a notification level.\nIn this case, I thought the latter is enough because it needs just a notification level.","commit_id":"d835754e1698850a98f97b2c5bcc3357abad7d1b"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"a46d6117a4ea14d52e14c2744ec76cf560c687ad","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"@urls.register"},{"line_number":60,"context_line":"class Notifications(generic.View):"},{"line_number":61,"context_line":"    \"\"\"API for retrieving notifications defined by MESSAGE_PATH."},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    url_regex \u003d r\u0027settings/notifications$\u0027"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a95cdbc_2f1ac36e","line":60,"updated":"2016-10-06 14:33:32.000000000","message":"miss unit test","commit_id":"7caa18cd331b1605dbef5c4e576ce31e9e600c23"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"df5581850d9b8c00a2af037bd2d147bb63ecc011","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"@urls.register"},{"line_number":60,"context_line":"class Notifications(generic.View):"},{"line_number":61,"context_line":"    \"\"\"API for retrieving notifications defined by MESSAGE_PATH."},{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    url_regex \u003d r\u0027settings/notifications$\u0027"}],"source_content_type":"text/x-python","patch_set":28,"id":"fa6399be_df60a8a7","line":60,"in_reply_to":"1a95cdbc_2f1ac36e","updated":"2016-10-17 07:33:33.000000000","message":"Done","commit_id":"7caa18cd331b1605dbef5c4e576ce31e9e600c23"}],"openstack_dashboard/dashboards/settings/static/dashboard/settings/notifications/notifications.module.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"59b4e707352a1c64f2404f838afabb3b4876333f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  function run(registry, settings, basePath, notificationResourceType, settingsService) {"},{"line_number":45,"context_line":"    registry.getResourceType(notificationResourceType)"},{"line_number":46,"context_line":"      .setNames(gettext(\u0027Notification\u0027), gettext(\u0027Notifications\u0027))"},{"line_number":47,"context_line":"      .setSummaryTemplateUrl(basePath + \u0027detail/drawer.html\u0027)"},{"line_number":48,"context_line":"      .setProperty(\u0027level\u0027, {"},{"line_number":49,"context_line":"        label: gettext(\u0027Level\u0027)"},{"line_number":50,"context_line":"      })"}],"source_content_type":"text/javascript","patch_set":21,"id":"1ac06dbe_ed90fdee","line":47,"updated":"2016-08-19 20:06:22.000000000","message":"can remove since there we don\u0027t have any content for drawer :)","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"62bd39d437728a3611cfa88b9e2996adff2a8c06","unresolved":false,"context_lines":[{"line_number":44,"context_line":"  function run(registry, settings, basePath, notificationResourceType, settingsService) {"},{"line_number":45,"context_line":"    registry.getResourceType(notificationResourceType)"},{"line_number":46,"context_line":"      .setNames(gettext(\u0027Notification\u0027), gettext(\u0027Notifications\u0027))"},{"line_number":47,"context_line":"      .setSummaryTemplateUrl(basePath + \u0027detail/drawer.html\u0027)"},{"line_number":48,"context_line":"      .setProperty(\u0027level\u0027, {"},{"line_number":49,"context_line":"        label: gettext(\u0027Level\u0027)"},{"line_number":50,"context_line":"      })"}],"source_content_type":"text/javascript","patch_set":21,"id":"1ac06dbe_1e9634f0","line":47,"in_reply_to":"1ac06dbe_ed90fdee","updated":"2016-08-22 05:11:49.000000000","message":"Done","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"a46d6117a4ea14d52e14c2744ec76cf560c687ad","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  function run(registry, settings, notificationResourceType, notificationsService) {"},{"line_number":44,"context_line":"    registry.getResourceType(notificationResourceType)"},{"line_number":45,"context_line":"      .setNames(gettext(\u0027Notification\u0027), gettext(\u0027Notifications\u0027))"},{"line_number":46,"context_line":"      .setProperty(\u0027level\u0027, {"},{"line_number":47,"context_line":"        label: gettext(\u0027Level\u0027)"},{"line_number":48,"context_line":"      })"},{"line_number":49,"context_line":"      .setProperty(\u0027message\u0027, {"}],"source_content_type":"text/javascript","patch_set":28,"id":"1a95cdbc_6cf21971","line":46,"updated":"2016-10-06 14:33:32.000000000","message":"could we use setProperties to be consistent with image panel","commit_id":"7caa18cd331b1605dbef5c4e576ce31e9e600c23"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"df5581850d9b8c00a2af037bd2d147bb63ecc011","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  function run(registry, settings, notificationResourceType, notificationsService) {"},{"line_number":44,"context_line":"    registry.getResourceType(notificationResourceType)"},{"line_number":45,"context_line":"      .setNames(gettext(\u0027Notification\u0027), gettext(\u0027Notifications\u0027))"},{"line_number":46,"context_line":"      .setProperty(\u0027level\u0027, {"},{"line_number":47,"context_line":"        label: gettext(\u0027Level\u0027)"},{"line_number":48,"context_line":"      })"},{"line_number":49,"context_line":"      .setProperty(\u0027message\u0027, {"}],"source_content_type":"text/javascript","patch_set":28,"id":"fa6399be_5ffc98b7","line":46,"in_reply_to":"1a95cdbc_6cf21971","updated":"2016-10-17 07:33:33.000000000","message":"Done","commit_id":"7caa18cd331b1605dbef5c4e576ce31e9e600c23"},{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"a46d6117a4ea14d52e14c2744ec76cf560c687ad","unresolved":false,"context_lines":[{"line_number":78,"context_line":"   */"},{"line_number":79,"context_line":"  function config($provide, $windowProvider, $routeProvider) {"},{"line_number":80,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027dashboard/settings/notifications/\u0027;"},{"line_number":81,"context_line":"    $provide.constant(\u0027horizon.dashboard.settings.notifications.basePath\u0027, path);"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    $routeProvider.when(\u0027/settings/ngnotifications\u0027, {"},{"line_number":84,"context_line":"      templateUrl: path + \u0027panel.html\u0027"}],"source_content_type":"text/javascript","patch_set":28,"id":"1a95cdbc_0fbb4728","line":81,"updated":"2016-10-06 14:33:32.000000000","message":"seems unnecessary","commit_id":"7caa18cd331b1605dbef5c4e576ce31e9e600c23"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"df5581850d9b8c00a2af037bd2d147bb63ecc011","unresolved":false,"context_lines":[{"line_number":78,"context_line":"   */"},{"line_number":79,"context_line":"  function config($provide, $windowProvider, $routeProvider) {"},{"line_number":80,"context_line":"    var path \u003d $windowProvider.$get().STATIC_URL + \u0027dashboard/settings/notifications/\u0027;"},{"line_number":81,"context_line":"    $provide.constant(\u0027horizon.dashboard.settings.notifications.basePath\u0027, path);"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    $routeProvider.when(\u0027/settings/ngnotifications\u0027, {"},{"line_number":84,"context_line":"      templateUrl: path + \u0027panel.html\u0027"}],"source_content_type":"text/javascript","patch_set":28,"id":"fa6399be_9f02b0b2","line":81,"in_reply_to":"1a95cdbc_0fbb4728","updated":"2016-10-17 07:33:33.000000000","message":"Done","commit_id":"7caa18cd331b1605dbef5c4e576ce31e9e600c23"}],"openstack_dashboard/dashboards/settings/static/dashboard/settings/notifications/notifications.service.js":[{"author":{"_account_id":6763,"name":"jingliuqing","email":"jing.liuqing@99cloud.net","username":"jing"},"change_message_id":"a46d6117a4ea14d52e14c2744ec76cf560c687ad","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      function getNotificationsSuccess(response) {"},{"line_number":48,"context_line":"        if (response.data.items.length \u003c 1) {"},{"line_number":49,"context_line":"          toast.add(\u0027info\u0027, gettext(\u0027No notifications are set.\u0027));"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        return {data: {items: response.data.items.map(addTrackBy)}};"}],"source_content_type":"text/javascript","patch_set":28,"id":"1a95cdbc_2c7e51ae","line":49,"updated":"2016-10-06 14:33:32.000000000","message":"do we need the info?","commit_id":"7caa18cd331b1605dbef5c4e576ce31e9e600c23"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"df5581850d9b8c00a2af037bd2d147bb63ecc011","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      function getNotificationsSuccess(response) {"},{"line_number":48,"context_line":"        if (response.data.items.length \u003c 1) {"},{"line_number":49,"context_line":"          toast.add(\u0027info\u0027, gettext(\u0027No notifications are set.\u0027));"},{"line_number":50,"context_line":"        }"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        return {data: {items: response.data.items.map(addTrackBy)}};"}],"source_content_type":"text/javascript","patch_set":28,"id":"fa6399be_9a61ded5","line":49,"in_reply_to":"1a95cdbc_2c7e51ae","updated":"2016-10-17 07:33:33.000000000","message":"Done","commit_id":"7caa18cd331b1605dbef5c4e576ce31e9e600c23"}],"openstack_dashboard/dashboards/settings/static/dashboard/settings/notifications/table/table.controller.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"c5cc924f3a3604db7a6edb7ff8739a0485233efb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"   * @ngController"},{"line_number":23,"context_line":"   *"},{"line_number":24,"context_line":"   * @description"},{"line_number":25,"context_line":"   * Controller for the nofitications table."},{"line_number":26,"context_line":"   */"},{"line_number":27,"context_line":"  angular"},{"line_number":28,"context_line":"    .module(\u0027horizon.dashboard.settings.notifications\u0027)"}],"source_content_type":"text/javascript","patch_set":7,"id":"3aaa91ec_3e8367ce","line":25,"updated":"2016-06-21 21:24:49.000000000","message":"notification*","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8c155e018d18f58d62f03c6f807e898608add458","unresolved":false,"context_lines":[{"line_number":22,"context_line":"   * @ngController"},{"line_number":23,"context_line":"   *"},{"line_number":24,"context_line":"   * @description"},{"line_number":25,"context_line":"   * Controller for the nofitications table."},{"line_number":26,"context_line":"   */"},{"line_number":27,"context_line":"  angular"},{"line_number":28,"context_line":"    .module(\u0027horizon.dashboard.settings.notifications\u0027)"}],"source_content_type":"text/javascript","patch_set":7,"id":"3aaa91ec_117e0a19","line":25,"in_reply_to":"3aaa91ec_3e8367ce","updated":"2016-06-23 08:47:28.000000000","message":"Done","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"}],"openstack_dashboard/dashboards/settings/static/dashboard/settings/notifications/table/table.html":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"c5cc924f3a3604db7a6edb7ff8739a0485233efb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003ctable ng-controller\u003d\"settingsNotificationsTableController as table\""},{"line_number":2,"context_line":"  hz-table ng-cloak"},{"line_number":3,"context_line":"  st-table\u003d\"table.imsgs\""},{"line_number":4,"context_line":"  st-safe-src\u003d\"table.msgs\""}],"source_content_type":"text/html","patch_set":7,"id":"3aaa91ec_e1514210","line":1,"updated":"2016-06-21 21:24:49.000000000","message":"can use the new hz-dynamic-table directive (https://github.com/openstack/horizon/blob/master/horizon/static/framework/widgets/table/hz-dynamic-table.directive.js)","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8c155e018d18f58d62f03c6f807e898608add458","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003ctable ng-controller\u003d\"settingsNotificationsTableController as table\""},{"line_number":2,"context_line":"  hz-table ng-cloak"},{"line_number":3,"context_line":"  st-table\u003d\"table.imsgs\""},{"line_number":4,"context_line":"  st-safe-src\u003d\"table.msgs\""}],"source_content_type":"text/html","patch_set":7,"id":"3aaa91ec_f2a419a7","line":1,"in_reply_to":"3aaa91ec_e1514210","updated":"2016-06-23 08:47:28.000000000","message":"Thanks! I\u0027ll use it.","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"}],"openstack_dashboard/dashboards/settings/static/dashboard/settings/settings.service.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"59b4e707352a1c64f2404f838afabb3b4876333f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \"use strict\";"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular.module(\u0027horizon.dashboard.settings\u0027)"},{"line_number":20,"context_line":"    .factory(\u0027horizon.dashboard.settings.service\u0027, settngsService);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  settngsService.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.app.core.openstack-service-api.settings\u0027"}],"source_content_type":"text/javascript","patch_set":21,"id":"1ac06dbe_ea4bc3ae","line":20,"updated":"2016-08-19 20:06:22.000000000","message":"settingsService*","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"62bd39d437728a3611cfa88b9e2996adff2a8c06","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \"use strict\";"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular.module(\u0027horizon.dashboard.settings\u0027)"},{"line_number":20,"context_line":"    .factory(\u0027horizon.dashboard.settings.service\u0027, settngsService);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  settngsService.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.app.core.openstack-service-api.settings\u0027"}],"source_content_type":"text/javascript","patch_set":21,"id":"1ac06dbe_5ea0ac43","line":20,"in_reply_to":"1ac06dbe_ea4bc3ae","updated":"2016-08-22 05:11:49.000000000","message":"Done","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"59b4e707352a1c64f2404f838afabb3b4876333f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  angular.module(\u0027horizon.dashboard.settings\u0027)"},{"line_number":20,"context_line":"    .factory(\u0027horizon.dashboard.settings.service\u0027, settngsService);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  settngsService.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.app.core.openstack-service-api.settings\u0027"},{"line_number":24,"context_line":"  ];"},{"line_number":25,"context_line":""}],"source_content_type":"text/javascript","patch_set":21,"id":"1ac06dbe_4ac77712","line":22,"updated":"2016-08-19 20:06:22.000000000","message":"ditto","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"62bd39d437728a3611cfa88b9e2996adff2a8c06","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  angular.module(\u0027horizon.dashboard.settings\u0027)"},{"line_number":20,"context_line":"    .factory(\u0027horizon.dashboard.settings.service\u0027, settngsService);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  settngsService.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.app.core.openstack-service-api.settings\u0027"},{"line_number":24,"context_line":"  ];"},{"line_number":25,"context_line":""}],"source_content_type":"text/javascript","patch_set":21,"id":"1ac06dbe_3ea33051","line":22,"in_reply_to":"1ac06dbe_4ac77712","updated":"2016-08-22 05:11:49.000000000","message":"Done","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"59b4e707352a1c64f2404f838afabb3b4876333f","unresolved":false,"context_lines":[{"line_number":28,"context_line":"   * @name horizon.dashboard.settings.service"},{"line_number":29,"context_line":"   *"},{"line_number":30,"context_line":"   */"},{"line_number":31,"context_line":"  function settngsService(settings) {"},{"line_number":32,"context_line":"    return {"},{"line_number":33,"context_line":"      getNotificationPromise: getNotificationPromise"},{"line_number":34,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":21,"id":"1ac06dbe_6ad6b3c6","line":31,"updated":"2016-08-19 20:06:22.000000000","message":"ditto","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"62bd39d437728a3611cfa88b9e2996adff2a8c06","unresolved":false,"context_lines":[{"line_number":28,"context_line":"   * @name horizon.dashboard.settings.service"},{"line_number":29,"context_line":"   *"},{"line_number":30,"context_line":"   */"},{"line_number":31,"context_line":"  function settngsService(settings) {"},{"line_number":32,"context_line":"    return {"},{"line_number":33,"context_line":"      getNotificationPromise: getNotificationPromise"},{"line_number":34,"context_line":"    };"}],"source_content_type":"text/javascript","patch_set":21,"id":"1ac06dbe_9e8a24be","line":31,"in_reply_to":"1ac06dbe_6ad6b3c6","updated":"2016-08-22 05:11:49.000000000","message":"Done","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"5a46642ab9c5c3d1851ca8283aa37bccc5a2ebdb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * (c) Copyright 2016 NEC Corporation, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/javascript","patch_set":23,"id":"1ac06dbe_2df7baf6","line":2,"updated":"2016-08-30 01:28:38.000000000","message":"data retrieval should be moved out of this namespace.\n\nnotifications.service.js is better.","commit_id":"d835754e1698850a98f97b2c5bcc3357abad7d1b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"82f87c056c384cc02b5e1eb4a7f20bbf07f2cffc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"/*"},{"line_number":2,"context_line":" * (c) Copyright 2016 NEC Corporation, L.P."},{"line_number":3,"context_line":" *"},{"line_number":4,"context_line":" * Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":" * you may not use this file except in compliance with the License."}],"source_content_type":"text/javascript","patch_set":23,"id":"fa7ab95a_48c6934a","line":2,"in_reply_to":"1ac06dbe_2df7baf6","updated":"2016-08-31 01:25:51.000000000","message":"Done","commit_id":"d835754e1698850a98f97b2c5bcc3357abad7d1b"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"5a46642ab9c5c3d1851ca8283aa37bccc5a2ebdb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \"use strict\";"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular.module(\u0027horizon.dashboard.settings\u0027)"},{"line_number":20,"context_line":"    .factory(\u0027horizon.dashboard.settings.service\u0027, settingsService);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  settingsService.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.app.core.openstack-service-api.settings\u0027,"}],"source_content_type":"text/javascript","patch_set":23,"id":"1ac06dbe_3ab51cd0","line":20,"updated":"2016-08-30 01:28:38.000000000","message":"fix indent","commit_id":"d835754e1698850a98f97b2c5bcc3357abad7d1b"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"5a46642ab9c5c3d1851ca8283aa37bccc5a2ebdb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \"use strict\";"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular.module(\u0027horizon.dashboard.settings\u0027)"},{"line_number":20,"context_line":"    .factory(\u0027horizon.dashboard.settings.service\u0027, settingsService);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  settingsService.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.app.core.openstack-service-api.settings\u0027,"}],"source_content_type":"text/javascript","patch_set":23,"id":"1ac06dbe_daa9687d","line":20,"updated":"2016-08-30 01:28:38.000000000","message":"fix indent","commit_id":"d835754e1698850a98f97b2c5bcc3357abad7d1b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"82f87c056c384cc02b5e1eb4a7f20bbf07f2cffc","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  \"use strict\";"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  angular.module(\u0027horizon.dashboard.settings\u0027)"},{"line_number":20,"context_line":"    .factory(\u0027horizon.dashboard.settings.service\u0027, settingsService);"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  settingsService.$inject \u003d ["},{"line_number":23,"context_line":"    \u0027horizon.app.core.openstack-service-api.settings\u0027,"}],"source_content_type":"text/javascript","patch_set":23,"id":"fa7ab95a_d62fa43c","line":20,"in_reply_to":"1ac06dbe_daa9687d","updated":"2016-08-31 01:25:51.000000000","message":"Done","commit_id":"d835754e1698850a98f97b2c5bcc3357abad7d1b"}],"openstack_dashboard/enabled/_5010_settings_message_panel.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"59b4e707352a1c64f2404f838afabb3b4876333f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2016 NEC Corporation, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":21,"id":"1ac06dbe_071e1a63","line":1,"updated":"2016-08-19 20:06:22.000000000","message":"should be stay consistent with the NG panels ending in 1?","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"62bd39d437728a3611cfa88b9e2996adff2a8c06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# (c) Copyright 2016 NEC Corporation, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":21,"id":"1ac06dbe_de949ce3","line":1,"in_reply_to":"1ac06dbe_071e1a63","updated":"2016-08-22 05:11:49.000000000","message":"Done","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"}],"openstack_dashboard/enabled/_5011_settings_message_panel.py":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"5a46642ab9c5c3d1851ca8283aa37bccc5a2ebdb","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Python panel class of the PANEL to be added."},{"line_number":27,"context_line":"ADD_PANEL \u003d (\u0027openstack_dashboard.dashboards.settings.\u0027"},{"line_number":28,"context_line":"             \u0027ngnotifications.panel.NGNotifications\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"1ac06dbe_b419377c","line":28,"updated":"2016-08-30 01:28:38.000000000","message":"one line is ok, and parens not needed","commit_id":"d835754e1698850a98f97b2c5bcc3357abad7d1b"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"82f87c056c384cc02b5e1eb4a7f20bbf07f2cffc","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Python panel class of the PANEL to be added."},{"line_number":27,"context_line":"ADD_PANEL \u003d (\u0027openstack_dashboard.dashboards.settings.\u0027"},{"line_number":28,"context_line":"             \u0027ngnotifications.panel.NGNotifications\u0027)"}],"source_content_type":"text/x-python","patch_set":23,"id":"fa7ab95a_280b0f2d","line":28,"in_reply_to":"1ac06dbe_b419377c","updated":"2016-08-31 01:25:51.000000000","message":"When we do so, pep8 will warn because the length is over 78. This format is same as other file (parens can help us not to use slash).","commit_id":"d835754e1698850a98f97b2c5bcc3357abad7d1b"}],"openstack_dashboard/static/app/core/openstack-service-api/settings.service.js":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"c5cc924f3a3604db7a6edb7ff8739a0485233efb","unresolved":false,"context_lines":[{"line_number":287,"context_line":"      function onError() {"},{"line_number":288,"context_line":"        var message \u003d gettext(\u0027Unable to retrieve notifications.\u0027);"},{"line_number":289,"context_line":"        if (!suppressError \u0026\u0026 horizon.alert) {"},{"line_number":290,"context_line":"          horizon.alert(\u0027error\u0027, message);"},{"line_number":291,"context_line":"        }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        return message;"}],"source_content_type":"text/javascript","patch_set":7,"id":"3aaa91ec_2114eaf3","line":290,"updated":"2016-06-21 21:24:49.000000000","message":"import and use toastService.add() instead of horizon.alert()","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8c155e018d18f58d62f03c6f807e898608add458","unresolved":false,"context_lines":[{"line_number":287,"context_line":"      function onError() {"},{"line_number":288,"context_line":"        var message \u003d gettext(\u0027Unable to retrieve notifications.\u0027);"},{"line_number":289,"context_line":"        if (!suppressError \u0026\u0026 horizon.alert) {"},{"line_number":290,"context_line":"          horizon.alert(\u0027error\u0027, message);"},{"line_number":291,"context_line":"        }"},{"line_number":292,"context_line":""},{"line_number":293,"context_line":"        return message;"}],"source_content_type":"text/javascript","patch_set":7,"id":"3aaa91ec_11d3aa05","line":290,"in_reply_to":"3aaa91ec_2114eaf3","updated":"2016-06-23 08:47:28.000000000","message":"Done","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"},{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"c5cc924f3a3604db7a6edb7ff8739a0485233efb","unresolved":false,"context_lines":[{"line_number":298,"context_line":"      // unwraps the success result data for direct consumption."},{"line_number":299,"context_line":"      return apiService.get(\u0027/api/settings/notifications\u0027, {cache: true})"},{"line_number":300,"context_line":"        .error(onError)"},{"line_number":301,"context_line":"        .then(function (response) {"},{"line_number":302,"context_line":"          return response.data;"},{"line_number":303,"context_line":"        });"},{"line_number":304,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":7,"id":"3aaa91ec_01bc4e6b","line":301,"updated":"2016-06-21 21:24:49.000000000","message":"do we need the .then()? other calls don\u0027t seem to do this","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"8c155e018d18f58d62f03c6f807e898608add458","unresolved":false,"context_lines":[{"line_number":298,"context_line":"      // unwraps the success result data for direct consumption."},{"line_number":299,"context_line":"      return apiService.get(\u0027/api/settings/notifications\u0027, {cache: true})"},{"line_number":300,"context_line":"        .error(onError)"},{"line_number":301,"context_line":"        .then(function (response) {"},{"line_number":302,"context_line":"          return response.data;"},{"line_number":303,"context_line":"        });"},{"line_number":304,"context_line":"    }"}],"source_content_type":"text/javascript","patch_set":7,"id":"3aaa91ec_b1d576ba","line":301,"in_reply_to":"3aaa91ec_01bc4e6b","updated":"2016-06-23 08:47:28.000000000","message":"In first patch, it was needed, but after using hz-dynamic-table, it was unnecessary. So I removed this.","commit_id":"bf95580b4f0f405b1cf7cd387bd29859121c19a4"}],"openstack_dashboard/test/test_data/notifications/message1.json":[{"author":{"_account_id":9622,"name":"Cindy Lu","email":"clu@us.ibm.com","username":"clu14"},"change_message_id":"59b4e707352a1c64f2404f838afabb3b4876333f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"level\": \"info\","},{"line_number":3,"context_line":"  \"message\": \"Message sample for info level.\""},{"line_number":4,"context_line":"}"}],"source_content_type":"application/json","patch_set":21,"id":"1ac06dbe_f6aa8a6f","line":4,"updated":"2016-08-19 20:06:22.000000000","message":"can we use the sample json from here? https://github.com/openstack/horizon/tree/master/horizon/test/messages","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"},{"author":{"_account_id":17172,"name":"Kenji Ishii","email":"ken-ishii@sx.jp.nec.com","username":"kenji-ishii"},"change_message_id":"62bd39d437728a3611cfa88b9e2996adff2a8c06","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"  \"level\": \"info\","},{"line_number":3,"context_line":"  \"message\": \"Message sample for info level.\""},{"line_number":4,"context_line":"}"}],"source_content_type":"application/json","patch_set":21,"id":"1ac06dbe_3eba106f","line":4,"in_reply_to":"1ac06dbe_f6aa8a6f","updated":"2016-08-22 05:11:49.000000000","message":"Done. I removed these sample files.","commit_id":"370d99e032bb124b1f3e9a6740debadf9e01e2a1"}]}
